librbd: Initializing member variables

Fixes the coverity issues:

** 1351727 Uninitialized scalar field
CID 1351727 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_state is not initialized in
this constructor nor in any functions that it calls.

** 1351728 Uninitialized scalar field
CID 1351728 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_state is not initialized in
this constructor nor in any functions that it calls.

** 1351733 Uninitialized scalar field
CID 1351733 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member snap_id is not initialized in
this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

Merge pull request #16862 from scienceluo/wip-luo-check-fix-branch

common/cmdparse.cc: remove unused variable 'argnum' in dump_cmd_to_json()

Reviewed-by: Jos Collin <jcollin@redhat.com>

Common: remove variable 'argnum' that is modified but its new value is never used.

Signed-off-by: Luo Kexue <luo.kexue@zte.com.cn>

Merge pull request #16847 from amitkumar50/cov-1054870

rgw: Initialize of member variable admin_specified in RGWUserAdminOpState

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16822 from liewegas/wip-20849

os/bluestore: _do_remove: dirty shard individually as each blob is unshared

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #16844 from xiexingguo/wip-bluestore-core

os/bluestore: default journal media to store media if bluefs is disabled

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #14053 from jdurgin/wip-19191

osd/PG: reset the missing set when restarting backfill

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16837 from xiexingguo/wip-still-more-class-fixes

crush: more class fixes

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16838 from xiexingguo/wip-fix-purge

mon/OSDMonitor: sanity check osd before performing 'osd purge'

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16832 from liewegas/wip-20915

rpm,deb: fix ceph-volume

Reviewed-by: Nathan Cutler <ncutler@suse.com>

rgw: Initilzation of admin_specified

Fixes the coverity issue:

** 1054870 Uninitialized scalar field
CID 1054870 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member admin_specified is not
initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

os/bluestore: _do_remove: dirty shard individually as each blob is unshared

Two problems with old code:

1- dirty_shard range is inclusive, so we might dirty the shard after b_end
2- we might unshare blobs in two shards with an unloaded shard in between,
which would mean dirtying a shard that isn't loaded.

Fix by ensuring the shard for each unshared blob is dirty individually.

Fixes: http://tracker.ceph.com/issues/20849
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #16849 from liewegas/wip-jewel-x

qa/suites/upgarde/jewel-x/parallel: more whitelisting

qa/suites/upgarde/jewel-x/parallel: more whitelisting

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #16830 from liewegas/wip-jewel-x

upgrade/jewel-x: a few fixes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

qa/suites/upgrade/jewel-x/parallel: more whitelisting

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/upgrade/*-x/parallel: whitelist more stuff

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/upgrade/*/parallel: disable POOL_APP_NOT_ENABLED

There is some other random workload running (that creates pools)
while we upgrade and wait for healthy.  Just disable the warning
for these tests.

Signed-off-by: Sage Weil <sage@redhat.com>

mon: add mon_warn_on_pool_no_app option

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/upgrade/jewel-x/parallel: whitelist OSD_DOWN

We restart OSDs during the upgrade.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: use static mgr commands if none defined yet

During upgrade, we may get a command (like 'pg dump') before we
pass our first post-upgrade paxos round embedding the static mgr
commands.  Until then, use the static mgr commands (that's what
we're proposing anyway).

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: default journal media to store media if bluefs is disabled

So we won't prevent bluestore-without-bluefs backed OSDs from booting:
0> 2017-08-06 18:28:07.431316 7ffa1c95fd00 -1 /home/xxg/build/ceph-dev/src/os/bluestore/BlueStore.cc: In function
'virtual bool BlueStore::is_journal_rotational()' thread 7ffa1c95fd00 time 2017-08-06 18:28:07.428503
/home/xxg/build/ceph-dev/src/os/bluestore/BlueStore.cc: 4401: FAILED assert(bluefs)

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #16780 from amitkumar50/cov-1414521

libradosstriper: Initialize member variable m_writeRc in WriteCompletionData

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16781 from amitkumar50/cov-1414516

msg: Initialize member variables in Infiniband

Reviewed-by: Jos Collin <jcollin@redhat.com>

msg: Initilization of uninitialized class Infiniband members

Fixes coverity issues:

1414516 Uninitialized pointer field
2. uninit_member: Non-static class member max_send_wr is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member max_recv_wr is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member max_sge is not initialized in this constructor nor in any functions that it calls.
8. uninit_member: Non-static class member ib_physical_port is not initialized in this constructor nor in any functions that it calls.
10. uninit_member: Non-static class member memory_manager is not initialized in this constructor nor in any functions that it calls.
12. uninit_member: Non-static class member srq is not initialized in this constructor nor in any functions that it calls.
14. uninit_member: Non-static class member device is not initialized in this constructor nor in any functions that it calls.
CID 1414516 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
16. uninit_member: Non-static class member pd is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

Merge pull request #16662 from ivancich/wip-dmclock-options-doc

doc: op queue and mclock related options

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16824 from liewegas/wip-more-scrub-time

qa/tasks/ceph: wait longer for scrub

Merge pull request #16841 from liewegas/wip-debug-ceph

qa/tasks/ceph: debug osd setup

Merge pull request #16633 from dillaman/wip-bootstrap-rbd-mirror

mon: added bootstrap-rbd auth profile

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16704 from dillaman/wip-20644

rbd-mirror: assertion failure during pool replayer shut down

Reviewed-by: Venky Shankar <vshankar@redhat.com>

qa/tasks/ceph: debug osd setup

I've seen a couple rbd runs that seem to skip the next block :/

Signed-off-by: Sage Weil <sage@redhat.com>

ceph.spec.in: ceph_volume but not ceph_volume_client in ceph-base

Fixes: http://tracker.ceph.com/issues/20915
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #16784 from amitkumar50/cov-1244200

test: Initialize pointer msg in MonClientHelper

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16839 from amitkumar50/cov-messages-3

messages: Initialize member variables

Reviewed-by: Jos Collin <jcollin@redhat.com>

messages: Initializing variables various classes

Fixes the coverity Issues:

** 1019615 Uninitialized scalar field
2. uninit_member: Non-static class member service_type is not initialized
 in this constructor nor in any functions that it calls.
CID 1019615 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member service_op is not initialized
 in this constructor nor in any functions that it calls.

** 1019618 Uninitialized scalar field
2. uninit_member: Non-static class member op is not initialized in this
 constructor nor in any functions that it calls.
4. uninit_member: Non-static class member cookie is not initialized in
 this constructor nor in any functions that it calls.
CID 1019618 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member last_committed is not initialized
 in this constructor nor in any functions that it calls.

** 1019620 Uninitialized scalar field
2. uninit_member: Non-static class member epoch is not initialized in this
 constructor nor in any functions that it calls.
CID 1019620 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member request_ack is not initialized
in this constructor nor in any functions that it calls.

** 1019621 Uninitialized scalar field
2. uninit_member: Non-static class member epoch is not initialized in this
constructor nor in any functions that it calls.
CID 1019621 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member round is not initialized in this
constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com

Merge pull request #16819 from amitkumar50/cov-messages-1

messages: Initialize member variables

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

messages: Initializing member variables of module messages

Fixes coverity Issue:

CID 717307 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
CID 717308 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member query_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717310 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
CID 717311 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
CID 717312 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717313 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member query_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717314 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717315 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717316 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717317 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member min_epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member repair is not initialized in this constructor nor in any functions that it calls.
CID 717318 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member deep is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member acks_wanted is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member old_exists is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member old_size is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member first is not initialized in this constructor nor in any functions that it calls.
CID 717319 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member complete is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member ack_type is not initialized in this constructor nor in any functions that it calls.
CID 717320 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member result is not initialized in this constructor nor in any functions that it calls.
CID 717321 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls
uninit_member: Non-static class member pool is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member auid is not initialized in this constructor nor in any functions that it calls.
CID 717322 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member crush_rule is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member replyCode is not initialized in this constructor nor in any functions that it calls.
CID 717323 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

Merge pull request #16785 from amitkumar50/cov-1274326

test: Initialize pointer variables in TestMemIoCtxImpl

Reviewed-by: Jos Collin <jcollin@redhat.com>

rados: Initializing uninitialized pointer variables

Fixes the coverity issue:

1274326 Uninitialized pointer field
2. uninit_member: Non-static class member m_client is not initialized in
this constructor nor in any functions that it calls.
CID 1274326 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
4. uninit_member: Non-static class member m_pool is not initialized in
this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

mon/OSDMonitor: sanity check osd before performing 'osd purge'

This will pervent OSDMonitor from crashing on purging a very large
non-existent osd id as below:

osd e11 prepare_command_osd_purge purging osd.8
    -1> 2017-08-05 18:59:44.994319 7f6076968700 10 mon.a@0(leader).osd e11 prepare_command_osd_destroy osd.8 does not exist.
     0> 2017-08-05 18:59:45.002309 7f6076968700 -1 /home/xxg/build/ceph-dev/src/osd/OSDMap.h: In function 'int OSDMap::get_state(int) const'
 thread 7f6076968700 time 2017-08-05 18:59:44.994336
/home/xxg/build/ceph-dev/src/osd/OSDMap.h: 690: FAILED assert(o < max_osd)

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

crush: automatically kill dead classes

If a class is no more referenced by any devices or crush rules,
it shall be considered as dead.

This patch makes Ceph automatically recycles those dead classes,
so user does not to explicitly call 'class rm', which is unsafe
and annoying.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

crush: remove 'class rm' command

The current version is broken. E.g., it should only remove a class
which is never referenced by any device.

Since we now create new classes automatically, we shall automatically
recycle dead classes too. So this command is definitely unuseful.
(Actually it is weird that we keep 'class rm' without keeping the
 corresponding 'class create' command).

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

crush: do not automatically recycle class for 'rm-device-class'

This will prevent the current crush rule from referencing a non-existent
shadow tree and hence avoid a coredump such as below:

 0> 2017-08-05 09:54:19.943349 7f73887d6700 -1 /clove/vm/xxg/rpm/ceph/rpmbuild/BUILD/ceph-12.1.2.1/src/crush/CrushWrapper.cc: In function 'int CrushWrapper::get_rule_weight_osd_map(unsigned
 int, std::map<int, float>*)' thread 7f73887d6700 time 2017-08-05 09:54:19.941291
/clove/vm/xxg/rpm/ceph/rpmbuild/BUILD/ceph-12.1.2.1/src/crush/CrushWrapper.cc: 1631: FAILED assert(b)

 ceph version 12.1.2.1-11-gd0f812a (d0f812a3a757b319c26794f558b57770663ab324) luminous (rc)
 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x110) [0x7f7398b66ea0]
 2: (CrushWrapper::get_rule_weight_osd_map(unsigned int, std::map<int, float, std::less<int>, std::allocator<std::pair<int const, float> > >*)+0x54e) [0x7f7398daac4e]
 3: (PGMap::get_rule_avail(OSDMap const&, int) const+0x68) [0x7f73989a6428]
 4: (PGMap::get_rules_avail(OSDMap const&, std::map<int, long, std::less<int>, std::allocator<std::pair<int const, long> > >*) const+0x35c) [0x7f73989b748c]
 5: (PGMap::encode_digest(OSDMap const&, ceph::buffer::list&, unsigned long) const+0x16) [0x7f73989b7506]
 6: (DaemonServer::send_report()+0x2a4) [0x7f73989f5474]
 7: (DaemonServer::maybe_ready(int)+0x2f9) [0x7f73989f6129]
 8: (DaemonServer::ms_dispatch(Message*)+0xce) [0x7f73989ff68e]
 9: (DispatchQueue::entry()+0x792) [0x7f7398dd2a22]
 10: (DispatchQueue::DispatchThread::entry()+0xd) [0x7f7398c1429d]
 11: (()+0x7df3) [0x7f739640cdf3]
 12: (clone()+0x6d) [0x7f73954f23ed]

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #16791 from amitkumar50/cov-717285

messages: Initializing member variable in MMDSCacheRejoin

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16783 from amitkumar50/cov-1414515

msg: Remove unused variable perf_counter in RDMAStack

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16810 from amitkumar50/cov-717293

messages: Initialize members in MMDSTableRequest

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge PR #16833 into master

* refs/remotes/upstream/pull/16833/head:
qa: whitelist expected MDS_CLIENT_OLDEST_TID warn
qa: ignore insufficient standby during failover
qa: fix read-only whitelist
mds: MDS_DAMAGED to MDS_DAMAGE
doc: remove duplicate CephFS health check doc

Merge PR #16825 into master

* refs/remotes/upstream/pull/16825/head:
Changing 'int const' to 'const int'

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16751 into master

* refs/remotes/upstream/pull/16751/head:
mds: Added NULL check before dereference

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16750 into master

* refs/remotes/upstream/pull/16750/head:
client: Added NULL check before dereference

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16725 into master

* refs/remotes/upstream/pull/16725/head:
mds: Removing unused variables from StrayManager

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16671 into master

* refs/remotes/upstream/pull/16671/head:
Client: Add function "get_default_data_pool_name" for java client

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #16570 into master

* refs/remotes/upstream/pull/16570/head:
mds: clean up obsolete declarations/headers

Reviewed-by: Zheng Yan <zyan@redhat.com>

qa: whitelist expected MDS_CLIENT_OLDEST_TID warn

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa: ignore insufficient standby during failover

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa: fix read-only whitelist

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Changing 'int const' to 'const int'

As per coding Guidelines 'const int' is recommended over 'int const'
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md

NL.26: Use conventional const notation
Example:
const int x = 7;    // OK
int const y = 9;    // bad

Note
We are well aware that you could claim the "bad" examples more logical than the ones marked "OK", but they also confuse more people, especially novices relying on teaching material using the far more common, conventional OK style.
As ever, remember that the aim of these naming and layout rules is consistency and that aesthetics vary immensely.

Enforcement
Flag const used as a suffix for a type.

Signed-off-by: Amit Kumar amitkuma@redhat.com

Merge PR #16761 into master

* refs/remotes/upstream/pull/16761/head:
doc/cephfs: Document ceph auth fs
mon/AuthMonitor: Add special syntax for cephfs

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #16811 from amitkumar50/cov-717296

messages: Initializing uninitialized members MMonGetVersion

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

mds: MDS_DAMAGED to MDS_DAMAGE

We had both and MDS_DAMAGE looks to be the right/intended one.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

debian: include ceph-volume python

Be careful not to grab ceph_volume_client.py

Signed-off-by: Sage Weil <sage@redhat.com>

doc: remove duplicate CephFS health check doc

These are documented in doc/cephfs/health-messages.rst.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge branch 'wip-qa-rbd-health' of git://github.com/dillaman/ceph

# Conflicts:
# qa/tasks/ceph.py

Merge pull request #16815 from amitkumar50/cov-717299

messages: Initializing uninitialized members MMonProbe

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16817 from amitkumar50/cov-messages-branch

messages: Initializing uninitialized members module messages

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16816 from amitkumar50/cov-717300

messages: Initializing uninitialized members MOSDAlive

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16814 from amitkumar50/cov-717298

messages: Initializing uninitialized members MMonPaxos

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16813 from amitkumar50/cov-717297

messages: Initializing uninitialized members MMonGetVersionReply

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16803 from dmick/master

common/buffer: off-by-one error in max iov length blocking

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16675 from Jeegn-Chen/skip-err-entries

osd/PGLog: skip ERROR entires in _merge_object_divergent_entries

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #16744 from joscollin/wip-osd-warning

osd: silence warning from -Wint-in-bool-context

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16820 from liewegas/wip-more-whitelist

qa/suites/rados: a bit more whitelisting

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

doc: op queue and mclock related options

Additionally makes sure when unexpected values are provided for config
options osd_op_queue or osd_op_queue_cut_off that the default values
are assigned.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #16614 from neha-ojha/recovery_sleep_hybrid

osd: Check whether journal is rotational or not

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16809 from jdurgin/wip-20904

osd/PG: fix lost unfound + delete when there are no missing objects

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16812 from xiexingguo/wip-class-startup

osd/OSD: tolerate any 'set-device-class' error on OSD startup

Reviewed-by: Sage Weil <sage@redhat.com>

osd: use recovery sleep hdd for ssd store and hdd journal case

Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge pull request #16827 from liewegas/wip-more-more-more

qa/suites/rados/basic/tasks/rados_python: POOL_APP_NOT_ENABLED

qa/suites/rados/basic/tasks/rados_python: POOL_APP_NOT_ENABLED

Signed-off-by: Sage Weil <sage@redhat.com>

messages: Initializing uninitialized members module messages

Fixes coverity Issue:

** 2. uninit_member: Non-static class member flags is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
CID 717301 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member failed_for is not initialized in this constructor nor in any functions that it calls.

2. uninit_member: Non-static class member oldest_map is not initialized in this constructor nor in any functions that it calls.
CID 717302 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member newest_map is not initialized in this constructor nor in any functions that it calls.

2. uninit_member: Non-static class member client_inc is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member osdmap_epoch is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member flags is not initialized in this constructor nor in any functions that it calls.
8. uninit_member: Non-static class member retry_attempt is not initialized in this constructor nor in any functions that it calls.
CID 717303 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
10. uninit_member: Non-static class member features is not initialized in this constructor nor in any functions that it calls.

2. uninit_member: Non-static class member flags is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member user_version is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member osdmap_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717304 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
8. uninit_member: Non-static class member retry_attempt is not initialized in this constructor nor in any functions that it calls.

2. uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717305 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member query_epoch is not initialized in this constructor nor in any functions that it calls.

CID 717306 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

Merge pull request #16724 from amitkumar50/cov-1403249

librbd: Uninitialized variable used handle_refresh()

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16742 from scienceluo/wip-luo-coverity-fix-branch

test/librbd/fsx: Add break in case OP_WRITESAME and OP_COMPARE_AND_WRITE

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16729 from amitkumar50/cov-1402141

rbd: Drop unused member variable reopen in C_OpenComplete

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

qa/tasks/ceph: wait longer for scrub

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #16769 from liewegas/wip-20295-b

os/bluestore: allow multiple DeferredBatches in flight at once

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #16787 from liewegas/wip-bluestore-docs

doc/release-notes: fix bluestore links

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

doc/cephfs: Document ceph auth fs

Change the CephFS auth caps documentation to reflect the new ceph auth
fs command.

Signed-off-by: Douglas Fuller <dfuller@redhat.com>

Merge pull request #16632 from ceph/wip-volume

ceph-volume: initial take on ceph-volume CLI tool

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Andrew Schoen <aschoen@redhat.com>

messages: Initializing uninitialized members MOSDAlive

Fixes coverity Issue:

** 717300 Uninitialized scalar field
CID 717300 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member want is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

messages: Initializing uninitialized members MMonProbe

Fixes coverity Issue:

** 717299 Uninitialized scalar field
2. uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
   4. uninit_member: Non-static class member paxos_first_version is not initialized in this constructor nor in any functions that it calls.
    6. uninit_member: Non-static class member paxos_last_version is not initialized in this constructor nor in any functions that it calls.
    8. uninit_member: Non-static class member has_ever_joined is not initialized in this constructor nor in any functions that it calls.

CID 717299 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
10. uninit_member: Non-static class member required_features is not initialized in this constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com

messages: Initializing uninitialized members MMonPaxos

Fixes coverity Issue:

2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
   4. uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
    6. uninit_member: Non-static class member first_committed is not initialized in this constructor nor in any functions that it calls.
    8. uninit_member: Non-static class member last_committed is not initialized in this constructor nor in any functions that it calls.
    10. uninit_member: Non-static class member pn_from is not initialized in this constructor nor in any functions that it calls.
    12. uninit_member: Non-static class member pn is not initialized in this constructor nor in any functions that it calls.
    14. uninit_member: Non-static class member uncommitted_pn is not initialized in this constructor nor in any functions that it calls.

CID 717298 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
16. uninit_member: Non-static class member latest_version is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

ceph-volume lvm trigger should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm prepare should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm create should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm activate should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: decorators should call the wrapped func

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd script should handle type-data format as argument

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm add the actual trigger subcommand handler

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm: add a trigger sub-command to parent parser

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests update argument parsing for systemd

Signed-off-by: Alfredo Deza <adeza@redhat.com>