osd: downgrade (ok) PG scrub messages to debug

Otherwise someone watching the log at INFO level gets
pelted with potentially millions of log messages
while the system is scrubbing.

Fixes: http://tracker.ceph.com/issues/20947
Signed-off-by: John Spray <john.spray@redhat.com>

mon: downgrade "scrub ok" message to debug.

This hides lines like:
[INF]  scrub ok on 0,1,2: ScrubResult(keys {pgmap_pg=13} crc {pgmap_pg=2458062599})

from the normal cluster log views.

Fixes: http://tracker.ceph.com/issues/20947
Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #16791 from amitkumar50/cov-717285

messages: Initializing member variable in MMDSCacheRejoin

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16783 from amitkumar50/cov-1414515

msg: Remove unused variable perf_counter in RDMAStack

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #16810 from amitkumar50/cov-717293

messages: Initialize members in MMDSTableRequest

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge PR #16833 into master

* refs/remotes/upstream/pull/16833/head:
qa: whitelist expected MDS_CLIENT_OLDEST_TID warn
qa: ignore insufficient standby during failover
qa: fix read-only whitelist
mds: MDS_DAMAGED to MDS_DAMAGE
doc: remove duplicate CephFS health check doc

Merge PR #16825 into master

* refs/remotes/upstream/pull/16825/head:
Changing 'int const' to 'const int'

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16751 into master

* refs/remotes/upstream/pull/16751/head:
mds: Added NULL check before dereference

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16750 into master

* refs/remotes/upstream/pull/16750/head:
client: Added NULL check before dereference

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16725 into master

* refs/remotes/upstream/pull/16725/head:
mds: Removing unused variables from StrayManager

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #16671 into master

* refs/remotes/upstream/pull/16671/head:
Client: Add function "get_default_data_pool_name" for java client

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #16570 into master

* refs/remotes/upstream/pull/16570/head:
mds: clean up obsolete declarations/headers

Reviewed-by: Zheng Yan <zyan@redhat.com>

qa: whitelist expected MDS_CLIENT_OLDEST_TID warn

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa: ignore insufficient standby during failover

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

qa: fix read-only whitelist

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Changing 'int const' to 'const int'

As per coding Guidelines 'const int' is recommended over 'int const'
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md

NL.26: Use conventional const notation
Example:
const int x = 7;    // OK
int const y = 9;    // bad

Note
We are well aware that you could claim the "bad" examples more logical than the ones marked "OK", but they also confuse more people, especially novices relying on teaching material using the far more common, conventional OK style.
As ever, remember that the aim of these naming and layout rules is consistency and that aesthetics vary immensely.

Enforcement
Flag const used as a suffix for a type.

Signed-off-by: Amit Kumar amitkuma@redhat.com

Merge PR #16761 into master

* refs/remotes/upstream/pull/16761/head:
doc/cephfs: Document ceph auth fs
mon/AuthMonitor: Add special syntax for cephfs

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #16811 from amitkumar50/cov-717296

messages: Initializing uninitialized members MMonGetVersion

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

mds: MDS_DAMAGED to MDS_DAMAGE

We had both and MDS_DAMAGE looks to be the right/intended one.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

doc: remove duplicate CephFS health check doc

These are documented in doc/cephfs/health-messages.rst.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge branch 'wip-qa-rbd-health' of git://github.com/dillaman/ceph

# Conflicts:
# qa/tasks/ceph.py

Merge pull request #16815 from amitkumar50/cov-717299

messages: Initializing uninitialized members MMonProbe

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16817 from amitkumar50/cov-messages-branch

messages: Initializing uninitialized members module messages

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16816 from amitkumar50/cov-717300

messages: Initializing uninitialized members MOSDAlive

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16814 from amitkumar50/cov-717298

messages: Initializing uninitialized members MMonPaxos

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16813 from amitkumar50/cov-717297

messages: Initializing uninitialized members MMonGetVersionReply

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16803 from dmick/master

common/buffer: off-by-one error in max iov length blocking

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #16675 from Jeegn-Chen/skip-err-entries

osd/PGLog: skip ERROR entires in _merge_object_divergent_entries

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #16744 from joscollin/wip-osd-warning

osd: silence warning from -Wint-in-bool-context

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #16820 from liewegas/wip-more-whitelist

qa/suites/rados: a bit more whitelisting

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #16614 from neha-ojha/recovery_sleep_hybrid

osd: Check whether journal is rotational or not

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16809 from jdurgin/wip-20904

osd/PG: fix lost unfound + delete when there are no missing objects

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #16812 from xiexingguo/wip-class-startup

osd/OSD: tolerate any 'set-device-class' error on OSD startup

Reviewed-by: Sage Weil <sage@redhat.com>

osd: use recovery sleep hdd for ssd store and hdd journal case

Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge pull request #16827 from liewegas/wip-more-more-more

qa/suites/rados/basic/tasks/rados_python: POOL_APP_NOT_ENABLED

qa/suites/rados/basic/tasks/rados_python: POOL_APP_NOT_ENABLED

Signed-off-by: Sage Weil <sage@redhat.com>

messages: Initializing uninitialized members module messages

Fixes coverity Issue:

** 2. uninit_member: Non-static class member flags is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
CID 717301 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member failed_for is not initialized in this constructor nor in any functions that it calls.

2. uninit_member: Non-static class member oldest_map is not initialized in this constructor nor in any functions that it calls.
CID 717302 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member newest_map is not initialized in this constructor nor in any functions that it calls.

2. uninit_member: Non-static class member client_inc is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member osdmap_epoch is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member flags is not initialized in this constructor nor in any functions that it calls.
8. uninit_member: Non-static class member retry_attempt is not initialized in this constructor nor in any functions that it calls.
CID 717303 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
10. uninit_member: Non-static class member features is not initialized in this constructor nor in any functions that it calls.

2. uninit_member: Non-static class member flags is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member user_version is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member osdmap_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717304 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
8. uninit_member: Non-static class member retry_attempt is not initialized in this constructor nor in any functions that it calls.

2. uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls.
CID 717305 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
6. uninit_member: Non-static class member query_epoch is not initialized in this constructor nor in any functions that it calls.

CID 717306 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

Merge pull request #16724 from amitkumar50/cov-1403249

librbd: Uninitialized variable used handle_refresh()

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16742 from scienceluo/wip-luo-coverity-fix-branch

test/librbd/fsx: Add break in case OP_WRITESAME and OP_COMPARE_AND_WRITE

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16729 from amitkumar50/cov-1402141

rbd: Drop unused member variable reopen in C_OpenComplete

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #16769 from liewegas/wip-20295-b

os/bluestore: allow multiple DeferredBatches in flight at once

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #16787 from liewegas/wip-bluestore-docs

doc/release-notes: fix bluestore links

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

doc/cephfs: Document ceph auth fs

Change the CephFS auth caps documentation to reflect the new ceph auth
fs command.

Signed-off-by: Douglas Fuller <dfuller@redhat.com>

Merge pull request #16632 from ceph/wip-volume

ceph-volume: initial take on ceph-volume CLI tool

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Andrew Schoen <aschoen@redhat.com>

messages: Initializing uninitialized members MOSDAlive

Fixes coverity Issue:

** 717300 Uninitialized scalar field
CID 717300 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member want is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

messages: Initializing uninitialized members MMonProbe

Fixes coverity Issue:

** 717299 Uninitialized scalar field
2. uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
   4. uninit_member: Non-static class member paxos_first_version is not initialized in this constructor nor in any functions that it calls.
    6. uninit_member: Non-static class member paxos_last_version is not initialized in this constructor nor in any functions that it calls.
    8. uninit_member: Non-static class member has_ever_joined is not initialized in this constructor nor in any functions that it calls.

CID 717299 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
10. uninit_member: Non-static class member required_features is not initialized in this constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com

messages: Initializing uninitialized members MMonPaxos

Fixes coverity Issue:

2. uninit_member: Non-static class member epoch is not initialized in this constructor nor in any functions that it calls.
   4. uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
    6. uninit_member: Non-static class member first_committed is not initialized in this constructor nor in any functions that it calls.
    8. uninit_member: Non-static class member last_committed is not initialized in this constructor nor in any functions that it calls.
    10. uninit_member: Non-static class member pn_from is not initialized in this constructor nor in any functions that it calls.
    12. uninit_member: Non-static class member pn is not initialized in this constructor nor in any functions that it calls.
    14. uninit_member: Non-static class member uncommitted_pn is not initialized in this constructor nor in any functions that it calls.

CID 717298 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
16. uninit_member: Non-static class member latest_version is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

ceph-volume lvm trigger should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm prepare should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm create should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm activate should check for root

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: decorators should call the wrapped func

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd script should handle type-data format as argument

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm add the actual trigger subcommand handler

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm: add a trigger sub-command to parent parser

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests update argument parsing for systemd

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests add an lvm trigger for the systemd argument parsing

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume remove activate utilities, not needed with 'osd new'

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm.activate remove unused import for activate utils

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd should retry several times to activate a device

Allows environment variables to tweak the retries and intervals,
defaulting to 30 tries at 5 second intervals.

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices chown the journal when activating

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd script should pass pre-configured log args

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: prevent missing conf values for logging config

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd: add helpers for the ceph-volume systemd unit

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util prepare should pass -i to consume stdin

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm consume the JSON secrets for preparing

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm remove the creation of the osd so early in the prepare process

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm: activate should not use the bootstrap-osd to auth add the keyring

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util: use osd new for creating osds

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: process: allow stdin to be used

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: slice args for main and subcommands differently

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices.lvm add create module for the sub-command support

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices.lvm add the create sub-command

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices.lvm create a common module for sharing parsers

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices: update coverage comments

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add lvm api tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: update coverage comments

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices.lvm: update print and import for py3 support

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.main: update imports for py3 support

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: create capture fixture for tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: devices: update imports to support py3

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: py3 support fixes with print

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.api: add parse_tags for VolumeGroup, cleanup json loads

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: process: decode non-str streams from subprocess

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm.prepare: print help and return before parsing args if no args

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: lvm: print help and return before parsing args if no args

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tets: use the new validation in conf

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add tests for lvm devices and API

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: configuration: introduce lazy validation in configuration

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add tests for the system utility

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util: remove ceph_user option, it is the default

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: util: use the chown argument for mkdir_p

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: systemd: ensure osd_id is digit-like

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add systemd tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add tests for main/cli handling

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add tests for decorators

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add configuration tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: changes to sys.argv handling for better testing

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: tests: add terminal tests

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: main: if no args are passed mention the --help usage, print some information

Signed-off-by: Alfredo Deza <adeza@redhat.com>