rgw: rgw_add_to_iam_env use string_view

This commit unites the various add_to_iam_env implementations and uses the
std::string_view variant. Also updated call sites which check empty key values
since that is done in the function

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: policy: refactor has_conditional

Basically created has_conditional and has_partial_conditional to check for
exact/partial matches for conditionals and modified exisiting call sites.
has_key is now a function template that passes on the test string to any given
function as the second argument.

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: rgw_op update has_conditional calls with new has_key

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw_op: drop the forward_as_tuple variant of rgw_add_to_iam_environment

We don't have any places in the code where we can std::move both the
key and value to construct the map, so dropping this code.

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

doc: rgw add the newly supported bucket policy conditionals

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: policy: add_to_iam_env allows empty values

Since null conditional just allows for presence of a header it makes
sense to allow empty values as well for checking presence of a header

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: Policy: add support for PutObject with grants conditionals

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: policy: support for conditionals in copy obj

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: policy: add_to_iam_env now supports char* and checks for null

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: policy : put object support for x-amz-metadata-directive

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: policy: support for acl grants cond. in bucket acls as well

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw_op: use has_conditional only when iam_policy exists

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: support for s3 grants conditional

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: rgw_add_to_iam_env has a r-value reference function overload

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: drop requestobject tag from gperf and keywords

Since these are dropped at compile time anyway

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: kill iam_action as a RGWOp member

since we only use it for verify_permissions, let us kill iam_action as
member of RGWOp class

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: policy: support GetObjTags to use policy conditionals

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

drop eval_existing_objtags

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

s3: add tags for ExistingObjectTag IAM conditional only if necessary

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw_iam_policy: add has_conditional to Policy

does a linear search of conditional keys and returns if present. Useful
where conditionals specified need an often expensive lookup to add to
the env.

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw_iam_tags: split into smaller function

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: add support for ExistingObjectTag in DeleteObjectTagging

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: support ExistingObjectTag in GetObjectAcl op

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: split rgw_iam_eval_existing_objtags to seperate functions

one for adding tags to env and the other which calls eval, useful for
Ops where we dont need an eval but need it in the env

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: support for ExistingObjectTag for s3:PubObjectAcl

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: support for ExistingObjectTag for PutObjectTagging operation

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw_op: add a function to eval ExistingObjTag s3:IAM conditional

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw_op: add iam action as RGWOp member

This commit adds iam_action as a member of RGWOp class which allows for
reusing this later when object policies are to be evaluated

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

RGW: IAM: support s3:x-amz-acl conditional for PutACLs

Support string-like s3:x-amz-acl conditional  for PutACL request. We're
still to support lists for this

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: add s3 conditions for PutObject IAM policies

Adding the following s3 conditions for PutObject operation

s3:x-amz-canned-acl (caveat: only strings are supported, we don't
support a list of canned acls yet)
s3:x-amz-copy-source
s3:x-amz-server-side-encryption
s3:x-amz-server-side-encryption-aws-kms-key-id
s3:RequestObjectTag/<key>

A still TODO is to tackle is s3:RequestObjectTagKeys
which supports a list as an argument and
s3:x-amz-grant-<permission> (which should be easier to support)

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge PR #19803 into master

* refs/pull/19803/head:
mds: get rid of unnecessary if condition

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #19837 into master

* refs/pull/19837/head:
client: avoid recursive lock in ll_get_vino

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: huanwen ren <ren.huanwen@zte.com.cn>

Merge PR #19860 into master

* refs/pull/19860/head:
cephfs-journal-tool: add usage help info for header set <field>
mds: add error log info
cephfs-journal-tool: add "set pool_id" option

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #19891 into master

* refs/pull/19891/head:
mds: handle 'inode gets queued for recovery multiple times'
mds: use elist to track recover queue items

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #19911 into master

* refs/pull/19911/head:
cephfs: Switch MIN/MAX for std::min/max and use intarith templates

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #19876 from theanalyst/build/do-cmake-args

build: do_cmake: allow ARGS to be overridden

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19433 from liewegas/wip-pg-removal

osd: put pg removal in op_wq

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

osd/PrimaryLogPG: do on_shutdown on removal

This cleans up our reservations and misc other state in OSDService that
needs to be cleaned up.

Signed-off-by: Sage Weil <sage@redhat.com>

osd: track deleted pools' pg_nums for calculating split

This is needed to determine (quickly) whether PGs have split.  Calling
get_pg_num() on the latest map does not work when the pool has been
deleted from that map.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #19850 from dzafman/wip-calc-stats

osd/PG: re-write of _update_calc_stats and improve pg degraded state

Fixes: http://tracker.ceph.com/issues/20059
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

tests: recovery-unfound-found test needs to account for correct misplaced calculations

The test expected HEALTH_OK when in a state with misplaced objects therefore HEALTH_WARN

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #19613 from qrGitHub/wip-rgw-optimize-bucketLCPrepare

rgw: optimize function bucket_lc_prepare

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #19878 from cbodley/wip-rgw-get-omap-keys-cr

rgw: fix handling of ENOENT in RGWRadosGetOmapKeysCR

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #19897 from cbodley/wip-rgw-put-system-obj

rgw: rgw_put_system_obj takes bufferlist

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Merge pull request #19945 from tchaikov/wip-deprecated-in-cxx17

librbd,librados: do not include stdbool.h in C++ headers

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #19261 from dillaman/wip-22286

mgr: disconnect unregistered service daemon when report received

Reviewed-By: Kefu Chai <kchai@redhat.com>

Merge pull request #19942 from shinobu-x/wip-sk-minmax-ms_async_op_threads

common: Add min/max of ms_async_op_threads

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #19397 from xxhdx1985126/master

mon: update PaxosService::cached_first_committed in PaxosService::maybe_trim()

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #19822 from trociny/wip-ggate-ceph-globals

rbd-ggate: fix parsing ceph global options

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #19673 from zouaiguo/wip_erase_code

mon/OSDMonitor.cc : set erasure-code-profile to "" when create replicated pools.

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19896 from tchaikov/wip-vive-cxx-17

msg/simple: s/ceph::size/std::size/

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #19870 from liewegas/wip-strip-ceph-base

debian/rules: strip ceph-base libraries

Reviewed-By: Kefu Chai <kchai@redhat.com>

Merge pull request #18755 from aclamk/wip-reverted-approx-size

osd/PG: revert approx size

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #18191 from hjwsm1989/osd-mark-down

qa/standalone/osd/osd-mark-down: create pool to get updated osdmap faster

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19877 from adamemerson/wip-dencish

denc cleanups and other fixes

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Kefu Chai <kchai@redhat.com>

test: Verify stat calculations during backfill

Signed-off-by: David Zafman <dzafman@redhat.com>

test: Verify stat calculations during recovery

Signed-off-by: David Zafman <dzafman@redhat.com>

ceph-helpers.sh: Add flush_pg_stats() to wait_for_clean() to make it reliable

osd-scrub-repair.sh: Fixes for omap keys landing on different OSDs due to flush

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Don't start recovery for missing until active pg state set

I was seeing recovery hang when it is started before _activate_committed()
The state machine passes into "Active" but this transitions to activating
pg state and after commmitted into "active" pg state.

Signed-off-by: David Zafman <dzafman@redhat.com>

qa: Ignore degraded PGs when injecting random eio errors

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Improve the way insufficient targets is handled to be compatible with EC

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Improve pg degraded state setting based on _update_calc_stats() degraded count

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #19946 from liewegas/wip-22677

qa/workunits/rados/test_rados_tool: fix stray |, race

osd: Handling when recovery sources have missing

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Base pg degraded state on num_degraded_objects

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Rewrite _update_calc_stats() to make it cleaner and more accurate

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: cleanup: Remove unused const vars

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: cleanup: Fix log message

Signed-off-by: David Zafman <dzafman@redhat.com>

qa/workunits/rados/test_rados_tool: remove stray |, fix race

Fixes: http://tracker.ceph.com/issues/22676
Signed-off-by: Sage Weil <sage@redhat.com>

librbd,librados: do not include stdbool.h in C++ headers

stdbool.h is offered to provide C++ keywords for C source file.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #12431 from VictorDenisov/snapshot_rename

rbd: group snapshot rename

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

cephfs: Switch MIN/MAX for std::min/max and use intarith templates

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rbd: Add group snapshot rename commands

Signed-off-by: Victor Denisov <denisovenator@gmail.com>

librbd: Add group snap rename method

Signed-off-by: Victor Denisov <denisovenator@gmail.com>

qa/workunits/rados/test_rados_tool.sh: -x

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #19913 from adamemerson/wip-minimax-rados

rados: Prefer templates to macros

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19914 from tchaikov/wip-cmake-check-boost-in-src

cmake: check version of boost in src/boost

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #19926 from batrick/i22527

mon: revert mds metadata argument name change

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #19903 from dillaman/wip-librbd-op-features

librbd: add preliminary support for new operation feature bit

Reviewed-by: Mykola Golub <mgolub@suse.com>

common: Add min/max of ms_async_op_threads

Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>

Merge pull request #19793 from badone/wip-blocking-deep-scrub

ceph.in: Add blocking mode for scrub and deep-scrub

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #19910 from jdurgin/wip-21897

config: lower default omap entries recovered at once

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #19894 into master

* refs/pull/19894/head:
cmake: link against ceph-common instead of common

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #19920 into master

* refs/pull/19920/head:
client: fix cap revoke race
client: release revoking Fc after invalidate cache

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #19885 into master

* refs/pull/19885/head:
qa: increase osd count for ec testing
qa: add missing openstack configs

Reviewed-by: Sage Weil <sage@redhat.com>

rgw: RGWRados::put_system_obj takes const bufferlist

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rados: Switch MIN/MAX for std::min/max and use intarith templates

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #19900 from dillaman/wip-rbd-lock-list

rbd: adjusted "lock list" JSON and XML formatted output

Reviewed-by: Mykola Golub <mgolub@suse.com>

rgw: rgw_put_system_obj takes bufferlist

all callers were converting from bufferlist to const char*, then
RGWRados::put_system_obj() copied that back into a new bufferlist

Signed-off-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #19933 from qrGitHub/wip-rgw-useless-line4

rgw: drop redundant RGW_OP_STAT_OBJ check

Reviewed-by: Casey Bodley <cbodley@redhat.com>

rbd: adjusted "lock list" JSON and XML formatted output

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: operations should return -EROFS if disabled

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: retrieve the op features on image refresh

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: track new operation features within image

This will initially be utilized to restrict older clients from
performing operations against an image if (1) it doesn't
support the new feature bit, or (2) doesn't support the specific
enabled op feature.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

include: Add templates along side macros in intarith

The macros can be removed later.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw: drop redundant RGW_OP_STAT_OBJ check

Signed-off-by: Bingyin Zhang <zhangbingyin@cloudin.cn>

denc: Clean up tuples even more

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

types: Output of arbitrary std::tuples

Again, using ceph::for_each

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

encoding: Encode/decode of arbitrary tuples

Using ceph::for_each to avoid fiddling with indices everywhere.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

common: Add ceph::for_each for tuples

Expand to pairs, optionals, and variants later.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>