Avoid extra check for clean object

We needn't to check clean object via buffer state, skip the clean object.

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

Merge pull request #1839 from ceph/wip-8338

OSD: verify that client ops are targeted correctly in the current epoch

Reviewed-by: Samuel Just <sam.just@inktank.com>

Merge pull request #1830 from salehe/docfix-1

rados.py: clarify documentation of recent change on write return value

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

Merge pull request #1804 from ceph/wip-8104

Wip 8104

Reviewed-by: Sage Weil <sage@inktank.com>

rados.py: clarify recent change on write return value

Signed-off-by: Mohammad Salehe <salehe+dev@gmail.com>

Merge pull request #1820 from ceph/wip-osd-refs

osd: fix a session ref leak, and an unlikely race

Reviewed-by: Greg Farnum <greg@inktank.com>

doc: Restored glance_api_version=2 setting.

Fixes: #8347
Signed-off-by: John Wilkins <john.wilkins@inktank.com>

Merge remote-tracking branch 'gh/next'

Merge pull request #1823 from dachary/wip-mailmap

mailmap: Sahid Orentino Ferdjaoui affiliation

Reviewed-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@cloudwatt.com>

mailmap: Sahid Orentino Ferdjaoui affiliation

Signed-off-by: Loic Dachary <loic@dachary.org>

Merge pull request #1822 from sahid/master

Ensure autogen.sh to be executed at the top-level

Reviewed-by: Loic Dachary <loic@dachary.org>

Ensure autogen.sh to be executed at the top-level

The commit adds a test to ensure that user executes
'autogen.sh' at the top-level of the directory.

Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@cloudwatt.com>

Merge pull request #1821 from ceph/mds-optracker-fixes

mds: fix Server::submit_mdlog_entry()

mds: fix Server::submit_mdlog_entry()

mdr can be NULL when rolling back slave update

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>

osd: fix narrow session refcount race

The set_priv() call consumes a ref.  Technically the local 's' is not
actually owned by use by the time we get to the con_front set_priv().

Signed-off-by: Sage Weil <sage@inktank.com>

osd: fix session leak in ms_handle_fast_connect

Signed-off-by: Sage Weil <sage@inktank.com>

Merge pull request #1809 from ceph/wip-4354-mds-optracker

MDS OpTracker

Reviewed-by: Sage Weil <sage@inktank.com>

MDS: add admin socket cleanup on shutdown

Signed-off-by: Greg Farnum <greg@inktank.com>

Merge pull request #1817 from ceph/wip-osdmon-pa-wait

OSDMonitor: set next commit in mon primary-affinity reply

Reviewed-by: Sage Weil <sage@inktank.com>

OSDMonitor: set next commit in mon primary-affinity reply

Commit 8c5c55c8b47e ("mon: set next commit in mon command replies")
fixed MMonCommand replies to include the right version, but the
primary-affinity handler was authored before that.  Fix it.

Backport: firefly
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>

Merge pull request #1816 from onlyjob/docs

sample.ceph.conf: minor update

Reviewed-by: Greg Farnum <greg@inktank.com>

sample.ceph.conf: minor update

 * Moved filestore settings above [osd.*] declarations otherwise
   (if uncommented) those settings might be applied only to last
   OSD which is not very obvious.
 * Few options added.

OSD: fix an osdmap_subscribe interface misuse

When calling osdmap_subscribe, you have to pass an epoch newer than the
current map's. _maybe_boot() was not doing this correctly -- we would
fail a check for being *in* the monitor's existing map range, and then
pass along the map prior to the monitor's range. But if we were exactly
one behind, that value would be our current epoch, and the request would
get dropped. So instead, make sure we are not *in contact* with the monitor's
existing map range.

Signed-off-by: Greg Farnum <greg@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>

workunits: provide some output in the dirfrag.sh test

Signed-off-by: Greg Farnum <greg@inktank.com>

Merge pull request #1803 from onlyjob/java-gcj

Java GCJ fixes

Reviewed-by: Greg Farnum <greg@inktank.com>
Acked-by: Noah Watkins <noahwatkins@gmail.com>

osd_types: remove the pool_id argument from (is|check)_new_interval

Signed-off-by: Samuel Just <sam.just@inktank.com>

PG: replace is_split, acting_up_affected with should_restart_peering

This way, we restart peering using the same criteria as
check_new_interval.

Fixes: #8104
Signed-off-by: Samuel Just <sam.just@inktank.com>

osd_types: factor out is_new_interval from check_new_interval

Signed-off-by: Samuel Just <sam.just@inktank.com>

Merge pull request #1806 from ceph/wip-8011

ReplicatedPG: block scrub on blocked object contexts

Reviewed-by: Sage Weil <sage@inktank.com>

doc: Clarified Debian uses sysvinit.

Fixes: #7182
Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added rgw print continue guidance.

Fixes: #7731
Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Minor edit.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added clarifying text to CRUSH add command.

Fixes: #8322
Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Omitted glance_api_version=2 to fix creating images from volumes.

Fixes: #8347

doc: Changed example to use virtio and put key usage into one line.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

Merge pull request #1802 from ceph/wip-mds-misc

Wip mds misc

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #1810 from ceph/wip-fedora

doc: update instructions for RPM distros

Improve Bash completion for various tools

test: fix some templates to match new output code

Signed-off-by: Greg Farnum <greg@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>

doc: update instructions for RPM distros

Fix RPM building instructions: this has been broken since
libs3 was included inline in the ceph repo as a submodule.
"rpmbuild -tb" was concatenating the ceph.spec and
libs3.spec files, resulting in something that didn't work.

Also, the instructions suggested downloading a .tar.gz file
whereas the specfile requires a .tar.bz2 file.

Also, add a convenient yum command line for getting the compile
dependencies on Fedora 20.

Signed-off-by: John Spray <john.spray@inktank.com>

Merge remote-tracking branch 'origin/master' into wip-4354-mds-optracker

Conflicts:
src/mds/Locker.cc
src/osd/OpRequest.cc
src/osd/OpRequest.h

Signed-off-by: Greg Farnum <greg@inktank.com>

mds: lower IO priority of storing backtrace

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>

Merge pull request #1771 from ceph/wip-5021

Wip 5021

Reviewed-by: Sage Weil <sage@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>

Merge pull request #1807 from ceph/wip-mds-flock

mds: reduce verbosity of handle_client_file_{readlock,setlock}

mds: reduce verbosity of handle_client_file_{readlock,setlock}

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>

mds: add a Server::submit_mdlog_entry() to provide event marking

Signed-off-by: Greg Farnum <greg@inktank.com>

OSD: verify that client ops are targeted correctly in the current epoch

We were previously only looking at the epoch the op was sent in, which meant
that if we had dropped responsibility somewhere between send_epoch and our
current epoch, we would queue up the op until a new osdmap came along. If it
never did, we could block all client IO against us...

Fixes: #8338
Signed-off-by: Greg Farnum <greg@inktank.com>

ReplicatedPG: block scrub on blocked object contexts

Fixes: #8011
Backport: firefly
Signed-off-by: Samuel Just <sam.just@inktank.com>

Merge pull request #1779 from ceph/wip-7553

Wip 7553

Reviewed-by: Samuel Just <sam.just@inktank.com>

Locker: mark_event in acquire_locks() when blocking or succeeding

Signed-off-by: Greg Farnum <greg@inktank.com>

Server: mark events when journaling and replying

Signed-off-by: Greg Farnum <greg@inktank.com>

MDCache: mark ops at various finish points

Signed-off-by: Greg Farnum <greg@inktank.com>

MDS: add an OpTracker and use it

Signed-off-by: Greg Farnum <greg@inktank.com>

Mutation: add an MDRequestParams struct and use that when building MDRequests

We now have a single constructor and one path to build MDRequests with.

Signed-off-by: Greg Farnum <greg@inktank.com>

MDS: add stubs for an AdminSocketHook

Signed-off-by: Greg Farnum <greg@inktank.com>

MDCache: pass the causative message to request_start_slave()

We were passing the causative MDS (as an int), but pushing down the
actual Message will help us as we set up an OpTracker.

Signed-off-by: Greg Farnum <greg@inktank.com>

mds: remove a couple leftover declarations of MDRequest

Signed-off-by: Greg Farnum <greg@inktank.com>

doc/release-notes: v0.80.1

Signed-off-by: Sage Weil <sage@inktank.com>

Merge pull request #1799 from ceph/wip-8305

osd: fix op ordering with pool overlay set/removed

Reviewed-by: Samuel Just <sam.just@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

doc: Improvements to qemu installation.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

doc: Added note on Default requiretty for CentOS and others.

Signed-off-by: John Wilkins <john.wilkins@inktank.com>

Merge pull request #1801 from ceph/wip-update-gitignore

Update gitignore entries for master

Reviewed-by: Sage Weil <sage@inktank.com>

Merge pull request #1800 from ceph/wip-da-SCA-20140510

fixes from SCA

Reviewed-by: Sage Weil <sage@inktank.com>

prioritise use of `javac` executable (gcj provides it through alternatives).

 On Debian this fixes FTBFS when gcj-jdk and openjdk-7-jdk are installed at
 the same time because build system will use default `javac` executable
 provided by current JDK through `update-alternatives` instead of blindly
 calling GCJ when it is present.

Signed-off-by: Dmitry Smirnov <onlyjob@member.fsf.org>

pass '-classpath' option (gcj/javah ignores CLASSPATH environment variable).

 This should not affect OpenJDK which understands '-classpath' as well.

 With gcj-jdk we still get FTBFS later:

 ~~~~
    java/native/libcephfs_jni.cc:2878:55: error: invalid conversion from 'const jbyte* {aka const signed char*}' to 'jbyte* {aka signed char*}' [-fpermissive]
                 reinterpret_cast<const jbyte*>(rawAddress));
                                                           ^
    In file included from java/native/libcephfs_jni.cc:27:0:
    /usr/lib/gcc/x86_64-linux-gnu/4.8/include/jni.h:1471:8: error:   initializing argument 4 of 'void _Jv_JNIEnv::SetByteArrayRegion(jbyteArray, jsize, jsize, jbyte*)' [-fpermissive]
       void SetByteArrayRegion (jbyteArray val0, jsize val1, jsize val2, jbyte * val3)
            ^
    make[5] *** [java/native/libcephfs_jni_la-libcephfs_jni.lo] Error 1
 ~~~~

Signed-off-by: Dmitry Smirnov <onlyjob@member.fsf.org>

look for "jni.h" in gcj-jdk path, needed to find "jni.h" with gcj-jdk_4.9.0

Signed-off-by: Dmitry Smirnov <onlyjob@member.fsf.org>

mds: deny reconnect for closed session

The client that tries reconnect may have dirty caps and unsafe requests.
Allowing the reconnect attempt may compromise consistency.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>

mds: revert EMetaBlob::{fullbit,remotebit,nullbit} encoding optimization

Revert commit 40d56a97 (mds: optimize EMetaBlob::fullbit, remotebit,
nullbit encoding). This optimization creates small segments in the
result bufferlist of encoding EMetaBlob. Perf shows lots of CPU time
are used for allocating list node for bufferlist.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>

mds: properly clear new flag for stale client cap

CInode::encode_inodestat() should clear the 'new' flag of client
cap even when session is stale, because the 'new' flag prevents
Locker::issue_caps() from sending cap message to client.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>

mds: propagate inode rstat if it has never been propagated

Otherwise the 'last_dirstat_prop' of directory inode keeps in 'never'
state.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>

mds: avoid journaling unnecessary dir context

If base inode is reached, try clearing the 'maybe' list, then stop.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>

mds: cleanup usage of MDCache::predirty_journal_parent()

The sixth parameter of MDCache::predirty_journal_parent() is 'int'
with default value 0.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>

BtrfsFileStoreBackend.cc: fix ::unlinkat() result handling

Don't check for 'fd' but for the return value of the ::unlinkat() call.

Fix for:
[src/os/BtrfsFileStoreBackend.cc:72] -> [src/os/BtrfsFileStoreBackend.cc:74]:
 (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

TestLFNIndex.cc: remove unused variable 'mangled_name'

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw_user.cc: remove dead assignment in generate_key()

Fix for:
[src/rgw/rgw_user.cc:778]: (style) Variable 'subuser' is
 assigned a value that is never used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw_user.cc: cleanup RGWAccessKeyPool::check_op()

Remove dead assignment and unsued variable 'secret_key'. Check
op_state.get_access_key() directly for emptiness without extra
variable. Fix comment above check for access key.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw_rados.cc: remove dead assignment / unused variable 'obj_name'

Fix for:
[src/rgw/rgw_main.cc:1086]: (style) Variable 'frontend_frameworks'
 is assigned a value that is never used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw_main.cc: remove dead assignment and unused variable

Fix for:

[src/rgw/rgw_main.cc:1086]: (style) Variable 'frontend_frameworks' is
 assigned a value that is never used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

PGMap.cc: remove dead assignment

[src/mon/PGMap.cc:865]: (style) Variable 'first' is assigned a value
 that is never used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

MDBalancer.cc: remove some since 2009 unused code

Remove some since long time unused code and variables (commented out
since 2009).

Fix for:

[src/mds/MDBalancer.cc:757]: (style) Variable 'total_sent' is
 assigned a value that is never used.
[src/mds/MDBalancer.cc:665]: (style) Variable 'total_goal' is
 assigned a value that is never used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

chain_xattr.cc: fix memory leak, free 'expected'

Fix for:
[src/test/objectstore/chain_xattr.cc:186]: (error) Memory leak:
 expected

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

confutils.cc: remove unused variable 'val'

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

SyntheticClient.cc: remove double check for "getdir"

Fix for:
[src/client/SyntheticClient.cc:1143]: (style) Expression is always
 false because 'else if' condition matches previous condition at line 1139.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw_op.cc: reduce scope of 'int r' in execute()

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw_op.cc: use static_cast instead of c-style cast

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

rgw_quota.cc: remove unused variable 'key'

[src/rgw/rgw_quota.cc:455]: (style) Variable 'key' is assigned a
 value that is never used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test_rgw_admin_log.cc: prefer ++operators for iterators

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test_cls_rbd.cc: use 'delete []' if 'new char[len]' was used

Fix for:
[src/test/cls_rbd/test_cls_rbd.cc:82]: (error) Mismatching allocation
 and deallocation: b
[src/test/cls_rbd/test_cls_rbd.cc:95]: (error) Mismatching allocation
 and deallocation: b
[src/test/cls_rbd/test_cls_rbd.cc:97]: (error) Mismatching allocation
 and deallocation: b

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test_rgw_admin_log.cc: prefer empty() over size() for emptiness check

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test_rgw_admin_opstate.cc: prefer ++operators for iterators

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test_rgw_admin_meta.cc: prefer ++operators for iterators

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

TestErasureCodePluginJerasure.cc: prefer ++operators for non-primitive types

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

test/ObjectMap/KeyValueDBMemory.cc: use empty() instead of size()

Use empty() instead of 'size() == 0' to fix:

[src/test/ObjectMap/KeyValueDBMemory.cc:83]: (performance)
 Possible inefficient checking for 'db' emptiness.
[src/test/ObjectMap/KeyValueDBMemory.cc:97]: (performance)
 Possible inefficient checking for 'db' emptiness.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

FileStore.cc: remove some dead assignments

There is no need to reset 'r' to '0'.

Fix for:
3759 r = 0;
     Value stored to 'r' is never read

4093 r = 0;
     Value stored to 'r' is never read

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

.gitignore: ignore files generated by ctags on topdir

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

add gitignore for wireshark subdir to track *.patch only here

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

.gitignore: add some patch/diff related files

Change *.patch to be ignored in general on all dirs.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

.gitignore: add no longer used mkcephfs

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

cls_kvs.cc: return 'r' from get_idata_from_key()

Fix for:

69  r = 0;
    Value stored to 'r' is never read

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

cls_kvs.cc: remove dead assignment

Fix for:
[src/key_value_store/cls_kvs.cc:383] -> [src/key_value_store/cls_kvs.cc:386]:
 (performance) Variable 'r' is reassigned a value before the old one has been used.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>