rados: Add noreturn attribute to silence uninitialized warning

Marking the `usage_exit` function as noreturn lets the compiler know
that execution won't continue beyond the statement where it's called,
so the path that would lead to the variables being used uninitialized
doesn't count.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #19101 from ifed01/wip-ifed-extending-fio

test/fio: extend fio objectstore plugin to better simulate OSD behavior

Merge pull request #18863 from tchaikov/wip-devtoolset-7

build/ops: use devtoolset-7 on centos/rhel-7

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #18812 from tchaikov/wip-pybind-rados-service-api

pybind/rados: add rados_service_*()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #19307 from tchaikov/wip-drop-ubuntu-trusty

qa,doc: drop support of ubuntu trusty

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

install-deps.sh: use gcc-7 on trusty

* always install gcc-7 on trusty
* point g++ to g++-7 if not yet

Signed-off-by: Kefu Chai <kchai@redhat.com>

ceph.spec: use devtoolset-7-gcc-c++ on centos/rhel

for better performance.

Signed-off-by: Kefu Chai <kchai@redhat.com>

install-deps.sh: always use yum-config-manager for consistency

Signed-off-by: Kefu Chai <kchai@redhat.com>

install-deps.sh: install devtoolset-7 for centos/rhel

ready them for gcc7 and libstdc++-7 for better performance.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19324 from neha-ojha/wip-fix-collectl

qa: install collectl with cbt task

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #19325 from ceph/wip-ceph-disk-man-fix

doc/man remove deprecation of ceph-disk man page title

Reviewed-by: Brad Hubbard

doc/man remove deprecation of ceph-disk man page title

Signed-off-by: Alfredo Deza <adeza@redhat.com>

qa: install collectl with cbt task

Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge pull request #19241 from ceph/wip-doc-deprecate-cdisk

doc: update references to use ceph-volume

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #19321 from ceph/wip-rm22305

ceph-volume should be able to handle multiple LVM (VG/LV) tags

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #19319 from ceph/wip-rm22297

ceph-volume  handle inline comments in the ceph.conf file

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

ceph-volume tests.api ensure that we can handle non-ceph tags in lvs

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #19316 from trociny/wip-blkdev-fixup

common/blkdev: fix build in FreeBSD environment

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

ceph-volume api.lvm only consider 'ceph.' tags in logical volumes

Signed-off-by: Alfredo Deza <adeza@redhat.com>

doc/install use ceph-volume in manual deployment steps

Signed-off-by: Alfredo Deza <adeza@redhat.com>

doc/rados update user-management to use ceph-volume

Signed-off-by: Alfredo Deza <adeza@redhat.com>

doc/rados update bluestore-migration to use ceph-volume

Signed-off-by: Alfredo Deza <adeza@redhat.com>

doc/rados update add-or-rm-osds to use ceph-volume

Signed-off-by: Alfredo Deza <adeza@redhat.com>

doc/rados update bluestore config to use ceph-volume

Signed-off-by: Alfredo Deza <adeza@redhat.com>

doc/rados update auth config examples to use ceph-volume

Signed-off-by: Alfredo Deza <adeza@redhat.com>

doc/man add deprecation notices to ceph-disk man page

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #19275 from qrGitHub/wip-rgw-correct-comment

rgw: correct comment in function parse_credentials

Reviewed-by: Casey Bodley <cbodley@redhat.com>

ceph-volume configuration allow inlined comments for # and ;

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume tests verify that INI comments can be inlined

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #19314 from ifed01/wip-ifed-affiliation

.githubmap, .mailmap, .organizationmap, .peoplemap: update Igor

Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>

common/blkdev: fix build in FreeBSD environment

Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>

.githubmap, .mailmap, .organizationmap, .peoplemap: update Igor
Fedotov's affiliation

Signed-off-by: Igor Fedotov <ifedotov@suse.com>

doc: update docs to remove references of ubuntu 14.04

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/docker-test: drop support for ubuntu 14.04 and centos 6

* we cannot build on centos 6. and we are dropping the support for ubuntu
  14.04 also.
* add ubuntu 17.04: this release is not a LTS release, and added merely for
  demostration purpose.

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/suites/hadoop: switch from trusty to ubuntu latest

use the ubuntu_face.yaml facet for the distro used for testing. since we
are dropping the support for trusty.

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/suites/fs: use ubuntu_latest for multiclient tasks

instead of using ubuntu 14.04, since we want to drop the support of this
release.

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/suites/fs: use ubuntu_latest for libcephfs_java

* instead of using ubuntu 14.04, use ubuntu_latest.since we want
  to drop the support of this release.
* refactor this test to use the facet of ubuntu_latest.yaml.

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks: remove test_buildpackages

the buildpackages feature is not part of ceph. and its test was moved to
teuthology in 5a43f8d5. let's remove the leftovers from ceph/ceph. BTW,
we have not run this test suite since then. and its dependency cannot be
fulfilled.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19196 from shun-s/wip-cephdisk-fix-major-error

ceph-disk: fix signed integer is greater than maximum when call major

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19296 from shinobu-x/strange_double_space

osd: Remove double space

osd: Remove double space

Should not break anything but just strange...

Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>

Merge pull request #19161 from xiexingguo/wip-pg-log

osd/PGLog: get rid of ineffective container operations

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

osd/PGLog: get rid of ineffective container operations

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #19242 from liewegas/wip-21147

qa/suites/rados/thrash: extend mgr beacon grace when many msgr failures injected

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19185 from liewegas/wip-trim-mgrmap

mon/MgrMonitor: limit mgrmap history

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19285 from ceph/wip-rm22299

ceph-volume Format correctly when vg/lv cannot be used

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #19259 from ceph/wip-rm22280

ceph-volume: handle leading whitespace/tabs in ceph.conf

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

ceph-volume tests verify proper formatting of RuntimeError on vg/lv error

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume lvm.prepare correctly format argument for vg/lv error

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #19264 from theanalyst/doc/releases/12.2.2

doc: add 12.2.2 release notes

Reviewed-By: Sage Weil <sage@redhat.com>
Reviewed-By: Nathan Cutler <ncutler@suse.com>

Merge pull request #19284 from theanalyst/changelog/12.2.2

doc: add changelog for v12.2.2

doc: add changelog for v12.2.2

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #19278 from badone/wip-librgw_file_marker-unused-function-warnings

rgw_file: Silence unused-function warnings

Merge pull request #19281 from qrGitHub/wip-rgw-typo-anynoymous

rgw: fix typo anynoymous to anonymous

Reviewed-by: Jos Collin <jcollin@redhat.com>

doc: add 12.2.2 release notes

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

rgw: correct typo anynoymous to anonymous

Signed-off-by: Bingyin Zhang <zhangbingyin@cloudin.cn>

rgw_file: Silence unused-function warnings

Comment out unused insertion operators.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

rgw: correct comment in function parse_credentials

Signed-off-by: Bingyin Zhang <zhangbingyin@cloudin.cn>

Merge pull request #19233 from tchaikov/wip-no-mon-health-to-clog-when-upgrading

qa: disable mon-health-to-clog in upgrade test

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #19225 from tchaikov/wip-more-whitelist

qa/suites/rados/singleton: more whitelist

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #19202 from tchaikov/wip-check-pthread-ext

cmake,common/RWLock: check for libpthread extensions

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #19160 from shinobu-x/bluestore_tool_remove_redundant_code

os/bluestore/bluestore_tool: Move redundant code into one method

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>

Merge pull request #19100 from tchaikov/wip-log-reuse-streambuf

common/log: Speed improvement for log

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #18124 from amitkumar50/cleanup-Min-Max

cleanup: Replacing MIN,MAX with std::min,std::max

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #18991 from dmick/wip-ceph-disk-fsid

ceph_disk: allow "no fsid" on activate

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #19262 from ceph/wip-fix-distro-master

tests - Replaced requests for "centos 7.3" to centos_latest

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #19164 from hrchu/adminopsBindings

doc: rgw adminops binding libraries

Reviewed-by: Casey Bodley <cbodley@redhat.com>

doc: add 12.2.2 to releases table

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

doc: cleanup PendingReleaseNotes

drop sections already in previous releases, keeping only Mimic sections
and a new section header for items going post 12.2.2

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

qa: disable mon-health-to-clog in upgrade test

otherwise the cluster will complain that the quorum size is smaller than
that of monmap.

Signed-off-by: Kefu Chai <kchai@redhat.com>

tests - Replaced requests for "centos 7.3" to centos_latest

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #19247 from shinobu-x/rados_op_crush-map-edits_straw2

doc/rados: Add explanation of straw2

test/fio: add single pool mode to share collections among multiple jobs

Signed-off-by: Igor Fedotov ifedotov@suse.com

ceph-volume test leading whitespace is handled in configurations

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume trim tabbed/whitespaced configuration files when loading them

Signed-off-by: Alfredo Deza <adeza@redhat.com>

test/fio: add options to insert attributes/omaps into write transaction.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #19254 from tchaikov/wip-ceph-disk-mock-get-fsid

ceph-disk: mock get fsid

Reviewed-by: Alfredo Deza <adeza@redhat.com>

ceph-disk: silence deprecate warnings while testing

Signed-off-by: Kefu Chai <kchai@redhat.com>

ceph-disk/tests: mock get_fsid

should offer a valid fsid for the ceph-disk under testing.

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/rados: add rados_service_*()

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #18995 into master

* refs/pull/18995/head:
client: emplace Cap in Inode caps map

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #19009 into master

* refs/pull/19009/head:
client: Switch to new style config options and some cleanup

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #19069 into master

* refs/pull/19069/head:
qa/tasks/ceph_fuse: fix ceph-fuse mount failed

Reviewed-by: Yunfei Guan <yunfei.guan@xtaotech.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Amit Kumar <amitkuma@redhat.com>

githubmap: update contributors

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #19078 into master

* refs/pull/19078/head:
pybind: return error message when ceph_mds_command() returns error
mds: Fix error message when mds not active

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #19095 into master

* refs/pull/19095/head:
test: pass correct buffer length to ceph_getdents

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #19181 into master

* refs/pull/19181/head:
client: give full error message on failed remount
client: use PATH_MAX for mount path size

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #19207 into master

* refs/pull/19207/head:
mds: handle client reconnect gather race

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

ceph-disk: fix signed integer is greater than maximum when call major
  fix signed integer is greater than maximum when call os.major
  using python 2.7.5 in Centos 7

Signed-off-by: Song Shun <song.shun3@zte.com.cn>

doc/rados: Add explanation of straw2

Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>

Merge pull request #15482 from myoungwon/wip-chunked-manifest

osd,librados: add manifest, operations for chunked object

Reviewed-by: Sage Weil <sage@redhat.com>

ceph_disk: allow "no fsid" on activate

The intent was to allow "no fsid" configurations when only one
conf file named 'ceph.conf' was present, but the code has a bug
in that ceph-osd --show-config-value will return a default all-0
uuid.  Treat 'all-0' as we were treating 'None'.

Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge pull request #18974 from liewegas/wip-22145

osd/PG: restart recovery if NotRecovering and unfound found

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

osd/PG: restart recovery if NotRecovering and unfound found

If we are in recovery_unfound state waiting for unfound objects, and we
find them, we need to restart the recovery reservation process so that we
can recover.  Do this by queueing DoRecover() event instead of calling
queue_recovery() (which won't do anything since we're not in
recoverying|backfilling pg states).

Make the parent Active state ignore DoRecovery so that if we are already
in some phase of recovery/backfill the event gets ignored.  It is already
handled by the other important substates that care, like Clean (for
repair's benefit).

I'm not sure why states like Activating are paying attention tot his vevent...

Fixes: http://tracker.ceph.com/issues/22145
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #18954 from adamemerson/wip-hole-in-the-bucket-dear-liza

rgw: Add try_refresh_bucket_info function
rgw: Add retry_raced_bucket_write
rgw: Handle stale bucket info in RGWPutMetadataBucket
rgw: Handle stale bucket info in RGWSetBucketVersioning
rgw: Handle stale bucket info in RGWSetBucketWebsite
rgw: Handle stale bucket info in RGWDeleteBucketWebsite
rgw: Handle stale bucket info in RGWPutBucketPolicy
rgw: Handle stale bucket info in RGWDeleteBucketPolicy
rgw: Expire entries in bucket info cache

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #19215 from joscollin/wip-mount-fuse-ceph-typo

doc: Fix typo in mount.fuse.ceph

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #19209 from joscollin/wip-githubman-ktdreyer

githubmap: Add ktdreyer

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #19208 from tchaikov/wip-spdk-17.10

 spdk: update SPDK to v17.10

Reviewed-by: Nathan Cutler <ncutler@suse.com>

qa/suites/rados/thrash: extend mgr beacon grace when many msgr failures injected

Fixes: http://tracker.ceph.com/issues/21147
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #19238 from tchaikov/wip-22266

tools/ceph_monstore_tool: rebuild initial mgrmap also

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: John Spray <jspray@redhat.com>