mgr: fix typo in variable name and cleanups

* s/sercive/service/
* also fix the logging message. before this change, we have

send_report send_report osd,2.0x557ea1c16550 sent me an unknown health
metric:

after this change,

send_report send_report osd.2 sent me an unknown health metric: 0x01

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #22061 from tspmelo/wip-npmrc

mgr/dashboard: Disable package-lock.json creation

Reviewed-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #22058 from ricardoasmarques/wip-ng-serve-remote-access

mgr/dashboard: ng serve bind to 0.0.0.0

Reviewed-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Disable package-lock.json creation

Since we are not keeping track of this file, it is better to not generate it.
Otherwise we might face some package version conflicts,
which break the dashboard build.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #22057 from tchaikov/qa-valgrind-without-random-distro

qa/suites/rados/verify: remove random-distro$

Reviewed-by: Sage Weil <sage@redhat.com>

qa/suites/rados/verify: remove random-distro$

the distro specified by random-distro$ will be overwrited by the one
specfied by valgrind.yaml. and teuthology-suite will give

KeyError: '16.04 not a centos version or codename'

when scheduling a suite involving the facets above. also, i think it's
of not much value to run valgrind/lockdep with different distros.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: ng serve bind to 0.0.0.0

This will allow access to ng serve from remote machines

Signed-off-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #21981 from tspmelo/fix-momentjs

mgr/dashboard: Fix moment.js deprecation warning

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #22046 from tchaikov/wip-23653

cmake: do not check for aligned_alloc() anymore

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

cmake: do not check for aligned_alloc() anymore

this reverts 16f0a67d

Fixes: http://tracker.ceph.com/issues/23653
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #22028 from tchaikov/wip-wheelhouse

install-deps: nuke wheelhouse if it's stale

Merge pull request #21751 from shangfufei/wip-async-needless-code

msg/async: the ceph_abort is needless in handle_connect_msg

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21854 from ifed01/wip-ifed-bluestore-alloc-cleanup

os/bluestore: allocator pruning

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #21926 from dragonylffly/wip-fix-throttle-configurations

os/filestore: fix throttle configurations

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #21937 from yanghonggang/balancer-list

mgr/balancer: add cmd to list all plans

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #21957 from tchaikov/wip-test-rados-bench

test/pybind/test_rados.py: collect output in stdout for "bench" cmd

Reviewed-by: John Spray <john.spray@redhat.com>

Merge pull request #21984 from liewegas/wip-24118

mon/MonClient: set configs via finisher

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #21892 from dzafman/wip-24045

osd: Don't evict even when preemption has restarted with smaller chunk

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #22027 from trociny/wip-24141

rbd-mirror: potential deadlock when running asok 'flush' command

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #21624 from trociny/wip-22787

librbd: deep copy optionally support flattening cloned image

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

osd: Clear part of cleaned_meta_map in case of a restarted smaller chunk

This can not happen at the primary because scrub_compare_maps() is only
called once per chunk start.

Preemption causes a smaller chunk from start to be processed again at
replicas.  We clear any of the previous chunk's information.

Signed-off-by: David Zafman <dzafman@redhat.com>

mgr/dashboard: Fix moment.js deprecation warning

Fixes: https://tracker.ceph.com/issues/24115
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #22003 from votdev/fix_deletion_dialog

mgr/dashboard: Deletion dialog falsely executes deletion when pressing 'Cancel'

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #21928 from ricardoasmarques/wip-remove-useless-unsubscribe

mgr/dashboard: Remove useless observable unsubscriptions

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

rbd: deep copy option to copy clone parent data

Signed-off-by: Mykola Golub <mgolub@suse.com>

librbd: deep copy optionally support flattening cloned image

Fixes: http://tracker.ceph.com/issues/22787
Signed-off-by: Mykola Golub <mgolub@suse.com>

librbd/deep_copy: adjust in-memory overlap if set_size updated it on disk

so set_parent won't be called when overlap is changed due to image
size change.

Signed-off-by: Mykola Golub <mgolub@suse.com>

librbd: hide parent object when deep copying empty child

Signed-off-by: Mykola Golub <mgolub@suse.com>

librbd: fix deep copy clone to destination with larger object size

When assembling a destination object from source objects we need to
read from parent if some (but not all) of assembles do not exist.

Signed-off-by: Mykola Golub <mgolub@suse.com>

test/librbd: add deep copy clone tests

Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #22002 from votdev/fix_deletion

mgr/dashboard: Handle errors during deletion

Reviewed-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #22006 from liewegas/wip-mimic

doc/releases/schedule: add mimic column

doc/releases/mimic: edit/clean up upgrade notes

Signed-off-by: Sage Weil <sage@redhat.com>

install-deps: nuke wheelhouse if it's stale

otherwise, if we update *requirements.txt, and the wheelhouse fails to
offer the newly added dependency, the setup-virtualenv.sh will fail the
build.

Signed-off-by: Kefu Chai <kchai@redhat.com>

rbd-mirror: make 'flush' asok command asynchronous

Signed-off-by: Mykola Golub <mgolub@suse.com>

rbd-mirror: don't reregister asok hook in process entry thread

It might get stuck if the asok is busy executing a command.
Instead kick status update, which will call reregister on finish.

Fixes: http://tracker.ceph.com/issues/24141
Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #22008 from dillaman/wip-rbd-suite-distros

qa/suites/rbd: randomly select a supported distro

Reviewed-by: Yuri Weinstein <yweins@redhat.com>

Merge pull request #21932 from yuriw/wip-yuriw-add-dollar-rgw

tests/qa: Adding $ distro mix - rgw

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #22011 from dillaman/wip-rbd-release-notes

doc/releases/mimic: tweak RBD major features

doc/releases/schedule: add mimic column

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #22017 into master

* refs/pull/22017/head:
ptl-tool: skip empty comment body

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

ptl-tool: skip empty comment body

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #21924 into master

* refs/pull/21924/head:
align lspools output in file-layouts and manual-freebsd-deployment
Fixed configuration setting standby_replay
Fixed the order of configuration

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #22016 from LenzGr/dashboard-mimic-reasenotes

doc/releases/mimic: Updated dashboard description

doc/releases/mimic: Updated dashboard description

Fixed typo and slightly reworked the description of the mgr
dashboard in the "Major changes" section. Updated the
description in the "Notable changes" section as well by adding
a note about creating an SSL certificate.

Signed-off-by: Lenz Grimmer <lgrimmer@suse.com>

doc/releases/mimic: tweak RBD major features

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

qa/suites/rbd: randomly select a supported distro

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge PR #21842 into master

* refs/pull/21842/head:
MDSMonitor: clean up use of pending fsmap in uncommitted ops
MDSMonitor: refactor last_beacons to use mono_clock
mds: refactor MDSMap init
mds: refactor FSMap init
mds: refactor Filesystem init
mds: move compat set methods to MDSMap

Reviewed-by: João Eduardo Luís <joao@suse.de>

Merge pull request #21986 from cbodley/wip-24124

Revert "common: add an async SharedMutex"

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #21987 from liewegas/wip-mimic-upgrade

doc/releases/mimic: upgrade steps

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

doc/releases/mimic: upgrade steps

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/dashboard: Deletion dialog falsely executes deletion when pressing 'Cancel'

If a deletion fails and the 'Cancel' button is pressed to close the dialog, then the deletion process is triggered again.

Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #21809 from tchaikov/wip-22420

mon,osd: dump "compression_algorithms" in "mon metadata"

Reveiwed-by: John Spray <john.spray@redhat.com>

mgr/dashboard: Handle errors during deletion

- Take care that the deletion dialog gets notified about errors to stop the progress spinner and enable the delete button again.
- Prettify JS code.

Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Remove useless observable unsubscriptions

Signed-off-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #21933 from tspmelo/fix-unittest-warnings

mgr/dashboard: Fix unit tests cli warnings

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #21967 from votdev/bug_24097

mgr/dashboard: Navbar dropdown button does not respond for mobile browsers

Reviewed-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #21971 from tspmelo/remove-husky

Mgr/dashboard: Remove husky package

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #21895 from yuriw/wip-yuriw-add-dollar1

tests/qa: trying $ distro mix

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #21949 from yuriw/wip-yuriw-crontab

qa/tests: added --filter-out="ubuntu_14.04"

Merge PR #21966 into master

* refs/pull/21966/head:
mds: handle imported session race
mds: check for session import race

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge pull request #20975 from theanalyst/doc/releases/mimic-dev-2

doc: mimic rc1 release notes

mds: handle imported session race

Thanks to Yan Zheng for identifying and reviewing the fix.

Fixes: http://tracker.ceph.com/issues/24087
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

mds: check for session import race

Credit to Yan Zheng for identifying the race condition [1].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1572555#c7

Test-for: http://tracker.ceph.com/issues/24072

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Revert "common: add an async SharedMutex"

This reverts commit 67fe5d25a7bd57841d5d1a2636c4e46ae97ac3e7.

Fixes: http://tracker.ceph.com/issues/24124
Signed-off-by: Casey Bodley <cbodley@redhat.com>

osd: Don't evict even when preemption has restarted with smaller chunk

Fixes: https://tracker.ceph.com/issues/24045
Signed-off-by: David Zafman <dzafman@redhat.com>

mon/MonClient: set configs via finisher

The config observers may want to take locks that are ordered relative
to monc_lock.

We could simply drop monc_lock for this call, but that would implicitly
rely on a single-threaded dispatch to avoid having two incoming MConfig
messages get reordered.  Explicitly putting it on a finisher is safer.
Note that we adjust the get_monmap_and_config() to start, drain, and stop
the finisher to ensure we have incoming config processed and applied
before returning.

Fixes: http://tracker.ceph.com/issues/24118
Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: add release(PExtentVector) helper to Allocator class to
free PExtentVector explicitly.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>

os/bluestore: get rid off allocator's reserve method

Signed-off-by: Igor Fedotov <ifedotov@suse.com>

Mgr/dashboard: Remove husky package

It seems pretty-quick is not restricted to the root of the dashboard frontend
and this could bring undesired changes to some files.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #21785 from votdev/info_no_rgw

mgr/dashboard: Display notification if RGW is not configured

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #21975 from ukernel/wip-revert-23837

Revert "ceph-fuse: Delete inode's bufferhead was in Tx state would le…

Revert "ceph-fuse: Delete inode's bufferhead was in Tx state would lead a assert fail"

This reverts commit 07e3bceea78dc8ecd76abb1cafca5c9d1fde521e.
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

mgr/dashboard: Display useful info if RGW is not configured

Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Add ModuleStatusGuardService route guard

Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Add info panel component

Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #20118 from b-ranto/wip-selinux-ldconfig

selinux: Allow ceph to execute ldconfig

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21943 from tchaikov/wip-24077

qa/tasks/mgr: fix test_pool.py

Reviewed-by: Ricardo Dias <rdias@suse.com>

selinux: Allow ceph to block suspend

Ceph is now trying to block suspend in certain cases, we need to update
the policy accordingly.

Signed-off-by: Boris Ranto <branto@redhat.com>

selinux: Allow ceph to execute ldconfig

The ceph-volume testing showed that the ceph daemons can run ldconfig in
a corner case when they are forbidden access to some files. This patch
allows ceph to execute ldconfig in Enforcing mode.

Fixes: https://tracker.ceph.com/issues/22302
Signed-off-by: Boris Ranto <branto@redhat.com>

mgr/dashboard: Navbar dropdown button does not respond for mobile-like browsers

Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #20731 from yuyuyu101/wip-opti-ac

msg/async: avoid put message within write_lock

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21946 from dillaman/wip-24092

rbd: disable cache for actions that open multiple images

Reviewed-by: Mykola Golub <mgolub@suse.com>

qa/tests: added --filter-out="ubuntu_14.04"

This is needed for all "client-upgrade-*" suites running on mimic

Fixes https://tracker.ceph.com/issues/2402

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

mgr/balancer: add cmd to list all plans

Signed-off-by: Yang Honggang <yanghonggang@umcloud.com>

test/pybind/test_rados.py: collect output in stdout for "bench" cmd

it was changed from stderr to stdout in 23583ccc

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21804 from dillaman/wip-24000

osdc: self-managed snapshot helper should catch decode exception

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #21929 from majianpeng/fio-ceph-objectstore

test/fio: add option single_pool_mode in ceph-bluestore.fio

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #21905 from jcsp/wip-24022

osd: write "bench" output to stdout

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21950 from liewegas/wip-23899

osd: clean up smart probe

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21940 from dmick/wip-remove-cephd

cmake: Remove embedded 'cephd' code

Reviewed-by: Bassam Tabbara <Bassam.Tabbara@Quantum.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

qa/tasks/mgr: fix test_pool.py

* per command desc of "osd pool set", "val" parameter should be a "string"
  not a number. so update the test_pool.py accordingly.
* also as a follow-up of 65925511bc, we need to update the test
  accordingly to reflect the change in the error's str representation.

Fixes: http://tracker.ceph.com/issues/24077
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #21615 into master

* refs/pull/21615/head:
ceph-fuse: Delete inode's bufferhead was in Tx state would lead a assert fail

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #21769 into master

* refs/pull/21769/head:
mds: properly reconnect client caps after loading inodes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #21883 into master

* refs/pull/21883/head:
mds: tighten conditions of calling rejoin_gather_finish()
mds: avoid calling rejoin_gather_finish() two times successively

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #21923 into master

* refs/pull/21923/head:
mds: set could_consume to false when no purge queue item actually executed

Reviewed-by: Zheng Yan <zyan@redhat.com>

tests/qa: adding rados/.. dirs

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

osd: clean up smart probe code a bit

Signed-off-by: Sage Weil <sage@redhat.com>

Remove embedded 'cephd' code

Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge pull request #21942 from tchaikov/wip-qa-ceph-disk-no-mon-config

qa/workunits/ceph-disk: --no-mon-config

Reviewed-by: Sage Weil <sage@redhat.com>