test: Use a file that should be on all OSes

Also, create temporary files in test specific dir and remove

Caused by: 154330fd68d952a4e1b972891f02b6dc9c355424

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #22420 from b-ranto/wip-mgr-fix-avg

mgr: expose avg data for long running avgs

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #22396 from liewegas/wip-24396

osd/PrimaryLogPG: fix on_local_recover crash on stray clone

Reviewed-by: David Zafman <dzafman@redhat.com>

osd/PrimaryLogPG: fix on_local_recover crash on stray clone

If there is a stray clone (one that does not appear in the SnapSet) and
we do any sort of recovery on it the OSD will crash.  Log an error instead
but continue.

This addresses a problem where a cluster has both (1) an unexpected clone
and (2) the clone is not present on all replicas.  Doing repair on that
PG will both not fix the unexpected clone and also cause the remaining
OSDs to crash trying to recover it.

Include a test.

Fixes: https://tracker.ceph.com/issues/24396
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #21999 from myoungwon/wip-manifest-unset-op

osd, librados: add unset-manifest op

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #22395 from liewegas/wip-24408

osd,mds: make 'config rm ...' idempotent

Reviewed-by: Erwan Velu <erwan@redhat.com>

Merge pull request #21775 from Synesis-LLC/fix-23964

librados: fix buffer overflow for aio_exec python binding

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #22417 from tspmelo/fix-lint-error

mgr/dashboard: fix lint error

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #22402 from ricardoasmarques/wip-stacktrace-optional

mgr/dashboard: Stacktrace is optional on 'js-error' endpoint

Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #22399 from alfredodeza/wip-rm24417

ceph-volume tests do not include admin keyring in OSD nodes

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

mgr: expose avg data for long running avgs

While exposing the long running avgs, the order of regular and long
running avg data got mixed up resulting in exposing empty data for both
since there is no regular data for long running avgs and vice versa.
This commit fixes this issue by changing the order of the if/else
statement exposing regular data for regular counters and avg data for
long running avgs.

Signed-off-by: Boris Ranto <branto@redhat.com>

Merge pull request #22401 from ricardoasmarques/wip-prettify-package-json

mgr/dashboard: Prettify package.json

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: fix lint error

Error was introduced in 78dc50443cf64168098f1fb5bc43b7d6125621b8.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #21826 from tspmelo/rxjs6

mgr/dashboard: Update RxJS to version 6

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #22122 from tspmelo/wip-osd-scrub

mgr/dashboard: Add scrub action to the OSDs table

Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #22392 from tchaikov/wip-cmake-boost-1.67

cmake: bump up the required boost version to 1.67

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #22405 from neha-ojha/wip-24365

qa/tasks/cbt.py: changes to run on bionic

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

qa/tasks/cbt.py: changes to run on bionic

Signed-off-by: Neha Ojha <nojha@redhat.com>

mgr/dashboard: Stacktrace is optional on 'js-error' endpoint

Signed-off-by: Ricardo Marques <rimarques@suse.com>

osd,mds,common: make 'config rm ...' idempotent

Fixes: http://tracker.ceph.com/issues/24408
Signed-off-by: Sage Weil <sage@redhat.com>

mgr/dashboard: Prettify package.json

Signed-off-by: Ricardo Marques <rimarques@suse.com>

ceph-volume tests do not include admin keyring in OSD nodes

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #22393 from wido/ceph-volume-bluestore-tool

ceph-volume lvm.activate Do not search for a MON configuration

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Alfredo Deza <adeza@redhat.com>

common/config: fix rm_val error codes

EINVAL if the config option is invalid.
ENOENT if the config option wasn't set.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #22359 into master

* refs/pull/22359/head:
osdc/objecter: remove unused method finish_op

Reviewed-by: Kefu Chai <kchai@redhat.com>

cmake: bump up the required boost version to 1.67

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Add scrub action to the OSD table

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Add OSD scrub modal component

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Add scrub methods to OSD controller and service

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Extract 'srt_to_bool' method

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #21247 from MahatiC/wip-rbd-datapool

rbd: add data pool support to trash purge

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #22389 from MahatiC/nit-cleanup

doc: cleanup rendering syntax

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #22384 from ukernel/wip-mds-session-ref

mds: add reference when setting Connection::priv to existing session

Merge pull request #22346 from dzafman/wip-scrub-omap

osd: Handle omap and data digests independently

Reviewed-by: Kefu Chai <kchai@redhat.com>

doc: cleanup

cleanup format

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@intel.com>

ceph-volume lvm.activate Do not search for a MON configuration

This system might not have one nor can we be sure that we have
a client.admin keyring on the system.

Just prime the directory and have the OSD then use it's own cephx
key to communicate with the MONs.

Signed-off-by: Wido den Hollander <wido@42on.com>

Merge pull request #22328 from tspmelo/wip-tslint-unused

mgr/dashboard: Add 'no-unused-variable' rule to tslint

Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #22350 from theanalyst/doc-mimic-index-fix

doc: mimic is stable!

Reviewed-by: Kefu Chai <kchai@redhat.com>

mds: fix MDSRank::send_message_client_counted()

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

mds: add reference when setting Connection::priv to existing session

the bug was introduced by commit 72883956c26 "use intrusive_ptr for
holding Connection::priv"

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

osd: use null if on_finisher is not needed

Signed-off-by: Myoungwon Oh <omwmw@sk.com>

osd: set has_reference flag when need_reference is set

Signed-off-by: Myoungwon Oh <omwmw@sk.com>

src/test: add a unit test for unset-manifest

Signed-off-by: Myoungwon Oh <omwmw@sk.com>

mgr/dashboard: Add 'no-unused-variable' rule to tslint

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Update RxJS to version 6

I used rxjs-tslint tool to automatically update most of the necessary code.

I added a new package, rxjs-compat, to maintain the compatibility
of external plugins that are still using RxJS v5.X.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #21718 from majianpeng/admin-socket-cleanup

common/admin_socket: add new api unregister_commands(AdminSocketHook …

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21913 from tspmelo/wip-cephfs-table

mgr/dashboard: Add Filesystems list component

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #22196 from thinkercui/bugfix

osd: read object attrs failed at EC recovery

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #22336 from majianpeng/bluestore-handle-kvdb-error

os/bluestore: firstly delete db then delete bluefs if open db met error.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #22306 from liewegas/wip-msgr-addrvec

msg: addr -> addrvec (part 1)

Reviewed-by: Ricardo Dias <rdias@suse.com>

Merge pull request #22342 from dillaman/wip-23516

librbd: commit IO as safe when complete if writeback cache is disabled

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #22348 from dillaman/wip-24169

rbd-mirror: ensure daemon can cleanly exit if pool is deleted

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #21812 from thmour/thmour_ceph-volume

ceph-volume: sort and align `lvm list` output

Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #22367 from tchaikov/wip-cmake-rgw

cmake: rgw_common should depend on tracing headers

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>

Merge pull request #22364 from tchaikov/wip-doc

 doc: fix the links in releases/schedule.rst

Reviewed-by: Sage Weil <sage@redhat.com>

osd/OSDMap: switch to addrvec for public_addr

Signed-off-by: Sage Weil <sage@redhat.com>

mon/Session: avoid OSDMap::get_addr()

Signed-off-by: Sage Weil <sage@redhat.com>

osd/OSDMap: remove get_addr()

Signed-off-by: Sage Weil <sage@redhat.com>

osd/OSDMap: avoid get_addr()

Signed-off-by: Sage Weil <sage@redhat.com>

msg/msg_types: entity_addrvec_t contains() and is_same_host()

Signed-off-by: Sage Weil <sage@redhat.com>

osd: avoid OSDMap::get_addr()

Signed-off-by: Sage Weil <sage@redhat.com>

client: use get_addrs()

These are legacy interfaces that should return an IP only.

Signed-off-by: Sage Weil <sage@redhat.com>

msg/msg_types: entity_addrvec_t::front()

Signed-off-by: Sage Weil <sage@redhat.com>

mgr: avoid OSDMap::get_addr()

Signed-off-by: Sage Weil <sage@redhat.com>

msg/msg_types: entity_addrvec_t::probably_equals()

Signed-off-by: Sage Weil <sage@redhat.com>

msg/msg_types: add entity_addrvec_t::get_ports()

Signed-off-by: Sage Weil <sage@redhat.com>

mon/OSDMonitor: change 'osd find' output to list all addrs

Signed-off-by: Sage Weil <sage@redhat.com>

osd/OSDMap: remove get_inst()

Signed-off-by: Sage Weil <sage@redhat.com>

osdc/Objecter: use get_addrs

Signed-off-by: Sage Weil <sage@redhat.com>

messages/MRoute: remove unused entity_inst_t dest

This is unused in luminous and mimic, too, although the code was
never removed.

Signed-off-by: Sage Weil <sage@redhat.com>

mon: remove dead try_send_message()

No more users!

Signed-off-by: Sage Weil <sage@redhat.com>

mon: remove dead send_command()

No users.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/OSDMonitor: remove dead 'osd scrub' implementation from mon

This is now handled by the mgr (as of luminous).

Signed-off-by: Sage Weil <sage@redhat.com>

messages/MOSDMarkMeDown: use addrvec

Signed-off-by: Sage Weil <sage@redhat.com>

cmake: rgw_common should depend on tracing headers

see also: 4c0d3531

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #22324 from cbodley/wip-rgw-cache-time-added

rgw: update ObjectCacheInfo::time_added on overwrite

Merge pull request #22327 from dillaman/wip-23512

librbd: utilize the journal disabled policy when removing images

Reviewed-by: Mykola Golub <mgolub@suse.com>

osd: retry to read object attrs at EC recovery

In EC recovery read, if the object's attrs read failed or with errors, we erase the attrs we have read and
try to read it again from left shards. This will make the primary osd get the object's attrs correct and
avoid assert.

Signed-off-by: xiaofei cui <cuixiaofei@sangfor.com>

os/bluestore: firstly delete db then delete bluefs if open db met error.

When create Rocksdb but failed, met the followong error messages:

2018-05-31 22:30:15.017 7facd3f4f240 -1 rocksdb: do_open Failed to create rocksdb column family: L
2018-05-31 22:30:15.017 7facd3f4f240 -1 bluestore(/home/jianpeng/ceph/build/dev/osd0) _open_db erroring opening db:
*** Caught signal (Segmentation fault) **
 in thread 7facd3f4f240 thread_name:ceph-osd
 ceph version 14.0.0-109-g9d317e5d23 (9d317e5d23eb78deec1a048aff5c2a31997c8345) nautilus (dev)
 1: (()+0x910ee0) [0x555727d3aee0]
 2: (()+0x12890) [0x7facc9a8d890]
 3: (pthread_mutex_lock()+0) [0x7facc9a84fa0]
 4: (BlockDevice::queue_reap_ioc(IOContext*)+0x28) [0x555727ce4fa8]
 5: (BlueFS::_close_writer(BlueFS::FileWriter*)+0x62) [0x555727ce9d52]
 6: (BlueRocksWritableFile::~BlueRocksWritableFile()+0x49) [0x555727d0e659]
 7: (rocksdb::WritableFileWriter::Close()+0x1e7) [0x555727ef0c77]
 8: (rocksdb::log::Writer::~Writer()+0x4d) [0x555727dfbb1d]
 9: (rocksdb::DBImpl::CloseHelper()+0x342) [0x555727d6d632]
 10: (rocksdb::DBImpl::~DBImpl()+0x4dd) [0x555727d7cb6d]
 11: (rocksdb::DBImpl::~DBImpl()+0x11) [0x555727d7cc11]
 12: (RocksDBStore::~RocksDBStore()+0xc1) [0x555727c8a6f1]
 13: (RocksDBStore::~RocksDBStore()+0x9) [0x555727c8aa29]
 14: (BlueStore::_open_db(bool, bool)+0x2416) [0x555727c204b6]
 15: (BlueStore::mkfs()+0x805) [0x555727c50105]
 16: (OSD::mkfs(CephContext*, ObjectStore*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, uuid_d, int)+0x1b0) [0x5557277ffa70]
 17: (main()+0x4222) [0x5557276ebb92]
 18: (__libc_start_main()+0xe7) [0x7facc8948b97]
 19: (_start()+0x2a) [0x5557277b0a9a]
2018-05-31 22:30:15.789 7facd3f4f240 -1 *** Caught signal (Segmentation fault) **
 in thread 7facd3f4f240 thread_name:ceph-osd

This because the error handle for this case firstly delete bluefs then
db. Like close path, it should firstly delete db than delete bluefs.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

doc: fix some redirected links reported by "build-doc linkcheck"

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc: fix the links in releases/schedule.rst

they were broken in e37e49b2

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #21864 from LenzGr/documentation-fixes

doc: fixed restful mgr module SSL configuration commands

Reveiwed-by: John Spray <john.spray@redhat.com>

Merge pull request #22295 from jan--f/cmake-fix-ceph-test-build

cmake: fix cython target in test/CMakeFile.txt

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #22317 from MahatiC/wip-doc-zipkin

doc: update blkin changes

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #22332 from TommyLike/bug/fix_typo

test/encoding: Fix typo in encoding/types.h file

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #22337 from tchaikov/wip-24361

osd,mon: enable level_compaction_dynamic_level_bytes for rocksdb

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #22285 from ricardoasmarques/wip-error-handling

mgr/dashboard: Log frontend errors + @UiController

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #22335 from majianpeng/bluestore-cleanup

os/bluestore: remove useless condtion.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

osdc/objecter: remove unused method finish_op

Signed-off-by: wumingqiao <wumingqiao@inspur.com>

Merge pull request #21689 from ovh/bp-reduce-bs-bl-rebuilds

os/bluestore/BlueFS: reduce bufferlist rebuilds during WAL writes

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #21920 from cbodley/wip-async-librados

librados: use ceph::async::Completion for asio bindings

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #22056 from jiangxiyxy/Branch_master

mon: change monitor compact command to run asynchronously

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>

rbd-mirror: attempt to re-acquire leader lock if watcher recovered

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: ensure managed lock can shut down if stuck waiting for register

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

qa/workunits/rbd: dump long image directory upon rbd-mirror test failure

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

doc: mimic is stable!

Signed-off-by: Abhishek Lekshmanan <alekshmanan@suse.com>

Merge pull request #22319 from theanalyst/releases/mimic/13.2

doc: release/mimic: correct the changelog to the latest version

mgr/dashboard: Remove unused data from summary controller

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Rename clients component to 'cephfs-clients'

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Rename cephfs component to 'cephfs-detail'

Signed-off-by: Tiago Melo <tmelo@suse.com>