mgr/MgrClient: Protect daemon_health_metrics

Without holiding the lock update_daemon_health() can race with
send_report() corrupting the daemon_health_metrics vector.

Fixes: http://tracker.ceph.com/issues/23352
Signed-off-by: Kjetil Joergensen <kjetil@medallia.com>
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

Merge PR #22825 into master

* refs/pull/22825/head:
common: FreeBSD does not have /etc/os-release

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #22998 into master

* refs/pull/22998/head:
filestore: add pgid in filestore pg dir split log message

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge PR #23134 into master

* refs/pull/23134/head:
common: check completion condition before waiting

Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge PR #23223 into master

* refs/pull/23223/head:
osd/PG: kill dead functions and related options
iosd/osd_type: kill unused input ec_pool for iterate_mayberw_back_to
common: kill dead options
osd/PG: do not initialize up/acting twice
osd/PG: clear missing_loc properly if last location is gone

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #22990 from tchaikov/wip-cmake-link-static-libstdc++

cmake: fix "WITH_STATIC_LIBSTDCXX"

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge PR #22692 into master

* refs/pull/22692/head:
doc/mgr/devicehealth: document devicehealth module
doc/rados/operations/health-checks: document DEVICE_HEALTH* messages
mgr/devicehealth: fix style for returns
mgr/devicehealth: use constants for health warnings
mgr/devicehealth: deal with as many daemons as we can until limit
mgr/devicehealth: warn if too many daemons are expected to fail soon
mgr/devicehealth: set primary-affinity 0 for failing devices
msg/devicehealth: fix config options
mgr/devicehealth: only fetch osdmap once from check_health
mgr/devicehealth: revise health messages
mgr/devicehealth: add 'device check-health' command and run periodically
mgr/devicehealth: fix new options
mgr/devicehealth: add helpers to life_expectancy_response()
mgr/devicehealth: simplify setting defaults
common/blkdev remove debug statements

Reviewed-by: John Spray <john.spray@redhat.com>

Merge PR #23157 into master

* refs/pull/23157/head:
Provided API to change umask

Merge PR #23354 into master

* refs/pull/23354/head:
src/osd/PG.cc: remove redundant call to trim_log()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

doc/mgr/devicehealth: document devicehealth module

Signed-off-by: Sage Weil <sage@redhat.com>

doc/rados/operations/health-checks: document DEVICE_HEALTH* messages

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: fix style for returns

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: use constants for health warnings

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: deal with as many daemons as we can until limit

Process as many OSDs as we can until we hit the min_in_ratio.

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: warn if too many daemons are expected to fail soon

Refuse to mark out *all* OSDs.

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: set primary-affinity 0 for failing devices

Signed-off-by: Sage Weil <sage@redhat.com>

msg/devicehealth: fix config options

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: only fetch osdmap once from check_health

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: revise health messages

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: add 'device check-health' command and run periodically

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: fix new options

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/devicehealth: add helpers to life_expectancy_response()

- if mark_out_threshold is met we write to log.warn instead of raising a
  health warning.
- check that OSD is 'in' before calling mark_out().
- raise a health warning in case OSD is marked 'out' but still has PGs
  attached to it.
- cast thresholds default values to string.
- add SCSI multipath support to health warning message.
- change health warning message.

Signed-off-by: Yaarit Hatuka <yaarithatuka@gmail.com>

mgr/devicehealth: simplify setting defaults

Signed-off-by: Sage Weil <sage@redhat.com>

common/blkdev remove debug statements

Signed-off-by: Yaarit Hatuka yaarithatuka@gmail.com

Merge PR #23334 into master

* refs/pull/23334/head:
pybind/rados/rados: do not pass prval from stack

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #23217 from dzafman/wip-25085

osd: Allow repair of an object with a bad data_digest in object_info on all replicas

Reviewed-by: Sage Weil <sage@redhat.com>

src/osd/PG.cc: remove redundant call to trim_log()

This change is motived by the failure tracked in
https://tracker.ceph.com/issues/25198. The failure highlights a case, when a
call to trim_log() after the PG has recovered, races with the previous op,
on a replica OSD. Since the previous operation has not completed, the
last_complete value for that OSD is not valid, when we try to trim the
log. It is also worth noting that the race is due to MOSDPGTrim going through
the strict queue as a peering message vs regular ops going through the
non-strict queue.

During the investigation of this bug, we noticed that, with
https://tracker.ceph.com/issues/23979, we allow pg log trimming to
happen on the primary and replicas, whenever we cross the upper bound of
the pg log. This also ensures that pg log trimming happens while processing
any new op.

Therefore, the function trim_log(), which earlier served the purpose of
trimming logs on the primary and replicas, just before the PG went into
the Recovered state, is no more required. This acted like a last line of
defense to trim logs, when we did not need the logs any more. But, this call
seems redundant now, because, we are limiting the pg log length at all times.

Signed-off-by: Neha Ojha <nojha@redhat.com>

pybind/rados/rados: do not pass prval from stack

The prval is a pointer to an int to write the final completion code of
the rados op.  This can't be on the stack since we immediately leave the
current scope after preparing the op (looong before we do the rados op).

We keep the tuple return value to avoid breaking users of this API
(devicehealth module, gnocchi at a minimum).

Fixes: http://tracker.ceph.com/issues/25175
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #23348 from ceph/wip-rm24957

ceph-volume: adds test for `ceph-volume lvm list /dev/sda`

Reviewed-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: adds a unit test for `lvm list /dev/sda`

This test is to prove that the issue from
http://tracker.ceph.com/issues/24957 was fixed
by http://tracker.ceph.com/issues/24784

When running lvm list against a raw device it should handle
gracefully the situation where there are multiple PVs with the
name of the given device.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

ceph-volume: move pvolumes fixture into conftest.py

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #23336 from noahdesu/vstart-dashboard-no-rbd

vstart: disable dashboard when rbd not built

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #23297 into master

* refs/pull/23297/head:
ceph_volume_client: add delay for MDSMap to be distributed

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge PR #23308 into master

* refs/pull/23308/head:
doc: s/Ceph FS/CephFS

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

vstart: disable dashboard when rbd not built

dashboard doesn't load correctly without the rbd module, which means
vstart commands that interact with dashboard fail and vstart exits.

Signed-off-by: Noah Watkins <nwatkins@redhat.com>

Merge pull request #23292 from yuriw/wip-yuriw-25140-master

qa/tests: added 1st draft of mimic-x suite

Merge pull request #23302 from yuriw/wip-yuriw-crontab-master

qa/tests: added mimic-x to the schedule

Merge pull request #23321 from cernceph/dvanders_enable

ceph-volume: enable the ceph-osd during lvm activation

Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #23332 from alfredodeza/wip-rm25171

ceph-volume add a __release__ string, to help version-conditional calls

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #23305 from smithfarm/wip-cleanup-upgrade

qa/upgrade: cleanup for nautilus

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

qa/tests: added 1st draft of mimic-x suite

Fixes: https://tracker.ceph.com/issues/25140
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

ceph-volume add a __release__ string, to help version-conditional calls

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #23276 from tchaikov/wip-config-diff-lock

common/config: fix the lock in ConfigProxy::diff()

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #23251 from neha-ojha/wip-25112

osd,mon: increase mon_max_pg_per_osd to 250

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #23249 from liewegas/wip-mon-cx-nautilus

osd/OSDMap: fix CEPHX_V2 osd requirement to nautilus, not mimic

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #23229 from rjfd/wip-dashboard-query-params-bug

mgr/dashboard: fix query parameters in task annotated endpoints

Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge PR #22607 into master

* refs/pull/22607/head:
common/options: convert many TYPE_[U]INT -> TYPE_SIZE
common/options: remove journal_max_corrupt_search

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph-volume: enable ceph-osd during lvm activation

Enable the ceph-osd@<id> unit during lvm activate to link these
units to the ceph-osd.target.

Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
Fixes: http://tracker.ceph.com/issues/24152

ceph-volume: optional systemd enable --runtime

Allow units to be enabled but not persisted across a reboot,
and use this when enabling osds.

Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>

Merge pull request #23287 from Devp00l/wip-duplicate-error-messages

mgr/dashboard: Fix duplicate error messages

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #22669 from votdev/feature_24574

mgr/dashboard: Cleanup RGW config checks

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

qa/upgrade: cleanup for nautilus

Drop unused suites, which ATM means all of them except upgrade/luminous-x
which recently got a cleanup in https://github.com/ceph/ceph/pull/23162

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #23162 from smithfarm/wip-upgrade-cleanup

tests: upgrade/luminous-x: fix order of final-workload directory

Reviewed-by: Sage Weil <sage@redhat.com>

cmake: do not link libs against ${ALLOC_LIBS}

let libcommon or libceph-common take care of this.

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake,make-dist: build gperftools if WITH_STATIC_LIBSTDCXX

we could create a mini project to build a shared library, and use
try_compile() to test if the found gperftools is compiled with -fPIC.
but as we are targeting mostly xenial when enabling
WITH_STATIC_LIBSTDCXX, and google-perftools on xenial by default
is built without -fPIC. so let's keep it simple.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Provided API to change umask

Signed-off-by: Pavani Rajula <rpavani1998@gmail.com>

qa/tests: added mimic-x to the schedule

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

common/options: convert many TYPE_[U]INT -> TYPE_SIZE

Note that the _cost options are in fact in units of bytes.

Signed-off-by: Sage Weil <sage@redhat.com>

cmake: link against libsnappy.a if WITH_STATIC_LIBSTDCXX

Signed-off-by: Kefu Chai <kchai@redhat.com>

rocksdb: pickup change to link against libsnappy.a

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: fix "WITH_STATIC_LIBSTDCXX"

- do not link libkv with ALLOC_LIBS, it turns out that if we link
tcmalloc *before* -static-libstdc++ -static-libgcc, libstdc++ and gcc
libs will show up in `ldd` output
- add `-static-libstdc++ -static-libgcc` to CMAKE_SHARED_LINKER_FLAGS
and CMAKE_EXE_LINKER_FLAGS instead of adding them to all shared
libraries and executable. simpler this way.
- link against libtcmalloc statically, because libtcmalloc is a C++
library, linking against it dynamically and linking against C++ runtime
statically will pull in depdencies on two versions of C++ runtime, which
will bring down the app at run-time.
- do not pass '-pie' to linker when building executable if
`WITH_STATIC_LIBSTDCXX` and tcmalloc is used, because the static tcmalloc
is not compiled with PIC.
- only apply '-pie' if ENABLE_SHARED is enabled.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc: s/Ceph FS/CephFS

Fixes: https://github.com/ceph/ceph/pull/22784#discussion_r200755460
Signed-off-by: Jos Collin <jcollin@redhat.com>

Merge pull request #23043 from tchaikov/wip-python-cephfs-dependencies

deb,rpm: fix python-cephfs dependencies

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

ceph_volume_client: add delay for MDSMap to be distributed

Otherwise the setxattr will fail if the mds has not yet received the MDSMap
which adds the new data pool.

Fixes: https://tracker.ceph.com/issues/25141
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #23288 from theanalyst/doc/releases/13.2.1

doc: releases: mimic 13.2.1 release notes

Reviewed-By: Sage Weil <sweil@redhat.com>

Merge pull request #23278 from b-ranto/wip-volume-selinux

ceph-volume: Restore SELinux context

Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #23106 from noahdesu/always-on-mgr-modules2

mgr: create always on class of modules

Merge pull request #23143 from joke-lee/qa-admin-api-user-info-through-access-key

qa: add test for https://github.com/ceph/ceph/pull/22790

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #23289 from alfredodeza/wip-rm24993-2

ceph-volume ensure encoded bytes are always used

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

ceph-volume: Restore SELinux context

We need to reset the root context of the file system after mounting it.
Otherwise, the SELinux policy rules will not be preserved.

Fixes: https://tracker.ceph.com/issues/24785
Signed-off-by: Boris Ranto <branto@redhat.com>

Merge pull request #23277 from zy751713126/fix_note

cls/rbd: fix method comment

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #23279 from tchaikov/wip-cmake-cleanup

cmake: cleanups

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #23283 from tchaikov/wip-cmake-fmt

cmake: bump up the required fmt version

Reviewed-by: Casey Bodley <cbodley@redhat.com>

doc: releases: mimic 13.2.1 release notes

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

ceph-volume tests.util verify as_bytes behavior

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume tests catch utf-8 encoded stdin errors

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume process use the as_bytes util for stdin

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume util create a helper for converting to bytes

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #22994 from tspmelo/wip-prettier-lint

mgr/dashboard: Improve prettier scripts and documentation

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Fix duplicate error messages

Duplicate error messages currently appear if the task wrapper service is
used. It calls 'notifyTask' on a failed task, this would be fine if
we didn't have the API interceptor, which watches all API requests and
triggers 'notifyTask' itself if an error appears.

Fixes issue #25139

Signed-off-by: Stephan Müller <smueller@suse.com>

Merge pull request #23281 from tspmelo/wip-opaque

mgr/dashboard: Fix localStorage problem in Jest

Reviewed-by: Kefu Chai <kchai@redhat.com>

cmake: bump up the required fmt version

seastar actually requires fmt 4.0.0 and up, as 3.0.2 does not offer
fmt/printf.h. see
https://github.com/fmtlib/fmt/blob/master/ChangeLog.rst#400---2017-06-27
.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Fix localStorage problem in Jest

Latest version of Jest was showing the following error:
"SecurityError: localStorage is not available for opaque origins"

Signed-off-by: Tiago Melo <tmelo@suse.com>

cmake: extract mgr into its own CMakeLists.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: extract common,msg out of src/CMakeLists.txt

* add arch as a static library.
* add crc32 as a static library. its only dependency is libarch.

Signed-off-by: Kefu Chai <kchai@redhat.com>

cls/rbd: fix note

Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>

Merge pull request #23254 from tchaikov/wip-cmake-cleanup

cmake: modularize src/perfglue

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #23255 from tchaikov/wip-seastar-yaml-cpp

seastar: lower the required yaml-cpp version to 0.5.1

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #23253 from smithfarm/wip-doc-dev-toc

doc: make it easier to reach the old dev doc TOC

Reviewed-by: Dan Mick <dan.mick@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

common/config: fix the lock in ConfigProxy::diff()

it's a regression introduced by e406d8eb9e1deb801ecb346169eaaf96adbb4b53

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/dev/internals: drop :orphan: directive

Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #23165 from smithfarm/wip-doc-snaptrim-nit

doc/rados/operations/pg-states: fix PG state names, part 2

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge pull request #23072 from fullerdj/wip-djf-24687

mon/OSDMonitor: Warnings for expected_num_objects

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #23268 from ceph/simple-testinfra-version

ceph-volume: do not pin the testinfra version for the simple tests

Reviewed-by: Alfredo Deza <adeza@redhat.com>

ceph-volume: do not pin the testinfra version for the simple tests

For testinfra to work with a 2.6.x version of ansible it must use the
latest version.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

mon/OSDMonitor: Warn if missing expected_num_objects

When creating a pool on filestore, warn if the user appears to be
creating a pool to store a large number of objects but omitted the
expected_num_objects parameter. Create the pool anyway.

Fixes: http://tracker.ceph.com/issues/24687
Signed-off-by: Douglas Fuller <dfuller@redhat.com>

osd,mon: increase mon_max_pg_per_osd to 250

https://bugzilla.redhat.com/show_bug.cgi?id=1603615 indicates
a case when pg calc conflicts with mon_max_pg_per_osd, and does not
allow pool creation when this limit is 200. Hence, increase this limit
to avoid this.

Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge pull request #23263 from ceph/simple-ansible-version

ceph-volume: update version of ansible to 2.6.x for simple tests

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

ceph-volume: update version of ansible to 2.6.x for simple tests

ceph-ansible now requires a 2.5.x or 2.6.x version of ansible if you're
using the master branch. This updates our functional tests for the
simple subcommand to use a 2.6.x version of ansible.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

test: Add test for repair of bad object info data_digest on all copies

Signed-off-by: David Zafman <dzafman@redhat.com>