]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
6 years agoosd/PrimaryLogPG.cc: reassign size only when object size > truncate_size 24564/head
Neha Ojha [Tue, 9 Oct 2018 22:57:15 +0000 (15:57 -0700)]
osd/PrimaryLogPG.cc: reassign size only when object size > truncate_size

Before setting size equal to op.extent.truncate_size, we need to check
if the size of the object is greater than the truncate_size. We do not
need to set size to op.extent.truncate_size, in the case where the size of
the object is less than op.extent.truncate_size.

Without this change, we were always setting size =
op.extent.truncate_size, when (seq < op.extent.truncate_seq) and
(op.extent.offset + op.extent.length > op.extent.truncate_size), were both
true. This ended up in:

1. overestimating the size of the object
2. not considering the correct size of the object, for
   the later checks, which calculate op.extent.length for the read ops
3. causing crashes when trying to read more data than what was present

Fixes: http://tracker.ceph.com/issues/21931
Fixes: http://tracker.ceph.com/issues/22330
Signed-off-by: Neha Ojha <nojha@redhat.com>
6 years agoosd: print offset and length to track trimtrunc
Neha Ojha [Wed, 26 Sep 2018 23:31:44 +0000 (16:31 -0700)]
osd: print offset and length to track trimtrunc

Signed-off-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge pull request #24428 from trociny/wip-rbd-config-global
Jason Dillaman [Thu, 11 Oct 2018 14:50:33 +0000 (10:50 -0400)]
Merge pull request #24428 from trociny/wip-rbd-config-global

rbd: add 'config global' command to get/store overrides in mon config db

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge PR #24541 into master
Sage Weil [Thu, 11 Oct 2018 14:09:07 +0000 (09:09 -0500)]
Merge PR #24541 into master

* refs/pull/24541/head:
common/config.h: fix spelling error in this file

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge PR #24305 into master
Sage Weil [Thu, 11 Oct 2018 12:27:11 +0000 (07:27 -0500)]
Merge PR #24305 into master

* refs/pull/24305/head:
msg/async: ProtocolV1: use continuations instead of direct function calls
msg/async: ProtocolV1 state machine ascii diagram

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
6 years agoMerge pull request #24404 from ceph/wip-batch-report-idempotent
Alfredo Deza [Thu, 11 Oct 2018 11:51:22 +0000 (07:51 -0400)]
Merge pull request #24404 from ceph/wip-batch-report-idempotent

ceph-volume: make `lvm batch` idempotent

Reviewed-by: Alfredo Deza <adeza@redhat.com>
6 years agocommon/config.h: fix spelling error in this file 24541/head
xiaomanh [Thu, 11 Oct 2018 10:00:51 +0000 (18:00 +0800)]
common/config.h: fix spelling error in this file

Signed-off-by: xiaomanh <huangxiaoman@cmss.chinamobile.com>
6 years agoMerge pull request #24425 from b-ranto/wip-ld-hardening
Boris Ranto [Thu, 11 Oct 2018 09:55:37 +0000 (04:55 -0500)]
Merge pull request #24425 from b-ranto/wip-ld-hardening

rpm: Use hardened LDFLAGS

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
6 years agoMerge PR #23069 into master
Patrick Donnelly [Wed, 10 Oct 2018 22:29:41 +0000 (15:29 -0700)]
Merge PR #23069 into master

* refs/pull/23069/head:
tests/libcephfs: add simple reclaim test
mds: check auth name before reclaiming session
mds: reclaim session before allowing mds to become active
mds: allow client to specify its session timeout
mds: initial code for client states reclaim

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoceph-volume: extracts batch.filter_devices from Batch._get_strategy 24404/head
Andrew Schoen [Wed, 10 Oct 2018 19:28:29 +0000 (15:28 -0400)]
ceph-volume: extracts batch.filter_devices from Batch._get_strategy

This allows us to easily provide tests for that method.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: failing to get block db size from conf logs an exception
Andrew Schoen [Wed, 10 Oct 2018 18:05:25 +0000 (14:05 -0400)]
ceph-volume: failing to get block db size from conf logs an exception

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: when all devices are filtered exit gracefully
Andrew Schoen [Tue, 9 Oct 2018 18:05:54 +0000 (14:05 -0400)]
ceph-volume: when all devices are filtered exit gracefully

Even if all devices are filtered we want to return a 0 exit code and
make sure the json reporting still works.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: filter devices used by journals/block.db
Andrew Schoen [Mon, 8 Oct 2018 13:57:07 +0000 (09:57 -0400)]
ceph-volume: filter devices used by journals/block.db

If after filterering of data/block devices there are only
one device left it can not be used if it is an SSD and
has been used previously as a journal or block.db

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: add rotational property to Device class
Andrew Schoen [Mon, 8 Oct 2018 13:39:05 +0000 (09:39 -0400)]
ceph-volume: add rotational property to Device class

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: add info about filtered devices to batch pretty reports
Andrew Schoen [Fri, 5 Oct 2018 21:18:48 +0000 (16:18 -0500)]
ceph-volume: add info about filtered devices to batch pretty reports

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: remove the used_by_ceph key in the json output
Andrew Schoen [Fri, 5 Oct 2018 15:45:35 +0000 (10:45 -0500)]
ceph-volume: remove the used_by_ceph key in the json output

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: fix idempotency checks for lvm batch tests
Andrew Schoen [Fri, 5 Oct 2018 15:39:54 +0000 (10:39 -0500)]
ceph-volume: fix idempotency checks for lvm batch tests

The mixed type tests will change strategy after the idempotency test so
we need to handle that in test playbook.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: fix bluestore strategy json reporting and type
Andrew Schoen [Fri, 5 Oct 2018 15:38:11 +0000 (10:38 -0500)]
ceph-volume: fix bluestore strategy json reporting and type

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: ignore failure to load ceph configuration for block.db size
Andrew Schoen [Thu, 4 Oct 2018 17:47:48 +0000 (12:47 -0500)]
ceph-volume: ignore failure to load ceph configuration for block.db size

If we fail to load a ceph configureation file when trying to get the
block.db size then just use defaults instead of throwing an error.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: fix strategy comparison in 'lvm batch'
Andrew Schoen [Thu, 4 Oct 2018 16:54:06 +0000 (11:54 -0500)]
ceph-volume: fix strategy comparison in 'lvm batch'

This also fixes some small json reporting issues with the
filestore MixedType strategy

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: raise a non zero exit code if strategy changes with batch
Andrew Schoen [Wed, 3 Oct 2018 20:01:08 +0000 (15:01 -0500)]
ceph-volume: raise a non zero exit code if strategy changes with batch

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: add functional tests to ensure lvm batch is idempotent
Andrew Schoen [Wed, 3 Oct 2018 17:13:27 +0000 (12:13 -0500)]
ceph-volume: add functional tests to ensure lvm batch is idempotent

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: add tests for util.device.Device.used_by_ceph
Andrew Schoen [Wed, 3 Oct 2018 15:19:45 +0000 (10:19 -0500)]
ceph-volume: add tests for util.device.Device.used_by_ceph

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: update tests to account for filtered_devices in batch
Andrew Schoen [Tue, 2 Oct 2018 20:23:39 +0000 (15:23 -0500)]
ceph-volume: update tests to account for filtered_devices in batch

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: consider block and data devices used_by_ceph
Andrew Schoen [Tue, 2 Oct 2018 20:08:10 +0000 (15:08 -0500)]
ceph-volume: consider block and data devices used_by_ceph

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: add filtered_devices and used_by_ceph to all batch reports
Andrew Schoen [Tue, 2 Oct 2018 14:48:27 +0000 (09:48 -0500)]
ceph-volume: add filtered_devices and used_by_ceph to all batch reports

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: pick strategy for batch with only the unused devices
Andrew Schoen [Thu, 27 Sep 2018 20:22:17 +0000 (15:22 -0500)]
ceph-volume: pick strategy for batch with only the unused devices

This will pick a strategy, filter out any devices already been used by
ceph and then pick a strategy again. If the strategy has changed the
call should error, if the strategy is the same proceed. If there are no
unused devices then the command is a noop.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: adds a 'changed' key to lvm batch --report
Andrew Schoen [Thu, 27 Sep 2018 13:55:20 +0000 (08:55 -0500)]
ceph-volume: adds a 'changed' key to lvm batch --report

This will indicate if the command would result in any OSDs being created
or not. Other tooling can use that key for idempotency checks.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: adds used_by_ceph to filestore singletype batch report
Andrew Schoen [Wed, 26 Sep 2018 21:07:30 +0000 (16:07 -0500)]
ceph-volume: adds used_by_ceph to filestore singletype batch report

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: adds a used_by_ceph property to the Device class
Andrew Schoen [Wed, 26 Sep 2018 21:01:30 +0000 (16:01 -0500)]
ceph-volume: adds a used_by_ceph property to the Device class

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: adds a lvs property to the Device class
Andrew Schoen [Wed, 26 Sep 2018 20:53:26 +0000 (15:53 -0500)]
ceph-volume: adds a lvs property to the Device class

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoceph-volume: add vg_name to the Device class
Andrew Schoen [Wed, 26 Sep 2018 19:29:41 +0000 (14:29 -0500)]
ceph-volume: add vg_name to the Device class

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
6 years agoMerge pull request #24525 from jtlayton/k8s-no-module-warn
John Spray [Wed, 10 Oct 2018 17:27:46 +0000 (18:27 +0100)]
Merge pull request #24525 from jtlayton/k8s-no-module-warn

mgr/orchestrator: clarify error message about kubernetes python module

Reviewed-by: John Spray <john.spray@redhat.com>
6 years agoMerge pull request #24476 from dillaman/wip-35944
Mykola Golub [Wed, 10 Oct 2018 15:40:14 +0000 (18:40 +0300)]
Merge pull request #24476 from dillaman/wip-35944

librbd: add new configuration option to always move deleted items to the trash

Reviewed-by: Mykola Golub <mgolub@suse.com>
6 years agoMerge pull request #24512 from trociny/wip-qa-namespace-create_args
Jason Dillaman [Wed, 10 Oct 2018 14:42:08 +0000 (10:42 -0400)]
Merge pull request #24512 from trociny/wip-qa-namespace-create_args

qa/workunits/rbd: force v2 image format for namespace test

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agorbd: add 'config global' command to get/store overrides in mon config db 24428/head
Mykola Golub [Thu, 4 Oct 2018 15:09:16 +0000 (18:09 +0300)]
rbd: add 'config global' command to get/store overrides in mon config db

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agoqa/workunits/rbd: test new move-to-trash on image remove config override 24476/head
Jason Dillaman [Mon, 8 Oct 2018 14:50:32 +0000 (10:50 -0400)]
qa/workunits/rbd: test new move-to-trash on image remove config override

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
6 years agolibrbd: optionally move image to trash when removed by user
Jason Dillaman [Mon, 8 Oct 2018 14:46:18 +0000 (10:46 -0400)]
librbd: optionally move image to trash when removed by user

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
6 years agolibrbd: move remove API method to api namespace
Jason Dillaman [Mon, 8 Oct 2018 14:09:39 +0000 (10:09 -0400)]
librbd: move remove API method to api namespace

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
6 years agolibrbd: move trash API methods to api namespace
Jason Dillaman [Mon, 8 Oct 2018 13:55:18 +0000 (09:55 -0400)]
librbd: move trash API methods to api namespace

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #24407 from alfredodeza/wip-rm26953
Andrew Schoen [Wed, 10 Oct 2018 12:57:34 +0000 (08:57 -0400)]
Merge pull request #24407 from alfredodeza/wip-rm26953

ceph-volume: allow to specify --cluster-fsid instead of reading from ceph.conf

Reviewed-by: Andrew Schoen <aschoen@redhat.com>
6 years agoMerge pull request #24515 from tchaikov/wip-cmake-rgw
Kefu Chai [Wed, 10 Oct 2018 12:32:02 +0000 (20:32 +0800)]
Merge pull request #24515 from tchaikov/wip-cmake-rgw

cmake: do not use plain target_link_libraries(rgw_a ...)

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Kai Wagner <kwagner@suse.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
6 years agoMerge pull request #23622 from renhwztetecs/renhw-wip-25103
John Spray [Wed, 10 Oct 2018 12:28:33 +0000 (13:28 +0100)]
Merge pull request #23622 from renhwztetecs/renhw-wip-25103

mgr: fixup pgs show in unknown state

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: John Spray <john.spray@redhat.com>
6 years agoMerge pull request #24448 from votdev/bug_36325
Ricardo Marques [Wed, 10 Oct 2018 11:18:35 +0000 (12:18 +0100)]
Merge pull request #24448 from votdev/bug_36325

mgr/dashboard: Performance counter progress bar keeps infinitely looping

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
6 years agoMerge pull request #23970 from noahdesu/mgr-always-on-mods-v2
John Spray [Wed, 10 Oct 2018 11:17:41 +0000 (12:17 +0100)]
Merge pull request #23970 from noahdesu/mgr-always-on-mods-v2

mgr: always on modules v2

Reviewed-by: John Spray <john.spray@redhat.com>
6 years agoMerge pull request #24239 from votdev/python_ceph_audit_log
John Spray [Wed, 10 Oct 2018 10:47:49 +0000 (11:47 +0100)]
Merge pull request #24239 from votdev/python_ceph_audit_log

mgr: Add ability to trigger a cluster/audit log message from Python

Reviewed-by: John Spray <john.spray@redhat.com>
6 years agocmake: do not use plain target_link_libraries(rgw_a ...) 24515/head
Kefu Chai [Wed, 10 Oct 2018 10:18:03 +0000 (18:18 +0800)]
cmake: do not use plain target_link_libraries(rgw_a ...)

this addresses following error:

CMake Error at src/rgw/CMakeLists.txt:178 (target_link_libraries):
  The plain signature for target_link_libraries has already been used
with
  the target "rgw_a".  All uses of target_link_libraries with a target
must
  be either all-keyword or all-plain.

  The uses of the plain signature are here:

   * src/rgw/CMakeLists.txt:168 (target_link_libraries)

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #24487 from badone/wip-undefined-references-to-dpdk-symbols
Kefu Chai [Wed, 10 Oct 2018 08:48:22 +0000 (16:48 +0800)]
Merge pull request #24487 from badone/wip-undefined-references-to-dpdk-symbols

cmake/modules/BuildDPDK.cmake: Build required DPDK libraries

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #24450 from dillaman/wip-rbd-conf-keys
Mykola Golub [Wed, 10 Oct 2018 08:01:50 +0000 (11:01 +0300)]
Merge pull request #24450 from dillaman/wip-rbd-conf-keys

librbd: simplify config override handling

Reviewed-by: Mykola Golub <mgolub@suse.com>
6 years agoqa/workunits/rbd: force v2 image format for namespace test 24512/head
Mykola Golub [Wed, 10 Oct 2018 07:46:14 +0000 (10:46 +0300)]
qa/workunits/rbd: force v2 image format for namespace test

While here, fix test_locking too.

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agoMerge pull request #24509 from badone/wip-releases-add-13.2.2
Kefu Chai [Wed, 10 Oct 2018 06:47:51 +0000 (14:47 +0800)]
Merge pull request #24509 from badone/wip-releases-add-13.2.2

doc/releases: Add Mimic release 13.2.2

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #24368 from tchaikov/wip-cmake-cleanup
Kefu Chai [Wed, 10 Oct 2018 04:39:06 +0000 (12:39 +0800)]
Merge pull request #24368 from tchaikov/wip-cmake-cleanup

cmake: use OpenSSL::Crypto instead of OPENSSL_LIBRARIES

Reviewed-by: Casey Bodley <cbodley@redhat.com>
6 years agocmake/modules/BuildDPDK.cmake: Build required DPDK libraries 24487/head
Brad Hubbard [Tue, 9 Oct 2018 08:58:58 +0000 (18:58 +1000)]
cmake/modules/BuildDPDK.cmake: Build required DPDK libraries

Make sure the mbuf and ethdev libraries are created as they export
required symbols.

Fixes: http://tracker.ceph.com/issues/36341
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
6 years agodoc/releases: Add Mimic release 13.2.2 24509/head
Brad Hubbard [Wed, 10 Oct 2018 02:23:55 +0000 (12:23 +1000)]
doc/releases: Add Mimic release 13.2.2

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
6 years agorbd: nicer help output for commands without options
Mykola Golub [Sun, 7 Oct 2018 16:22:34 +0000 (19:22 +0300)]
rbd: nicer help output for commands without options

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agorbd: print long aliases specs shorter in help output
Mykola Golub [Sun, 7 Oct 2018 15:12:02 +0000 (18:12 +0300)]
rbd: print long aliases specs shorter in help output

(by substituting the common part with '...')

Signed-off-by: Mykola Golub <mgolub@suse.com>
6 years agoMerge PR #24496 into master
Patrick Donnelly [Tue, 9 Oct 2018 18:23:47 +0000 (11:23 -0700)]
Merge PR #24496 into master

* refs/pull/24496/head:
doc: fix typo in blkin.rst

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoMerge pull request #24484 from hsiang41/mgr/predictor_model_file
Sage Weil [Tue, 9 Oct 2018 16:56:51 +0000 (11:56 -0500)]
Merge pull request #24484 from hsiang41/mgr/predictor_model_file

mgr/diskprediction: Replace local predictor model file

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge pull request #21614 from Devp00l/pool-creation-form
Ricardo Marques [Tue, 9 Oct 2018 16:29:09 +0000 (17:29 +0100)]
Merge pull request #21614 from Devp00l/pool-creation-form

mgr/dashboard: Pool management

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #24497 from idryomov/wip-clarify-copy-from
Gregory Farnum [Tue, 9 Oct 2018 16:22:07 +0000 (09:22 -0700)]
Merge pull request #24497 from idryomov/wip-clarify-copy-from

include/rados: clarify which flags go where for copy_from

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
6 years agocmake: use OpenSSL::Crypto instead of OPENSSL_LIBRARIES 24368/head
Kefu Chai [Tue, 2 Oct 2018 07:56:19 +0000 (15:56 +0800)]
cmake: use OpenSSL::Crypto instead of OPENSSL_LIBRARIES

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoinclude/rados: clarify which flags go where for copy_from 24497/head
Ilya Dryomov [Tue, 9 Oct 2018 14:43:58 +0000 (16:43 +0200)]
include/rados: clarify which flags go where for copy_from

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
6 years agodoc: fix typo in blkin.rst 24496/head
Scoots Hamilton [Tue, 9 Oct 2018 14:46:39 +0000 (10:46 -0400)]
doc: fix typo in blkin.rst

Signed-off-by: Scoots Hamilton <scoots@redhat.com>
6 years agoMerge pull request #24491 from tchaikov/wip-add-erasure-clay-in-release-note
Kefu Chai [Tue, 9 Oct 2018 14:17:55 +0000 (22:17 +0800)]
Merge pull request #24491 from tchaikov/wip-add-erasure-clay-in-release-note

PendingReleaseNotes: note newly added CLAY code

Reviewed-by: Sage Weil <sage@redhat.com>
6 years agomgr/dashboard: New formatter byte unit tests 21614/head
Stephan Müller [Mon, 24 Sep 2018 13:36:15 +0000 (15:36 +0200)]
mgr/dashboard: New formatter byte unit tests

Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Unset any compression setting for pools in UI
Stephan Müller [Fri, 21 Sep 2018 08:08:19 +0000 (10:08 +0200)]
mgr/dashboard: Unset any compression setting for pools in UI

The dashboard API now can delete all compression options if the
compression mode is set to 'unset' during edit. Other dismissed options
will be overwritten with the reset value on submit, which will cause
the deletion of the previously set settings.

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agoMerge pull request #23230 from s0nea/wip-dashboard-config-options-add
Ricardo Marques [Tue, 9 Oct 2018 14:07:50 +0000 (15:07 +0100)]
Merge pull request #23230 from s0nea/wip-dashboard-config-options-add

mgr/dashboard config options add

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agomgr/dashboard: Update PG update test
Stephan Müller [Tue, 9 Oct 2018 06:37:03 +0000 (08:37 +0200)]
mgr/dashboard: Update PG update test

It is now commented out like it was before,
but I've added a comment what happened during this test with the QA
system. The problem was that even with only a increase of 1 PG the QA
cluster went into a cluster warning state and did not recover in time.
The QA coverage timeout is 2 minutes.

I could not reproduce this behavior with a local cluster, but I've
added a loop to wait until pgp and pg number are equal and the cluster
is in a healthy state again. This can take locally about 5 seconds.
The internal loop has a timeout of 3 minutes.

Fixes: https://tracker.ceph.com/issues/36362
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Unset compression arguments for pools
Stephan Müller [Tue, 9 Oct 2018 06:35:41 +0000 (08:35 +0200)]
mgr/dashboard: Unset compression arguments for pools

The dashboard backend can now unset all set compression arguments if the
compression mode is switched to 'unset'. In the case of 'unset' Ceph
itself will only delete the 'compression_mode' argument, not all other
set arguments. The other arguments that should be removed, too, are
added to the update arguments in order to delete all set arguments.

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Readd pool notifications
Stephan Müller [Mon, 27 Aug 2018 14:45:22 +0000 (16:45 +0200)]
mgr/dashboard: Readd pool notifications

As of the merge of cleaner notifications, the notification component was
refactored and move this caused a loss of previously added
notifications.

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Use task list service in pool list
Stephan Müller [Wed, 15 Aug 2018 10:02:48 +0000 (12:02 +0200)]
mgr/dashboard: Use task list service in pool list

Now the pool list uses the task list service to monitor all tasks, in
order to extend each pool item with corresponding tasks if any. If there
is a running task for a pool you will see what action runs on it in the
listing.

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Handle pool permissions
Stephan Müller [Mon, 2 Jul 2018 17:33:13 +0000 (19:33 +0200)]
mgr/dashboard: Handle pool permissions

Handles pool action permissions in pool listing.

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Pool delete
Stephan Müller [Fri, 29 Jun 2018 12:18:46 +0000 (14:18 +0200)]
mgr/dashboard: Pool delete

You can delete pools through the UI, this will generate a task that
deletes the pool in the background.

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Pool create / edit
Stephan Müller [Fri, 29 Jun 2018 12:13:37 +0000 (14:13 +0200)]
mgr/dashboard: Pool create / edit

You can create/edit pools through the UI if you have the right
permissions.

You can specify the following:
* Name - can't be duplicated
* Type - replicated or erasure
* Crush rule set
  * Validates if you can use it
  * A popover tells which crush steps are used
* Replica size - depends on your selected rule and the amount of OSDs
* Erasure code profile
* PGs - will be recalculated on form changes (type, replica size,
    erasure profile, crush rule) only if not set before
* EC overwrites flag
* Compression - Algorithm / Min/max blob size / mode / ratio
* Application metadata - Predefined and custom applications as badges

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agoMerge pull request #24471 from tchaikov/wip-doc-serve-doc
Kefu Chai [Tue, 9 Oct 2018 13:22:20 +0000 (21:22 +0800)]
Merge pull request #24471 from tchaikov/wip-doc-serve-doc

doc: add instructions about using "serve-doc" to preview built document

Reviewed-by: Alfredo Deza <adeza@redhat.com>
6 years agoPendingReleaseNotes: note newly added CLAY code 24491/head
Kefu Chai [Tue, 9 Oct 2018 10:50:16 +0000 (18:50 +0800)]
PendingReleaseNotes: note newly added CLAY code

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #24477 from tchaikov/wip-live-with-slow-list-size
Kefu Chai [Tue, 9 Oct 2018 13:05:25 +0000 (21:05 +0800)]
Merge pull request #24477 from tchaikov/wip-live-with-slow-list-size

cmake: remove checking for GCC 5.1

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
6 years agomgr/dashboard: Return errors to subscriber of task-wrapper
Stephan Müller [Tue, 7 Aug 2018 14:16:47 +0000 (16:16 +0200)]
mgr/dashboard: Return errors to subscriber of task-wrapper

Fixes: https://tracker.ceph.com/issues/36360
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Fixes user roles
Stephan Müller [Tue, 7 Aug 2018 12:20:38 +0000 (14:20 +0200)]
mgr/dashboard: Fixes user roles

Due to changes in the badges component, user roles had to be amended.

Fixes: https://tracker.ceph.com/issues/36357
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Add badge filtering
Stephan Müller [Thu, 9 Aug 2018 12:02:50 +0000 (14:02 +0200)]
mgr/dashboard: Add badge filtering

It's now possible to filter badges and create badges via a create badges
label.

Fixes: https://tracker.ceph.com/issues/36357
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: add create functionality to the frontend 23230/head
Tatjana Dehler [Wed, 22 Aug 2018 13:18:57 +0000 (15:18 +0200)]
mgr/dashboard: add create functionality to the frontend

Add the missing functionality to create config options and related
tests to the frontend.

Fixes: http://tracker.ceph.com/issues/24455
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: Enable custom badges
Stephan Müller [Tue, 7 Aug 2018 12:23:26 +0000 (14:23 +0200)]
mgr/dashboard: Enable custom badges

Enables custom badges within badges component.

It's possible to use custom validations and custom error messages.

Fixes: https://tracker.ceph.com/issues/36357
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Amend pool backend tasks
Stephan Müller [Tue, 31 Jul 2018 10:32:10 +0000 (12:32 +0200)]
mgr/dashboard: Amend pool backend tasks

Amends pool tasks in order to get the right results back into the UI
and also to have tasks with the same attributes.

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Add pool type definition
Stephan Müller [Fri, 29 Jun 2018 12:08:49 +0000 (14:08 +0200)]
mgr/dashboard: Add pool type definition

Adds pool type definition which is used in pool listing.

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Add crush rule type definitions
Stephan Müller [Fri, 23 Mar 2018 17:09:21 +0000 (18:09 +0100)]
mgr/dashboard: Add crush rule type definitions

There are two type definitions one for the crush rule itself and one
for the crush step definition which is used inside the crush rule
definition.

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: Erasure code profile interface
Stephan Müller [Wed, 27 Jun 2018 14:58:20 +0000 (16:58 +0200)]
mgr/dashboard: Erasure code profile interface

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: add missing parameter type and related test
Tatjana Dehler [Wed, 22 Aug 2018 11:03:28 +0000 (13:03 +0200)]
mgr/dashboard: add missing parameter type and related test

Added missing parameter type and a test for this service method.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: add config options form
Tatjana Dehler [Mon, 25 Jun 2018 14:30:16 +0000 (16:30 +0200)]
mgr/dashboard: add config options form

Fixes: http://tracker.ceph.com/issues/24455
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: add pattern validators
Tatjana Dehler [Thu, 27 Sep 2018 11:22:05 +0000 (13:22 +0200)]
mgr/dashboard: add pattern validators

Add some pattern validators (ip, uuid, number, decimalNumber) that
are needed to validate the config option input values.

Fixes: http://tracker.ceph.com/issues/24455
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: Erasure code service
Stephan Müller [Wed, 27 Jun 2018 14:57:41 +0000 (16:57 +0200)]
mgr/dashboard: Erasure code service

Fixes: https://tracker.ceph.com/issues/36355
Signed-off-by: Stephan Müller <smueller@suse.com>
6 years agomgr/dashboard: add placeholder for filters to datatable
Tatjana Dehler [Fri, 6 Jul 2018 12:27:12 +0000 (14:27 +0200)]
mgr/dashboard: add placeholder for filters to datatable

As (e.g.) the configuration option documentation has dropdown menus
with pre-defined filters we need a placeholder for them in the
datatable.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: move config table details to their own component
Tatjana Dehler [Mon, 8 Oct 2018 09:49:11 +0000 (11:49 +0200)]
mgr/dashboard: move config table details to their own component

Fixes: http://tracker.ceph.com/issues/24455
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: add backend method to create config options
Tatjana Dehler [Mon, 25 Jun 2018 14:19:41 +0000 (16:19 +0200)]
mgr/dashboard: add backend method to create config options

Fixes: http://tracker.ceph.com/issues/24455
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: fix typo
Tatjana Dehler [Thu, 16 Aug 2018 12:11:34 +0000 (14:11 +0200)]
mgr/dashboard: fix typo

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: fix missing import
Tatjana Dehler [Wed, 15 Aug 2018 13:56:09 +0000 (15:56 +0200)]
mgr/dashboard: fix missing import

Added the missing import otherwise the 'should create' test will fail
because the received component is undefined.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: refactor '_get_mon_allow_pool_delete_config'
Tatjana Dehler [Fri, 29 Jun 2018 10:50:42 +0000 (12:50 +0200)]
mgr/dashboard: refactor '_get_mon_allow_pool_delete_config'

Refactor '_get_mon_allow_pool_delete_config' method to be a little bit
more general. The method can now be used to get the value of every
config option known to the cluster.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agoMerge pull request #24392 from joscollin/wip-fix-fs-status
Jos Collin [Tue, 9 Oct 2018 11:06:02 +0000 (16:36 +0530)]
Merge pull request #24392 from joscollin/wip-fix-fs-status

pybind/mgr: identify invalid fs

Reviewed-by: John Spray <john.spray@redhat.com>
6 years agoMerge pull request #24422 from mynaramana/claydoc
Kefu Chai [Tue, 9 Oct 2018 09:50:14 +0000 (17:50 +0800)]
Merge pull request #24422 from mynaramana/claydoc

docs: add Clay code plugin documentation

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #23666 from rhcs-dashboard/grafana-integration
Ricardo Marques [Tue, 9 Oct 2018 08:29:08 +0000 (09:29 +0100)]
Merge pull request #23666 from rhcs-dashboard/grafana-integration

mgr/dashboard: Grafana graphs integration with dashboard

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agomgr/dashboard: Performance counter progress bar keeps infinitely looping 24448/head
Volker Theile [Fri, 5 Oct 2018 09:20:35 +0000 (11:20 +0200)]
mgr/dashboard: Performance counter progress bar keeps infinitely looping

Fixes: https://tracker.ceph.com/issues/36325
Signed-off-by: Volker Theile <vtheile@suse.com>