osd, test: Add test case with osd support for overdue PG scrubs and deep scrubs

Add trigger_deep_scrub osd command for testing
Publish stats when trigger_scrub/trigger_deep_scrub is used for testing
Add optional argument to trigger_scrub/trigger_deep_scrub
for amount of extra time to change last scrub stamps

Signed-off-by: David Zafman <dzafman@redhat.com>

mon: Fix scrub health warning handling and change config to a ratio

Make this mon_warn code clearer since it involves 2 values
Code used mon scrub interval instead of pg scrub interval
Rename config values to include _pg_ and ratio to make it more clear
Fix scrub warniing handling use per-pool intervals when specified

Fixes: http://tracker.ceph.com/issues/37264
Signed-off-by: David Zafman <dzafman@redhat.com>

common: Fix some configuration descriptions

osd_scrub_backoff_ratio
osd_deep_scrub_randomize_ratio

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Increase log level in PG::_update_calc_stats()

Signed-off-by: David Zafman <dzafman@redhat.com>

test: Correct typo trying to call flush_pg_stats

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge PR #26017 into master

* refs/pull/26017/head:
ceph: cleanup mds ceph status output

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26079 from trociny/wip-38006

librbd: properly filter out trashed non-user images on purge

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25984 from tspmelo/wip-fix-summary

mgr/dashboard: Fix summary refresh call stack

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

mgr/dashboard: Fix summary refresh call stack

Currently each time we created a task it would call the summary refresh method.
Since that method was a recursive method, overtime we would get N calls to the
refresh each 5 seconds.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #25988 from Exotelis/branding

mgr/dashboard: Add guideline how to brand the UI and update the color scheme

Reviewed-by: Kanika Murarka <kmurarka@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #25991 from jtlayton/wip-dashboard

mgr/dashboard: add a script to run an API request on a rook cluster

Reviewed-by: Ricardo Dias <rdias@suse.com>

mgr/dashboard: Fix linting errors

Fixes linting error in two files

Signed-off-by: Sebastian Krah <skrah@suse.com>

Merge pull request #25774 from yehudasa/wip-rgw-tiering-3

rgw: rados tiering

librbd: properly filter out trashed non-user images on purge

Fixes: https://tracker.ceph.com/issues/38006
Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #26073 from rhcs-dashboard/add-tox-ini-command

mgr/dashboard: added command to tox.ini

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #26020 from rhcs-dashboard/issue-37854

mgr/dashboard: Fixed performance details context for host list row selection

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kanika Murarka <kmurarka@redhat.com>

Merge pull request #26007 from rhcs-dashboard/upgrade-python-dev-deps

mgr/dashboard: upgraded python dev dependencies

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>

mgr/dashboard: added command to tox.ini

* Added 'run' command to run arbitrary commands so
  you don't have to run the whole test/lint suite.
  Use case examples:
  - Run only 1 test:
  tox -e py3-run pytest tests/test_rgw_client.py::RgwClientTest::test_ssl_verify
  - Run pycodestyle for only 1 file:
  tox -e py3-run pycodestyle tests/test_rgw_client.py

Signed-off-by: Alfonso Martínez <almartin@redhat.com>

Merge pull request #26032 from jtlayton/wip-rook

mgr/rook: remove dead code and fix bug in url fetching code

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #25895 from jan--f/c-v-func-test-local

ceph-volume: functional tests, add libvirt customization

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #26044 from tchaikov/wip-build-doc-pyyaml

doc: bump up sphinx and pyyaml versions

Reviewed-by: Alfredo Deza <adeza@redhat.com>

doc: bump up sphinx and pyyaml versions

* bump up pyyaml version to address CVE-2017-18342, see
  https://nvd.nist.gov/vuln/detail/CVE-2017-18342
* bump up sphinx to the latest stable

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26052 from tchaikov/wip-37976

mgr/zabbix: drop "total_objects" field

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26054 from tchaikov/wip-crimson-dispatcher-fix-ftbfs

crimson/osd: remove "force_new" from ms_get_authorizer()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #26045 from hsiang41/Ticket_33736

mgr/diskprediction_cloud: fix divide by zero when total_size is 0

Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/osd: remove "force_new" from ms_get_authorizer()

it was removed in e62f45d1, so update crimson-osd accordingly

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26046 from liewegas/wip-37976

mgr/telemetry: fix total_objects

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/zabbix: drop "total_objects" field

This field was removed from df output a while back in
342f309

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #25712 from familyuu/configuration

mgr/dashboard: Add a 'clear filter' button to configuration page

Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/diskprediction_cloud: fix divide by zero when total_size is 0

Fix devide by zero when total_size is o.

Ref ticket: https://tracker.ceph.com/issues/37736

Signed-off-by: Rick Chen <rick.chen@prophetstor.com>

mgr/telemetry: fix total_objects

This field was removed from df output a while back in
342f309645df886fb96eb401634e38376553e6d9

Fixes: http://tracker.ceph.com/issues/37976
Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #26031 into master

* refs/pull/26031/head:
mgr/BaseMgrModule: fix mon commands targetting a specific monitor
mgr/ActivePyModules: fix RestoreThread calls for get('devices')

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #25490 from Aran85/fix-ec-using-cache

osd: keep using cache even if op will invalid cache

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #25920 from wjwithagen/wjw-fix-freebsd-numa

common/numa: Add shim routines for NUMA on FreeBSD.

Merge pull request #25938 from majianpeng/msg-remove-memcopy-message-header

msg/async: reduce additional ceph_msg_header copy.

Reviewed-by: Xie Xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26021 from majianpeng/osd-remove-unused-code

osd: remove unused fields

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26040 from tchaikov/wip-blkdev-stat

common/blkdev: check retval of stat()

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26041 from tchaikov/wip-kvstore-tool-gcc-ice

tools/ceph_kvstore_tool: extract StoreTool into kvstore_tool.cc

Reviewed-by: Sage Weil <sage@redhat.com>

ceph: cleanup mds ceph status output

This is primarily to make the CephFS line more readable with lots of file
systems with more understandable output.

From something like:

    mds: a-2/2/2 up  {0=c=up:active,1=b=up:active}, 1 up:standby

Now with 1 FS and 1 active:

    mds: a:1 {0=p=up:active}, 15 up:standby

2 FS, 2 actives:

    mds: a:1 b:1 {a:0=o=up:active,b:0=n=up:active}, 14 up:standby

2 FS, 3 actives:

    mds: a:1 b:2 {a:0=o=up:active,b:0=n=up:active,b:1=p=up:active}, 13 up:standby

3 FS and 2 active and 1 reconnect:

    mds: a:1/1 b:1 c:1 {a:0=n=up:reconnect,b:0=p=up:active,c:0=o=up:active}, 13 up:standby

3 FS and 1 failed rank:

    mds: a:0/1 b:1 c:1 {b:0=p=up:active,c:0=o=up:active}, 14 up:standby, 1 failed

3 FS, 4 actives:

    mds: a:1 b:2 c:1 {a:0=o=up:active,b:0=n=up:active,b:1=p=up:active,c:0=l=up:active}, 12 up:standby

3 FS, 3 actives, 1 FS failed:

    mds: a:1 b:2 c:0/1 {a:0=o=up:active,b:0=n=up:active,b:1=p=up:active}, 13 up:standby, 1 failed

3 FS, 5 actives:

    mds: a:1 b:2 c:2 5 up:active, 11 up:standby

4 FS:

    mds: 4 fs {a:0=o=up:active,b:0=n=up:active,c:0=l=up:active,d:0=p=up:active}, 12 up:standby

5 FS:

    mds: 5 fs 5 up:active, 11 up:standby

5 FS, 1 degraded:

    mds: 5 fs (degraded: c:0/1) {a:0=o=up:active,b:0=n=up:active,d:0=p=up:active,e:0=m=up:active}, 12 up:standby, 1 failed

8 FS, 1 degraded:

    mds: 8 fs (degraded: c:0/1) 7 up:active, 9 up:standby, 1 failed

Fixes: http://tracker.ceph.com/issues/37954
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #26012 into master

* refs/pull/26012/head:
qa: add test that down fs does not ERR
mon/MDSMonitor: skip offline ERR for down fs

Reviewed-by: Douglas Fuller <dfuller@redhat.com>

Merge PR #25993 into master

* refs/pull/25993/head:
mds/FSMap: simplify encode/decode
mds: alias reference type for Filesystem
mds: add missing memory header include
include/encoding: eliminate smart_ptr temporaries

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #25976 into master

* refs/pull/25976/head:
Objecter::calc_op_budget: Fix invalid access to extent union member

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #25974 into master

* refs/pull/25974/head:
MDSMonitor: add missing OSDMonitor writeable check
MDSMonitor: codify constraint for writeable OSDMap

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #25973 into master

* refs/pull/25973/head:
qa: use simpler fs fail to bring fs down
MDSMonitor: add fs fail command

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Douglas Fuller <dfuller@redhat.com>

Merge PR #25971 into master

* refs/pull/25971/head:
qa: test hex dump_inode
pybind/ceph_argparse: accept int with non-decimal base

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #25650 into master

* refs/pull/25650/head:
client: add ceph_stat/ceph_lstat/ceph_fstat api

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

tool/ceph_kvstore_tool: extract duration calc out

simplify the code a little bit

Signed-off-by: Kefu Chai <kchai@redhat.com>

tools/ceph_kvstore_tool: extract StoreTool into kvstore_tool.cc

to workaround n bug in GCC 7.3, which leads to ICE like

build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/huge/release/14.0.1-2751-gb268822/rpm/el7/BUILD/ceph-14.0.1-2751-gb268822/src/tools/ceph_kvstore_tool.cc:625:1:
internal compiler error: Segmentation fault
 }
 ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugzilla.redhat.com/bugzilla> for instructions.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/BaseMgrModule: fix mon commands targetting a specific monitor

We just need to use the right variant of start_mon_command().

Fixes: http://tracker.ceph.com/issues/37967
Signed-off-by: Sage Weil <sage@redhat.com>

mgr/ActivePyModules: fix RestoreThread calls for get('devices')

Fixes 61aa7e2e0230bff49e757c32932d1db4bcad5f67

Fixes: http://tracker.ceph.com/issues/37736
Signed-off-by: Sage Weil <sage@redhat.com>

common/blkdev: check retval of stat()

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa: use simpler fs fail to bring fs down

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

rgw: align head object size with pool alignment

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #25919 from yuriw/wip-yuriw-distros-master

qa/tests: added rhel 7.6

Merge PR #26019 into master

* refs/pull/26019/head:
mon: implement hiding commands in ceph tool

Reviewed-by: Sage Weil <sage@redhat.com>

mgr/rook: wrap url fetch function in try/except block

It's possible for the fetch of this object to fail if the service is
being torn down. Handle that situation gracefully, but log a message.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #25996 from yehudasa/wip-37885

qa/rgw/tempest: either force os_type or select random distro

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #26015 from noahdesu/osd-find-fsid

cli: dump osd-fsid as part of osd find <id>

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>

Merge pull request #22797 from dzafman/wip-19753

osd: Deny reservation if expected backfill size would put us over bac…

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #25132 into master

* refs/pull/25132/head:
os/bluestore: implement kv update on bluefs extents info change.
os/bluestore: use original algorithm to calculate BlueFS gift size for explicit allocation.
os/bluestore: get rid of bluefs space gifting performed in background
os/bluestore: do KV/FM/allocator opening in two stages.
os/bluestore: detach FreelistManager from DB instance.
test/osd/store_test: add test case for explicit bluefs expanding.
os/bluestore: implement explicit bluefs space allocation at slow device
os/bluestore: unify allocator dump on bluefs space failures
os/bluestore: stop keeping bluefs_extents at KV

Reviewed-by: Sage Weil <sage@redhat.com>

mgr/rook: remove init_rook

John evidently added this code early on in development, when we figured
we might be taking over a cluster that is already running under k8s.

I don't see how we'd ever make that work, so just remove this function
for now, and the commented-out callsite.

Reported-by: Sebastian Wagner <sebastian.wagner@suse.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #25972 from noahdesu/doc-release-ver-sort

doc: sort releases by date and version

Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #25891 from ifed01/wip-ifed-fix-compress-errors

os/bluestore: do not assert on non-zero err codes from  compress() call

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #15168 from qwren/qat-crypto

crypto: add openssl support for RGW encryption

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #25961 from p-na/wip-pna-fix-argparse

ceph_argparse: fix --verbose

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #25324 from votdev/fix_raw_input

ceph-volume: Adapt code to support Python3

Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #25912 from sebastian-philipp/orchestrator-drive-group

mgr/orchestrator: Extend DriveGroupSpec

Merge pull request #26006 from jtlayton/wip-orchestrator

Clean up field names in ServiceDescription and add a service field

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Mark variables as default

Mark all variables as default, that they can get overwritten.
Also import the file vendor.variables

Signed-off-by: Sebastian Krah <skrah@suse.com>

mgr/dashboard: Add vendor.overrides.scss and vendor.variables.scss

Adds the files vendor.overrides.scss and vendor.variables.scss.
In those files the css and variable defaults can be overwritten.

Signed-off-by: Sebastian Krah <skrah@suse.com>

mgr/dashboard: Adapt to ceph.com branding

Changes the primary, secondary and accent color and adds a radius to all
buttons to match the branding of ceph.com

Signed-off-by: Sebastian Krah <skrah@suse.com>

mgr/dashboard: Introduce new scss variable

Adds a new scss variable called color-primary that the primary color only has
to be changed at one point

Signed-off-by: Sebastian Krah <skrah@suse.com>

mgr/dashboard: Add branding documentation

Explains how to brand the ui without running in merge conflicts once a source
file gets updated

Signed-off-by: Sebastian Krah <skrah@suse.com>

Merge PR #25981 into master

* refs/pull/25981/head:
crush: switch to *get_or_create_class_id* helper whenever possible

Reviewed-by: Sage Weil <sage@redhat.com>

mgr/orchestrator: Extend DriveGroupSpec

Also: Added tox.

Co-authored-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #25602 from familyuu/pool

mgr/dashboard: Add pool cache tiering details tab

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #25651 from votdev/improve_basemgrmodule

mgr: Allow modules to get/set other module options

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: Add a 'clear filter' button to configuration page

Fixes:http://tracker.ceph.com/issues/36173

Signed-off-by: familyuu <guodan1@lenovo.com>

Merge pull request #25304 from tchaikov/wip-crimson-osd

crimson/osd: crimson osd driver

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

osd:remove unused fileds.

Session::received_map_epoch only used by OSD::dispatch_op_fast. But this
func removed in 3cc48278bf0ee5c9535, So remvoe related code.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

crimson/osd: add mkfs()

we will need it for preparing crimson-osd without help of ceph-osd.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: send beacon to mon periodically

so monitor won't mark crimson-osd down and out

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: enable crimson-osd to boot

* add state.h to encapsulate the state represeting different stages
  related to booting an OSD. the boot process of an OSD can be blocked
  by
  - waiting for PG consuming updated osdmaps
  - waiting for osdmaps marking osd.{whoami} up
  - waiting for new osdmaps to bring this osd up to speed.
  - waiting for current OSD to be healthy
  we could chain these "waits" in a more seastarized way, and let
OSD::start() wait on the future returned by this chain. but that'd
requires adding some seastar::shard_future<> as member variables of
`OSD` class, which is a little bit more convoluted than the state
machine approach used in this change. we could switch over to the
`future<>` chain approach, if we found that these futures could have
more consumers than merely `OSD::start()`.
* all osdmaps are now stored in an `std::map` in `OSD`, we can
  improve it by
  - caching it using an LRU cache
  - trimming the stale ones
  - persisting the evicted maps into the meta collection in ObjectStore
* superblock is not persited to store, neither is it read from the
  store.

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/crimson: s/get_connection/connect_to/

in aa3d6f66, we removed Messenger::get_connection(), so update the test
accordingly.

Signed-off-by: Kefu Chai <kchai@redhat.com>

messages/MOSDBeacon: include PaxosServiceMessage.h

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson: integrate mon::Client into OSD

and register them as dispatchers using ChainedDispatchers

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson: add ChainedDispatchers

it will be used to glue multiple dispatchers for subscribing events
emitted by messenger

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson: add prototype of crimson/osd

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Fixed performance details context for host list row selection
Fixes: http://tracker.ceph.com/issues/37854
Signed-off-by: Neha Gupta <gnehapk@gmail.com>

crimson: add a dummy object store

CyanStore only provides just-enough facility for booting an OSD.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson: set src for message

monitor will panic at seeing a MOSDBoot message which is not from an
OSD. see OSDMonitor::preprocess_boot()
```
ceph_assert(m->get_orig_source_inst().name.is_osd());
```

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson: ignore v2 only addvec

crimson need to be v2 compatible. but let's leave this for another PR.

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: silence -Wsign-compare in libfmt

* silence -Wsign-compare in libfmt
* silence -Wattributes in seastar

to silence warnings like:

/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/seastar/fmt/include/fmt/format.h:
In instantiation of 'constexpr bool fmt::v5::internal::find(Ptr, Ptr, T,
Ptr&) [with bool IS_CONSTEXPR = false; T = char; Ptr = const wchar_t*]':
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/seastar/fmt/include/fmt/format.h:2154:32:
required from 'constexpr void
fmt::v5::internal::parse_format_string(fmt::v5::basic_string_view<Char>,
Handler&&)::writer::operator()(const Char*, const Char*) [with bool
IS_CONSTEXPR = false; Char = wchar_t; Handler =
fmt::v5::format_handler<fmt::v5::arg_formatter<fmt::v5::back_insert_range<fmt::v5::internal::basic_buffer<wchar_t>
> >, wchar_t,
fmt::v5::basic_format_context<std::back_insert_iterator<fmt::v5::internal::basic_buffer<wchar_t>
>, wchar_t> >&]'
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/seastar/fmt/include/fmt/format.h:2164:3:
required from 'constexpr void
fmt::v5::internal::parse_format_string(fmt::v5::basic_string_view<Char>,
Handler&&) [with bool IS_CONSTEXPR = false; Char = wchar_t; Handler =
fmt::v5::format_handler<fmt::v5::arg_formatter<fmt::v5::back_insert_range<fmt::v5::internal::basic_buffer<wchar_t>
> >, wchar_t,
fmt::v5::basic_format_context<std::back_insert_iterator<fmt::v5::internal::basic_buffer<wchar_t>
>, wchar_t> >&]'
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/seastar/fmt/include/fmt/format.h:3346:39:
required from 'typename Context::iterator fmt::v5::vformat_to(typename
ArgFormatter::range, fmt::v5::basic_string_view<Char>,
fmt::v5::basic_format_args<Context>) [with ArgFormatter =
fmt::v5::arg_formatter<fmt::v5::back_insert_range<fmt::v5::internal::basic_buffer<wchar_t>
> >; Char = wchar_t; Context =
fmt::v5::basic_format_context<std::back_insert_iterator<fmt::v5::internal::basic_buffer<wchar_t>
>, wchar_t>; typename Context::iterator =
std::back_insert_iterator<fmt::v5::internal::basic_buffer<wchar_t> >;
typename ArgFormatter::range =
fmt::v5::back_insert_range<fmt::v5::internal::basic_buffer<wchar_t> >]'
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/seastar/fmt/include/fmt/format.h:3457:64:
required from here

/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/seastar/fmt/include/fmt/format.h:2120:14:
error: comparison of integer expressions of different signedness: 'const
wchar_t' and 'char' [-Werror=sign-compare]
     if (*out == value)
         ~~~~~^~~~~~~~
cc1plus: all warnings being treated as errors

where libfmt compares a wchar_t with a literal '}', which is char.
because the former is unsigned, and the latter is of a signed type,
GCC is annoyed. but since both of them are ASCII, and when performing
comparison, the signed one is converted to unsigned, then result of
comparison is correct per-se. hence, it's safe to silence this very
warning.

and warning like:

/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/seastar/src/core/future-util.cc:61:5:
required from 'seastar::future<> seastar::sleep_abortable(typename
Clock::duration, seastar::abort_source&) [with Clock =
std::chrono::_V2::steady_clock; typename Clock::duration =
std::chrono::duration<long int, std::ratio<1, 1000000000> >]'
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/seastar/src/core/future-util.cc:68:105:
required from here
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/seastar/src/core/future-util.cc:48:28:
error: 'seastar::sleep_abortable(typename Clock::duration,
seastar::abort_source&)::sleeper::sleeper(typename Clock::duration,
seastar::abort_source&) [with Clock = std::chrono::_V2::steady_clock;
typename Clock::duration = std::chrono::duration<long int, std::ratio<1,
1000000000> >]::<lambda()>' declared with greater visibility than the
type of its field 'seastar::sleep_abortable(typename Clock::duration,
seastar::abort_source&)::sleeper::sleeper(typename Clock::duration,
seastar::abort_source&) [with Clock = std::chrono::_V2::steady_clock;
typename Clock::duration = std::chrono::duration<long int, std::ratio<1,
1000000000> >]::<lambda()>::<this capture>' [-Werror=attributes]
                 : tmr([this] { done.set_value(); }) {
                            ^
Signed-off-by: Kefu Chai <kchai@redhat.com>

seastar: pick up the cmake fix

to pick up the fix for seastar/issues/576

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson: set default keyring path

otherwise crimson-osd won't be able to load the keyring

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson: add entity_addrvec_t interfaces to Messenger

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/monc: add subcription helpers

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/monc: add start() method

to boot strap mon::Client once seastar and msgr is ready. this allows us
to allocate mon::Client on stack.

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/crimson/monc: start/stop perf counter

in CephContext::CephContext(), we assume that
ceph::common::local_perf_coll() is ready when a CephContext is to be
contructed. so we need to prepare start it before creating CephContext.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: implement hiding commands in ceph tool

Otherwise ceph.in doing get_command_descriptions sees the command does not
exist and will print an error.

Fixes: https://tracker.ceph.com/issues/37956
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>