mds: convert const char ptr to string_view

Trivial refactor.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

common/TrackedOp: use string_view interface

Also, don't store pointers to strings outside. The interface was written to
optimize for string literals but this is structurally unsafe programming.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #24427 from thmour/thmour_api_purge

librbd: add trash purge api calls

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25908 from trociny/wip-dperf-bytes

mgr: change 'bytes' dynamic perf counters to COUNTER type

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25887 from neha-ojha/wip-hide-flag

include/rados.h: hide CEPH_OSDMAP_PGLOG_HARDLIMIT from ceph -s

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Xie Xingguo <xie.xingguo@zte.com.cn>

librbd: tweaked trash purge API

Removed the internal usage of the public librbd API, avoided double-opening
image to determine data pool, and fixed issues with the unit test case.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

cls/rbd: reduce erroneous error messages when omap keys don't exist

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

test/librbd: fix librbrd test relative to trash purge

Signed-off-by: Julien Collet <julien.collet@cern.ch>

librbd: add trash purge api calls

Add trash purge api calls and fix the docs of some other rbd trash functions

Signed-off-by: Theofilos Mouratidis <mtheofilos@gmail.com>

Merge pull request #25529 from Songweibin/wip-fix-rbd-migration

librbd: disallow trash restoring when image being migrated

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25765 from Songweibin/wip-fix-migrate-parent

librbd/api: misc fix migration

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25834 from trociny/wip-21392

rbd-mirror: create and export replication perf counters to mgr

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25896 from trociny/wip-37861

rbd: fix delay time calculation for trash move

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25656 from tspmelo/wip-npm-update

mgr/dashboard: Update npm packages

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #25883 from dillaman/wip-37745

librbd: keep access/modified timestamp updates out of IO path

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #25894 from Devp00l/wip-kv-table-update

mgr/dashboard: Hide empty fields and render all objects in KV-table

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr: change 'bytes' dynamic perf counters to COUNTER type

(so they are of the same type as in static perf)

Signed-off-by: Mykola Golub <mgolub@suse.com>

mgr/dashboard: Render all objects in KV-table

The problem was that the key value table didn't render all objects in
the given object, even if 'renderObjects' was set to true.

For example you give it an object with 2 attributes each of them holds a
non empty object, this will result in a table data that is not fully
converted to key value objects, which will result as text '[Object
object]' in the table view.

Now every object will be rendered and the key value array will be sorted
by key.

Fixes: https://tracker.ceph.com/issues/37859
Signed-off-by: Stephan Müller <smueller@suse.com>

mgr/dashboard: Hide empty fields in KV-table

It exends the key value table by the option to hide empty fields.

Fixes: https://tracker.ceph.com/issues/37860
Signed-off-by: Stephan Müller <smueller@suse.com>

Merge PR #25755 into master

* refs/pull/25755/head:
msg/async/Protocol*: bump global_seq when retrying connection
msg/async/Protocol*: unregister con from accept vs mark_down race

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Haomai Wang <haomai@xsky.com>

Merge PR #25840 into master

* refs/pull/25840/head:
qa/msgr: add async-v1only case

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #25792 into master

* refs/pull/25792/head:
common/numa: remove unused _mask variants
osd: support osd_numa_node, osd_numa_auto_affinity, osd_numa_prefer_iface
mon/OSDMonitor: add 'osd numa-status' command
osd: report numa node for network interface(s)
common/pick_address: get numa node info for a interface
os/bluestore: report numa node info for storage
os/bluestore/KernelDevice: report numa info for each device
os/bluestore: allow get_devices() to run without bluestore started
common/blkdev: query numa info
common/numa: cpu_set helpers and numa helpers
common/blkdev: drop debug statements

Reviewed-by: Mark Nelson <mnelson@redhat.com>

Merge PR #25841 into master

* refs/pull/25841/head:
mon/MonClient: make mon hunt more aggressive

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #25827 into master

* refs/pull/25827/head:
test/cls_rgw: fix signed/unsigned warning
test/msgr/test_msgr: fix signed/unsigned warning
msg/Connection: protect peer_addrs with safe_item_history<>

Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #25704 from tchaikov/wip-36737-unittest-log

test: write log file to current directory

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge PR #25898 into master

* refs/pull/25898/head:
qa/tests: reduced nubmer of runs on 'ovh'

Reviewed-by: Sage Weil <sage@redhat.com>

qa/tests: reduced nubmer of runs on 'ovh'

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge PR #25544 into master

* refs/pull/25544/head:
common/PriorityCache: Automatic chunk sizing

Reviewed-by: Sage Weil <sage@redhat.com>

msg/async/Protocol*: bump global_seq when retrying connection

In the top connect retry in particular we do not bump connect_seq, so it
is critical that we bump global_seq so that the two connection attempts
are distinguishable at the peer.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #25744 from cbodley/wip-test-rgw-reshard-wait

test/rgw: add ifdef for HAVE_BOOST_CONTEXT

Reviewed-by: Kefu Chai <kchai@redhat.com>

rbd: fix delay time calculation for trash move

Fixes: https://tracker.ceph.com/issues/37861
Signed-off-by: Mykola Golub <mgolub@suse.com>

librbd: keep access/modified timestamp updates out of IO path

If the cache is enabled, it was possible for the timestamp updates
to cause race conditions with librbd clients (e.g. rbd export)
that had data corrupting effects since callbacks were expected to
be serialized.

Fixes: http://tracker.ceph.com/issues/37745
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25892 from theanalyst/doc-rgw-usage-fix

doc: rgw: fix the default value of usage log setting

Reviewed-by: Casey Bodley <cbodley@redhat.com>

rbd-mirror: add aggregated replication perf counters

Signed-off-by: Mykola Golub <mgolub@suse.com>

pybind/mgr/prometheus: export rbd-mirror metadata

Signed-off-by: Mykola Golub <mgolub@suse.com>

pybind/mgr: add rbd-mirror to get_all_perf_counters by default

This effectively enables rbd-mirror stats for modules like prometheus or
influx.

Signed-off-by: Mykola Golub <mgolub@suse.com>

pybind/mgr/diskprediction_cloud: only perfs for mon and osd needed

Signed-off-by: Mykola Golub <mgolub@suse.com>

pybind/mgr: allow to specify services for get_all_perf_counters

Signed-off-by: Mykola Golub <mgolub@suse.com>

rbd-mirror: create and export replication perf counters to mgr

Fixes: https://tracker.ceph.com/issues/21392
Signed-off-by: Mykola Golub <mgolub@suse.com>

doc: rgw: fix the default value of usage log setting

Fixes: http://tracker.ceph.com/issues/37856
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #25769 from votdev/navbar_focus_color

mgr/dashboard: Fix navbar focused color

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Neha Gupta <gnehapk@gmail.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #25791 from rhcs-dashboard/36740-pool-stats-read-write-columns

mgr/dashboard: add columns to Pools table

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #25839 from tchaikov/wip-37773

mgr/test_orchestrator: correct ceph-volume path

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

include/rados.h: hide CEPH_OSDMAP_PGLOG_HARDLIMIT from ceph -s

Signed-off-by: Neha Ojha <nojha@redhat.com>

mgr/dashboard: Update bootstrap to 3.4.0

Fixes: https://tracker.ceph.com/issues/37834
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Update npm packages

Signed-off-by: Tiago Melo <tmelo@suse.com>

test/journal: ReplayEntry::get_data is const

Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #25816 from neha-ojha/wip-36686

osd/mon: fix upgrades for pg log hard limit

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #25321 from votdev/fix_dict_changed_size

ceph-volume: Add unit test

Reviewed-by: Alfredo Deza <adeza@redhat.com>

pybind/mgr/dashboard: add modified messages.xlf

This is to fix the make check failure in
mgr-dashboard-frontend-unittests.

Signed-off-by: Neha Ojha <nojha@redhat.com>

common/numa: remove unused _mask variants

These parse the 'local_cpus' file that has a hex bitmask, but I didn't end
up using them.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #25863 from trociny/wip-rbd-mirror-mock-warnings

 test/rbd_mirror: fix gmock warnings

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

mgr/test_orchestrator: correct ceph-volume path

s/ceph_volume/ceph-volume/

Fixes: http://tracker.ceph.com/issues/37773
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #25860 from trociny/wip-prometheus-rbd_stats_pools

pybind/mgr/prometheus: improve 'rbd_stats_pools' param parsing

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25300 from votdev/improve_rgw_user_list

mgr/dashboard: Improve RgwUser controller

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #25634 from sebastian-philipp/doc-orchestrator-wal

doc/mgr/orchestrator: add `wal` to blink lights

Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #25813 from rhcs-dashboard/updated-test-full-health

mgr/dashboard: updated health API test

Merge pull request #25743 from trociny/wip-37541

 journal: set max journal order to 26

Merge pull request #25789 from trociny/wip-36038

rbd_mirror: don't report error if image replay canceled

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25832 from trociny/wip-37729-1

test/pybind/test_rbd: filter out unknown list_children2 keys

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #25861 from tchaikov/wip-seastar-connect-fix

seastar: pickup fix for segfault in POSIX stack

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

test/rbd_mirror: expect service daemon update instance_id attribute

Signed-off-by: Mykola Golub <mgolub@suse.com>

test/rbd_mirror: fix gmock warnings when running with debug

Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #25572 from nathan-weinberg/pools-tests

mgr/dashboard: Added breadcrumb and tab tests to Pools menu

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

seastar: pickup fix for segfault in POSIX stack

see
https://github.com/scylladb/seastar/commit/5e399906d1efa9e5ca9d121d09c6d2b1cdc41404

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/prometheus: improve 'rbd_stats_pools' param parsing

re.split can still produce a list with empty string elements (e.g. if
'rbd_stats_pools' is just an empty string) and we want to filter out
those.

Signed-off-by: Mykola Golub <mgolub@suse.com>

mgr/dashboard: add columns to Pools table

* Added columns:
Usage, Read bytes, Write bytes, Read ops, Write ops.

* TableKeyValueComponent:
Bugfix in method: _insertFlattenObjects

* Updated jest global mock:
Now window.getComputedStyle returns an object
that has getPropertyValue defined
(otherwise jest pool tests involving chart.js threw error). See:
https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle

Fixes: https://tracker.ceph.com/issues/37717
Fixes: https://tracker.ceph.com/issues/34320
Signed-off-by: Alfonso Martínez <almartin@redhat.com>

Merge PR #25621 into master

* refs/pull/25621/head:
mds: allow boot on read-only
mds: setup readonly mode for PurgeQueue
mds: return string_view for type str
mds: add missing locks for PurgeQueue methods
mds: delete on_error context on des

Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #24556 into master

* refs/pull/24556/head:
tools/cephfs: make 'cephfs-data-scan scan_links' update snaptable
tools/cephfs: make 'cephfs-data-scan scan_links' update inotable

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #25818 into master

* refs/pull/25818/head:
mon: adjust mon sync, extra_probe_peers to use addrvec

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

mon/MonClient: make mon hunt more aggressive

With v2 and v1 addresses, it helps to be a bit more aggressive
searching for mons since the v1 or v2 ports may not be in use.

- try 3 parallel connection attempts, not 2
- increase the timeout interval more slowly

Signed-off-by: Sage Weil <sage@redhat.com>

qa/msgr: add async-v1only case

Signed-off-by: Sage Weil <sage@redhat.com>

mon: adjust mon sync, extra_probe_peers to use addrvec

The peer addr stuff via asok is a bit fragile because the user must
provide an exact addrvec matching the mon to avoid some weirdness, but
it's rarely used, and the fix would be some robustness/tolerance in the
messenger that is a bigger project than this.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #25823 into master

* refs/pull/25823/head:
msg/async/Protocol*: fix mark_down vs accept race

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

osd: support osd_numa_node, osd_numa_auto_affinity, osd_numa_prefer_iface

- osd_numa_node manually specifies a numa node.
- osd_numa_prefer_iface makes us prefer IPs in public_network that are
  on the same numa node as the storage
- osd_numa_auto_affinity will set affinity to a numa node when both the
  store and network(s) are on the same numa node.

These options are all flagged as 'startup', although osd_numa_node and
osd_numa_auto_affinity takes effect when the OSD is marked up, so doing
'ceph osd down ...' is sufficient to induce an update.

Signed-off-by: Sage Weil <sage@redhat.com>

mon/OSDMonitor: add 'osd numa-status' command

Signed-off-by: Sage Weil <sage@redhat.com>

osd: report numa node for network interface(s)

Signed-off-by: Sage Weil <sage@redhat.com>

common/pick_address: get numa node info for a interface

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #25381 from cbodley/wip-qa-rgw-cls

qa/rgw: add cls_lock/log/refcount/version tests to verify suite

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #24027 from theanalyst/wip-civetweb-poll

rgw: civetweb: use poll instead of select while waiting on sockets

Merge PR #25835 into master

* refs/pull/25835/head:
mgr/ServiceMap: print daemon addr in legacy format

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge PR #24172 into master

* refs/pull/24172/head:
client: fix fuse client hang because its pipe to mds is not ok

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

mgr/dashboard: Added breadcrumb and tab tests to Pools menu

Fixes: https://tracker.ceph.com/issues/37667
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>

mgr/ServiceMap: print daemon addr in legacy format

The v1/v2 prefix isn't useful anyway since the client can connect via
any protocol.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #25741 into master

* refs/pull/25741/head:
mds: remove wrong assertion in Locker::snapflush_nudge

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

test/cls_rgw: fix signed/unsigned warning

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #25479 into master

* refs/pull/25479/head:
client: fix fuse client can't read or write data due its caps is invalid
Revert "client: fix fuse client can't read or write data due its caps is invalid"

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

test/msgr/test_msgr: fix signed/unsigned warning

Signed-off-by: Sage Weil <sage@redhat.com>

msg/Connection: protect peer_addrs with safe_item_history<>

The peer_addrs can be updated during the initial connection handshake,
but we don't want users (e.g., dout()) to race with an update and
wander off into bad memory.

We use the same strategy for Messenger's my_addrs.

Fixes: http://tracker.ceph.com/issues/37807
Signed-off-by: Sage Weil <sage@redhat.com>

test/pybind/test_rbd: filter out unknown list_children2 keys

Fixes: http://tracker.ceph.com/issues/37729
Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #25812 from Exotelis/toc

mgr/dashboard: Add table of contents to HACKING.rst

Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #25830 from rhcs-dashboard/grafana-500

mgr/dashboard: Fixes Grafana 500 error

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge PR #25801 into master

* refs/pull/25801/head:
qa/tasks/radosbench: default to 64k writes

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #24714 from pritha-srivastava/wip-rgw-role-doc

rgw: Adding documentation for Roles.

mgr/dashboard: Improve RgwUser controller

Use the new 'user?list' RGW Admin OPS API endpoint.

Signed-off-by: Volker Theile <vtheile@suse.com>

Merge PR #25821 into master

* refs/pull/25821/head:
doc/dev/msgr2: checksum frame header (tag + length)

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

msg/async/Protocol*: fix mark_down vs accept race

If we mark_down the connection while we have the lock dropped the state
maybe CLOSED when we retake it.  Bail out if that happens instead of
continuing to process the connection and eventually running into an
assertion on can_write.

Fixes: http://tracker.ceph.com/issues/36497
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #25820 from alfredodeza/wip-rm37805

ceph-volume tests/functional declare ceph-ansible roles instead of importing them

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

mgr/dashboard: Fix navbar focused color

The previous gray does not match the new branding color. Now use the green from https://ceph.com.

Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Fixes Grafana 500 error

Fixes: http://tracker.ceph.com/issues/37809
Signed-off-by: Kanika Murarka <kmurarka@redhat.com>