test: Limit loops waiting for force-backfill/force-recovery to happen

Fixes: http://tracker.ceph.com/issues/38309
Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #26397 from guits/guits-fix_ceph-volume

ceph-volume: update testing playbook 'deploy.yml'

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #26406 from drunkard/master

doc: typo fixes, s/Requered/Required/

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26325 from jtlayton/wip-jlayton-dashboard-orch

mgr/dashboard: use the orchestrator_cli backend setting

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

doc: typo fixes, s/Requered/Required/

Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>

Merge pull request #26390 from smithfarm/wip-doc-mgr-dashboard

doc: add Ceph Manager Dashboard to top-level TOC

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #26265 into master

* refs/pull/26265/head:
qa/suites/rados/upgrade: whitelist 'slow request'

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #26366 into master

* refs/pull/26366/head:
os/filestore: ceph_abort() on fsync(2) or fdatasync(2) failure

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge PR #26369 into master

* refs/pull/26369/head:
ceph-mon: slightly more helpful output during mkfs

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #26391 into master

* refs/pull/26391/head:
buffer: disable hypercombining in bufferlist.

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #26392 into master

* refs/pull/26392/head:
messages/MMonMgrReport: fix compat decoding

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

ceph-volume: update deploy.yml

update deploy.yml accordingly with recent changes in ceph-ansible.

Fixes: ceph/ceph-ansible#3602
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #26367 from tspmelo/wip-iscsi-edit-ui

mgr/dashboard: Add iSCSI Target Edit UI

Reviewed-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #26346 from noahdesu/mgr-orch-cache-refresh

mgr/orch: refresh option for inventory query

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #26357 from rjfd/wip-orch-fix-dev-pretty-print

mgr/orchestrator: fix device pretty print with None attributes

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #26384 from tspmelo/wip-e2e-login

mgr/dashboard: Add implicit wait in e2e tests

Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #26379 from tchaikov/wip-remove-jinja2

rpm,deb: remove python-jinja2 dependency

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

mgr/dashboard: Add implicit wait in e2e tests

Fixes: https://tracker.ceph.com/issues/38269
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge PR #26385 into master

* refs/pull/26385/head:
mon: mons also connect to mgrs

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>

messages/MMonMgrReport: fix compat decoding

Broken by 08d1a6fc3c57ccbeb6dff8fce1aae429edca97f3

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #26377 from tchaikov/wip-mgr-plugin-arch-all

debian/control: change Architecture python plugins to "all"

Merge pull request #26246 from leseb/cb-typo

ceph-volume: add space between words

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Merge pull request #26337 from dillaman/wip-37998

librbd: get_parent API method should properly handle migrating image

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #26368 from alfredodeza/wip-rm38261

build: further removal of `subman` configuration

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

doc: add Ceph Manager Dashboard to top-level TOC

Signed-off-by: Nathan Cutler <ncutler@suse.com>

buffer: disable hypercombining in bufferlist.

We're seeing various failures like:

      * http://tracker.ceph.com/issues/38024,
      * http://tracker.ceph.com/issues/38230,
      * http://tracker.ceph.com/issues/37910

without a clear cause. Disabling hypercombining makes at least one
reproducer happy.

Fixes: http://tracker.ceph.com/issues/38024
Fixes: http://tracker.ceph.com/issues/38230
Fixes: http://tracker.ceph.com/issues/37910
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

rbd: added missing feature bitmask to name mapping

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

rbd: removed migration source annotation from parent info

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge PR #26340 into master

* refs/pull/26340/head:
osd/OSD: respect osdmap message limits
mon/OSDMonitor: limit MOSDMap message size by bytes
common/options: add osd_map_message_max_bytes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge PR #26365 into master

* refs/pull/26365/head:
msg/async/ProtocolV2: refuse incoming reconnect attempt intended for someone else
msg/async/ProtocolV2: refuse incoming connection intended for someone else

Reviewed-by: Ricardo Dias <rdias@suse.com>

Merge PR #26363 into master

* refs/pull/26363/head:
ceph.spec.in: python-kubernetes broken on rhel

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #26323 from LenzGr/pools-typo

mgr/dashboard: Fix typo in pools management

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

mon: mons also connect to mgrs

Signed-off-by: Ricardo Dias <rdias@suse.com>

mgr/dashboard: Add iSCSI target edit UI

Fixes: http://tracker.ceph.com/issues/38014
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #26320 from tspmelo/wip-iscsi-discovery-ui

mgr/dashboard: Add iSCSI discovery authentication UI

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #26383 from tchaikov/wip-auth-common-cleanup

auth, common: cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

mgr/dashboard: use orchestrator_cli to figure out the backend

Currently the dashboard has its own setting for the orchestrator
backend, which means that one has to set it in both the dashboard and
the orchestrator_cli module if you intend to use both.

Change the dashboard code to use the setting in the orchestrator_cli
module, and eliminate the dashboard-specific setting.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mgr: make orchestrator_cli be always-on

The volumes module has at least a loose dependency on the orchestrator,
and thus also relies on the orchestrator_cli module for the backend
setting. Since the volumes module is always-on, do the same with the
orchestrator_cli module.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mgr/volumes: properly handle NoOrchestrator exception

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mgr/orchestrator: don't have _select_orchestrator raise exceptions

This is problematic as this usually gets invoked via the Mgr remote
method, which will clobber any exception with a RuntimeError.

Instead, just have it return None if one isn't configured, and have the
callers raise the exception if necessary.

Signed-off-by: Jeff Layton <jlayton@redhat.com>

mgr/orchestrator: move NoOrchestrator definition to base orchestrator.py

Signed-off-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #26221 from cyx1231st/wip-seastar-msgr-perf

crimson/net: misc fixes and features for crimson-messenger tests

Reviewed-by: Kefu Chai <kchai@redhat.com>

mon/MonClient: forward declare AuthRegistry instead of #include it

to speed up the compilation.

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/ceph_context: hardwire module_type to CEPH_ENTITY_TYPE_OSD

currently, crimson project is only targeting crimson-osd.

Signed-off-by: Kefu Chai <kchai@redhat.com>

auth/AuthServer: fix typo in comments

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/net: crimson messenger performance test tool

Support the following settings:
* mode: both, client mode, server mode;
* set server address;
* rounds of messages;
* keepalive-ratio;
* block size;
* io-depth;

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: improve UT performance and added timing

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

Merge pull request #26243 from nathan-weinberg/block-tabs

mgr/dashboard: Added tab tests to Block menu items

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #26364 from tchaikov/wip-test-silence-warnings

test/rgw: silence -Wsign-compare warnings

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

mgr/dashboard: Add iSCSI discovery authentication UI

Fixes: https://tracker.ceph.com/issues/38021
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Fix order of table buttons

"float:none" is changing  the order of the table buttons.
By reverting this change and setting .oadatatableactions to "float:left",
we get the same result as intended before.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #26319 from tspmelo/wip-iscsi-service-spec

mgr/dashboard: Fix iSCSI service unit tests

Reviewed-by: Ricardo Marques <rimarques@suse.com>

rpm,deb: remove python-jinja2 dependency

python-jinja2 dependency was added for the dashboard v1 in 87399bea. but
dashboard v2, which is now known as "dashboard" has taken the place of
the old dashboard. and dashboard now does not use jinja2, so we should
drop this dependency.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/net: fix memory leak

Do not enqueue sent before lossless policy implemented, it is causing
memory leak.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: port sharded-msgr to existing code

Port sharded-msgr to crimson osd, monc, heartbeat and tests with
compatible mode.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: promote policy related method to Messenger

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: compatible mode of crimson-msgr

Added a compatible mode with master_sid to support single-core
dispatcher.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: suppress info logs for frequent keepalive

The new unittest_seastar_messenger will print out the count of keepalive
attempts at the end of the execution.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

crimson/net: enable connections on all cores

Implement the sharded crimson-messenger:

* Sharded Messenger: provides shared-nothing Messenger for each shard,
  it's interfaces are symmetric to be called, any modifications will be
  applied to all shards.

* Sharded/non-sharded Dispatcher interface: allow connections to be
  dispatched, and related resources (such as Session) to be managed in
  its own shard or not.

* Sharded Connection: A connection only lives at one dedicated core
  during its lifecycle. It's sharded by its peer_IP in this PoC, because
  peer port and nonce are not available when a socket is accepted. While
  its interfaces are safe to be called from all shards.

* Replace `boost::intrusive_ptr` by seastar native smart ptrs for
  `Connection` and `SocketConnection`, because they need to be
  destructed from its original core.

* Unit test: establish multiple connections on both client and server
  sides, they runs concurrently and creates sessions that are also
  following shared-nothing design.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>

debian/control: change Architecture python plugins to "all"

change following plugins' Architecture to "all", as they are pure python
plugins, and are architecture-independent packages.

- ceph-mgr-diskprediction-cloud
- ceph-mgr-diskprediction-local
- ceph-mgr-rook

this also matches their couterparts in ceph.spec.in, where we have
```
BuildArch:  noarch
```

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/orchestrator: fix device pretty-print, added unit test

Signed-off-by: Ricardo Dias <rdias@suse.com>

Merge pull request #26255 from tchaikov/wip-crimson-hb

crimson/osd: add more heartbeat peers

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

pybind/orch: add refresh option to inventory query

allow a user of the orchestrator interface to express that the inventory
query should not read from any cached inventory state.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>

Merge PR #26282 into master

* refs/pull/26282/head:
mon: include progress events in 'ceph status' output
mon/MgrStatMonitor: persist progress events
mgr: send progress events to mon
mgr/progress: revise message syntax a bit
mgr/progress: report events into mgr
mgr: allow progress events to be reported from modules
mgr/progress: make persist period/interval configurable
mgr/progress: prune completed events

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

ceph-mon: slightly more helpful output during mkfs

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #26336 into master

* refs/pull/26336/head:
qa/tasks/keystone.py: no need for notcmalloc in example
qa/suites/rgw/tempest/tasks/rgw_tempest: no need for notcmalloc

Reviewed-by: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

cmake: further removal/cleanup of subman configuration

Signed-off-by: Alfredo Deza <adeza@redhat.com>

rpm: further removal/cleanup of subman calls

Signed-off-by: Alfredo Deza <adeza@redhat.com>

os/filestore: ceph_abort() on fsync(2) or fdatasync(2) failure

If we get an error from f[data]sync that is always a fatal error.

Fixes: http://tracker.ceph.com/issues/38258
Signed-off-by: Sage Weil <sage@redhat.com>

mgr/dashboard: Fix typo in pools management

Typo fix: "suite your needs" -> "suit your needs"

Signed-off-by: Lenz Grimmer <lgrimmer@suse.com>

Merge pull request #26322 from trociny/wip-mock-warning

test/librbd: fix 'Uninteresting mock function call' warning

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

msg/async/ProtocolV2: refuse incoming reconnect attempt intended for someone else

The same scenario that was possible on client_ident is also possible
for reconnect: on the accepting side we recognized the client_addrs
but the client is trying to reach someone else.  Since the cookie is a
random 64-bit value it is unlikely, but still possible, that we will
match an existing session that is not for the client.

Signed-off-by: Sage Weil <sage@redhat.com>

test/rgw: silence -Wsign-compare warnings

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #26318 from wjwithagen/wjw-fix-crush_weights.sh-sed

test: switch to GNU sed on FreeBSD

Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph.spec.in: python-kubernetes broken on rhel

Error: Package: python2-kubernetes-8.0.0-6.el7.noarch (epel)
           Requires: python-adal

Signed-off-by: Sage Weil <sage@redhat.com>

msg/async/ProtocolV2: refuse incoming connection intended for someone else

If we get a client_ident frame, and they are trying to talk to someone
else, drop the connection.

This is an inelegant workaround to http://tracker.ceph.com/issues/38247.
A nicer fix would be to restructure the protocol so that the client knows
who they connected to before they try to open a session.  That is a bigger
change that can follow...

Fixes: http://tracker.ceph.com/issues/38247
Signed-off-by: Sage Weil <sage@redhat.com>

mgr/dashboard: Fix iSCSI service unit tests

Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #26339 from idryomov/wip-krbd-namespaces-test

qa: krbd namespaces test

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #26102 from rhcs-dashboard/wip-featuretoggles

mgr/dashboard: add Feature Toggles

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

librbd: get_parent API method should properly handle migrating image

The true parent of a migrating parent is actually the parent of the
migration source image. There are other API methods available to
retreive the details of the migration source.

Fixes: http://tracker.ceph.com/issues/37998
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #26360 from rhcs-dashboard/wip-38254-master

doc: mgr/orch: Fix remote_host doc reference

Reviewed-by: Alfonso Martínez <almartin@redhat.com>

doc: mgr/orch: Fix remote_host doc reference

The type fix in the remote_host to remove_host has caused a Ceph docs
build failure.

Introduced-By: 05cfa6f
Fixes: http://tracker.ceph.com/issues/38254
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #26268 from smithfarm/wip-opensuse-s390

rpm: do not exclude s390x build on openSUSE

Reviewed-by: Kefu Chai <kchai@redhat.com>

doc: mgr/dashboard: feature-toggles: Fix config

Add '*.inc.rst' to the list of excluded patterns from sphinx-build. This
allows for using '*.inc.rst' as includes, and avoids duplicates. The
benefit of keeping the trailing '.rst' extension is that most IDEs use
that to render reStructured Text files.

Fixes: http://tracker.ceph.com/issues/37530
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: feature-toggles: minor fixes

Fixes: http://tracker.ceph.com/issues/37530
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: feature-toggles: Update Hacking

Fixes: http://tracker.ceph.com/issues/37530
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: feature-toggles: Fix formatting

Fix front-end formatting as suggested by tspmelo

Fixes: http://tracker.ceph.com/issues/37530
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

doc: mgr/dashboard: feature-toggles: Add doc

Fixes: http://tracker.ceph.com/issues/37530
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: feature-toggles: add py unit tests

Add python unit test for feature toggles plugin, and refactor other
files, and add a new type of function cache decorator based on LRU but
with a TTL.

Fixes: http://tracker.ceph.com/issues/37530
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #26115 from ricardoasmarques/iscsi-discovery-auth-api

mgr/dashboard: iSCSI discovery authentication API

Reviewed-by: Tiago Melo <tmelo@suse.com>

mgr/orchestrator: fix device pretty print with None attributes

Signed-off-by: Ricardo Dias <rdias@suse.com>

Merge pull request #26314 from sebastian-philipp/orchestrator-host-mon-mgr

mgr/orchestrator: Add host mon mgr management to interface

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Noah Watkins <noahwatkins@gmail.com>

Merge PR #25977 into master

* refs/pull/25977/head:
qa/suites: exclude new packages when installing old versions
rpm: add dependency on python-kubernetes module to ceph-mgr-rook package
rpm,deb: add rbd_support module to ceph-mgr
packaging: split ceph-mgr diskprediction and rook plugins into own packages

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #26327 into master

* refs/pull/26327/head:
doc/dev/msgr2: bring up to date with new HELLO, different RECONNECT
msg/async/ProtocolV2: separate IDENT into {CLIENT,SERVER}_IDENT

Reviewed-by: Ricardo Dias <rdias@suse.com>

Merge pull request #25082 from rzarzynski/wip-bl-less-atomic

common: optimize reference counting in bufferlist

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge PR #26287 into master

* refs/pull/26287/head:
doc: update doc on new recall config

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #26248 into master

* refs/pull/26248/head:
systemd: lock down privileges more

Reviewed-by: Sage Weil <sage@redhat.com>

mon: include progress events in 'ceph status' output

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrStatMonitor: persist progress events

Signed-off-by: Sage Weil <sage@redhat.com>

mgr: send progress events to mon

Signed-off-by: Sage Weil <sage@redhat.com>