]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
6 years agoscript/ptl-tool: allow invocation within a subdirectory 26463/head
Sage Weil [Sat, 16 Feb 2019 19:05:35 +0000 (13:05 -0600)]
script/ptl-tool: allow invocation within a subdirectory

Make ptl-tool.py work from a subdirectory inside the repo (e.g., build/).

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoMerge pull request #26416 from dzafman/wip-fix-test-loops
David Zafman [Fri, 15 Feb 2019 22:25:59 +0000 (14:25 -0800)]
Merge pull request #26416 from dzafman/wip-fix-test-loops

test: Limit loops waiting for force-backfill/force-recovery to happen

Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge PR #26448 into master
Sage Weil [Fri, 15 Feb 2019 22:22:14 +0000 (16:22 -0600)]
Merge PR #26448 into master

* refs/pull/26448/head:
osd: do not send peers really old maps
osd: build_incremental_map_msg: recover if we are missing an incremental
osd: build_incremental_map_msg: behave if we have latest full but not incremental

Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge PR #26345 into master
Sage Weil [Fri, 15 Feb 2019 22:08:55 +0000 (16:08 -0600)]
Merge PR #26345 into master

* refs/pull/26345/head:
ceph-osd: be helpful about upgrade gate
mon: record 'min_mon_release' file and prevent startup if it's too old
mon/Monitor: do not join cluster that is >2 releases old
mon/Elector: respect monmap min_mon_release
mon: check min_mon_release during probe
mon/MonmapMonitor: increase min_mon_release when full quorum is upgraded
mon: maintain quorum_min_mon_release
mon/MonMapMonitor: set initial min_mon_release
monmaptool: add --set-min-mon-release
monmaptool: don't spew usage on any error
mon/MonMap: add min_mon_release field

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
6 years agoMerge PR #26456 into master
Sage Weil [Fri, 15 Feb 2019 22:07:25 +0000 (16:07 -0600)]
Merge PR #26456 into master

* refs/pull/26456/head:
mgr/PyModuleRegistry: avoid null deref from get_progress_events

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
6 years agoMerge pull request #26212 from linuxbox2/wip-rgw-master-nosuch
Matt Benjamin [Fri, 15 Feb 2019 21:40:21 +0000 (16:40 -0500)]
Merge pull request #26212 from linuxbox2/wip-rgw-master-nosuch

rgw: check for non-existent bucket in RGWGetACLs

6 years agoMerge PR #25739 into master
Patrick Donnelly [Fri, 15 Feb 2019 18:37:13 +0000 (10:37 -0800)]
Merge PR #25739 into master

* refs/pull/25739/head:
mds: handle leftover reconnect information
client: split large reconnect into multiple messages
mds: update MClientReconnect encoding

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoMerge PR #26423 into master
Patrick Donnelly [Fri, 15 Feb 2019 18:36:32 +0000 (10:36 -0800)]
Merge PR #26423 into master

* refs/pull/26423/head:
mgr/volumes: create/delete fs subvolumes
pybind/ceph_volume_client: allow volume_client to

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoMerge PR #26434 into master
Patrick Donnelly [Fri, 15 Feb 2019 18:26:30 +0000 (10:26 -0800)]
Merge PR #26434 into master

* refs/pull/26434/head:
mds: return string_view for type
mds: reorg LogEvent def
mds: pass LogEvent as unique_ptr

Reviewed-by: Zheng Yan <zyan@redhat.com>
6 years agomgr/PyModuleRegistry: avoid null deref from get_progress_events 26456/head
Sage Weil [Fri, 15 Feb 2019 18:14:13 +0000 (12:14 -0600)]
mgr/PyModuleRegistry: avoid null deref from get_progress_events

active_modules may be null.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoMerge PR #26445 into master
Sage Weil [Fri, 15 Feb 2019 16:36:03 +0000 (10:36 -0600)]
Merge PR #26445 into master

* refs/pull/26445/head:
mgr: hold GIL while generating a typed option value
mgr/ActivePyModules: do not touch PyFormatter without the GIL

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
6 years agoosd: do not send peers really old maps 26448/head
Sage Weil [Fri, 15 Feb 2019 14:43:23 +0000 (08:43 -0600)]
osd: do not send peers really old maps

We may receive a message that sat in a queue for a while with a low
priority and is tagged with an older epoch.  Don't send a bunch of old
maps that we have already sent the peer.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoosd: build_incremental_map_msg: recover if we are missing an incremental
Sage Weil [Fri, 15 Feb 2019 14:28:07 +0000 (08:28 -0600)]
osd: build_incremental_map_msg: recover if we are missing an incremental

If we are building a history and are missing an incremental, continue with
a full map in its place.

Generally speaking, an OSD should *always* have a full map stored, but
may not have the corresponding incremental for various reasons.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoosd: build_incremental_map_msg: behave if we have latest full but not incremental
Sage Weil [Fri, 15 Feb 2019 14:25:19 +0000 (08:25 -0600)]
osd: build_incremental_map_msg: behave if we have latest full but not incremental

Fixes 47a3f63ef71522d6b9572e81674598dd3e19df9d and
follow-on 57a13adc8d0e34b4bb1a4022eacbb3de2636df53

Fixes: http://tracker.ceph.com/issues/38330
Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomgr: hold GIL while generating a typed option value 26445/head
Sage Weil [Fri, 15 Feb 2019 00:21:38 +0000 (18:21 -0600)]
mgr: hold GIL while generating a typed option value

Drop the GIL while looking up the module and option value.  Retake
it before calling get_typed_option_value(), where we generate the
Python objects for the value.

Fixes: http://tracker.ceph.com/issues/38123
Fixes: http://tracker.ceph.com/issues/38204
Fixes: http://tracker.ceph.com/issues/38292
Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomgr/ActivePyModules: do not touch PyFormatter without the GIL
Sage Weil [Thu, 14 Feb 2019 13:24:09 +0000 (07:24 -0600)]
mgr/ActivePyModules: do not touch PyFormatter without the GIL

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoMerge pull request #26437 from tspmelo/wip-npm-update-19-2
Lenz Grimmer [Fri, 15 Feb 2019 11:25:23 +0000 (12:25 +0100)]
Merge pull request #26437 from tspmelo/wip-npm-update-19-2

mgr/dashboard: Update npm packages

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #26429 from rhcs-dashboard/fix-toast-notifications
Lenz Grimmer [Fri, 15 Feb 2019 10:38:27 +0000 (11:38 +0100)]
Merge pull request #26429 from rhcs-dashboard/fix-toast-notifications

mgr/dashboard: fix: toast notifications hiding utility menu

Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #26334 from votdev/fix_typo
Lenz Grimmer [Fri, 15 Feb 2019 09:27:26 +0000 (10:27 +0100)]
Merge pull request #26334 from votdev/fix_typo

mgr/dashboard: Fix typo in NoOrchesrtatorConfiguredException class name

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
6 years agomgr/dashboard: Update prettier to 1.16 26437/head
Tiago Melo [Wed, 23 Jan 2019 01:02:50 +0000 (01:02 +0000)]
mgr/dashboard: Update prettier to 1.16

Signed-off-by: Tiago Melo <tmelo@suse.com>
6 years agomgr/dashboard: Update npm packages
Tiago Melo [Tue, 12 Feb 2019 15:50:29 +0000 (15:50 +0000)]
mgr/dashboard: Update npm packages

Signed-off-by: Tiago Melo <tmelo@suse.com>
6 years agomds: return string_view for type 26434/head
Patrick Donnelly [Thu, 14 Feb 2019 20:27:11 +0000 (12:27 -0800)]
mds: return string_view for type

To avoid unnecessary heap allocation.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agomds: reorg LogEvent def
Patrick Donnelly [Thu, 14 Feb 2019 18:55:41 +0000 (10:55 -0800)]
mds: reorg LogEvent def

To follow code-style guidelines and protect some members.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agomds: pass LogEvent as unique_ptr
Patrick Donnelly [Thu, 14 Feb 2019 18:49:32 +0000 (10:49 -0800)]
mds: pass LogEvent as unique_ptr

To avoid leaks.

Fixes: http://tracker.ceph.com/issues/38324
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoMerge pull request #26375 from dzafman/wip-38034
David Zafman [Thu, 14 Feb 2019 18:36:38 +0000 (10:36 -0800)]
Merge pull request #26375 from dzafman/wip-38034

pg stuck in backfill_wait with plenty of disk space

Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge PR #26238 into master
Patrick Donnelly [Thu, 14 Feb 2019 18:22:28 +0000 (10:22 -0800)]
Merge PR #26238 into master

* refs/pull/26238/head:
mds: resolve memory leak of recall gather

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
6 years agoMerge PR #26374 into master
Patrick Donnelly [Thu, 14 Feb 2019 18:21:37 +0000 (10:21 -0800)]
Merge PR #26374 into master

* refs/pull/26374/head:
mds: fix potential re-evaluate stray dentry in _unlink_local_finish

Reviewed-by: Zheng Yan <zyan@redhat.com>
6 years agoMerge PR #26394 into master
Patrick Donnelly [Thu, 14 Feb 2019 18:20:44 +0000 (10:20 -0800)]
Merge PR #26394 into master

* refs/pull/26394/head:
mds: remove superfluous cap sequence increment
mds: fix MDCache::finish_snaprealm_reconnect()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoosd: Fix the problem by rechecking backfill status each time 26375/head
xie xingguo [Tue, 12 Feb 2019 04:07:42 +0000 (20:07 -0800)]
osd: Fix the problem by rechecking backfill status each time
a RemoteReservationRevoked message is received, so we can
restart the backfill process in a more safe and less-likely raced way.

Fixes: http://tracker.ceph.com/issues/38034
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
6 years agoRevert "osd: Handle getting RecoveryDone while in RepWaitBackfillReserved"
David Zafman [Tue, 12 Feb 2019 03:42:43 +0000 (19:42 -0800)]
Revert "osd: Handle getting RecoveryDone while in RepWaitBackfillReserved"

This reverts commit 83c2521a5316c922875746a40b95100b62865e67.

This original fix handled the race by accepting the RecoveryDone
while in RepWaitBackfillReserved by going to RepNotRecovering.
Once we weren't crashing OSDs, none of the tests at the time
detected that backfill was actually hung.

Signed-off-by: David Zafman <dzafman@redhat.com>
6 years agoMerge pull request #26371 from dzafman/wip-38262
David Zafman [Thu, 14 Feb 2019 17:28:33 +0000 (09:28 -0800)]
Merge pull request #26371 from dzafman/wip-38262

test: run-standalone.sh: point LD_LIBRARY_PATH to $(pwd)/lib

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #26297 from s0nea/wip-dashboard-readonly-config-options
Lenz Grimmer [Thu, 14 Feb 2019 17:27:32 +0000 (18:27 +0100)]
Merge pull request #26297 from s0nea/wip-dashboard-readonly-config-options

mgr/dashboard: disallow editing read-only config options

Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #26316 from wjwithagen/wjw-fix-FindStdFilesystem
Kefu Chai [Thu, 14 Feb 2019 17:06:08 +0000 (01:06 +0800)]
Merge pull request #26316 from wjwithagen/wjw-fix-FindStdFilesystem

cmake: Make the tests for finding Filesystem with more serious functions

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge PR #26063 into master
Patrick Donnelly [Thu, 14 Feb 2019 16:27:41 +0000 (08:27 -0800)]
Merge PR #26063 into master

* refs/pull/26063/head:
ceph: omit hidden commands from suggestions

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge pull request #26413 from liewegas/wip-38282
Kefu Chai [Thu, 14 Feb 2019 15:59:44 +0000 (23:59 +0800)]
Merge pull request #26413 from liewegas/wip-38282

osd: fix build_incremental_map_msg

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #26420 from tchaikov/wip-pgmap-more-includes
Kefu Chai [Thu, 14 Feb 2019 15:51:55 +0000 (23:51 +0800)]
Merge pull request #26420 from tchaikov/wip-pgmap-more-includes

mon/PGMap: add more #include

Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agomgr/dashboard: fix: toast notifications hiding utility menu 26429/head
alfonsomthd [Thu, 14 Feb 2019 15:15:58 +0000 (16:15 +0100)]
mgr/dashboard: fix: toast notifications hiding utility menu

* Fixed margin-top taking into account responsiveness.
* dropdown-menu class: set z-index to avoid notification
  hiding dropdown menus when menu item clicked.

Fixes: https://tracker.ceph.com/issues/38313
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
6 years agocmake: Make the tests for finding Filesystem with more serious functions 26316/head
Willem Jan Withagen [Thu, 14 Feb 2019 12:16:53 +0000 (13:16 +0100)]
cmake: Make the tests for finding Filesystem with more serious functions

Otherwise it is linked agains lc++ on FreeBSD,a dn that will satisfy both
tested libraries.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
6 years agoMerge pull request #26085 from tspmelo/wip-dashboard-nfs
Lenz Grimmer [Thu, 14 Feb 2019 12:13:44 +0000 (13:13 +0100)]
Merge pull request #26085 from tspmelo/wip-dashboard-nfs

mgr/dashboard: NFS management UI

Reviewed-by: Ricardo Dias <rdias@suse.com>
6 years agoMerge pull request #26149 from votdev/improve_get_typed_config
Kefu Chai [Thu, 14 Feb 2019 11:59:42 +0000 (19:59 +0800)]
Merge pull request #26149 from votdev/improve_get_typed_config

mgr: Improve ActivePyModules::get_typed_config implementation

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #26407 from votdev/rgw_column_style
Lenz Grimmer [Thu, 14 Feb 2019 11:40:57 +0000 (12:40 +0100)]
Merge pull request #26407 from votdev/rgw_column_style

mgr/dashboard: Sync column style with the rest of the UI

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
6 years agoMerge pull request #25963 from smithfarm/wip-python-dep-cleanup
Kefu Chai [Thu, 14 Feb 2019 11:27:04 +0000 (19:27 +0800)]
Merge pull request #25963 from smithfarm/wip-python-dep-cleanup

rpm: make Python dependencies somewhat less confusing

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #26421 from b-ranto/wip-rest-fix
Kefu Chai [Thu, 14 Feb 2019 11:08:07 +0000 (19:08 +0800)]
Merge pull request #26421 from b-ranto/wip-rest-fix

restful: Fix regression when traversing leaf nodes

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agomgr/dashboard: Add UI for NFS Form 26085/head
Tiago Melo [Thu, 4 Oct 2018 16:24:20 +0000 (17:24 +0100)]
mgr/dashboard: Add UI for NFS Form

Signed-off-by: Tiago Melo <tmelo@suse.com>
6 years agomgr/dashboard: Add UI for NFS List and Detail
Tiago Melo [Thu, 4 Oct 2018 16:20:10 +0000 (17:20 +0100)]
mgr/dashboard: Add UI for NFS List and Detail

Signed-off-by: Tiago Melo <tmelo@suse.com>
6 years agomgr/dashboard: Add NFS frontend services
Tiago Melo [Thu, 4 Oct 2018 16:14:26 +0000 (17:14 +0100)]
mgr/dashboard: Add NFS frontend services

Signed-off-by: Tiago Melo <tmelo@suse.com>
6 years agomgr/volumes: create/delete fs subvolumes 26423/head
Ramana Raja [Thu, 14 Feb 2019 09:41:02 +0000 (15:11 +0530)]
mgr/volumes: create/delete fs subvolumes

... within the specified fs volume.

Previously, subvolumes (fs subdirectories) weren't created within
the desired volumes (fs filestyems).

Fixes: https://tracker.ceph.com/issues/38297
Signed-off-by: Ramana Raja <rraja@redhat.com>
6 years agoMerge pull request #26410 from tspmelo/wip-bootstrap-3.4.1
Lenz Grimmer [Thu, 14 Feb 2019 10:07:18 +0000 (11:07 +0100)]
Merge pull request #26410 from tspmelo/wip-bootstrap-3.4.1

mgr/dashboard: Update bootstrap to v3.4.1

Reviewed-by: Stephan Müller <smueller@suse.com>
6 years agoMerge pull request #26409 from rhcs-dashboard/fix-tox-ini
Lenz Grimmer [Thu, 14 Feb 2019 10:06:26 +0000 (11:06 +0100)]
Merge pull request #26409 from rhcs-dashboard/fix-tox-ini

mgr/dashboard: fix: tox not detecting deps changes

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agomgr/dashboard: Fix typo in NoOrchesrtatorConfiguredException class name 26334/head
Volker Theile [Fri, 8 Feb 2019 13:00:27 +0000 (14:00 +0100)]
mgr/dashboard: Fix typo in NoOrchesrtatorConfiguredException class name

Signed-off-by: Volker Theile <vtheile@suse.com>
6 years agopybind/ceph_volume_client: allow volume_client to
Ramana Raja [Thu, 14 Feb 2019 09:25:24 +0000 (14:55 +0530)]
pybind/ceph_volume_client: allow volume_client to

... mount a specificied ceph filesystem.

Signed-off-by: Ramana Raja <rraja@redhat.com>
6 years agorestful: Fix regression when traversing leaf nodes 26421/head
Boris Ranto [Thu, 14 Feb 2019 09:35:56 +0000 (10:35 +0100)]
restful: Fix regression when traversing leaf nodes

The commit 23b6c90 introduced a regression when traversing leaf nodes.
The issue is that it traverses the keys of a `dict` returned by
`nodes_by_id`, not the actual `items` of the node. That resulted in an
500 error because it tried to treat `str` as a `dict` and failed.

Signed-off-by: Boris Ranto <branto@redhat.com>
6 years agorpm: move Python deps out of distro-conditional blocks 25963/head
Nathan Cutler [Tue, 15 Jan 2019 14:43:13 +0000 (15:43 +0100)]
rpm: move Python deps out of distro-conditional blocks

The python%{_python_buildid}-bcrypt and python%{_python_buildid}-requests RPMs
are identically named across all the RPM distros, so move them out of the
distro conditional blocks.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
6 years agorpm: make Python build deps somewhat less confusing
Nathan Cutler [Tue, 15 Jan 2019 14:34:42 +0000 (15:34 +0100)]
rpm: make Python build deps somewhat less confusing

Signed-off-by: Nathan Cutler <ncutler@suse.com>
6 years agomon/PGMap: add more #include 26420/head
Kefu Chai [Thu, 14 Feb 2019 09:26:19 +0000 (17:26 +0800)]
mon/PGMap: add more #include

* common/Clock.h for ceph_clock_now()
* global/global_context.h for g_conf()

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #26210 from falcon78921/wip-mgr-restful-python3
Kefu Chai [Thu, 14 Feb 2019 09:02:58 +0000 (17:02 +0800)]
Merge pull request #26210 from falcon78921/wip-mgr-restful-python3

mgr/restful: updated string formatting to str.format()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoMerge pull request #26315 from tchaikov/wip-fix-Waddress-of-packed-member
Kefu Chai [Thu, 14 Feb 2019 09:01:02 +0000 (17:01 +0800)]
Merge pull request #26315 from tchaikov/wip-fix-Waddress-of-packed-member

msg/msg_types.h: do not cast `ceph_entity_name` to `entity_name_t` for printing

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge pull request #26380 from tchaikov/wip-split-dashboard-package
Kefu Chai [Thu, 14 Feb 2019 08:59:58 +0000 (16:59 +0800)]
Merge pull request #26380 from tchaikov/wip-split-dashboard-package

deb,rpm,qa: split dashboard package

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
6 years agoMerge pull request #26419 from cyx1231st/wip-fix-echo
Kefu Chai [Thu, 14 Feb 2019 08:43:40 +0000 (16:43 +0800)]
Merge pull request #26419 from cyx1231st/wip-fix-echo

test/crimson: fixes of unittest_seastar_echo

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #25989 from votdev/feature_36488
Lenz Grimmer [Thu, 14 Feb 2019 08:43:15 +0000 (09:43 +0100)]
Merge pull request #25989 from votdev/feature_36488

mgr/dashboard: Add UI to configure the telemetry mgr plugin

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
6 years agoMerge pull request #26398 from SUSE/wip-fix-spec-badness
Kefu Chai [Thu, 14 Feb 2019 07:53:52 +0000 (15:53 +0800)]
Merge pull request #26398 from SUSE/wip-fix-spec-badness

ceph.spec.in: Don't use noarch for mgr module subpackages, fix /usr/lib64/ceph/mgr dir ownership

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agomds: handle leftover reconnect information 25739/head
Yan, Zheng [Thu, 20 Dec 2018 13:16:15 +0000 (21:16 +0800)]
mds: handle leftover reconnect information

previous commit allows client to split reconnect into multiple
messages. mds may evict client after getting incomplete recconect.

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
6 years agoclient: split large reconnect into multiple messages
Yan, Zheng [Thu, 20 Dec 2018 13:09:31 +0000 (21:09 +0800)]
client: split large reconnect into multiple messages

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
6 years agoMerge pull request #26393 from zmc/wip-rhel7-deps
Kefu Chai [Thu, 14 Feb 2019 05:03:07 +0000 (13:03 +0800)]
Merge pull request #26393 from zmc/wip-rhel7-deps

install-deps.sh: Fixes for RHEL 7

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agomds: update MClientReconnect encoding
Yan, Zheng [Tue, 18 Dec 2018 08:22:21 +0000 (16:22 +0800)]
mds: update MClientReconnect encoding

The old encoding assumes that snaprealms are encoded at the tail of
message payload. So it does not allow adding new fields to the message.
The patch introduce new encoding for MClientReconnect, the new encoding
allows us to extend MClientReconnect.

The new encoding is not compatible with the old encoding. If mds does
not understand the new encoding. client needs to use the old encoding
to encode MClientReconnect.

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
6 years agotest: Limit loops waiting for force-backfill/force-recovery to happen 26416/head
David Zafman [Wed, 13 Feb 2019 18:13:12 +0000 (10:13 -0800)]
test: Limit loops waiting for force-backfill/force-recovery to happen

Fixes: http://tracker.ceph.com/issues/38309
Signed-off-by: David Zafman <dzafman@redhat.com>
6 years agoMerge pull request #26411 from liewegas/wip-remove-smart
Dan Mick [Wed, 13 Feb 2019 22:49:11 +0000 (14:49 -0800)]
Merge pull request #26411 from liewegas/wip-remove-smart

mgr/smart: remove obsolete smart module

6 years agoMerge PR #26389 into master
Sage Weil [Wed, 13 Feb 2019 22:22:40 +0000 (16:22 -0600)]
Merge PR #26389 into master

* refs/pull/26389/head:
message/MMonMgrReport: conditionally reencode PGMapDigest
qa/suites/upgrade/luminous-x/parallel: enable all classes
qa/suites/upgrade/luminous-x/parallel/5-final-workload/rados_mon_thrash: use x branch
qa/suites/upgade/luminous-x: pglog_hardlimit succeeds now on luminous due to backport
mgr/DaemonServer: use a luminous-compatible 'mgr metadata' command
mgr/Mgr: print bad (non-object) json
qa/suites/upgrade/luminous-x/stress-split: mons on separate hosts, enable msgr2
qa/suites/upgrade/luminous-x/parallel: mon per host, msgr2
qa/suites/upgrade/luminous-x: whitelist 'slow request'
mon/HealthMonitor: add mon_warn_on_msgr2_not_enabled

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoosd: fix build_incremental_map_msg 26413/head
Sage Weil [Wed, 13 Feb 2019 21:01:48 +0000 (15:01 -0600)]
osd: fix build_incremental_map_msg

We need to fall back to an old map if since (the peer's epoch) is *older*
than our oldest.  If it's newer, we have it, and can just send
incrementals.

Fixes: http://tracker.ceph.com/issues/38282
Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomessage/MMonMgrReport: conditionally reencode PGMapDigest 26389/head
Sage Weil [Wed, 13 Feb 2019 13:29:45 +0000 (07:29 -0600)]
message/MMonMgrReport: conditionally reencode PGMapDigest

The encoding changed between luminous and mimic.  Reencode the
structure if the target doesn't have all the features.

Fixes: http://tracker.ceph.com/issues/38295
Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoqa/suites/upgrade/luminous-x/parallel: enable all classes
Sage Weil [Fri, 8 Feb 2019 19:46:00 +0000 (13:46 -0600)]
qa/suites/upgrade/luminous-x/parallel: enable all classes

Otherwise it's annoying because the class list changes between luminous and nautilus,
and we don't want to futz around with changing this setting during the upgrade.

The problematic classes are 'cas' (added) and 'sdk' (not enabled by default but
included by the cls/ workunit.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoqa/suites/upgrade/luminous-x/parallel/5-final-workload/rados_mon_thrash: use x branch
Sage Weil [Sun, 3 Feb 2019 17:04:15 +0000 (11:04 -0600)]
qa/suites/upgrade/luminous-x/parallel/5-final-workload/rados_mon_thrash: use x branch

The luminous version is (1) not what we want and (2) will fail because
ceph_test_rados_api_tier no longer exists in master.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoMerge pull request #26397 from guits/guits-fix_ceph-volume
Andrew Schoen [Wed, 13 Feb 2019 19:53:03 +0000 (13:53 -0600)]
Merge pull request #26397 from guits/guits-fix_ceph-volume

ceph-volume: update testing playbook 'deploy.yml'

Reviewed-by: Andrew Schoen <aschoen@redhat.com>
6 years agomgr/smart: remove 26411/head
Sage Weil [Wed, 13 Feb 2019 18:38:53 +0000 (12:38 -0600)]
mgr/smart: remove

This is obsolete and replaced by the devicehealth module.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomgr/restful: updated string formatting to str.format() 26210/head
James McClune [Wed, 30 Jan 2019 21:01:22 +0000 (16:01 -0500)]
mgr/restful: updated string formatting to str.format()

Made changes per @tchaikov's request

Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>
6 years agoceph-osd: be helpful about upgrade gate 26345/head
Sage Weil [Mon, 11 Feb 2019 15:32:40 +0000 (09:32 -0600)]
ceph-osd: be helpful about upgrade gate

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomon: record 'min_mon_release' file and prevent startup if it's too old
Sage Weil [Sat, 9 Feb 2019 19:42:49 +0000 (13:42 -0600)]
mon: record 'min_mon_release' file and prevent startup if it's too old

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomon/Monitor: do not join cluster that is >2 releases old
Sage Weil [Fri, 8 Feb 2019 21:12:57 +0000 (15:12 -0600)]
mon/Monitor: do not join cluster that is >2 releases old

This enforces the N+2 upgrade rule from the mon's perspective.

Note that this safety check is not as safe as the OSDs.  Notably, we
start up our backend store (rocksdb) *before* we probe other monitors
and discover any newer monmap that tells us we shouldn't join.  If there
is a *rocksdb* backward-compatibility problem it is too late by this
point.  Unfortunately, I don't see an easy way to get this far before
rocksdb is read-write--not without a lot more code, at least!

However, we'll still protect against a whole class of other potential
problems by not getting involved in a cluster that is too old.  :)

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomon/Elector: respect monmap min_mon_release
Sage Weil [Fri, 8 Feb 2019 16:51:25 +0000 (10:51 -0600)]
mon/Elector: respect monmap min_mon_release

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomon: check min_mon_release during probe
Sage Weil [Tue, 29 Jan 2019 19:19:44 +0000 (13:19 -0600)]
mon: check min_mon_release during probe

This will give us more informative errors messages than the feature bit
strings.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoqa/suites/upgade/luminous-x: pglog_hardlimit succeeds now on luminous due to backport
Sage Weil [Sat, 2 Feb 2019 18:08:02 +0000 (12:08 -0600)]
qa/suites/upgade/luminous-x: pglog_hardlimit succeeds now on luminous due to backport

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomgr/DaemonServer: use a luminous-compatible 'mgr metadata' command
Sage Weil [Wed, 30 Jan 2019 22:44:35 +0000 (16:44 -0600)]
mgr/DaemonServer: use a luminous-compatible 'mgr metadata' command

In luminous it was 'id', in mimic it changed to 'who'.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomgr/Mgr: print bad (non-object) json
Sage Weil [Wed, 30 Jan 2019 22:17:25 +0000 (16:17 -0600)]
mgr/Mgr: print bad (non-object) json

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoqa/suites/upgrade/luminous-x/stress-split: mons on separate hosts, enable msgr2
Sage Weil [Tue, 29 Jan 2019 23:02:54 +0000 (17:02 -0600)]
qa/suites/upgrade/luminous-x/stress-split: mons on separate hosts, enable msgr2

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoqa/suites/upgrade/luminous-x/parallel: mon per host, msgr2
Sage Weil [Mon, 28 Jan 2019 22:54:20 +0000 (16:54 -0600)]
qa/suites/upgrade/luminous-x/parallel: mon per host, msgr2

- mon per host
- enable msgr2 at the end
- include the nautilus.yaml

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomsg/msg_types.h: do not cast `ceph_entity_name` to `entity_name_t` for printing 26315/head
Kefu Chai [Thu, 7 Feb 2019 13:13:14 +0000 (21:13 +0800)]
msg/msg_types.h: do not cast `ceph_entity_name` to `entity_name_t` for printing

in GCC-9, `-Waddress-of-packed-member` is enabled, so we have warnings like:

src/msg/msg_types.h:142:41: warning: converting a packed 'const
ceph_entity_name' pointer (alignment 1) to a 'const entity_name_t'
pointer (alignment 8) may result in an unaligned pointer value
[-Waddress-of-packed-member]
  142 |   return out << *(const entity_name_t*)&addr;
      |                                         ^~~~

since the alignment of these two structures are different, we cannot
cast a structure with the alignment of 1 to a structure with the
alignment of 8. as the code generated by compiler accessing the members
of alignment 8 won't work with the members of alignment 1, we need to
create a temporary structure for printing it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #26406 from drunkard/master
Kefu Chai [Wed, 13 Feb 2019 16:37:34 +0000 (00:37 +0800)]
Merge pull request #26406 from drunkard/master

doc: typo fixes, s/Requered/Required/

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agomgr/dashboard: Update bootstrap to v3.4.1 26410/head
Tiago Melo [Wed, 13 Feb 2019 16:21:02 +0000 (16:21 +0000)]
mgr/dashboard: Update bootstrap to v3.4.1

This update fixes an XSS vulnerability (CVE-2019-8331)

Signed-off-by: Tiago Melo <tmelo@suse.com>
6 years agomgr/dashboard: fix: tox not detecting deps changes 26409/head
alfonsomthd [Wed, 13 Feb 2019 16:17:30 +0000 (17:17 +0100)]
mgr/dashboard: fix: tox not detecting deps changes

* tox.ini: replaced 'deps' setting by appropriate commands
  due to this bug:
  https://github.com/tox-dev/tox/issues/149
  tox is not detecting changes in requirements.txt when using
  'deps' setting in 'tox.ini'.

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
6 years agoMerge pull request #26325 from jtlayton/wip-jlayton-dashboard-orch
Lenz Grimmer [Wed, 13 Feb 2019 16:08:23 +0000 (17:08 +0100)]
Merge pull request #26325 from jtlayton/wip-jlayton-dashboard-orch

mgr/dashboard: use the orchestrator_cli backend setting

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoceph: omit hidden commands from suggestions 26063/head
Patrick Donnelly [Mon, 21 Jan 2019 22:45:07 +0000 (14:45 -0800)]
ceph: omit hidden commands from suggestions

Fixes: http://tracker.ceph.com/issues/37955
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agomgr/dashboard: Sync column style with the rest of the UI 26407/head
Volker Theile [Wed, 13 Feb 2019 15:40:13 +0000 (16:40 +0100)]
mgr/dashboard: Sync column style with the rest of the UI

Center the checkbox in the column.

Signed-off-by: Volker Theile <vtheile@suse.com>
6 years agomgr/dashboard: disallow editing read-only config options 26297/head
Tatjana Dehler [Wed, 6 Feb 2019 15:32:23 +0000 (16:32 +0100)]
mgr/dashboard: disallow editing read-only config options

Fixes: https://tracker.ceph.com/issues/34528
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
6 years agodoc: typo fixes, s/Requered/Required/ 26406/head
Drunkard Zhang [Wed, 13 Feb 2019 15:04:40 +0000 (23:04 +0800)]
doc: typo fixes, s/Requered/Required/

Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
6 years agoqa: exclude new packages when installing old versions 26380/head
Kefu Chai [Tue, 12 Feb 2019 09:14:19 +0000 (17:14 +0800)]
qa: exclude new packages when installing old versions

ceph-mgr-dashboard is introduced in nautilus, so exclude it when
installing old versions.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agorpm: split ceph-mgr-dashboard plugin into its own package
Kefu Chai [Tue, 12 Feb 2019 09:13:12 +0000 (17:13 +0800)]
rpm: split ceph-mgr-dashboard plugin into its own package

to make ceph-mgr-dashboard a separated package

- helps to reduce the repo size of downstream. because
  ceph-mgr-dashboard is an architecture independent package. by
  making it separated package avoids needless duplication of
  the same data in mutiple .debs.
- gives user a fine grained control of selection.

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #26390 from smithfarm/wip-doc-mgr-dashboard
Kefu Chai [Wed, 13 Feb 2019 13:31:58 +0000 (21:31 +0800)]
Merge pull request #26390 from smithfarm/wip-doc-mgr-dashboard

doc: add Ceph Manager Dashboard to top-level TOC

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoqa/suites/upgrade/luminous-x: whitelist 'slow request'
Sage Weil [Tue, 12 Feb 2019 17:26:54 +0000 (11:26 -0600)]
qa/suites/upgrade/luminous-x: whitelist 'slow request'

The luminous warnings say slow request.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agomon/HealthMonitor: add mon_warn_on_msgr2_not_enabled
Sage Weil [Mon, 28 Jan 2019 21:30:42 +0000 (15:30 -0600)]
mon/HealthMonitor: add mon_warn_on_msgr2_not_enabled

Default true, but allow users (or tests) to turn this warning off.

Signed-off-by: Sage Weil <sage@redhat.com>
6 years agoMerge PR #26265 into master
Sage Weil [Wed, 13 Feb 2019 12:40:41 +0000 (06:40 -0600)]
Merge PR #26265 into master

* refs/pull/26265/head:
qa/suites/rados/upgrade: whitelist 'slow request'

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>