Check pointer before deleting

Here I think should check the pointer, to avoid potential risk

Signed-off-by: Jiantao He <hejiantao5@gmail.com>

Merge pull request #2671 from ceph/wip-da-fix-make_check

Makefile.am: make sure everything was build before make check

Reviewed-by: Loic Dachary <loic-201408@dachary.org>

Merge pull request #2669 from ceph/wip-9692

qa/workunits/fs/misc: fix syntax error

Reviewed-by: Loic Dachary <loic-201408@dachary.org>

Merge pull request #2676 from ceph/wip-print-mode

client: print out mode, uid, gid if they are changed

qa/workunits/fs/misc: fix syntax error

Signed-off-by: Yan, Zheng <zyan@redhat.com>

Merge pull request #2677 from ceph/wip-mds-coverity

Wip mds coverity

mds: MDirUpdate: initialize discover count to 0 if we're not discovering

Otherwise it's left uninitialized and could do who-knows-what!

CID 1244229:  Uninitialized scalar field  (UNINIT_CTOR)
/messages/MDirUpdate.h: 55 in MDirUpdate::MDirUpdate(mds_rank_t, dirfrag_t,
int, std::set<int, std::less<int>, std::allocator<int>> &, filepath &, bool)()

Signed-off-by: Greg Farnum <greg@inktank.com>

mds: MDSAuthCaps: init "read" param in default constructor

CID 1244228:  Uninitialized scalar field  (UNINIT_CTOR)
/mds/MDSAuthCaps.h: 29 in MDSCapSpec::MDSCapSpec()()

Signed-off-by: Greg Farnum <greg@inktank.com>

client: print out mode, uid, gid if they are changed

These values can be printed by MClientRequest message output, but if
they're flushed out via cap updates we don't even get that. These
are important values that generally don't change often; so print
them out in debug logging.

Signed-off-by: Greg Farnum <greg@inktank.com>

Merge pull request #2511 from dachary/wip-catch-options-errors

test,tools: catch option parsing exceptions

Reviewed-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>

Merge pull request #2629 from dachary/wip-heap-profiler

perfglue: minors heap profiler updates and documentation

Reviewed-by: Jianpeng Ma <majianpeng@gmail.com>

Merge pull request #2586 from ceph/wip-mon-status

mon: make health portion of ceph -s readable (multiple lines)

Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>

Merge pull request #2673 from dachary/wip-ceph-erasure-code-corpus

build: add ceph-erasure-code-corpus to gitmodule_mirrors

Reviewed-by: Sandon Van Ness <sandon@inktank.com>

build: add ceph-erasure-code-corpus to gitmodule_mirrors

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

Makefile.am: make sure everything was build before make check

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

Merge remote-tracking branch 'upstream/giant'

Merge pull request #2616 from guangyy/wip-giant-9614

PG::actingset should be used when checking the number of acting OSDs for a given PG.

Backport: firefly
Reviewed-by: Samuel Just <sam.just@inktank.com>

Merge pull request #2663 from ceph/wip-9496

mon: PGMonitor: populate scrub timestamps with 'now' on pg creation

Reviewed-by: Samuel Just <sam.just@inktank.com>

Merge pull request #2650 from ceph/wip-9128

Add reset_tp_timeout in long loop in add_source_info for suicide timeout

Reviewed-by: Samuel Just <sam.just@inktank.com>

Merge pull request #2543 from ceph/wip-9419

Wip 9419

Reviewed-by: Samuel Just <sam.just@inktank.com>

Merge pull request #2670 from dachary/wip-9700-cephtool-mon-osd

qa: move mon_mds tests last

Reviewed-by: John Spray <john.spray@redhat.com>

qa: move mon_mds tests last

Assuming they are more likely than others to leave OSD/MON in an
unstable state that could have undefined side effects on the tests
following it. A cleaner solution would be to run them in a separate
script that is run on an independent cluster.

http://tracker.ceph.com/issues/9700 Fixes: #9700

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

Merge pull request #2569 from ceph/wip-9437

Implement `tell` in MDS

Reviewed-by: Reviewed-by: Greg Farnum <greg@inktank.com>

qa: cephtool tests for `tell mds.X`

Signed-off-by: John Spray <john.spray@redhat.com>

qa: fixup cephtool test when MDS exists

We added MDS resetting code here a while back,
but the order of operations was such that a
"cluster up" was being run between a fail_all_mds
and the point at which we needed the map not to
be interfered with (testing setmap).

Also the new fs create/destroy cycles for testing
EC pool handling were missing calls to stop the
daemons before fs rm.

Signed-off-by: John Spray <john.spray@redhat.com>

test: unit tests for MDSAuthCaps

Signed-off-by: John Spray <john.spray@redhat.com>

vstart: create fewer pgs for fs pools

Just so that dev clusters come up more
quickly.

Signed-off-by: John Spray <john.spray@redhat.com>

vstart: mds * auth caps

...so that the default client.admin identity
can call 'tell mds' things.

Signed-off-by: John Spray <john.spray@redhat.com>

mds: fix MDSAuthCap when cephx is disabled

Signed-off-by: John Spray <john.spray@redhat.com>

pybind/ceph_argparse: implement 'tell mds'

Signed-off-by: John Spray <john.spray@redhat.com>

pybind/cephfs: implement mds_command

Signed-off-by: John Spray <john.spray@redhat.com>

pybind/cephfs: implement conf_parse_argv

So that when using `ceph` we can pass through
--debug-x args etc.

Signed-off-by: John Spray <john.spray@redhat.com>

pybind/rados: add conf/conf_defaults attributes

Store these from initialization so that given a Rados
object, we can read back config to initialize a
LibCephFS object.

Signed-off-by: John Spray <john.spray@redhat.com>

libcephfs: add ceph_mds_command

Wraps the equivalent fn in Client.

Signed-off-by: John Spray <john.spray@redhat.com>

client: add mds_command operation

akin to Objecter::osd_command

Signed-off-by: John Spray <john.spray@redhat.com>

osdc/Objecter: don't consume non-osd cmd replies

...so that Client can get command replies from MDSs.

Signed-off-by: John Spray <john.spray@redhat.com>

mds: introduce MDS auth caps

Signed-off-by: John Spray <john.spray@redhat.com>

mds: handle MCommand (mds tell)

Separate path to legacy MMonCommand, because MCommand
from the CLI sends JSON-style commands.

Signed-off-by: John Spray <john.spray@redhat.com>

mds: deprecation-warn on numeric mds names

To be turned into strict check in post-hammer
release, so that we can always unambiguously
discriminate a string into one of name, rank, gid.

Signed-off-by: John Spray <john.spray@redhat.com>

common: fix cmd_getval constness

...so that one can pass in a const cmdmap.

Signed-off-by: John Spray <john.spray@redhat.com>

messages: fix constness in MCommand constructor

Signed-off-by: John Spray <john.spray@redhat.com>

mds: typedefs for rank and gid in MDSMap

Make it clearer what these numbers are where they appear.

Signed-off-by: John Spray <john.spray@redhat.com>

Merge pull request #2668 from theanalyst/fix/mailmap-again

Fix/mailmap again

Reviewed-by: Loic Dachary <loic-201408@dachary.org>

mailmap: João Eduardo Luís name normalization

Reported-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>

mailmap: Yongyue sun affiliation

Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>

mailmap: Andreas Peters name normalization

Reported-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>

Merge pull request #2665 from yuyuyu101/update-mailmap

mailmap: add yuandong to organizationmap

Reviewed-by: Loic Dachary <loic-201408@dachary.org>

doc: update memory-profiling with examples

* Update the ceph tell from ceph daemon tell id to the new
  ceph tell deamon.id form

* Add usages examples for easier copy / paste

* Add MON to the list of daemons that can be profiled

* Document CEPH_HEAP_PROFILER_INIT=true

* Remove trailing empty lines

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

mon,mds: call ceph_heap_profiler_init() at boot time

So that the CEPH_HEAP_PROFILER_INIT environment variable can be used to
start profiling.

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

perfglue: profiler stats need more than 1024 bytes

With a 1024 bytes buffer to display the stats, the end is truncated.
Use an array on the stack instead of leaking the buffer.

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

mailmap: add yuandong to organizationmap

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

test,tools: indentation, whitespace only

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

tools: allow_unregistered() options

So that --debug-mon etc. can be parsed afterwards.

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

tools: move po::collect_unrecognized in the try block

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

tools: display boost::program_options errors

Instead of silently discarding them. Do not display the usage on error
as it will probably hide the error message that shows before it.

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

test: catch boost::program_options errors

And display it before returning on error.

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

test,tools: capture boost::program_options in a try

When something fails boost::program_options throws an exception that
needs to be caught.

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

Merge pull request #2661 from dachary/wip-9677-ioprio-class-giant

common: ceph_ioprio_string_to_class always returns -EINVAL

Merge pull request #2617 from ceph/wip-9628

mds: Add session to sessionmap when its state becomes opening

Reviewed-by: Greg Farnum <greg@inktank.com>

mon: PGMonitor: populate scrub timestamps with 'now' on pg creation

Fixes: #9496
Signed-off-by: Joao Eduardo Luis <joao@redhat.com>

mon: PGMonitor: prettify access to pg_stats_t in register_pg

Signed-off-by: Joao Eduardo Luis <joao@redhat.com>

Merge pull request #2660 from athanatos/wip-9203

test/osd/Object: don't generate length of 0

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #2659 from athanatos/wip-9113

Wip 9113

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #2658 from athanatos/wip-9625

PG: release backfill reservations if a backfill peer rejects

Reviewed-by: Sage Weil <sage@redhat.com>

osd: Return EOPNOTSUPP if a set-alloc-hint occurs with OSDs that don't support

Add CEPH_FEATURE_OSD_SET_ALLOC_HINT feature bit
Collect the intersection of all peer feature bits during peering
When handling CEPH_OSD_OP_SETALLOCHINT check that all OSDs support it
by checking for CEPH_FEATURE_OSD_SET_ALLOC_HINT feature bit.

Fixes: #9419
Backport: firefly

Signed-off-by: David Zafman <dzafman@redhat.com>

osd: Remove unused PG functions queue_notify(), queue_info(), queue_log()

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge remote-tracking branch 'gh/giant'

Conflicts:
src/osdc/Objecter.cc

Merge tag 'v0.86' into giant

v0.86

0.86

Merge remote-tracking branch 'guangyy/wip-9008' into giant

Merge pull request #2631 from ceph/wip-rwtimer

DNM: osdc/Objecter: use SafeTimer; make callbacks race-tolerant

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

common: ceph_ioprio_string_to_class always returns -EINVAL

The l string is always empty because std::transform needs a
pre-allocated string. Replace with the in-place version. Add unit tests.

http://tracker.ceph.com/issues/9677 Fixes: #9677

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
(cherry picked from commit 3535b7aba3df8b54fa5117b8a9c2f52b8f0f118b)

osd: log error if set_ioprio fails to parse class

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
(cherry picked from commit 5088e0d49332d579ba7e33c2c9baee3d5f701a3e)

common: set_ioprio debug message including pid

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
(cherry picked from commit 33339c7754875eb7e513345ee6b26a9b2b4d2707)

common: do not set ioprio if pid is not set

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
(cherry picked from commit c7e4c0bfe70bf29d3b8fe4df4e4b934853e33d26)

doc: missing osd prefix to ioprio config options

http://tracker.ceph.com/issues/9676 Fixes: #9676

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
(cherry picked from commit 62235688c417ed19a472bc8a94bba005e03afbc6)

Merge pull request #2489 from guangyy/wip-9008

For pgls OP, get/put budget on per list session basis, instead of per OP basis.

Reviewed-by: Greg Farnum <greg@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>

Merge pull request #2655 from ceph/wip-9635

mon: fix async write completion waits

Fixes: #9635
Reviewed-by: Joao Eduardo Luis <joao@redhat.com>

Merge pull request #2654 from dachary/wip-9677-ioprio-class

common: ceph_ioprio_string_to_class always returns -EINVAL

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #2626 from dachary/wip-rados-empty-file

tools: rados put /dev/null should write() and not create()

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #2652 from ceph/wip-msgr

msgr: fix remaining direct references to "new SimpleMessenger" by replacing with the factory method

Reorganize the src/msg hierarchy to push SimpleMessenger down into a subfolder to make way for organizing new in-tree implementations.

Reviewed-by: Greg Farnum <greg@inktank.com>

Merge pull request #2560 from ceph/wip-9418

mon: add new profiles & audit cap checks

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #2647 from ceph/wip-rm-legacy-cli

tools: remove old ceph.cc

Reviewed-by: Loic Dachary <loic@dachary.org>

Merge pull request #2646 from ceph/wip-osd-op-macro

rados.h: use macros to generate osd ops definitons and strings

Reviewed-by: Sage Weil <sage@redhat.com>

0.86

Run configure without liblttng on squeeze as well.

Signed-off-by: Sandon Van Ness <sandon@inktank.com>

Run configure without liblttng on squeeze as well.

Signed-off-by: Sandon Van Ness <sandon@inktank.com>

common: ceph_ioprio_string_to_class always returns -EINVAL

The l string is always empty because std::transform needs a
pre-allocated string. Replace with the in-place version. Add unit tests.

http://tracker.ceph.com/issues/9677 Fixes: #9677

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

osd: log error if set_ioprio fails to parse class

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

common: set_ioprio debug message including pid

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

common: do not set ioprio if pid is not set

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

Merge pull request #2653 from dachary/wip-9676-ioprio-doc

doc: missing osd prefix to ioprio config options

Reviewed-by: Mehdi Abaakouk <sileht@sileht.net>

doc: missing osd prefix to ioprio config options

http://tracker.ceph.com/issues/9676 Fixes: #9676

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

msg: move SimpleMessenger to msg/simple/

Signed-off-by: Sage Weil <sage@redhat.com>

librados: use Messenger factory method

Signed-off-by: Sage Weil <sage@redhat.com>

msg: use localized cct for derr

Signed-off-by: Sage Weil <sage@redhat.com>

doc/release-notes: v0.86

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #2651 from ceph/wip-ostool

ceph_objectstore_tool: Accept CEPH_ARGS environment arguments

Reviewed-by: Sage Weil <sage@redhat.com>

ceph_objectstore_tool: Accept CEPH_ARGS environment arguments

Signed-off-by: David Zafman <dzafman@redhat.com>

Add reset_tp_timeout in long loop in add_source_info for suicide timeout

Fixes: #9128
Signed-off-by: luowei@yahoo-inc.com