mgr/orchestrator: Add error handling to interface

Also:

* Small test_orchestrator refactorization
* Improved Docstring in MgrModule.remote
* Added `raise_if_exception` that raises Exceptions
* Added `OrchestratorError` and `OrchestratorValidationError`
* `_orchestrator_wait` no longer raises anything
* `volumes` model also calls `raise_if_exception`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 61d53ed70e2deafd6bebdf0a8e569cdc46b89e97)

14.2.0

Merge PR #26956 into nautilus

* refs/pull/26956/head:
doc/releases/nautilus: more detail around ceph-volume step

Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #27011 from liewegas/wip-redirect-mimic

qa/suites/upgrade/mimic-x/parallel: enable all classes

Reviewed-by: Myoungwon Oh <omwmw@sk.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #27018 from liewegas/wip-38294

qa/suites/upgrade/luminous-x: disable c-o-t import/export tests between versions

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #26960 into nautilus

* refs/pull/26960/head:
ceph_release: nautilus is will be 'stable' for v14.2.0

Reviewed-by: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>

qa/suitse/upgrade/luminous-x/stress-split-erasure-code: disable c-o-t tests

The stress-split thrasher already had this off, but the ec variant did
not.  We don't support ceph-objectstore-tool exports/imports between major
versions.

Fixes: http://tracker.ceph.com/issues/38294
Signed-off-by: Sage Weil <sage@redhat.com>

ceph_test_rados_api_tier_cxx: remove mimic checks

These checks don't work when the cluster is newer than mimic.

Instead, let's just try not to run this test on a pre-mimic cluster.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #27002 into nautilus

* refs/pull/27002/head:
mgr/telemetry: check for errors when sending report

Reviewed-by: Sage Weil <sage@redhat.com>

qa/suites/upgrade/mimic-x/parallel: enable all classes

This fixes the redirect tiering tests, which need the 'cas' class.

Signed-off-by: Sage Weil <sage@redhat.com>

ceph_test_rados_api_tier_cxx: remove luminous check

It was a flawed check, since it would fail for anything newer than
luminous.  And in any case, we don't need it anymore.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #27000 into nautilus

* refs/pull/27000/head:
osd: stringify as int

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/telemetry: check for errors when sending report

There was no error checking, and the server has been failing for
some time, but no one noticed.  Oops.

Signed-off-by: Dan Mick <dan.mick@redhat.com>

Merge PR #26563 into nautilus

* refs/pull/26563/head:
doc/ceph-volume/lvm/batch: fix typos

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #26994 into nautilus

* refs/pull/26994/head:
doc: add scrub link for nautilus release notes

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #26822 into nautilus

* refs/pull/26822/head:
osd/PG: adjust pg history on fabricated merge target if necessary

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #26986 into nautilus

* refs/pull/26986/head:
mgr: Make 3rd parameter optional in ceph_get_module_option

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #26949 into nautilus

* refs/pull/26949/head:
mgr/dashboard: add test_module_selftest to API tests

Reviewed-by: Volker Theile <vtheile@suse.com>

osd: stringify as int

Otherwise we get

$ hexdump -C require_osd_release
00000000  0e 0a                                             |..|
00000002

Signed-off-by: Sage Weil <sage@redhat.com>

doc/releases/nautilus: more detail around ceph-volume step

Recommend host reboots to verify ceph-volume adoption worked.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #26997 from cbodley/wip-38008

doc/rgw: document placement targets and storage classes

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge PR #26995 into nautilus

* refs/pull/26995/head:
osd/PG: fix pg merge check for rc clusters

Reviewed-by: Neha Ojha <nojha@redhat.com>

doc/rgw: document storage class configuration

Fixes: http://tracker.ceph.com/issues/38008
Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc/rgw: document placement target configuration

Fixes: http://tracker.ceph.com/issues/24508
Signed-off-by: Casey Bodley <cbodley@redhat.com>

osd/PG: fix pg merge check for rc clusters

If a cluster had a pg merge pending before last_pg_merge_meta was
introduced then the source_pgid will be pg_t().  If that's the case,
skip these new checks.

Likewise, if we decode a legacy pg_pool_t, put the old merge les/lec
values into the correct location.

Signed-off-by: Sage Weil <sage@redhat.com>

doc: add scrub link for nautilus release notes

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #26958 into nautilus

* refs/pull/26958/head:
mon: avoid using naked pointer
msg/async: do not "return std::move(local_var)"
mon: do not assert on bad auth payload

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge PR #26959 into nautilus

* refs/pull/26959/head:
mgr/crash: include entity (instead of daemon) in 'crash ls'

Reviewed-by: Dan Mick <dmick@redhat.com>

Merge PR #26965 into nautilus

* refs/pull/26965/head:
ms/async/ProtocolV2: add ms_die_on_bug and assert rxbuf/txbuf don't get big
msg/async/ProtocolV2: do not reenable pre_auth buffering on from reset_recv_state

Reviewed-by: Ricardo Dias <rdias@suse.com>

Merge PR #26974 into nautilus

* refs/pull/26974/head:
doc: add cephfs scrub related admin document

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #26984 from ricardoasmarques/remove-iscsi-gateway-param-nautilus

mgr/dashboard: Drop iSCSI gateway name parameter

Reviewed-by: Ricardo Dias <rdias@suse.com>

mgr: Make 3rd parameter optional in ceph_get_module_option

Fixes: https://tracker.ceph.com/issues/38766
File "/usr/share/ceph/mgr/mgr_module.py", line 863, in _handle_command
2019-03-15T11:28:31.324 INFO:tasks.ceph.mgr.x.mira117.stderr:    return self.handle_command(inbuf, cmd)
2019-03-15T11:28:31.324 INFO:tasks.ceph.mgr.x.mira117.stderr:  File "/usr/share/ceph/mgr/selftest/module.py", line 114, in handle_command
2019-03-15T11:28:31.324 INFO:tasks.ceph.mgr.x.mira117.stderr:    self._self_test()
2019-03-15T11:28:31.325 INFO:tasks.ceph.mgr.x.mira117.stderr:  File "/usr/share/ceph/mgr/selftest/module.py", line 213, in _self_test
2019-03-15T11:28:31.325 INFO:tasks.ceph.mgr.x.mira117.stderr:    self._self_test_config()
2019-03-15T11:28:31.325 INFO:tasks.ceph.mgr.x.mira117.stderr:  File "/usr/share/ceph/mgr/selftest/module.py", line 313, in _self_test_config
2019-03-15T11:28:31.325 INFO:tasks.ceph.mgr.x.mira117.stderr:    assert self.get_module_option_ex("foo", "bar") is None
2019-03-15T11:28:31.325 INFO:tasks.ceph.mgr.x.mira117.stderr:  File "/usr/share/ceph/mgr/mgr_module.py", line 942, in get_module_option_ex
2019-03-15T11:28:31.325 INFO:tasks.ceph.mgr.x.mira117.stderr:    r = self._ceph_get_module_option(module, key)
2019-03-15T11:28:31.325 INFO:tasks.ceph.mgr.x.mira117.stderr:TypeError: ceph_get_module_option() takes exactly 3 arguments (2 given)

Signed-off-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Drop iSCSI gateway name parameter

iSCSI gateway name will now be obtained from the
ceph-iscsi `/api/sysinfo/hostname` endpoint

Signed-off-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #26971 from theanalyst/nautilus-rgw-enoent-mdlog

rgw_sync: drop ENOENT error logs from mdlog

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

mon: avoid using naked pointer

to save our trouble to delete auth_handler in the error handling paths

Signed-off-by: Kefu Chai <kchai@redhat.com>

msg/async: do not "return std::move(local_var)"

it prevents copy elision. and both GCC and Clang warn like

warning: moving a local object in a return statement prevents copy
elision [-Wpessimizing-move]

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: do not assert on bad auth payload

If we get garbage, fail to authenticate--do not assert out and crash.

Signed-off-by: Sage Weil <sage@redhat.com>

ms/async/ProtocolV2: add ms_die_on_bug and assert rxbuf/txbuf don't get big

Signed-off-by: Sage Weil <sage@redhat.com>

msg/async/ProtocolV2: do not reenable pre_auth buffering on from reset_recv_state

This is specifically bad because we call reset_recv_state from
reuse_connection, which turns buffering back on on an already-authenticated
session.

Instead, reenable it only when we set the state to START_CONNECT.  (On
the accepting side, it is a fresh connection, so it starts out true.)
Also, we want to *disable* it on the connection we are reusing, which
might be in a pre-auth state, while we are in a post-auth state.

Fixes: http://tracker.ceph.com/issues/38746
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #26738 from votdev/fix_docs

mgr/dashboard: Fix issues in controllers/docs

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tina Kallio <tina.kallio@gmail.com>

doc: add cephfs scrub related admin document

Fixes: http://tracker.ceph.com/issues/38728
Signed-off-by: Venky Shankar <vshankar@redhat.com>

rgw_sync: drop ENOENT error logs from mdlog

Since this commonly occurs and isn't an error of concern at level 1.

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit c246abb3935266f9335cab97e52ab489cc7ebfd6)

Merge PR #26898 into nautilus

* refs/pull/26898/head:
osd/PG: invalidate PG if merging with unexpected version
osd,mon: include more pg merge metadata in pg_pool_t
qa/standalone/osd/pg-split-merge.sh: reproduce pg merge problem with empty pgs
osd: add osd_debug_no_{acting_change,purge_strays}

Reviewed-by: Neha Ojha <nojha@redhat.com>

mgr/crash: include entity (instead of daemon) in 'crash ls'

The daemon name is implied by the entity, and the entity is more useful.

Signed-off-by: Sage Weil <sage@redhat.com>

ceph_release: nautilus is will be 'stable' for v14.2.0

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #26905 into nautilus

* refs/pull/26905/head:
mgr: Cleanup get_localized_module_option function

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge PR #26875 into nautilus

* refs/pull/26875/head:
common: implement HMACs on top of OpenSSL.
msg/async, v2: switch the pre-auth mechanism to HMAC-SHA256.
include/types: beef sha_digest_t up with encode and compare.
auth: add hmac_sha256() to CryptoKey.
msg/async, v2: introduce pre_auth exchanges with CRC32.
msg/async, v2: introduce pre_auth buffers.
msg/async, v2: rectify the encapsulation of rx_segments_{desc,data}.
msg/async, v2: rework decoding of MessageFrame.
msg/async, v2: limit the num_segments to non-empty segments.
msg/async, v2: drop the bl onwire space optimization in ControlFrames.
msg/async, v2: clean up ret handling in ProtocolV2::write().
msg/async, v2: drop next_payload_len as we don't need anymore.
msg/async, v2: drop temp_buffer and limitations driven by it.
msg/async, v2: switch to rx_buffer_t entirely.
msg/async, v2: rx continuations use buffer::ptr_node.
msg/async, v2: use bptr continuation for segment reading.
msg/async: introduce bptr-carrying continuations.
msg/async: replace CONTINUATION_PARAM() with specialized types.
msg/async, v2: ::_banner_exchange() takes CtRef instead of CtPtr.
msg/async: avoid extra pointers in continuation definitions.
msg/async, v2: dissect setting stream handlers into ::finish_auth().
msg/async, v2: drop ceph_msg_header2 handling from ControlFrames.
msg/async, v2: drop the SignedEncryptedFrame entirely.
msg/async, v2: reintroduce segment aligment. It's compile-time now.
msg/async, v2: generalize Frame about number of segments.
msg/async, v2: rework and generalize Frame encryption.
msg/async, v2: rework the class hierarchy - introduce MessageFrame.
msg/async, v2: rework the class hierarchy - introduce ControlFrame.
msg/async/ProtocolV2: remove obsolete AuthFlags

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26918 from trociny/wip-rbd-bench-wait-on-interrupted

rbd: wait for all io complete when bench is interrupted

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

mgr: Cleanup get_localized_module_option function

Address comments from https://github.com/ceph/ceph/pull/26736.

Signed-off-by: Volker Theile <vtheile@suse.com>

Merge PR #26948 into nautilus

* refs/pull/26948/head:
rbd-nbd: fix segfault for list-mapped command

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #26864 into nautilus

* refs/pull/26864/head:
rados: update to latest ver. of dmclock lib w performance enhancements

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: yanjun <yan.jun8@zte.com.cn>
Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #26921 into nautilus

* refs/pull/26921/head:
mgr/telemetry: fix 'telemetry {on,off}'

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #26924 into nautilus

* refs/pull/26924/head:
auth/cephx: fix decode_encrypt error handling
auth/cephx: fix encode_encrypt error handling

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26951 from ricardoasmarques/validate-ceph-iscsi-config-version-nautilus

nautilus: mgr/dashboard: Validate `ceph-iscsi` config version

Reviewed-by: Ricardo Dias <rdias@suse.com>

mgr/dashboard: Validate `ceph-iscsi` config version

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit b9b2b562ccf5dc6469d11912ee28dd2d932fdb48)

mgr/dashboard: add test_module_selftest to API tests

* This test suite helps to catch mgr module regressions introduced by
dashboard feature/bugfix.
* Fixed: 'ceph -w' now behaves properly for Python 3.

Fixes: https://tracker.ceph.com/issues/38394
Signed-off-by: Alfonso Martínez <almartin@redhat.com>

rbd-nbd: fix segfault for list-mapped command

The global ceph context is not initialized when list-mapped command
is issued.

The regression was introduced by a92628f2857390460e35ae60b8e06f16296da481.

Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge PR #26935 into nautilus

* refs/pull/26935/head:
qa: extend MDS heartbeat grace for valgrind

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #26916 into nautilus

* refs/pull/26916/head:
qa: ignore MON_DOWN for volume-client testing

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #26894 into nautilus

* refs/pull/26894/head:
qa/standalone/erasure-code/test-erasure-code: adjust test to avoid m=0
erasure-code: ensure m >= 1
mon/OSDMonitor: set ec min_size to k + min(1, m - 1)

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #26919 into nautilus

* refs/pull/26919/head:
doc: add CephFS notes for nautilus

Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

doc: add CephFS notes for nautilus

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge remote-tracking branch 'gh/nautilus'

qa/standalone/erasure-code/test-erasure-code: adjust test to avoid m=0

_DD is k=2 m=0, which we don't allow.  Switch it to cDD.

I confess I don't fully understand why this was _DD to begin with, but
I'm pretty sure mapping is there to control the order of results so that
it can be mapped to the CRUSH rule output sanely, and the coding portion
is not relevant to the test.

Signed-off-by: Sage Weil <sage@redhat.com>

qa: extend MDS heartbeat grace for valgrind

Valgrind makes the MDS slowwwww. The newish mds_heartbeat_grace config allows
us to keep sending beacons to the mons even if the internal heartbeat is slow.
This avoids the laggy messages which are useful to grep for unrelated messaging
issues.

Fixes: http://tracker.ceph.com/issues/38723
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #26790 from ricardoasmarques/iscsi-passwords-with-slash

mgr/dashboard: iSCSI - Support iSCSI passwords with '/'

Reviewed-by: Patrick Nawracay <pnawracay@suse.com>

mgr/telemetry: fix 'telemetry {on,off}'

Signed-off-by: Sage Weil <sage@redhat.com>

doc/ceph-volume/lvm/batch: fix typos
Fix typos in ceph-volume lvm batch documentation
Signed-off-by: Alexandru Cucu <me@alexcucu.ro>

mgr/dashboard: Always get iSCSI passwords decrypted

Fixes: https://tracker.ceph.com/issues/38630
Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Support iSCSI password with '/'

Signed-off-by: Ricardo Marques <rimarques@suse.com>

Merge pull request #26765 from p-na/wip-pna-rbd-conf-table-search

mgr/dashboard: Fix search in `Source` column of RBD configuration list

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #26766 from p-na/wip-pna-fix-table-search

mgr/dashboard: Search broken for entries with null values

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #26800 from linuxbox2/wip-rgw-limitcheck-trunc

rgw: bucket limit check misbehaves for > max-entries buckets (usually…

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge PR #26920 into master

* refs/pull/26920/head:
qa/tasks/mgr/test_module_selftest: fix localized value test
mgr/BaseMgrStandbyModule: parse prefix properly

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #26756 from badone/wip-f28-broken-Cython-dep

rpm: Install python2-Cython on f28

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Boris Ranto <branto@redhat.com>

qa/tasks/mgr/test_module_selftest: fix localized value test

When mgr/selftest/testkey = foo and mgr/selftest/x/testkey is not set,
then get_localized() should return foo.

Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #26886 into master

* refs/pull/26886/head:
crush/CrushWrapper: ensure crush_choose_arg_map.size == max_buckets

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge PR #26917 into master

* refs/pull/26917/head:
osd/osd_types: include omap and hit_set_archive bytes in pool usage

Reviewed-by: Neha Ojha <nojha@redhat.com>

auth/cephx: fix decode_encrypt error handling

**decode_encrypt** returns 0 on success, 1 otherwise

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #26788 from ricardoasmarques/iscsi-docs-password

doc/rbd/iscsi-target-cli: Update auth command

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

auth/cephx: fix encode_encrypt error handling

**encode_encrypt** returns 0 on success, 1 otherwise

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

rpm: Install python2-Cython in python2 environment

do_cmake.sh tests for Cython module version in python2

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

common: implement HMACs on top of OpenSSL.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

msg/async, v2: switch the pre-auth mechanism to HMAC-SHA256.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

include/types: beef sha_digest_t up with encode and compare.

BEWARE: sha_digest_t is part of our public. The commit tries to
preserve it as the cost of avoiding a clean-up.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

auth: add hmac_sha256() to CryptoKey.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

msg/async, v2: introduce pre_auth exchanges with CRC32.

CRC32 is just scaffolding and will be replaced with
HMAC-SHA256 or other msg auth code.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #26880 from pcuzner/prom-add-recovery-metrics

mgr/prometheus: Add recovery metrics

Reviewed-by: Boris Ranto <branto@redhat.com>

mgr/BaseMgrStandbyModule: parse prefix properly

Fixes: http://tracker.ceph.com/issues/38705
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #26712 from badone/wip-b64decode-decorator-traceback

pybind/mgr/restful: Decode the output of b64decode

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Boris Ranto <branto@redhat.com>

Merge pull request #26899 from dzafman/wip-38678

Minor cleanups in tests and log output

Reviewed-by: Neha Ojha <nojha@redhat.com>

rbd: wait for all io complete when bench is interrupted

Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge PR #26890 into master

* refs/pull/26890/head:
ceph.spec.in: add libstoragemgmt to mgr package

Reviewed-by: Sage Weil <sage@redhat.com>

erasure-code: ensure m >= 1

Fixes: http://tracker.ceph.com/issues/38682
Signed-off-by: Sage Weil <sage@redhat.com>

Merge PR #26893 into master

* refs/pull/26893/head:
qa: unmount clients prior to marking fs down

Reviewed-by: Zheng Yan <zyan@redhat.com>

osd/osd_types: include omap and hit_set_archive bytes in pool usage

- Include the hit_set_archive bytes if we're in legacy mode.

- Add in (estimated) omap bytes for both nautilus+ and legacy mode, since
we didn't break out omap usage by pool (oops!).

Fixes: http://tracker.ceph.com/issues/38703
Signed-off-by: Sage Weil <sage@redhat.com>

qa: ignore MON_DOWN for volume-client testing

The test restarts the monitors.

Fixes: http://tracker.ceph.com/issues/38704
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #26892 into master

* refs/pull/26892/head:
qa: stop testing simple messenger in CephFS suites

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #26503 from ricardoasmarques/iscsi-support-dots-in-name

mgr/dashboard: iSCSI - Adds support for pool/image names with dots

Reviewed-by: Ricardo Dias <rdias@suse.com>

crush/CrushWrapper: ensure crush_choose_arg_map.size == max_buckets

The crush/builder.c crush_add_bucket method resizes the max_buckets array
but a power of 2 when it has to expand, but the code in CrushWrapper was
assuming that if the array grew the pos for the new bucket would be the
last position in the new array.  This led to a situation where the
crush_choose_arg_map args array size didn't match max_buckets, and
eventually caused a crash.

Fixes: http://tracker.ceph.com/issues/38664
Signed-off-by: Sage Weil <sage@redhat.com>