]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 years agopybind/mgr: remove type conversions for ceph native options 29855/head
Sage Weil [Fri, 23 Aug 2019 17:15:01 +0000 (12:15 -0500)]
pybind/mgr: remove type conversions for ceph native options

We now return the correct Py types, just like we do for module options.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr: return get_ceph_option result as typed Py object (not string)
Sage Weil [Fri, 23 Aug 2019 17:14:24 +0000 (12:14 -0500)]
mgr: return get_ceph_option result as typed Py object (not string)

We already return module options as the proper Py type; do the same for
native ceph options.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #29613 from trociny/wip-41206
Jason Dillaman [Tue, 3 Sep 2019 14:20:23 +0000 (10:20 -0400)]
Merge pull request #29613 from trociny/wip-41206

librbd: behave more gracefully when data pool removed

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge PR #29835 into master
Sage Weil [Tue, 3 Sep 2019 14:19:21 +0000 (09:19 -0500)]
Merge PR #29835 into master

* refs/pull/29835/head:
osd/PeeringState: fix wrong history of merge target

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #30097 from jan--f/ceph-backport-cp-indiviudal-commits
Nathan Cutler [Tue, 3 Sep 2019 13:22:05 +0000 (15:22 +0200)]
Merge pull request #30097 from jan--f/ceph-backport-cp-indiviudal-commits

ceph-backport.sh: cherry-pick individual commits

Reviewed-by: Nathan Cutler <ncutler@suse.com>
5 years agoMerge pull request #30063 from Rjerk/wip-silence-unused-warning
Casey Bodley [Tue, 3 Sep 2019 13:19:06 +0000 (09:19 -0400)]
Merge pull request #30063 from Rjerk/wip-silence-unused-warning

rgw/services: silence -Wunused-variable warning

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #30065 from tchaikov/wip-rgw-test-wo-global
Casey Bodley [Tue, 3 Sep 2019 13:15:06 +0000 (09:15 -0400)]
Merge pull request #30065 from tchaikov/wip-rgw-test-wo-global

test: do not include unnecessary includes

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoceph-backport.sh: cherry-pick individual commits 30097/head
Jan Fajerski [Tue, 3 Sep 2019 11:26:20 +0000 (13:26 +0200)]
ceph-backport.sh: cherry-pick individual commits

In git 2.23.0 (possibly earlier too) cherry-pick seems to interact with
rev-list and submodules in unexpected ways, where the cherry-pick of a
commit range (<sha1>..<sha1>) fails with "changes would be overwritten"
in a submodule. CP'ing individual commits avoids this.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
5 years agoMerge pull request #30060 from c744402859/master
Casey Bodley [Tue, 3 Sep 2019 12:57:21 +0000 (08:57 -0400)]
Merge pull request #30060 from c744402859/master

rgw: fixed "unrecognized arg" error when using "radosgw-admin zone rm".

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #30091 from joke-lee/doc-rgw-object-version
Casey Bodley [Tue, 3 Sep 2019 12:34:05 +0000 (08:34 -0400)]
Merge pull request #30091 from joke-lee/doc-rgw-object-version

rgw: add --object-version in radosgw-admin help info

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #29957 from smithfarm/wip-ceph-backport-sh-improvements
Nathan Cutler [Tue, 3 Sep 2019 10:50:39 +0000 (12:50 +0200)]
Merge pull request #29957 from smithfarm/wip-ceph-backport-sh-improvements

script/ceph-backport.sh: wholesale refactor

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
5 years agoMerge pull request #29665 from rishabh-d-dave/cv-remove-redundant-calls
Jan Fajerski [Tue, 3 Sep 2019 08:55:24 +0000 (10:55 +0200)]
Merge pull request #29665 from rishabh-d-dave/cv-remove-redundant-calls

ceph-volume: minor optimizations related to class Volumes's use

5 years agorgw: add --object-version in radosgw-admin help info 30091/head
yuliyang [Tue, 3 Sep 2019 06:03:36 +0000 (14:03 +0800)]
rgw: add --object-version in radosgw-admin help info

Signed-off-by: yuliyang <yuliyang@cmss.chinamobile.com>
5 years agoMerge pull request #30086 from uniqueyehu/fix-complie-errors-dpdk
Kefu Chai [Tue, 3 Sep 2019 04:29:38 +0000 (12:29 +0800)]
Merge pull request #30086 from uniqueyehu/fix-complie-errors-dpdk

msg/async/dpdk: fix complie errors from fix FTBFS

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agomsg/async/dpdk: fix complie errors from fix FTBFS 30086/head
yehu [Tue, 3 Sep 2019 02:49:12 +0000 (10:49 +0800)]
msg/async/dpdk: fix complie errors from fix FTBFS

Signed-off-by: yehu <yehu5@huawei.com>
5 years agoMerge pull request #30010 from wjwithagen/wjw-fix-rbd-ggate-postfork
Mykola Golub [Mon, 2 Sep 2019 16:31:46 +0000 (19:31 +0300)]
Merge pull request #30010 from wjwithagen/wjw-fix-rbd-ggate-postfork

tools/rbd-ggate: close log before running postfork

Reviewed-by: Mykola Golub <mgolub@suse.com>
5 years agoMerge pull request #29923 from xiexingguo/wip-bump-decode-version
Kefu Chai [Mon, 2 Sep 2019 14:18:23 +0000 (22:18 +0800)]
Merge pull request #29923 from xiexingguo/wip-bump-decode-version

osd/osd_types: bump up some encoding versions

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: yanjun <yan.jun8@zte.com.cn>
5 years agoMerge pull request #30066 from uniqueyehu/fix-compile-error-dpdk
Kefu Chai [Mon, 2 Sep 2019 13:13:46 +0000 (21:13 +0800)]
Merge pull request #30066 from uniqueyehu/fix-compile-error-dpdk

async/dpdk: fix compile errors from ceph::mutex update

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agotest: do not include unnecessary includes 30065/head
Kefu Chai [Mon, 2 Sep 2019 08:37:14 +0000 (16:37 +0800)]
test: do not include unnecessary includes

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agorgw: fixed "unrecognized arg" error when using "radosgw-admin zone rm". 30060/head
root [Mon, 2 Sep 2019 03:23:45 +0000 (11:23 +0800)]
rgw: fixed "unrecognized arg" error when using "radosgw-admin zone rm".

Signed-off-by: Hongang Chen <c744402859@gmail.com>
Author:    root <root@devel.localdomain>
Date:      Mon Sep 2 11:23:45 2019 +0800

5 years agoMerge pull request #30034 from tchaikov/wip-install-tox-deps-from-wheelhouse
Kefu Chai [Mon, 2 Sep 2019 09:24:23 +0000 (17:24 +0800)]
Merge pull request #30034 from tchaikov/wip-install-tox-deps-from-wheelhouse

mgr: install tox deps from wheelhouse

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
5 years agoasync/dpdk: fix compile errors from ceph::mutex update 30066/head
yehu [Mon, 2 Sep 2019 08:35:22 +0000 (16:35 +0800)]
async/dpdk: fix compile errors from ceph::mutex update

Signed-off-by: yehu <yehu5@huawei.com>
5 years agotools/rbd-ggate: close log before running postfork 30010/head
Willem Jan Withagen [Thu, 29 Aug 2019 13:54:30 +0000 (15:54 +0200)]
tools/rbd-ggate: close log before running postfork

Otherwise the assert in Log:open() will trigger since
all data is kept during the fork and also the `is_started` flag

Fixes: https://tracker.ceph.com/issues/41592
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
5 years agorgw/services: silence -Wunused-variable warning 30063/head
Lan Liu [Mon, 2 Sep 2019 07:10:58 +0000 (15:10 +0800)]
rgw/services: silence -Wunused-variable warning

Signed-off-by: Lan Liu <liulan@umcloud.com>
5 years agoscript/run_tox.sh: install tox deps from wheelhouse 30034/head
Kefu Chai [Fri, 30 Aug 2019 09:40:25 +0000 (17:40 +0800)]
script/run_tox.sh: install tox deps from wheelhouse

could be faster

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #29583 from rafaelquint/configfield2
Ricardo Marques [Sat, 31 Aug 2019 09:36:01 +0000 (10:36 +0100)]
Merge pull request #29583 from rafaelquint/configfield2

mgr/dashboard: Verify fields on Configuration page

Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
6 years agoMerge pull request #29919 from dzafman/wip-41522
David Zafman [Sat, 31 Aug 2019 00:14:20 +0000 (17:14 -0700)]
Merge pull request #29919 from dzafman/wip-41522

ceph-objectstore-tool can't remove head with bad snapset

Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge pull request #29941 from dzafman/wip-41517
David Zafman [Fri, 30 Aug 2019 23:22:27 +0000 (16:22 -0700)]
Merge pull request #29941 from dzafman/wip-41517

osd: Fix assert in the case that snapset is missing

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Xie Xingguo <xie.xingguo@zte.com.cn>
6 years agoMerge pull request #30019 from mxdInspur/fix_20190829
Jason Dillaman [Fri, 30 Aug 2019 15:12:26 +0000 (11:12 -0400)]
Merge pull request #30019 from mxdInspur/fix_20190829

librbd: clean up unused variable

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #29968 from wjwithagen/wjw-fix-dencode-bluestore_bdev_t
Kefu Chai [Fri, 30 Aug 2019 15:06:20 +0000 (23:06 +0800)]
Merge pull request #29968 from wjwithagen/wjw-fix-dencode-bluestore_bdev_t

bluestore/bdev: initialize size when creating object.

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #29931 from yaozongyou/refine-decltype
Kefu Chai [Fri, 30 Aug 2019 14:57:21 +0000 (22:57 +0800)]
Merge pull request #29931 from yaozongyou/refine-decltype

osdc: using decltype(auto) instead of trailing return type

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agolibrbd: clean up unused variable: C_MigrateObject::m_object_size 30019/head
mxdInspur [Fri, 30 Aug 2019 01:34:19 +0000 (09:34 +0800)]
librbd: clean up unused variable: C_MigrateObject::m_object_size

Fixes: https://tracker.ceph.com/issues/41580
Signed-off-by: mxdInspur <muxiangdong@inspur.com>
6 years agoMerge pull request #30035 from tchaikov/wip-rgw-maybe-unused
Casey Bodley [Fri, 30 Aug 2019 14:02:33 +0000 (10:02 -0400)]
Merge pull request #30035 from tchaikov/wip-rgw-maybe-unused

rgw/rgw_user: add [[maybe_unused]] for silencing -Wunused-variable wa…

Reviewed-by: Casey Bodley <cbodley@redhat.com>
6 years agoMerge pull request #29927 from votdev/add_cephfs_legend
Ricardo Dias [Fri, 30 Aug 2019 13:14:10 +0000 (14:14 +0100)]
Merge pull request #29927 from votdev/add_cephfs_legend

mgr/dashboard: Display legend for CephFS standbys

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
6 years agoMerge pull request #29934 from votdev/add_missing_i18n
Ricardo Dias [Fri, 30 Aug 2019 13:11:39 +0000 (14:11 +0100)]
Merge pull request #29934 from votdev/add_missing_i18n

mgr/dashboard: Add missing text translation

Reviewed-by: Tiago Melo <tmelo@suse.com>
6 years agoMerge pull request #30001 from votdev/issue_41573
Ricardo Dias [Fri, 30 Aug 2019 13:08:39 +0000 (14:08 +0100)]
Merge pull request #30001 from votdev/issue_41573

mgr/dashboard: A block-manager can not access the pool page

6 years agoMerge pull request #28885 from Kriechi/fix-bucket-policy-spelling
Casey Bodley [Fri, 30 Aug 2019 13:06:38 +0000 (09:06 -0400)]
Merge pull request #28885 from Kriechi/fix-bucket-policy-spelling

docs: rgw: fix bucket operation spelling: ListBucketMultipartUploads

Reviewed-by: Casey Bodley <cbodley@redhat.com>
6 years agoscript/ceph-backport.sh: leave Assignee blank in backport PR 29957/head
Nathan Cutler [Fri, 30 Aug 2019 12:32:22 +0000 (14:32 +0200)]
script/ceph-backport.sh: leave Assignee blank in backport PR

Signed-off-by: Nathan Cutler <ncutler@suse.com>
6 years agomgr/dashboard: Verify fields on Configuration page 29583/head
Rafael Quintero [Fri, 9 Aug 2019 20:02:36 +0000 (16:02 -0400)]
mgr/dashboard: Verify fields on Configuration page

Fixes: https://tracker.ceph.com/issues/41193
Signed-off-by: Adam King <adking@redhat.com>
Signed-off-by: Rafael Quintero <rquinter@redhat.com>
6 years agoMerge pull request #29794 from votdev/improve_error_msg
Ricardo Dias [Fri, 30 Aug 2019 11:37:56 +0000 (12:37 +0100)]
Merge pull request #29794 from votdev/improve_error_msg

mgr/dashboard: Improve RestClient error logging

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
6 years agoMerge pull request #29353 from votdev/issue_40981
Ricardo Dias [Fri, 30 Aug 2019 10:18:58 +0000 (11:18 +0100)]
Merge pull request #29353 from votdev/issue_40981

mgr/dashboard: CephFS class issues with strings

6 years agoMerge pull request #29848 from rhcs-dashboard/fix-41358-master
Volker Theile [Fri, 30 Aug 2019 10:09:26 +0000 (12:09 +0200)]
Merge pull request #29848 from rhcs-dashboard/fix-41358-master

mgr/dashboard: fix SAML input argument handling

Reviewed-by: Lenz Grimmer <LGrimmer@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agomgr/dashboard: fix tox missing bits and add lint-fixer (#29802)
Volker Theile [Fri, 30 Aug 2019 10:09:00 +0000 (12:09 +0200)]
mgr/dashboard: fix tox missing bits and add lint-fixer (#29802)

mgr/dashboard: fix tox missing bits and add lint-fixer

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agorgw/rgw_user: add [[maybe_unused]] for silencing -Wunused-variable warning 30035/head
Kefu Chai [Fri, 30 Aug 2019 10:04:20 +0000 (18:04 +0800)]
rgw/rgw_user: add [[maybe_unused]] for silencing -Wunused-variable warning

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agoMerge pull request #29993 from votdev/fix_pool_e2e
Laura Paduano [Fri, 30 Aug 2019 09:59:41 +0000 (11:59 +0200)]
Merge pull request #29993 from votdev/fix_pool_e2e

mgr/dashboard: Fix pool deletion e2e

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/ansible: document requirements in requirements.txt
Kefu Chai [Fri, 30 Aug 2019 09:38:54 +0000 (17:38 +0800)]
mgr/ansible: document requirements in requirements.txt

so install-deps.sh is able to collect them in wheels

Signed-off-by: Kefu Chai <kchai@redhat.com>
6 years agomgr/dashboard: access_control: add grafana scope read access t… (#29989)
Volker Theile [Fri, 30 Aug 2019 09:23:35 +0000 (11:23 +0200)]
mgr/dashboard: access_control: add grafana scope read access t… (#29989)

mgr/dashboard: access_control: add grafana scope read access to *-manager roles

Reviewed-by: Lenz Grimmer <LGrimmer@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
6 years agomgr/dashboard: CephFS class issues with strings 29353/head
Volker Theile [Fri, 26 Jul 2019 13:02:57 +0000 (15:02 +0200)]
mgr/dashboard: CephFS class issues with strings

Fixes: https://tracker.ceph.com/issues/40981
Signed-off-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #30022 from Yan-waller/wip-yanj-miscleanup
Xie Xingguo [Fri, 30 Aug 2019 08:12:07 +0000 (16:12 +0800)]
Merge pull request #30022 from Yan-waller/wip-yanj-miscleanup

osd: misc cleanups

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
6 years agoosd: drop useless get_possibly_deleted_pool_pg_num 30022/head
Yan Jun [Fri, 30 Aug 2019 05:55:16 +0000 (13:55 +0800)]
osd: drop useless get_possibly_deleted_pool_pg_num

Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
6 years agoosd: no need to dump empty waiting_for_split
Yan Jun [Fri, 30 Aug 2019 05:41:41 +0000 (13:41 +0800)]
osd: no need to dump empty waiting_for_split

Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
6 years agoMerge pull request #29982 from falcon78921/wip-doc-41516
Kefu Chai [Fri, 30 Aug 2019 04:22:50 +0000 (12:22 +0800)]
Merge pull request #29982 from falcon78921/wip-doc-41516

doc: updated ceph monitor config options

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agodoc: updated ceph monitor config options 29982/head
James McClune [Thu, 29 Aug 2019 02:21:24 +0000 (22:21 -0400)]
doc: updated ceph monitor config options

Executed ceph-conf --dump-all on a freshly installed v14.2.2 (nautilus)
cluster. Compared the global defaults to the keys/values specified in
mon-config-ref.rst. Checked options.cc to make sure the obsolete keys
are no longer used.

Fixes: https://tracker.ceph.com/issues/41516
Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>
6 years agoMerge pull request #29939 from majianpeng/bluestore-print-correctly-info
Neha Ojha [Thu, 29 Aug 2019 14:36:02 +0000 (07:36 -0700)]
Merge pull request #29939 from majianpeng/bluestore-print-correctly-info

os/bluestore: print correctly info.

Reviewed By: Xie Xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
6 years agoMerge pull request #30005 from wjwithagen/wjw-fix-vstart-mkdir
Kefu Chai [Thu, 29 Aug 2019 14:35:22 +0000 (22:35 +0800)]
Merge pull request #30005 from wjwithagen/wjw-fix-vstart-mkdir

vstart.sh: Make sure mkdir succeeds

Reviewed-by: Kefu Chai <kchai@redhat.com>
6 years agomgr/dashboard: Fix pool deletion e2e 29993/head
Volker Theile [Thu, 29 Aug 2019 10:09:40 +0000 (12:09 +0200)]
mgr/dashboard: Fix pool deletion e2e

Signed-off-by: Volker Theile <vtheile@suse.com>
6 years agomgr/dashboard: A block-manager can not access the pool page 30001/head
Volker Theile [Thu, 29 Aug 2019 11:14:33 +0000 (13:14 +0200)]
mgr/dashboard: A block-manager can not access the pool page

Fixes: https://tracker.ceph.com/issues/41573
Signed-off-by: Volker Theile <vtheile@suse.com>
6 years agovstart.sh: Make sure mkdir succeeds 30005/head
Willem Jan Withagen [Thu, 29 Aug 2019 13:20:46 +0000 (15:20 +0200)]
vstart.sh: Make sure mkdir succeeds

Even in the case the full path was not created, make sure mkdir
does create the full path.

And while there replaced some `test ....` with `[ ... ]`
like in the remainder of the file.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
6 years agoscript/ceph-backport.sh: wholesale refactor
Nathan Cutler [Wed, 28 Aug 2019 11:57:43 +0000 (13:57 +0200)]
script/ceph-backport.sh: wholesale refactor

This commit refactors the script to make it more user-friendly and
maintainable. Added features:

* script now determine release/milestone from backport issue instead of
  requiring user to provide it
* script now generates a more verbose PR description
* backport PR title is based on original PR instead of the tracker issue
* improved error handling
* new --debug option that triggers "set -x"
* new --verbose option
* errors and diagnostic messages are now printed to stderr

Signed-off-by: Nathan Cutler <ncutler@suse.com>
6 years agoceph-volume: test number of times LVs list was created 29665/head
Rishabh Dave [Mon, 19 Aug 2019 13:33:21 +0000 (19:03 +0530)]
ceph-volume: test number of times LVs list was created

Add a test that cofirm that the LVs list was created only once when
calling devices.lvm.listing.list()

Signed-off-by: Rishabh Dave <ridave@redhat.com>
6 years agoMerge pull request #29917 from tchaikov/wip-mon-always-on-modules
Kefu Chai [Thu, 29 Aug 2019 09:31:54 +0000 (17:31 +0800)]
Merge pull request #29917 from tchaikov/wip-mon-always-on-modules

mgr/MgrMonitor: print pending.always_on_modules before updating it

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
6 years agoMerge pull request #29857 from dzafman/wip-41255
Kefu Chai [Thu, 29 Aug 2019 09:30:58 +0000 (17:30 +0800)]
Merge pull request #29857 from dzafman/wip-41255

backfill_toofull seen on cluster where the most full OSD is at 1%

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Neha Ojha <nojha@redhat.com>
6 years agoMerge pull request #29604 from votdev/python_cleanup
Kefu Chai [Thu, 29 Aug 2019 09:29:40 +0000 (17:29 +0800)]
Merge pull request #29604 from votdev/python_cleanup

mgr/dashboard: Cleanup Python code

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
6 years agomgr/dashboard: access_control: add grafana scope read access to *-manager roles 29989/head
Ricardo Dias [Thu, 29 Aug 2019 09:26:48 +0000 (10:26 +0100)]
mgr/dashboard: access_control: add grafana scope read access to *-manager roles

Fixes: https://tracker.ceph.com/issues/41572
Signed-off-by: Ricardo Dias <rdias@suse.com>
6 years agomgr/dashboard: Extract E2E wait calls into PageHelper (#29789)
Volker Theile [Thu, 29 Aug 2019 09:02:42 +0000 (11:02 +0200)]
mgr/dashboard: Extract E2E wait calls into PageHelper (#29789)

mgr/dashboard: Extract E2E wait calls into PageHelper

Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
6 years agoMerge pull request #29881 from tchaikov/wip-test-bufferlist
Kefu Chai [Thu, 29 Aug 2019 01:24:56 +0000 (09:24 +0800)]
Merge pull request #29881 from tchaikov/wip-test-bufferlist

test/bufferlist.cc: encode/decode int64_t instead of long

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
6 years agoMerge pull request #29916 from badone/wip-tracker-41518-grafana-server
Brad Hubbard [Wed, 28 Aug 2019 23:52:33 +0000 (09:52 +1000)]
Merge pull request #29916 from badone/wip-tracker-41518-grafana-server

qa/ceph-ansible: Disable dashboard

Reviewed-by: Nathan Cutler <ncutler@suse.com>
6 years agomgr/dashboard: Extract E2E wait calls into PageHelper 29789/head
Tiago Melo [Tue, 20 Aug 2019 16:45:23 +0000 (16:45 +0000)]
mgr/dashboard: Extract E2E wait calls into PageHelper

Signed-off-by: Tiago Melo <tmelo@suse.com>
6 years agoMerge PR #20160 into master
Patrick Donnelly [Wed, 28 Aug 2019 22:02:35 +0000 (15:02 -0700)]
Merge PR #20160 into master

* refs/pull/20160/head:
cephfs: Make mds-mds per message versioned

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoMerge PR #29911 into master
Patrick Donnelly [Wed, 28 Aug 2019 20:44:33 +0000 (13:44 -0700)]
Merge PR #29911 into master

* refs/pull/29911/head:
qa: ignore RECENT_CRASH for multimds snapshot testing

Tested-by: Patrick Donnelly <pdonnell@redhat.com>
6 years agoMerge pull request #29966 from idryomov/wip-krbd-zero-after-overlap
Ilya Dryomov [Wed, 28 Aug 2019 18:34:04 +0000 (20:34 +0200)]
Merge pull request #29966 from idryomov/wip-krbd-zero-after-overlap

qa: krbd_parent_overlap.t: fix read test

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
6 years agoMerge pull request #29967 from theanalyst/rgw/beast-endpoint-fix
Abhishek L [Wed, 28 Aug 2019 15:33:24 +0000 (17:33 +0200)]
Merge pull request #29967 from theanalyst/rgw/beast-endpoint-fix

rgw: asio: check the remote endpoint before processing requests

Reviewed-By: Casey Bodley <cbodley@redhat.com>
6 years agobluestore/bdev: initialize size when creating object. 29968/head
Willem Jan Withagen [Wed, 28 Aug 2019 15:19:22 +0000 (17:19 +0200)]
bluestore/bdev: initialize size when creating object.

The other partss of the struct are initialized by their
ctors. Only for unint_64 there is no ctor.

Otherwise ceph-dencoder tests will fail in comparing
the exported output.
[~/master36] wjw@cephdev.digiware.nl> build/bin/ceph-dencoder type bluestore_bdev_label_t select_test 1 encode export /tmp/typ-yFISvjvgj
[~/master36] wjw@cephdev.digiware.nl> hexdump -C !$
hexdump -C /tmp/typ-yFISvjvgj
00000000  62 6c 75 65 73 74 6f 72  65 20 62 6c 6f 63 6b 20 |bluestore block |
00000010  64 65 76 69 63 65 0a 30  30 30 30 30 30 30 30 2d |device.00000000-|
00000020  30 30 30 30 2d 30 30 30  30 2d 30 30 30 30 2d 30 |0000-0000-0000-0|
00000030  30 30 30 30 30 30 30 30  30 30 30 0a 02 01 28 00 |00000000000...(.|
00000040  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
00000050  00 00 70 74 03 04 00 00  00 00 00 00 00 00 00 00 |..pt............|
00000060  00 00 00 00 00 00 00 00  00 00 |..........|
0000006a

[~/master36] wjw@cephdev.digiware.nl> build/bin/ceph-dencoder type bluestore_bdev_label_t select_test 1 encode decode encode export /tmp/typ-MjWXdCpzJ
[~/master36] wjw@cephdev.digiware.nl> hexdump -C !$
hexdump -C /tmp/typ-MjWXdCpzJ
00000000  62 6c 75 65 73 74 6f 72  65 20 62 6c 6f 63 6b 20 |bluestore block |
00000010  64 65 76 69 63 65 0a 30  30 30 30 30 30 30 30 2d |device.00000000-|
00000020  30 30 30 30 2d 30 30 30  30 2d 30 30 30 30 2d 30 |0000-0000-0000-0|
00000030  30 30 30 30 30 30 30 30  30 30 30 0a 02 01 28 00 |00000000000...(.|
00000040  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00 |................|
00000050  00 00 73 64 00 00 00 00  00 00 00 00 00 00 00 00 |..sd............|
00000060  00 00 00 00 00 00 00 00  00 00 |..........|
0000006a

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
6 years agoqa: krbd_parent_overlap.t: fix read test 29966/head
Ilya Dryomov [Wed, 28 Aug 2019 15:07:07 +0000 (17:07 +0200)]
qa: krbd_parent_overlap.t: fix read test

It turns out this test has not been triggering the right code path for
a while now (krbd_parent_overlap.t was added just over a year ago, but
the original test goes back a few years).

To do its job it needs an empty clone with the overlap set to somewhere
in the middle of an object.  The test relied on shrinking for this, but
shrinking no longer fits the bill because a copyup is now performed for
the object with the overlap -- we never go to the parent after that.

Let's size the parent so that it ends in the middle of an object and
then grow an empty clone instead.  Also, while reading from page cache
does seem to trigger a read that straddles the overlap, it's not very
reliable, so supplement it with a direct read.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
6 years agoMerge pull request #29948 from smithfarm/wip-ceph-backport-sh-doc
Nathan Cutler [Wed, 28 Aug 2019 14:34:11 +0000 (16:34 +0200)]
Merge pull request #29948 from smithfarm/wip-ceph-backport-sh-doc

doc: script/ceph-backport.sh: add "Troubleshooting notes"

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
6 years agoMerge pull request #29950 from smithfarm/wip-bri-deep-scan-of-pr-desc
Nathan Cutler [Wed, 28 Aug 2019 14:33:37 +0000 (16:33 +0200)]
Merge pull request #29950 from smithfarm/wip-bri-deep-scan-of-pr-desc

script/backport-resolve-issue: handle tracker URLs better

Reviewed-by: Casey Bodley <cbodley@redhat.com>
6 years agorgw: asio: check the remote endpoint before processing requests 29967/head
Abhishek Lekshmanan [Wed, 7 Aug 2019 15:09:32 +0000 (17:09 +0200)]
rgw: asio: check the remote endpoint before processing requests

`socket.remote_endpoint()` can throw exceptions corresponding to errors in the
`getpeername` syscall, make sure these are handled.

Fixes: CVE-2019-10222, https://tracker.ceph.com/issues/40018
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
6 years agoMerge pull request #29815 from smanjara/wip-fix-bucket-link
Casey Bodley [Wed, 28 Aug 2019 12:10:11 +0000 (08:10 -0400)]
Merge pull request #29815 from smanjara/wip-fix-bucket-link

rgw: fix missing tenant prefix in bucket name during bucket link

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
6 years agoscript/backport-resolve-issue: handle tracker URLs better 29950/head
Nathan Cutler [Wed, 28 Aug 2019 09:21:17 +0000 (11:21 +0200)]
script/backport-resolve-issue: handle tracker URLs better

Before this commit, backport-resolve-issue would blindly grab the first tracker
URL it saw in the GitHub PR description. With this commit, it examines all the
tracker URLs it sees in the PR description and uses the first one that
corresponds to an issue in the Redmine Backport tracker.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
6 years agomgr/dashboard: migrate e2e tests to async await (#29758)
Volker Theile [Wed, 28 Aug 2019 10:26:17 +0000 (12:26 +0200)]
mgr/dashboard: migrate e2e tests to async await (#29758)

mgr/dashboard: migrate e2e tests to async await

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
6 years agoMerge pull request #29942 from tchaikov/wip-bump-seastar
Kefu Chai [Wed, 28 Aug 2019 09:18:16 +0000 (17:18 +0800)]
Merge pull request #29942 from tchaikov/wip-bump-seastar

seastar: pick up latest changes and cleanups

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
6 years agodoc: script/ceph-backport.sh: add "Troubleshooting notes" 29948/head
Nathan Cutler [Wed, 28 Aug 2019 08:42:17 +0000 (10:42 +0200)]
doc: script/ceph-backport.sh: add "Troubleshooting notes"

Signed-off-by: Nathan Cutler <ncutler@suse.com>
6 years agomgr/dashboard: fix protractor.conf.js 29758/head
Patrick Seidensal [Tue, 27 Aug 2019 14:07:48 +0000 (16:07 +0200)]
mgr/dashboard: fix protractor.conf.js

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: set sensible `implicitWaitTimeout`
Patrick Seidensal [Tue, 27 Aug 2019 13:57:49 +0000 (15:57 +0200)]
mgr/dashboard: set sensible `implicitWaitTimeout`

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: fix issue in dashbboard test
Patrick Seidensal [Tue, 27 Aug 2019 13:29:15 +0000 (15:29 +0200)]
mgr/dashboard: fix issue in dashbboard test

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: prepend await before expect statements are used
Patrick Seidensal [Tue, 27 Aug 2019 12:53:41 +0000 (14:53 +0200)]
mgr/dashboard: prepend await before expect statements are used

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: fix issue E2E image with unclickable element
Patrick Seidensal [Tue, 27 Aug 2019 10:39:48 +0000 (12:39 +0200)]
mgr/dashboard: fix issue E2E image with unclickable element

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: refactoring E2E mirroring test
Patrick Seidensal [Mon, 26 Aug 2019 15:14:34 +0000 (17:14 +0200)]
mgr/dashboard: refactoring E2E mirroring test

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: refatoring E2E page helper test
Patrick Seidensal [Fri, 23 Aug 2019 23:54:54 +0000 (01:54 +0200)]
mgr/dashboard: refatoring E2E page helper test

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: refactoring E2E iscsi test
Patrick Seidensal [Fri, 23 Aug 2019 23:38:56 +0000 (01:38 +0200)]
mgr/dashboard: refactoring E2E iscsi test

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: refactoring Helper class to remove PageHelper instances
Patrick Seidensal [Fri, 23 Aug 2019 23:25:45 +0000 (01:25 +0200)]
mgr/dashboard: refactoring Helper class to remove PageHelper instances

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: refactoring E2E dashboard test
Patrick Seidensal [Fri, 23 Aug 2019 15:58:12 +0000 (17:58 +0200)]
mgr/dashboard: refactoring E2E dashboard test

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: reformat of `protractor.conf.js`
Patrick Seidensal [Wed, 21 Aug 2019 15:27:01 +0000 (17:27 +0200)]
mgr/dashboard: reformat of `protractor.conf.js`

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: refactoring of references of classes to point to classes directly
Patrick Seidensal [Wed, 21 Aug 2019 15:13:20 +0000 (17:13 +0200)]
mgr/dashboard: refactoring of references of classes to point to classes directly

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: fix UnhandledPromiseRejectionWarning in RGW users
Patrick Seidensal [Wed, 21 Aug 2019 11:24:45 +0000 (13:24 +0200)]
mgr/dashboard: fix UnhandledPromiseRejectionWarning in RGW users

Fixes: https://tracker.ceph.com/issues/40693
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: migrate E2E dashboards to async/await
Patrick Seidensal [Wed, 21 Aug 2019 07:18:06 +0000 (09:18 +0200)]
mgr/dashboard: migrate E2E dashboards to async/await

Fixes: https://tracker.ceph.com/issues/40693
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: improve overall E2E stability of navigation
Patrick Seidensal [Wed, 21 Aug 2019 07:16:02 +0000 (09:16 +0200)]
mgr/dashboard: improve overall E2E stability of navigation

The `navigateTo` method will check if a table exists on the table it has
been used to navigate to and if so, wait for the data of the table to
be loaded.

Fixes: https://tracker.ceph.com/issues/41349
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: migrate E2E user management tests
Patrick Seidensal [Mon, 26 Aug 2019 15:39:30 +0000 (17:39 +0200)]
mgr/dashboard: migrate E2E user management tests

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: migrate E2E images to async/await
Patrick Seidensal [Mon, 19 Aug 2019 12:07:27 +0000 (14:07 +0200)]
mgr/dashboard: migrate E2E images to async/await

Fixes: https://tracker.ceph.com/issues/40693
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 years agomgr/dashboard: migrate E2E iscsi to async/await
Patrick Seidensal [Mon, 19 Aug 2019 12:06:32 +0000 (14:06 +0200)]
mgr/dashboard: migrate E2E iscsi to async/await

Fixes: https://tracker.ceph.com/issues/40693
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>