test/pybind/test_ceph_argparse.py: pg_num of pool creation now optional

introduced by f88d95bef6948410603bd877aa4714a2afefd5a5

note that we remove the bad pg_num = -1 test too, which will now
be treated as the the crush rule name (invalid but allowed) since
pg_num is optional

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge PR #30348 into master

* refs/pull/30348/head:
doc: Add a new document on Dynamic Metadata Management in CephFS

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #30512 from xiexingguo/wip-vstart-inc-osd

vstart: add --inc-osd option

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #30490 from ceph/guits-41392

ceph-volume: do not fail when trying to remove crypt mapper

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Alfredo Deza <adeza@redhat.com>

Merge pull request #30507 from tchaikov/wip-mgr-features-in-mgrmap

qa/tasks/mgr/dashboard/test_health: update schema

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>

doc: Add a new document on Dynamic Metadata Management in CephFS

Signed-off-by: Sidharth Anupkrishnan <sanupkri@redhat.com>

Merge PR #30475 into master

* refs/pull/30475/head:
qa/standalone/ceph-helpers: default pg autoscale mode off for standalone
os/bluestore: fix objectstore_blackhole read-after-write
test,misc: do not specify pg_num per pool
mgr/volumes: do not specify pg_num
pybind/ceph_volume_client: do not specify pg_num for new pools
doc: remove all pg_num arguments to 'osd pool create'
mon: do not require pg_num to 'osd pool create'
common: default pg_autoscale_mode=on for new pools

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge PR #30503 into master

* refs/pull/30503/head:
osd/PeeringState: recover_got - add special handler for empty log

Reviewed-by: Sage Weil <sage@redhat.com>

Merge PR #30506 into master

* refs/pull/30506/head:
qa/standalone/osd/divergent-priors: add reproducer for bug 41816

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

mgr/dashboard: Fix spacing between cards (#30461)

mgr/dashboard: Fix spacing between cards

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: fix error when linking a bucket to a tenanted u… (#30123)

mgr/dashboard: fix error when linking a bucket to a tenanted user

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: OSD list component improvements (#30488)

mgr/dashboard: OSD list component improvements

Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: NFS list should display the "Pseudo Path" (#30395)

mgr/dashboard: NFS list should display the "Pseudo Path"

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

ceph-volume: do not fail when trying to remove crypt mapper

In a containerized context, at some point, need to run `simple scan` on a device
from a separate container (not the existing and running corresponding container
to that device), but this can't work because when it tries to remove the
mapper which is still in use by the corresponding running osd container,
it fails.
This can be a bit more permissive and simply throw a warning.

Closes: https://tracker.ceph.com/issues/41392
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #30411 from dillaman/wip-41653

rbd-mirror: simplify peer bootstrapping

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge PR #30428 into master

* refs/pull/30428/head:
doc/dev/developer_guide: fix heading level

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #30435 into master

* refs/pull/30435/head:
doc: improve developer guide doc

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #30497 into master

* refs/pull/30497/head:
ceph-volume: systemd fix typo in log message

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

vstart: add --inc-osd option

I am currently developing some scale-up[down] related feature.
It would be nice if I can simply develop and test it on the
vcluster at the early stage.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

qa/standalone/ceph-helpers: default pg autoscale mode off for standalone

Signed-off-by: Sage Weil <sage@redhat.com>

os/bluestore: fix objectstore_blackhole read-after-write

Instead of tossing out transactions from queue_transactions (which prevents
us from reading back the results), instead (1) stop doing any write IO, and
(2) stop trimming the cache.

Fixes: https://tracker.ceph.com/issues/40684
Signed-off-by: Sage Weil <sage@redhat.com>

test,misc: do not specify pg_num per pool

Signed-off-by: Sage Weil <sage@redhat.com>

mgr/volumes: do not specify pg_num

Signed-off-by: Sage Weil <sage@redhat.com>

pybind/ceph_volume_client: do not specify pg_num for new pools

Signed-off-by: Sage Weil <sage@redhat.com>

doc: remove all pg_num arguments to 'osd pool create'

Also, update the dicussion about pg_num and pool creation, with a reference
to the autoscaler.

Signed-off-by: Sage Weil <sage@redhat.com>

mon: do not require pg_num to 'osd pool create'

Signed-off-by: Sage Weil <sage@redhat.com>

common: default pg_autoscale_mode=on for new pools

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #30457 from dillaman/wip-41908

osd/PrimaryLogPG: do not append outdata to TMAPUP ops

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

qa/tasks/mgr/dashboard/test_health: update schema

see 351a3b9d3867ab8dd6d0502fbc46c0016553c6d5

Fixes: https://tracker.ceph.com/issues/41947
Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/MgrMap: dump mgr_features as an object property

it's a property of "standby" object, not an element of
"available_modules".

it's a follow-up fix of 351a3b9d

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #30427 into master

* refs/pull/30427/head:
doc/cephfs: correct a description mistake about mds states

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #30432 from yanghonggang/wip-yhg-balancer-eval-maxmin

pybind/mgr/balancer/module.py: add max/min info in stats_by_root

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #30479 from liewegas/wip-fix-osd-invalid-stats

osd/osd_types: fix {omap,hitset_bytes}_stats_invalid handling on split/merge

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #29800 from Devp00l/wip-41372

mgr/dashboard: CephFS tab component

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #30412 from tchaikov/wip-crimson-osd-make-message

osd,crimson: use make_message for creating message

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #30408 from p-se/wip-pna-smartctl-report

osd: add common smartctl output to JSON output

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30414 from neha-ojha/wip-fix-missing

osd/PeeringState.h: get_num_missing() should report num_missing()

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30448 from tchaikov/wip-40871

mgr: set hostname in DeviceState::set_metadata()

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #30449 from tchaikov/wip-37884

mon,mgr: pass MessageRef to monc.send_mon_message()  …

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #30413 from vumrao/wip-vumrao-41875

tools/rados: call pool_lookup() after rados is connected.

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30409 from uweigand/cleanup-endian

src/: Clean up endian handling

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30383 from vumrao/wip-vumrao-tools-rados-add-pgid-in-help

tools/rados: add --pgid in help

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30211 from majianpeng/msg-clear-payload

msg/async: clear_payload when requeue_sent.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>

Merge pull request #30445 from tchaikov/wip-41320

mgr/dashboard: do not log tokens

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #29947 from iotcg/nosrq

support RDMA NIC without SRQ in msg/async/rdma

Reviewed-by: Roman Penyaev <rpenyaev@suse.de>
Reviewed-by: Kefu Chai <kchai@redhat.com>

qa/standalone/osd/divergent-priors: add reproducer for bug 41816

Reproducer for https://tracker.ceph.com/issues/41816

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #30502 from idryomov/wip-krbd-avoid-hexdump-s

qa: avoid hexdump skip and length options

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #30489 from liuchang0812/kill-compile-warning

rgw: kill compile warnning in rgw_object_lock.h

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

osd/PeeringState: recover_got - add special handler for empty log

If we use a small osd_min[max]_pg_log_entries setting, say, 10, and
do splitting, a child pg may only be able to keep some divergent log
entries in the list. Any follow-up peering cycle on that child pg
would then rewind all the divergent log entries and lead to an empty
log list, which as a result could reliably fire the

  ceph_assert(info.last_complete == info.last_update)

assert if we start to recover any of the missing divergent objects
later.

Fixes: https://tracker.ceph.com/issues/41816
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

qa: avoid hexdump skip and length options

On Debian-based distros, hexdump(1) comes from FreeBSD in bsdmainutils
package (other distros ship a Linux version from util-linux).  It turns
out that '-s skip' for anything but a regular file has been broken for
ages in FreeBSD -- instead of calling fseek(), it consumed the input
byte by byte with getchar().  This was fixed in commit 7cd5ae492557
"hexdump(1): Speed up -s flag on devices" last year, but it hasn't made
it to the Debian world yet.

bsdmainutils_9.0.6ubuntu3 in xenial had a custom patch for that, but
it's no longer there in bsdmainutils_11.1.2ubuntu1 in bionic.  hexdump
-s <large offset> is now a fancy infinite loop!

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

ceph-volume: systemd fix typo in log message

Fixes: https://tracker.ceph.com/issues/41942
Signed-off-by: Manu Zurmühl <m.zurmuehl@heinlein-support.de>

rgw: kill compile warnning in rgw_object_lock.h

Signed-off-by: Chang Liu <liuchang0812@gmail.com>

qa/suites/rbd: test case for rbd-mirror bootstrap

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #30484 from trociny/wip-handle_start_replay_interrupted

rbd-mirror: potential nullptr dereference in ImageReplayer::handle_start_replay

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

mgr/dashboard: Fix validation of OSDs

There were situations where the OSD was removed and then we tried to access some
property of the OSD object, causing a frontend error.

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Fix error when removing osds

After purging or destroying OSDs the details component would stay open and try
to fetch data related to a non existent OSDs.
This would result in error notifications and frontend exceptions.

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Improve processing of multiple OSD requests

We were not using forkJoin when calling scrub endpoint.

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr: pass MessageRef to monc.send_mon_message()

less chance to leak memory

see also: https://tracker.ceph.com/issues/37884

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/MonClient: include necessary #includes

ideally, a header file should be self-contained.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/MonClient: add send_mon_message(MessageRef)

Signed-off-by: Kefu Chai <kchai@redhat.com>

messages/MLog: pass rvalue ref instead const ref to ctor

easier to use this way. and so far, there is no caller of this function
yet.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard Adds multiple selection in osd table (#29662)

mgr/dashboard Adds multiple selection in osd table

Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #30438 from dillaman/wip-41833

cls/rbd: sanitize entity instance messenger version type

Reviewed-by: Mykola Golub <mgolub@suse.com>

rbd-mirror: potential nullptr dereference in ImageReplayer::handle_start_replay

Signed-off-by: Mykola Golub <mgolub@suse.com>

Merge pull request #30474 from tchaikov/wip-discard-future

crimson: run in foreground if possible, silence warnings

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #28971 from yuvalif/wip-yuval-pubsub-api2

rgw/pubsub: add S3 compliant API to master zone

Merge pull request #30101 from rishabh-d-dave/cv-minor

ceph-volume: api/lvm: check if list of LVs is empty

Reviewed-by: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #19020 from zhangsw/feature-rgw-bucketsync-api

rgw: add admin rest api for bucket sync

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #29637 from liuchang0812/rgw-es7

rgw: sync with elastic search v7

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #29897 from tianshan/fix_list_start_with_null_marker

rgw: fix list versions starts with version_id=null

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #29909 from cbodley/wip-40935

rgw: fix default storage class for get_compression_type

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #30127 from zhangsw/rgw-fix-adminuser

rgw: add missing admin property when sync user info.

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #30163 from zhangsw/feature-rgw-opslog-transid

rgw: add transaction id to ops log.

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #30175 from tianshan/improve-data-sync-retry

rgw: improve data sync restart after failure

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #30189 from linuxbox2/wip-rgw-ss3lite

rgw: crypt: permit RGW-AUTO/default with SSE-S3 headers

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #30194 from vumrao/wip-vumrao-41589

radosgw-admin: add --uid check in bucket list command

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #30332 from linuxbox2/wip-ldap-denied

rgw: ldap auth: S3 auth failure should return InvalidAccessKeyId

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #30384 from ZVampirEM77/bucket-create-time

rgw: add creation time information into bucket stats

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #29680 from liuchang0812/s3-lock-bugfix

rgw: DefaultRetention requires either Days or Years

Reviewed-By: Casey Bodley <cbodley@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>

osd/osd_types: fix {omap,hitset_bytes}_stats_invalid handling on split/merge

Fixes: https://tracker.ceph.com/issues/41936
Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #30451 from ajarr/fix-41903

mgr/volumes: return string type to ceph-manager

mgr/dashboard: Add smartctl data as an details tab of an OSD (#30324)

mgr/dashboard: Add smartctl data as an details tab of an OSD

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

crimson/osd: suppress warnings about unused future<> return values

These are dropped on purpose, suppress warnings.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/osd: ShardServices::send_pg_temp() returns future

it should not run in background unless necessary.

please note, we don't have a caller of this method yet.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: evict object state in foreground

when doing error handling, we need to make sure the stale object state
is evicted before we return.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: add_peer() in parallel

we should not add peers in background, and we can do this in parallel!

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: Heartbeat::add_reporter_peers() returns future

the sole caller `Heartbeat::update_peers()` also returns future, so
there is no reason that `add_reporter_peers()` runs in background.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: fix the order in OSD::update_heartbeat_peers()

before this chance, we do following things in background and in
parallel:

* add peers from pg map
* and peers from whole osdmap
* remove dead peers

but we should prioritize the peer candidates, apparently, the ones from
pgmap should have higher priority. as they are more likely to be used in
cluser and they are more important to current OSD, as they serve the
same set of PGs.

so we need to do these things in a proper order:

1. add peers from pg map
2. and peers from whole osdmap
3. remove dead peers

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd/heartbeat: avoid racing when connecting to peer

before this change, we could initialize connections to newly added peers
in parallel repeatly, if an OSD is listed in up/acting of multiple PGs
served by current OSD.

after this change, we try to add the peer to `Heartbeat.peers` first,
and then try to connect to it with the hb front/back addresses, to avoid
potential repeatly connecting to peer.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30270 from ricardoasmarques/wip-41727

mgr/dashboard: Check if `num_sessions` is available

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/volumes: return string type to ceph-manager

The 'volumes' ceph-mgr module returns a byte type instead of a string
type as the stdout result of commands, `fs subvolume getpath` and
`fs subvolumegroup getpath` to the ceph-mgr. This causes the commands
to hang and the ceph-mgr to utilize 100% CPU. Fix the 'volumes'
ceph-mgr module to return string type to ceph-mgr as the stdout
result of the commands.

Introduced-by: 3d63cd947f55a8508f972ee249ea6a04836429ae
Fixes: https://tracker.ceph.com/issues/41903
Signed-off-by: Venky Shankar <vshankar@redhat.com>

crimson/osd: do not cluster_msgr.set_myaddrs() in background

we should do the initialization in foreground

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/net: avoid warning about signed comparison with enum classes

Signed-off-by: Samuel Just <sjust@redhat.com>

mgr/dashboard: fix error when linking a bucket to a tenanted user

- Prefix bucket name with '/' when linking bucket to a tenanted user
- Add qa tests

Fixes: https://tracker.ceph.com/issues/41611
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

pybind/mgr/balancer/module.py: add max/min info in stats_by_root

$ ceph balancer eval-verbose hahapool
...
count_by_pool {'hahapool': {'objects': {0: 1L, 1: 1L, 2: 0L, 3: 0L, 4: 1L}, 'bytes': {0: 0L, 1: 0L, 2: 0L, 3: 0L, 4: 0L}, 'pgs': {0: 35, 1: 42, 2: 23, 3: 30, 4: 26}}}
...
stats_by_root {'default': {'objects': {'min': 0.0, 'max': 1.0, 'score': 0.2970089549436925, 'stddev': 0.5477225575051662, 'avg': 0.6, 'sum_weight': 0.6000000000000001}, 'bytes': {'min': 0, 'max': 0, 'score': 0, 'stddev': 0, 'avg': 0, 'sum_weight': 0}, 'pgs': {'min': 23.0, 'max': 42.0, 'score': 0.07354228523075643, 'stddev': 7.52994023880668, 'avg': 31.2, 'sum_weight': 0.4}}}

max/min can give us an intuitive feel of the pg/bytes/object's distribution.
In addition, sometimes we really want to know which osd hold the most
number of pgs/bytes/objects for specified pool.

Signed-off-by: Yang Honggang <yanghonggang@umcloud.com>

Merge pull request #30410 from tchaikov/wip-debian-g++

debian/control: Build-Depends on g++

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Seidensal <pnawracay@suse.com>

Merge pull request #30405 from p-se/wip-pna-ubuntu-disco-deps

install-deps.sh: add support for Ubuntu Disco Dingo

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #30453 from tchaikov/wip-doc-crimson

doc/dev/crimson: transpose options of compare.py

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

doc/rbd: document new rbd mirror bootstrap commands

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

doc/rbd: clarify cluster naming by using site-a/b

The local vs remote cluster naming has been confusing for multiple
users.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>