]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 years agomgr/dashboard: show alert panel if prometheus/alertmanager is unconfigured 31937/head
Patrick Seidensal [Tue, 3 Dec 2019 19:46:17 +0000 (20:46 +0100)]
mgr/dashboard: show alert panel if prometheus/alertmanager is unconfigured

If the tabs under the "Monitoring" page aren't properly configured, a
notification is shown which explains the user which setting needs to be
enabled and also provides a link to the corresponding documentation.

Fixes: https://tracker.ceph.com/issues/42877
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 years agomgr/dashboard: extend dashboard documentation
Patrick Seidensal [Mon, 2 Dec 2019 13:30:30 +0000 (14:30 +0100)]
mgr/dashboard: extend dashboard documentation

by adding the previously added monitoring related features as well as
the newest feature addition. Extends the documentation where necessary
to describe the Prometheus' alert configuration.

Fixes: https://tracker.ceph.com/issues/42877
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 years agomgr/dashboard: move monitoring tabs to a single page
Patrick Seidensal [Wed, 27 Nov 2019 20:34:12 +0000 (20:34 +0000)]
mgr/dashboard: move monitoring tabs to a single page

with a tab for 'active alerts', 'all alerts' and 'silences'. Due to
ambiguity with existing names, `AlertListComponent` has been renamed to
`ActiveAlertListComponent`. Introduces `MonitoringListComponent` as
first page for monitoring concerns, using path `/monitoring`.

Keeps the activated tab open, independent of the way that's used to go
back to the previous page, be it the cancel button or submit button or
the link on the breadcrumb. Also keeps the active tab open even when the
page is reloaded.

Fixes: https://tracker.ceph.com/issues/42877
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 years agomgr/dashboard: refactor test of Prometheus alert service
Patrick Seidensal [Wed, 27 Nov 2019 08:14:13 +0000 (09:14 +0100)]
mgr/dashboard: refactor test of Prometheus alert service

Mocking the test the way it was removed the asynchronous nature of the
test. By using an Observable the test can stay asynchronous and be
tested as well.

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 years agomgr/dashboard: list configured Prometheus alerts
Patrick Seidensal [Mon, 25 Nov 2019 12:37:50 +0000 (13:37 +0100)]
mgr/dashboard: list configured Prometheus alerts

Fixes: https://tracker.ceph.com/issues/42877
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 years agomgr/dashboard: return Prometheus alert groups, too
Patrick Seidensal [Tue, 19 Nov 2019 15:45:52 +0000 (16:45 +0100)]
mgr/dashboard: return Prometheus alert groups, too

Fixes: https://tracker.ceph.com/issues/42877
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 years agoMerge pull request #31473 from ifed01/wip-ifed-smplify-fsck
Kefu Chai [Tue, 3 Dec 2019 14:32:25 +0000 (22:32 +0800)]
Merge pull request #31473 from ifed01/wip-ifed-smplify-fsck

os/bluestore: simplify multithreaded shallow fsck.

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #31969 from sebastian-philipp/mgr-fix-mocking
Sebastian Wagner [Tue, 3 Dec 2019 14:26:23 +0000 (15:26 +0100)]
Merge pull request #31969 from sebastian-philipp/mgr-fix-mocking

pybind/mgr: Make it easier to create a Module instance without the mgr

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
5 years agomgr/dashboard,grafana: remove shortcut menu (#31951)
Lenz Grimmer [Tue, 3 Dec 2019 13:56:00 +0000 (13:56 +0000)]
mgr/dashboard,grafana: remove shortcut menu (#31951)

mgr/dashboard,grafana: remove shortcut menu

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
5 years agoMerge pull request #31960 from tchaikov/wip-cmake-new-policy
Kefu Chai [Tue, 3 Dec 2019 12:04:28 +0000 (20:04 +0800)]
Merge pull request #31960 from tchaikov/wip-cmake-new-policy

cmake: do not use CMP0093 unless it is supported

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
5 years agocmake: do not use CMP0093 unless it is supported 31944/head 31960/head
Kefu Chai [Tue, 3 Dec 2019 03:50:40 +0000 (11:50 +0800)]
cmake: do not use CMP0093 unless it is supported

CMake CMP0093 was introduced by CMake 3.15, but we only require CMake
v3.10.2. so use the old `Boost_VERSION_MACRO` variable by default,
unless specified otherwise.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agopybind/mgr: Make it easier to create a Module instance without the mgr 31969/head
Sebastian Wagner [Tue, 3 Dec 2019 11:49:07 +0000 (12:49 +0100)]
pybind/mgr: Make it easier to create a Module instance without the mgr

Caused by conflict between #30961 and #30262

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #31872 from smithfarm/wip-mimic-v13.2.7-doc2
Nathan Cutler [Tue, 3 Dec 2019 11:21:11 +0000 (12:21 +0100)]
Merge pull request #31872 from smithfarm/wip-mimic-v13.2.7-doc2

doc/releases: add mimic v13.2.7 to releases timeline

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
5 years agomgr/dashboard: Increase max-width of popovers (#31743)
Lenz Grimmer [Tue, 3 Dec 2019 09:32:21 +0000 (09:32 +0000)]
mgr/dashboard: Increase max-width of popovers (#31743)

mgr/dashboard: Increase max-width of popovers

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agoMerge pull request #30961 from rjfd/wip-mgr-module-logging
Laura Paduano [Tue, 3 Dec 2019 09:29:42 +0000 (10:29 +0100)]
Merge pull request #30961 from rjfd/wip-mgr-module-logging

mgr: module logging infrastructure

Reviewed-by: Ernesto Puertat <epuertat@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
5 years agomgr/dashboard,grafana: remove shortcut menu 31951/head
Ernesto Puerta [Mon, 2 Dec 2019 20:28:35 +0000 (21:28 +0100)]
mgr/dashboard,grafana: remove shortcut menu

Remove shortcut menu (links) and add check in grafana CI script.

Fixes: https://tracker.ceph.com/issues/43091
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
5 years agoMerge pull request #31962 from bk201/wip-43095
Kefu Chai [Tue, 3 Dec 2019 07:12:02 +0000 (15:12 +0800)]
Merge pull request #31962 from bk201/wip-43095

vstart: fix error when getting CMake variables with the same prefix

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agovstart: fix error when getting CMake variables with the same prefix 31962/head
Kiefer Chang [Tue, 3 Dec 2019 06:03:21 +0000 (14:03 +0800)]
vstart: fix error when getting CMake variables with the same prefix

The function fails to work when there are multiple variables starts with
the same prefix. e.g.

- WITH_RBD
- WITH_RBD_RGW

Fixes: https://tracker.ceph.com/issues/43095
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
5 years agoMerge pull request #31947 from zdover23/wip-doc-ubuntu-1804-python-minimal
Kefu Chai [Tue, 3 Dec 2019 04:07:42 +0000 (12:07 +0800)]
Merge pull request #31947 from zdover23/wip-doc-ubuntu-1804-python-minimal

doc: add Python 2 to Ubuntu 18.04 installations

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #31958 from tchaikov/wip-cmake-new-policy
Kefu Chai [Tue, 3 Dec 2019 02:48:39 +0000 (10:48 +0800)]
Merge pull request #31958 from tchaikov/wip-cmake-new-policy

cmake: do not use CMP0074 unless it is supported

Reviewed-by: Samuel Just <sjust@redhat.com>
5 years agocmake: do not use CMP0074 unless it is supported 31958/head
Kefu Chai [Tue, 3 Dec 2019 01:50:10 +0000 (09:50 +0800)]
cmake: do not use CMP0074 unless it is supported

CMake CMP0074 was introduced by CMake 3.12, but we only require CMake
v3.10.2. so default to check `Boost_ROOT` unless specified otherwise.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #31913 into master
Sage Weil [Mon, 2 Dec 2019 22:26:33 +0000 (16:26 -0600)]
Merge PR #31913 into master

* refs/pull/31913/head:
ceph-daemon: Allow env var for setting the used image

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #31919 from idryomov/wip-krbd-udev-improvements
Ilya Dryomov [Mon, 2 Dec 2019 20:27:31 +0000 (21:27 +0100)]
Merge pull request #31919 from idryomov/wip-krbd-udev-improvements

krbd: do away with explicit memory management and other cleanups

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge PR #31933 into master
Sage Weil [Mon, 2 Dec 2019 19:58:28 +0000 (13:58 -0600)]
Merge PR #31933 into master

* refs/pull/31933/head:
mgr/ssh: `test_mon_update` needs to set a mon name

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #31274 into master
Sage Weil [Mon, 2 Dec 2019 18:56:05 +0000 (12:56 -0600)]
Merge PR #31274 into master

* refs/pull/31274/head:
osd/OSD: enhance osd numa affinity compatibility

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #31348 into master
Sage Weil [Mon, 2 Dec 2019 18:55:49 +0000 (12:55 -0600)]
Merge PR #31348 into master

* refs/pull/31348/head:
tools/rados: update advisory lock break usage with --lock-cookie required

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #31669 into master
Sage Weil [Mon, 2 Dec 2019 18:55:26 +0000 (12:55 -0600)]
Merge PR #31669 into master

* refs/pull/31669/head:
bluestore: tiny tracepoints improvement

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
5 years agoMerge pull request #31943 from tchaikov/wip-31224
Kefu Chai [Mon, 2 Dec 2019 16:52:00 +0000 (00:52 +0800)]
Merge pull request #31943 from tchaikov/wip-31224

python-common: move pytest integration from setup.py to tox.ini

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agodoc: add Python 2 to Ubuntu 18.04 installations 31947/head
Zac Dover [Mon, 2 Dec 2019 16:21:27 +0000 (02:21 +1000)]
doc: add Python 2 to Ubuntu 18.04 installations

This commit updates the "Create a Cluster" section of the
"Storage Cluster Quick Start" document. Ubuntu 18.04 does
not have Python 2 installed by default. This commit instructs
users of Python 18.04 to install the package "python-minimal"
to provide Python 2 prior to running "ceph-deploy".

This commit fixes Bug number 9 in the list here:
https://pad.ceph.com/p/Report_Documentation_Bugs

Signed-off-by: Zac Dover <zac.dover@gmail.com>
5 years agoMerge pull request #31361 from hairesis/kms_transit_backend
Casey Bodley [Mon, 2 Dec 2019 15:20:19 +0000 (10:20 -0500)]
Merge pull request #31361 from hairesis/kms_transit_backend

rgw: extend SSE-KMS with Vault using transit secrets engine

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agopython-common: move pytest integration from setup.py to tox.ini 31943/head
Sebastian Wagner [Tue, 29 Oct 2019 15:36:01 +0000 (16:36 +0100)]
python-common: move pytest integration from setup.py to tox.ini

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #31279 from lixiaoy1/rwl-image-writeback-cache-seq1
Jason Dillaman [Mon, 2 Dec 2019 14:16:10 +0000 (09:16 -0500)]
Merge pull request #31279 from lixiaoy1/rwl-image-writeback-cache-seq1

rbd/cache: Replicated Write Log core codes part 1

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agomgr/dashboard: Display the aggregated number of request (#31369)
Lenz Grimmer [Mon, 2 Dec 2019 12:41:20 +0000 (12:41 +0000)]
mgr/dashboard: Display the aggregated number of request (#31369)

mgr/dashboard: Display the aggregated number of request

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agomgr/dashboard: Resolve some npm audit issues (#31845)
Lenz Grimmer [Mon, 2 Dec 2019 12:06:39 +0000 (12:06 +0000)]
mgr/dashboard: Resolve some npm audit issues (#31845)

mgr/dashboard: Resolve some npm audit issues

Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agomgr/dashboard: Trim IQN on iSCSI target form (#31888)
Lenz Grimmer [Mon, 2 Dec 2019 11:40:20 +0000 (11:40 +0000)]
mgr/dashboard: Trim IQN on iSCSI target form (#31888)

mgr/dashboard: Trim IQN on iSCSI target form

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agomgr/ssh: `test_mon_update` needs to set a mon name 31933/head
Sebastian Wagner [Mon, 2 Dec 2019 10:20:53 +0000 (11:20 +0100)]
mgr/ssh: `test_mon_update` needs to set a mon name

... in order to exercise a code path to make use of `_get_services()`

Fixes: https://tracker.ceph.com/issues/43075
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/dashboard: Eye candy updates to datatable pages (#31764)
Lenz Grimmer [Mon, 2 Dec 2019 09:27:33 +0000 (09:27 +0000)]
mgr/dashboard: Eye candy updates to datatable pages (#31764)

mgr/dashboard: Eye candy updates to datatable pages

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
5 years agoMerge pull request #31903 from majianpeng/os-bluestore-ceph-assert
Kefu Chai [Mon, 2 Dec 2019 08:50:38 +0000 (16:50 +0800)]
Merge pull request #31903 from majianpeng/os-bluestore-ceph-assert

os/bluestore: don't round_up_to in apply_for_bitset_range.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
5 years agoMerge pull request #31774 from dzafman/wip-balancer3
Kefu Chai [Mon, 2 Dec 2019 08:48:38 +0000 (16:48 +0800)]
Merge pull request #31774 from dzafman/wip-balancer3

osd,tools: Balancer fixes without all of the calc_pg_upmaps() rewrites

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoMerge pull request #31317 from wjwithagen/wjw-update-FindBoost.cmake
Kefu Chai [Mon, 2 Dec 2019 08:46:00 +0000 (16:46 +0800)]
Merge pull request #31317 from wjwithagen/wjw-update-FindBoost.cmake

cmake: update FindBoost.cmake for 1.71

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #31841 from rosinL/wip-support-dpdk-numa
Kefu Chai [Mon, 2 Dec 2019 08:45:11 +0000 (16:45 +0800)]
Merge pull request #31841 from rosinL/wip-support-dpdk-numa

cmake: Add dpdk numa support

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #31915 from majianpeng/osd-remove-useless-ceph-assert
Kefu Chai [Mon, 2 Dec 2019 08:44:27 +0000 (16:44 +0800)]
Merge pull request #31915 from majianpeng/osd-remove-useless-ceph-assert

osd: remove useless ceph_assert.

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #31723 from rosinL/wip-add-bench-log-usage
Kefu Chai [Mon, 2 Dec 2019 08:43:48 +0000 (16:43 +0800)]
Merge pull request #31723 from rosinL/wip-add-bench-log-usage

test/bench_log: add usage function

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #31840 from rosinL/wip-fix-dpdk
Kefu Chai [Mon, 2 Dec 2019 08:42:00 +0000 (16:42 +0800)]
Merge pull request #31840 from rosinL/wip-fix-dpdk

msg/async/dpdk: fix compilation errors when WITH_DPDK=on

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #30631 from xxhdx1985126/wip-bluefs-sync-leak-fix
Kefu Chai [Mon, 2 Dec 2019 08:39:09 +0000 (16:39 +0800)]
Merge pull request #30631 from xxhdx1985126/wip-bluefs-sync-leak-fix

BlueFS: prevent BlueFS::dirty_files from being leaked when syncing metadata

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
5 years agoMerge PR #31900 into master
Sage Weil [Mon, 2 Dec 2019 02:16:31 +0000 (20:16 -0600)]
Merge PR #31900 into master

* refs/pull/31900/head:
mgr: fix debug typo

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge PR #31442 into master
Sage Weil [Mon, 2 Dec 2019 02:12:00 +0000 (20:12 -0600)]
Merge PR #31442 into master

* refs/pull/31442/head:
kv/RocksDBStore: Add minimum key limit before invoking DeleteRange.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agomsg/async/dpdk: Porting seastar's init_port_start to fix to resolve compilation errors 31840/head
Chunsong Feng [Thu, 14 Nov 2019 02:10:34 +0000 (10:10 +0800)]
msg/async/dpdk: Porting seastar's init_port_start to fix to resolve compilation errors

Ceph currently uses dpdk19.05, seastar dpdk_device::init_port_start has
been upgraded to DPDK19.05, so porting changes to fix compiler error.

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
5 years agoMerge pull request #31165 from votdev/improve_py_unittests
Laura Paduano [Fri, 29 Nov 2019 10:04:57 +0000 (11:04 +0100)]
Merge pull request #31165 from votdev/improve_py_unittests

mgr/dashboard: Refactor Python unittests and controller

Reviewed-by: Ernesto Puertat <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
5 years agoMerge pull request #31856 from rzarzynski/wip-crimson-errorator-handle_error
Kefu Chai [Fri, 29 Nov 2019 05:49:26 +0000 (13:49 +0800)]
Merge pull request #31856 from rzarzynski/wip-crimson-errorator-handle_error

crimson/common/errorator.h: add handle_error() method.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #31853 from liewegas/fix-rn-typo
Kefu Chai [Fri, 29 Nov 2019 02:27:36 +0000 (10:27 +0800)]
Merge pull request #31853 from liewegas/fix-rn-typo

PendingReleaseNotes: fix typo

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #31918 from rzarzynski/wip-crimson-errorator-simplify_safe_then
Kefu Chai [Fri, 29 Nov 2019 00:24:01 +0000 (08:24 +0800)]
Merge pull request #31918 from rzarzynski/wip-crimson-errorator-simplify_safe_then

crimson/common/errorator.h: simplify the compound safe_then() variant.

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #31838 into master
Sage Weil [Thu, 28 Nov 2019 21:28:47 +0000 (15:28 -0600)]
Merge PR #31838 into master

* refs/pull/31838/head:
ceph-daemon: chown uid/gid files during `adopt`
ceph-daemon: use 'iglob' instead of 'glob'
ceph-daemon: Fix handling for symlinks on python2

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agokrbd: misc cleanups 31919/head
Ilya Dryomov [Mon, 25 Nov 2019 14:16:38 +0000 (15:16 +0100)]
krbd: misc cleanups

Introduce get_devnode() and append_unmap_options(); make some functions
static.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 years agokrbd: make wait_for_udev_add() clearer and a bit more efficient
Ilya Dryomov [Mon, 25 Nov 2019 13:57:02 +0000 (14:57 +0100)]
krbd: make wait_for_udev_add() clearer and a bit more efficient

Collect only /dev/rbd* block events and dispose of them as soon as
possible; match on devnode and assert on major/minor instead of the
other way around.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 years agokrbd: do away with explicit memory management
Ilya Dryomov [Wed, 9 Oct 2019 10:40:11 +0000 (12:40 +0200)]
krbd: do away with explicit memory management

Wrap udev_monitor, udev_enumerate and udev_device with std::unique_ptr.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 years agomgr/dashboard: Eye candy updates to datatable pages 31764/head
Volker Theile [Thu, 28 Nov 2019 15:54:06 +0000 (16:54 +0100)]
mgr/dashboard: Eye candy updates to datatable pages

- Introduce boolean and array pipes
- Introduce configurable 'badge' datatable column
- Refactor the Inventory, OSD, RBD, iSCSI, ... datatable pages

Signed-off-by: Volker Theile <vtheile@suse.com>
5 years agocrimson/common/errorator.h: simplify the compound safe_then() variant. 31918/head
Radoslaw Zarzynski [Thu, 28 Nov 2019 15:39:05 +0000 (16:39 +0100)]
crimson/common/errorator.h: simplify the compound safe_then() variant.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocrimson/common/errorator.h: add handle_error() method. 31856/head
Radoslaw Zarzynski [Mon, 25 Nov 2019 13:36:36 +0000 (14:36 +0100)]
crimson/common/errorator.h: add handle_error() method.

In contrast to `safe_then` it deals only with errors
and, on return, leaves the value type `future<ValueT>`
embodies unchanged.
While being basically a specialization of `safe_then`,
it's also a convenience method to squeeze boilerplate.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoMerge PR #31914 into master
Sage Weil [Thu, 28 Nov 2019 14:54:19 +0000 (08:54 -0600)]
Merge PR #31914 into master

* refs/pull/31914/head:
mgr/orchestrator: set node labels to empty list if none specified

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
5 years agomgr/dashboard: support creating OSDs on spare devices (#30921)
Volker Theile [Thu, 28 Nov 2019 12:18:22 +0000 (13:18 +0100)]
mgr/dashboard: support creating OSDs on spare devices (#30921)

mgr/dashboard: support creating OSDs on spare devices

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
5 years agocmake: Add shared library as dpdk dependency 31841/head
luo rixin [Thu, 28 Nov 2019 12:18:09 +0000 (20:18 +0800)]
cmake: Add shared library as dpdk dependency

librte_eal.a refers to libpthread.so and libdl.so, and libceph-common.so
refers to librte_eal.a. Many test application link libceph-common.so
without linking pthread, it will cause link error.
Such as unittest_interval_set, target_link_libraries (unittest_interval_set
ceph-common)

Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
5 years agocmake: Add dpdk numa support
Chunsong Feng [Thu, 14 Nov 2019 04:35:37 +0000 (12:35 +0800)]
cmake: Add dpdk numa support

Find and link the numa library for DPDK.

Fixes: https://tracker.ceph.com/issues/42275
Signed-off-by: Hu Ye <yehu5@huawei.com>
Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
5 years agoMerge pull request #31785 from votdev/cleanup_remove_useless_var
Laura Paduano [Thu, 28 Nov 2019 10:44:50 +0000 (11:44 +0100)]
Merge pull request #31785 from votdev/cleanup_remove_useless_var

mgr/dashboard: Remove unused variable

Reviewed-by: Kiefer Chang kiefer.chang@suse.com
Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agoMerge pull request #31720 from rhcs-dashboard/fix-42708-master
Laura Paduano [Thu, 28 Nov 2019 10:36:32 +0000 (11:36 +0100)]
Merge pull request #31720 from rhcs-dashboard/fix-42708-master

mgr/dashboard: remove traceback/version assertions

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agoMerge pull request #31843 from votdev/rename_list_pipe
Laura Paduano [Thu, 28 Nov 2019 10:28:20 +0000 (11:28 +0100)]
Merge pull request #31843 from votdev/rename_list_pipe

mgr/dashboard: Rename pipe list -> join

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
5 years agorgw: improvements to SSE-KMS with Vault 31361/head
Sergio de Carvalho [Thu, 7 Nov 2019 15:33:14 +0000 (15:33 +0000)]
rgw: improvements to SSE-KMS with Vault

* Minor improvements to Vault documentation
* Add teuthology tests for Transit secrets engine
* Add unit tests for KV secrets engine, minor improvements to Transit
  secrets engine
* use string_view::npos instead of string::npos

Signed-off-by: Andrea Baglioni <andrea.baglioni@workday.com>
Signed-off-by: Sergio de Carvalho <sergio.carvalho@workday.com>
5 years agorgw: Vault's Transit Secrets updates and docs
Andrea Baglioni [Tue, 5 Nov 2019 11:21:06 +0000 (11:21 +0000)]
rgw: Vault's Transit Secrets updates and docs

  * Drop polymorfism for KMS class
  * Fix issue in kms-key selection
  * Update documentation for Vault section

Signed-off-by: Andrea Baglioni <andrea.baglioni@workday.com>
Signed-off-by: Sergio de Carvalho <sergio.carvalho@workday.com>
5 years agorgw: Add support to Vault's Transit Secrets Engine in SSE-KMS
Andrea Baglioni [Thu, 24 Oct 2019 09:14:54 +0000 (10:14 +0100)]
rgw: Add support to Vault's Transit Secrets Engine in SSE-KMS

* refactor rgw_kms.cc to support extension to multiple secret engines.
* introduced support to Vault Namesapces
* added support for Vault Agent

Signed-off-by: Andrea Baglioni <andrea.baglioni@workday.com>
Signed-off-by: Sergio de Carvalho <sergio.carvalho@workday.com>
5 years agoos/bluestore: don't round_up_to in apply_for_bitset_range. 31903/head
Jianpeng Ma [Thu, 28 Nov 2019 08:23:01 +0000 (16:23 +0800)]
os/bluestore: don't round_up_to in apply_for_bitset_range.

I met the following error messages:
>sceph7: /home/Jianpeng/ceph/src/os/bluestore/bluestore_common.h: In function 'void apply_for_bitset_range(uint64_t, uint64_t, uint64_t, Bitset&, Func) [with Bitset = boost::dynamic_bitset<long unsigned int>; Func = BlueFS::_replay(bool, bool)::<lambda(uint64_t, boost::dynamic_bitset<long unsigned int>&)>; uint64_t = long unsigned int]' thread 7f7d55a3dd40 time 2019-11-27T23:26:05.949827+0800
>sceph7: /home/Jianpeng/ceph/src/os/bluestore/bluestore_common.h: 28: FAILED ceph_assert(end <= bitset.size())
>sceph7:  ceph version 15.0.0-7747-g22a9a28e28 (22a9a28e2859718c4168f5b3cf6e20a9186e18bc) octopus (dev)
>sceph7:  1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x14f) [0x56322c4440ef]
>sceph7:  2: (()+0x50d2d9) [0x56322c4442d9]
>sceph7:  3: (BlueFS::_replay(bool, bool)+0x5639) [0x56322cb51e49]
>sceph7:  4: (BlueFS::mount()+0x269) [0x56322cb53289]
>sceph7:  5: (BlueStore::_open_bluefs(bool)+0x29e) [0x56322ca6e38e]
>sceph7:  6: (BlueStore::_open_db(bool, bool, bool)+0x59b) [0x56322ca6e9cb]
>sceph7:  7: (BlueStore::mkfs()+0x749) [0x56322caaa259]
>sceph7:  8: (OSD::mkfs(CephContext*, ObjectStore*, uuid_d, int)+0x1c8) [0x56322c5099e8]
>sceph7:  9: (main()+0x1787) [0x56322c4ab117]
>sceph7:  10: (__libc_start_main()+0xeb) [0x7f7d55b5fb6b]
>sceph7:  11: (_start()+0x2a) [0x56322c4de71a]
>sceph7: *** Caught signal (Aborted) **
>sceph7:  in thread 7f7d55a3dd40 thread_name:ceph-osd

If bdev[i]->get_size() / alloc_size[i] != 0,  round_up_to(off+lengh,alloc_size[i])/alloc_size is larger than(one)
ownend_blocks[i].size().

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
5 years agoceph-daemon: Allow env var for setting the used image 31913/head
Thomas Bechtold [Thu, 28 Nov 2019 05:08:42 +0000 (06:08 +0100)]
ceph-daemon: Allow env var for setting the used image

Instead of always adding "--image my-custom-image" when calling
ceph-daemon with a non-standard image, allow to set the environment
variable called CEPH_DAEMON_IMAGE which will adjust the --image
default.
That way, the command line arguments when using ceph-daemon with a
custom image are a bit shorter.

Signed-off-by: Thomas Bechtold <tbechtold@suse.com>
5 years agomgr/orchestrator: set node labels to empty list if none specified 31914/head
Tim Serong [Thu, 28 Nov 2019 05:25:21 +0000 (16:25 +1100)]
mgr/orchestrator: set node labels to empty list if none specified

f06366836ff tries to ' '.join(node.labels), which raises an exception
if labels is None, so we need to default it to an empty list.

Signed-off-by: Tim Serong <tserong@suse.com>
5 years agoosd: remove useless ceph_assert. 31915/head
Jianpeng Ma [Thu, 28 Nov 2019 05:21:49 +0000 (13:21 +0800)]
osd: remove useless ceph_assert.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
5 years agoMerge pull request #31588 from usefulalgorithm/patch-1
Neha Ojha [Thu, 28 Nov 2019 01:33:38 +0000 (17:33 -0800)]
Merge pull request #31588 from usefulalgorithm/patch-1

doc/rados/operations: OSD_OUT_OF_ORDER_FULL fullness order is wrong

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agotest: Add test case based on Xie script in commit comment 31774/head
David Zafman [Wed, 27 Nov 2019 18:50:01 +0000 (10:50 -0800)]
test: Add test case based on Xie script in commit comment

Other test fixes to reflect changes

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agoosd: ceph_pg_upmaps() use any overfull when there are still underfull
David Zafman [Wed, 27 Nov 2019 18:48:30 +0000 (10:48 -0800)]
osd: ceph_pg_upmaps() use any overfull when there are still underfull

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agoosd: Create more_underfull with below target that aren't in underfull
David Zafman [Tue, 26 Nov 2019 23:19:01 +0000 (15:19 -0800)]
osd: Create more_underfull with below target that aren't in underfull

Use more_underfull for finding remaps for overfull OSDs

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agoosd: calc_pg_upmaps() pick most overfull remap from try_pg_upmap()
David Zafman [Tue, 26 Nov 2019 05:38:16 +0000 (21:38 -0800)]
osd: calc_pg_upmaps() pick most overfull remap from try_pg_upmap()

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agoosd: ceph_pg_upmaps() use max_deviation to determine perfect distribution
David Zafman [Fri, 15 Nov 2019 05:10:28 +0000 (21:10 -0800)]
osd: ceph_pg_upmaps() use max_deviation to determine perfect distribution

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agotools: osdmaptool sync with balancer module behavior
David Zafman [Sat, 9 Nov 2019 00:23:14 +0000 (16:23 -0800)]
tools: osdmaptool sync with balancer module behavior

This can be backported only to nautilus

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agotools: osdmaptool: Perform upmap calculation as ceph-mgr does
David Zafman [Thu, 7 Nov 2019 04:32:48 +0000 (20:32 -0800)]
tools: osdmaptool: Perform upmap calculation as ceph-mgr does

This is the backportable commit that works with older balancer module.py

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agoosd: For balancer crush needs the rule passed to get_parent_of_type()
David Zafman [Wed, 20 Nov 2019 06:21:00 +0000 (22:21 -0800)]
osd: For balancer crush needs the rule passed to get_parent_of_type()

Fixes: https://tracker.ceph.com/issues/42718
Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agoosdmaptool: Match default max value of 10
David Zafman [Thu, 7 Nov 2019 04:31:21 +0000 (20:31 -0800)]
osdmaptool: Match default max value of 10

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agotools: odsmaptool truncate target upmap file
David Zafman [Wed, 20 Nov 2019 19:55:15 +0000 (11:55 -0800)]
tools: odsmaptool truncate target upmap file

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agomgr: Fix balancer print
David Zafman [Wed, 20 Nov 2019 22:08:24 +0000 (14:08 -0800)]
mgr: Fix balancer print

Signed-off-by: David Zafman <dzafman@redhat.com>
5 years agoMerge PR #31870 into master
Sage Weil [Wed, 27 Nov 2019 20:20:33 +0000 (14:20 -0600)]
Merge PR #31870 into master

* refs/pull/31870/head:
ceph-daemon: fix `systemctl is-enabled` bool

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #31886 into master
Sage Weil [Wed, 27 Nov 2019 20:20:04 +0000 (14:20 -0600)]
Merge PR #31886 into master

* refs/pull/31886/head:
ceph-daemon: error out if not root
ceph-daemon: user-friendly exception/error messages
ceph-daemon: user-friendly exception/error messages

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #31883 from jan--f/ceph-volume-code-owner
Jan Fajerski [Wed, 27 Nov 2019 15:36:23 +0000 (16:36 +0100)]
Merge pull request #31883 from jan--f/ceph-volume-code-owner

github/codeowners: add ceph-volume

5 years agoMerge PR #31892 into master
Sage Weil [Wed, 27 Nov 2019 14:36:12 +0000 (08:36 -0600)]
Merge PR #31892 into master

* refs/pull/31892/head:
ceph-daemon: seek relative to the start of file

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #31899 into master
Sage Weil [Wed, 27 Nov 2019 14:04:14 +0000 (08:04 -0600)]
Merge PR #31899 into master

* refs/pull/31899/head:
mgr: drop session with Ceph daemon when not ready
mgr: improve debug message information

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoceph-daemon: error out if not root 31886/head
Sage Weil [Wed, 27 Nov 2019 14:01:45 +0000 (08:01 -0600)]
ceph-daemon: error out if not root

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoceph-daemon: user-friendly exception/error messages
Michael Fritch [Wed, 27 Nov 2019 03:30:25 +0000 (20:30 -0700)]
ceph-daemon: user-friendly exception/error messages

- Rename `CDError` to `Error`
- Display traceback on console when `-v` is specified
- Other misc clean-up

Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #30262 from sebastian-philipp/orchestrator-pomise-future
Sebastian Wagner [Wed, 27 Nov 2019 13:58:21 +0000 (14:58 +0100)]
Merge pull request #30262 from sebastian-philipp/orchestrator-pomise-future

mgr/orchestrator: Make Completions composable

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Joshua Schmid <jschmid@suse.de>
5 years agomgr/dashboard: Trim IQN on iSCSI target form 31888/head
Ricardo Marques [Tue, 26 Nov 2019 15:50:21 +0000 (15:50 +0000)]
mgr/dashboard: Trim IQN on iSCSI target form

Fixes: https://tracker.ceph.com/issues/43027
Signed-off-by: Ricardo Marques <rimarques@suse.com>
5 years agomgr/ssh: Disable host labels. 30262/head
Sebastian Wagner [Wed, 27 Nov 2019 12:49:02 +0000 (13:49 +0100)]
mgr/ssh: Disable host labels.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #31896 from rsevero/missing_virtualenv
Kefu Chai [Wed, 27 Nov 2019 12:48:40 +0000 (20:48 +0800)]
Merge pull request #31896 from rsevero/missing_virtualenv

doc: add missing virtualenv for build-doc

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agomgr/orchestrator: use finalize to set TrivialReadCompletion result
Tim Serong [Mon, 25 Nov 2019 04:43:25 +0000 (15:43 +1100)]
mgr/orchestrator: use finalize to set TrivialReadCompletion result

This is needed to correctly set the state of the completion, so that
Completion.has_result returns true.  Without this, _orchestrator_wait()
will spin forever if given a TrivialReadCompletion.

Signed-off-by: Tim Serong <tserong@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/orchestrator: add pretty_print()
Sebastian Wagner [Thu, 21 Nov 2019 14:18:10 +0000 (15:18 +0100)]
mgr/orchestrator: add pretty_print()

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agomgr/ssh: Fix Promises
Sebastian Wagner [Mon, 11 Nov 2019 09:50:21 +0000 (10:50 +0100)]
mgr/ssh: Fix Promises

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoimport typing optionally
Sebastian Wagner [Tue, 1 Oct 2019 09:54:21 +0000 (11:54 +0200)]
import typing optionally

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>