common,log,msg: Fix win32 compiler warnings

This change will fix a few compiler warnings, most of them being
type mismatches that affect Windows builds.

Worth mentioning that "long" uses 32b on x64 Windows platforms,
which is a constant source of type mismatches.

There's a warning saying that the "select" event handler shouldn't
be used in production. Considering that this is the only available
mechanism on Windows for the time being, we're going to disable
this warning.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

win32,common: provide a default ceph.conf location

We're going to use %ProgramData%\ceph\ceph.conf as the default
ceph.conf location on Windows.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

common: add newline before parsing config on Windows

On Windows, ceph will fail to parse config files that lack a
newline at the end.

To improve user experience, we're adding a newline ourselves before
parsing the content.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

common: verify unix sockets support on Windows

Windows Server 2016 doesn't support unix sockets. We'll
check the Windows version and log a message (but not at
error level) when attempting to initialize the admin socket.

This will prevent the following error from being printed
whenever mapping RBD images:

  AdminSocketConfigObs::init: failed: AdminSocket::bind_and_listen:
  failed to bind the UNIX domain socket to
  'C:/ProgramData/Ceph/out/client.admin.2560.asok':
  (10050) Unknown error

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

common: fix md_config_t::get_cluster_name

Mingw complains about not being able to convert
std::filesystem::path::stem to std::string, so we'll need to
explicitly retrurn a string.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

global, common: Print config parse errors

At the moment, config parsing errors aren't printed by "global_init",
so the message shown to the user can be a bit cryptic.

This change will ensure that those parsing errors will be printed.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

common: accept config files containing whitespaces

At the moment, the ceph config file location cannot contain
whitespaces. This applies to all platforms but is quite an
inconvenient on Windows in particular, where it's very common
to have default paths containing white spaces.

ceph_resolve_file_search expects a list of config files and uses
"get_str_list" to separate them. No delimiter list is explicitly
specified, so the default delimiter list is used, which includes
white space.

This change will explicitly set the delimiters to "," and ";".

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

librbd: avoid broken mingw rng

std::random_device is broken when using Mingw < 9.2 [1].
It always produces the same sequence of numbers, so one critical
implication is that multiple sessions coming from different
processes will use the same identifier.

For now, we'll use boost::random::random_device when building with
Mingw.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85494

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

common: define DEV_NULL

On Windows, the "nul" special path must be used instead of
"/dev/null".

Worth mentioning that reading from "nul" will report errors, unlike
"/dev/null" on POSIX platforms. This doesn't affect writes.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

tools,common,msg: Use O_BINARY for win32 compatibility

Unless O_BINARY is passed when opening files, Windows will translate
newlines and handle CTRL+z (Alt+026) as EOF, which can abruptly
end file reads.

We'll define O_BINARY as 0 on other platforms and explicitly use
O_BINARY when expecting binary files.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

log: fix timestamps on Windows

timeval.tv_usec uses long, although on Windows long uses 32b, even
on x64.

For this reason, we'll have to avoid a direct cast from time_t,
which is 64b long.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

common,librbd: add portable ceph_memzero_s

We need a portable way of safely zero-ing out a buffer.

We're adding ceph_memzero_s, which will use one of the
following functions, dependning which one is available:
memset_s, SecureZeroMemory and explicit_bzero.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

common,msg: Fix socket handling

The Windows socket API is slightly different. send/recv/closesocket
must be used instead of read/write/close.

At the same time, WSALastError() must be used instead of errno,
covered by ceph_sock_errno().

The Windows socket errors are similar to the errno ones, except for the
"WSA" prefix and different values.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

common: Extend win32 compatbility layer

For Windows compatibility, we're defining the following:

* random
* get_page_size
* setenv
* unsetenv
* _putenv_s - defined by Windows headers but not exposed by Mingw
              when _POSIX is set

* EDQUOT
* uint

While at it, we're going to avoid importing sys/resourcectl.h on
Windows.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>

Merge pull request #36979 from tspmelo/wip-npm-update-20-8

mgr/dashboard: Update npm packages

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #37449 from ceph/47676-zone-empty-realm-id

mgr/dashboard: get rgw daemon zonegroup name from mgr

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #37375 from ceph/47615-fix-endpoint-responses

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #37064 from bk201/wip-47372

mgr/dashboard: fix error when typing existing paths in the Ganesha form

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #37596 from rhcs-dashboard/telemetry_link_cleanup

mgr/dashboard: Improve HTML formatting of the telemetry report preview

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

mgr/dashboard: Update npm packages

Angular 10.1 includes extraction of TS translations,
so @locl/cli is no longer needed.

Updating Angular automatically removed the usage of base tsconfig.

Downgraded css-loader to be able to use css modules.

angular-tree-component has been deprecated and
replaced by @circlon/angular-tree-component

Fixes: https://tracker.ceph.com/issues/47289
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge PR #32778 into master

* refs/pull/32778/head:
msg: Use sockets instead of pipes for wakeup events on win32
common: Convert remote errors on win32
common,msg: Initialize Windows WSA and TLS
common,os,kv: Define aligned_free
common: avoid CLOCK_*_COARSE warnings on win32
global: Windows support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge PR #36554 into master

* refs/pull/36554/head:
mgr/volumes: Make number of cloner threads configurable

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Shyamsundar R <srangana@redhat.com>

Merge PR #36457 into master

* refs/pull/36457/head:
qa/tasks/cephfs: fix fs authorize cmd args
mds: add root_squash mode in MDS auth caps
vstart_runner: add write_file and sudo_write_file

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #36556 into master

* refs/pull/36556/head:
doc: cephfs mirroring design document

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #37483 from dzafman/wip-46405

osd/osd-rep-recov-eio.sh: TEST_rados_repair_warning:  return 1

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #37500 from ricardoasmarques/fix-bootstrap-container-init

cephadm: Fix error setting 'mgr/cephadm/container_init' config

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #37582 from ivancich/wip-fix-bucket-list-namespace

rgw: fix setting of namespace in ordered and unordered bucket listing

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #37572 from ivancich/wip-orphan-list-namespace-locator

rgw: allow rgw-orphan-list to note when rados objects are in namespace

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #37511 from ivancich/wip-paginate-rgw-bucket-list

rgw: radosgw-admin should paginate internally when listing bucket

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>

mgr/dashboard: Improve HTML formatting of the telemetry report preview

Convert the string "Community Data License Agreement - Sharing - Version 1.0" to a clickable link

Fixes: https://tracker.ceph.com/issues/47790
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #37584 from rhcs-dashboard/report-preview-helper

mgr/dashboard: Add short descriptions to the telemetry report preview

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge PR #37591 into master

* refs/pull/37591/head:
ceph-volume: don't exit before empty report can be printed

Reviewed-by: Joshua Schmid <jschmid@suse.de>

doc: cephfs mirroring design document

Signed-off-by: Venky Shankar <vshankar@redhat.com>

ceph-volume: don't exit before empty report can be printed

get_plan() called exit in case of an empty plan. This prevented a report
being printed under these circumstances. Avoid exit in this case. Also
adds tests to ensure an empty report is printed.

Fixes: https://tracker.ceph.com/issues/47760
Signed-off-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #37561 from tchaikov/wip-cmake-node-mirror

cmake: support Node.js and npm registry mirror

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #37570 from ceph/wip-install-ceph-deploy

doc: add a link to ceph-deploy document

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge PR #37446 into master

* refs/pull/37446/head:
mds: remove dead mdsmap broadcast code

Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge PR #37497 into master

* refs/pull/37497/head:
client,mds: Drop execute permission bits

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #37571 into master

* refs/pull/37571/head:
qa/tasks/cephfs/nfs: Check ganesha daemon status after restarting mgr

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #37579 into master

* refs/pull/37579/head:
SubmittingPatches: use "doc" prefix in title of doc-only commits

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

mgr/dashboard: Add short descriptions to the telemetry report preview

A small info icon with a popover on the telemetry report preview form step2 for
Report ID and Report Preview.

Report ID: "A randomized UUID to identify a particular cluster over the course of several telemetry reports."
Report preview: "The actual telemetry data that will be submitted."

Fixes: https://tracker.ceph.com/issues/47610
Signed-off-by: Nizamudeen A <nia@redhat.com>

rgw: fix setting of namespace in ordered and unordered bucket listing

The namespace is not always set correctly during bucket listing. This
can, for example, cause the listing of incomplete multipart uploads,
which are in the _multipart_ namespace, to not paginate correctly, and
cause entries to be re-listed.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

Merge PR #37577 into master

* refs/pull/37577/head:
PendingReleaseNotes: add note about batch refactor

Reviewed-by: Nathan Cutler <ncutler@suse.com>

rgw: allow rgw-orphan-list to note when rados objects are in namespace

Currently namespaces and locators are ignored when `rados ls` is run
by rgw-orphan-list to record RADOS's known objects.

However there have been cases where RADOS objects have a locator, and
when one is included in the listing, the script does not handle it
correctly. Now when objects have locators, we will prevent their
output from entering the .intermediate file.

Additionally we do not expect RGW data objects to be in RADOS
namespaces, so when a namespaced object is detected, we'll error out
with a message.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

PendingReleaseNotes: add note about batch refactor

Signed-off-by: Jan Fajerski <jfajerski@suse.com>

SubmittingPatches: use "doc" prefix in title of doc-only commits

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37498 from jan--f/cadm-new-batch-report

pybind/mgr/orchestrator: fix preview for new c-v batch output

Merge pull request #37556 from dillaman/wip-rbd-status

rbd: cleanup code and output formatting in status action

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #37521 from jschmid1/remove_orch_osd_spec_mention

docs: <orch osd spec> is no longer present

Merge pull request #37574 from tchaikov/wip-crimson-doc

doc/crimson: cleanups

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>

doc/crimson/poseidonstore: reformat

to render it as expected

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc: move dev/crimson.rst into dev/crimson/

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36343 from myoungwon/wip-doc-poseidon-store

doc: introduce PoseidonStore

Reviewed-by: Samuel Just <sjust@redhat.com>

mgr/dashboard: get rgw daemon zonegroup name from mgr

Fixes: https://tracker.ceph.com/issues/47676
Signed-off-by: Alfonso Martinez <almartin@redhat.com>

Merge pull request #37567 from liewegas/wip-stable-mod

include: ceph_stable_mod in public domain

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

qa/tasks/cephfs/nfs: Check ganesha daemon status after restarting mgr

Fixes: https://tracker.ceph.com/issues/47591
Signed-off-by: Varsha Rao <varao@redhat.com>

doc: add a link to ceph-deploy document

Merge pull request #37565 from tchaikov/wip-crimson-cleanup

crimson: do not capture unused variables

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

crimson/os: mark class with "final" dtor "final"

to silence warning like

scheduler.cc:145:30: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
  ~ClassedOpQueueScheduler() final {};
                             ^
/home/jenkins-build/build/workspace/ceph-perf-crimson/ceph-pr/src/crimson/osd/scheduler/scheduler.cc:52:7: note: mark 'ClassedOpQueueScheduler<T>' as 'final' to silence this warning
class ClassedOpQueueScheduler : public Scheduler {
      ^

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/os: mark dtor of interface class "virtual"

we use a smart_ptr in Seastore to manage the life cycle of
`TransactionManager` which is in turn a subclass
`ExtentCallbackInterface`, so should declare the dtor of latter as
virtual.

Signed-off-by: Kefu Chai <kchai@redhat.com>

rbd: cleanup code and output formatting in status action

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

include: ceph_stable_mod in public domain

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #37395 from tchaikov/wip-doc-crimson

doc/dev/crimson: add instruction on running install-deps.sh for build…

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson: do not capture unused variables

also silence warnings like:

Signe-off-by: Kefu Chai <kchai@redhat.cop_btree_node.h:103:36: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
                                  [this, ec, len, &extents] (auto i) {
                                   ^

Signed-off-by: Kefu Chai <kchai@redhat.com>

seastar: pick up document fixes

pick up changes to address the split script failure with HTML generated
with the latest pandoc.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/dev/crimson: add links to seastar documents

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37523 from Exotelis/wip-42404

mgr/dashboard: Show warning when replicated size is 1

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

doc/dev/crimson: add instruction on running install-deps.sh for building crimson

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc: introduce Poseidon store

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Signed-off-by: Jiwoong Park <jw12.park@samsung.com>
Signed-off-by: Kyuho Son <kyuho.son@samsung.com>
Signed-off-by: Sungkyu Park <sk921.park@samsung.com>

mgr/dashboard: api doc: fix endpoint responses doc generation.

Fixes: https://tracker.ceph.com/issues/47615
Signed-off-by: Alfonso Martínez <almartin@redhat.com>

cmake: read $NPM_REGISTRY for npm registry mirror

in case the offical npm registry is slow or unreachable.

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: extract add_npm_options()

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: read $NODE_MIRROR for Node.js mirror

in case the offical Node.js https://nodejs.org/dist/ is slow or
unreachable.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37134 from myoungwon/wip-tier-evict

osd: add tier_evict

Reviewed-by: Samuel Just <sjust@redhat.com>

mgr/dashboard: fix error when typing existing paths in the Ganesha form

- The `CephFS.ls_dir()` implementation in the backend had changed, the code in the
  UI endpoint `/ui-api/nfs-ganesha/lsdir` needs to adapt.
- Add fs_name as resource_id in `/ui-api/nfs-ganesha/lsdir/<fs_name>` to distinguish FS.
- Add more checks and unit tests.

Fixes: https://tracker.ceph.com/issues/47372
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

Merge pull request #37189 from orozery/striper-assemble-multiple-extents

librbd: support assembling results of multiple object extents

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #37509 from lixiaoy1/fix_rwl

rbd/tools: fix rwl related names

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

rbd/tools: fix rwl related names

These attributes have been renamed.

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>

Merge pull request #37507 from ofriedma/wip-ofriedma-leaked-logs

rgw: print to log leaked obj for any debug level

Merge PR #37531 into master

* refs/pull/37531/head:
ceph-volume batch: return valid empty json reports

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Joshua Schmid <jschmid@suse.de>

Merge PR #37545 into master

* refs/pull/37545/head:
ceph-volume: pass filter_for_batch as keyword argument

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>

librbd: support assembling sparse results of multiple object extents

Currently, Striper supports assembling results representing a single object extent.
Recently, the object dispatch API was extended allowing to read multiple object extents per rados operation.
This commit enables the Striper to correctly un-sparsify the results of the new read extents API.

Signed-off-by: Or Ozeri <oro@il.ibm.com>

ceph-volume: pass filter_for_batch as keyword argument

This PR also removes an unused ctor argument in the Devices class.

Fixes: 7d168ad7bdbb6d6d5231a4ae540ab03040b49a38
Signed-off-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #37414 from votdev/issue_47647_pylint_isort

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge PR #37221 into master

* refs/pull/37221/head:
ceph-volume: add no-systemd argument to zap

Reviewed-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #37532 from tchaikov/wip-crimson-more-privacy

crimson: mark more methods private

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #37516 from anthonyeleven/anthonyeleven/misc-doc-tweaks

doc/rbd: readability and spelling

Reviewed-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #37085 from sunnyku/wip-fix-46743

mgr/devicehealth: device_health_metrics pool gets created even without any OSDs in the cluster

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Yaarit Hatuka <yaarit@redhat.com>

Merge pull request #37487 from tchaikov/wip-backtrace

common/BackTrace: print path without symbol

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #37489 from Rethan/remove_address_helper

common/address_helper: remove address_helper*

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37494 from idryomov/wip-mon-session-timeout-fix

mon: set session_timeout when adding to session_map

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #37526 from ifed01/wip-ifed-verify-range

os/bluestore: kill BitmapFreeListManager::_verify_range()

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #37423 from ronen-fr/wip-rf-scrub6

mon: fixing extra copying in some loops

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #37524 from jschmid1/dont_skip_unavailable_devices

python-common: do not skip unavailable devices

Reviewed-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #37525 from ifed01/wip-ifed-no-recursion-clist

os/bluestore: avoid recursive calls in SimpleCollectionListIterator.

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #37528 from batrick/i47689

qa: ignore evicted client warnings

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #33963 from rosinL/wip-40668

mon/OSDMonitor: Add a safety builtin to mon_osd_report_timeout

Reviewed-by: Joao Eduardo Luis <joao@suse.de>

Merge pull request #37289 from pcuzner/prometheus-add-compr

mgr/prometheus: add pool compression stats

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #36234 from vshankar/wip-rados-pybind-aio-notify

pybind/rados: add aio_notify()

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36732 from rishabh-d-dave/vr-rotate-logs

vstart_runner: rotate logs between testcases

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>