]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 years agoqa/suites/fs/upgrade: finish at octopus 32853/head
Sage Weil [Fri, 24 Jan 2020 23:25:52 +0000 (17:25 -0600)]
qa/suites/fs/upgrade: finish at octopus

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/fs/upgrade: set min-compat-client to octopus
Sage Weil [Fri, 24 Jan 2020 23:26:05 +0000 (17:26 -0600)]
qa/suites/fs/upgrade: set min-compat-client to octopus

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/fs/upgrade: set pg_autoscale_mode=off after upgrade
Sage Weil [Fri, 24 Jan 2020 23:24:39 +0000 (17:24 -0600)]
qa/suites/fs/upgrade: set pg_autoscale_mode=off after upgrade

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32750 into master
Sage Weil [Fri, 24 Jan 2020 23:21:28 +0000 (17:21 -0600)]
Merge PR #32750 into master

* refs/pull/32750/head:
qa/suites/upgrade/*-x/stress-split: run latest python tests at end
qa/tasks/ceph_manager: kludge around /var/log/ceph permissions
mgr/pg_autoscaler: don't check anything until cluster is nautilus
qa/suites/upgrade: install python3-* as part of final upgrade step
qa/tasks/radosbench: only set object size if != block size
qa/tasks/ceph: simplify mon_health_to_clog suppression during restart
cls_hello: alias write_return_data -> writes_dont_return_data
ceph_test_cls_hello: only do returndata test on octopus+
qa: remove unnecessary package excludes in upgrades/nautilus*
qa: exclude cephadm from upgrade/nautilus-x
qa/suites/upgrade/mimic-x/parallel: fix msgr2 vs octopus ordering
qa/suites/upgrade/nautilus-x/stress-split: fix msgr2 vs octopus ordering
qa/suites/upgrade/mimic-x: fix msgr2 vs octopus ordering
qa/suites/upgrade/nautilus-x: end on octopus
qa/suites/upgrade/mimic-x: finish at octopus
qa/suites/upgrade/nautilus-x: disable TOO_FEW_PGS warning
qa/tasks/ceph: set mon_health_to_clog=false via mon config
qa/suites/upgrade/mimic-x: disable TOO_FEW_PGS warning

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #32804 into master
Patrick Donnelly [Fri, 24 Jan 2020 20:57:07 +0000 (12:57 -0800)]
Merge PR #32804 into master

* refs/pull/32804/head:
pybind: Add test for listxattr
pybind: Add listxattr

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #32786 into master
Sage Weil [Fri, 24 Jan 2020 20:04:59 +0000 (14:04 -0600)]
Merge PR #32786 into master

* refs/pull/32786/head:
mon/ConfigMonitor: put global/ keys in global section
mon/ConfigMonitor: transition old keys to have global/ prefix
mon/ConfigMonitor: always prefix global config keys with global/
mon/ConfigMonitor: switch to use pending_cleanup boost::optional

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge PR #32665 into master
Sage Weil [Fri, 24 Jan 2020 20:04:09 +0000 (14:04 -0600)]
Merge PR #32665 into master

* refs/pull/32665/head:
os/bluestore: avoid race between split_cache and get/put pin/unpin
os/bluestore: remove no-op line from split_cache

Reviewed-by: Mark Nelson <mnelson@redhat.com>
5 years agoMerge PR #32755 into master
Sage Weil [Fri, 24 Jan 2020 20:02:14 +0000 (14:02 -0600)]
Merge PR #32755 into master

* refs/pull/32755/head:
pybind/mgr/*: fix config_notify handling of default values

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoMerge PR #32809 into master
Sage Weil [Fri, 24 Jan 2020 20:01:38 +0000 (14:01 -0600)]
Merge PR #32809 into master

* refs/pull/32809/head:
common/options: bluestore 64k min_alloc_size for HDD

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge pull request #32735 from trociny/wip-doc-mirror-snapshot
Jason Dillaman [Fri, 24 Jan 2020 19:30:22 +0000 (14:30 -0500)]
Merge pull request #32735 from trociny/wip-doc-mirror-snapshot

doc: document "mode" param for "rbd mirror image enable" command

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge PR #32686 into master
Sage Weil [Fri, 24 Jan 2020 15:30:11 +0000 (09:30 -0600)]
Merge PR #32686 into master

* refs/pull/32686/head:
mgr/cephadm: speed up when not refresh is needed
mgr/cephadm: track age of service metadata
mgr/orchestrator: include age of 'service ls' metadata
mgr/mgr_util: add to_pretty_timedelta

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agomgr/cephadm: speed up when not refresh is needed 32686/head
Sage Weil [Mon, 23 Dec 2019 19:47:29 +0000 (13:47 -0600)]
mgr/cephadm: speed up when not refresh is needed

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/cephadm: track age of service metadata
Sage Weil [Mon, 23 Dec 2019 19:19:58 +0000 (13:19 -0600)]
mgr/cephadm: track age of service metadata

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/orchestrator: include age of 'service ls' metadata
Sage Weil [Mon, 23 Dec 2019 19:19:38 +0000 (13:19 -0600)]
mgr/orchestrator: include age of 'service ls' metadata

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/mgr_util: add to_pretty_timedelta
Sage Weil [Mon, 23 Dec 2019 19:18:53 +0000 (13:18 -0600)]
mgr/mgr_util: add to_pretty_timedelta

This mirrors the Ceph C++ implementation.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #28603 into master
Sage Weil [Fri, 24 Jan 2020 14:32:47 +0000 (08:32 -0600)]
Merge PR #28603 into master

* refs/pull/28603/head:
mgr: Add get_rates_from_data to mgr_util.py

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #32788 into master
Sage Weil [Fri, 24 Jan 2020 14:32:13 +0000 (08:32 -0600)]
Merge PR #32788 into master

* refs/pull/32788/head:
qa/tasks/mgr/dashboard: set pg_num to 32
mgr/pg_autoscaler: default to pg_num[_min] = 32

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agomgr/dashboard: check if user has config-opt permissions (#32638)
Lenz Grimmer [Fri, 24 Jan 2020 14:00:08 +0000 (14:00 +0000)]
mgr/dashboard: check if user has config-opt permissions (#32638)

mgr/dashboard: check if user has config-opt permissions

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agoqa/suites/upgrade/*-x/stress-split: run latest python tests at end 32750/head
Sage Weil [Fri, 24 Jan 2020 12:52:41 +0000 (06:52 -0600)]
qa/suites/upgrade/*-x/stress-split: run latest python tests at end

Use the master/test/x branch, so that we run the python3 variant of the
test.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/dashboard: Improve the size of forms (#31863)
Lenz Grimmer [Fri, 24 Jan 2020 12:34:12 +0000 (12:34 +0000)]
mgr/dashboard: Improve the size of forms (#31863)

mgr/dashboard: Improve the size of forms

Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agoMerge pull request #32802 from uweigand/cmake-atomic-check
Nathan Cutler [Fri, 24 Jan 2020 09:40:29 +0000 (10:40 +0100)]
Merge pull request #32802 from uweigand/cmake-atomic-check

cmake: Improve test for 16-byte atomic support on IBM Z

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
5 years agomgr/dashboard: Unit test does not do the mentioned thing (#32799)
Lenz Grimmer [Fri, 24 Jan 2020 08:32:59 +0000 (08:32 +0000)]
mgr/dashboard: Unit test does not do the mentioned thing (#32799)

mgr/dashboard: Unit test does not do the mentioned thing

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
5 years agoqa/tasks/ceph_manager: kludge around /var/log/ceph permissions
Sage Weil [Fri, 24 Jan 2020 03:25:08 +0000 (21:25 -0600)]
qa/tasks/ceph_manager: kludge around /var/log/ceph permissions

The ceph.py task normally makes these permissive.  But a package upgrade
can reset the permissions so that we can't read and write the temp
export files.  (We put them in these dirs now because it's alreadly
mapped out of cephadm containers to the host.)

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/pg_autoscaler: don't check anything until cluster is nautilus
Sage Weil [Fri, 24 Jan 2020 03:13:58 +0000 (21:13 -0600)]
mgr/pg_autoscaler: don't check anything until cluster is nautilus

This prevents any health alerts about too many/few PGs due to old pools
that are defaulted to 'warn'.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/upgrade: install python3-* as part of final upgrade step
Sage Weil [Thu, 23 Jan 2020 23:35:02 +0000 (17:35 -0600)]
qa/suites/upgrade: install python3-* as part of final upgrade step

These are new packages, so they won't install just by upgrading the old
packages, and they are needed for some of the tests.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/tasks/radosbench: only set object size if != block size
Sage Weil [Thu, 23 Jan 2020 23:27:30 +0000 (17:27 -0600)]
qa/tasks/radosbench: only set object size if != block size

This is mostly pointless, except that the -O option for objects size
used to be -o for pre-octopus, so passing -O breaks the upgrade tests.
Fortunately, the upgrades use the defaults, so we can just skate by here.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/tasks/ceph: simplify mon_health_to_clog suppression during restart
Sage Weil [Thu, 23 Jan 2020 23:12:21 +0000 (17:12 -0600)]
qa/tasks/ceph: simplify mon_health_to_clog suppression during restart

This only does one thing--do that.  More simply.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #32798 from rhcs-dashboard/fix-make-check-deps-centos8
Kefu Chai [Fri, 24 Jan 2020 02:30:15 +0000 (10:30 +0800)]
Merge pull request #32798 from rhcs-dashboard/fix-make-check-deps-centos8

ceph.spec.in: fix 'make check' deps for centos8

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #32478 into master
Patrick Donnelly [Thu, 23 Jan 2020 23:53:24 +0000 (15:53 -0800)]
Merge PR #32478 into master

* refs/pull/32478/head:
qa: update xfstests version
qa: install some dependencies for xfstests

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
5 years agoMerge PR #32754 into master
Sage Weil [Thu, 23 Jan 2020 23:37:56 +0000 (17:37 -0600)]
Merge PR #32754 into master

* refs/pull/32754/head:
mgr/cephadm: health alert for stray hosts and/or services

Reviewed-by: Michael Fritch <mfritch@suse.com>
5 years agoqa: update xfstests version 32478/head
Patrick Donnelly [Thu, 23 Jan 2020 23:37:56 +0000 (15:37 -0800)]
qa: update xfstests version

Building xfstests on CentOS 8 has build errors:

    2020-01-23T21:15:14.939 INFO:tasks.workunit.client.0.smithi155.stderr:/home/ubuntu/cephtest/mnt.0/client.0/tmp/xfstests/src/fssum.c:616: undefined reference to `major'
    2020-01-23T21:15:14.939 INFO:tasks.workunit.client.0.smithi155.stderr:/home/ubuntu/cephtest/mnt.0/client.0/tmp/xfstests/src/fssum.c:617: undefined reference to `minor'
    2020-01-23T21:15:14.940 INFO:tasks.workunit.client.0.smithi155.stderr:collect2: error: ld returned 1 exit status

From: /ceph/teuthology-archive/pdonnell-2020-01-23_20:47:47-fs-wip-pdonnell-testing-20200122.210533-distro-basic-smithi/4697257/teuthology.log

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoqa: install some dependencies for xfstests
Patrick Donnelly [Fri, 3 Jan 2020 23:33:07 +0000 (15:33 -0800)]
qa: install some dependencies for xfstests

These are needed for CentOS 8 / RHEL8.

Also organize the YAML to use the cleaner array syntax.

Fixes: https://tracker.ceph.com/issues/43459
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #32350 into master
Patrick Donnelly [Thu, 23 Jan 2020 23:29:04 +0000 (15:29 -0800)]
Merge PR #32350 into master

* refs/pull/32350/head:
mds: Reorganize class members in SnapServer header

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #32722 into master
Patrick Donnelly [Thu, 23 Jan 2020 23:28:27 +0000 (15:28 -0800)]
Merge PR #32722 into master

* refs/pull/32722/head:
mds: fix null pointer dereference in Server::handle_client_link()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agocls_hello: alias write_return_data -> writes_dont_return_data
Sage Weil [Wed, 22 Jan 2020 21:51:49 +0000 (15:51 -0600)]
cls_hello: alias write_return_data -> writes_dont_return_data

This allows pre-octopus tests to reach this (renamed) method via the old
method name.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoceph_test_cls_hello: only do returndata test on octopus+
Sage Weil [Tue, 21 Jan 2020 16:58:09 +0000 (10:58 -0600)]
ceph_test_cls_hello: only do returndata test on octopus+

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa: remove unnecessary package excludes in upgrades/nautilus*
Josh Durgin [Mon, 13 Jan 2020 23:14:48 +0000 (18:14 -0500)]
qa: remove unnecessary package excludes in upgrades/nautilus*

These packages are present in nautilus.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
5 years agoqa: exclude cephadm from upgrade/nautilus-x
Josh Durgin [Mon, 13 Jan 2020 23:08:17 +0000 (18:08 -0500)]
qa: exclude cephadm from upgrade/nautilus-x

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
5 years agoqa/suites/upgrade/mimic-x/parallel: fix msgr2 vs octopus ordering
Sage Weil [Tue, 21 Jan 2020 18:44:04 +0000 (12:44 -0600)]
qa/suites/upgrade/mimic-x/parallel: fix msgr2 vs octopus ordering

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/upgrade/nautilus-x/stress-split: fix msgr2 vs octopus ordering
Sage Weil [Tue, 21 Jan 2020 18:43:19 +0000 (12:43 -0600)]
qa/suites/upgrade/nautilus-x/stress-split: fix msgr2 vs octopus ordering

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/upgrade/mimic-x: fix msgr2 vs octopus ordering
Sage Weil [Tue, 21 Jan 2020 18:42:38 +0000 (12:42 -0600)]
qa/suites/upgrade/mimic-x: fix msgr2 vs octopus ordering

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/upgrade/nautilus-x: end on octopus
Sage Weil [Tue, 21 Jan 2020 16:59:25 +0000 (10:59 -0600)]
qa/suites/upgrade/nautilus-x: end on octopus

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/upgrade/mimic-x: finish at octopus
Sage Weil [Tue, 21 Jan 2020 16:57:47 +0000 (10:57 -0600)]
qa/suites/upgrade/mimic-x: finish at octopus

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/upgrade/nautilus-x: disable TOO_FEW_PGS warning
Sage Weil [Tue, 21 Jan 2020 16:07:59 +0000 (10:07 -0600)]
qa/suites/upgrade/nautilus-x: disable TOO_FEW_PGS warning

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/tasks/ceph: set mon_health_to_clog=false via mon config
Sage Weil [Tue, 21 Jan 2020 14:57:06 +0000 (08:57 -0600)]
qa/tasks/ceph: set mon_health_to_clog=false via mon config

This actually works better on new versions.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/upgrade/mimic-x: disable TOO_FEW_PGS warning
Sage Weil [Tue, 21 Jan 2020 14:51:38 +0000 (08:51 -0600)]
qa/suites/upgrade/mimic-x: disable TOO_FEW_PGS warning

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32616 into master
Sage Weil [Thu, 23 Jan 2020 22:40:58 +0000 (16:40 -0600)]
Merge PR #32616 into master

* refs/pull/32616/head:
cephadm: annotate call()
cephadm: podman inspect: image field was called `ImageID`:

Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32795 into master
Sage Weil [Thu, 23 Jan 2020 22:17:39 +0000 (16:17 -0600)]
Merge PR #32795 into master

* refs/pull/32795/head:
cephadm: require fsid if name contains a daemon id
cephadm: infer the fsid by name

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #31155 from zhangsw/fix-rgw-reshard-process
Casey Bodley [Thu, 23 Jan 2020 21:35:13 +0000 (16:35 -0500)]
Merge pull request #31155 from zhangsw/fix-rgw-reshard-process

rgw: one log shard fails shouldn't block other shards process when reshard buckets

Reviewed-by: Mark Kogan <mkogan@redhat.com>
5 years agoMerge pull request #31103 from zhangsw/fix-rgw-reshard-cleanindex
Casey Bodley [Thu, 23 Jan 2020 21:34:12 +0000 (16:34 -0500)]
Merge pull request #31103 from zhangsw/fix-rgw-reshard-cleanindex

rgw: clean index and remove bucket instance info when setting resharding status fails

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #30920 from GaryHyg/wip-quota-bug
Casey Bodley [Thu, 23 Jan 2020 21:33:46 +0000 (16:33 -0500)]
Merge pull request #30920 from GaryHyg/wip-quota-bug

RGW: Set appropriate bucket quota value (when quota value is less than 0)

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #30880 from jiahuizeng/radosgw
Casey Bodley [Thu, 23 Jan 2020 21:33:20 +0000 (16:33 -0500)]
Merge pull request #30880 from jiahuizeng/radosgw

rgw: support radosgw-admin zone/zonegroup placement get command

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #30861 from IlsooByun/rgw_lc_missing
Casey Bodley [Thu, 23 Jan 2020 21:32:45 +0000 (16:32 -0500)]
Merge pull request #30861 from IlsooByun/rgw_lc_missing

rgw: do not miss the 1000th element of every iteration during lifecycle processing

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
5 years agomon/ConfigMonitor: put global/ keys in global section 32786/head
Sage Weil [Thu, 23 Jan 2020 20:14:09 +0000 (14:14 -0600)]
mon/ConfigMonitor: put global/ keys in global section

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #32797 from tchaikov/wip-seastar-and-errorator
Kefu Chai [Thu, 23 Jan 2020 18:31:59 +0000 (02:31 +0800)]
Merge pull request #32797 from tchaikov/wip-seastar-and-errorator

seastar,crimson: pickup change to pin socket to fixed core

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoMerge pull request #29703 from baixueyu/wip-quota
Ali Maredia [Thu, 23 Jan 2020 18:13:17 +0000 (13:13 -0500)]
Merge pull request #29703 from baixueyu/wip-quota

rgw:  when you abort a multipart upload request, the quota may be not updated

5 years agoMerge pull request #28622 from IlsooByun/master
Ali Maredia [Thu, 23 Jan 2020 18:12:25 +0000 (13:12 -0500)]
Merge pull request #28622 from IlsooByun/master

rgw: incorrect return value when processing CORS headers

5 years agoMerge pull request #29733 from baixueyu/wip-reload-coredump
Ali Maredia [Thu, 23 Jan 2020 18:11:39 +0000 (13:11 -0500)]
Merge pull request #29733 from baixueyu/wip-reload-coredump

rgw: maybe coredump when reload operator happened

5 years agodoc: document "mode" param for "rbd mirror image enable" command 32735/head
Mykola Golub [Mon, 20 Jan 2020 15:15:35 +0000 (15:15 +0000)]
doc: document "mode" param for "rbd mirror image enable" command

Signed-off-by: Mykola Golub <mgolub@suse.com>
5 years agoMerge pull request #29795 from xxcs/xxcs03
Ali Maredia [Thu, 23 Jan 2020 17:56:20 +0000 (12:56 -0500)]
Merge pull request #29795 from xxcs/xxcs03

rgw: fix one part of the bulk delete(RGWDeleteMultiObj_ObjStore_S3) fails but no error messages

5 years agoMerge pull request #30913 from ofriedma/wip-ofriedma-lc-logs
Ali Maredia [Thu, 23 Jan 2020 17:55:22 +0000 (12:55 -0500)]
Merge pull request #30913 from ofriedma/wip-ofriedma-lc-logs

rgw: Add more details to the LC delete and transit log

5 years agoMerge PR #32787 into master
Sage Weil [Thu, 23 Jan 2020 17:25:56 +0000 (11:25 -0600)]
Merge PR #32787 into master

* refs/pull/32787/head:
qa/tasks/cephadm: work around .git suffix on ceph_repo
qa/tasks/cephadm: learn to pull cephadm from github

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
5 years agocommon/options: bluestore 64k min_alloc_size for HDD 32809/head
Sage Weil [Thu, 23 Jan 2020 17:23:38 +0000 (11:23 -0600)]
common/options: bluestore 64k min_alloc_size for HDD

Until we understand the performance regression and allocator behavior,
go back to 64k.  This will continue to have a high space overhead for
small objects and EC, but will preserve the current performance levels
for all workloads.

This partially reverts 0ec75c99ddb103c664f66c04450003ed4c407708

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/cephadm: health alert for stray hosts and/or services 32754/head
Sage Weil [Tue, 21 Jan 2020 16:40:07 +0000 (10:40 -0600)]
mgr/cephadm: health alert for stray hosts and/or services

Fixes: https://tracker.ceph.com/issues/43714
Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/dashboard: Add column filtering feature to cd-table (#32568)
Lenz Grimmer [Thu, 23 Jan 2020 16:36:44 +0000 (16:36 +0000)]
mgr/dashboard: Add column filtering feature to cd-table (#32568)

mgr/dashboard: Add column filtering feature to cd-table

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agocephadm: require fsid if name contains a daemon id 32795/head
Michael Fritch [Thu, 23 Jan 2020 15:12:10 +0000 (08:12 -0700)]
cephadm: require fsid if name contains a daemon id

$ cephadm shell --name mon.123
INFO:cephadm:Found fsids []
Traceback (most recent call last):
  File "./cephadm", line 2805, in <module>
    r = args.func()
  File "./cephadm", line 646, in _infer_fsid
    return func()
  File "./cephadm", line 1992, in command_shell
    no_config=True if args.config else False)
  File "./cephadm", line 1009, in get_container_mounts
    data_dir = get_data_dir(fsid, daemon_type, daemon_id)
  File "./cephadm", line 670, in get_data_dir
    return os.path.join(args.data_dir, fsid, '%s.%s' % (t, n))
  File "/usr/lib64/python3.7/posixpath.py", line 94, in join
    genericpath._check_arg_types('join', a, *p)
  File "/usr/lib64/python3.7/genericpath.py", line 149, in _check_arg_types
    (funcname, s.__class__.__name__)) from None
TypeError: join() argument must be str or bytes, not 'NoneType'

Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agocephadm: infer the fsid by name
Michael Fritch [Thu, 23 Jan 2020 15:11:59 +0000 (08:11 -0700)]
cephadm: infer the fsid by name

Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #32387 from athanatos/sjust/wip-glibcxx-assertions
Samuel Just [Thu, 23 Jan 2020 15:15:28 +0000 (07:15 -0800)]
Merge pull request #32387 from athanatos/sjust/wip-glibcxx-assertions

Enable _GLIBCXX_ASSERTIONS and fix unittest problems

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoqa/tasks/cephadm: work around .git suffix on ceph_repo 32787/head
Sage Weil [Thu, 23 Jan 2020 14:25:34 +0000 (08:25 -0600)]
qa/tasks/cephadm: work around .git suffix on ceph_repo

githubusercontent.com doesn't like the .git suffix

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32794 into master
Sage Weil [Thu, 23 Jan 2020 14:12:49 +0000 (08:12 -0600)]
Merge PR #32794 into master

* refs/pull/32794/head:
cephadm: normalize image_id in 'pull' output too
cephadm: fix image_id normalization
cephadm: pull: remove newline from ceph_version
mgr/cephadm: base upgrade check on return code, not stderr
mgr/cephadm: fix ok-to-stop
mgr/cephadm: some upgrade debug output
mgr/cephadm: remove dup check
mgr/cephadm: only need_upgrade_self if image_id doesn't match
mgr/cephadm: safe to restart mgr and other non-mon/osd/mds daemons

Reviewed-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #32791 from liewegas/fix-rgw-website
Ali Maredia [Thu, 23 Jan 2020 14:01:28 +0000 (09:01 -0500)]
Merge pull request #32791 from liewegas/fix-rgw-website

qa/suites/rgw/website: run test on ubuntu

5 years agoMerge pull request #32276 from smithfarm/wip-drop-repo-access-doc
Nathan Cutler [Thu, 23 Jan 2020 13:17:26 +0000 (14:17 +0100)]
Merge pull request #32276 from smithfarm/wip-drop-repo-access-doc

doc/cleanup: drop repo-access.rst

Reviewed-by: Zac Dover <zac.dover@gmail.com>
5 years agopybind: Add test for listxattr 32804/head
Varsha Rao [Sat, 11 Jan 2020 06:01:31 +0000 (11:31 +0530)]
pybind: Add test for listxattr

Signed-off-by: Varsha Rao <varao@redhat.com>
5 years agopybind: Add listxattr
Varsha Rao [Wed, 8 Jan 2020 14:25:57 +0000 (19:55 +0530)]
pybind: Add listxattr

Signed-off-by: Varsha Rao <varao@redhat.com>
5 years agoMerge pull request #32269 from liuchang0812/issue-43199-lockdep-in-coroutines-manager
Daniel Gryniewicz [Thu, 23 Jan 2020 12:56:35 +0000 (07:56 -0500)]
Merge pull request #32269 from liuchang0812/issue-43199-lockdep-in-coroutines-manager

rgw: get elastic search info in start_sync, avoid creating new coroutines manager

5 years agoMerge pull request #32290 from jiahuizeng/es-valid
Daniel Gryniewicz [Thu, 23 Jan 2020 12:55:51 +0000 (07:55 -0500)]
Merge pull request #32290 from jiahuizeng/es-valid

rgw: relax es zone validity check

5 years agoMerge pull request #32458 from ofriedma/wip-ofriedma-fix-trans-noncurr
Daniel Gryniewicz [Thu, 23 Jan 2020 12:54:43 +0000 (07:54 -0500)]
Merge pull request #32458 from ofriedma/wip-ofriedma-fix-trans-noncurr

cls/rgw: when object is versioned and lc transition it, the object is becoming non-current

5 years agoMerge pull request #32180 from yehudasa/wip-43255
Daniel Gryniewicz [Thu, 23 Jan 2020 12:53:34 +0000 (07:53 -0500)]
Merge pull request #32180 from yehudasa/wip-43255

rgw: use bucket creation time from bucket instance info

5 years agocmake: Improve test for 16-byte atomic support on IBM Z 32802/head
Ulrich Weigand [Thu, 23 Jan 2020 12:07:08 +0000 (13:07 +0100)]
cmake: Improve test for 16-byte atomic support on IBM Z

Commit d1b9d14324586d02dc6c8dd0a9bdf4b98ae16416 added a check for
16-byte atomics without library support on IBM Z.  Unfortunately
it turns out this test only works correctly when the test case
is built without optimization.  (This is normally true, but it
may not be the case when passing explicit CXXFLAGS to cmake.)

The underlying reason is that GCC may choose to use either an
inline implementation of the 16-byte atomics or library calls,
depending on whether or not it is able to prove the atomic
variable is properly aligned.  At -O0 it is never able to prove
that, but at higher optimization levels it depends on the complexity
of the expression (in particular, whether GCC can track down the
definition of the underlying object).

As the test case uses a very simple expression, it may happen that
this test can be built without requiring library support, but some
of the "real" uses of atomics in Ceph code cannot.   This defeats
the whole purpose of the test at configure time.

Fixed by making the access pattern in the test more complex, so
that the test fails even at high optimization levels.

Fixes: https://tracker.ceph.com/issues/43747
Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
5 years agomgr/dashboard: Add required symbol directly in the text element 31863/head
Tiago Melo [Mon, 25 Nov 2019 16:41:28 +0000 (15:41 -0100)]
mgr/dashboard: Add required symbol directly in the text element

This prevents the symbol from breaking from the last word of the label,
if the width gets too small.

This will also remove the need to add an extra span just to show the symbol.

Fixes: https://tracker.ceph.com/issues/40751
Signed-off-by: Tiago Melo <tmelo@suse.com>
5 years agomgr/dashboard: Use custom classes for form label and inputs
Tiago Melo [Tue, 19 Nov 2019 19:27:04 +0000 (18:27 -0100)]
mgr/dashboard: Use custom classes for form label and inputs

With this change we are able to configura the col sizes of labels and inputs in
one single place.

Also increased the col size in smaller screens to be able to display longer
labels.

This was not applied in some situations where the col size was different than
usual.

Fixes: https://tracker.ceph.com/issues/40751
Signed-off-by: Tiago Melo <tmelo@suse.com>
5 years agoMerge pull request #32736 from capri1989/credits-script
Abhishek L [Thu, 23 Jan 2020 10:44:28 +0000 (11:44 +0100)]
Merge pull request #32736 from capri1989/credits-script

src/script/credits.sh - switch to bash

Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
5 years agoceph.spec.in: fix 'make check' deps for centos8 32798/head
Alfonso Martínez [Thu, 23 Jan 2020 10:16:27 +0000 (11:16 +0100)]
ceph.spec.in: fix 'make check' deps for centos8

When running 'FOR_MAKE_CHECK=1 ./install-deps.sh' in CentOS 8
these dependencies were not being installed.
Missing dependencies are provided by
https://copr.fedorainfracloud.org/coprs/ktdreyer/ceph-el8/

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
5 years agomgr/dashboard: Unit test does not do the mentioned thing 32799/head
Volker Theile [Thu, 23 Jan 2020 09:25:53 +0000 (10:25 +0100)]
mgr/dashboard: Unit test does not do the mentioned thing

The unit test AccessControlTest::test_load_v2() is testing a v1 database instead of a v2.

Fixes: https://tracker.ceph.com/issues/43760
Signed-off-by: Volker Theile <vtheile@suse.com>
5 years agomgr: Add get_rates_from_data to mgr_util.py 28603/head
Stephan Müller [Fri, 14 Jun 2019 13:45:53 +0000 (15:45 +0200)]
mgr: Add get_rates_from_data to mgr_util.py

The function calculates the difference between the values
in a time series list.

The previous location of it was in the dashboard, that's why the
function has doc tests. In order to be able to test them as part of the
manager utilities a bit of tox magic was added.

Fixes: https://tracker.ceph.com/issues/40365
Signed-off-by: Stephan Müller <smueller@suse.com>
5 years agocrimson/common/errorator: construct future<> with a future_state_base 32797/head
Kefu Chai [Thu, 23 Jan 2020 07:38:11 +0000 (15:38 +0800)]
crimson/common/errorator: construct future<> with a future_state_base

this change is made to adapt
https://github.com/scylladb/seastar/commit/89e801b373423b068b3a70e50b656348f549ade0

* always use the helpers from `futurize` instead of using
  `::seastar::make_exception_future()` directly. as
  `make_exception_future(future_state_base&& state)` is located in
  `seastar::internal` namespace
* add `noexcept` specifier in both constructors. to match with the
  helpers of `make_exception_future2()` which dispatch the call to
  different constructor variants.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoseastar: pickup change to pin socket to fixed core
Kefu Chai [Thu, 23 Jan 2020 04:02:34 +0000 (12:02 +0800)]
seastar: pickup change to pin socket to fixed core

and clang / GCC-10 related fixes

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #32373 from zdover23/wip-doc-pg-formats-update-dec-2019
Neha Ojha [Thu, 23 Jan 2020 03:10:00 +0000 (19:10 -0800)]
Merge pull request #32373 from zdover23/wip-doc-pg-formats-update-dec-2019

doc: update list of formats for --format flag for "ceph pg dump"

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge pull request #32790 from neha-ojha/wip-pglog-defaults
Neha Ojha [Thu, 23 Jan 2020 03:03:48 +0000 (19:03 -0800)]
Merge pull request #32790 from neha-ojha/wip-pglog-defaults

doc/rados: update osd_min_pg_log_entries and add osd_max_pg_log_entries

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agorgw_kms: fix concat_url for empty url case 32387/head
Samuel Just [Sat, 21 Dec 2019 02:11:58 +0000 (02:11 +0000)]
rgw_kms: fix concat_url for empty url case

Can't call back() on an empty string.  Causes unittest_rgw_kms
to fail when compiled with _GLIBCXX_ASSERTIONS.

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agofastbmap_allocator_impl: avoid std::vector[] for oob index
Samuel Just [Sat, 21 Dec 2019 02:04:47 +0000 (02:04 +0000)]
fastbmap_allocator_impl: avoid std::vector[] for oob index

This was relatively harmless as the pointer won't actually be
dereferenced, but it runs afoul of std::vector's bounds checks with
_GLIBCXX_ASSERTIONS enabled.

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agounittest_random: min > max triggers a glibc assert
Samuel Just [Fri, 20 Dec 2019 21:13:49 +0000 (21:13 +0000)]
unittest_random: min > max triggers a glibc assert

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agosrc/CMakeLists.txt: enable _GLIBCXX_ASSERTIONS in debug builds
Samuel Just [Thu, 19 Dec 2019 00:05:14 +0000 (00:05 +0000)]
src/CMakeLists.txt: enable _GLIBCXX_ASSERTIONS in debug builds

We already enable this by default in our rpm builds.  Adding it here as
well increases the odds we'll catch things with make check and local
testing.

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocephadm: normalize image_id in 'pull' output too 32794/head
Sage Weil [Wed, 22 Jan 2020 22:46:17 +0000 (16:46 -0600)]
cephadm: normalize image_id in 'pull' output too

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agocephadm: fix image_id normalization
Sage Weil [Wed, 22 Jan 2020 22:46:05 +0000 (16:46 -0600)]
cephadm: fix image_id normalization

Remove sha256: prefix from id (hash), not name.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32741 into master
Patrick Donnelly [Wed, 22 Jan 2020 22:41:40 +0000 (14:41 -0800)]
Merge PR #32741 into master

* refs/pull/32741/head:
qa/cephfs: make filelock_interrupt.py work with python3

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agocephadm: pull: remove newline from ceph_version
Sage Weil [Wed, 22 Jan 2020 22:39:57 +0000 (16:39 -0600)]
cephadm: pull: remove newline from ceph_version

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/cephadm: base upgrade check on return code, not stderr
Sage Weil [Wed, 22 Jan 2020 22:37:51 +0000 (16:37 -0600)]
mgr/cephadm: base upgrade check on return code, not stderr

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/cephadm: fix ok-to-stop
Sage Weil [Wed, 22 Jan 2020 22:33:03 +0000 (16:33 -0600)]
mgr/cephadm: fix ok-to-stop

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/cephadm: some upgrade debug output
Sage Weil [Wed, 22 Jan 2020 22:31:01 +0000 (16:31 -0600)]
mgr/cephadm: some upgrade debug output

Signed-off-by: Sage Weil <sage@redhat.com>