]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 years agomgr/dashboard: Change project name to "Ceph Dashboard" 32959/head
Lenz Grimmer [Wed, 29 Jan 2020 10:04:28 +0000 (11:04 +0100)]
mgr/dashboard: Change project name to "Ceph Dashboard"

The Dashboard's "About" page still referred to the
application as "Ceph Manager Dashboard".
Changed the `projectName` constant to
"Ceph Dashboard" to resolve this.

Fixes: https://tracker.ceph.com/issues/43840
Signed-off-by: Lenz Grimmer <lgrimmer@suse.com>
5 years agoMerge pull request #32836 from s0nea/wip-dashboard-boolean-settings
Laura Paduano [Tue, 28 Jan 2020 11:13:37 +0000 (12:13 +0100)]
Merge pull request #32836 from s0nea/wip-dashboard-boolean-settings

mgr/dashboard: show checkboxes for booleans

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
5 years agomgr/dashboard: extend doc by Grafana setting (#32460)
Lenz Grimmer [Tue, 28 Jan 2020 10:06:24 +0000 (10:06 +0000)]
mgr/dashboard: extend doc by Grafana setting (#32460)

mgr/dashboard: extend doc by Grafana setting

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
5 years agomgr/dashboard: disable 'Add Capability' button in rgw user edi… (#32610)
Lenz Grimmer [Tue, 28 Jan 2020 08:49:10 +0000 (08:49 +0000)]
mgr/dashboard: disable 'Add Capability' button in rgw user edi… (#32610)

mgr/dashboard: disable 'Add Capability' button in rgw user edit form.

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agoMerge PR #32925 into master
Sage Weil [Mon, 27 Jan 2020 23:38:55 +0000 (17:38 -0600)]
Merge PR #32925 into master

* refs/pull/32925/head:
os/bluestore: fix duplicate onode instance while doing omap repair.
test/store_test: introduce test case for per-pool omap repair.

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32850 into master
Sage Weil [Mon, 27 Jan 2020 22:49:12 +0000 (16:49 -0600)]
Merge PR #32850 into master

* refs/pull/32850/head:
osdc/Objecter: debug pause/unpause transition

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge PR #32752 into master
Sage Weil [Mon, 27 Jan 2020 21:20:32 +0000 (15:20 -0600)]
Merge PR #32752 into master

* refs/pull/32752/head:
cephadm: remove `logs` command

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #32920 into master
Sage Weil [Mon, 27 Jan 2020 19:28:59 +0000 (13:28 -0600)]
Merge PR #32920 into master

* refs/pull/32920/head:
qa/suites/rados/rest: run restful test on el8

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoos/bluestore: fix duplicate onode instance while doing omap repair. 32925/head
Igor Fedotov [Mon, 27 Jan 2020 18:47:08 +0000 (21:47 +0300)]
os/bluestore: fix duplicate onode instance while doing omap repair.

Fixes: https://tracker.ceph.com/issues/43824
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
5 years agotest/store_test: introduce test case for per-pool omap repair.
Igor Fedotov [Mon, 27 Jan 2020 18:11:51 +0000 (21:11 +0300)]
test/store_test: introduce test case for per-pool omap repair.

This also reproduces
https://tracker.ceph.com/issues/43824

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
5 years agoMerge PR #32812 into master
Sage Weil [Mon, 27 Jan 2020 17:39:53 +0000 (11:39 -0600)]
Merge PR #32812 into master

* refs/pull/32812/head:
mgr/cephadm: get --osd-uuid deploy arg from osdmap
mgr/cephadm: fetch keyring in _create_daemon()

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #32885 into master
Sage Weil [Mon, 27 Jan 2020 17:36:37 +0000 (11:36 -0600)]
Merge PR #32885 into master

* refs/pull/32885/head:
qa/suites/rados/thrash: debug monc

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge PR #32886 into master
Sage Weil [Mon, 27 Jan 2020 17:31:36 +0000 (11:31 -0600)]
Merge PR #32886 into master

* refs/pull/32886/head:
cephadm: no --no-systemd arg to ceph-volume deactivate

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #32851 into master
Sage Weil [Mon, 27 Jan 2020 17:05:29 +0000 (11:05 -0600)]
Merge PR #32851 into master

* refs/pull/32851/head:
qa/standalone/osd/osd-backfill-recovery-log.sh: fix TEST_backfill_log_2
qa/standalone/osd/osd-backfill-recovery-log.sh: fix TEST_backfill_log_1

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: David Zafman <dzafman@redhat.com>
5 years agoqa/suites/rados/rest: run restful test on el8 32920/head
Sage Weil [Mon, 27 Jan 2020 17:02:07 +0000 (11:02 -0600)]
qa/suites/rados/rest: run restful test on el8

For some reason the requests library has trouble connecting from
ubuntu 18.04.  I reproduced this locally on my 18.04 desktop, although
there it fails on the first API request instead of the last (as in QA).

In any case, this appears to be a client library problem.

Fixes: https://tracker.ceph.com/issues/43720
Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32898 into master
Sage Weil [Mon, 27 Jan 2020 16:37:16 +0000 (10:37 -0600)]
Merge PR #32898 into master

* refs/pull/32898/head:
qa/suites/rados/singleton/all/recovery-preemption: fix pg log length

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge pull request #32617 from taodd/bug-43563
Casey Bodley [Mon, 27 Jan 2020 15:49:33 +0000 (10:49 -0500)]
Merge pull request #32617 from taodd/bug-43563

rgw: update the hash source for multipart entries during resharding

Reviewed-by: Eric J. Ivancich <ivancich@redhat.com>
5 years agoMerge pull request #32487 from ofriedma/wip-ofriedma-copy-part-hdr
Casey Bodley [Mon, 27 Jan 2020 15:48:40 +0000 (10:48 -0500)]
Merge pull request #32487 from ofriedma/wip-ofriedma-copy-part-hdr

rgw: Fix upload part copy range able to get almost any string

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
5 years agoMerge pull request #31887 from ofriedma/wip-ofriedma-lc-hdr-mid
Casey Bodley [Mon, 27 Jan 2020 15:48:11 +0000 (10:48 -0500)]
Merge pull request #31887 from ofriedma/wip-ofriedma-lc-hdr-mid

rgw: LC expiration header should present midnight expiration date

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
5 years agoMerge pull request #30778 from joke-lee/rgw-ipv6
Casey Bodley [Mon, 27 Jan 2020 15:47:38 +0000 (10:47 -0500)]
Merge pull request #30778 from joke-lee/rgw-ipv6

rgw: fix SignatureDoesNotMatch when use ipv6 address in s3 client

Reviewed-By: Casey Bodley <cbodley@redhat.com>
Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
5 years agoMerge pull request #31977 from ofriedma/wip-ofriedma-dynamic-disable
Casey Bodley [Mon, 27 Jan 2020 15:46:15 +0000 (10:46 -0500)]
Merge pull request #31977 from ofriedma/wip-ofriedma-dynamic-disable

rgw: Fix dynamic resharding not working for empty zonegroup in period

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
5 years agoMerge pull request #31185 from joke-lee/rgw-user-modify-placement
Casey Bodley [Mon, 27 Jan 2020 15:44:17 +0000 (10:44 -0500)]
Merge pull request #31185 from joke-lee/rgw-user-modify-placement

rgw: support specify user default placement and placement_tags when create or modify user

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge pull request #32235 from jan--f/c-v-prepare-size-args
Jan Fajerski [Mon, 27 Jan 2020 15:03:07 +0000 (16:03 +0100)]
Merge pull request #32235 from jan--f/c-v-prepare-size-args

ceph-volume: add sizing arguments to prepare

5 years agomgr/dashboard: unify indentation in dashboard.rst 32460/head
Patrick Seidensal [Thu, 2 Jan 2020 14:04:14 +0000 (15:04 +0100)]
mgr/dashboard: unify indentation in dashboard.rst

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 years agocephadm: remove `logs` command 32752/head
Michael Fritch [Mon, 27 Jan 2020 14:21:53 +0000 (07:21 -0700)]
cephadm: remove `logs` command

Fixes: https://tracker.ceph.com/issues/43618
Signed-off-by: Michael Fritch <mfritch@suse.com>
5 years agoqa/suites/rados/singleton/all/recovery-preemption: fix pg log length 32898/head
Sage Weil [Mon, 27 Jan 2020 13:40:12 +0000 (07:40 -0600)]
qa/suites/rados/singleton/all/recovery-preemption: fix pg log length

This was broken by the variable PG log lengths in
9c69c2f7cc585b5e13e4d1b0432016d38135a3de.

Disable the new option to get (roughly) the old behavior, or at least the
short logs that we want to trigger some backfill.

Fixes: https://tracker.ceph.com/issues/43810
Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32853 into master
Sage Weil [Mon, 27 Jan 2020 13:14:37 +0000 (07:14 -0600)]
Merge PR #32853 into master

* refs/pull/32853/head:
qa/suites/fs/upgrade: finish at octopus
qa/suites/fs/upgrade: set min-compat-client to octopus
qa/suites/fs/upgrade: set pg_autoscale_mode=off after upgrade

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #32883 into master
Sage Weil [Mon, 27 Jan 2020 13:08:40 +0000 (07:08 -0600)]
Merge PR #32883 into master

* refs/pull/32883/head:
qa/workunits/rados/test_crash.sh: do not fail if coredump not found
rgw: set bucket quota only when necessary

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agomgr/dashboard: show checkboxes for booleans 32836/head
Tatjana Dehler [Fri, 24 Jan 2020 16:02:22 +0000 (17:02 +0100)]
mgr/dashboard: show checkboxes for booleans

The frontend showed textboxes for the dashboard settings because
the actual type information was missing here. The REST API then
returned the default type 'str'.

Edit the e2e test case in order to update a different setting as
the 'editMgrModule' method can't handle checkboxes.

Fixes: https://tracker.ceph.com/issues/43769
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
5 years agomonitoring: add details to Prometheus' alerts (#32803)
Lenz Grimmer [Mon, 27 Jan 2020 08:23:29 +0000 (08:23 +0000)]
monitoring: add details to Prometheus' alerts (#32803)

monitoring: add details to Prometheus' alerts

Reviewed-by: Andreas Jaeger <aj@suse.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
5 years agoMerge pull request #32434 from trociny/wip-41559
Jason Dillaman [Sun, 26 Jan 2020 18:31:39 +0000 (13:31 -0500)]
Merge pull request #32434 from trociny/wip-41559

mgr/rbd_support: implement mirror snapshot scheduler

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agolibrbd: optimize mirror_image_info_list (don't open image context) 32434/head
Mykola Golub [Thu, 9 Jan 2020 11:07:22 +0000 (11:07 +0000)]
librbd: optimize mirror_image_info_list (don't open image context)

Signed-off-by: Mykola Golub <mgolub@suse.com>
5 years agolibrbd: make mirror get info request not require image context
Mykola Golub [Thu, 9 Jan 2020 11:01:46 +0000 (11:01 +0000)]
librbd: make mirror get info request not require image context

Signed-off-by: Mykola Golub <mgolub@suse.com>
5 years agoqa/workunits/rados/test_crash.sh: do not fail if coredump not found 32883/head
Kefu Chai [Sun, 26 Jan 2020 14:20:42 +0000 (22:20 +0800)]
qa/workunits/rados/test_crash.sh: do not fail if coredump not found

Fixes: https://tracker.ceph.com/issues/43653
Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agocephadm: no --no-systemd arg to ceph-volume deactivate 32886/head
Sage Weil [Sun, 26 Jan 2020 17:17:01 +0000 (11:17 -0600)]
cephadm: no --no-systemd arg to ceph-volume deactivate

ceph-volume lvm deactivate: error: unrecognized arguments: --no-systemd

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/rados/thrash: debug monc 32885/head
Sage Weil [Sun, 26 Jan 2020 17:13:20 +0000 (11:13 -0600)]
qa/suites/rados/thrash: debug monc

Hunting https://tracker.ceph.com/issues/43825

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agorgw: set bucket quota only when necessary 32884/head
Kefu Chai [Sun, 26 Jan 2020 16:19:01 +0000 (00:19 +0800)]
rgw: set bucket quota only when necessary

this change fixes the regression introduced by 9a7f76a7

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agomgr/rbd_support: optimize scanning images in mirror snapshot mode
Mykola Golub [Fri, 27 Dec 2019 10:37:42 +0000 (10:37 +0000)]
mgr/rbd_support: optimize scanning images in mirror snapshot mode

Signed-off-by: Mykola Golub <mgolub@suse.com>
5 years agolibrbd: add API to list mirror image info
Mykola Golub [Fri, 27 Dec 2019 08:54:31 +0000 (08:54 +0000)]
librbd: add API to list mirror image info

Signed-off-by: Mykola Golub <mgolub@suse.com>
5 years agomgr/rbd_support: implement mirror snapshot scheduler
Mykola Golub [Sat, 14 Dec 2019 19:56:07 +0000 (19:56 +0000)]
mgr/rbd_support: implement mirror snapshot scheduler

Signed-off-by: Mykola Golub <mgolub@suse.com>
5 years agopybind/mgr/rbd_support: split module.py into several files
Mykola Golub [Fri, 22 Nov 2019 17:56:38 +0000 (17:56 +0000)]
pybind/mgr/rbd_support: split module.py into several files

(it is becoming too large)

Signed-off-by: Mykola Golub <mgolub@suse.com>
5 years agoMerge pull request #32734 from trociny/wip-43589
Jason Dillaman [Sun, 26 Jan 2020 16:19:11 +0000 (11:19 -0500)]
Merge pull request #32734 from trociny/wip-43589

librbd: don't call refresh from mirror::GetInfoRequest state machine

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge pull request #32766 from rzarzynski/wip-common-ceph_atomic
Kefu Chai [Sun, 26 Jan 2020 16:01:57 +0000 (00:01 +0800)]
Merge pull request #32766 from rzarzynski/wip-common-ceph_atomic

crimson, common: introduce ceph::atomic and apply it on bufferlist.

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #32760 from trociny/wip-43666
Jason Dillaman [Sun, 26 Jan 2020 15:15:26 +0000 (10:15 -0500)]
Merge pull request #32760 from trociny/wip-43666

librbd: fix potential snapshot remove failure due to duplicate RPC messages

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge pull request #32730 from tchaikov/wip-mgr-maybe-unused
Kefu Chai [Sun, 26 Jan 2020 03:56:10 +0000 (11:56 +0800)]
Merge pull request #32730 from tchaikov/wip-mgr-maybe-unused

mgr: better error handling when reading option

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #32758 from ifed01/wip-ifed-fix-legacy-omap
Kefu Chai [Sun, 26 Jan 2020 03:55:21 +0000 (11:55 +0800)]
Merge pull request #32758 from ifed01/wip-ifed-fix-legacy-omap

os/bluestore: upgrade legacy omap to per-pool format automatically.

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #32764 from liewegas/fix-43552
Kefu Chai [Sun, 26 Jan 2020 03:53:40 +0000 (11:53 +0800)]
Merge pull request #32764 from liewegas/fix-43552

mon/Session: only index osd ids >= 0

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge pull request #32753 from mgfritch/cephadm-tox-escape-seq
Kefu Chai [Sun, 26 Jan 2020 03:45:28 +0000 (11:45 +0800)]
Merge pull request #32753 from mgfritch/cephadm-tox-escape-seq

cephadm: fix tox DeprecationWarning

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #32352 from rzarzynski/wip-bug-43070
Kefu Chai [Sun, 26 Jan 2020 03:41:06 +0000 (11:41 +0800)]
Merge pull request #32352 from rzarzynski/wip-bug-43070

msg/async: reset the V1's session_security in proper EventCenter.

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #32785 from rzarzynski/wip-encoding-no-bl-copy_in-2
Kefu Chai [Sun, 26 Jan 2020 03:37:01 +0000 (11:37 +0800)]
Merge pull request #32785 from rzarzynski/wip-encoding-no-bl-copy_in-2

common: encode for std::list<T> doesn't use bl::copy_in() anymore.

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/suites/fs/upgrade: finish at octopus 32853/head
Sage Weil [Fri, 24 Jan 2020 23:25:52 +0000 (17:25 -0600)]
qa/suites/fs/upgrade: finish at octopus

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/cephadm: get --osd-uuid deploy arg from osdmap 32812/head
Sage Weil [Thu, 23 Jan 2020 19:43:58 +0000 (13:43 -0600)]
mgr/cephadm: get --osd-uuid deploy arg from osdmap

During the initial OSD creation, we had the osd_uuid handy.  However, on
reconfig/redeploy, we don't.

Refactor a bit so that this is extracted from the osdmap by the
_create_daemon() method.  While we're at it, make the deployment case
verify that the deployed OSD uuid matches the one in the osdmap.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/fs/upgrade: set min-compat-client to octopus
Sage Weil [Fri, 24 Jan 2020 23:26:05 +0000 (17:26 -0600)]
qa/suites/fs/upgrade: set min-compat-client to octopus

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #30272 from ivancich/wip-move-some-bucket-listing-logic-to-cls
J. Eric Ivancich [Sat, 25 Jan 2020 19:12:02 +0000 (14:12 -0500)]
Merge pull request #30272 from ivancich/wip-move-some-bucket-listing-logic-to-cls

rgw: move delimiter-based bucket listing/filtering logic to cls

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoqa/suites/fs/upgrade: set pg_autoscale_mode=off after upgrade
Sage Weil [Fri, 24 Jan 2020 23:24:39 +0000 (17:24 -0600)]
qa/suites/fs/upgrade: set pg_autoscale_mode=off after upgrade

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32750 into master
Sage Weil [Fri, 24 Jan 2020 23:21:28 +0000 (17:21 -0600)]
Merge PR #32750 into master

* refs/pull/32750/head:
qa/suites/upgrade/*-x/stress-split: run latest python tests at end
qa/tasks/ceph_manager: kludge around /var/log/ceph permissions
mgr/pg_autoscaler: don't check anything until cluster is nautilus
qa/suites/upgrade: install python3-* as part of final upgrade step
qa/tasks/radosbench: only set object size if != block size
qa/tasks/ceph: simplify mon_health_to_clog suppression during restart
cls_hello: alias write_return_data -> writes_dont_return_data
ceph_test_cls_hello: only do returndata test on octopus+
qa: remove unnecessary package excludes in upgrades/nautilus*
qa: exclude cephadm from upgrade/nautilus-x
qa/suites/upgrade/mimic-x/parallel: fix msgr2 vs octopus ordering
qa/suites/upgrade/nautilus-x/stress-split: fix msgr2 vs octopus ordering
qa/suites/upgrade/mimic-x: fix msgr2 vs octopus ordering
qa/suites/upgrade/nautilus-x: end on octopus
qa/suites/upgrade/mimic-x: finish at octopus
qa/suites/upgrade/nautilus-x: disable TOO_FEW_PGS warning
qa/tasks/ceph: set mon_health_to_clog=false via mon config
qa/suites/upgrade/mimic-x: disable TOO_FEW_PGS warning

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/standalone/osd/osd-backfill-recovery-log.sh: fix TEST_backfill_log_2 32851/head
Neha [Fri, 24 Jan 2020 22:42:04 +0000 (22:42 +0000)]
qa/standalone/osd/osd-backfill-recovery-log.sh: fix TEST_backfill_log_2

Fixes: https://tracker.ceph.com/issues/43807
Signed-off-by: Neha Ojha <nojha@redhat.com>
5 years agoqa/standalone/osd/osd-backfill-recovery-log.sh: fix TEST_backfill_log_1
Neha [Fri, 24 Jan 2020 22:13:00 +0000 (22:13 +0000)]
qa/standalone/osd/osd-backfill-recovery-log.sh: fix TEST_backfill_log_1

Fixes: https://tracker.ceph.com/issues/43807
Signed-off-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge PR #32804 into master
Patrick Donnelly [Fri, 24 Jan 2020 20:57:07 +0000 (12:57 -0800)]
Merge PR #32804 into master

* refs/pull/32804/head:
pybind: Add test for listxattr
pybind: Add listxattr

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #32786 into master
Sage Weil [Fri, 24 Jan 2020 20:04:59 +0000 (14:04 -0600)]
Merge PR #32786 into master

* refs/pull/32786/head:
mon/ConfigMonitor: put global/ keys in global section
mon/ConfigMonitor: transition old keys to have global/ prefix
mon/ConfigMonitor: always prefix global config keys with global/
mon/ConfigMonitor: switch to use pending_cleanup boost::optional

Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agoMerge PR #32665 into master
Sage Weil [Fri, 24 Jan 2020 20:04:09 +0000 (14:04 -0600)]
Merge PR #32665 into master

* refs/pull/32665/head:
os/bluestore: avoid race between split_cache and get/put pin/unpin
os/bluestore: remove no-op line from split_cache

Reviewed-by: Mark Nelson <mnelson@redhat.com>
5 years agoMerge PR #32755 into master
Sage Weil [Fri, 24 Jan 2020 20:02:14 +0000 (14:02 -0600)]
Merge PR #32755 into master

* refs/pull/32755/head:
pybind/mgr/*: fix config_notify handling of default values

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
5 years agoMerge PR #32809 into master
Sage Weil [Fri, 24 Jan 2020 20:01:38 +0000 (14:01 -0600)]
Merge PR #32809 into master

* refs/pull/32809/head:
common/options: bluestore 64k min_alloc_size for HDD

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
5 years agorgw: let newer RGWs work with older OSDs re: cls-side filtering 30272/head
J. Eric Ivancich [Fri, 27 Sep 2019 16:05:17 +0000 (12:05 -0400)]
rgw: let newer RGWs work with older OSDs re: cls-side filtering

Previous commits moved bucket list filtering when a delimiter was
specified to the osd/cls layer. However, since rgw's are often
upgraded before osd's are, until we reach verison ceph version 16, an
rgw cannot assume that the osd/cls did the filtering. This is
addressed in the following ways....

First rgw_cls_list_ret now indicates whether filtering was done on the
osd/cls side.

And second, the old filtering code in the rgw is maintained in
RGWRados::Bucket::List::list_objects_ordered, so it can still be
triggered when all osd's are not doing the filtering.

Once we reach ceph version 16, and there is no chance that the rgw is
working with a osd running "young" version 14 code, we can remove the
backward compatibility code in
RGWRados::Bucket::List::list_objects_ordered.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agorgw: add unit testing for delimiter filtering in cls
J. Eric Ivancich [Mon, 9 Sep 2019 20:30:33 +0000 (16:30 -0400)]
rgw: add unit testing for delimiter filtering in cls

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agorgw: move some bucket index delimiter filtering logic to cls
J. Eric Ivancich [Tue, 6 Aug 2019 21:44:29 +0000 (17:44 -0400)]
rgw: move some bucket index delimiter filtering logic to cls

Currently the cls code that returns bucket index entries does no
filtering when a delimiter is specified. This means that the cls code
will return many entries that the rgw code does not need. This means
unnecessary bucket index entries will be encoded, decoded, and consume
network bandwidth.

A change is made to send a delimiter, if it's specified, to the cls
code, so the filtering can be done there.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agoMerge pull request #32735 from trociny/wip-doc-mirror-snapshot
Jason Dillaman [Fri, 24 Jan 2020 19:30:22 +0000 (14:30 -0500)]
Merge pull request #32735 from trociny/wip-doc-mirror-snapshot

doc: document "mode" param for "rbd mirror image enable" command

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agorgw: reformat some code to make it easier to read
J. Eric Ivancich [Tue, 3 Sep 2019 17:03:51 +0000 (13:03 -0400)]
rgw: reformat some code to make it easier to read

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agorgw: rename search variable to better indicate semantics
J. Eric Ivancich [Tue, 3 Sep 2019 19:14:21 +0000 (15:14 -0400)]
rgw: rename search variable to better indicate semantics

cls_cxx_map_get_vals takes a parameter of where in the sequence of
keys to start returning values. In code it's often referred to as the
"start_key", but in fact it only returns values who have keys *after*
it. To clarify the semantics, rename the variable to "start_after_key"
in the bucket listing functions in both rgw and cls.

Also, declare a type RGWRados::check_filter_t, so the type does not
have to be fully literalized multiple times.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agorgw: change scope of bucket index entry flags
J. Eric Ivancich [Fri, 13 Sep 2019 03:20:55 +0000 (23:20 -0400)]
rgw: change scope of bucket index entry flags

Redefine global constants that define flags in bucket index entries to
struct-scoped.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agorgw: add documentation to bucket index code
J. Eric Ivancich [Tue, 3 Sep 2019 17:00:30 +0000 (13:00 -0400)]
rgw: add documentation to bucket index code

Some of the logic surrounding bucket indexes and the listing thereof
can be subtle. Add some comments to help future developers working on
this code.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agorgw: move after-delimiter logic so available in both rgw & cls/osd
J. Eric Ivancich [Tue, 3 Sep 2019 14:49:12 +0000 (10:49 -0400)]
rgw: move after-delimiter logic so available in both rgw & cls/osd

Since we need to be able to calculate a key a path subdirectory both
in rgw and cls, move the code that calculates that to cls_rgw_types.h,
which is shared by both rgw and cls/osd.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agorgw: use a constexpr to specify standard # of bucket entries to list
J. Eric Ivancich [Fri, 6 Sep 2019 22:02:54 +0000 (18:02 -0400)]
rgw: use a constexpr to specify standard # of bucket entries to list

Rather than hard-coding literals (of 1000) throughout the code, use a
constexpr given it's the standard chunk we're reading from a bucket
index.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agorgw: add missing editor directive to file
J. Eric Ivancich [Wed, 7 Aug 2019 20:41:44 +0000 (16:41 -0400)]
rgw: add missing editor directive to file

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
5 years agoosdc/Objecter: debug pause/unpause transition 32850/head
Sage Weil [Fri, 24 Jan 2020 16:54:00 +0000 (10:54 -0600)]
osdc/Objecter: debug pause/unpause transition

My only theory for https://tracker.ceph.com/issues/43813 is that
t->paused got set somehow, but I can't see how.  Add some debug output
when this happens (it should be pretty rare).

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #32686 into master
Sage Weil [Fri, 24 Jan 2020 15:30:11 +0000 (09:30 -0600)]
Merge PR #32686 into master

* refs/pull/32686/head:
mgr/cephadm: speed up when not refresh is needed
mgr/cephadm: track age of service metadata
mgr/orchestrator: include age of 'service ls' metadata
mgr/mgr_util: add to_pretty_timedelta

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agomgr/cephadm: speed up when not refresh is needed 32686/head
Sage Weil [Mon, 23 Dec 2019 19:47:29 +0000 (13:47 -0600)]
mgr/cephadm: speed up when not refresh is needed

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/cephadm: track age of service metadata
Sage Weil [Mon, 23 Dec 2019 19:19:58 +0000 (13:19 -0600)]
mgr/cephadm: track age of service metadata

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/orchestrator: include age of 'service ls' metadata
Sage Weil [Mon, 23 Dec 2019 19:19:38 +0000 (13:19 -0600)]
mgr/orchestrator: include age of 'service ls' metadata

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/mgr_util: add to_pretty_timedelta
Sage Weil [Mon, 23 Dec 2019 19:18:53 +0000 (13:18 -0600)]
mgr/mgr_util: add to_pretty_timedelta

This mirrors the Ceph C++ implementation.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge PR #28603 into master
Sage Weil [Fri, 24 Jan 2020 14:32:47 +0000 (08:32 -0600)]
Merge PR #28603 into master

* refs/pull/28603/head:
mgr: Add get_rates_from_data to mgr_util.py

Reviewed-by: Sebastian Wagner <swagner@suse.com>
5 years agoMerge PR #32788 into master
Sage Weil [Fri, 24 Jan 2020 14:32:13 +0000 (08:32 -0600)]
Merge PR #32788 into master

* refs/pull/32788/head:
qa/tasks/mgr/dashboard: set pg_num to 32
mgr/pg_autoscaler: default to pg_num[_min] = 32

Reviewed-by: Sage Weil <sage@redhat.com>
5 years agomgr/dashboard: check if user has config-opt permissions (#32638)
Lenz Grimmer [Fri, 24 Jan 2020 14:00:08 +0000 (14:00 +0000)]
mgr/dashboard: check if user has config-opt permissions (#32638)

mgr/dashboard: check if user has config-opt permissions

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agomonitoring: add details to Prometheus' alerts 32803/head
Patrick Seidensal [Thu, 23 Jan 2020 11:52:24 +0000 (12:52 +0100)]
monitoring: add details to Prometheus' alerts

Fixes: https://tracker.ceph.com/issues/43764
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
5 years agoqa/suites/upgrade/*-x/stress-split: run latest python tests at end 32750/head
Sage Weil [Fri, 24 Jan 2020 12:52:41 +0000 (06:52 -0600)]
qa/suites/upgrade/*-x/stress-split: run latest python tests at end

Use the master/test/x branch, so that we run the python3 variant of the
test.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/dashboard: Improve the size of forms (#31863)
Lenz Grimmer [Fri, 24 Jan 2020 12:34:12 +0000 (12:34 +0000)]
mgr/dashboard: Improve the size of forms (#31863)

mgr/dashboard: Improve the size of forms

Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agoMerge pull request #32802 from uweigand/cmake-atomic-check
Nathan Cutler [Fri, 24 Jan 2020 09:40:29 +0000 (10:40 +0100)]
Merge pull request #32802 from uweigand/cmake-atomic-check

cmake: Improve test for 16-byte atomic support on IBM Z

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
5 years agomgr/dashboard: Unit test does not do the mentioned thing (#32799)
Lenz Grimmer [Fri, 24 Jan 2020 08:32:59 +0000 (08:32 +0000)]
mgr/dashboard: Unit test does not do the mentioned thing (#32799)

mgr/dashboard: Unit test does not do the mentioned thing

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
5 years agoqa/tasks/ceph_manager: kludge around /var/log/ceph permissions
Sage Weil [Fri, 24 Jan 2020 03:25:08 +0000 (21:25 -0600)]
qa/tasks/ceph_manager: kludge around /var/log/ceph permissions

The ceph.py task normally makes these permissive.  But a package upgrade
can reset the permissions so that we can't read and write the temp
export files.  (We put them in these dirs now because it's alreadly
mapped out of cephadm containers to the host.)

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agomgr/pg_autoscaler: don't check anything until cluster is nautilus
Sage Weil [Fri, 24 Jan 2020 03:13:58 +0000 (21:13 -0600)]
mgr/pg_autoscaler: don't check anything until cluster is nautilus

This prevents any health alerts about too many/few PGs due to old pools
that are defaulted to 'warn'.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/suites/upgrade: install python3-* as part of final upgrade step
Sage Weil [Thu, 23 Jan 2020 23:35:02 +0000 (17:35 -0600)]
qa/suites/upgrade: install python3-* as part of final upgrade step

These are new packages, so they won't install just by upgrading the old
packages, and they are needed for some of the tests.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/tasks/radosbench: only set object size if != block size
Sage Weil [Thu, 23 Jan 2020 23:27:30 +0000 (17:27 -0600)]
qa/tasks/radosbench: only set object size if != block size

This is mostly pointless, except that the -O option for objects size
used to be -o for pre-octopus, so passing -O breaks the upgrade tests.
Fortunately, the upgrades use the defaults, so we can just skate by here.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoqa/tasks/ceph: simplify mon_health_to_clog suppression during restart
Sage Weil [Thu, 23 Jan 2020 23:12:21 +0000 (17:12 -0600)]
qa/tasks/ceph: simplify mon_health_to_clog suppression during restart

This only does one thing--do that.  More simply.

Signed-off-by: Sage Weil <sage@redhat.com>
5 years agoMerge pull request #32798 from rhcs-dashboard/fix-make-check-deps-centos8
Kefu Chai [Fri, 24 Jan 2020 02:30:15 +0000 (10:30 +0800)]
Merge pull request #32798 from rhcs-dashboard/fix-make-check-deps-centos8

ceph.spec.in: fix 'make check' deps for centos8

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #32478 into master
Patrick Donnelly [Thu, 23 Jan 2020 23:53:24 +0000 (15:53 -0800)]
Merge PR #32478 into master

* refs/pull/32478/head:
qa: update xfstests version
qa: install some dependencies for xfstests

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
5 years agoMerge PR #32754 into master
Sage Weil [Thu, 23 Jan 2020 23:37:56 +0000 (17:37 -0600)]
Merge PR #32754 into master

* refs/pull/32754/head:
mgr/cephadm: health alert for stray hosts and/or services

Reviewed-by: Michael Fritch <mfritch@suse.com>
5 years agoqa: update xfstests version 32478/head
Patrick Donnelly [Thu, 23 Jan 2020 23:37:56 +0000 (15:37 -0800)]
qa: update xfstests version

Building xfstests on CentOS 8 has build errors:

    2020-01-23T21:15:14.939 INFO:tasks.workunit.client.0.smithi155.stderr:/home/ubuntu/cephtest/mnt.0/client.0/tmp/xfstests/src/fssum.c:616: undefined reference to `major'
    2020-01-23T21:15:14.939 INFO:tasks.workunit.client.0.smithi155.stderr:/home/ubuntu/cephtest/mnt.0/client.0/tmp/xfstests/src/fssum.c:617: undefined reference to `minor'
    2020-01-23T21:15:14.940 INFO:tasks.workunit.client.0.smithi155.stderr:collect2: error: ld returned 1 exit status

From: /ceph/teuthology-archive/pdonnell-2020-01-23_20:47:47-fs-wip-pdonnell-testing-20200122.210533-distro-basic-smithi/4697257/teuthology.log

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoqa: install some dependencies for xfstests
Patrick Donnelly [Fri, 3 Jan 2020 23:33:07 +0000 (15:33 -0800)]
qa: install some dependencies for xfstests

These are needed for CentOS 8 / RHEL8.

Also organize the YAML to use the cleaner array syntax.

Fixes: https://tracker.ceph.com/issues/43459
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #32350 into master
Patrick Donnelly [Thu, 23 Jan 2020 23:29:04 +0000 (15:29 -0800)]
Merge PR #32350 into master

* refs/pull/32350/head:
mds: Reorganize class members in SnapServer header

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #32722 into master
Patrick Donnelly [Thu, 23 Jan 2020 23:28:27 +0000 (15:28 -0800)]
Merge PR #32722 into master

* refs/pull/32722/head:
mds: fix null pointer dereference in Server::handle_client_link()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>