mgr/cephadm: unify apply tests

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm: unified add_daemon tests

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm: add cleanup to test_cephadm

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm: remove_service: Feedback, if spec not found

`ceph orch rm my-unknown-service` still returned
`Removed service my-unknown-service`.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34678 from sebastian-philipp/doc-cephadm-install-fix-placement

doc/cephadm: install.rst: fix placement spec.

Reviewed-by: Alexandra Settle <asettle@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #34674 from sebastian-philipp/cephadm-ceph-volume-lock-if-fsid

cephadm: Aquire lock, if fsid != None

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #34620 from mgfritch/cephadm-timeout-test-fixup

qa/workunits/cephadm/test_cephadm.sh: extend timeout test

Merge pull request #34600 from dsavineau/issue_45120

cephadm: fix adopt prometheus command

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #34688 from sebastian-philipp/qa-test-cephadm-octopus-version

qa/workunits/cephadm/test_cephadm: Also test octopus

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #34691 from sebastian-philipp/cephadm-ssk-keyring-check_call

mgr/cephadm: use check_call  for `ssh-keygen`

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #33065 from ifed01/wip-ifed-spurious-readerr-alert

os/bluestore: introduce health alert on spurious read errors.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #34666 from rhcs-dashboard/44405-test-totp-increase-time

mgr/dashboard: fix tasks.mgr.dashboard.test_rgw.RgwBucketTest.test_all

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #34483 from dabukalam/master

doc/rados: Remove obsolete placement group note from EC pool creation

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #33916 from aclamk/fix-bs-avl-memaccounting

os/bluestore: Adds shutdown in destructor of AvlAllocator

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #34559 from tchaikov/wip-19076-refactor

mon/OSDMonitor: refactor loops for better readability

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #34328 from liewegas/cpatch

script/cpatch: initial version

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #34430 from yison/rwl-image-writeback-cache-seq4

rbd/cache: Replicated Write Log core codes part 4

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #34669 from yuvalif/remove_queue_dependency

cls/2pc_queue: remove the dependency of cls_2pc_queue with cls_queue

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #34664 from yuvalif/clarify_topic_creation_format

rgw/doc: clarify topic creation format

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mgr/cephadm: use check_call  for `ssh-keygen`

Mainly to provide any reasonable error

Fixes: https://tracker.ceph.com/issues/44832
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34613 from cbodley/wip-44661

rgw: use DEFER_DROP_PRIVILEGES flag unconditionally

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

qa/workunits/cephadm/test_cephadm: Also test octopus

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34621 from mgfritch/cephadm-test-cleanup

qa/workunits/cephadm/test_cephadm.sh: add CLEANUP var

Merge pull request #34568 from sebastian-philipp/orch-upgrade-usage

mgr/orch: upgrade: better input validation

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #34565 from SUSE/wip-fix-45095

cephadm: handle adopting offline OSDs

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34442 from tspmelo/wip-fix-rgw-bucket-checkbox

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

doc/cephadm: install.rst: fix placement spec.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

cephadm: Aquire lock, if fsid != None

Fixes:

```
Traceback (most recent call last):
  File "./cephadm", line 4494, in <module>
    r = args.func()
  File "./cephadm", line 1077, in _infer_fsid
    return func()
  File "./cephadm", line 1103, in _infer_image
    return func()
  File "./cephadm", line 2813, in command_ceph_volume
    l = FileLock(args.fsid)
  File "./cephadm", line 560, in __init__
    self._lock_file = os.path.join(LOCK_DIR, name + '.lock')
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
```

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #33479 from simon-rock/simon_split_stray

mds : enable fragmentation of stray dir when conditions are met

Merge pull request #34561 from kotreshhr/ceph-fs-status-output

mgr/status: Fix "ceph fs status" json format writing to stderr

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #34546 from varshar16/wip-flake8-cephfs-shell

cephfs-shell: Fix multiple flake8 errors

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #34534 from ajarr/fix-43061

mon/FSCommands: Fix 'add_data_pool' command and 'fs new' command

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #34164 from ukernel/wip-44382

qa/cephfs: update TestClusterFull:test_barrier

Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #33576 from lxbsz/fuse

unshare-ns-mount: add isolating netns for mount helper support

Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #34121 from ADI10HERO/flake8_fix1

cephfs-shell: Fix flake8 errors (F841, E302, E502, E128, E305 and E222)

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>

Merge pull request #34531 from lxbsz/libfuse3

ceph-fuse: link to libfuse3 and pass `-o big_writes` to libfuse if libfuse < 3.0.0

Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #34274 from ukernel/wip-44801

client: reset requested_max_size if file write is not wanted

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

cls/2pc_queue: remove the dependency of cls_2pc_queue with cls_queue

both queues share the same code base, however, cls_2pc_queue should work
even if cls_queue objectclass is not loaded into the osd

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>

mgr/dashboard: fix tasks.mgr.dashboard.test_rgw.RgwBucketTest.test_all

Increased the time for getting 2nd TOTP.

Fixes: https://tracker.ceph.com/issues/44405
Signed-off-by: Alfonso Martínez <almartin@redhat.com>

Merge pull request #34612 from zdover23/wip-doc-tshooting-ssh-errors-44905

doc/cephadm: Add troubleshooting guidance for ssh connection failures. [cephadm]

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34661 from wjwithagen/wjw-fix-rgw_bucket_sync_cache.h

rgw: remove noexcept from function definition

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #34614 from theanalyst/rgw/reshard-num-check

rgw: reshard: skip stale bucket id entries from reshard queue

Reviewed-by: Casey Bodley <cbodley@redhat.com>

rgw: remove noexcept from function definition

Clang complains:
src/rgw/rgw_bucket_sync_cache.h:88:3: error: exception specification of explicitly defaulted copy co
nstructor does not match the calculated one
  Handle(const Handle&) noexcept = default;
  ^
1 error generated.

And a reference that I found for this:
    https://github.com/mapnik/mapnik/issues/3274
Suggesting that the noexcept is inherited from the first definition.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

rgw/doc: clarify topic creation format

also, fix some typos, and 'push-endpoint' parameter

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>

qa/cephfs: add test case for fragmenting stray dirs

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

Merge pull request #34605 from tchaikov/wip-45113

qa/suites/*/rados_cls_all.yaml: load all classes

Reviewed-by: Neha Ojha <nojha@redhat.com>

mds: automatically fragment stray dirs

Signed-off-by: Simon Gao <simon29rock@gmail.com>

Merge pull request #34655 from ceph/wip-yuriw-remove-wip-master

qa/tests: removed tests 'client-upgrade-octopus-pacific'

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

qa/tests: removed tests 'client-upgrade-octopus-pacific'

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #34651 from ceph/wip-yuriw-crontab-master

qa/tests: fixed typo

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

qa/tests: fixed typo

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #34649 from ceph/wip-yuriw-crontab-master

qa/tests: added new clients upgrade tests `client-upgrade-octopus-pacific`

qa/tests: added new clients upgrade tests

`client-upgrade-octopus-pacific` for future 'pacific' release

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #34642 from ceph/wip-yuriw-octopus-client-upgrade-octopus-pacific

qa/tests: initial checkin for clients upgrades tests for future relea…

qa/tests: initial checkin for clients upgrades tests for future release of pacific

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #34608 from trociny/wip-journal-append-stripe-width

cls/journal: use EC pool stripe width for padding appends

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

qa/rgw: allow 'ceph' user to read vault token

Signed-off-by: Casey Bodley <cbodley@redhat.com>

mgr/orch: upgrade: better input validation

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34636 from tchaikov/wip-vstart-runner-py3

qa/tasks/vstart_runner,doc: be compatible with python3

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

cephadm: fix adopt prometheus command

Create the target directory before copy the prometheus configuration.

Closes: https://tracker.ceph.com/issues/45120
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>

qa/tasks/cephfs/fuse_mount.py: by python3 compatible

pass `StringIO()` to capture stdout whose value will be interpreted as a
string later on

Signed-off-by: Kefu Chai <kchai@redhat.com>

Add troubleshooting guidance for ssh connection failures.

For more thorough information about this commit, see:
https://tracker.ceph.com/issues/44905

Signed-off-by: Zac Dover <zac.dover@gmail.com>
Update doc/cephadm/troubleshooting.rst

Co-Authored-By: Michael Fritch <mfritch@suse.com>
ibid

Signed-off-by: Zac Dover <zac.dover@gmail.com>
Update doc/cephadm/troubleshooting.rst

Co-Authored-By: Sebastian Wagner <sebastian@spawnhost.de>
Update doc/cephadm/troubleshooting.rst

Co-Authored-By: Sebastian Wagner <sebastian@spawnhost.de>
Added mgfritch's suggestion regarding checking to see if the public key
is listed in the authorized_keys file.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

pybind/mgr/dashboard/run-backend-api-tests.sh: use python3 by default

since vstart_runner.py is now py3, let's use python3 by default

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks/vstart_runner.py: be python3 compatible

differentiate `str` and `bytes` instances, and drop python2 support from
vstart_runner.py, as we've moved to python3 already

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/suites/*/rados_cls_all.yaml: load all classes

the intention to add the whitelist was to test "sdk" class, but if we
add new classes to the list, and add tests exercising them, the tests
fail if we fail to update these `rados_cls_all.yaml` accordingly.

so in this change, the list is now '*' which allows OSD to load all
classes found in the specified directory

Fixes: https://tracker.ceph.com/issues/45113
Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/dev/developer_guide: use python3 to launch vstart_runner.py

as vstart_runner.py is compatible with python3, and so is the tests
under `qa/` directory.

and use `pip` to install teuthology, simpler this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mds: make MDCache::scan_stray_dir() handle dir fragmentation

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

mds: don't add null dentry to frozen stray dir

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

mds: auth pin stray dir when purging stray inode

After stray inode gets added to purge queue, mds deletes stray dentry.
MDS needs to make sure stray dir is not being fragmented.

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

ceph: allow 'dirfrag split' asok command to operate on stray dirs

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

Merge pull request #34432 from optimistyzy/47_upstream

os/bluestore/NVMEDevice.cc: use slist for tracking mempool

Reviewed-by: Kefu Chai <kchai@redhat.com>

NVMEDevice: Remove the performance counter

Compared with other approach (KernelDevice, iouring), it does not
have such feature, so remove it to simplify the code and improve
the performance. Because, each thread will call the logger and calculate
the time, it is very time consuming. And the upper layer in bluestore has
the feature to track each I/O task.

And it is not readable if we add ifdef configure to enable this feature,
so in my mind that I suggest removing this latency track. And the
latency benefit demonstrated by SPDK is already approved, so we do not
need to tracking every I/O time when invoking SPDK driver.

Signed-off-by: Ziye Yang <ziye.yang@intel.com>

NVMEDevice.cc: Remove the data_buf_mempool

Use the linked list is enough.

Signed-off-by: Ziye Yang <ziye.yang@intel.com>

librbd: add aio_flush test case

Signed-off-by: Peterson, Scott <scott.d.peterson@intel.com>
Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
Signed-off-by: Lu, Yuan <yuan.y.lu@intel.com>
Signed-off-by: Chamarthy, Mahati <mahati.chamarthy@intel.com>

librbd: add aio_flush

Signed-off-by: Peterson, Scott <scott.d.peterson@intel.com>
Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
Signed-off-by: Lu, Yuan <yuan.y.lu@intel.com>
Signed-off-by: Chamarthy, Mahati <mahati.chamarthy@intel.com>

Merge pull request #34615 from dillaman/wip-45072

rbd-mirror: image replayer stop might race with instance replayer shut down

Reviewed-by: Mykola Golub <mgolub@suse.com>

ceph-fuse: link to libfuse3 if fuse3 is installed

Fixes: https://tracker.ceph.com/issues/44891
Signed-off-by: Xiubo Li <xiubli@redhat.com>

rbd-fuse: remove FUSE_CAP_BIG_WRITES when linking to libfuse3

The big-writes is enabled as default from 3.0.

Fixes: https://tracker.ceph.com/issues/44891
Signed-off-by: Xiubo Li <xiubli@redhat.com>

rbd-fuse: switch to use utimens instead

The utime is deprecated.

Fixes: https://tracker.ceph.com/issues/44891
Signed-off-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #34576 from jdurgin/wip-object-corpus

ceph-object-corpus: update to octopus

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #34535 from changchengx/refine_build_liburing

cmake: refactor liburing support

Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph-fuse: enable the big writes as default

When the libfuse version < 3, without the big_writes options enabled
the write perf is very poor.

Fixes: https://tracker.ceph.com/issues/44885
Signed-off-by: Xiubo Li <xiubli@redhat.com>

cstart.sh: work with docker or podman

Signed-off-by: Sage Weil <sage@redhat.com>

src/script/cpatch: complete globs in correct paths

Otherwise none of these libs are copied

Signed-off-by: Josh Durgin <jdurgin@redhat.com>

src/script/cpatch: include cython libs and cephadm

Signed-off-by: Josh Durgin <jdurgin@redhat.com>

src/cstart.sh: initial version

Signed-off-by: Sage Weil <sage@redhat.com>

script/cpatch: initial version

Based on kubejacker.

- copy + strip (tar compress is sloooow)
- avoid touching build artifacts
- by default, patch "everything"
- optionally do actual build as root
- lump rbd and cephfs into core because mgr needs to dynamically link
  them and c++ ABI is fragile.

Signed-off-by: Sage Weil <sage@redhat.com>

qa/workunits/cephadm/test_cephadm.sh: extend timeout test

test occasionally fails when the container is slow to start

Signed-off-by: Michael Fritch <mfritch@suse.com>

test_cephadm.sh: remove unmaintained test_cephadm.sh

the script has become unmaintained and duplicates logic found in
qa/workunits/cephadm/test_cephadm.sh

Signed-off-by: Michael Fritch <mfritch@suse.com>

qa/workunits/cephadm/test_cephadm.sh: add CLEANUP var

preserve the current test state during EXIT:
`CLEANUP=false ../qa/workunits/cephadm/test_cephadm.sh`

Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge pull request #34584 from bk201/wip-45108

mgr/test_orchestrator: fix error when listing services

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #32951 from matthewoliver/cephadm_rgw_ssl

cephadm: add RGW SSL support

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34410 from lxbsz/mds_dirty_parent

tools/cephfs: add accounted_rstat/rstat when building file dentry

Reviewed-by: "Yan, Zheng" <zyan@redhat.com>

Merge pull request #33928 from mchangir/cephfs-journal-tool-cannot-set-dry_run-arg

cephfs-journal-tool: correctly parse --dry_run argument

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

cmake: use cmake module to integrate liburing

1. WITH_LIBURING is used to set HAVE_LIBURING to decide
   use liburing in KernelDevice or not.
2. WITH_SYSTEM_LIBURING is to choose use system installed
   liburing or build the liburing from source code.

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>

Merge pull request #32612 from rishabh-d-dave/fs-qa-UnicodeDecodeError

test_cephfs_shell: fix UnicodeDecodeError

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #33169 from moningchao/master

client: fix blacklist removal failed

Reviewed-by: "Yan, Zheng" <zyan@redhat.com>

Merge pull request #33711 from lxbsz/qa_umount_failed

qa/tasks/cephfs: umount the mountpoints when tearDown

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #34533 from fanjunwei/fix_fuse_bug

client: fix ceph-fuse parse command line failed

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

rbd-mirror: track in-flight start/stop/restart in instance replayer

The shut down waits for in-flight ops to complete but the
start/stop/restart operations were previously not tracked. This
could cause a potential race and crash between an image replayer
operation and the instance replayer shutting down.

Fixes: https://tracker.ceph.com/issues/45072
Signed-off-by: Jason Dillaman <dillaman@redhat.com>