]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 years agoceph.spec.in: claim ownership of include/cephfs/metrics 35360/head
Kefu Chai [Wed, 3 Jun 2020 12:06:52 +0000 (20:06 +0800)]
ceph.spec.in: claim ownership of include/cephfs/metrics

otherwise, "osc build" fails like:

[ 5545s] libcephfs-devel-16.0.0-2172.ga59fb9ffac.x86_64.rpm: directories not owned by a package:
[ 5545s]  - /usr/include/cephfs/metrics

this addresses a regression introduced by
c669de12e076bcedf3fe6cfe52377713f06d7ceb

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #35352 from tchaikov/wip-vstart-runner-create-cluster-only
Kefu Chai [Wed, 3 Jun 2020 09:56:00 +0000 (17:56 +0800)]
Merge pull request #35352 from tchaikov/wip-vstart-runner-create-cluster-only

qa/tasks/vstart_runner: do not teardown test_path if "create-cluster-…

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
5 years agoMerge pull request #35300 from tspmelo/wip-ng-typeahead
Lenz Grimmer [Wed, 3 Jun 2020 08:55:51 +0000 (10:55 +0200)]
Merge pull request #35300 from tspmelo/wip-ng-typeahead

mgr/dashboard: Use ng-bootstrap for Typeahead

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agoMerge pull request #35031 from tspmelo/wip-get-current-summary
Lenz Grimmer [Wed, 3 Jun 2020 08:53:16 +0000 (10:53 +0200)]
Merge pull request #35031 from tspmelo/wip-get-current-summary

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agoMerge pull request #35282 from bk201/wip-45735
Lenz Grimmer [Wed, 3 Jun 2020 08:50:37 +0000 (10:50 +0200)]
Merge pull request #35282 from bk201/wip-45735

monitoring: fixing some issues in RBD detail dashboard

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agoMerge pull request #35320 from sebastian-philipp/cephadm-more-type-annotations
Sebastian Wagner [Wed, 3 Jun 2020 07:52:04 +0000 (09:52 +0200)]
Merge pull request #35320 from sebastian-philipp/cephadm-more-type-annotations

cephadm: Add a bunch of type annotations

Reviewed-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #35262 from jmolmo/cephadm_shared_folders
Sebastian Wagner [Wed, 3 Jun 2020 07:51:31 +0000 (09:51 +0200)]
Merge pull request #35262 from jmolmo/cephadm_shared_folders

cephadm: Make easy manager modules development

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #35069 from sebastian-philipp/qa-cephadm-add-rgw-and-iscsi
Sebastian Wagner [Wed, 3 Jun 2020 07:50:04 +0000 (09:50 +0200)]
Merge pull request #35069 from sebastian-philipp/qa-cephadm-add-rgw-and-iscsi

qa/cephadm: Add RGW

Reviewed-by: Michael Fritch <mfritch@suse.com>
5 years agoMerge pull request #34860 from jschmid1/host_spec_fixes
Sebastian Wagner [Wed, 3 Jun 2020 07:45:09 +0000 (09:45 +0200)]
Merge pull request #34860 from jschmid1/host_spec_fixes

python-common: only validate host_pattern if present

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoqa/tasks/vstart_runner: do not teardown test_path if "create-cluster-only" 35352/head
Kefu Chai [Wed, 3 Jun 2020 01:39:26 +0000 (09:39 +0800)]
qa/tasks/vstart_runner: do not teardown test_path if "create-cluster-only"

otherwise we could be removing a "None" directory when tearing down the cluster,
and have following failure:

Exception ignored in: <bound method LocalContext.__del__ of <__main__.LocalContext object at 0x7f99fd4a6cc0>>
Traceback (most recent call last):
  File "../qa/tasks/vstart_runner.py", line 1189, in __del__
    shutil.rmtree(self.teuthology_config['test_path'])
  File "/tmp/tmp.mmM2ugspuR/venv/lib/python3.6/shutil.py", line 477, in rmtree
    onerror(os.lstat, path, sys.exc_info())
  File "/tmp/tmp.mmM2ugspuR/venv/lib/python3.6/shutil.py", line 475, in rmtree
    orig_st = os.lstat(path)
TypeError: lstat: path should be string, bytes or os.PathLike, not NoneType

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #34288 into master
Patrick Donnelly [Wed, 3 Jun 2020 01:57:28 +0000 (18:57 -0700)]
Merge PR #34288 into master

* refs/pull/34288/head:
mds: flag backtrace scrub failures for new files as okay

Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge pull request #35257 from athanatos/sjust/wip-lba-tree
Kefu Chai [Wed, 3 Jun 2020 01:47:17 +0000 (09:47 +0800)]
Merge pull request #35257 from athanatos/sjust/wip-lba-tree

crimson: TransactionManager and BtreeLBAManager initial implementations

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #34719 into master 35239/head
Patrick Donnelly [Wed, 3 Jun 2020 00:46:26 +0000 (17:46 -0700)]
Merge PR #34719 into master

* refs/pull/34719/head:
ceph-fuse: compatible with libfuse3.5 or higher
cmake: to get the header and library from specified path
libfuse: check the libfuse version from the pkconfig/fuse{3}.pc file

Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #34776 into master
Patrick Donnelly [Wed, 3 Jun 2020 00:44:21 +0000 (17:44 -0700)]
Merge PR #34776 into master

* refs/pull/34776/head:
mgr/volumes: Create subvolume with isolated rados namespace

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #34839 into master
Patrick Donnelly [Wed, 3 Jun 2020 00:42:59 +0000 (17:42 -0700)]
Merge PR #34839 into master

* refs/pull/34839/head:
qa/cephfs: add FUSE module before running mount -t fusectl

Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
5 years agoMerge PR #34942 into master
Patrick Donnelly [Wed, 3 Jun 2020 00:41:29 +0000 (17:41 -0700)]
Merge PR #34942 into master

* refs/pull/34942/head:
tools/cephfs: don't bind to public_addr

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #35034 into master
Patrick Donnelly [Wed, 3 Jun 2020 00:40:00 +0000 (17:40 -0700)]
Merge PR #35034 into master

* refs/pull/35034/head:
ceph_fuse: enable fuse_debug when the '-d' option is specified

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #35057 into master
Patrick Donnelly [Wed, 3 Jun 2020 00:38:46 +0000 (17:38 -0700)]
Merge PR #35057 into master

* refs/pull/35057/head:
pybind/ceph_volume_client: logger.warn() -> logger.warning()

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #35193 into master
Patrick Donnelly [Wed, 3 Jun 2020 00:38:09 +0000 (17:38 -0700)]
Merge PR #35193 into master

* refs/pull/35193/head:
qa/tasks/mds_thrash: s/random.sample/random.choice/

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge PR #35234 into master
Patrick Donnelly [Wed, 3 Jun 2020 00:35:08 +0000 (17:35 -0700)]
Merge PR #35234 into master

* refs/pull/35234/head:
mds: cleanup uncommitted fragments before mds goes to active

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agodoc/dev/seastore.rst: add a bit of information about lba tree etc 35257/head
Samuel Just [Wed, 27 May 2020 03:05:13 +0000 (20:05 -0700)]
doc/dev/seastore.rst: add a bit of information about lba tree etc

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore: add transaction_manager
Samuel Just [Wed, 27 May 2020 01:15:09 +0000 (18:15 -0700)]
crimson/os/seastore: add transaction_manager

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore: add lba_manager interface with btree_lba_manager impl
Samuel Just [Wed, 27 May 2020 01:14:47 +0000 (18:14 -0700)]
crimson/os/seastore: add lba_manager interface with btree_lba_manager impl

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/common: add fixed_kv_node_layout with tests
Samuel Just [Mon, 4 May 2020 18:51:21 +0000 (11:51 -0700)]
crimson/common: add fixed_kv_node_layout with tests

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore/root_block: update to handle relative addresses
Samuel Just [Tue, 26 May 2020 18:17:59 +0000 (11:17 -0700)]
crimson/os/seastore/root_block: update to handle relative addresses

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore/root_block: fix copy constructor
Samuel Just [Tue, 26 May 2020 18:17:14 +0000 (11:17 -0700)]
crimson/os/seastore/root_block: fix copy constructor

Otherwise, we don't appropriately initialize root.

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore/cache: add read clean extents to cache
Samuel Just [Mon, 1 Jun 2020 19:01:40 +0000 (12:01 -0700)]
crimson/os/seastore/cache: add read clean extents to cache

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore/cache: remove unnecessary lambda capture
Samuel Just [Tue, 2 Jun 2020 23:52:13 +0000 (16:52 -0700)]
crimson/os/seastore/cache: remove unnecessary lambda capture

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore/cache.h: actually call complete_load
Samuel Just [Tue, 26 May 2020 18:15:42 +0000 (11:15 -0700)]
crimson/os/seastore/cache.h: actually call complete_load

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore/cache.h: only retire extent if not already retired and not fresh
Samuel Just [Tue, 26 May 2020 18:15:28 +0000 (11:15 -0700)]
crimson/os/seastore/cache.h: only retire extent if not already retired and not fresh

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore/cached_extent: add buffer sharing constructor
Samuel Just [Mon, 1 Jun 2020 19:02:35 +0000 (12:02 -0700)]
crimson/os/seastore/cached_extent: add buffer sharing constructor

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os/seastore/cached_extent.h: fix get_overlap
Samuel Just [Tue, 26 May 2020 18:18:47 +0000 (11:18 -0700)]
crimson/os/seastore/cached_extent.h: fix get_overlap

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocached_extent: add get_crc32 helper
Samuel Just [Fri, 29 May 2020 21:18:29 +0000 (14:18 -0700)]
cached_extent: add get_crc32 helper

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson: distinguish record and block relative paddrs
Samuel Just [Tue, 12 May 2020 04:02:07 +0000 (21:02 -0700)]
crimson: distinguish record and block relative paddrs

Blocks get read independently of the surrounding record,
so paddr's embedded directly in a block need to refer
to other blocks within the same record by a block_relative
addr relative to the block's own offset.  By contrast,
deltas to existing blocks need to use record_relative
addrs relative to the first block of the record.

This patch distinguishes the two kinds of relative paddr
(mainly for debugging purposes) and adapts cache, journal,
etc to use the appropriate types.

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agocrimson/os: port abseil::Layout to C++17
Kefu Chai [Wed, 8 Apr 2020 09:22:19 +0000 (17:22 +0800)]
crimson/os: port abseil::Layout to C++17

and adapt it to our needs

* use C++17 instead of homebrew facilities
* use boost::beast::span for Span

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agocrimson: import abseil::layout
Kefu Chai [Tue, 7 Apr 2020 08:46:51 +0000 (16:46 +0800)]
crimson: import abseil::layout

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoinclude/byteorder.h: add _le signed types
Samuel Just [Thu, 21 May 2020 21:47:15 +0000 (14:47 -0700)]
include/byteorder.h: add _le signed types

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agoMerge PR #26004 into master
Patrick Donnelly [Tue, 2 Jun 2020 20:55:18 +0000 (13:55 -0700)]
Merge PR #26004 into master

* refs/pull/26004/head:
mds: forward mds metrics to ceph manager w/ quering interfaces
mds: track per session client metrics
mds: record metrics from all MDSs in MDS rank 0
mds: non-rank based interface for sending message to an mds
mds: inter-mds ping-pong message and type
mgr: introduce query/report types for ceph metadata server
mds: new intra-mds message type for forwarding aggregated metrics
client: new message type for providing client side metrics

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge pull request #35351 from neha-ojha/wip-45802
Casey Bodley [Tue, 2 Jun 2020 19:08:03 +0000 (15:08 -0400)]
Merge pull request #35351 from neha-ojha/wip-45802

qa/suites/rgw/multisite, qa/suites/rgw/crypt: whitelist PG_AVAILABILITY

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agoMerge PR #34838 into master
Patrick Donnelly [Tue, 2 Jun 2020 19:01:49 +0000 (12:01 -0700)]
Merge PR #34838 into master

* refs/pull/34838/head:
vstart_runner: don't use namespaces by default
qa/cephfs: run nsenter commands with superuser privileges
qa/cephfs: look for mountpoint in cmdline file

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge pull request #35349 from kshtsk/wip-teuthology-branch-master
Ilya Dryomov [Tue, 2 Jun 2020 17:39:38 +0000 (19:39 +0200)]
Merge pull request #35349 from kshtsk/wip-teuthology-branch-master

qa: add .teuthology_branch with `master` contents

Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
5 years agoqa/suites/rgw/multisite, qa/suites/rgw/crypt: whitelist PG_AVAILABILITY 35351/head
Neha Ojha [Tue, 2 Jun 2020 16:58:22 +0000 (16:58 +0000)]
qa/suites/rgw/multisite, qa/suites/rgw/crypt: whitelist PG_AVAILABILITY

This follows b162541ac21e965a304ee6ffe604c43f22fa96c4.
The balancer was turned on by default in
d4fbaf7, as a result of which we might see
PG_AVAILABILITY health warnings when pg-upmap-items are applied.

Fixes: https://tracker.ceph.com/issues/45802
Signed-off-by: Neha Ojha <nojha@redhat.com>
5 years agoqa: add .teuthology_branch with `master` contents 35349/head
Kyr Shatskyy [Tue, 2 Jun 2020 17:05:30 +0000 (19:05 +0200)]
qa: add .teuthology_branch with `master` contents

This is follow up change for:

    teuthology-suite: automate -t argument default value
    https://github.com/ceph/teuthology/pull/1490

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
5 years agoMerge pull request #35321 from tchaikov/wip-rgw-reshard-cleanup
Casey Bodley [Tue, 2 Jun 2020 16:36:34 +0000 (12:36 -0400)]
Merge pull request #35321 from tchaikov/wip-rgw-reshard-cleanup

rgw/reshard: use defined variable

Reviewed-by: Casey Bodley <cbodley@redhat.com>
5 years agorgw/reshard: use defined variable 35321/head
Kefu Chai [Sat, 30 May 2020 04:51:14 +0000 (12:51 +0800)]
rgw/reshard: use defined variable

use the defined reference for more concise code, this silences the
warning like:
```
../src/rgw/rgw_reshard.cc:530:15: warning: unused variable ‘bucket’ [-Wunused-variable]
  530 |   rgw_bucket& bucket = bucket_info.bucket;
      |               ^~~~~~
```

also move `ret` close to where it is used for the first time.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #34782 into master
Patrick Donnelly [Tue, 2 Jun 2020 14:40:39 +0000 (07:40 -0700)]
Merge PR #34782 into master

* refs/pull/34782/head:
qa/tasks/cephfs/mount.py: remove netns name parsing in mountpoint setter
qa/tasks/vstart_runner.py: add kwargs parameter to ignore the ones it does not understand

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoMerge pull request #35264 from pritha-srivastava/wip-rgw-gc-urgent-data-overwrite
Casey Bodley [Tue, 2 Jun 2020 13:42:15 +0000 (09:42 -0400)]
Merge pull request #35264 from pritha-srivastava/wip-rgw-gc-urgent-data-overwrite

cls/rgw_gc: Clearing off urgent data in bufferlist, before

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
5 years agoMerge pull request #35249 from rhcs-dashboard/wip-45705-master
Lenz Grimmer [Tue, 2 Jun 2020 13:11:20 +0000 (15:11 +0200)]
Merge pull request #35249 from rhcs-dashboard/wip-45705-master

mgr/dashboard: add API team to CODEOWNERS

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
5 years agoMerge pull request #35276 from tspmelo/wip-make-langs
Lenz Grimmer [Tue, 2 Jun 2020 13:07:46 +0000 (15:07 +0200)]
Merge pull request #35276 from tspmelo/wip-make-langs

mgr/dashboard: Fix dashboard languages make configuration

Reviewed-by: Stephan Müller <smueller@suse.com>
5 years agovstart_runner: don't use namespaces by default 34838/head
Rishabh Dave [Tue, 2 Jun 2020 10:44:40 +0000 (16:14 +0530)]
vstart_runner: don't use namespaces by default

And add option --usens to vstart_runner.py to use namespaces.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
5 years agoqa/cephfs: run nsenter commands with superuser privileges
Rishabh Dave [Wed, 29 Apr 2020 18:10:16 +0000 (23:40 +0530)]
qa/cephfs: run nsenter commands with superuser privileges

And add a method that sets self.fuse_daemon.subproc.pid to the PID of
the process that doesn't have sudo in its arguments. For example, when
"sudo ceph-fuse /mnt/cephfs" is run on the shell, it launches process
with arguments "ceph-fuse /mnt/cephfs". The added method gets PID of
latter/child process and sets that as the fuse daemon's PID. Not doing
so kills the former/parent process but the not the child process.

Also, since we are around cleanup this method a bit.

Fixes: https://tracker.ceph.com/issues/45339
Signed-off-by: Rishabh Dave <ridave@redhat.com>
5 years agoMerge pull request #35313 from sebastian-philipp/qa-py2-filenotfound
Sebastian Wagner [Tue, 2 Jun 2020 10:58:25 +0000 (12:58 +0200)]
Merge pull request #35313 from sebastian-philipp/qa-py2-filenotfound

qa/cephadm: FileNotFoundError doesn't exist in py2

Reviewed-by: Tim Serong <tserong@suse.com>
5 years agoMerge pull request #35281 from matthewoliver/cephadm_reset_stale_connections
Sebastian Wagner [Tue, 2 Jun 2020 10:57:52 +0000 (12:57 +0200)]
Merge pull request #35281 from matthewoliver/cephadm_reset_stale_connections

cephadm: Detect stale and then recreate connections

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #34879 from Daniel-Pivonka/cephadm_bootstrap_apply_spec
Sebastian Wagner [Tue, 2 Jun 2020 10:54:38 +0000 (12:54 +0200)]
Merge pull request #34879 from Daniel-Pivonka/cephadm_bootstrap_apply_spec

mgr/cephadm: cephadm bootstrap add --apply-spec <cluster.yaml>

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #35124 from jmolmo/wip-doc-update-devices
Sebastian Wagner [Tue, 2 Jun 2020 10:47:54 +0000 (12:47 +0200)]
Merge pull request #35124 from jmolmo/wip-doc-update-devices

doc: New section in device management

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #35330 from yanghonggang/master
Kefu Chai [Tue, 2 Jun 2020 10:35:12 +0000 (18:35 +0800)]
Merge pull request #35330 from yanghonggang/master

msg/Message.cc: fix build error when WITH_BLKIN is on

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #35226 from tchaikov/wip-py3-for-tox
Kefu Chai [Tue, 2 Jun 2020 09:47:24 +0000 (17:47 +0800)]
Merge pull request #35226 from tchaikov/wip-py3-for-tox

qa/tasks/tox: use python3 for tox tests

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agocephadm: Make easy manager modules development 35262/head
Juan Miguel Olmo Martínez [Wed, 27 May 2020 07:57:14 +0000 (09:57 +0200)]
cephadm: Make easy manager modules development

A volume replaces content  in </usr/share/mgr> folder in manager containers.
The new argument <shared_mgr_folder> sets the source folder for the volume

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
5 years agoMerge pull request #35296 from tspmelo/wip-accordion
Lenz Grimmer [Tue, 2 Jun 2020 08:18:55 +0000 (10:18 +0200)]
Merge pull request #35296 from tspmelo/wip-accordion

mgr/dashboard: Remove Accordion imports

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
5 years agomsg/Message.cc: fix build error when WITH_BLKIN is on 35330/head
Yang Honggang [Mon, 1 Jun 2020 05:43:21 +0000 (13:43 +0800)]
msg/Message.cc: fix build error when WITH_BLKIN is on

Signed-off-by: Yang Honggang <yanghonggang@kuaishou.com>
5 years agoMerge pull request #34714 from alfredosola/patch-1
Kefu Chai [Tue, 2 Jun 2020 04:54:14 +0000 (12:54 +0800)]
Merge pull request #34714 from alfredosola/patch-1

doc/rados: fix a typo in troubleshooting-mon.rst

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #35244 from danbev/rados_t-comment
Kefu Chai [Tue, 2 Jun 2020 04:49:39 +0000 (12:49 +0800)]
Merge pull request #35244 from danbev/rados_t-comment

librados: minor improvment to rados_t comment

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge pull request #35168 from CodingSpiderFox/master
Kefu Chai [Tue, 2 Jun 2020 04:44:43 +0000 (12:44 +0800)]
Merge pull request #35168 from CodingSpiderFox/master

doc: clarify WAL in bluestore-config-ref.rst

Reviewed-by: Samuel Just <sjust@redhat.com>
5 years agoMerge pull request #35341 from changchengx/script_cbt
Kefu Chai [Tue, 2 Jun 2020 04:38:31 +0000 (12:38 +0800)]
Merge pull request #35341 from changchengx/script_cbt

scripts/run-cbt.sh: correct script option usage

Reviewed-by: Kefu Chai <kchai@redhat.com>
5 years agomds: flag backtrace scrub failures for new files as okay 34288/head
Milind Changire [Tue, 2 Jun 2020 02:11:39 +0000 (07:41 +0530)]
mds: flag backtrace scrub failures for new files as okay

New, unwritten files, fail when backtracing during scrub.
This is not necessarily bad. So flag such failures as okay and continue
with other entries.

Fixes: https://tracker.ceph.com/issues/43543
Signed-off-by: Milind Changire <mchangir@redhat.com>
5 years agoscripts/run-cbt.sh: correct script option usage 35341/head
Changcheng Liu [Tue, 2 Jun 2020 01:55:41 +0000 (09:55 +0800)]
scripts/run-cbt.sh: correct script option usage

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
5 years agoqa/tasks/tempest: use --black-regex for blacklisting tests 35226/head
Kefu Chai [Sun, 31 May 2020 01:03:12 +0000 (09:03 +0800)]
qa/tasks/tempest: use --black-regex for blacklisting tests

simpler this way

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/keystone: unpin python-openstackclient
Kefu Chai [Sun, 31 May 2020 01:01:39 +0000 (09:01 +0800)]
qa/keystone: unpin python-openstackclient

this reverts 2dac5c5012cffb5f41d7e7457569c6bfdc53ec26,
as we don't use `--os-url` anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/tasks/tempest: use user/pass to authenticate
Kefu Chai [Sun, 31 May 2020 00:54:41 +0000 (08:54 +0800)]
qa/tasks/tempest: use user/pass to authenticate

instead of using admin token use "admin" user to authenticate,
as admin token is not suggested anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/suites/rgw/tempest: update unsupported tests of tempest
Kefu Chai [Sun, 31 May 2020 00:47:34 +0000 (08:47 +0800)]
qa/suites/rgw/tempest: update unsupported tests of tempest

after rerunning tempest with lastest radosgw, remove the supported
tests from the blacklist, and add the ones which are not supported
yet. now we can pass 123 tests in total.

also enable discoverity for better testing coverage, since it's
supported now.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/tasks/keystone: use "keystone-manage bootstrap"
Kefu Chai [Sun, 31 May 2020 00:38:00 +0000 (08:38 +0800)]
qa/tasks/keystone: use "keystone-manage bootstrap"

* qa/tasks/keystone.py:
  instead of prefilling keystone manually, use "keystone-manage bootstrap"
  instead. it helps to setup the admin user, a "Default" domain with
  "default" id, and wire them up with the expected role and a "admin" project,
  etc. as id of the admin domain is known to be "default", we can just use it
  in our tests without querying openstack for the id of "Default"
  domain. this is very handy.
* qa/suites/rgw/tempest/tasks/rgw_tempest.yaml:
  use "Default" for domain name. as "Default" is the name of the domain
  created by bootstrap, while "default" is its id.
* qa/suites/rgw/crypt/2-kms/barbican.yaml:
  remove settings to bootstrap keystone

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/suites/rgw/tempest: use the latest tempest supporting py3.5
Kefu Chai [Thu, 28 May 2020 16:51:39 +0000 (00:51 +0800)]
qa/suites/rgw/tempest: use the latest tempest supporting py3.5

in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/suites/rgw/tempest: bump up keystone to 17.0.0
Kefu Chai [Mon, 25 May 2020 07:52:04 +0000 (15:52 +0800)]
qa/suites/rgw/tempest: bump up keystone to 17.0.0

* also generate a sample conf file following the document at
  https://github.com/openstack/keystone/tree/17.0.0.0rc2/etc
* use "projects" instead of "tenants" to match the terminology used by
  openstack identify API 3.0.
* test API 3.0 instead of API 2.0, by changing
  `rgw_keystone_api_version` from "2" to "3"
* explicitly specify a domain "default" for project to be created,
  otherwise a POST request will fail with:
```
{"error":{"code":400,"message":"You have tried to create a resource using the admin token. As this token is not within a domain you must explicitly include a domain for this resource to belong
to.","title":"Bad Request"}}
````
* create "default" domain, and use it, othewise a GET request fails
  like:
```
2020-05-28T11:17:28.751 INFO:teuthology.orchestra.run.smithi092.stderr:http://smithi092.front.sepia.ceph.com:35357 "GET /v3/domains/default HTTP/1.1" 404 87
2020-05-28T11:17:28.752 INFO:teuthology.orchestra.run.smithi092.stderr:RESP: [404] Content-Length: 87 Content-Type: application/json Date: Thu, 28 May 2020 11:17:28 GMT Server: WSGIServer/0.2
CPython/3.6.9 Vary: X-Auth-Token x-openstack-request-id: req-bc33796f-2bc3-411c-a7fb-1208918e0dbd
2020-05-28T11:17:28.752 INFO:teuthology.orchestra.run.smithi092.stderr:RESP BODY: {"error":{"code":404,"message":"Could not find domain: default.","title":"Not Found"}}
```
* add user to "default" domain when creating it.
* use "type" as the positional argument, per
  https://docs.openstack.org/keystone/pike/admin/cli-keystone-manage-services.html
  otherwise we will have failures like:
```
2020-05-28T13:38:24.867 INFO:teuthology.orchestra.run.smithi198.stderr:openstack service create: error: unrecognized arguments: --type keystone
```
* update `create_endpoint()` to use the V3 API,
  see
  https://docs.openstack.org/python-openstackclient/pike/cli/command-objects/endpoint.html

Fixes: https://tracker.ceph.com/issues/45692
Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/tasks/keystone.py: support multiple positional args
Kefu Chai [Thu, 28 May 2020 15:14:35 +0000 (23:14 +0800)]
qa/tasks/keystone.py: support multiple positional args

it's required when creating endpoint, see
https://docs.openstack.org/python-openstackclient/pike/cli/command-objects/endpoint.html,
where we need to pass <service>, <interface>, and <url>

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/tasks/tox: use the latest stable tox
Kefu Chai [Sun, 24 May 2020 17:07:09 +0000 (01:07 +0800)]
qa/tasks/tox: use the latest stable tox

in hope to avoid any ancient bugs

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoqa/tasks/tox: use python3 for tox tests
Kefu Chai [Sun, 24 May 2020 17:04:37 +0000 (01:04 +0800)]
qa/tasks/tox: use python3 for tox tests

both tempest and keystone have dropped python2 support in their tox
based tests.

Signed-off-by: Kefu Chai <kchai@redhat.com>
5 years agoMerge PR #34672 into master
Patrick Donnelly [Mon, 1 Jun 2020 18:21:34 +0000 (11:21 -0700)]
Merge PR #34672 into master

* refs/pull/34672/head:
qa/tasks/cephfs: Enable multiple exports tests
mgr/nfs: Instead of 'auth del' use 'auth rm'
qa/tasks/cephfs: Don't enable cephadm in TestNFS
qa/tasks/cephfs: Add tests for nfs exports
mgr/volumes/nfs: Fix idempotency of cluster and export commands
mgr/volumes/nfs: Fix incorrect read only access_type value
mgr/fs/nfs: Use check_mon_command() instead of mon_command()
qa/cephfs: Add tests for nfs
mgr/volumes/nfs: Remove type option from export create interface
vstart: Instead of CACHEINODE use MDCACHE
mgr/volumes: Rearrange nfs export interface
mgr/volumes/nfs: Delete common config object on cluster deletion
mgr/volumes/nfs: Delete all exports on cluster deletion
mgr/volumes: Make nfs create export interface idempotent
vstart: Add watch url for conf-nfs object
mgr/volumes/nfs: Delete user on removing export
mgr/volumes: Create user for given path and fs
vstart: Ensure cephadm and NFS does not conflict
vstart: Update details about ganesha packages
mgr/volumes/nfs: Add delete cephfs export command
mgr/volumes/nfs: Add RADOS notify for common config object
mgr/volumes/nfs: Pass cluster_id directly to NFSCluster {create, update, delete} methods
mgr/volumes: Add nfs cluster delete interface
mgr/volumes: Add nfs cluster update interface
vstart: Enable test_orchestrator in start_ganesha()
mgr/volumes: Add placement option to create nfs cluster interface
mgr/volumes/nfs: Change common ganesha config object name to 'conf-nfs.ganesha-<cluster_id>'
mgr/volumes/nfs: Call orch nfs apply

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
5 years agoqa/cephfs: look for mountpoint in cmdline file
Rishabh Dave [Tue, 26 May 2020 11:10:29 +0000 (16:40 +0530)]
qa/cephfs: look for mountpoint in cmdline file

Look for self.mountpoint in the contents of /proc/<pid>/cmdline file
when finding asok file for the client so that vstart_runner.py won't end
up picking asok file for a client not created in current run.

This usually never happens so far because PID of newly created processes
is higher than that of previously created processes and list of asok
files returned by "glob.glob(asok_path)" in find_socket() is in
descending order of PIDs.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
5 years agoMerge pull request #35334 from changchengx/rwl_code_clean
Jason Dillaman [Mon, 1 Jun 2020 16:27:42 +0000 (12:27 -0400)]
Merge pull request #35334 from changchengx/rwl_code_clean

librbd/rwl: remove extra ';' after defining function

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge pull request #35336 from tchaikov/wip-clang-cache
Kefu Chai [Mon, 1 Jun 2020 14:45:46 +0000 (22:45 +0800)]
Merge pull request #35336 from tchaikov/wip-clang-cache

pybind/*/setup.py: fix clang detection with ccache

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 years agoMerge pull request #35332 from idryomov/wip-rbd-read-flags
Jason Dillaman [Mon, 1 Jun 2020 12:14:17 +0000 (08:14 -0400)]
Merge pull request #35332 from idryomov/wip-rbd-read-flags

librbd: make rbd_read_from_replica_policy actually work

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agopybind/*/setup.py: fix clang detection with ccache 35336/head
Samuel Just [Tue, 19 May 2020 19:33:44 +0000 (12:33 -0700)]
pybind/*/setup.py: fix clang detection with ccache

Signed-off-by: Samuel Just <sjust@redhat.com>
5 years agolibrbd/rwl: remove extra ';' after defining function 35334/head
Changcheng Liu [Mon, 1 Jun 2020 08:43:14 +0000 (16:43 +0800)]
librbd/rwl: remove extra ';' after defining function

Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
5 years agomds: forward mds metrics to ceph manager w/ quering interfaces 26004/head
Venky Shankar [Tue, 10 Sep 2019 13:53:09 +0000 (09:53 -0400)]
mds: forward mds metrics to ceph manager w/ quering interfaces

`MetricAggregator` sets up manager callback to forward metrics
data to ceph-mgr. Also, add querying interfaces for adding and
removing user queries and a simple interface to fetch MDS perf
metrics.

Fixes: http://tracker.ceph.com/issues/36253
Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomds: track per session client metrics
Venky Shankar [Mon, 4 Feb 2019 13:19:58 +0000 (18:49 +0530)]
mds: track per session client metrics

Every MDS maintains a view of metrics that are forwarded to
it by clients. This is updated when clients forward metrics
via MClientMetrics message type. Periodically, each MDS
forwards its collected metrics to MDS rank 0 (which maintains
an aggregated view of metrics of all clients on all ranks).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomds: record metrics from all MDSs in MDS rank 0
Venky Shankar [Mon, 5 Aug 2019 09:32:28 +0000 (05:32 -0400)]
mds: record metrics from all MDSs in MDS rank 0

`MetricAggregator` class aggregates metrics from all active ranks
and places metrics appropriately as defined by user queries.

This is implemented as a separate dispatcher since metric update
messages from active MDSs are frequent so as to avoid messages
getting stuck in MDSRank queue (suggested by Patrick).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomds: non-rank based interface for sending message to an mds
Venky Shankar [Wed, 6 May 2020 07:17:15 +0000 (03:17 -0400)]
mds: non-rank based interface for sending message to an mds

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomds: inter-mds ping-pong message and type
Venky Shankar [Sun, 6 Oct 2019 15:25:25 +0000 (11:25 -0400)]
mds: inter-mds ping-pong message and type

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomgr: introduce query/report types for ceph metadata server
Venky Shankar [Tue, 10 Sep 2019 13:50:37 +0000 (09:50 -0400)]
mgr: introduce query/report types for ceph metadata server

These types will be used for supporting user define querying
from ceph-mgr.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agomds: new intra-mds message type for forwarding aggregated metrics
Venky Shankar [Mon, 21 Jan 2019 06:03:19 +0000 (01:03 -0500)]
mds: new intra-mds message type for forwarding aggregated metrics

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agoclient: new message type for providing client side metrics
Venky Shankar [Thu, 17 Jan 2019 06:52:46 +0000 (01:52 -0500)]
client: new message type for providing client side metrics

Signed-off-by: Venky Shankar <vshankar@redhat.com>
5 years agolibrbd: make rbd_read_from_replica_policy actually work 35332/head
Ilya Dryomov [Sat, 30 May 2020 17:03:20 +0000 (19:03 +0200)]
librbd: make rbd_read_from_replica_policy actually work

Commit d92be8b5856d ("librbd: Improved support for balanced and
localized reads") introduced read_flags, but used low-level Objecter
flags (CEPH_OSD_FLAG_*).  This is wrong because librbd sits on top of
librados, not Objecter.  "balance" ends up being translated into
IGNORE_REDIRECT and "localize" being ignored.

Fixes: https://tracker.ceph.com/issues/45798
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 years agoMerge pull request #35301 from dillaman/wip-45715
Mykola Golub [Sat, 30 May 2020 11:46:49 +0000 (14:46 +0300)]
Merge pull request #35301 from dillaman/wip-45715

librbd: Watcher should not attempt to re-watch after detecting blacklisting

Reviewed-by: Mykola Golub <mgolub@suse.com>
5 years agocephadm: Add a bunch of type annotations 35320/head
Sebastian Wagner [Fri, 29 May 2020 23:20:42 +0000 (01:20 +0200)]
cephadm: Add a bunch of type annotations

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
5 years agoMerge pull request #35138 from maydaycc/wip-45313
Jason Dillaman [Fri, 29 May 2020 20:32:05 +0000 (16:32 -0400)]
Merge pull request #35138 from maydaycc/wip-45313

librbd: support duration controllable continuous burst

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agoMerge pull request #35173 from trociny/wip-group-quiesce
Jason Dillaman [Fri, 29 May 2020 19:46:34 +0000 (15:46 -0400)]
Merge pull request #35173 from trociny/wip-group-quiesce

librbd: quiesce/unquiesce support for group_snap_create

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
5 years agolibrbd: support duration controllable continuous burst 35138/head
Wencong Wan [Tue, 19 May 2020 18:23:01 +0000 (02:23 +0800)]
librbd: support duration controllable continuous burst

Modify the design of token bucket to save more tokens than burst value,
so as to support continuous burst. The desired burst duration can be
controlled by rbd_qos_XYZ_burst_seconds.

Fixes: https://tracker.ceph.com/issues/45313
Signed-off-by: wencong wan <wanwc@chinatelecom.cn>
5 years agoqa/tasks/cephfs: Enable multiple exports tests 34672/head
Varsha Rao [Fri, 29 May 2020 18:06:34 +0000 (23:36 +0530)]
qa/tasks/cephfs: Enable multiple exports tests

Signed-off-by: Varsha Rao <varao@redhat.com>
5 years agomgr/nfs: Instead of 'auth del' use 'auth rm'
Varsha Rao [Fri, 29 May 2020 17:54:54 +0000 (23:24 +0530)]
mgr/nfs: Instead of 'auth del' use 'auth rm'

`mgr` profile allows 'auth rm'. Use it instead of 'auth del' which is not
allowed.

Signed-off-by: Varsha Rao <varao@redhat.com>
5 years agomgr/dashboard: Use ng-bootstrap for Typeahead 35300/head
Tiago Melo [Thu, 28 May 2020 20:18:55 +0000 (20:18 +0000)]
mgr/dashboard: Use ng-bootstrap for Typeahead

Removed semicolon tslint rule, since it was conflicting with prettier.

Fixes: https://tracker.ceph.com/issues/45756
Signed-off-by: Tiago Melo <tmelo@suse.com>