install-deps.sh: do not enable unavailable repos

should be specific when enabling codeready-builder repos, there is
chance that some repos are just not available, while the required one
is. for instance, "codeready-builder-for-rhel-8-x86_64-eus-debug-rpms"
might not be available. and in that case, `install-deps.sh` just fails.

so in this change, only the required one is enabled. see also
https://fedoraproject.org/wiki/EPEL

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #32288 into master

* refs/pull/32288/head:
test_cephfs_shell: remove test_every_shell_cmd_at_invocation
test_cephfs_shell: catch specific exception instead of catching all
cephfs-shell: set return value before exiting
test_cephfs_shell: re-arrange TestCephFSShell's methods
cephfs-shell: re-arrange code under __main__
test_cephfs_shell: add new test for shell cmd at invocation
cephfs-shell: launch shell only if there are no args following

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>

Merge pull request #35307 from aclamk/wip-rocksdb-sharding-dump

kv/RocksDBStore: Fixes dump of batch commited to rocksdb

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #35562 from tchaikov/wip-drop-copr-repo

install-deps.sh: drop ktdreyer/ceph-el8 copr repo

Reviewed-by: David Galloway <dgallowa@redhat.com>

Merge pull request #35602 from tchaikov/wip-vstart-ganesha-comment

vstart.sh: update comment to use ganesha from CentOS Storage SIG

Reviewed-by: Varsha Rao <varao@redhat.com>

Merge pull request #35510 from mgfritch/cephadm-bootstrap-timeout

cephadm: increase is_available timeout 30s -> 60s

Merge pull request #35585 from tchaikov/wip-test-mgr-dashboard-smoke-random-port

test/mgr/mgr-dashboard-smoke: listen on random ports

Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #35366 from tspmelo/wip-npm-20-05

mgr/dashboard: Update npm packages

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>

Merge pull request #35557 from dillaman/wip-librbd-asio

librbd: initial boost asio integration

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #35412 from sebastian-philipp/doc-cephadm-concepts-fqdn

doc/cephadm: Add chapter about FQDNs

Reviewed-by: Daniel-Pivonka <dpivonka@redhat.com>
Reviewed-by: Thomas Bechtold <tbechtold@suse.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>

vstart.sh: update comment to use ganesha from CentOS Storage SIG

see https://download.nfs-ganesha.org/3/LATEST/RHEL/

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/mgr/mgr-dashboard-smoke: listen on random ports

in hope to reduce the chance to listen an already used port while
running multiple "make check" instances in parallel.

See-also: http://tracker.ceph.com/issues/36737
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35524 from sebastian-philipp/cephadm-rm-container-storage

cephadm: call `podman rm --storage`

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35317 from dsavineau/doc_radosgw_key_typo

doc/radosgw/admin: fix key subuser typo

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #35541 into master

* refs/pull/35541/head:
doc/dev: mention -l, -e and -n among useful options
doc/dev: add info on how to retest QA changes without rebuilding

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

doc/cephadm: Add chapter about FQDNs

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: Update npm packages

Fixes: https://tracker.ceph.com/issues/45949
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35561 from tchaikov/wip-crimson-disable-bluestore-with-allocator

crimson/os: disable alienized bluestore if using seastar allocator

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #35472 from varshar16/wip-vstart-stop-cephadm

stop.sh: Kill cephadm deployed daemons

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

cephadm: call `podman rm --storage`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

crimson/os: disable alienized bluestore if using seastar allocator

before figuring out how to colocate alien store and seastar's builtin
allocator. we need to disable alienized bluestore, if
SEASTAR_DEFAULT_ALLOCATOR is not defined.

See-also: https://tracker.ceph.com/issues/45985
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 3dd052c4558144d7252aa8a856c1601ea17b74e7)

install-deps.sh: drop ktdreyer/ceph-el8 copr repo

as all python3-cherrypy and its deps are included by EPEL8 now

Signed-off-by: Kefu Chai <kchai@redhat.com>

rbd-mirror: swapped ThreadPool/ContextWQ for AsioEngine

The majority of usage of ContextWQ has been switched to use the
ASIO ContextWQ adapter class. The journal remains the only
remaining use of dedicated ThreadPools in rbd-mirror.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: swapped ThreadPool/ContextWQ for AsioEngine

The majority of usage of ContextWQ has been switched to use the
ASIO ContextWQ adapter class. The journal, RWL cache, and image update
notifications remain the only remaining use of dedicated ThreadPools in
librbd.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: wrapper class for ContextWQ

Numerous state machines in librbd utilize ContextWQ for handling deferred
completion work. Now that we have an ASIO thread pool, we want to remove
the older ThreadPool/WorkQueue implementation. To avoid massive refactoring,
this ContextWQ will mimic the interface of the old ContextWQ class but
utilize ASIO for dispatching.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35538 from bk201/wip-45155

mgr/cephadm: set Ganesha pool/namespace settings in the Dashboard

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35474 from sebastian-philipp/python-common-hostspec

mgr/orch: move HostSpec to python-common

Reviewed-by: Joshua Schmid <jschmid@suse.de>

Merge PR #33406 into master

* refs/pull/33406/head:
libcephfs/pybind: Add truncate, ftruncate
libcephfs/pybind: Add get_layout, get_default_pool
libcephfs/pybind: Add setattrx, fsetattrx
libcephfs/pybind: Add pwritev, preadv
libcephfs/pybind: Add rewinddir, telldir, seekdir
libcephfs/pybind: Add set_uuid, set_session_timeout
libcephfs/pybind: Add debug_get_fd_caps, debug_get_file_caps, get_cap_return_timeout
libcephfs/pybind: Add get_pool_id, get_pool_replication
libcephfs/pybind: Add get_file_replication, get_path_replication
libcephfs/pybind: Add lazyio, lazyio_propagate, lazyio_synchronize
libcephfs/pybind: Add fallocate, mknod
libcephfs/pybind: Add lsetxattr, lremovexattr, lgetxattr, llistxattr
libcephfs/pybind: Add fsetxattr, fgetxattr, fremovexattr, flistxattr
libcephfs/pybind: Add fchown, fchmod

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge PR #34716 into master

* refs/pull/34716/head:
mgr/volumes: Add snapshot info command

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>

Merge PR #35261 into master

* refs/pull/35261/head:
qa/vstart_runner.py: ignores when source and destination are same

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>

Merge PR #35368 into master

* refs/pull/35368/head:
fuse: update to newer FUSE_USE_VERSION

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #35519 from kshtsk/wip-remove-t-py2

qa/crontab: remove -t py2 from schedule

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>

cephadm: only SIGKILL once during timeout

no need to continually SIGKILL a process that is already exiting

Signed-off-by: Michael Fritch <mfritch@suse.com>

cephadm: add profile log line to Popen wrappers

add debug log line to profile the Popen wrapper read loop
exec runtime, exitcode, stop, fds to read, etc.

Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge pull request #35536 from icepic/patch-1

doc/dev/deduplication.rst: fix a spelling nit

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/dev/deduplication.rst: fix a spelling nit

Signed-off-by: Janne Johansson <icepic.dz@gmail.com>

mgr/cephadm: set Ganesha pool/namespace settings in the Dashboard

- Config Ganesha pool and namespace settings in Dashboard.
- New `config_dashboard` option in cephadm. If the flag is Flase,
  cephadm won't manage Dashboard settings for daemons. This might be
  useful when users want to config API URLs by themselves or for debugging.

Fixes: https://tracker.ceph.com/issues/45155
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

librbd: replaced ImageCtx::get_thread_pool_instance

Callers have never needed the actual ThreadPool which is being
removed. Refactored into ImageCtx::get_work_queue method.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: simple ASIO execution context

This initial execution context wrapper will start "rbd_op_threads"
number of threads and bind them to an ASIO io_context to be used for
processing async callbacks.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35544 from neha-ojha/wip-reduce-noise

qa/tasks/ceph_manager.py: dump more useful info before failing

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #35545 from LenzGr/doc-troubleshooting-community

doc: Updated mailing list addresses

stop.sh: Remove cephadm deployed daemons

Fixes: https://tracker.ceph.com/issues/44746
Signed-off-by: Varsha Rao <varao@redhat.com>

doc: Updated mailing list addresses

The "Community" chapter of the RADOS troubleshooting section
was still pointing to the old mailing list addresses.

Updated to point to the new ceph.io addresses.

Signed-off-by: Lenz Grimmer <lgrimmer@suse.com>

qa/tasks/ceph_manager.py: dump more useful info before failing

Add helpers that dump information only about PGs that haven't reached
the desired state when we fail. Previously we dumped the output of
"ceph pg dump" before failing, which prints a lot of unnecessary information
about PGs that are not responsible for the failure, making debugging harder.

Also, try to make the failure messages distinct.

Signed-off-by: Neha Ojha <nojha@redhat.com>

doc/dev: mention -l, -e and -n among useful options

Signed-off-by: Rishabh Dave <ridave@redhat.com>

doc/dev: add info on how to retest QA changes without rebuilding

Add a section to "Running tests using teuthology" in "Developer's Guide"
that explains how to retest a branch without rebuilding binaries.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #34380 from jdkruzr/patch-1

doc/man: Update mount.ceph.rst for clarity

Reviewed-by: Jeff Layton <jlayton@redhat.com>

mgr/test_orchestrator: Provide proper get_hosts_func

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35504 from zdover23/wip-doc-cephadm-ssh-key-setup-2020-Jun

doc/cephadm: Importing existing ssh keys

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35526 from tchaikov/wip-qa-krbd-whitelist-mon-down

qa/suites/krbd: whitelist MON_DOWN health warning

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #35521 from sebastian-philipp/dashboard-mgr-module-option-default-value-none-for-it-or-float

mgr/dashboard: fix None value for ints and floats

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #35318 from ifed01/wip-ifed-fix-ex-frag-test

test/objectstore/store_test: kill ExcessiveFragmentation test case.

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #35502 from wjwithagen/wjw-fix-cls-le32

cls: fix missing __le32 definition

Reviewed-by: Sage Weil <sage@newdream.net>

Merge pull request #35486 from jdurgin/wip-radosbench-qa

qa/tasks/radosbench: use long form of option for compatibility

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #35258 from majianpeng/bluefs-flush-use-force

os/bluestore/BlueFS: force flush when call flush().

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #35478 from idryomov/wip-populate-watchers-replica

osd/PrimaryLogPG: don't populate watchers if replica

Reviewed-by: Samuel Just <sjust@redhat.com>

qa/suites/krbd: whitelist MON_DOWN health warning

see also

- 93de19adcf1233ce4c68f1253e0b9abef6d97a9d
- 608e002195638e80323780f1907db40c0b9768f0

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #35530 into master

* refs/pull/35530/head:
vstart: set $CEPH_CONF when running ganesha-rados-grace

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

vstart: set $CEPH_CONF when running ganesha-rados-grace

...otherwise we could pick up the wrong ceph.conf file. Also, use the
correct $test_user userid for these ops.

Fixes: https://tracker.ceph.com/issues/45971
Signed-off-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #35459 from sebastian-philipp/orch-apply-unknown-type

mgr/orch: apply: Fix proper error when passed unknown type

Reviewed-by: Michael Fritch <mfritch@suse.com>

mgr/dashboard: pylint: reduce number of branches

fixes: `R0912: Too many branches (14/12) (too-many-branches)`
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: fix None value for ints and floats

Fixes: https://tracker.ceph.com/issues/45963
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35007 from rhcs-dashboard/fix-36354-master

mgr/dashboard: work with v1 RBD images

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

qa/crontab: remove -t py2 from schedule

After automating teuthology branch selection we do not need
to provide it exclusively with teuthology-suite.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

Merge pull request #35371 from yuriw/wip-yuriw-crontab-master

qa/tests: Changed -t from `py2` to default for `octopus`

Merge pull request #35455 from Conan-Kudo/ceph-libexec

rpm, deb: Use /usr/libexec for libexecdir whenever possible

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35357 from yison/rwl-fix-deadlock-on-ut-issue

rbd/cache: fix deadlock on RWL unit test

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35425 from dzafman/wip-44314

test: osd-backfill-stats.sh use nobackfill to avoid races in remainin…

Reviewed-by: Neha Ojha <nojha@redhat.com>

cephadm: increase is_available timeout 30s -> 60s

bootstrap fails because `ceph -s` might take longer
than 30 sec to return on resource limited hardware

Fixes: https://tracker.ceph.com/issues/45961
Signed-off-by: Michael Fritch <mfritch@suse.com>

qa/tasks/radosbench: use long form of option for compatibility

Since the short version of --object-size changed from -o to -O, it
does not work with upgrade tests.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>

Revert "qa/tasks/radosbench: only set object size if != block size"

This reverts commit fb991fa5f62c4aaa6c564a6d15aeee4bfaa33b39.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Conflicts:
qa/tasks/radosbench.py - extra context from -t, trivial resolution

Revert "qa/tasks/radosbench: fix usage of -O"

This reverts commit da19fd14dbe8bdb62ce376d9df7bf5578f169b9c.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Conflicts:
qa/tasks/radosbench.py - concurrency arg added in context, trival resolution

Merge pull request #35099 from sebastian-philipp/doc-orch-update-specs

doc/orch: How to update an existing specification

Reviewed-by: Alexandra Settle <asettle@suse.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>

cls: fix missing __le32 definition

On platforms that do not the __le* definitions it throws a compiler error.

fixes: https://github.com/ceph/ceph/pull/35186
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #35506 from rzarzynski/wip-crimson-thread-comment-fix

crimson/thread: fix comment phrasing in ThreadPool.h.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #34492 from xxhdx1985126/wip-crimson-recovery-block-io-pr

crimson/net: fix system shutdown problems

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/cephadm: Import existing ssh key docs.

This commit supersedes the commit below, which was suggested by
mohnewald:

https://github.com/ceph/ceph/pull/34453/commits/1cd278b08a342df1acf9b43dbc5c27ee686149c0

Co-author: https://github.com/mohnewald

Signed-off-by: Zac Dover <zac.dover@gmail.com>

test/objectstore/store_test: kill ExcessiveFragmentation test case.
This test case was introduced by https://github.com/ceph/ceph/pull/18494
to verify allocation failure handling while gifting during bluefs rebalance
Not it looks outdated as there is no periodic gifting any more.

Fixes: https://tracker.ceph.com/issues/45788
Signed-off-by: Igor Fedotov <ifedotov@suse.com>

crimson/thread: fix comment phrasing in ThreadPool.h.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #35423 from scoopex/master

tools/histogram_dump: improve io-latency and -size statistics

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35187 from CodingSpiderFox/patch-3

doc: Introduce the concept of a pool before talking about it.

Merge pull request #32705 from petrutlucian94/windows.3

include,common: Windows support [part 3]

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35422 from adamemerson/wip-45878

osdc: Fix crash on OSD failure

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #33720 from yunfeiguan/wip-44409

log: fix timestap precision of log can't set to millisecond.

Reviewed-by: Adam Emersen <aemerson@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #34667 from aclamk/wip-rocksdb-reshard

Resharding tool for sharded rocksdb

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #35186 from liewegas/wip-cas

cls_cas: misc cleanup, and dynamic chunk_refs_t

Reviewed-by: Samuel Just <sjust@redhat.com>

tools/histogram_dump: improve io-latency and -size statistics

The script is part of the ceph distribution but not
part of the official tooling. Nevertheless it was useful to understand
the usage scenarios of my osds.

- add colors to the output to ease interpretation
- add possibility to specify one ore more sockets
- aggregate statistics over multiple sockets
- prevent stacktrace if tool is interrupted by SIGINT
- add possibility to specify the number of data collection
  seconds between loops
- raise loop_seconds default

Signed-off-by: Marc Schoechlin <ms-github@256bit.org>

doc/orch: How to update an existing specification

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34633 from sebastian-philipp/cephadm-total-scheduler

mgr/cephadm: make scheduling make sense

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #35460 from agayev/fix-cmake

blk: Add missing PUBLIC keyword to target_link_libraries command.

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35095 from tchaikov/wip-kefu-onode-v1

crimson/os: add onode node implementation

Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/os: add OnodeBlock

used for representing the an node of onode tree

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: add crimson::gtest target

instead re-compiling gtest_seastar.cc, better off creating a static
library and link against it instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson: add node implementation for onode tree

* node_t and friends are representations of in-mem and on-disk onode
  block/page/node. it might have different names in different contexts.
  but normally, they are the same thing and are loaded as a logical
  cached extent.
* delta_t holds the mutations against a given node onode. they are
  applied to memory once they are committed to disk as part of the
  log record.

regarding to the name of "simple-fltree", it is a short for simple
Flexible Layout Fixed Tree, which was designed by Samuel Just. My
implementation is a naive implementation of this design. But it
tries to be extensive and should be able to adapt to different policies
for rebalancing nodes when overflow/underflow. But there could be
other variant of flexible layout tree implementations in future,
so i added "simple" prefix.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/os: extract onode.h out

so the concrete onode manager implementation can include it without
including the onode_manager.h interface as a whole

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/os/seastore: add ObjectStore and OnodeManager stubs

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #33878 from theanalyst/rgw/cleanup/user-policy-append

rgw: append user policies to existing policies

Reviewed-by: Pritha Srivastava <prsivas@redhat.com>
Reviewed-by: Adam Emersen <aemerson@redhat.com>

Merge pull request #33521 from linuxbox2/wip-getset-ver-nosuch

rgw: fail when get/set-bucket-versioning attempted on a non-existent …

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #33511 from theanalyst/rgw/append-gc-fixes

rgw: append obj: prevent tail from being GC'ed

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #33492 from prasakri/multisite-sync-check

RGW:Multisite: Verify if the synced object is identical to source

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>