msg/msg_types: entity_addrvec_t: fix decode on big-endian hosts

When decoding an entity_addrvec_t with marker 1, we just have
a single (non-legacy) entity_addr_t.  This should be decoded
exactly the same as done by entity_addr_t::decode, but it
currently is not.  Specifically, the sa_family member of
the sockaddr is not converted from the on-wire little-endian
format to host byte order (as done by entity_addr_t::decode).

Fixed by using the same code as in entity_addr_t::decode.

Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>

Merge pull request #35859 from tspmelo/wip-remove-ngx-bootstrap

mgr/dashboard: Remove ngx-bootstrap

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #35875 from Devp00l/wip-46303

mgr/dashboard: Fixes regression in device selection modal

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35912 from tchaikov/wip-crimson-osd-flush-pg-stats

crimson/osd: implement flush_pg_stats command

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #35374 from jschmid1/activate_osdspec_affinity

mgr/cephadm: re-enable osdspec affinity passing

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

crimson/osd: avoid `-Wunused-but-set-variable` warning

in release build, `found` is not used at all. but GCC complains with a
`-Wunused-but-set-variable` warning.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35704 from Devp00l/wip-46135

mgr/dashboard: Fixes typeahead regression in the silence matcher

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

crimson/osd: update the osd stats with hb peers

just to align with classic OSD

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: implement flush_pg_stats command

this command is used by teuthology based tests for updating the mgr with
the lastes pg stats on OSD.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/{mgr,osd}: add WithStats::update_stats()

because we need to implement a tell command which forces osd to
send the latest pg stats to mgr, and the command returns the user with
the sequence id of the report, and `mgr::Client::report()` does not
return a future, so we have to update the seq id before sending
the report. the solution is to update the seq id in a separated
method, so in this change:

* add `const` to `WithStats::get_stats()
* add a dedicated method of `WithStats::update_stats()` to update
  the stats to be collected by mgr::Client.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35887 from joscollin/wip-update-kyr

.githubmap: add Kyr

Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>

Merge pull request #35845 from tchaikov/wip-rpm-crimson

rpm: package crimson-osd in ceph-osd

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #35867 from jwilk-forks/spelling

doc/dev/osd_internals: fix typos

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #35894 from tchaikov/wip-crimson-os

crimson/os: pin the last cpu core for the alien worker threads

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>

Merge pull request #35745 from votdev/issue_46146_delete_host

mgr/dashboard: Host delete action should be disabled if not managed by Orchestrator

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #35642 from tspmelo/wip-fix-flicker

mgr/dashboard: Re-enable OSD's table autoReload

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #34889 from votdev/issue_43120_tabs

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

crimson/os/alienstore: assert on failure

before we have a failure recovery, better off failing fast.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/os: pin the last cpu core for the alien worker threads

before this change, we assume that we have at least current_shared + 10
cores. but that's not always true. so in this change, the last core
is used for performing the alien tasks scheduled by reactor.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: stay on active tab (accessible via URL)

This PR refactors the /monitoring page by introducing a new component which is responsible for rendering the tabs. All tabs have a dedicated route/URL now, no fragments are used anymore, thus they will act like the iSCSI and RBD pages.

Fixes: https://tracker.ceph.com/issues/45375
Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #35816 from idryomov/wip-msgr21-fix-reuse

msg/async/ProtocolV2: take care of features when replacing the socket

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #35854 from tspmelo/wip-fix-nfs-loading

mgr/dashboard: Fix NFS Edit page loading problem

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #35823 from bk201/wip-46245

mgr/cephadm: reconfig ssh after setting or clearing ssh_config

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35765 from votdev/issue_46145_reset_action_button

mgr/dashboard: Action button is not reset after switching tabs

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35803 from s0nea/wip-dashboard-remove-formatted-attr

mgr/dashboard: remove cdCopy2ClipboardButton `formatted` attribute

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #35828 from votdev/issue_46249_rm_tab

mgr/dashboard: Remove useless tab in monitoring/alerts datatable details

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35564 from rhcs-dashboard/wip-45957-fixUiApiEndpoints

mgr/dashboard: fix ui api endpoints

.githubmap: add Kyr

Signed-off-by: Jos Collin <jcollin@redhat.com>

Merge pull request #35639 from joscollin/wip-fix-sh-as-in-teuthology

qa/tasks: make sh() in vstart_runner.py identical with teuthology.orchestra.remote.sh

Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #35037 from CongMinYin/qa-test-for-immutale-object-cache

qa: add tests for immutable object cache

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

librbd/image: fix immutable object cache read failed bug when daemon down

Fix bug: read child image failed when enabling immutable object cache and daemon down

Signed-off-by: Yin Congmin <congmin.yin@intel.com>

qa: add tests for immutable object cache

based on qemu task, use immutable_object_cache task to test parent cache
based on rbd_fio task, use immutable_object_cache task to test parent cache

Signed-off-by: Yin Congmin <congmin.yin@intel.com>
Signed-off-by: Feng Hualong <hualong.feng@intel.com>

Merge pull request #35699 from fflorens/ff/work/bug_46139

osd/OSDCap: rbd profile permits use of "rbd_info"

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35596 from Songweibin/wip-fix-rbd-rm

librbd: fix potential image rm failure due to parent missing

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

mgr/dashboard: Fixes regression in device selection modal

The 'ExpressionChangedAfterItHasBeenCheckedError' has recently
shown up in device selection modal in OSD creation form. It looks
like it's a regression due to the modal switch (PR #35370). Which was
merged yesterday and it had worked on Monday.

Fixes: https://tracker.ceph.com/issues/46303
Signed-off-by: Stephan Müller <smueller@suse.com>

Merge pull request #35856 from tchaikov/wip-46267

test/unittest_lockdep: skip lockdep test if CEPH_DEBUG_MUTEX is not d…

Reviewed-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #35751 from smithfarm/wip-radosgw-admin-orphans

doc: PendingReleaseNotes: fix deprecated radosgw-admin commands

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

mgr/dashboard: Remove ngx-bootstrap

Fixes: https://tracker.ceph.com/issues/46281
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35782 from tspmelo/wip-ng-datepicker

mgr/dashboard: Use ng-bootstrap for Datepicker

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #35869 from smithfarm/wip-rn-15_2_4

doc/releases/octopus: add 15.2.4 release notes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #35805 from ricardoasmarques/ceph-orch-status-format

cephadm: Add "--format" option to "ceph orch status"

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #35811 from tchaikov/wip-46054

kv/RocksDBStore: always release column family handles

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

Merge pull request #35723 from tspmelo/wip-fix-action-tooltip

mgr/dashboard: Fix title of disabled table actions

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

qa/tasks: make sh() in vstart_runner.py identical with teuthology.orchestra.remote.sh

Fixes: https://tracker.ceph.com/issues/46069
Signed-off-by: Jos Collin <jcollin@redhat.com>

Merge pull request #35606 from Daniel-Pivonka/cephadm-45653-44866

cephadm: add sudo ssh user option

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

doc/releases/octopus: add 15.2.4 release notes

Signed-off-by: Nathan Cutler <ncutler@suse.com>

doc/dev/osd_internals: fix typos

Signed-off-by: Jakub Wilk <jwilk@jwilk.net>

cephadm: Add "--format" option to "ceph orch status"

Fixes: https://tracker.ceph.com/issues/46233
Signed-off-by: Ricardo Marques <rimarques@suse.com>

mgr/dashboard: Fixes typeahead regression in the silence matcher

This regression was introduced by PR #35300 which updated the typeahead
module usage from ngx-bootstrap to ng-bootstrap's typeahead module.

The regression was that the typeahead didn't open on click into the
input field. Another regression was that the suggestions didn't overlap
the modal anymore.

Fixes: https://tracker.ceph.com/issues/46135
Signed-off-by: Stephan Müller <smueller@suse.com>

Merge pull request #35577 from mgfritch/orch-test-iscsi

mgr/test_orchestrator: add iscsi

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge PR #35417 into master

* refs/pull/35417/head:
volumes/fs/nfs: Don't parse rados export objects during FSExport init
pybind/mgr/volumes/nfs: Fix flake8 errors
qa/tasks/test_nfs: Add todo note for cluster update test
qa/tasks/cephfs/test_nfs: Add test for get and list detailed export
qa/tasks/cephfs/test_nfs: Add test for export user id
qa/tasks/cephfs/test_nfs: Add description for each test
doc/cephfs: Add list and get export usage
qa/tasks/cephfs: Add tests for export create with non-existing fsname and cluster id
qa/tasks/cephfs: Add tests for invalid cluster id, export type and modify list cluster
qa/tasks/cephfs: Add test for listing exports
pybind/mgr/volumes/nfs: Reorder FSExport and NFSCluster class methods
mgr/volumes/nfs: Set pool_namespace and cluster_id through decorator
mgr/volumes/nfs: Check cluster availability in export command methods
mgr/volumes/nfs: Misc changes to export get and ls command
qa/tasks/cephfs: Add test for nfs cluster ls command
mgr/volumes/nfs: Add nfs cluster ls command
mgr/volumes/nfs: Remove 'ganesha-' prefix from orch returned service id
mgr/volumes/nfs: get export in a nfs cluster
mgr/volumes/nfs: list exports within a ganesha cluster
mgr/volume/nfs: allow only [A-Za-z0-9-_.] characters
qa/tasks/cephfs: Add test to check if export is available on restarting mgr
qa/tasks/cephfs: Add idempotency test for nfs commands
mgr/volumes/nfs: Check if cluster exists before creating exports
mgr/volumes/nfs: Fetch exports in persistent way if mgr is restarted

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

volumes/fs/nfs: Don't parse rados export objects during FSExport init

Instead we can do it if any export commands are used. This fixes ImportError
raised when FSExport is initialized with cephadm module disabled.

Signed-off-by: Varsha Rao <varao@redhat.com>

pybind/mgr/volumes/nfs: Fix flake8 errors

Signed-off-by: Varsha Rao <varao@redhat.com>

qa/tasks/test_nfs: Add todo note for cluster update test

Signed-off-by: Varsha Rao <varao@redhat.com>

qa/tasks/cephfs/test_nfs: Add test for get and list detailed export

Signed-off-by: Varsha Rao <varao@redhat.com>

qa/tasks/cephfs/test_nfs: Add test for export user id

Signed-off-by: Varsha Rao <varao@redhat.com>

qa/tasks/cephfs/test_nfs: Add description for each test

Signed-off-by: Varsha Rao <varao@redhat.com>

doc/cephfs: Add list and get export usage

Signed-off-by: Varsha Rao <varao@redhat.com>

qa/tasks/cephfs: Add tests for export create with non-existing fsname and cluster id

Signed-off-by: Varsha Rao <varao@redhat.com>

qa/tasks/cephfs: Add tests for invalid cluster id, export type and modify list cluster

Signed-off-by: Varsha Rao <varao@redhat.com>

qa/tasks/cephfs: Add test for listing exports

Signed-off-by: Varsha Rao <varao@redhat.com>

pybind/mgr/volumes/nfs: Reorder FSExport and NFSCluster class methods

To maintain consistency and improve readability.

Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/volumes/nfs: Set pool_namespace and cluster_id through decorator

Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/volumes/nfs: Check cluster availability in export command methods

Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/volumes/nfs: Misc changes to export get and ls command

This patch does following changes:
* Add extra line before every class definition
* Reorder export dictionary
* Use _fetch_export() in get export command
* Remove cluster_id key from export dictionary if single export is deleted

Signed-off-by: Varsha Rao <varao@redhat.com>

qa/tasks/cephfs: Add test for nfs cluster ls command

Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/volumes/nfs: Add nfs cluster ls command

This commands provides list of deployed nfs clusters.

Fixes: https://tracker.ceph.com/issues/45742
Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/volumes/nfs: Remove 'ganesha-' prefix from orch returned service id

Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/volumes/nfs: get export in a nfs cluster

Fixes: https://tracker.ceph.com/issues/45741
Signed-off-by: Ramana Raja <rraja@redhat.com>

mgr/volumes/nfs: list exports within a ganesha cluster

List the pseudo paths of the exports within a ganesha cluster
with `nfs export ls <cluster ID>` command.

List all the details of the exports within a ganesha cluster
with `nfs export ls <cluster ID> --detailed` command.

Partially-fixes: https://tracker.ceph.com/issues/45741
Signed-off-by: Ramana Raja <rraja@redhat.com>

mgr/volume/nfs: allow only [A-Za-z0-9-_.] characters

... for ganesha cluster names.

Fixes: https://tracker.ceph.com/issues/45744
Signed-off-by: Ramana Raja <rraja@redhat.com>

qa/tasks/cephfs: Add test to check if export is available on restarting mgr

Signed-off-by: Varsha Rao <varao@redhat.com>

qa/tasks/cephfs: Add idempotency test for nfs commands

Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/volumes/nfs: Check if cluster exists before creating exports

Fixes: https://tracker.ceph.com/issues/45740
Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/volumes/nfs: Fetch exports in persistent way if mgr is restarted

Fixes: https://tracker.ceph.com/issues/45740
Signed-off-by: Varsha Rao <varao@redhat.com>

Merge PR #35784 into master

* refs/pull/35784/head:
mon/MDSMonitor: copy MDS info which may be removed

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge PR #35038 into master

* refs/pull/35038/head:
qa/tasks/cephfs/cephfs_test_case.py: skip cleaning the core dumps

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

mgr/dashboard: Use ng-bootstrap for Datepicker

Fixes: https://tracker.ceph.com/issues/45757
Signed-off-by: Tiago Melo <tmelo@suse.com>

test/unittest_lockdep: skip lockdep test if CEPH_DEBUG_MUTEX is not defined

this change addresses a regression introduced by
2dc50b5f91476cf10429dbcdd52b00e32f599d5c

Fixes: https://tracker.ceph.com/issues/46267
Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Fix NFS Edit page loading problem

We were trying to access a component that is only created
after the form loading is finished, before it was finished.

Fixes: https://tracker.ceph.com/issues/46276
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #32493 from rishabh-d-dave/cv-use-dash-S-everywhere

ceph-volume: don't use container classes in api/lvm.py

cephadm: add sudo ssh user option

add the ability to use a non-root users for connecting to hosts, this user requires pass wordless sudo access

useful for clusters that have root ssh access disabled

Fixes: https://tracker.ceph.com/issues/44866
Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>

mgr/dashboard: Fix title of disabled table actions

Fix regression introduced in a1fac664f5b0fa1c8b78de3440e99ee68d34f512.
Title attribute was unintentionally removed from the table actions.

Fixes: https://tracker.ceph.com/issues/46153
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Re-enable OSD's table autoReload

Fixes: https://tracker.ceph.com/issues/45303
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35657 from athanatos/sjust/wip-lba-replay

crimson/seastore: add extent replay support, implement for lba tree nodes

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35370 from tspmelo/wip-ng-modal

mgr/dashboard: Use ng-bootstrap for Modal

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

ceph-volume: delete devices.lvm.prepare.Prepare.get_lv

Since it calls get_lv_from_argument() internally and use get_first_lv()
instead and update tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: don't use api.lvm.VolumeGroups

Use api.lvm.get_vgs() and api.lvm.get_first_vg() instead and update
tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: don't use api.lvm.PVolumes

Update api.lvm.get_first_pv() and api.lvm.get_pvs() instead and update
tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: don't use api.lvm.get_lv

Use api.lvm.get_lvs() and api.lvm.get_first_lv() instead and update the
tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: don't use api.lvm.get_lv_from_argument

Use api.lvm.get_lvs() and api.lvm.get_first_lv() instead and update
tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: don't use class api.lvm.Volumes

Replace code using class Volumes by methods get_lvs() and
get_first_lv(). Also, update the tests accordingly.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #34532 from rhcs-dashboard/wip-45068-fix-parse-error

mgr/dashboard: Prometheus query error in the metrics of Pools, OSDs and RBD images

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #35576 from sebastian-philipp/cephadm-etc-ceph-ceph-conf

mgr/cephadm: Manage /etc/ceph/ceph.conf

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #35565 from bk201/wip-44985

mgr/dashboard: fix wal/db slots controls in the OSD form

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #35779 from votdev/show_yes_no

mgr/dashboard: Display check icon instead of true|false in various datatables

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

rpm: package crimson-osd in ceph-osd

in hope to simplify the enabling of crimson-osd. as we will use cephadm
as the way for deploying crimson-osd in future. it's unlikely we will
have classic osd and crimson osd co-located in the same system. so
this is most simple way to enable crimson-osd with minimum efforts.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35615 from ishanrai05/scss-linting

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge PR #35826 into master

* refs/pull/35826/head:
mds: fix typo in MDSSocketHook

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #35729 from rzarzynski/wip-bl-deprecate-claim

common/bl, *: deprecate bufferlist::claim() and switch to rvalue-taking operator=()

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>