mds/MDSRank: fix typo in "unrecognized"

Fixes: beb12fa25315153e1a06a0104883de89776438a6
Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #36080 from winndows/superfluous_break5

osd/PGBackend: Remove superfluous breaks

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36067 from winndows/superfluous_break1

mon/OSDMonitor: Remove the superfluous break

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36068 from winndows/superfluous_break2

common: Remove the superfluous break

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36078 from winndows/superfluous_break7

mgr: Remove the superfluous break

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #35994 from jschmid1/osd_support_reweight

mgr/osd_support: add unittests

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #35836 from mgfritch/vstart-out-dir-logs

vstart: out dir can contain a large number of files

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36152 from sebastian-philipp/ceph-tell-cephadm

ceph: Fix `tell` for cephadm

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35629 from dillaman/wip-librbd-asio-2

librbd: switch IO path to use new librados asio API

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge PR #36134 into master

* refs/pull/36134/head:
mgr/nfs: Remove NParts and Cache_Size from MDCACHE block

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge PR #36107 into master

* refs/pull/36107/head:
mds: fix mds forwarding request 'no_available_op_found'

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #36097 into master

* refs/pull/36097/head:
mds: fix nullptr dereference in MDCache::finish_rollback

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #35969 into master

* refs/pull/35969/head:
mds: optimize random threshold lookup for dentry load

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #35953 into master

* refs/pull/35953/head:
qa: Fix name collisions

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge PR #35902 into master

* refs/pull/35902/head:
ceph-dedup-tool: fix warning
mds: slave -> peer
mds: master -> leader

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #36139 into master

* refs/pull/36139/head:
mon: refactor ServiceMap::Service::get_task_summary()
mon: only dump non-empty "task status"
mgr/ServiceMap: move ServiceMap::Daemon implementation into .cc file

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #36140 into master

* refs/pull/36140/head:
mgr/volumes: fix "ceph nfs export" help messages

Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #35851 from dang/wip-dang-zipper-6

Wip dang zipper 6

Clean up some leaks in rgw_admin

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

NULL out g_ceph_context when deleting it

This avoids a use-after-free when there is a crash on shutdown (or when
something like ASAN triggers an ABORT on leak).

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Zipper Object

This pass modifies RGW to use RGWObject and RGWRadosObject.
Also improves RGWBucket usage.  This converts many of the APIs to
unique_ptr.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #35553 from zdover23/wip-doc-iscsi-target-cli-daemon

doc/rbd: add rbd-target-gw enable and start

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Alexandra Settle <asettle@suse.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35846 from sebastian-philipp/podman-pull-retry

cephadm: Retry pull on transient error

Reviewed-by: Ricardo Marques <rimarques@suse.com>

ceph: Fix `tell` for cephadm

The tell target might contain dots now. Like
`mds.myfs.myhost.rnusmq` is now a valid
target.

Fixes: https://tracker.ceph.com/issues/46560
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #34696 from tspmelo/wip-locl

mgr/dashboard: Use $localize and locl for TS translations

Reviewed-by: Ernesto Puertat <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>

Merge pull request #36000 from tspmelo/wip-favicon

mgr/dashboard: Display cluster status in favicon

Reviewed-by: Ernesto Puertat <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #35456 from sebastian-philipp/cephadm-events

mgr/cephadm: Add k8s-style event system

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #35985 from bk201/wip-46413

mgr/dashboard: fix regression in delete OSD modal

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

mgr/nfs: Remove NParts and Cache_Size from MDCACHE block

As setting them to small value affects the performance and they are not related
to metadata caching. https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495185

Fixes: https://tracker.ceph.com/issues/46579
Signed-off-by: Varsha Rao <varao@redhat.com>

Merge PR #36124 into master

* refs/pull/36124/head:
script/ptl-tool: add flag to turn off credits

Reviewed-by: Jos Collin <jcollin@redhat.com>

test/librbd: drop test_internal.ShrinkFlushCase test case

It's a racey test that is better exercised by the existing resize
state machine mock tests.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: utilize neorados to issue async blacklist request

The librados API does not currently offer an async 'mon_command'
API method. Instead of adding one just to support this effort,
re-use the neorados API to issue an asynchronous 'mon_command'
for blacklisting a client.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: managed_lock::BreakRequest needs a reference to AsioEngine

The current usage of the asio::ContextWQ to similate an asynchronous blocklist
API call is resulting in deadlock in the rbd-mirror HA tests when multiple
blocklists are occurring concurrently. The next commit will switch to use the
neorados async MON command API (since librados doesn't offer one).

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: fix race condition with AIO completion callbacks

Now that librbd utilizes multiple threads for the IO path, it's
possible for a race condition to occur if a client app is waiting
on a completion to fire and the actual invokation of the
completion.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: directly post completions to the asio strand

Avoid the unnecessary wrapping of the strand completion in a
bind_executor by just directly posting the completion to the
strand.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: allocate the asio strands directly on the heap

This will assist with potential race condition debugging since the
stand pointer will be invalidated by the time the strand has been
destructed and shut down.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: ensure all asio completions are complete at ImageCtx destruction

With multiple threads of execution possible, we need to ensure that
all completions have fired prior to the destruction of the AsioEngine.
We also need to ensure that the AsioEngine is destoyed outside the
context of its owned stands.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: increased logging for asio::ContextWQ

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: switch the IO path to utilize the neorados API

IO operations to the cluster are now dispatched via the neorados
API which allows multiple threads to be utilized for processing
incoming and outgoing IO.

This also involves switching from a map for tracking sparse extents
to a vector of pairs since that matches the new API for sparse
read operations.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: switch all queued contexts in IO path to use asio post

The post operation is similar to the asio::ContextWQ::queue wrapper
but execution is not limited to a single thread strand.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: switch external API callbacks to use dedicated asio strand

This ensures that the API callers will not receive concurrent
callbacks and allows internal AioCompletion users to be able to
use all available asio dispatch threads.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: integrate neorados into ImageCtx

Also create an up-to-date data_io_context that mimics the function
of ImageCtx::data_ctx. The data_io_context will eventually be passed
via the IO dispatch specs to replace the passing of the snapshot
id vectors.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: replace ImageCtx::get_work_queue with direct AsioEngine usage

The ImageCtx will contain a shared_ptr to its AsioEngine and previous
usage for get_work_queue now directly instantiate their own AsioEngine
instance.

Additionally, AsioEngine is now lighter weight by re-using the
io_context exposed via a neorados-wrapped librados API.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

cls/rbd: add support for neorados-style IO requests

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

test/librados_test_stub: decode "osd blacklist" MON command

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

test/librados_test_stub: add support for basic neorados ops

Internally it re-uses the existing librados-style architecture adapted
to fit the new interface.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

test/librados_test_stub: pass read snap id to read operation hooks

The neorados API does not require the creation of heavy IoCtx-like
objects with static read snap_ids pre-assigned. Therefore, we will
need to pass the read snap_id to all affected functions and adjust
all dependent unittests to expect a new parameter.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

test/librbd: fixed gmock warnings for get_parent_overlap calls

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

neorados: allow a client to wait for the latest OSD map

This is required when issuing a client blacklist to ensure that
they cannot overwrite any OSD data before their map updates.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

neorados: fixed missing handling of read flags

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

neorados: support blkin trace passing on execute calls

librbd passes blkin traces from the user API down through to
Objecter and back. Add these missing hooks to the neorados API
since they weren't included in the intial revision.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

common/Timer: fixed invalid read from deleted object

The std::conditional_variable will keep the provided reference and
repeatedly dereference it even after the lock was dropped and
re-acquired. This can lead to an invalid read if the associated
schedule entry has been removed while waiting.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36077 from dillaman/wip-librbd-parent-cache

librbd: fix parent cache initialization failures

Reviewed-by: Mykola Golub <mgolub@suse.com>

mgr/dashboard: Use $localize and locl for TS translations

Fixes: https://tracker.ceph.com/issues/45950
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #36128 from xxhdx1985126/wip-crimson-fix-osd-shutdown

crimson/osd: fix osd shutdown problem

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36142 from tchaikov/wip-crimson-cleanup

crimson: do not capture unused variables

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #35987 from tspmelo/wip-update-lodash

mgr/dashboard: Fix some npm audit warnings

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge PR #36138 into master

* refs/pull/36138/head:
doc/cephfs/nfs: Update about deploying nfs-ganesha with cephadm in vstart

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #35960 from votdev/issue_46395_required_field_message

mgr/dashboard: Use same required field message accross the UI

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35777 from ofriedma/rgw-enoent-cache

rgw: add negative cache to the system object

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #36070 from tspmelo/wip-fix-async-unittest

mgr/dashboard: Block the import of async from @angular/core/testing

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #36113 from trociny/wip-snap-create-error-msg

librbd: fix snapshot create error message

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35974 from tspmelo/wip-clean-headers

mgr/dashboard: Clean custom header styles

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

crimson: do not capture unused variables

this change silences warnings like:

mson/osd/backfill_state.cc:131:11: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
      [&, this](const pg_log_entry_t& e) {
        ~~^~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36099 from dillaman/wip-rbd-nbd-hook

rbd-nbd: quisce hook should be installed to /usr/libexec/...

Reviewed-by: Mykola Golub <mgolub@suse.com>

mgr/volumes: fix "ceph nfs export" help messages

They say "<attach>" but they mean "<clusterid>".

Fixes: https://tracker.ceph.com/issues/46572
Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #35605 from ceph/osd-compact-on-start

osd: Add config option to compact OSD's object store on start

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

mon: refactor ServiceMap::Service::get_task_summary()

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

mon: only dump non-empty "task status"

* mgr/ServiceMap: add ServiceMap::Service::has_running_tasks() to tell
  if a service has any running tasks
* mon/Monitor: do not print an empty "task status" section when printing
  cluster status. it's just confusing.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/ServiceMap: move ServiceMap::Daemon implementation into .cc file

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/cephfs/nfs: Update about deploying nfs-ganesha with cephadm in vstart

Fixes: https://tracker.ceph.com/issues/46571
Signed-off-by: Varsha Rao <varao@redhat.com>

Merge pull request #36122 from zdover23/wip-doc-rados-redundant-a-typo

doc/rados: remove a redundant "a" from a sentence

This sentence removes an "a" from a sentence, which makes the sentence grammatically correct.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

mgr/dashboard: Block the import of async from @angular/core/testing

We no longer need this and it was causing unexpected results in some tests.

Fixes: https://tracker.ceph.com/issues/46500
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Display cluster status in favicon

Fixes: https://tracker.ceph.com/issues/44542
Signed-off-by: Tiago Melo <tmelo@suse.com>

osd: Add config option to compact OSD's object store on start

By setting this configuration option an OSD will compact it's
store's OMAP on start.

This way admin's can trigger an offline compaction by setting this
configuration value to 'true' and then restarting the OSD.

This is easier than using tools like 'ceph-kvstore-tool' with requires
more manual work on the CLI and might be more difficult for users.

Signed-off-by: Wido den Hollander <wido@42on.com>

mgr/cephadm: Set exception context to populate orch events.

Like when if daemon deployment fails

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

crimson/osd: fix osd shutdown problem

when doing full-system shutdown, monitors may go down before OSDs in which case
the osd shutdown hangs waiting for monc to successfully send the markmedown msg
to monitors

Fixes: https://tracker.ceph.com/issues/46564
Signed-off-by: Xuehan Xu <xxhdx1985126@163.com>

Merge pull request #36103 from dillaman/wip-44311

crush/CrushWrapper: rebuild reverse maps after rebuilding crush map

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>

Merge pull request #35768 from rhcs-dashboard/fix-45185-master

mgr/dashboard: fix pool usage calculation

Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>

Merge pull request #36095 from orozery/striper_get_file_offset

osdc/Striper: add get_file_offset function

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36091 from tchaikov/wip-46495

mgr/DaemonServer: keep daemon in service map when it has no tasks

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #36051 from Songweibin/wip-rados-setomapval

tools/rados: add an option "--input-file file" to `setomapval` command

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/cephadm: Add event when deploying a daemon

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

doc/rados: remove a redundant "a" from a sentence

This commit changes the (not quite) sentence "Once
you have a deployed a Ceph Storage Cluster, you may
begin operating your cluster." to "Once you have
deployed a Ceph Storage Cluster, you may begin
operating your cluster."

Fixes: https://tracker.ceph.com/issues/46554
Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #35130 from rzarzynski/wip-crimson-backfill

crimson: add support for backfill, part 0

Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/cephadm: Add an event when creating a service

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/cephadm: Add inventory.EventStore

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orch: Add events to tests/test_orchestrator

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/orch: Add OrchestratorEvent class

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

cephadm: also retry on digest mismatch

Fixes: https://tracker.ceph.com/issues/46534
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

doc/rbd: add rbd-target-gw enable and start

This commit adds the following commands to  the "Configuring the iSCSI Target Using the Command Line" page: "systemctl enable rbd-target-gw" and "systemctl start rbd-target-gw"

Fixes: https://tracker.ceph.com/issues/45987
Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #33770 from majianpeng/osd-simple-logger

osd/OSD: simple perfcounter usage in OSDService

Reviewed-by: Kefu Chai <kchai@redhat.com>

mds: fix mds forwarding request 'no_available_op_found'

Fixes: https://tracker.ceph.com/issues/46543
Signed-off-by: Yanhu Cao <jrcaoyanhu@jd.com>

Merge pull request #35989 from bigwhite37/fix-dedup-tool-unused-var-warn

tools/ceph_dedup_tool: fix unused variable warning

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

script/ptl-tool: add flag to turn off credits

To speed up integration branch creation.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #30780 from zhangsw/fix-rgw-multipart-abortdate

rgw: add abort multipart date and rule-id header to init multipart upload response

Merge pull request #35950 from zdover23/wip-doc-dev-guide-add-zdover-to-lead-list

doc/devel: add zdover to leads list

Merge pull request #34537 from ideepika/wip-bluestore-mem-tracking

os/bluestore: mempool split for finer granularity

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

librbd: fix parent cache races and error handling

If the plugin fails to connect to the daemon at start-up it will
crash the process due to a resource deadlock exception being
thrown as the client is destroyed. Additionally, librbd will support
concurrent IO thread processing in the future so the client needs
to be protected by a lock.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #35901 from sebastian-philipp/juanmi-firewall-refactor

cephadm: refactor update_firewalld

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>