mgr/dashboard: print more log when backend-api-tests fails

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36240 from tchaikov/wip-ceph-debug-docker-el8

ceph-debug-docker: support centos 8

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #36203 into master

* refs/pull/36203/head:
client: cleanup the fuse client code

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge pull request #35667 from jschmid1/cephadm_deterministic_simplescheduler

mgr/cephadm: rework --dry-run/previews

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #36216 from sebastian-philipp/cephadm-fix-undefined-container_path

cephadm: fix UnboundLocalError: `container_path`

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

ceph-debug-docker: support centos 8

* default to centos:8, as we've moved to centos:8 now
* do not assume that the base image is centos:7, use centos:8 if it is
  specified.
* install python3-* packages for centos:8 and install python36-*
  packages for centos:7. as el8 is now a python3 distro, and
  centos:7 now has python36.
* s/screen/tmux/. because screen is now offered by EPEL, while tmux
  is in BaseOS.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #35694 from rhcs-dashboard/wip-45901-master

mgr/dashboard: increase API test coverage in API controllers

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puertat <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

doc: add notes about --dry-run

Signed-off-by: Joshua Schmid <jschmid@suse.de>

mgr/cephadm: rework --dry-run/previews

Signed-off-by: Joshua Schmid <jschmid@suse.de>

client: cleanup the fuse client code

Signed-off-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #35866 from tchaikov/wip-qa-tempest-pin-openstackclients

qa/keystone: pin python-openstackclient

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #36005 from p-se/log-prometheus-metric-gathering

mgr/prometheus: log time it takes to collect metrics

Reviewed-by: Boris Ranto <branto@redhat.com>

qa/keystone: pin python-openstackclient and osc-lib

keystone's dependencies are installed using its tox.ini,
which in turn uses a constraints file of
https://releases.openstack.org/constraints/upper/ussuri,
and it pins cliff to 3.1.0, which is not able to fulfill the requirement
of osc-lib 2.2.0. as it needs needs cliff>=3.2.0. per
https://releases.openstack.org/ussuri/, the latest osc-lib for
ussuri is 2.0.0. and osc-lib>=2.0.0 is required by
python-openstackclient 2.5.1, so let's use it instead of using the latest
one.

if we install cliff==3.1.0 along with python-openstackclient==5.2.1,
we will have following error, as `CommandManager.add_command_group()`
method was added to cliff in 3.2.0. see
https://opendev.org/openstack/cliff/commit/8477c4dbd0cf651b9b4ba4a4934de69d5942bfc2,
so cliff failed to work with the latest openstackclient, like:

2020-06-29T17:26:23.402 INFO:teuthology.orchestra.run.smithi039.stderr:'CommandManager' object has no attribute 'add_command_group'
2020-06-29T17:26:23.402 INFO:teuthology.orchestra.run.smithi039.stderr:Traceback (most recent call last):
2020-06-29T17:26:23.403 INFO:teuthology.orchestra.run.smithi039.stderr:  File "/home/ubuntu/cephtest/keystone/.tox/venv/lib/python3.6/site-packages/cliff/app.py", line 264, in run
2020-06-29T17:26:23.403 INFO:teuthology.orchestra.run.smithi039.stderr:    self.initialize_app(remainder)
2020-06-29T17:26:23.403 INFO:teuthology.orchestra.run.smithi039.stderr:  File "/home/ubuntu/cephtest/keystone/.tox/venv/lib/python3.6/site-packages/openstackclient/shell.py", line 133, in
initialize_app
2020-06-29T17:26:23.403 INFO:teuthology.orchestra.run.smithi039.stderr:    super(OpenStackShell, self).initialize_app(argv)
2020-06-29T17:26:23.403 INFO:teuthology.orchestra.run.smithi039.stderr:  File "/home/ubuntu/cephtest/keystone/.tox/venv/lib/python3.6/site-packages/osc_lib/shell.py", line 442, in initialize_app
2020-06-29T17:26:23.404 INFO:teuthology.orchestra.run.smithi039.stderr:    self._load_plugins()
2020-06-29T17:26:23.404 INFO:teuthology.orchestra.run.smithi039.stderr:  File "/home/ubuntu/cephtest/keystone/.tox/venv/lib/python3.6/site-packages/openstackclient/shell.py", line 104, in
_load_plugins
2020-06-29T17:26:23.404 INFO:teuthology.orchestra.run.smithi039.stderr:    self.command_manager.add_command_group(cmd_group)
2020-06-29T17:26:23.404 INFO:teuthology.orchestra.run.smithi039.stderr:AttributeError: 'CommandManager' object has no attribute 'add_command_group'
2020-06-29T17:26:23.404 INFO:teuthology.orchestra.run.smithi039.stderr:Traceback (most recent call last):
2020-06-29T17:26:23.405 INFO:teuthology.orchestra.run.smithi039.stderr:  File "/home/ubuntu/cephtest/keystone/.tox/venv/lib/python3.6/site-packages/osc_lib/shell.py", line 134, in run
2020-06-29T17:26:23.405 INFO:teuthology.orchestra.run.smithi039.stderr:    ret_val = super(OpenStackShell, self).run(argv)
2020-06-29T17:26:23.405 INFO:teuthology.orchestra.run.smithi039.stderr:  File "/home/ubuntu/cephtest/keystone/.tox/venv/lib/python3.6/site-packages/cliff/app.py", line 264, in run
2020-06-29T17:26:23.405 INFO:teuthology.orchestra.run.smithi039.stderr:    self.initialize_app(remainder)
2020-06-29T17:26:23.405 INFO:teuthology.orchestra.run.smithi039.stderr:  File "/home/ubuntu/cephtest/keystone/.tox/venv/lib/python3.6/site-packages/openstackclient/shell.py", line 133, in
initialize_app
2020-06-29T17:26:23.405 INFO:teuthology.orchestra.run.smithi039.stderr:    super(OpenStackShell, self).initialize_app(argv)
2020-06-29T17:26:23.406 INFO:teuthology.orchestra.run.smithi039.stderr:  File "/home/ubuntu/cephtest/keystone/.tox/venv/lib/python3.6/site-packages/osc_lib/shell.py", line 442, in initialize_app
2020-06-29T17:26:23.406 INFO:teuthology.orchestra.run.smithi039.stderr:    self._load_plugins()
2020-06-29T17:26:23.406 INFO:teuthology.orchestra.run.smithi039.stderr:  File "/home/ubuntu/cephtest/keystone/.tox/venv/lib/python3.6/site-packages/openstackclient/shell.py", line 104, in
_load_plugins
2020-06-29T17:26:23.406 INFO:teuthology.orchestra.run.smithi039.stderr:    self.command_manager.add_command_group(cmd_group)
2020-06-29T17:26:23.406 INFO:teuthology.orchestra.run.smithi039.stderr:AttributeError: 'CommandManager' object has no attribute 'add_command_group'

in this change the openstackclients version is pin'ed to the
latest stable of 5.2.1. will have a separated PR to bump up
the cliff version on teuthology side.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36094 from varshar16/wip-vstart-cephadm-rm-stale-image

vstart: Remove old ceph images if new cluster is deployed

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #36198 from tchaikov/wip-test-drop-py2

rpm,deb,qa,python-common,test: drop python2 support

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #35579 from pcuzner/wip-prometheus-diskinfo

mgr/prometheus: add disk metadata to occupation metric

Signed-off-by: Boris Ranto <branto@redhat.com>

Merge pull request #36117 from tspmelo/wip-angular-10

mgr/dashboard: Update Angular v10

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #36098 from s0nea/wip-doc-dashboard-nfs-issue

doc/mgr/dashboard: add note about known NFS issue

Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #36205 from ceph/navbar-padding

mgr/dashboard: fix navigation sidebar elements alignment

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #36194 from wjwithagen/wjw-fix-preforker

common: include <signal.h> in Preforker.h

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

rpm,deb: drop python3-six dependency

it's not used anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>

python-common: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/test_orchestrator: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/rook: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/orchestrator: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/k8sevents: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

pybind/mgr/cephadm: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks: drop python2 support from rgw related tests

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks/samba: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks/rbd: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks/mgr/dashboard: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Update Angular v10

Fixes: https://tracker.ceph.com/issues/46509
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35981 from trociny/wip-45268

librbd: don't resend async_complete if watcher is unregistered

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36149 from adamemerson/wip-warn-more

Warning Cleanup

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <jdillaman@redhat.com>

Merge pull request #36206 from idryomov/wip-read-from-replica-log-msgs

osd/PrimaryLogPG: fix up replica read log messages

Reviewed-by: Xie Xingguo <xie.xingguo@zte.com.cn>

qa/tasks/fs: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks/cephfs: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks/cephadm: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/rgw/rgw_multi: drop python2 support

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #34059 from Songweibin/wip-objectmap-invalid

librbd: don't set objectmap invalid when load objectmap timed out

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36212 from tspmelo/wip-cypress-gpu

mgr/dashboard: E2E: Fix random failures

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #36153 from votdev/increase_icon_border

mgr/dashboard: Display cluster status in favicon

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

Merge pull request #35850 from sebastian-philipp/cephadm-set-paused-health

mgr/cephadm: Add CEPHADM_PAUSED to test_cli

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #36147 from mgfritch/cephadm-service-fixup-mypy

mgr/cephadm: clean-up service module type checking

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

mgr/dashboard: fix navigation sidebar elements alignment

Currently the navigation sidebar elements are not aligned properly with the three bars for opening and closing the sidebar. This PR address that minor cleanup.

Fixes: https://tracker.ceph.com/issues/46621
Signed-off-by: Nizamudeen A <nia@redhat.com>

librbd: propagate an error back when failed to invalidating

Signed-off-by: songweibin <song.weibin@zte.com.cn>

librbd: don't set objectmap invalid when load objectmap timed out

Add a new configuration option of `rbd_invalidate_object_map_on_timeout`,
if disabled and timed out to open/update object map, donot invalidating
object map and return -ETIMEDOUT to APP.

Signed-off-by: songweibin <song.weibin@zte.com.cn>

Merge pull request #35509 from zdover23/wip-doc-cephadm-adoption-step-9

doc/cephadm: remove confusing fragment from cephadm adoption step 9

Reviewed-by: Varsha Rao <varao@redhat.com>

mgr/dashboard: E2E: Increase defaultCommandTimeout

Fixes: https://tracker.ceph.com/issues/46623
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: E2E: Disable GPU for Chrome Headless

Fixes: https://tracker.ceph.com/issues/46624
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #35916 from jschmid1/drivegroup_extension

python-common/drivegroups: implement option to change filter_logic

Merge pull request #35946 from jschmid1/extend_device_ls

mgr/cephadm: also list vendor/model/rotational in `device ls`

Merge pull request #35961 from p-se/cephadm-custom-image-fix

cephadm: fix usage of custom Prometheus image

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #36157 from rhcs-dashboard/fix-46601-master

mgr/dashboard/api: increase API health timeout

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

cephadm: fix UnboundLocalError: `container_path`

Fixes: https://tracker.ceph.com/issues/46098
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge pull request #36164 from dsavineau/cephadm_remove_ktdreyer_copr_repo

cephadm: remove ktdreyer's copr repository

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

osd/PrimaryLogPG: fix up replica read log messages

Add missing spaces and don't repeat oid twice.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #36129 from matthewoliver/ipv6_cephadm_route_expiry

cephadm: Fix ipv6 network regex to support routes with expiry

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

Merge PR #36196 into master

* refs/pull/36196/head:
mds/MDSRank: fix typo in "unrecognized"

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

mds/MDSRank: fix typo in "unrecognized"

Fixes: beb12fa25315153e1a06a0104883de89776438a6
Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #36081 from winndows/superfluous_break4

osd/OSDMap: Remove the superfluous break

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36083 from winndows/superfluous_break8

key_value_store: Remove superfluous breaks

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36080 from winndows/superfluous_break5

osd/PGBackend: Remove superfluous breaks

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36067 from winndows/superfluous_break1

mon/OSDMonitor: Remove the superfluous break

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36068 from winndows/superfluous_break2

common: Remove the superfluous break

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36078 from winndows/superfluous_break7

mgr: Remove the superfluous break

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #35994 from jschmid1/osd_support_reweight

mgr/osd_support: add unittests

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

Merge pull request #35836 from mgfritch/vstart-out-dir-logs

vstart: out dir can contain a large number of files

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36152 from sebastian-philipp/ceph-tell-cephadm

ceph: Fix `tell` for cephadm

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

common: include <signal.h> in Preforker.h

Since it does use functions declared by signal.h

/home/jenkins/workspace/ceph-master/src/common/Preforker.h:50:5: error: use of undeclared identifier                                             'sigemptyset'
    sigemptyset(&sa.sa_mask);
    ^
/home/jenkins/workspace/ceph-master/src/common/Preforker.h:52:9: error: no matching constructor for                                             initialization of 'sigaction'
    if (sigaction(SIGHUP, &sa, nullptr) != 0) {
        ^         ~~~~~~~~~~~~~~~~~~~~
/usr/include/sys/signal.h:366:8: note: candidate constructor (the implicit copy constructor) not via                                            ble: requires 1 argument, but 3 were provided
struct sigaction {
       ^
/usr/include/sys/signal.h:366:8: note: candidate constructor (the implicit move constructor) not via                                            ble: requires 1 argument, but 3 were provided
/usr/include/sys/signal.h:366:8: note: candidate constructor (the implicit default constructor) not                                             viable: requires 0 arguments, but 3 were provided
2 errors generated.

fixes: https://github.com/ceph/ceph/pull/35844
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #35629 from dillaman/wip-librbd-asio-2

librbd: switch IO path to use new librados asio API

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge PR #36134 into master

* refs/pull/36134/head:
mgr/nfs: Remove NParts and Cache_Size from MDCACHE block

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

Merge PR #36107 into master

* refs/pull/36107/head:
mds: fix mds forwarding request 'no_available_op_found'

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #36097 into master

* refs/pull/36097/head:
mds: fix nullptr dereference in MDCache::finish_rollback

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #35969 into master

* refs/pull/35969/head:
mds: optimize random threshold lookup for dentry load

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>

Merge PR #35953 into master

* refs/pull/35953/head:
qa: Fix name collisions

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge PR #35902 into master

* refs/pull/35902/head:
ceph-dedup-tool: fix warning
mds: slave -> peer
mds: master -> leader

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #36139 into master

* refs/pull/36139/head:
mon: refactor ServiceMap::Service::get_task_summary()
mon: only dump non-empty "task status"
mgr/ServiceMap: move ServiceMap::Daemon implementation into .cc file

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #36140 into master

* refs/pull/36140/head:
mgr/volumes: fix "ceph nfs export" help messages

Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #35851 from dang/wip-dang-zipper-6

Wip dang zipper 6

rbd: Parenthesize constant macro expressions

So something can't bind to the shifted argument tighter than the shift
operator.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

pybind: Silence distutils/setuptools warning

Setuptools would very much like to be imported BEFORE distutils

So move the conditional imports of setuptools above the import of
distutils.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

test/osdc: Silence implicit conversion warning

By converting explicitly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

test/objectstore: Remove unused value

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

test/common: Fix pessimizing move

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

test/cls_queue: Remove pessimizing move

…and fix filetype in modeline.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

tools/cephfs: Explicitly convert to char

Whether char is signed or not is implementation defined, and if char
is signed converting 255 to a char will turn a positive value into a
negative.

Silence the warning by converting explicitly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

test/random: Turn off spurious warning

Since we're testing deduction guides involving a type whose concrete
representation is unknown, this warning provides no value.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osd: Remove unneeded copy in ranged loop initializer

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw/picojson: Pragma out limit comparison warning

intmax_t may or may not be identical to int64_t, depending on
platform. On our platform, it is.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw: Remove unneded copy in ranged initializer

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw: Fix dangling-gsl warning

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rbd: Remove unused lambda capture

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw: Remove unused lambda capture

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rbd_mirror: Remove unneded implicit conversions

Since we're comparing to uint64_ts and storing in a uint64_t, just
have the variable be a uint64_t.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rgw: Fix braced initializer warning

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

rbd: Remove clashing definition of CephContext

Fallout from the common_fwd change

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

kv/RocksDBStore: Remove unused variable

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

common: Clarify empty conditional body

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>