mgr/dashboard: Update list of supported browsers

Fixes: https://tracker.ceph.com/issues/46923
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge pull request #36604 from tspmelo/wip-favicon-circle

mgr/dashboard: Fix favicon white circle

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #36602 from tspmelo/wip-spell-check

mgr/dashboard: Fix spell errors

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Merge pull request #36585 from votdev/proper_format_portals

mgr/dashboard: Proper format iSCSI target portals

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #36566 from votdev/issue_46900_autocomplete

mgr/dashboard: Strange iSCSI discovery auth behavior

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #36567 from votdev/issue_46901_hide_limit_action_field

mgr/dashboard: Hide table action input field if limit=0

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

Merge pull request #36510 from athanatos/sjust/wip-tm-decref

crimson: remove extent from cache in TransactionManager::dec_ref

Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/os/seastore/transaction_manager: complete dec_ref

Previously, dec_ref didn't handle actually retiring the
extent from the cache.  dec_ref will now reach into the
cache and mark the extent retired if it exists either
in the cache or in the current transaction.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/lba_manager: clarify ref count operation return

Previously, we returned a refcount from inc_ref and dec_ref.  Now,
return the paddr as well for future code accounting for released
extents.

In addition, replumb btree_lba_manager to return an enoent error if
the mapping does not exist, and the resulting refcount, paddr
otherwise with a refcount of 0 indicating that the mapping has
been removed.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/cache: don't mark invalid extents clean

In the event that an extent is created and removed in the same
transaction (invalid extent in fresh_block_list), update
block specific metadata but don't add to cache and especially
do not mark clean.  LBAManager::complete_commit implementations
are meant to use skip based on state in the same way.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/cached_extent: add print_detail for logical extents

This way we can always see laddr in debug output.

Signed-off-by: Samuel Just <sjust@redhat.com>

Merge pull request #36591 from idryomov/wip-snap-create-progress

qa: update krbd tests for snap create

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36434 from ricardoasmarques/fix-iscsi-logged-in-client-edit

mgr/dashboard: Unable to edit iSCSI logged-in client

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #36564 from ceph/46899-log-info-from-unhandled-errors

mgr/dashboard: log useful information from internal server errors

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Fabrizio D'Angelo <fdangelo@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>

mgr/dashboard: Fix favicon white circle

A white circle was displayed when the user logged out.

Fixes: https://tracker.ceph.com/issues/46919
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Fix spell errors

Fixes: https://tracker.ceph.com/issues/46917
Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Proper format iSCSI target portals

Proper format the 'Portals' and 'Images' columns.

Fixes: https://tracker.ceph.com/issues/46908
Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #36532 from simon-rock/crash_on_restart

mds : move start_files_to_recover() to recovery_done

mds : move start_files_to_recover()  to recovery_done

the requests in the queue, named waiting_for_replay, may modify the state of the filelock,
resulting in the wrong lock state when repairing file (start_files_to_recover)

Fixes : https://tracker.ceph.com/issues/46906
Signed-off-by: Simon Gao <simon29rock@gmail.com>

Merge pull request #36119 from votdev/issue_44831_deploy_service

mgr/dashboard: Create Ceph services via Orchestrator by using ServiceSpec

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

qa: update krbd tests for snap create

"rbd snap create" now reports progress.  Pass --no-progress, as in
commit b5a5fea9e2b4 ("test/cli-integration/rbd: tweak after snap create
started to show progress").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #36569 from yuriw/wip-yuriw-crontab-master

qa/tests: use "-k distro" for all suites (except krbd)

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #36570 from theanalyst/doc/releases/v14.2.11

doc: releases: notes for v14.2.11 nautilus

Reviewed-By: Neha Ojha <nojha@redhat.com>
Reviewed-By: Josh Durgin <jdurgin@redhat.com>
Reviewed-By: Patrick Donelly <pdonell@redhat.com>

mgr/dashboard: log useful information from internal server errors

Fixes: https://tracker.ceph.com/issues/46899
Signed-off-by: Alfonso Martínez <almartin@redhat.com>

mgr/dashboard: Strange iSCSI discovery auth behavior

Disable 'autocomplete' for the user and password form fields.

Fixes: https://tracker.ceph.com/issues/46900
Signed-off-by: Volker Theile <vtheile@suse.com>

doc: releases: notes for v14.2.11 nautilus

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #36550 from tspmelo/wip-npm-update

mgr/dashboard: Update npm packages

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #36565 from jan--f/c-v-py3-flake8

ceph-volume: run flake8 in python3

Merge PR #36351 into master

* refs/pull/36351/head:
qa/tasks/cephfs/nfs: Add tests for cluster config set and reset
doc/cephfs/nfs: Update the doc about 'reset' and 'set' config interfaces
mgr/volumes/nfs: Add interface for adding user defined configuration

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

qa/tests: use "-k distro" for all suites (except krbd)

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #36437 from yuriw/wip-yuriw-crontab-master

qa/tests: changes related to #36435 and #36436

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #36111 from vosdev/patch-2

doc/mgr/dashboard: Fix haproxy example to use ssl for backends

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

mgr/dashboard: Hide table action input field if limit=0

Fixes: https://tracker.ceph.com/issues/46901
Signed-off-by: Volker Theile <vtheile@suse.com>

Merge pull request #36456 from sebastian-philipp/orch-type-py3

mgr/orch: _interface.py cleanup: PEP8 and type annotations

Reviewed-by: Joshua Schmid <jschmid@suse.de>

ceph-volume: run flake8 in pyhton3

Fixes: https://tracker.ceph.com/issues/46897
Signed-off-by: Jan Fajerski <jfajerski@suse.com>

Merge pull request #36431 from rishabh-d-dave/cv-add-tests-for-new-lvm-functions

ceph-volume: add tests for new functions that run LVM commands

Merge pull request #35937 from rishabh-d-dave/cv-rm-container-classes

ceph-volume: remove container classes from api/lvm.py

Merge pull request #36425 from majianpeng/rocksdb-remove-redundant-perfcount

kv/RocksdbStore: remove perfcounter l_rocksdb_txns/l_rocksdb_txns_sync

Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>

Merge pull request #36528 from dmick/wip-ctags

cmake: don't include tags for Python imports, .tox, build/ dirs

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36538 from zdover23/wip-docs-45678-fix

doc/cephadm: Remove shell alias

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>

cmake: don't include tags for Python imports, .tox, build/ dirs

For things like cephadm, where there is a lot of "from X import Y",
the import tags become cumbersome.  .tox dirs and
python-common/build are just repeats of source files found elsewhere
so result in duplicate tags

Signed-off-by: Dan Mick <dmick@redhat.com>

mgr/dashboard: Update npm packages

Fixes: https://tracker.ceph.com/issues/46888
Signed-off-by: Tiago Melo <tmelo@suse.com>

Merge PR #36221 into master

* refs/pull/36221/head:
client: switch lock_guard to scoped_lock
client: remove useless unsafe_sync_write
client: make the root member under the client_lock
client: add mount/initialize states support and convert to RWRef
client: add RWRef support

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #36487 into master

* refs/pull/36487/head:
mds: avoid calling g_conf().get_val() in MDSRank::heartbeat_reset()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36522 from kalebskeithley/rgw_rados_h

rgw: remove unnecessary #include "rgw_rados.h"

Merge PR #32731 into master

* refs/pull/32731/head:
mgr/mds_autoscaler: plugin to configure mds instances

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #35161 into master

* refs/pull/35161/head:
mgr/mgr_module: metadata is fetched async
mgr/status: metadata is fetched async

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36548 from votdev/fix_colors

mgr/dashboard: correct color names which are not defined

Reviewed-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: correct color names which are not defined

Fix regression introduced by https://github.com/ceph/ceph/pull/35954.
Rename some color names that have been changed by the mentioned PR.

Signed-off-by: Volker Theile <vtheile@suse.com>

Merge PR #36547 into master

* refs/pull/36547/head:
client: add on space before the inode info

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #34869 from linuxbox2/wip-reset-stats2

rgw: introduce safe user-reset-stats

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #35316 from cbodley/wip-45771

rgw: fix shutdown crash in RGWAsyncReadMDLogEntries

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #35597 from soumyakoduri/http_client_fix

rgw: Empty reqs_change_state queue before unregistered_reqs

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #36015 from cbodley/wip-46456

cls/rgw: preserve olh entry's name on last unlink

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #36516 from tchaikov/wip-crimson-parse-conffile

crimson/common: read conf file in async

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #36069 from mkogan1/wip-fix-endpoint-not-connected-r1

rgw: improve scheduler log

Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>

Merge pull request #35792 from thmour/theo_rgw_url_test

rgw: fix double slash (//) killing the gateway

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #36082 from winndows/superfluous_break3

rgw: Remove superfluous breaks

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36084 from winndows/superfluous_break9

rgw: Remove superfluous breaks

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #36092 from Huber-ming/dump_RGWLifecycleConfiguration

rgw: dump transitions in RGWLifecycleConfiguration::dump()

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36264 from theanalyst/rgw/bucket-not-impl

rgw: s3: mark bucket encryption as not implemented

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #36303 from theanalyst/rgw/empty-princ-policy

rgw: policy: reuse eval_principal to evaluate the policy principal

Reviewed-by: Pritha Srivastava <prsivas@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #35954 from SchoolGuy/dashboard/bootrapify

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

crimson/common: read conf file in async

otherwise seastar's stall detector could complain, if the task takes too
long to complete.

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/config: extract md_config_t::parse_buffer()

so we can reuse it in crimson.

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/ConfUtils: expose parse_buffer()

so it can be used by crimson for reading settings from a conf file.
crimson reads file with async read. since we already have a specialized
ConfigProxy for crimson, it'd be simpler to expose the shared facility
from ConfUtils instead of specializing it in ConfUtils.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/osd: use "ceph" for default cluster_name

for couple reasons:

* to avoid the pain to guess / update the cluster name when loading
  conf file. in the past, we use "ceph" as a fallback for the cluster
  name, which is in turn used as a meta name when expanding setting
  values containing "$cluster". so to ensure those settings continue
  working, we have to at least set cluster_name a safe value, and
  "ceph" is what we've been using.
* in
  http://lists.ceph.com/pipermail/ceph-users-ceph.com/2017-June/018519.html,
  we decided to drop the cluster_name support in deploy tools, and to
  keep this feature in code. so in the long run, we can assume
  new clusters will be all named "ceph".
* it's difficult to properly implement the feature to use "ceph",
  if no --conf option is specified, as, in Ceph, even the path pointing
  to conf file is allowed to contain "$cluster". so, to get it
  right, we need to update cluster name stored in options before
  reading the option files, this forces us to populate the setting
  twice when reading the settings from a conf file. or we could
  specialize the process, but i don't think it worthy of the
  efforts.

so i think we can just use "ceph" for the cluster name in crimson.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/common: move ConfigProxy::parse_config_files() into .cc

prepare for a proper async version, which will be a little bit more
complicated than the existing one, so better off moving it into .cc file.

Signed-off-by: Kefu Chai <kchai@redhat.com>

client: add on space before the inode info

Signed-off-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #36150 from rhcs-dashboard/fix-45414-master

mgr/dashboard: Improve notification badge

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/dashboard: Add a paragraph for the future Bootstrap 4

Fixes: https://tracker.ceph.com/issues/46382
Signed-off-by: Enno Gotthold <egotthold@suse.de>

mgr/dashboard: SCSS: Replaced usage of baseclass with specific

The SCSS class cd-col-form-label is the specific and correct class to use. Previously sometimes the class col-form-label was used.

Fixes: https://tracker.ceph.com/issues/46382
Signed-off-by: Enno Gotthold <egotthold@suse.de>

mgr/dashboard: SCSS cleanup

Removes unnecessary variables and uses already existing bootstrap variables instead.

Also we removed uneffective SCSS, as well as moved the Navtabs SCSS code into a module Bootstrap style

Last but not least we cleaned up toast & tooltip SCSS.

Fixes: https://tracker.ceph.com/issues/46382
Signed-off-by: Sebastian Krah <skrah@suse.com>
Signed-off-by: Enno Gotthold <egotthold@suse.de>

qa/tasks/cephfs/nfs: Add tests for cluster config set and reset

Signed-off-by: Varsha Rao <varao@redhat.com>

rgw: remove unnecessary #include "rgw_rados.h"

rgw_rados.h not needed for compile

see https://tracker.ceph.com/issues/46880

Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>

doc/cephfs/nfs: Update the doc about 'reset' and 'set' config interfaces

Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/volumes/nfs: Add interface for adding user defined configuration

Code related to creating and removing rados object has been rearranged abd
modified. This patch introduces interface to set and reset user config.

nfs cluster config set <clusterid> -i <config_file>
nfs cluster config reset <clusterid>

Fixes: https://tracker.ceph.com/issues/45747
Signed-off-by: Varsha Rao <varao@redhat.com>

Merge pull request #36399 from jhgorrell/harley/add-missing-laggy-state-1

mgr: Add missing states to PG_STATES in mgr_module.py.

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #36424 from ghyer/ghyer-MonOpRequest

mon: add "duration" field for monitors' operation log.

Reviewed-by: Joao Eduardo Luis <joao@suse.de>

Merge pull request #36499 from tchaikov/wip-redirect-stderr

qa/tasks/ceph: redirect stderr for crimson flavor

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #34289 from Synesis-LLC/pool_stats_pg_merge

mgr: decrease pool stats if pg was removed

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #33299 from joscollin/wip-fix-releases

src/: fixed error message

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

ceph-volume: relocate the new LVM methods

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: remove api.lvm.get_api_lvs() and related tests

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: remove api.lvm.get_api_vgs() and related tests

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: remove api.lvm.get_api_pvs()

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: remove class Volumes from api/lvm.py

And remove methods is_lv(), get_lv() and get_lv_from_argument() since
these methods uses class Volumes and get_first_lv() or get_lv() can be
easily used instead when needed in future.

Also, update tests and comments accordingly.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: remove class VolumeGroups from api/lvm.py

And remove get_vg() since its based on VolumesGroups and get_first_vg()
or get_vg() can be easily used instead in future when needed. Also,
update tests accordingly.

iSigned-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: remove PVolumes from api/lvm.py

And method get_pv() since it's based on PVolumes and get_first_pv() and
get_pvs() can be easily used instead in future. Also, update tests
accordingly.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

ceph-volume: add tests for new functions that run LVM commands

... and for supporting functions. Specifically, these functions are
get_pvs(), get_vgs(), get_lvs(), get_first_pv(), get_first_vg(),
get_first_lv() and make_filters_lvmcmd_ready().

Signed-off-by: Rishabh Dave <ridave@redhat.com>

doc/cephadm: Remove shell alias

Turns out, the alias doesn't work for files.

Fixes: https://tracker.ceph.com/issues/46701
Fixes:

```
$ ceph orch apply -i myfile.yaml
ERROR: no such file or directory: myfile.yaml
```

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #36520 from rzarzynski/wip-crimson-dissect-pgopsexecuter

crimson/osd: dissect PgOpsExecuter from OpsExecuter

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #36497 from sebastian-philipp/mgr-cephadm-entity-newtype

mgr/cephadm: Some more typing

Reviewed-by: Michael Fritch <mfritch@suse.com>

crimson/osd: rename execute_{osd,pg}_op() in OpsExecuters.

The reason for renaming is the duplicating the information
already present in the classes' names.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: simplify PgOpsExecuter and impove const-correctness.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: reorder definitions in ops_executer.cc.

The idea here is to move `OpsExecuter::execute_osd_op()`
closer to other method definitions of this class

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: dissect PgOpsExecuter from OpsExecuter.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #36500 from tchaikov/wip-crimson-checksum

crimson/osd: support checksum op and chop off consumed chunk from indata.

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #36492 from ricardoasmarques/prevent-unnecessary-ssh-reconfiguration

mgr/cephadm: Prevent unnecessary SSH reconfiguration

Merge pull request #36481 from tchaikov/wip-remove-BatchWorkQueue

common/WorkQueue: remove unused BatchWorkQueue

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>