]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agocrimson/cmake: fix copy&paste error 36907/head
ylifshit@redhat.com [Mon, 31 Aug 2020 16:32:54 +0000 (19:32 +0300)]
crimson/cmake: fix copy&paste error

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agocrimson/cmake: make libraries static to prevent cmake error
Yuval Lifshitz [Mon, 31 Aug 2020 09:58:18 +0000 (12:58 +0300)]
crimson/cmake: make libraries static to prevent cmake error

Fixes: https://tracker.ceph.com/issues/47209
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agoMerge pull request #36839 from dillaman/wip-46875
Mykola Golub [Mon, 31 Aug 2020 05:59:06 +0000 (08:59 +0300)]
Merge pull request #36839 from dillaman/wip-46875

librbd: flush all incomplete in-flight IOs upon image close

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #36819 from vumrao/wip-vumrao-46663
Kefu Chai [Mon, 31 Aug 2020 05:31:34 +0000 (13:31 +0800)]
Merge pull request #36819 from vumrao/wip-vumrao-46663

mon/PGMap: add pg count for pools in the ceph df command

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #33852 from rosinL/wip-fix-enqueue-dead-qp-deadlock
Kefu Chai [Mon, 31 Aug 2020 02:39:02 +0000 (10:39 +0800)]
Merge pull request #33852 from rosinL/wip-fix-enqueue-dead-qp-deadlock

msg/async/rdma: avoid enqueue_dead_qp deadlock

Reviewed-by: Peng Liu <liupeng37@baidu.com>
4 years agoMerge pull request #36767 from tchaikov/wip-47061
Kefu Chai [Sun, 30 Aug 2020 15:21:32 +0000 (23:21 +0800)]
Merge pull request #36767 from tchaikov/wip-47061

test/osd/RadosModel: check retval of read op

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agotest/osd/RadosModel: assure that tid seq is contiguous 36767/head
Kefu Chai [Mon, 24 Aug 2020 13:49:28 +0000 (21:49 +0800)]
test/osd/RadosModel: assure that tid seq is contiguous

before this change:

4:  finishing write tid 1 to gen81094472-1
4:  finishing write tid 2 to gen81094472-1
4:  finishing write tid 3 to gen81094472-1
4:  finishing write tid 5 to gen81094472-1
4:  finishing write tid 6 to gen81094472-1

after this change:

1:  finishing write tid 1 to gen81117124-1
1:  finishing write tid 2 to gen81117124-1
1:  finishing write tid 3 to gen81117124-1
1:  finishing write tid 4 to gen81117124-1
1:  finishing write tid 5 to gen81117124-1

more pleasant when reading the logging messages.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: check retval of read op
Kefu Chai [Mon, 24 Aug 2020 11:06:11 +0000 (19:06 +0800)]
test/osd/RadosModel: check retval of read op

* check racing read's return value
* check if racing read completes

Fixes: https://tracker.ceph.com/issues/47061
Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: do not set done
Kefu Chai [Mon, 24 Aug 2020 10:35:22 +0000 (18:35 +0800)]
test/osd/RadosModel: do not set done

we don't reuse TestOp, and `done` should have been reset in the
constructor.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: use range-based for loop
Kefu Chai [Mon, 24 Aug 2020 10:34:42 +0000 (18:34 +0800)]
test/osd/RadosModel: use range-based for loop

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: use in-class initiailization
Kefu Chai [Mon, 24 Aug 2020 10:34:06 +0000 (18:34 +0800)]
test/osd/RadosModel: use in-class initiailization

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd: use stack for ObjectDesc::iterator::stack
Kefu Chai [Mon, 24 Aug 2020 09:11:40 +0000 (17:11 +0800)]
test/osd: use stack for ObjectDesc::iterator::stack

better readability this way

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36815 from sebastian-philipp/cephadm-pep8-module
Sebastian Wagner [Sat, 29 Aug 2020 21:49:13 +0000 (23:49 +0200)]
Merge pull request #36815 from sebastian-philipp/cephadm-pep8-module

mgr/cephadm: PEP8tify module.py

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agomgr/cephadm: PEP8tify module.py 36815/head
Sebastian Wagner [Sat, 29 Aug 2020 18:41:20 +0000 (20:41 +0200)]
mgr/cephadm: PEP8tify module.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36858 from adk3798/cephadm-47171
Sebastian Wagner [Sat, 29 Aug 2020 18:25:11 +0000 (20:25 +0200)]
Merge pull request #36858 from adk3798/cephadm-47171

mgr/cephadm: Verify non-empty list in get_active_daemon functions

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36849 from sebastian-philipp/cephadm-kick-when-monmap
Sebastian Wagner [Sat, 29 Aug 2020 18:24:42 +0000 (20:24 +0200)]
Merge pull request #36849 from sebastian-philipp/cephadm-kick-when-monmap

mgr/cephadm: kick serve loop to trigger ceph.conf deployment

Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #36753 from sebastian-philipp/mgr-cephadm-schedule-redeploy
Sebastian Wagner [Sat, 29 Aug 2020 18:24:11 +0000 (20:24 +0200)]
Merge pull request #36753 from sebastian-philipp/mgr-cephadm-schedule-redeploy

mgr/cephadm: Make daemon actions asynchronous

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #35891 from changchengx/multi_stress_watch
Kefu Chai [Sat, 29 Aug 2020 15:50:59 +0000 (23:50 +0800)]
Merge pull request #35891 from changchengx/multi_stress_watch

test/multi_stress_watch: use internel API to connect cluster

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36868 from zhoufeng2021/removeunsed
Kefu Chai [Sat, 29 Aug 2020 15:49:52 +0000 (23:49 +0800)]
Merge pull request #36868 from zhoufeng2021/removeunsed

msg/async: cleanup unused function local_deliver()

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: use insert_or_assign()
Kefu Chai [Mon, 24 Aug 2020 08:21:50 +0000 (16:21 +0800)]
test/osd/RadosModel: use insert_or_assign()

for better performance, and less repeatings.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: add more comments
Kefu Chai [Mon, 24 Aug 2020 08:21:29 +0000 (16:21 +0800)]
test/osd/RadosModel: add more comments

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/osd/RadosModel: rename local variable
Kefu Chai [Mon, 24 Aug 2020 05:21:26 +0000 (13:21 +0800)]
test/osd/RadosModel: rename local variable

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36888 from batrick/release-notes-union
Kefu Chai [Sat, 29 Aug 2020 14:13:04 +0000 (22:13 +0800)]
Merge pull request #36888 from batrick/release-notes-union

doc: use union merge strategy for resolving conflicts in PendingRelea…

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36886 from batrick/librados-statfs-header
Kefu Chai [Sat, 29 Aug 2020 06:56:01 +0000 (14:56 +0800)]
Merge pull request #36886 from batrick/librados-statfs-header

librados: remove unused header

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agomsg/async/rdma: avoid enqueue_dead_qp deadlock 33852/head
Chunsong Feng [Mon, 17 Aug 2020 11:59:34 +0000 (19:59 +0800)]
msg/async/rdma: avoid enqueue_dead_qp deadlock

In RDMADispatcher::handle_async_event, when case
IBV_EVENT_QP_LAST_WQE_REACHED matched, enqueue_dead_qp wants the lock,
result in deadlock here. Change enqueue_dead_qp to lockless.

Fixes: https://tracker.ceph.com/issues/44298
Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Signed-off-by: luorixin <luorixin@huawei.com>
4 years agolibrados: remove unused headers 36886/head
Patrick Donnelly [Fri, 28 Aug 2020 17:14:49 +0000 (10:14 -0700)]
librados: remove unused headers

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agodoc: use union merge strategy for resolving conflicts in PendingReleaseNotes 36888/head
Patrick Donnelly [Sat, 29 Aug 2020 01:02:59 +0000 (18:02 -0700)]
doc: use union merge strategy for resolving conflicts in PendingReleaseNotes

Generally, the conflict resolution performed manually is always to do a
union: automate this. This avoids pointless rebases of PRs.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36701 into master
Patrick Donnelly [Sat, 29 Aug 2020 00:48:44 +0000 (17:48 -0700)]
Merge PR #36701 into master

* refs/pull/36701/head:
client: make Client::open() pass proper cap mask to path_walk

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36641 into master
Patrick Donnelly [Sat, 29 Aug 2020 00:48:15 +0000 (17:48 -0700)]
Merge PR #36641 into master

* refs/pull/36641/head:
mds : skip show_cache if level of log is lower than 7

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zheng Yan <zyan@redhat.com>
4 years agoMerge PR #36882 into master
Patrick Donnelly [Fri, 28 Aug 2020 20:31:07 +0000 (13:31 -0700)]
Merge PR #36882 into master

* refs/pull/36882/head:
qa/tests: Added "--force-priority"

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #36729 from changchengx/zero_malloc
Kefu Chai [Fri, 28 Aug 2020 15:21:27 +0000 (23:21 +0800)]
Merge pull request #36729 from changchengx/zero_malloc

crush: do not malloc for empty bucket and avoid member variables after memset() with 0

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36820 from tchaikov/wip-test-multi_stress_watch
Kefu Chai [Fri, 28 Aug 2020 15:17:05 +0000 (23:17 +0800)]
Merge pull request #36820 from tchaikov/wip-test-multi_stress_watch

test/multi_stress_watch: use condition_variable for level triggering

Reviewed-By: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #36832 from neha-ojha/wip-clean-temps
Kefu Chai [Fri, 28 Aug 2020 15:14:26 +0000 (23:14 +0800)]
Merge pull request #36832 from neha-ojha/wip-clean-temps

tools/osdmaptool.cc: add ability to clean_temps

Reviewed-By: Josh Durgin <jdurgin@redhat.com>
4 years agoqa/tests: Added "--force-priority" 36882/head
Yuri Weinstein [Fri, 28 Aug 2020 14:35:25 +0000 (07:35 -0700)]
qa/tests: Added "--force-priority"

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
4 years agoMerge pull request #36854 from idryomov/wip-krbd-default-pool-fix
Ilya Dryomov [Fri, 28 Aug 2020 11:04:52 +0000 (13:04 +0200)]
Merge pull request #36854 from idryomov/wip-krbd-default-pool-fix

rbd: fix default pool handling for krbd map/unmap

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agomon/PGMap: add pg count for pools in the ceph df command 36819/head
Vikhyat Umrao [Wed, 26 Aug 2020 10:17:05 +0000 (03:17 -0700)]
mon/PGMap: add pg count for pools in the ceph df command
Fixes: https://tracker.ceph.com/issues/46663
Signed-off-by: Vikhyat Umrao <vikhyat@redhat.com>
4 years agoMerge pull request #36866 from yison/fix-core-dump-issue-of-sync-read
Kefu Chai [Fri, 28 Aug 2020 08:47:51 +0000 (16:47 +0800)]
Merge pull request #36866 from yison/fix-core-dump-issue-of-sync-read

blk/spdk/NVMEDevice.cc: fix a core dump issue of sync read

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoblk/spdk/NVMEDevice.cc: fix a core dump issue of sync read 36866/head
Yuan Lu [Fri, 28 Aug 2020 18:27:50 +0000 (18:27 +0000)]
blk/spdk/NVMEDevice.cc: fix a core dump issue of sync read

Signed-off-by: Yuan Lu <yuan.y.lu@intel.com>
4 years agomsg/async: cleanup unused function local_deliver() 36868/head
zhoufeng [Fri, 28 Aug 2020 08:20:19 +0000 (16:20 +0800)]
msg/async: cleanup unused function local_deliver()

Signed-off-by: zhoufeng <zhoufeng2021@outlook.com>
4 years agoMerge pull request #36802 from dillaman/wip-46916
Mykola Golub [Fri, 28 Aug 2020 08:17:08 +0000 (11:17 +0300)]
Merge pull request #36802 from dillaman/wip-46916

librbd: expose internal plugin API to plugin libraries

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agomgr/cephadm: add test_daemon_check 36753/head
Sebastian Wagner [Fri, 21 Aug 2020 15:38:33 +0000 (17:38 +0200)]
mgr/cephadm: add test_daemon_check

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agomgr/cephadm: Make daemon actions asynchronous
Sebastian Wagner [Fri, 21 Aug 2020 14:25:31 +0000 (16:25 +0200)]
mgr/cephadm: Make daemon actions asynchronous

Fixes broken `ceph orch redeploy <current active mgr>`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agomgr/cephadm: add scheduled_daemon_actions to HostCache
Sebastian Wagner [Fri, 21 Aug 2020 09:44:15 +0000 (11:44 +0200)]
mgr/cephadm: add scheduled_daemon_actions to HostCache

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agomgr/cephadm: move fail_over from upgrade.py to MgrService
Sebastian Wagner [Wed, 19 Aug 2020 10:39:39 +0000 (12:39 +0200)]
mgr/cephadm: move fail_over from upgrade.py to MgrService

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agomgr/cephadm: _wait_for_ok_to_stop: add missing f-prefix
Sebastian Wagner [Wed, 19 Aug 2020 10:25:18 +0000 (12:25 +0200)]
mgr/cephadm: _wait_for_ok_to_stop: add missing f-prefix

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agomgr/cephadm: _create_daemon: remove usused parameter
Sebastian Wagner [Wed, 19 Aug 2020 10:12:00 +0000 (12:12 +0200)]
mgr/cephadm: _create_daemon: remove usused parameter

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agomgr/orch: daemon redeploy: Fix missing default value
Sebastian Wagner [Wed, 19 Aug 2020 10:10:04 +0000 (12:10 +0200)]
mgr/orch: daemon redeploy: Fix missing default value

Fixes: https://tracker.ceph.com/issues/47035
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36792 from sebastian-philipp/cephadm-pep8-inventory
Sebastian Wagner [Fri, 28 Aug 2020 07:24:36 +0000 (09:24 +0200)]
Merge pull request #36792 from sebastian-philipp/cephadm-pep8-inventory

mgr/cephadm: PEP8tify inventory.py

Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #36848 from sebastian-philipp/cephadm-no-pep8-test_scheduling
Sebastian Wagner [Fri, 28 Aug 2020 07:20:54 +0000 (09:20 +0200)]
Merge pull request #36848 from sebastian-philipp/cephadm-no-pep8-test_scheduling

mgr/cephadm: disable autopep8 for test_{spec,scheduling}.py

Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #29489 from jan--f/cephfs-snap-schedule
Venky Shankar [Fri, 28 Aug 2020 04:21:53 +0000 (09:51 +0530)]
Merge pull request #29489 from jan--f/cephfs-snap-schedule

pybind/snap_schedule: add initial interface

4 years agoMerge pull request #34566 from X0Ken/master
Kefu Chai [Fri, 28 Aug 2020 03:01:41 +0000 (11:01 +0800)]
Merge pull request #34566 from X0Ken/master

os/bluestore: Support flock retry

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #36507 from matthewoliver/msgr_intercepter_step_enum
Kefu Chai [Fri, 28 Aug 2020 02:51:16 +0000 (10:51 +0800)]
Merge pull request #36507 from matthewoliver/msgr_intercepter_step_enum

msgr: interceptor test step enum to ease readability

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #36762 from qwren/qat-doc-update
Kefu Chai [Fri, 28 Aug 2020 02:48:52 +0000 (10:48 +0800)]
Merge pull request #36762 from qwren/qat-doc-update

doc: the update for QAT Acceleration

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge PR #35941 into master
Patrick Donnelly [Fri, 28 Aug 2020 02:11:30 +0000 (19:11 -0700)]
Merge PR #35941 into master

* refs/pull/35941/head:
doc/mgr: Supplement missing keywords 'crash'

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agomgr/cephadm: Verify non-empty list in get_active_daemon functions 36858/head
Adam King [Thu, 27 Aug 2020 16:22:49 +0000 (12:22 -0400)]
mgr/cephadm: Verify non-empty list in get_active_daemon functions

The get_active_daemon functions for monitoring stack daemons
were just returning the first or last daemon in the given list
without checking the list actually contained any daemons

Fixes: https://tracker.ceph.com/issues/47171
Signed-off-by: Adam King <adking@redhat.com>
4 years agotest/cli/osdmaptool/help.t: add clean-temps 36832/head
Neha Ojha [Wed, 26 Aug 2020 18:40:01 +0000 (18:40 +0000)]
test/cli/osdmaptool/help.t: add clean-temps

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years agodoc: add clean-temps to osdmaptool.rst
Neha Ojha [Wed, 26 Aug 2020 18:37:58 +0000 (18:37 +0000)]
doc: add clean-temps to osdmaptool.rst

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years agotools/osdmaptool.cc: add ability to clean_temps
Neha Ojha [Wed, 26 Aug 2020 18:08:03 +0000 (18:08 +0000)]
tools/osdmaptool.cc: add ability to clean_temps

This is particularly useful for debugging purposes when clean_temps()
takes abnormally high amount of time due to flaws in crush rules etc.

Fixes: https://tracker.ceph.com/issues/47159
Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #36572 from dmick/wip-cephadm-doc
Sebastian Wagner [Thu, 27 Aug 2020 15:07:33 +0000 (17:07 +0200)]
Merge pull request #36572 from dmick/wip-cephadm-doc

doc/mgr: Clean up orchestrator.rst (spell/punct, awkward wording)

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
4 years agoMerge pull request #36750 from ifed01/wip-ifed-enable-flexible-bluefs
Kefu Chai [Thu, 27 Aug 2020 14:28:32 +0000 (22:28 +0800)]
Merge pull request #36750 from ifed01/wip-ifed-enable-flexible-bluefs

os/bluestore: enable more flexible bluefs space management by default.

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #36718 from ShraddhaAg/add-dir-to-archive-in-logs
Kefu Chai [Thu, 27 Aug 2020 14:26:01 +0000 (22:26 +0800)]
Merge pull request #36718 from ShraddhaAg/add-dir-to-archive-in-logs

qa/tasks/ceph.py: add ceph logs directory in job's info.yaml

Reviewed-By: Josh Durgin <jdurgin@redhat.com>
4 years agolibrbd: add internal API for plugin libraries 36802/head
Jason Dillaman [Tue, 25 Aug 2020 19:06:06 +0000 (15:06 -0400)]
librbd: add internal API for plugin libraries

To avoid the need to expose internal librbd symbols as public, expose
a select set of symbols via an internal plugin API for use by the
plugins.

Fixes: https://tracker.ceph.com/issues/46916
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agopybind/mgr/snap_schedule: fix imports for snap_schedule vs mgr wide tox runs 29489/head
Jan Fajerski [Wed, 12 Aug 2020 10:58:29 +0000 (12:58 +0200)]
pybind/mgr/snap_schedule: fix imports for snap_schedule vs mgr wide tox runs

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybing/mgr/snap_schedule: normalize dates to utc and ignore microseconds
Jan Fajerski [Wed, 12 Aug 2020 09:17:15 +0000 (11:17 +0200)]
pybing/mgr/snap_schedule: normalize dates to utc and ignore microseconds

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap_schedule: don't use as keyword in update statement
Jan Fajerski [Tue, 11 Aug 2020 11:50:01 +0000 (13:50 +0200)]
pybind/mgr/snap_schedule: don't use as keyword in update statement

While UPDATE <table_name> AS <alias> ... should be valid SQL syntax. It seems
like only some sqlite version support it however.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap_schedule: fix import locations for unit tests
Jan Fajerski [Mon, 10 Aug 2020 12:29:46 +0000 (14:29 +0200)]
pybind/mgr/snap_schedule: fix import locations for unit tests

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap_schedule: datetime.fromisoformat fallbacks
Jan Fajerski [Mon, 10 Aug 2020 12:26:21 +0000 (14:26 +0200)]
pybind/mgr/snap_schedule: datetime.fromisoformat fallbacks

fromisoformat was introduced in pytho3.7. This can be worked around by
either installing
https://github.com/movermeyer/backports.datetime_fromisoformat. If a
pre3.7 python is found and the backport module is not installed,
snap_schedule falls back to parsing a fully specified timestamp
format. This commit adds the necessary code.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybing/mgr/snap_schedule: guard minute repeat interval
Jan Fajerski [Thu, 6 Aug 2020 13:56:57 +0000 (15:56 +0200)]
pybing/mgr/snap_schedule: guard minute repeat interval

To enable the use of a minutely repeat interval in the snap schedules,
this adds a guard that checks for the SNAP_SCHED_TEST env variable.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap_schedule: add type hint for mypy, fix import
Jan Fajerski [Thu, 6 Aug 2020 13:51:58 +0000 (15:51 +0200)]
pybind/mgr/snap_schedule: add type hint for mypy, fix import

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap_schedule: integrate with mgr wide tox testing
Jan Fajerski [Thu, 6 Aug 2020 08:52:24 +0000 (10:52 +0200)]
pybind/mgr/snap_schedule: integrate with mgr wide tox testing

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybing/mgr/snap_schedule: add separate retention interface
Jan Fajerski [Tue, 9 Jun 2020 12:49:55 +0000 (14:49 +0200)]
pybing/mgr/snap_schedule: add separate retention interface

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybing/mgr/snap_schedule: add more unit tests
Jan Fajerski [Thu, 28 May 2020 11:47:50 +0000 (13:47 +0200)]
pybing/mgr/snap_schedule: add more unit tests

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap-schedule: fix meta uniqueness contraint
Jan Fajerski [Wed, 27 May 2020 14:02:03 +0000 (16:02 +0200)]
pybind/mgr/snap-schedule: fix meta uniqueness contraint

This adds a simple test for the Schedule.store_schedule. This test
exposed a bug (couldn't add schedule on different paths with the same
repeat and start time). Bug is also fixed.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap_schedule: add unit tests
Jan Fajerski [Thu, 14 May 2020 10:06:46 +0000 (12:06 +0200)]
pybind/mgr/snap_schedule: add unit tests

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybing/mgr/snap_sched: improve SQL statements, logging, metadata
Jan Fajerski [Tue, 19 May 2020 15:31:47 +0000 (17:31 +0200)]
pybing/mgr/snap_sched: improve SQL statements, logging, metadata

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/snap_schedule: return negative error codes
Venky Shankar [Tue, 19 May 2020 04:51:40 +0000 (00:51 -0400)]
pybind/snap_schedule: return negative error codes

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agopybind/mgr/snap_schedule: refactor Schedule ctor, make more args optional
Jan Fajerski [Thu, 14 May 2020 09:06:54 +0000 (11:06 +0200)]
pybind/mgr/snap_schedule: refactor Schedule ctor, make more args optional

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybing/mgr/snap_schedule: Add active flag to status report
Jan Fajerski [Thu, 14 May 2020 08:41:50 +0000 (10:41 +0200)]
pybing/mgr/snap_schedule: Add active flag to status report

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap-schedule: refactor schedule into two modules
Jan Fajerski [Thu, 14 May 2020 08:38:58 +0000 (10:38 +0200)]
pybind/mgr/snap-schedule: refactor schedule into two modules

This separates the Schedule class from the SnapSchedClient class.
Motivation is cleaner code layout and simpler testing.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap-schedule: add interface to de-/activate schedules
Jan Fajerski [Wed, 13 May 2020 08:42:34 +0000 (10:42 +0200)]
pybind/mgr/snap-schedule: add interface to de-/activate schedules

This allows to 1) activate schedules that have previously been
deactivated due to the path no existing and 2) allowing ussers to
explicitly deactivate a schedule for debugging or maintenance purposes.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap-schedule: list - print ws separated results
Jan Fajerski [Wed, 6 May 2020 15:09:33 +0000 (17:09 +0200)]
pybind/mgr/snap-schedule: list - print ws separated results

This should make it easy to consume for cli tools.
Also simplifies some internals.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agosnap_schedule: add metadata fields, refactor Schedule, multiple Schedules per path
Jan Fajerski [Fri, 3 Apr 2020 14:04:11 +0000 (16:04 +0200)]
snap_schedule: add metadata fields, refactor Schedule, multiple Schedules per path

This commit adds a bunch of interesting metadata fields to the DB and
refactors the Schedule class so that it concentrates all the DB queries
in on place. Also enables to set multiple schedules per path as long as
the (repeat interval, start time) pairs are unique.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agosnap-schedule: Implement pruning according to retention specfication
Jan Fajerski [Wed, 6 May 2020 13:20:32 +0000 (15:20 +0200)]
snap-schedule: Implement pruning according to retention specfication

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/snap_schedule: take snapshots according to schedule.
Jan Fajerski [Tue, 19 Nov 2019 12:35:20 +0000 (13:35 +0100)]
pybind/mgr/snap_schedule: take snapshots according to schedule.

Timers are scheduled for the next snapshot to be taken. The next Timer
is canceled in case the snapshot DB is changed. When a Timer triggers it
also schedules the next Timer.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agospec: include snap_schedule in ceph spec file
Venky Shankar [Tue, 28 Apr 2020 06:57:30 +0000 (02:57 -0400)]
spec: include snap_schedule in ceph spec file

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agosnap_schedule: add initial interface and basic CRUD ops
Jan Fajerski [Wed, 6 May 2020 13:32:17 +0000 (15:32 +0200)]
snap_schedule: add initial interface and basic CRUD ops

Storage of schedules is in an in-memory sqlite DB that gets serialized
to an rados object.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind/mgr/mgr_util: CephFSClient - add helper methods
Jan Fajerski [Wed, 6 May 2020 13:20:56 +0000 (15:20 +0200)]
pybind/mgr/mgr_util: CephFSClient - add helper methods

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybing/mgr/mgr_module: allow keyword arguments
Jan Fajerski [Thu, 16 Apr 2020 09:49:31 +0000 (11:49 +0200)]
pybing/mgr/mgr_module: allow keyword arguments

If a mgr module encounters an argument values containing a '=' parsing
switches to kwargs style parsing independent of arg position. If a
non-kw argument is encountered after the first kw argument an EINVAL
error is returned.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agorbd: rename some MapOptions instances to unmap_options 36854/head
Ilya Dryomov [Wed, 26 Aug 2020 12:35:49 +0000 (14:35 +0200)]
rbd: rename some MapOptions instances to unmap_options

It is no longer a global variable, so rename the ones that have to do
with options for unmapping (currently just "force").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 years agorbd: fix default pool handling for krbd map/unmap
Ilya Dryomov [Wed, 26 Aug 2020 12:12:29 +0000 (14:12 +0200)]
rbd: fix default pool handling for krbd map/unmap

The default pool name does not get passed to the kernel since commit
96f05a7956b3 ("rbd: delay determination of default pool name").  The
kernel ends up interpreting the image name as the pool name (and the
snapshot name as the image name).

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 years agoMerge pull request #36816 from sebastian-philipp/cephadm-pep8-osd
Sebastian Wagner [Thu, 27 Aug 2020 13:38:43 +0000 (15:38 +0200)]
Merge pull request #36816 from sebastian-philipp/cephadm-pep8-osd

mgr/cephadm: PEP8tify services/osd.py

Reviewed-by: Adam King <adking@redhat.com>
4 years agoMerge pull request #36830 from tchaikov/wip-crimson-recovery-cleanup
Kefu Chai [Thu, 27 Aug 2020 13:31:24 +0000 (21:31 +0800)]
Merge pull request #36830 from tchaikov/wip-crimson-recovery-cleanup

crimson/osd: recovery related cleanup

Reviewed-by: Xuehan Xu <xxhdx1985126@163.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #36841 from matthewoliver/cephadm_iscsi_dev_volumemount
Sebastian Wagner [Thu, 27 Aug 2020 13:23:58 +0000 (15:23 +0200)]
Merge pull request #36841 from matthewoliver/cephadm_iscsi_dev_volumemount

cephadm: Give better access to the /dev in the iscsi container

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36811 from sebastian-philipp/mgr-always-mock-rados
Sebastian Wagner [Thu, 27 Aug 2020 12:50:46 +0000 (14:50 +0200)]
Merge pull request #36811 from sebastian-philipp/mgr-always-mock-rados

pybind/mgr: pytest: Unconditionally mock the rados objects

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
4 years agoMerge pull request #36844 from BryceCao/wip-correct-log-output
Daniel Gryniewicz [Thu, 27 Aug 2020 12:30:00 +0000 (08:30 -0400)]
Merge pull request #36844 from BryceCao/wip-correct-log-output

rgw: correct log output when decode bucket CORS attr

4 years agoMerge pull request #36736 from ceph/47052-fix-base-uri-api-tests
Laura Paduano [Thu, 27 Aug 2020 12:27:08 +0000 (14:27 +0200)]
Merge pull request #36736 from ceph/47052-fix-base-uri-api-tests

mgr/dashboard: fix API tests: Invalid URL: None/api/auth

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Ernesto Puertat <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
4 years agoMerge pull request #36818 from sebastian-philipp/orch-pep8
Sebastian Wagner [Thu, 27 Aug 2020 12:03:10 +0000 (14:03 +0200)]
Merge pull request #36818 from sebastian-philipp/orch-pep8

mgr/orchestrator: PEP8tify

Reviewed-by: Adam King <adking@redhat.com>
4 years agoMerge pull request #36590 from votdev/issue_46903_prevent_select_events
Lenz Grimmer [Thu, 27 Aug 2020 10:33:01 +0000 (12:33 +0200)]
Merge pull request #36590 from votdev/issue_46903_prevent_select_events

mgr/dashboard: Datatable catches select events from other datatables

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #36599 from votdev/issue_46915_login_autocomplete
Lenz Grimmer [Thu, 27 Aug 2020 10:15:17 +0000 (12:15 +0200)]
Merge pull request #36599 from votdev/issue_46915_login_autocomplete

mgr/dashboard: Disable autocomplete on user form

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #36799 from mgfritch/cephadm-iscsi-check-mon-command
Sebastian Wagner [Thu, 27 Aug 2020 10:03:56 +0000 (12:03 +0200)]
Merge pull request #36799 from mgfritch/cephadm-iscsi-check-mon-command

mgr/cephadm: use `check_mon_command` during iscsi config