]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agorgw : add URL encode toward bucket name in forward request 37340/head
caolei [Wed, 20 May 2020 09:28:15 +0000 (17:28 +0800)]
rgw : add URL encode toward bucket name in forward request

Signed-off-by: caolei <halei15848934852@163.com>
(cherry picked from commit 1e4ec14dd0df4e9053ef630c831c93d392508417)

4 years agoMerge pull request #37182 from callithea/wip-47414-octopus
Lenz Grimmer [Wed, 23 Sep 2020 08:55:51 +0000 (10:55 +0200)]
Merge pull request #37182 from callithea/wip-47414-octopus

octopus: mgr/dashboard: increase Grafana iframe height to avoid scroll bar

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
4 years agoMerge pull request #36899 from callithea/wip-47199-octopus
Lenz Grimmer [Wed, 23 Sep 2020 08:49:47 +0000 (10:49 +0200)]
Merge pull request #36899 from callithea/wip-47199-octopus

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #37092 from neha-ojha/wip-47195-octopus
Yuri Weinstein [Tue, 22 Sep 2020 13:21:05 +0000 (06:21 -0700)]
Merge pull request #37092 from neha-ojha/wip-47195-octopus

octopus: os/bluestore: enable more flexible bluefs space management by default.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #36901 from callithea/wip-47197-octopus
Lenz Grimmer [Tue, 22 Sep 2020 11:52:53 +0000 (13:52 +0200)]
Merge pull request #36901 from callithea/wip-47197-octopus

octopus: mgr/dashboard: Disable autocomplete on user form

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #36874 from callithea/wip-46345-octopus
Lenz Grimmer [Tue, 22 Sep 2020 11:51:09 +0000 (13:51 +0200)]
Merge pull request #36874 from callithea/wip-46345-octopus

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
4 years agoMerge pull request #36872 from callithea/wip-46972-octopus
Lenz Grimmer [Tue, 22 Sep 2020 11:48:50 +0000 (13:48 +0200)]
Merge pull request #36872 from callithea/wip-46972-octopus

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #36870 from callithea/wip-46970-octopus
Lenz Grimmer [Tue, 22 Sep 2020 10:02:01 +0000 (12:02 +0200)]
Merge pull request #36870 from callithea/wip-46970-octopus

octopus: mgr/dashboard: Proper format iSCSI target portals

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoMerge pull request #37285 from idryomov/wip-krbd-noudev-octopus
Ilya Dryomov [Tue, 22 Sep 2020 07:51:11 +0000 (09:51 +0200)]
Merge pull request #37285 from idryomov/wip-krbd-noudev-octopus

octopus: krbd: optionally skip waiting for udev events

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37164 from dillaman/wip-47099-octopus
Yuri Weinstein [Mon, 21 Sep 2020 16:28:07 +0000 (09:28 -0700)]
Merge pull request #37164 from dillaman/wip-47099-octopus

octopus: librbd: using migration abort can result in the loss of data

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
4 years agoqa: add test for mapping and unmapping from a network namespace 37285/head
Ilya Dryomov [Wed, 16 Sep 2020 14:38:10 +0000 (16:38 +0200)]
qa: add test for mapping and unmapping from a network namespace

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit d2884adb1542de7a43f82eb899056aa74de95052)

4 years agoMerge pull request #36871 from callithea/wip-46933-octopus
Lenz Grimmer [Mon, 21 Sep 2020 12:35:40 +0000 (14:35 +0200)]
Merge pull request #36871 from callithea/wip-46933-octopus

octopus: mgr/dashboard: Fix for CrushMap viewer items getting compressed vertically

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 years agoMerge pull request #36953 from ceph/wip-octopus-bz1872983
Jan Fajerski [Fri, 18 Sep 2020 14:19:40 +0000 (16:19 +0200)]
Merge pull request #36953 from ceph/wip-octopus-bz1872983

octopus: ceph-volume: simple scan should ignore tmpfs

4 years agoMerge pull request #36928 from jan--f/wip-47237-octopus
Jan Fajerski [Fri, 18 Sep 2020 14:18:55 +0000 (16:18 +0200)]
Merge pull request #36928 from jan--f/wip-47237-octopus

octopus: ceph-volume: support for mpath devices

4 years agoMerge pull request #36925 from leseb/bp-36700-octopus
Jan Fajerski [Fri, 18 Sep 2020 14:18:38 +0000 (16:18 +0200)]
Merge pull request #36925 from leseb/bp-36700-octopus

octopus: ceph-volume: retry when acquiring lock fails

4 years agoMerge pull request #36852 from jan--f/wip-47146-octopus
Jan Fajerski [Fri, 18 Sep 2020 14:18:17 +0000 (16:18 +0200)]
Merge pull request #36852 from jan--f/wip-47146-octopus

octopus: ceph-volume: add libstoragemgmt support

4 years agoMerge pull request #36975 from sebastian-philipp/octopus-backport-36765-36738-36757...
Joshua Schmid [Thu, 17 Sep 2020 06:50:37 +0000 (08:50 +0200)]
Merge pull request #36975 from sebastian-philipp/octopus-backport-36765-36738-36757-36793-36509-36794-36571-36315-36817-36330-36752-3679

octopus: cephadm batch backport September (1)

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Joshua Schmid <jschmid@suse.com>
4 years agoMerge pull request #37201 from tchaikov/octopus-doc-rtd
Kefu Chai [Thu, 17 Sep 2020 01:39:09 +0000 (09:39 +0800)]
Merge pull request #37201 from tchaikov/octopus-doc-rtd

octopus: doc: enable Read the Docs

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agodoc: add in-doc search from read the docs 37201/head
Kefu Chai [Thu, 9 Apr 2020 15:14:42 +0000 (23:14 +0800)]
doc: add in-doc search from read the docs

readthedocs-sphinx-search features better user experience than the
builtin search offered by sphinx

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8bd8a8badbf992347a0883a537cce414432c867e)

4 years agodoc: use plantweb as fallback of sphinx-ditaa
Kefu Chai [Thu, 9 Apr 2020 13:25:39 +0000 (21:25 +0800)]
doc: use plantweb as fallback of sphinx-ditaa

RTD does not support installing system packages, the only ways to install
dependencies are setuptools and pip. while ditaa is a tool written in
Java. so we need to find a native python tool allowing us to render ditaa
images. plantweb is able to the web service for rendering the ditaa
diagram. so let's use it as a fallback if "ditaa" is not around.

also start a new line after the directive, otherwise planweb server will
return 500 at seeing the diagram.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 0cb56e0f13dc57167271ec7f20f11421416196a2)

4 years agodoc/conf.py: exclude pybindings docs from build for RTD
Kefu Chai [Thu, 9 Apr 2020 08:51:06 +0000 (16:51 +0800)]
doc/conf.py: exclude pybindings docs from build for RTD

because it'd difficult to prepare (dummy) librados,libcephfs and librbd for
their python bindings in the building environment offered by Read the Docs.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 847e4ef941401e1b580e93d7058e8413bd131e21)

4 years agoreadthedocs: add .readthedocs.yml
Kefu Chai [Thu, 9 Apr 2020 07:35:15 +0000 (15:35 +0800)]
readthedocs: add .readthedocs.yml

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 99b75c14d2c84bad8a6b491e4981eeb481751c40)

4 years agoMerge pull request #36840 from Huber-ming/octopus-loglevel
Yuri Weinstein [Wed, 16 Sep 2020 15:39:14 +0000 (08:39 -0700)]
Merge pull request #36840 from Huber-ming/octopus-loglevel

octopus: rgw: log resharding events at level 1 (formerly 20)

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #36812 from Huber-ming/octopus-dump
Yuri Weinstein [Wed, 16 Sep 2020 15:38:45 +0000 (08:38 -0700)]
Merge pull request #36812 from Huber-ming/octopus-dump

octopus: rgw: dump transitions in RGWLifecycleConfiguration::dump()

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #37080 from idryomov/wip-relax-preauth-asserts-octopus
Ilya Dryomov [Wed, 16 Sep 2020 15:16:41 +0000 (17:16 +0200)]
Merge pull request #37080 from idryomov/wip-relax-preauth-asserts-octopus

octopus: msg/async/ProtocolV2: allow rxbuf/txbuf get bigger in testing

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agomgr/dashboard: increase Grafana iframe height to avoid scroll bar 37182/head
nSedrickm [Mon, 27 Apr 2020 20:04:37 +0000 (21:04 +0100)]
mgr/dashboard: increase Grafana iframe height to avoid scroll bar

Add Grafana component style four with height 1160px
Fixes : https://tracker.ceph.com/issues/44966
Signed-off-by: Ngwa Sedrick Meh <nsedrick101@gmail.com>
(cherry picked from commit 550762ed872871ca63c44c68fca66ea74bea0cc4)

Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/host-details/host-details.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-details/osd-details.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-details/pool-details.component.html
- We are still using the tabset style in octopus, while we use the ngbNav directive in master;
  Also there are some more tabs in master vs. octopus which are not related to this PR and thus
  are not included

4 years ago15.2.5 v15.2.5
Jenkins Build Slave User [Tue, 15 Sep 2020 18:57:02 +0000 (18:57 +0000)]
15.2.5

4 years agolibrbd: migration abort should revert data back to the original image 37164/head
Jason Dillaman [Wed, 5 Aug 2020 13:12:41 +0000 (09:12 -0400)]
librbd: migration abort should revert data back to the original image

If the migration destination image was modified and then the migration
was aborted, we need to copy the data back to the source image to avoid
losing data. For simplicity we will only revert the HEAD revision state
and will not attempt to copy new snapshots on the destination image
back to the source.

Fixes: https://tracker.ceph.com/issues/41394
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 5bd15da8be09a4e7644d411a0b0c132e5b795393)

Conflicts:
src/librbd/api/Migration.cc: trivial resolution

4 years agolibrbd: track in-progress migration aborting operation
Jason Dillaman [Tue, 4 Aug 2020 21:09:57 +0000 (17:09 -0400)]
librbd: track in-progress migration aborting operation

We want to prevent the destination image from being used while an
abort is in-progress. Test that the image has no watchers prior to
permitting the abort, switch the migration state to ABORTING, and
treat the image as read-only if the migration state is ABORTING.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit d848b4f1c083bd9f3e6eac3e186c9e7df2e22004)

4 years agolibrbd: improved debug logs on list watcher state machine
Jason Dillaman [Tue, 4 Aug 2020 21:19:21 +0000 (17:19 -0400)]
librbd: improved debug logs on list watcher state machine

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit aee199f1daea6fd8eb7671464e45154ed0e9fd65)

4 years agoMerge pull request #37145 from linuxbox2/octopus-rgwlc-mtime
Yuri Weinstein [Mon, 14 Sep 2020 19:49:47 +0000 (12:49 -0700)]
Merge pull request #37145 from linuxbox2/octopus-rgwlc-mtime

Octopus rgwlc mtime

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
4 years agorgwlc: fix (post-parallel) non-current expiration 37145/head
Matt Benjamin [Fri, 4 Sep 2020 19:02:42 +0000 (15:02 -0400)]
rgwlc:  fix (post-parallel) non-current expiration

Object mtime had been lifted correctly into LCOpRule for
DMExpiration and, apparently, NonCurrentTransition, but not
for NonCurrentExpiration.

Some additional debug statements added at level 20.

Fixes: https://tracker.ceph.com/issues/47308
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
4 years agoos/bluestore: enable more flexible bluefs space management by default. 37092/head
Igor Fedotov [Fri, 21 Aug 2020 11:51:00 +0000 (14:51 +0300)]
os/bluestore: enable more flexible bluefs space management by default.

It turned out that we did't enable it when introduced this feature in
https://github.com/ceph/ceph/pull/29687.

Fixes: https://tracker.ceph.com/issues/47053
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit 41823db09c609155db31afbd03b817c2a578fa9d)

4 years agomsg/async/ProtocolV2: allow rxbuf/txbuf get bigger in testing 37080/head
Ilya Dryomov [Sat, 29 Aug 2020 10:02:30 +0000 (12:02 +0200)]
msg/async/ProtocolV2: allow rxbuf/txbuf get bigger in testing

We have a kernel client test case that constructs huge auth tickets
to exercise the three related code paths in the kernel.  One of the
tickets is bigger than 1000000 bytes, as required for triggering the
third code path.

We haven't bumped into this assert earlier because the kernel client
is still on msgr v1.  However, "rbd map" and "rbd unmap" commands
started connecting to the cluster in commit 96f05a7956b3 ("rbd: delay
determination of default pool name") and that happens via msgr v2.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 94953dd9398a937d43026f73efaf437597071ca7)

4 years agomgr/cephadm: Add comments to secondary contaieners 36975/head
Sebastian Wagner [Wed, 2 Sep 2020 07:37:24 +0000 (09:37 +0200)]
mgr/cephadm: Add comments to secondary contaieners

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Co-authored-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 98c0119833b9fc9648d667f002d84b1ccb75f334)

4 years agocephadm: properly remove `osd-activate` container
Sebastian Wagner [Fri, 28 Aug 2020 09:58:12 +0000 (11:58 +0200)]
cephadm: properly remove `osd-activate` container

Othwerise we end up with being unable to create
new containers, due to the name being already used

Fixes: https://tracker.ceph.com/issues/47170
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit bff74b01803bddd082cd9b4641a2d7fcbf080ef2)

4 years agomgr/cephadm: customize blink_device_light cmd via j2
Sebastian Wagner [Mon, 31 Aug 2020 13:41:39 +0000 (15:41 +0200)]
mgr/cephadm: customize blink_device_light cmd via j2

Customized blink a device light. By default running something like:

    lsmcli local-disk-ident-led-on --path $path

If you must, you can customize this via:

    ceph config-key set mgr/cephadm/lsmcli_blink_lights_cmd '<my jinja2 template>'

where my jinja2 template is something like:

    lsmcli local-disk-{{ ident_fault }}-led-{{'on' if on else 'off'}} --path '{{ path or dev }}'

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit dc2dd8b19242d7b8da1f881ae128b2746d8ff398)

4 years agomgr/cephadm: Add extensive test for blink_device_light
Sebastian Wagner [Mon, 31 Aug 2020 13:11:24 +0000 (15:11 +0200)]
mgr/cephadm: Add extensive test for blink_device_light

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 17cdcdc73094f4cb4f45575e02434234cf9cebd8)

4 years agomgr/cephadm: PEP8tify test_migration.py
Sebastian Wagner [Mon, 31 Aug 2020 09:48:14 +0000 (11:48 +0200)]
mgr/cephadm: PEP8tify test_migration.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit fa49f096066ab6e84e52cc122368eccbd56eb681)

4 years agocephadm: auto wrap and unwrap ipv6 addresses
Matthew Oliver [Mon, 17 Aug 2020 01:08:56 +0000 (11:08 +1000)]
cephadm: auto wrap and unwrap ipv6 addresses

This patch attempts to simplify IPv6 support in cephadm by automatically
wrapping and unwrapping IPv6 addresses when required.

There are some asumptions though, if you are supplyings an IPv6 addrv
then it needs to be wrapped. But because you are specifiying, you should
know what your doing.

But in general, it means in bootstrap you should be able to supply ipv6
addresses wrapped or not so long as there isn't a post appended.

Fixes: https://tracker.ceph.com/issues/46922
Signed-off-by: Matthew Oliver <moliver@suse.com>
(cherry picked from commit 09eac4bef0f04f5db7118f94dd9679f3295bddf8)

Conflicts:
src/pybind/mgr/dashboard/tools.py
src/python-common/ceph/deployment/service_spec.py

4 years agomgr/cephadm: PEP8tify module.py
Sebastian Wagner [Sat, 29 Aug 2020 18:41:20 +0000 (20:41 +0200)]
mgr/cephadm: PEP8tify module.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit ce35b3381cf6ef28f233355e6c3844db606c1244)

4 years agomgr/cephadm: Verify non-empty list in get_active_daemon functions
Adam King [Thu, 27 Aug 2020 16:22:49 +0000 (12:22 -0400)]
mgr/cephadm: Verify non-empty list in get_active_daemon functions

The get_active_daemon functions for monitoring stack daemons
were just returning the first or last daemon in the given list
without checking the list actually contained any daemons

Fixes: https://tracker.ceph.com/issues/47171
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 2c440edebf7cd4e535bcb680bd7131f0d22daf7a)

4 years agomgr/cephadm: kick serve loop to trigger ceph.conf deployment
Sebastian Wagner [Thu, 27 Aug 2020 09:33:31 +0000 (11:33 +0200)]
mgr/cephadm: kick serve loop to trigger ceph.conf deployment

Otherwise we'll wait 600s.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 4609210e105cbbe2d5f685fc4890cce8d8b0ba6f)

4 years agomgr/cephadm: add test_daemon_check
Sebastian Wagner [Fri, 21 Aug 2020 15:38:33 +0000 (17:38 +0200)]
mgr/cephadm: add test_daemon_check

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit d0978ddf414a88fd8edc7cb355d0f678b2cf2d92)

4 years agomgr/cephadm: Make daemon actions asynchronous
Sebastian Wagner [Fri, 21 Aug 2020 14:25:31 +0000 (16:25 +0200)]
mgr/cephadm: Make daemon actions asynchronous

Fixes broken `ceph orch redeploy <current active mgr>`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 365f839a79ac5e321dc088aaec07644c7bc554eb)

4 years agomgr/cephadm: add scheduled_daemon_actions to HostCache
Sebastian Wagner [Fri, 21 Aug 2020 09:44:15 +0000 (11:44 +0200)]
mgr/cephadm: add scheduled_daemon_actions to HostCache

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit ce4798ba0d33d2c8cfc7811553eed11f0f6af781)

4 years agomgr/cephadm: move fail_over from upgrade.py to MgrService
Sebastian Wagner [Wed, 19 Aug 2020 10:39:39 +0000 (12:39 +0200)]
mgr/cephadm: move fail_over from upgrade.py to MgrService

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 3e5676d6c02f5aa458e4714ea5e61bd13c9e3a3f)

4 years agomgr/cephadm: _wait_for_ok_to_stop: add missing f-prefix
Sebastian Wagner [Wed, 19 Aug 2020 10:25:18 +0000 (12:25 +0200)]
mgr/cephadm: _wait_for_ok_to_stop: add missing f-prefix

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit f5ae34ab711f808baa570637ed79c934282d6c1a)

4 years agomgr/cephadm: _create_daemon: remove usused parameter
Sebastian Wagner [Wed, 19 Aug 2020 10:12:00 +0000 (12:12 +0200)]
mgr/cephadm: _create_daemon: remove usused parameter

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 66a9f87d16e3e006bb8e2de41399887f58448374)

4 years agomgr/orch: daemon redeploy: Fix missing default value
Sebastian Wagner [Wed, 19 Aug 2020 10:10:04 +0000 (12:10 +0200)]
mgr/orch: daemon redeploy: Fix missing default value

Fixes: https://tracker.ceph.com/issues/47035
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit e6f2237840b8fa17d6ca95b02b784a224a4f22f7)

4 years agomgr/cephadm: PEP8tify inventory.py
Sebastian Wagner [Tue, 25 Aug 2020 13:29:36 +0000 (15:29 +0200)]
mgr/cephadm: PEP8tify inventory.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit fef1151a62dedc7edc34fd9887aa59a94d9c9c7f)

4 years agomgr/cephadm: disable autopep8 for test_{spec,scheduling}.py
Sebastian Wagner [Thu, 27 Aug 2020 08:20:34 +0000 (10:20 +0200)]
mgr/cephadm: disable autopep8 for test_{spec,scheduling}.py

The signal to noise ratio is just too bad.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit d30d5e4746483880ca3b3306150255c0739224a8)

4 years agodoc/mgr: Clean up orchestrator.rst (spell/punct, awkward wording)
Dan Mick [Sat, 8 Aug 2020 03:14:26 +0000 (03:14 +0000)]
doc/mgr: Clean up orchestrator.rst (spell/punct, awkward wording)

Signed-off-by: Dan Mick <dmick@redhat.com>
(cherry picked from commit a2a90542021005622e6a763c4593d2994177f4bd)

4 years agomgr/cephadm: PEP8tify services/osd.py
Sebastian Wagner [Wed, 26 Aug 2020 09:41:58 +0000 (11:41 +0200)]
mgr/cephadm: PEP8tify services/osd.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 1a229055b040f10afd84d036c7acf5cbcc13b1dd)

4 years agocephadm: Give better access to the /dev in the iscsi container
Matthew Oliver [Thu, 27 Aug 2020 02:44:40 +0000 (12:44 +1000)]
cephadm: Give better access to the /dev in the iscsi container

In testing it seems the main iscsi container's /dev related volume mount to just
/dev/log is too narrow. And in certain circumstances it needs to access
to see /dev/rbd* devices. Like if using krdb.

This patch volume mounts /dev rather then /dev/log in the main
container, but since this aligns with what we need in the tcmu-runner
container it actaully ends up simplifying the code as well.

Signed-off-by: Matthew Oliver <moliver@suse.com>
(cherry picked from commit 40c0d6821252e8112b655dee67d9d3eb5b7ffbff)

4 years agomgr/orchestrator: PEP8tify
Sebastian Wagner [Wed, 26 Aug 2020 09:48:17 +0000 (11:48 +0200)]
mgr/orchestrator: PEP8tify

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit ee634f2921ba0f9083b3778ea5651f52c1ed98f7)

4 years agomgr/cephadm: use `check_mon_command` during iscsi config
Michael Fritch [Tue, 25 Aug 2020 17:19:03 +0000 (11:19 -0600)]
mgr/cephadm: use `check_mon_command` during iscsi config

ensure the mon commands actually succeed

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 2e98c8cda49161e66856f0aaf1bfa9ae9a3f3417)

4 years agocephadm: infer latest image with a valid tag
Michael Fritch [Tue, 25 Aug 2020 13:55:08 +0000 (07:55 -0600)]
cephadm: infer latest image with a valid tag

Fixes: https://tracker.ceph.com/issues/47134
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit d61676f92dc701daeab71bd9d9c35d6cfa9a6434)

4 years agomgr/cephadm: use `check_mon_command` util
Michael Fritch [Tue, 25 Aug 2020 15:26:51 +0000 (09:26 -0600)]
mgr/cephadm: use `check_mon_command` util

rather then checking the retval explicitly

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 2f7fef134753f880c54027fbe18d4bf7425098fe)

4 years agomgr/cephadm: merge NFSGanesha into NFSService class
Michael Fritch [Fri, 21 Aug 2020 00:52:33 +0000 (18:52 -0600)]
mgr/cephadm: merge NFSGanesha into NFSService class

these two classes really preform the same function

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 82598631c30bf483a5bda285414df7245fe283c1)

4 years agomgr/cephadm: use supplied `CephadmDaemonSpec`
Michael Fritch [Thu, 20 Aug 2020 20:10:11 +0000 (14:10 -0600)]
mgr/cephadm: use supplied `CephadmDaemonSpec`

69ed3d9cffd refactored `_create_daemon()` which obsoleted any need to
search for the NFSServiceSpec in the SpecStore

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 87ccbad67170a9a0b35776d53826b0a944239cb5)

4 years agomgr/cephadm: move NFS config/create func
Michael Fritch [Thu, 20 Aug 2020 20:06:15 +0000 (14:06 -0600)]
mgr/cephadm: move NFS config/create func

preserve func order seen in the impl. for the other services

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 170220875d942b6f1678d5a388a19e081251f554)

4 years agocephadm: Update error message on host failure
Stephan Müller [Tue, 28 Jul 2020 18:36:30 +0000 (20:36 +0200)]
cephadm: Update error message on host failure

Now the error message explains how to add the ssh key to the not
reachable host

Fixes: https://tracker.ceph.com/issues/46551
Signed-off-by: Stephan Müller <smueller@suse.com>
(cherry picked from commit 1bfb044518d8b771c8f6cac2396f636b0cbdf12e)

4 years agomgr/cephadm: PEP8tify some tests
Sebastian Wagner [Wed, 26 Aug 2020 09:45:56 +0000 (11:45 +0200)]
mgr/cephadm: PEP8tify some tests

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit a385c3cc28188f5a4c85a113086ab11f9cace67c)

4 years agocephadm: deploying of monitoring images partially broken
Patrick Seidensal [Tue, 28 Jul 2020 08:23:57 +0000 (10:23 +0200)]
cephadm: deploying of monitoring images partially broken

Deployment of monitoring images has been broken in the context of
ceph-salt. Due to the removal of the registries in
/etc/containers/registries.conf, all images need to be provided
qualified.

Fixes: https://tracker.ceph.com/issues/46726
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
(cherry picked from commit 658230048bff5907d6dad8e216a540014a0898f1)

4 years agocephadm: remove py2 from tox tests
Paul Cuzner [Tue, 11 Aug 2020 21:22:27 +0000 (09:22 +1200)]
cephadm: remove py2 from tox tests

cephadm is dependent on py3, and the presence of py2 in
tox is just going to throw more errors over time as py3
idioms are adopted. py2 is EOL, and older hosts should
have py3 available as an installation option anyway.

This patch just removes py2 from the tox test.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit c8649eff0097635ad16778d2194b07d139ce806a)

4 years agomgr/cephadm: PEP8tify cephadmservice.py
Sebastian Wagner [Tue, 25 Aug 2020 13:33:06 +0000 (15:33 +0200)]
mgr/cephadm: PEP8tify cephadmservice.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 56f11c015ad323bb31e9fa372d30541b4b54de41)

4 years agocephadm: remove py2 from test_adoption
Paul Cuzner [Mon, 24 Aug 2020 22:51:26 +0000 (10:51 +1200)]
cephadm: remove py2 from test_adoption

Since cephadm is py3 based, and py2 is EOL this patch
removes the py2 test iteration from test_adoption.sh

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit 225cbd8d790602b30050e0e32ecffd400ec17731)

4 years agocephadm: remove py2 from test stream
Paul Cuzner [Wed, 19 Aug 2020 23:58:34 +0000 (11:58 +1200)]
cephadm: remove py2 from test stream

Since py2 is EOL, and cephadm requires py3 anyway this
patch removes the py2 test iteration from the functional
testing suite.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit db5f758ec5d1887b664d16d08552ff272b8c214f)

4 years agocephadm: make devices lists more granular in gather-facts
Paul Cuzner [Wed, 19 Aug 2020 23:12:09 +0000 (11:12 +1200)]
cephadm: make devices lists more granular in gather-facts

The gather-facts commands returns a list of hdd and flash
devices. This patch changes the list content from being
simple strings representing the disks to a dict, making it
easier to extend in the future.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit 9b43b5c555d7e4160bc704a9702edc17797de50d)

4 years agocephadm: add gather-facts to the qa test
Paul Cuzner [Wed, 12 Aug 2020 00:01:48 +0000 (12:01 +1200)]
cephadm: add gather-facts to the qa test

Adds a gather-facts invocatio after check-host is run.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit e24321be416e3e10b31c602c2b0715119f869833)

4 years agocephadm: enhance memory and cpu data
Paul Cuzner [Mon, 10 Aug 2020 21:53:12 +0000 (09:53 +1200)]
cephadm: enhance memory and cpu data

Added free/available memory state, and cpu loadavg info

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit fb72a14ad4a6675f6471c69365187844bb98d322)

4 years agocephadm: fixes to address PR requirements
Paul Cuzner [Mon, 10 Aug 2020 06:03:41 +0000 (18:03 +1200)]
cephadm: fixes to address PR requirements

Minor changes to address issues raised in the PR;
- formatting of ipv6 addresses
- missing docstrings
- NIC mtu and speed now int instead of string
- added NIC driver name
- removed discrete JSON method making gather-facts JSON only
- added upper/lower device lists to show NIC relationships
- added hostname to the JSON!
- added selinux/apparmor status
- added timestamp (epoch) for the gather-facts run
- added system uptime (secs)

Closes:

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit 92250132bf48da1df86a71edbfa5815a210c8b6b)

4 years agocephadm: add gather_facts command
Paul Cuzner [Fri, 7 Aug 2020 04:28:30 +0000 (16:28 +1200)]
cephadm: add gather_facts command

The gather_facts command is intended to provide host
level metadata to the caller, which could then be used
in a number of places: orchestrator inventory, displayed
in the UI etc

Data is extracted mainly from sysfs and /proc

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit ff00e0d04c0ab82078fb41849e758bb6fb2ed291)

4 years agomgr/cephadm: PEP8tify schedule.py
Sebastian Wagner [Tue, 25 Aug 2020 13:30:51 +0000 (15:30 +0200)]
mgr/cephadm: PEP8tify schedule.py

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 83e4559fcef059e8f65b9730b5e1ca7820699ddb)

4 years agomgr/cephadm: use raw string during `re.search`
Michael Fritch [Fri, 21 Aug 2020 16:03:05 +0000 (10:03 -0600)]
mgr/cephadm: use raw string during `re.search`

cephadmservice.py:348: DeprecationWarning: invalid escape sequence \:
    port = re.search('\:\d+\/', end_point)

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit ed0074da2ca00b3fc1669865667e1090d9676fbe)

4 years agoqa/tasks/cephadm.py: add ceph logs directory in job's info.yaml
Shraddha Agrawal [Wed, 19 Aug 2020 10:54:18 +0000 (16:24 +0530)]
qa/tasks/cephadm.py: add ceph logs directory in job's info.yaml

This commit adds the file path of ceph log directories to the job's
info.yaml log file. The motivation behind this is, in case of job
timeout, the logs would still be tranferred to teuthology host
before nuking test machines using these ceph log directory paths in
job's info.yaml log file.

Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
(cherry picked from commit d2ff5c5eb609eba02e6c966015bb7e1d9b349be4)

Conflicts:
qa/tasks/cephadm.py

4 years agoCODEOWNERS: Add cephadm man page to @ceph/orchestrators
Sebastian Wagner [Mon, 24 Aug 2020 08:30:12 +0000 (10:30 +0200)]
CODEOWNERS: Add cephadm man page to @ceph/orchestrators

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit f3aed0828b6fa3bc0753892161082cb766ad9866)

4 years agodoc/man/cephadm: Add missing parameters for `ls`
Sebastian Wagner [Mon, 24 Aug 2020 08:28:07 +0000 (10:28 +0200)]
doc/man/cephadm: Add missing parameters for `ls`

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 20b679a8928767db5b7314a4f017fcf2eb4fbf36)

4 years agoMerge pull request #36981 from neha-ojha/wip-47297-octopus
Yuri Weinstein [Fri, 4 Sep 2020 23:07:22 +0000 (16:07 -0700)]
Merge pull request #36981 from neha-ojha/wip-47297-octopus

octopus: mon/OSDMonitor: only take in osd into consideration when trimming osd…

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
4 years agoceph-volume: simple scan should ignore tmpfs 36953/head
Andrew Schoen [Fri, 4 Sep 2020 14:44:49 +0000 (09:44 -0500)]
ceph-volume: simple scan should ignore tmpfs

When simple scan is ran against a ceph-volume
OSD, util.encryption.legacy_encrypted returns
tmpfs. We want to avoid creating a Device
object with tmpfs and ignore the OSD as it's
not a ceph-disk created OSD.

Resolves: rhbz#1872983

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit ff4b7bfa573e95acf4cdc01ccf2881f0935e91d6)

4 years agomon/OSDMonitor: only take in osd into consideration when trimming osdmaps 36981/head
Kefu Chai [Thu, 3 Sep 2020 15:02:58 +0000 (23:02 +0800)]
mon/OSDMonitor: only take in osd into consideration when trimming osdmaps

we should not take down osd into consideration when trimming osdmap. in
e62269c892, we decrease the upper bound of range of osdmaps to be trimmed
if the given osd is out. but we should have to decrease it only if the
osd in question is still *in*.

so, in this change, the min_lec is decreased only if the osd in question
is *in*.

Fixes: https://tracker.ceph.com/issues/47290
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 79175740cf2394bba74163ca8a5131419b9641ed)

 Conflicts:
src/mon/OSDMonitor.cc - trivial resolution

4 years agoMerge pull request #36973 from sebastian-philipp/octopus-mgr-re-add_osd_support
Yuri Weinstein [Thu, 3 Sep 2020 22:34:02 +0000 (15:34 -0700)]
Merge pull request #36973 from sebastian-philipp/octopus-mgr-re-add_osd_support

octopus: Revert "mgr/osd_support: remove module and all traces"

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
4 years agoRevert "mgr/osd_support: remove module and all traces" 36973/head
Sebastian Wagner [Wed, 2 Sep 2020 14:05:25 +0000 (16:05 +0200)]
Revert "mgr/osd_support: remove module and all traces"

This reverts commit a55c1dd0fac826978edf22e448c3456e7634cbc3.

Kept to keep upgrades from older point releases working.
This module can be removed as soon as we no longer
support upgrades from old octopus point releases.

Revert "build/debian: remove osd_support"

This reverts commit 8ff2824beb78dfd03710e94302f038ea70fb4561.

Fixes: https://tracker.ceph.com/issues/47109
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 43f1bdb6ef7d740eda219bac7d0280ed558e319d)

4 years agokrbd: optionally skip waiting for udev events
Ilya Dryomov [Mon, 24 Aug 2020 17:01:46 +0000 (19:01 +0200)]
krbd: optionally skip waiting for udev events

Add support for noudev option to allow mapping and unmapping images
from a privileged container in a non-initial network namespace (e.g.
when using Multus CNI).

Fixes: https://tracker.ceph.com/issues/47128
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 2e657d134a1af489dcf623d207be259ce3dda9bc)

Conflicts:
src/tools/rbd/action/Kernel.cc [ commits 34f539d8af33 ("rbd:
  delay parsing of default kernel map options") and da4ffd834fb8
  ("rbd: rename some MapOptions instances to unmap_options") not
  in octopus ]

4 years agoceph-volume: support for mpath devices 36928/head
Jan Fajerski [Fri, 15 May 2020 09:26:31 +0000 (11:26 +0200)]
ceph-volume: support for mpath devices

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
Fixes: https://tracker.ceph.com/issues/45094
(cherry picked from commit ee8887f4c0ff4f91117f31b621b95c8d08019130)

4 years agoceph-volume: retry when acquiring lock fails 36925/head
Sébastien Han [Tue, 18 Aug 2020 13:41:31 +0000 (15:41 +0200)]
ceph-volume: retry when acquiring lock fails

When preaparing the osd device with --mkfs, the ceph-osd binary tries to
acquire an exclusive lock on the device (soon to become an OSD).
Unfortunately, when running in containers, we have seen cases where
there is a race between ceph-osd and systemd-udevd to acquire a lock on
the device. Sometimes systemd-udevd gets the lock and releases it soon
so that the ceph-osd gets sometimes the lock is still held and because
ceph-osd uses LOCK_NB the command fails.

This commit retries if the lock cannot be acquired, up to 5 times for 5
seconds, this should be more than enough to acquire the lock and
proceed with the OSD mkfs.

Unfortunately, this is so transient that we cannot lock earlier from c-v,
this won't do anything.

Fixes: https://tracker.ceph.com/issues/47010
Signed-off-by: Sébastien Han <seb@redhat.com>
(cherry picked from commit a285cd08921f51ef1101950eb6b9addcdfbecc35)

4 years agomgr/dashboard: Fix stale table actions 36899/head
Tiago Melo [Thu, 27 Aug 2020 17:31:48 +0000 (17:31 +0000)]
mgr/dashboard: Fix stale table actions

If we don't emit the select event, the action button can become stale and not
update when the data changes.

This fixes a regression introduced in 31e9bbb9b308277d2f89390d5ff62f13457d69cb

Fixes: https://tracker.ceph.com/issues/47175
Signed-off-by: Tiago Melo <tmelo@suse.com>
(cherry picked from commit c9a73185a9d8348d0a5e72b76b6bcabd5ac34da8)

4 years agomgr/dashboard: Disable autocomplete on user form 36901/head
Volker Theile [Thu, 13 Aug 2020 07:31:39 +0000 (09:31 +0200)]
mgr/dashboard: Disable autocomplete on user form

Fixes: https://tracker.ceph.com/issues/46915
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit a48989f87bf7e2c38e8795ee7a4523670f7727f2)

4 years agomgr/dashboard: Datatable catches select events from other datatables
Volker Theile [Wed, 12 Aug 2020 14:25:05 +0000 (16:25 +0200)]
mgr/dashboard: Datatable catches select events from other datatables

Ensure we do not process DOM 'select' events, see https://github.com/swimlane/ngx-datatable/issues/899.

Fixes: https://tracker.ceph.com/issues/46903
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 31e9bbb9b308277d2f89390d5ff62f13457d69cb)

4 years agomgr/dashboard: Host delete action should be disabled if not managed by Orchestrator 36874/head
Volker Theile [Wed, 24 Jun 2020 10:32:01 +0000 (12:32 +0200)]
mgr/dashboard: Host delete action should be disabled if not managed by Orchestrator

Fixes: https://tracker.ceph.com/issues/46146
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 4fbe49a793f1bd09a823620414f36a3bbfc426a0)

4 years agomgr/dashboard: Hide table action input field if limit=0 36872/head
Volker Theile [Tue, 11 Aug 2020 13:26:24 +0000 (15:26 +0200)]
mgr/dashboard: Hide table action input field if limit=0

Fixes: https://tracker.ceph.com/issues/46901
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 241855f3e3fee5ceea5d3b3060793ff619f32c6c)

4 years agomgr/dashboard: Fix for CrushMap viewer items getting compressed vertically 36871/head
Nizamudeen A [Tue, 4 Aug 2020 08:45:45 +0000 (14:15 +0530)]
mgr/dashboard: Fix for CrushMap viewer items getting compressed vertically

Intents to fix the crushmap viewer tree children getting compressed vertically when more osd's are added.

Fixes: https://tracker.ceph.com/issues/46826
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 166681df08e01e85617885f492d665a74486ab8f)

4 years agomgr/dashboard: Proper format iSCSI target portals 36870/head
Volker Theile [Wed, 12 Aug 2020 10:54:07 +0000 (12:54 +0200)]
mgr/dashboard: Proper format iSCSI target portals

Proper format the 'Portals' and 'Images' columns.

Fixes: https://tracker.ceph.com/issues/46908
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit ac0b34a26777400226e263120e4b82644b2e0d51)

4 years agoceph-volume: show correct rejected reason in inventory if device type is not acceptable 36852/head
Satoru Takeuchi [Fri, 22 May 2020 01:45:32 +0000 (01:45 +0000)]
ceph-volume: show correct rejected reason in inventory if device type is not acceptable

If device type is not acceptable in `c-v inventory`, its rejected reason
becomes "Insufficient space (<5GB)" by mistake. It's because sys_api is
empty due to skipping devices that are neither `disk` nor `device`. We
should report the target device is not acceptable in this case.

Fixes: https://tracker.ceph.com/issues/46102
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
(cherry picked from commit 3e5d91d41f7275d4656019c1ca3fc80927d214c9)

4 years agorgw: log resharding events at level 1 (formerly 20) 36840/head
Or Friedmann [Wed, 19 Aug 2020 13:07:19 +0000 (13:07 +0000)]
rgw: log resharding events at level 1 (formerly 20)
log resharding events at level 1 (formerly 20)
Signed-off-by: Or Friedmann <ofriedma@redhat.com>
(cherry picked from commit a5428c8a29414044a87b7dc009f27b336d4232e2)

Conflicts:
src/rgw/rgw_rados.cc

4 years agorgw: dump transitions in RGWLifecycleConfiguration::dump() 36812/head
Shengming Zhang [Sat, 18 Jul 2020 06:16:34 +0000 (14:16 +0800)]
rgw: dump transitions in RGWLifecycleConfiguration::dump()

Signed-off-by: Shengming Zhang <zhangsm01@inspur.com>
(cherry picked from commit c843b6f08799c1fef39a4a6fd24c27207d1e951e)

4 years agoMerge pull request #36786 from callithea/wip-46936-octopus
Yuri Weinstein [Thu, 27 Aug 2020 19:21:19 +0000 (12:21 -0700)]
Merge pull request #36786 from callithea/wip-46936-octopus

octopus: mgr: Add missing states to PG_STATES in mgr_module.py.

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #36795 from ifed01/wip-ifed-simplify-pin-octopus
Yuri Weinstein [Thu, 27 Aug 2020 17:21:25 +0000 (10:21 -0700)]
Merge pull request #36795 from ifed01/wip-ifed-simplify-pin-octopus

octopus: os/bluestore: simplify Onode pin/unpin logic

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #36644 from smithfarm/wip-46471-octopus
Yuri Weinstein [Thu, 27 Aug 2020 16:53:08 +0000 (09:53 -0700)]
Merge pull request #36644 from smithfarm/wip-46471-octopus

octopus: rgw: stop realm reloader before store shutdown

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>