]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agomgr/progress: introduce turn off/on feature 37488/head
Kamoltat [Wed, 30 Sep 2020 05:44:23 +0000 (05:44 +0000)]
mgr/progress: introduce turn off/on feature

progress module can be turned off/on by using
the commands: 'progress off' and 'progress on'

As well as refractoring teuthology test suite
to prevent future bugs that can possibly occur

fixes: https://tracker.ceph.com/issues/47238

Signed-off-by: kamoltat <ksirivad@redhat.com>
4 years agoMerge pull request #37922 from mgfritch/project-kubic
Kefu Chai [Thu, 12 Nov 2020 02:40:24 +0000 (10:40 +0800)]
Merge pull request #37922 from mgfritch/project-kubic

cephadm: install podman from the Kubic project

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38018 from tchaikov/wip-cmake-python
Kefu Chai [Thu, 12 Nov 2020 01:54:54 +0000 (09:54 +0800)]
Merge pull request #38018 from tchaikov/wip-cmake-python

COPYING: note cmake/modules/FindPython* license and copyright

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #38028 from tchaikov/wip-crimson-maybe-unused
Kefu Chai [Thu, 12 Nov 2020 01:53:47 +0000 (09:53 +0800)]
Merge pull request #38028 from tchaikov/wip-crimson-maybe-unused

crimson/os: mark unused variable [[maybe_unused]]

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #35865 from tchaikov/wip-crimson-recovery-qa
Kefu Chai [Thu, 12 Nov 2020 01:52:33 +0000 (09:52 +0800)]
Merge pull request #35865 from tchaikov/wip-crimson-recovery-qa

qa/suites: add crimson-rados suite

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #36759 from dzafman/wip-46264
David Zafman [Thu, 12 Nov 2020 01:09:28 +0000 (17:09 -0800)]
Merge pull request #36759 from dzafman/wip-46264

mon: check for mismatched daemon versions

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agotest: Changes based on code review comments 36759/head
David Zafman [Wed, 11 Nov 2020 22:00:24 +0000 (14:00 -0800)]
test: Changes based on code review comments

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agodoc: Apply suggestions from code review
David Zafman [Tue, 10 Nov 2020 22:29:08 +0000 (14:29 -0800)]
doc: Apply suggestions from code review

Co-authored-by: Neha Ojha <nehaojha88@gmail.com>
Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoosd test: Delay reporting until mon_warn_older_version_delay has passed
David Zafman [Sun, 8 Nov 2020 17:07:04 +0000 (09:07 -0800)]
osd test: Delay reporting until mon_warn_older_version_delay has passed

Move release notes description to 16.0.0 and update
Update documentation

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoosd: Temporary fix for alienstore which doesn't support asok commands yet
David Zafman [Thu, 22 Oct 2020 16:15:40 +0000 (16:15 +0000)]
osd: Temporary fix for alienstore which doesn't support asok commands yet

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agodoc: Document health check DAEMON_OLD_VERSION
David Zafman [Mon, 28 Sep 2020 22:48:09 +0000 (22:48 +0000)]
doc: Document health check DAEMON_OLD_VERSION

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoUpdate Release notes
David Zafman [Fri, 28 Aug 2020 20:27:42 +0000 (20:27 +0000)]
Update Release notes

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agotest: Simple test case for version health warning
David Zafman [Fri, 28 Aug 2020 18:35:03 +0000 (18:35 +0000)]
test: Simple test case for version health warning

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agotest: Use a config variable debug_version_for_testing
David Zafman [Tue, 25 Aug 2020 01:20:28 +0000 (01:20 +0000)]
test: Use a config variable debug_version_for_testing

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agomon: Add mds version collector
David Zafman [Thu, 27 Aug 2020 17:54:15 +0000 (17:54 +0000)]
mon: Add mds version collector

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agomon: Add mgr version collector
David Zafman [Thu, 27 Aug 2020 05:10:06 +0000 (05:10 +0000)]
mon: Add mgr version collector

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agomon: Add osd version collector
David Zafman [Fri, 11 Sep 2020 21:46:55 +0000 (21:46 +0000)]
mon: Add osd version collector

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agomon: Verify version consistency across daemons
Tyler [Mon, 20 Jul 2020 17:18:29 +0000 (13:18 -0400)]
mon: Verify version consistency across daemons

Add a function called check_daemon_versions()
Made minor changes based on pull request comments
Changed the way versions are checked along with some other minor modifications
Made minor modification to the error message
Modifications to include the hostname in the error message

Fixes: https://tracker.ceph.com/issues/46264
Signed-off-by: Tyler <tyler_sheehan@student.uml.edu>
Remove time since health errors aren't preserved if not set every time
Rename health error to DAEMON_OLD_VERSION
Reoganize code so that we can get versions from other daemon types
Change to map of version (key), a list of daemons (value)
Get actual daemon names from get_versions() requests
Fix message output based on how many daemons and how many versions
Add a config to be able to turn off this features
Give HEALTH_ERR if more than one older version exists
Fix minor indentation problem with health detail

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoMerge PR #37978 into master
Patrick Donnelly [Wed, 11 Nov 2020 19:07:27 +0000 (11:07 -0800)]
Merge PR #37978 into master

* refs/pull/37978/head:
qa: fix broken links in multimds suite

Reviewed-by: Jeff Layton <jlayton@redhat.com>
4 years agoMerge pull request #37235 from adk3798/4mon
Michael Fritch [Wed, 11 Nov 2020 16:09:30 +0000 (09:09 -0700)]
Merge pull request #37235 from adk3798/4mon

mgr/cephadm: only deploy 3 mons by default when there are 4 hosts

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agocrimson/os: mark unused variable [[maybe_unused]] 38028/head
Kefu Chai [Wed, 11 Nov 2020 15:22:08 +0000 (23:22 +0800)]
crimson/os: mark unused variable [[maybe_unused]]

silences the warning when building with -DNDEBUG:

segment_cleaner.h:399:10: warning: unused variable ‘ret’ [-Wunused-variable]
  399 |     auto ret = space_tracker->allocate(
      |          ^~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37916 from orozery/librbd-crypto-wait-for-copyup
Jason Dillaman [Wed, 11 Nov 2020 14:53:29 +0000 (09:53 -0500)]
Merge pull request #37916 from orozery/librbd-crypto-wait-for-copyup

librbd: wait for copyup in unaligned crypto write

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38017 from YanfeiXu/yann-dev
Kefu Chai [Wed, 11 Nov 2020 11:57:08 +0000 (19:57 +0800)]
Merge pull request #38017 from YanfeiXu/yann-dev

cmake: add support for python3.9

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoCOPYING: note cmake/modules/FindPython* license and copyright 38018/head
Kefu Chai [Wed, 11 Nov 2020 03:47:40 +0000 (11:47 +0800)]
COPYING: note cmake/modules/FindPython* license and copyright

these files were copied from CMake project for better python3 support

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38021 from tchaikov/wip-mgr-liburl3
Kefu Chai [Wed, 11 Nov 2020 08:05:12 +0000 (16:05 +0800)]
Merge pull request #38021 from tchaikov/wip-mgr-liburl3

pybind/mgr: add urllib3==1.25.11 to mgr/requirements.txt

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
4 years agopybind/mgr: add urllib3==1.25.11 to mgr/requirements.txt 38021/head
Kefu Chai [Wed, 11 Nov 2020 05:09:53 +0000 (13:09 +0800)]
pybind/mgr: add urllib3==1.25.11 to mgr/requirements.txt

in hope to address the failure of

ERROR: Cannot install -r requirements.txt (line 3) and kubernetes because these package versions have conflicting dependencies.

The conflict is caused by:
    kubernetes 12.0.0 depends on urllib3>=1.24.2
    requests 2.24.0 depends on urllib3!=1.25.0, !=1.25.1, <1.26 and >=1.21.1

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: add support for python3.9 38017/head
Yanfei Xu [Tue, 10 Nov 2020 09:17:30 +0000 (17:17 +0800)]
cmake: add support for python3.9

add support for python3.9.

Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
4 years agoMerge pull request #37775 from dzafman/wip-upgrade-mimic-fix
David Zafman [Wed, 11 Nov 2020 00:27:43 +0000 (16:27 -0800)]
Merge pull request #37775 from dzafman/wip-upgrade-mimic-fix

test: Remove mimic-x* upgrade testing in master

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
4 years agoMerge pull request #38006 from xxhdx1985126/wip-crimson-recovery-bug-fix2
Kefu Chai [Tue, 10 Nov 2020 11:17:39 +0000 (19:17 +0800)]
Merge pull request #38006 from xxhdx1985126/wip-crimson-recovery-bug-fix2

crimson/osd: make load_obc_for_recovery pop up all errors

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: make load_obc_for_recovery pop up all errors 38006/head
Xuehan Xu [Tue, 10 Nov 2020 10:33:01 +0000 (18:33 +0800)]
crimson/osd: make load_obc_for_recovery pop up all errors

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
4 years agoMerge pull request #37943 from xxhdx1985126/wip-crimson-recovery-bug-fix
Kefu Chai [Tue, 10 Nov 2020 10:07:16 +0000 (18:07 +0800)]
Merge pull request #37943 from xxhdx1985126/wip-crimson-recovery-bug-fix

crimson: recovery bug fix

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37997 from rhcs-dashboard/48155-fix-api-test-full-health
Kefu Chai [Tue, 10 Nov 2020 09:53:50 +0000 (17:53 +0800)]
Merge pull request #37997 from rhcs-dashboard/48155-fix-api-test-full-health

mgr/dashboard: fix API test: test_full_health

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agomgr/dashboard: fix API test: test_full_health 37997/head
Alfonso Martínez [Tue, 10 Nov 2020 08:29:45 +0000 (09:29 +0100)]
mgr/dashboard: fix API test: test_full_health

Fixes: https://tracker.ceph.com/issues/48155
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
4 years agoMerge PR #37942 into master
Jan Fajerski [Tue, 10 Nov 2020 07:30:55 +0000 (08:30 +0100)]
Merge PR #37942 into master

* refs/pull/37942/head:
ceph-volume: fix lvm help test
ceph-volume: add a unit tests to lvm batch
ceph-volume: fix lvm batch auto with full SSDs

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
4 years agocrimson/osd: make non-first push ops' version to be the version of the recovering... 37943/head
Xuehan Xu [Sun, 1 Nov 2020 10:46:16 +0000 (18:46 +0800)]
crimson/osd: make non-first push ops' version to be the version of the recovering object

An object may take more than one push op to recover, those later push ops also need to
set their version accordingly

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
4 years agocrimson/osd: make PglogBasedRecovery op take recovering objs triggered elsewhere...
Xuehan Xu [Sat, 31 Oct 2020 11:53:12 +0000 (19:53 +0800)]
crimson/osd: make PglogBasedRecovery op take recovering objs triggered elsewhere into account

PGRecovery::start_recovery_ops() should wait for all inflight recovery ops, whether they are
started by BackgroundRecovery or not, otherwise there may be circumstances in which BackgroundRecovery
keep recursively invoking its do_recovery when start_recovery_ops returns recovery done while there are
still missing objects.

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
4 years agoMerge pull request #37941 from dzafman/wip-48077
David Zafman [Mon, 9 Nov 2020 23:12:34 +0000 (15:12 -0800)]
Merge pull request #37941 from dzafman/wip-48077

Allowing scrub configs begin_day/end_day to include 7 and begin_hour/end_hour to include 24 is confusing

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #37539 from zdover23/wip-doc-ceph-df-2020-oct
Josh Durgin [Mon, 9 Nov 2020 23:09:45 +0000 (15:09 -0800)]
Merge pull request #37539 from zdover23/wip-doc-ceph-df-2020-oct

doc/rados: ceph df output update

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agotest: unittest_osdscrub: Remove invalid hour test and add day of week testing 37941/head
David Zafman [Wed, 4 Nov 2020 17:20:17 +0000 (09:20 -0800)]
test: unittest_osdscrub: Remove invalid hour test and add day of week testing

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoosd: Eliminate day of weeek 7 and hour 24
David Zafman [Tue, 3 Nov 2020 03:26:57 +0000 (03:26 +0000)]
osd: Eliminate day of weeek 7 and hour 24

Add test case for permitted hours to make sure scrub doesn't start
Remove permitted hours in extended sleep test

Fixes: https://tracker.ceph.com/issues/48077
Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agodoc/rados: ceph df output update 37539/head
Zac Dover [Sun, 4 Oct 2020 20:28:51 +0000 (06:28 +1000)]
doc/rados: ceph df output update

This commit updates the "ceph df" output
so that it is current as of October 2020.
-Add correctly formatted `ceph df` output.
-Add explanation of "DIRTY" column.
-(DATA) remains to be defined (1 instance)
-(OMAP) remains to be defined (1 instance)
-USED remains to be defined (1 instance)
-Update prompts in "Checking OSD Status"

Fixes: https://tracker.ceph.com/issues/47523
Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agocephadm: install podman from the Kubic project 37922/head
Michael Fritch [Mon, 2 Nov 2020 15:54:53 +0000 (08:54 -0700)]
cephadm: install podman from the Kubic project

ppa:projectatomic is no longer maintained, updates are now provided via
the Kubic project

Fixes: https://tracker.ceph.com/issues/48072
Signed-off-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge PR #37932 into master
Patrick Donnelly [Mon, 9 Nov 2020 16:17:18 +0000 (08:17 -0800)]
Merge PR #37932 into master

* refs/pull/37932/head:
src/script/ceph-backport.sh: abort if jq not available

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoceph-volume: fix lvm help test 37942/head
Dimitri Savineau [Mon, 9 Nov 2020 15:50:20 +0000 (10:50 -0500)]
ceph-volume: fix lvm help test

ed5ceb0 changed the LVM help code but not the associated test.

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
4 years agoceph-volume: add a unit tests to lvm batch
Guillaume Abrioux [Wed, 4 Nov 2020 14:11:58 +0000 (15:11 +0100)]
ceph-volume: add a unit tests to lvm batch

This commit adds unit tests in order to cover `_sort_rotational_disks()`
call when deploying with full hdd/ssd or mixed hdd/sdd scenarios.

Fixes: https://tracker.ceph.com/issues/48150
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Co-authored-by: Dimitri Savineau <dsavinea@redhat.com>
4 years agoceph-volume: fix lvm batch auto with full SSDs
Dimitri Savineau [Tue, 3 Nov 2020 23:21:35 +0000 (18:21 -0500)]
ceph-volume: fix lvm batch auto with full SSDs

The ceph-volume lvm batch --auto introduced by [1] breaks the backward
compatibility when using non rotational devices only (SSD and/or NVMe).
Those devices are reaffected as bluestore db or filestore journal
devices while we want them as data devices.

Fixes: https://tracker.ceph.com/issues/48106
[1] https://github.com/ceph/ceph/pull/34740

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
4 years agoMerge pull request #37928 from tchaikov/wip-qa-ceph-ctx-archive
Kefu Chai [Mon, 9 Nov 2020 15:48:30 +0000 (23:48 +0800)]
Merge pull request #37928 from tchaikov/wip-qa-ceph-ctx-archive

qa/tasks/ceph: extract update_archive_setting()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #37453 from tspmelo/wip-rbd-change-detection
Lenz Grimmer [Mon, 9 Nov 2020 14:10:24 +0000 (15:10 +0100)]
Merge pull request #37453 from tspmelo/wip-rbd-change-detection

mgr/dashboard: Improve Change Detection on RBD Snapshot

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
4 years agoMerge pull request #37641 from henyxia/dev/henyxia/add-mgr-dashboard-prom-ssl-verify
Lenz Grimmer [Mon, 9 Nov 2020 14:07:57 +0000 (15:07 +0100)]
Merge pull request #37641 from henyxia/dev/henyxia/add-mgr-dashboard-prom-ssl-verify

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #37983 from tchaikov/wip-crimson-os-co-locate-alien-allocator
Kefu Chai [Mon, 9 Nov 2020 13:34:20 +0000 (21:34 +0800)]
Merge pull request #37983 from tchaikov/wip-crimson-os-co-locate-alien-allocator

crimson/os: do not configure seastar allocator for alien threads

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge PR #32777 into master
Jan Fajerski [Mon, 9 Nov 2020 13:10:36 +0000 (14:10 +0100)]
Merge PR #32777 into master

* refs/pull/32777/head:
common,log,msg: Fix win32 compiler warnings
win32,common: provide a default ceph.conf location
common: add newline before parsing config on Windows
common: verify unix sockets support on Windows
common: fix md_config_t::get_cluster_name
global, common: Print config parse errors
common: accept config files containing whitespaces
librbd: avoid broken mingw rng
common: define DEV_NULL
tools,common,msg: Use O_BINARY for win32 compatibility
log: fix timestamps on Windows
common,librbd: add portable ceph_memzero_s
common,msg: Fix socket handling
common: Extend win32 compatbility layer

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37984 from tchaikov/wip-fio
Kefu Chai [Mon, 9 Nov 2020 13:08:13 +0000 (21:08 +0800)]
Merge pull request #37984 from tchaikov/wip-fio

cmake: drop WITH_SYSTEM_FIO option

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #37965 from rhcs-dashboard/about-modal-cleanup
Lenz Grimmer [Mon, 9 Nov 2020 12:37:55 +0000 (13:37 +0100)]
Merge pull request #37965 from rhcs-dashboard/about-modal-cleanup

mgr/dashboard: Moving copyright variable into the app.constants

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #37958 from ronen-fr/wip-ronenf-librbd-move1
Jason Dillaman [Mon, 9 Nov 2020 12:14:43 +0000 (07:14 -0500)]
Merge pull request #37958 from ronen-fr/wip-ronenf-librbd-move1

librbd: removing a "pessimizing move"

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37990 from tchaikov/wip-liburing-fPIC
Kefu Chai [Mon, 9 Nov 2020 12:10:05 +0000 (20:10 +0800)]
Merge pull request #37990 from tchaikov/wip-liburing-fPIC

cmake: build liburing with -fPIC

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #37915 from gregsfortytwo/wip-stretch-fixes
Gregory Farnum [Mon, 9 Nov 2020 11:52:07 +0000 (03:52 -0800)]
Merge pull request #37915 from gregsfortytwo/wip-stretch-fixes

Fix several stretch mode issues

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge PR #37741 into master
Jan Fajerski [Mon, 9 Nov 2020 10:33:18 +0000 (11:33 +0100)]
Merge PR #37741 into master

* refs/pull/37741/head:
ceph-volume: remove mention of dmcache from docs and help text

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
4 years agoMerge PR #37896 into master
Jan Fajerski [Mon, 9 Nov 2020 10:30:35 +0000 (11:30 +0100)]
Merge PR #37896 into master

* refs/pull/37896/head:
ceph-volume: implement the --log-level flag

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
4 years agoMerge pull request #37506 from rhcs-dashboard/fix-47478-master
Lenz Grimmer [Mon, 9 Nov 2020 09:45:35 +0000 (10:45 +0100)]
Merge pull request #37506 from rhcs-dashboard/fix-47478-master

mgr/dashboard: Improvements in cluster > OSDs

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #37649 from rhcs-dashboard/add-header-tooltip
Lenz Grimmer [Mon, 9 Nov 2020 09:43:50 +0000 (10:43 +0100)]
Merge pull request #37649 from rhcs-dashboard/add-header-tooltip

mgr/dashboard: add description for CRUSH Ruleset

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 years agocmake: build liburing with -fPIC 37990/head
Kefu Chai [Mon, 9 Nov 2020 09:08:35 +0000 (17:08 +0800)]
cmake: build liburing with -fPIC

in liburing,
https://github.com/axboe/liburing/commit/75cad68b953fe0fabbc4b1ced1ab4ba0ed5da18e
partially reverts
https://github.com/axboe/liburing/commit/4e360f71131918c36774f51688e5c65dea8d43f2,
which builds liburing.a with -fPIC.

so we need to pass -fPIC by ourselves. otherwise we'd have

/usr/bin/ld: ../../liburing/src/liburing.a(setup.ol): relocation R_X86_64_PC32 against symbol `io_uring_queue_mmap' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
src/test/fio/CMakeFiles/fio_ceph_objectstore.dir/build.make:154: recipe for target 'lib/libfio_ceph_objectstore.so' failed

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: expose FIO_INCLUDE_DIR via libfio 37984/head
Kefu Chai [Mon, 9 Nov 2020 07:47:41 +0000 (15:47 +0800)]
cmake: expose FIO_INCLUDE_DIR via libfio

always use the fio built from source for better consistency.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: drop WITH_SYSTEM_FIO option
Kefu Chai [Mon, 9 Nov 2020 07:36:47 +0000 (15:36 +0800)]
cmake: drop WITH_SYSTEM_FIO option

there is no well-known distro packaging fio.h, so drop this option.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37981 from tchaikov/wip-make-dist
Kefu Chai [Mon, 9 Nov 2020 07:58:16 +0000 (15:58 +0800)]
Merge pull request #37981 from tchaikov/wip-make-dist

make-dist: add liburing to dist tarball

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 years agocmake: use make explicitly to build fio
Kefu Chai [Mon, 9 Nov 2020 07:34:55 +0000 (15:34 +0800)]
cmake: use make explicitly to build fio

we cannot assume that user uses "make" as the generator of cmake, if,
for instance, ninja is used, `$(MAKE)` is not a valid variable in the
generated `build.ninja`. so we should use "make" explicitly.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/os: do not configure seastar allocator for alien threads 37983/head
Kefu Chai [Mon, 9 Nov 2020 06:34:00 +0000 (14:34 +0800)]
crimson/os: do not configure seastar allocator for alien threads

4cd2b00d2a703510777bd761609be221859bd790 allows us to colocate seastar
allocator used by seastar reactors and libc allocator used by alien threads,
there is no need to configure seastar allocator for alien thread
anymore.

this change partially reverts

f7715b86ef09a820adb2d43d4e82cabc9a04199f
b55919071fc872d880bebe70bc270b9d66d02ab0

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/os: do not #include unused headers
Kefu Chai [Mon, 9 Nov 2020 06:41:25 +0000 (14:41 +0800)]
crimson/os: do not #include unused headers

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: use src/liburing for building liburing if it exists 37981/head
Kefu Chai [Mon, 9 Nov 2020 05:11:06 +0000 (13:11 +0800)]
cmake: use src/liburing for building liburing if it exists

so we can build with liburing enabled if the dist tarball contains
liburing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomake-dist: use a loop to collect the ingredients of the dist tarball
Kefu Chai [Mon, 9 Nov 2020 04:31:34 +0000 (12:31 +0800)]
make-dist: use a loop to collect the ingredients of the dist tarball

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomake-dist: add liburing to dist tarball
Kefu Chai [Mon, 9 Nov 2020 04:25:24 +0000 (12:25 +0800)]
make-dist: add liburing to dist tarball

since liburing is enabled by default, let's included it in the dist
tarball.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomake-dist: extract download_from() out
Kefu Chai [Mon, 9 Nov 2020 03:58:10 +0000 (11:58 +0800)]
make-dist: extract download_from() out

so we can reuse it

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoqa: fix broken links in multimds suite 37978/head
Patrick Donnelly [Sat, 7 Nov 2020 19:15:11 +0000 (11:15 -0800)]
qa: fix broken links in multimds suite

Fixes: #37899
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #36998 into master
Patrick Donnelly [Sat, 7 Nov 2020 04:51:54 +0000 (20:51 -0800)]
Merge PR #36998 into master

* refs/pull/36998/head:
doc/mgr/volumes: Document authorize/deauthorize cli commands
qa/tasks/cephfs: test `fs subvolume authorize/deauthorize`
mgr/volumes: Allow/deny auth IDs access to FS subvolumes
mon/MonCap: allow 'profile mgr' to create/update/del auth IDs

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #37618 into master
Patrick Donnelly [Sat, 7 Nov 2020 04:51:06 +0000 (20:51 -0800)]
Merge PR #37618 into master

* refs/pull/37618/head:
mds: throttle cap acquisition via readdir

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #37662 into master
Patrick Donnelly [Sat, 7 Nov 2020 04:50:28 +0000 (20:50 -0800)]
Merge PR #37662 into master

* refs/pull/37662/head:
mon/MDSMonitor: deal with subscription after being expired

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #37600 from mgfritch/cephadm-nfs-rgw
Michael Fritch [Sat, 7 Nov 2020 01:10:26 +0000 (18:10 -0700)]
Merge pull request #37600 from mgfritch/cephadm-nfs-rgw

mgr/cephadm: add RGW support for NFS ganesha

Reviewed-by: Daniel-Pivonka <dpivonka@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #37792 from p-se/monitoring-prom-many-to-many
Michael Fritch [Sat, 7 Nov 2020 01:02:00 +0000 (18:02 -0700)]
Merge pull request #37792 from p-se/monitoring-prom-many-to-many

mgr/cephadm: many-to-many Prometheus error

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #37967 from linuxbox2/wip-rgwfile-zwrite
Matt Benjamin [Fri, 6 Nov 2020 17:41:48 +0000 (12:41 -0500)]
Merge pull request #37967 from linuxbox2/wip-rgwfile-zwrite

rgw_file: fix some zipper flow for RGWLibContinuedReq

4 years agoMerge pull request #37968 from changchengx/paxos
Kefu Chai [Fri, 6 Nov 2020 15:37:27 +0000 (23:37 +0800)]
Merge pull request #37968 from changchengx/paxos

mon/PaxosService: remove unnecessary code

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37970 from toabctl/fix-orch-cli-doc-link
Kefu Chai [Fri, 6 Nov 2020 11:34:03 +0000 (19:34 +0800)]
Merge pull request #37970 from toabctl/fix-orch-cli-doc-link

mgr/orchestratori: Fix doc link in README.rst

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agomgr/orchestrator_cli: Fix doc link in README.rst 37970/head
Thomas Bechtold [Fri, 6 Nov 2020 08:42:47 +0000 (09:42 +0100)]
mgr/orchestrator_cli: Fix doc link in README.rst

Signed-off-by: Thomas Bechtold <tbechtold@suse.com>
4 years agodoc: update stretch mode doc to not be a lie 37915/head
Greg Farnum [Fri, 6 Nov 2020 06:24:49 +0000 (06:24 +0000)]
doc: update stretch mode doc to not be a lie

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
4 years agomon: include stretch mode status in more outputs
Greg Farnum [Thu, 5 Nov 2020 00:07:01 +0000 (00:07 +0000)]
mon: include stretch mode status in more outputs

It was missing from the monmap dump, and included in OSDMap::dump()
but not the OSDMap::print() which is used for text-based CLI queries.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
4 years agomon: retain disallowed leader list on restart
Greg Farnum [Mon, 2 Nov 2020 08:14:48 +0000 (08:14 +0000)]
mon: retain disallowed leader list on restart

We were only setting this when new monmaps were read from paxos -- whoops!
Pull apart that mechanism a little bit and make sure to set them before
doing elections, as part of bootstrap.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
4 years agomon: Output the real leader in ::_quorum_status() and get_leader_name()
Greg Farnum [Thu, 29 Oct 2020 06:10:23 +0000 (06:10 +0000)]
mon: Output the real leader in ::_quorum_status() and get_leader_name()

These functions previously assumed the first mon in the quorum
was the leader. That isn't accurate if the first monitor is
disallowed or it lost a connectivity-mode election, though.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
4 years agomon: monmap: print out disallowed_leaders in text form, when non-empty
Greg Farnum [Thu, 29 Oct 2020 06:06:24 +0000 (06:06 +0000)]
mon: monmap: print out disallowed_leaders in text form, when non-empty

This is already dumped in the programmatic output, but it got left out of
the direct-user-facing calls (as in "ceph mon dump").

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
4 years agomon: Do not increase compatv when using monitor location or stretch mode
Greg Farnum [Thu, 29 Oct 2020 05:58:56 +0000 (05:58 +0000)]
mon: Do not increase compatv when using monitor location or stretch mode

For mon_info_t, I first wrote things so that when monitors get a location
added in MonMap::mon_info_t, I bumped the struct_v to 5 and also bumped
the min_compat to 5. This made sure that nobody could decode the
struct and lose the location info, which if it were a monitor
would be very bad.

And for the MonMap, when stretch mode is enabled I bumped up the
comptav (in addition to the always-increased struct_v), for the same reason.

But clients also have to decode these structures, and we can't
disallow older clients from connecting to a stretched cluster.

Happily, usage of any stretch modes already requires a feature
bit and sets it as required in the monmap, so these are already
gated. Therefore, just don't set new compat values in these cases.

While at it, also gate setting the location on the monmap indicating
all monitors are updated.

Reported-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
4 years agomon: fix erroneous commit of monmap stretch mode when failing to enable
Greg Farnum [Fri, 23 Oct 2020 16:32:33 +0000 (16:32 +0000)]
mon: fix erroneous commit of monmap stretch mode when failing to enable

MonmapMonitor::try_enable_stretch_mode() was accidentally writing into the
pending_map even when commit was false. Whoops!

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
4 years agoMerge pull request #37966 from tchaikov/wip-cmake-uring 38003/head
Kefu Chai [Fri, 6 Nov 2020 03:36:24 +0000 (11:36 +0800)]
Merge pull request #37966 from tchaikov/wip-cmake-uring

cmake: set GIT_SHALLOW and UPDATE_DISCONNECTED

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agocmake: set GIT_SHALLOW and UPDATE_DISCONNECTED 37966/head
Kefu Chai [Thu, 5 Nov 2020 16:16:45 +0000 (00:16 +0800)]
cmake: set GIT_SHALLOW and UPDATE_DISCONNECTED

* GIT_SHALLOW=TRUE, so we don't pull the full git history,
  as we don't care about it.
* UPDATE_DISCONNECTED=TRUE, to skip the UPDATE step, this change
  somehow works around
  https://gitlab.kitware.com/cmake/cmake/-/issues/19703. otherwise
  cmake keeps building liburing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoblk/kernel/io_uring: bump liburing to v0.7
Kefu Chai [Thu, 5 Nov 2020 16:37:32 +0000 (00:37 +0800)]
blk/kernel/io_uring: bump liburing to v0.7

* use functions exposed by liburing instead of using syscalls
* v0.7 is the latest release at the time of writing, as liburing is under
  active development. it'd be better to use a newer release.
* also use https://git.kernel.dk/liburing instead of
  http://git.kernel.dk/liburing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agorgw_file: fix some zipper flow for RGWLibContinuedReq 37967/head
Matt Benjamin [Wed, 4 Nov 2020 17:02:27 +0000 (12:02 -0500)]
rgw_file: fix some zipper flow for RGWLibContinuedReq

Some bits of the standard Zipper conversions were missed for
the RGWLibContinuedReq case, where the setup is encapsulated in
the request, but execution is broken up in to steps.   This
currently affects only RGWWriteRequest.

Fixes: https://tracker.ceph.com/issues/48136
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
4 years agolibrbd: removing a "pessimizing move" 37958/head
Ronen Friedman [Thu, 5 Nov 2020 08:38:37 +0000 (10:38 +0200)]
librbd: removing a "pessimizing move"

Silencing a compiler warning ("warning: moving a temporary object
prevents copy elision")

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 years agomgr/dashboard: Moving copyright into the app.constants 37965/head
Nizamudeen A [Thu, 5 Nov 2020 16:27:00 +0000 (21:57 +0530)]
mgr/dashboard: Moving copyright into the app.constants

Move the variable copyright from about.component.ts to the app.constants.ts

https://tracker.ceph.com/issues/48135
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 years agoMerge pull request #37919 from tchaikov/wip-cmake-liburing
Kefu Chai [Thu, 5 Nov 2020 15:32:32 +0000 (23:32 +0800)]
Merge pull request #37919 from tchaikov/wip-cmake-liburing

cmake: enable LIBURING bluestore backend by default

Reviewed-by: Mark Nelson <mnelson@redhat.com>
4 years agoMerge pull request #37929 from BryceCao/wip-modify-error-code-of-bucket-info-API
Casey Bodley [Thu, 5 Nov 2020 15:04:30 +0000 (10:04 -0500)]
Merge pull request #37929 from BryceCao/wip-modify-error-code-of-bucket-info-API

rgw : modify error message to NoSuchBucket when bucket doesn't exist in bucket info API

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #37913 from rhcs-dashboard/button-disable
Lenz Grimmer [Thu, 5 Nov 2020 13:54:16 +0000 (14:54 +0100)]
Merge pull request #37913 from rhcs-dashboard/button-disable

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #37832 from tchaikov/wip-doc-slow-ops
Kefu Chai [Thu, 5 Nov 2020 13:05:17 +0000 (21:05 +0800)]
Merge pull request #37832 from tchaikov/wip-doc-slow-ops

doc: reformat health-messages.rst and revise SLOW_OPS section

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #37951 from agayev/misc-zbd-changes
Kefu Chai [Thu, 5 Nov 2020 13:01:46 +0000 (21:01 +0800)]
Merge pull request #37951 from agayev/misc-zbd-changes

doc, os/bluestore: Zoned storage related cleanup.

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37637 from p-se/dashboard-smart-logging
Lenz Grimmer [Thu, 5 Nov 2020 12:38:59 +0000 (13:38 +0100)]
Merge pull request #37637 from p-se/dashboard-smart-logging

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>