]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agolog/Log: cast typed pointer to integer before printing it 38097/head
Kefu Chai [Mon, 16 Nov 2020 07:21:19 +0000 (15:21 +0800)]
log/Log: cast typed pointer to integer before printing it

libfmt does not print pointer if it's not "void*", but "thread_t" is
defined as a pointer pointing to "struct pthread" on FreeBSD, so we need
to cast it either to "void*" or an integer". let's cast it to an integer
so it's more consistent with the output on Linux where thread_t is
defined as an integer.

this change addresses the FTBFS on FreeBSD likee:

In file included from /home/jenkins/workspace/ceph-master-compile/src/log/Log.cc:27:
In file included from /usr/local/include/fmt/format.h:44:
/usr/local/include/fmt/core.h:1043:20: error: invalid application of 'sizeof' to an incomplete type 'pthread'
    static_assert(!sizeof(T), "formatting of non-void pointers is disallowed");
                   ^~~~~~~~~
/usr/local/include/fmt/core.h:1259:32: note: in instantiation of function template specialization
'fmt::v7::detail::arg_mapper<fmt::v7::basic_format_context<std::__1::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::map<pthread>' requested here
  return arg_mapper<Context>().map(val);
                               ^
/usr/local/include/fmt/core.h:1408:23: note: in instantiation of function template specialization 'fmt::v7::detail::make_arg<true,
fmt::v7::basic_format_context<std::__1::back_insert_iterator<fmt::v7::detail::buffer<char> >, char>, fmt::v7::detail::type::int_type, pthread *, 0>' requested here
        data_{detail::make_arg<
                      ^
/usr/local/include/fmt/core.h:1764:10: note: in instantiation of member function 'fmt::v7::format_arg_store<fmt::v7::basic_format_context<std::__1::back_insert_iterator<fmt::v7::detail::buffer<char>
>, char>, pthread *const, char *>::format_arg_store' requested here
  return {args...};
         ^
/usr/local/include/fmt/core.h:1835:31: note: in instantiation of function template specialization 'fmt::v7::detail::make_args_checked<pthread *const &, char *, char [10], char>' requested here
  const auto& vargs = detail::make_args_checked<Args...>(format_str, args...);
                              ^
/home/jenkins/workspace/ceph-master-compile/src/log/Log.cc:376:23: note: in instantiation of function template specialization 'fmt::v7::format<char [10], pthread *const &, char *, char>' requested
here
    _log_message(fmt::format("  {} / {}", pthread_id, (char*)pthread_name), true);
                      ^
/usr/include/sys/_pthreadtypes.h:46:8: note: forward declaration of 'pthread'
struct pthread;
       ^
1 error generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agolog/Log: cast parameter of syslog() from unsigned to int
Kefu Chai [Mon, 16 Nov 2020 07:18:33 +0000 (15:18 +0800)]
log/Log: cast parameter of syslog() from unsigned to int

silences warning like:

../src/log/Log.cc:325:34: warning: field precision should have type 'int', but argument has type 'std::basic_string_view::size_type' (aka 'unsigned long') [-Wformat]
    syslog(LOG_USER|LOG_INFO, "%.*s", s.size(), s.data());
                               ~~^~   ~~~~~~~~
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomessage: mark message classes "final"
Kefu Chai [Mon, 16 Nov 2020 06:58:22 +0000 (14:58 +0800)]
message: mark message classes "final"

silences warnings like:

src/messages/MOSDPGUpdateLogMissingReply.h:74:34: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
  ~MOSDPGUpdateLogMissingReply() final {}
                                 ^
../src/messages/MOSDPGUpdateLogMissingReply.h:21:7: note: mark 'MOSDPGUpdateLogMissingReply' as 'final' to silence this warning
class MOSDPGUpdateLogMissingReply : public MOSDFastDispatchOp {
      ^
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge PR #34842 into master
Patrick Donnelly [Sun, 15 Nov 2020 20:39:11 +0000 (12:39 -0800)]
Merge PR #34842 into master

* refs/pull/34842/head:
qa/tasks/vstart_runner.py: disable the ns unsharing if using localhost

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge PR #37746 into master
Patrick Donnelly [Sun, 15 Nov 2020 20:38:05 +0000 (12:38 -0800)]
Merge PR #37746 into master

* refs/pull/37746/head:
client: add a dedicated thread for the Client tick
client: try to renew caps and flush old cap releases

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #37982 into master
Patrick Donnelly [Sun, 15 Nov 2020 20:37:02 +0000 (12:37 -0800)]
Merge PR #37982 into master

* refs/pull/37982/head:
qa/cephfs: add code for when config is None in __init__

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
4 years agoMerge PR #38016 into master
Patrick Donnelly [Sun, 15 Nov 2020 20:35:58 +0000 (12:35 -0800)]
Merge PR #38016 into master

* refs/pull/38016/head:
qa: switch to 'osdop_read' instead of 'op_r'

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #38056 into master
Patrick Donnelly [Sun, 15 Nov 2020 20:34:00 +0000 (12:34 -0800)]
Merge PR #38056 into master

* refs/pull/38056/head:
pybind/mgr/volumes: use = for equality comparision

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #38077 from tchaikov/wip-doc-scrub-max
Brad Hubbard [Sun, 15 Nov 2020 20:19:09 +0000 (06:19 +1000)]
Merge pull request #38077 from tchaikov/wip-doc-scrub-max

doc/rados/operation: add link to scrub_max_interval

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38038 from bk201/wip-48209
Kefu Chai [Sun, 15 Nov 2020 17:29:46 +0000 (01:29 +0800)]
Merge pull request #38038 from bk201/wip-48209

mgr/dashboard: fix cephadm e2e test failure on deleting OSDs

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #37908 from dzafman/wip-47930
Kefu Chai [Sun, 15 Nov 2020 17:00:56 +0000 (01:00 +0800)]
Merge pull request #37908 from dzafman/wip-47930

test: Fix race in TEST_recovery_scrub test

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #38043 from jhonxue/wip-fix-bluestore-bitmap-allocator
Kefu Chai [Sun, 15 Nov 2020 16:38:35 +0000 (00:38 +0800)]
Merge pull request #38043 from jhonxue/wip-fix-bluestore-bitmap-allocator

osd: fix bluestore bitmap allocator calculate wrong last_pos with hint

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #37963 from aclamk/wip-bluestore-no-debug-misc
Kefu Chai [Sun, 15 Nov 2020 16:37:51 +0000 (00:37 +0800)]
Merge pull request #37963 from aclamk/wip-bluestore-no-debug-misc

os/bluestore: Removed bluestore_debug_misc option

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #37999 from trociny/wip-48153
Kefu Chai [Sun, 15 Nov 2020 16:34:12 +0000 (00:34 +0800)]
Merge pull request #37999 from trociny/wip-48153

os/bluestore: fix "end reached" check in collection_list_legacy

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #37630 from zjcmszh/aio_rmxattr
Kefu Chai [Sun, 15 Nov 2020 16:32:22 +0000 (00:32 +0800)]
Merge pull request #37630 from zjcmszh/aio_rmxattr

pybind/rados: add Ioctx::aio_rmxattr() and test aio_rmxattr()

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37976 from batrick/msg-destructor
Kefu Chai [Sun, 15 Nov 2020 16:31:21 +0000 (00:31 +0800)]
Merge pull request #37976 from batrick/msg-destructor

messages: use final specifier for destructor

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37992 from rishabh-d-dave/dashboard-qa-skipTest
Kefu Chai [Sun, 15 Nov 2020 16:30:42 +0000 (00:30 +0800)]
Merge pull request #37992 from rishabh-d-dave/dashboard-qa-skipTest

qa/mgr: mgr_test_case: raise SkipTest instead of calling skipTest()

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
4 years agoMerge pull request #37998 from tchaikov/wip-log-mon-cleanup
Kefu Chai [Sun, 15 Nov 2020 16:18:17 +0000 (00:18 +0800)]
Merge pull request #37998 from tchaikov/wip-log-mon-cleanup

log,mon: use libfmt to format string and use range-based loop

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
4 years agoMerge pull request #38026 from wjwithagen/wjw-fix-test-mon-build_initial
Kefu Chai [Sun, 15 Nov 2020 16:09:15 +0000 (00:09 +0800)]
Merge pull request #38026 from wjwithagen/wjw-fix-test-mon-build_initial

test/mon: FreeBSD returns ENOENT on resolv error

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agotest/mon: Accept ENOENT as returned value on FreeBSD 38026/head
Willem Jan Withagen [Wed, 11 Nov 2020 14:09:12 +0000 (15:09 +0100)]
test/mon: Accept ENOENT as returned value on FreeBSD

FreeBSD returns ENOENT on resolv error

Tracker: https://tracker.ceph.com/issues/48183
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agodoc/rados/operation: add link to scrub_max_interval 38077/head
Kefu Chai [Sat, 14 Nov 2020 06:59:04 +0000 (14:59 +0800)]
doc/rados/operation: add link to scrub_max_interval

add the reference to the per-pool setting when explaing
PG_NOT_DEEP_SCRUBBED.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38082 from adamemerson/wip-anti-nihilism
J. Eric Ivancich [Sun, 15 Nov 2020 03:35:23 +0000 (22:35 -0500)]
Merge pull request #38082 from adamemerson/wip-anti-nihilism

Asyncening 0: The Yielding Anti-Nihilist

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
4 years agoMerge PR #38071 into master
Patrick Donnelly [Sat, 14 Nov 2020 18:04:12 +0000 (10:04 -0800)]
Merge PR #38071 into master

* refs/pull/38071/head:
.github: add labeler for cephfs

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38067 from dillaman/wip-github-rbd-label
Kefu Chai [Sat, 14 Nov 2020 16:53:38 +0000 (00:53 +0800)]
Merge pull request #38067 from dillaman/wip-github-rbd-label

github: add 'rbd' auto-labelling

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38013 from drakonstein/master
Kefu Chai [Sat, 14 Nov 2020 11:56:40 +0000 (19:56 +0800)]
Merge pull request #38013 from drakonstein/master

rpm,deb: change sudoers file mode to 440

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
4 years agoMerge pull request #38073 from badone/wip-use-right-tunable-for-pg-scrub-doc 38145/head
Brad Hubbard [Sat, 14 Nov 2020 04:49:27 +0000 (14:49 +1000)]
Merge pull request #38073 from badone/wip-use-right-tunable-for-pg-scrub-doc

doc: Use correct tunable for PG_NOT_SCRUBBED

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37883 from diwilli/patch-1
Michael Fritch [Sat, 14 Nov 2020 02:27:59 +0000 (19:27 -0700)]
Merge pull request #37883 from diwilli/patch-1

cephadm: Set listen-addresses on alertmanager container

Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
4 years agoMerge pull request #38011 from mgfritch/cephadm-sudo-log-dir
Michael Fritch [Sat, 14 Nov 2020 02:23:34 +0000 (19:23 -0700)]
Merge pull request #38011 from mgfritch/cephadm-sudo-log-dir

cephadm: verify root privileges before log dir create

Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
4 years ago.github: add labeler for cephfs 38071/head
Patrick Donnelly [Fri, 13 Nov 2020 23:07:12 +0000 (15:07 -0800)]
.github: add labeler for cephfs

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agogithub: add 'rbd' auto-labelling 38067/head
Jason Dillaman [Fri, 13 Nov 2020 19:43:21 +0000 (14:43 -0500)]
github: add 'rbd' auto-labelling

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agorgw: No null_yield in rgw_rest 38082/head
Adam C. Emerson [Wed, 11 Nov 2020 22:12:08 +0000 (17:12 -0500)]
rgw: No null_yield in rgw_rest

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: No null_yield in rgw_role
Adam C. Emerson [Wed, 11 Nov 2020 20:55:41 +0000 (15:55 -0500)]
rgw: No null_yield in rgw_role

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: no null_yield in rgw_tools
Adam C. Emerson [Wed, 11 Nov 2020 19:06:07 +0000 (14:06 -0500)]
rgw: no null_yield in rgw_tools

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: No null_yield in rgw_torrent
Adam C. Emerson [Wed, 11 Nov 2020 17:13:50 +0000 (12:13 -0500)]
rgw: No null_yield in rgw_torrent

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: No null_yield in rgw_user
Adam C. Emerson [Wed, 11 Nov 2020 16:25:38 +0000 (11:25 -0500)]
rgw: No null_yield in rgw_user

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: No null_yield in rgw_zone
Adam C. Emerson [Wed, 11 Nov 2020 14:36:23 +0000 (09:36 -0500)]
rgw: No null_yield in rgw_zone

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: No null_yield in RGWOp
Adam C. Emerson [Wed, 11 Nov 2020 06:03:12 +0000 (01:03 -0500)]
rgw: No null_yield in RGWOp

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw/services: No null_yield
Adam C. Emerson [Wed, 11 Nov 2020 00:33:35 +0000 (19:33 -0500)]
rgw/services: No null_yield

Null yield is fine at top levels where we know what kind of thread
we're running into, but do not belong in general use functions.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agoMerge pull request #38057 from zdover23/wip-doc-dev-guide-essentials-source-clean...
Neha Ojha [Fri, 13 Nov 2020 17:42:20 +0000 (09:42 -0800)]
Merge pull request #38057 from zdover23/wip-doc-dev-guide-essentials-source-clean-update

doc/dev: update essentials.rst

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #38036 from zdover23/wip-doc-dev-guide-basic-workflow-make-check...
Neha Ojha [Fri, 13 Nov 2020 17:38:28 +0000 (09:38 -0800)]
Merge pull request #38036 from zdover23/wip-doc-dev-guide-basic-workflow-make-check-nov-2020

doc/dev: improve make check text

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #37977 from dillaman/wip-48145
Mykola Golub [Fri, 13 Nov 2020 14:47:46 +0000 (16:47 +0200)]
Merge pull request #37977 from dillaman/wip-48145

librbd: update hidden global config when removing pool config override

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #37975 from dang/wip-dang-webdir-empty-object
Daniel Gryniewicz [Fri, 13 Nov 2020 14:02:04 +0000 (09:02 -0500)]
Merge pull request #37975 from dang/wip-dang-webdir-empty-object

RGW - Don't create empty obj in webdir

4 years agoMerge pull request #38060 from rhcs-dashboard/wip-master-auto_labels
Kefu Chai [Fri, 13 Nov 2020 12:07:42 +0000 (20:07 +0800)]
Merge pull request #38060 from rhcs-dashboard/wip-master-auto_labels

github: fix autolabel paths

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
4 years agogithub: fix autolabel paths 38060/head
Ernesto Puerta [Fri, 13 Nov 2020 10:19:33 +0000 (11:19 +0100)]
github: fix autolabel paths

Remove starting / from paths and add missing doc path from dashboard.

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoMerge pull request #38055 from tchaikov/wip-doc-conf
Kefu Chai [Fri, 13 Nov 2020 08:58:48 +0000 (16:58 +0800)]
Merge pull request #38055 from tchaikov/wip-doc-conf

doc/rados/configuration: document option types

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 years agodoc/dev: update essentials.rst 38057/head
Zac Dover [Fri, 13 Nov 2020 07:37:58 +0000 (17:37 +1000)]
doc/dev: update essentials.rst

This commit changes the noun "backup" to the
intended verb "back up" (this is one of my
technical documentation pet peeves and I couldn't
resist), and it also removes the verb "to nuke"
and replaces it with something less poetic but
more likely to be discoverable in a dictionary by
someone whose English is weak. It also adds a
missing colon.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agopybind/mgr/volumes: use = for equality comparision 38056/head
Kefu Chai [Fri, 13 Nov 2020 05:33:03 +0000 (13:33 +0800)]
pybind/mgr/volumes: use = for equality comparision

should not rely on the internal implementation of Python to check the
equality of two strings.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc/rados/configuration: document option types 38055/head
Kefu Chai [Fri, 13 Nov 2020 05:32:14 +0000 (13:32 +0800)]
doc/rados/configuration: document option types

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc/rados: remove superfluous "::"
Kefu Chai [Fri, 13 Nov 2020 04:14:00 +0000 (12:14 +0800)]
doc/rados: remove superfluous "::"

this change addresses a regression introduced by
0f2489406a8d4194c159c8777517d20b54e216b5

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: Use correct tunable for PG_NOT_SCRUBBED 38073/head
Brad Hubbard [Fri, 13 Nov 2020 04:33:24 +0000 (14:33 +1000)]
doc: Use correct tunable for PG_NOT_SCRUBBED

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
4 years agodoc/dev: improve make check text 38036/head
Zac Dover [Thu, 12 Nov 2020 09:33:16 +0000 (19:33 +1000)]
doc/dev: improve make check text

This commit fixes the references to the
"make check" section in the "notes on
pr make check test" section and improves
the wording of that section so that it
reads a bit more clearly.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #38049 from rhcs-dashboard/wip-master-auto_labels
Kefu Chai [Fri, 13 Nov 2020 03:35:37 +0000 (11:35 +0800)]
Merge pull request #38049 from rhcs-dashboard/wip-master-auto_labels

github: autolabel PRs

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38023 from zdover23/wip-doc-dev-guide-essentials-nov-2020
Josh Durgin [Fri, 13 Nov 2020 01:25:43 +0000 (17:25 -0800)]
Merge pull request #38023 from zdover23/wip-doc-dev-guide-essentials-nov-2020

doc/dev: update essentials.rst nov 2020

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agodoc/dev: update essentials.rst 38023/head
Zac Dover [Thu, 5 Nov 2020 23:22:03 +0000 (09:22 +1000)]
doc/dev: update essentials.rst

This commit improves the grammar and structure
of essentials.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #37902 from pdvian/wip-clog-health-detail
Neha Ojha [Thu, 12 Nov 2020 23:02:52 +0000 (15:02 -0800)]
Merge pull request #37902 from pdvian/wip-clog-health-detail

mon: Log "ceph health detail" periodically in cluster log

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoRGW - Don't create empty obj in webdir 37975/head
Daniel Gryniewicz [Thu, 5 Nov 2020 19:02:04 +0000 (14:02 -0500)]
RGW - Don't create empty obj in webdir

Zipper objects shouldn't be empty, but should instead be null.  Fix this
case where parsing wasn't checking for empty object name, and the
website code that uses it.

Fixes: https://tracker.ceph.com/issues/48049
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
4 years agogithub: autolabel PRs 38049/head
Ernesto Puerta [Thu, 12 Nov 2020 17:07:44 +0000 (18:07 +0100)]
github: autolabel PRs

... starting with dashboard ones.

Requires https://github.com/marketplace/actions/labeler

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoosd: fix bluestore bitmap allocator calculated wrong last_pos with hint 38043/head
jhonxue [Thu, 12 Nov 2020 15:17:13 +0000 (23:17 +0800)]
osd: fix bluestore bitmap allocator calculated wrong last_pos with hint

Fixes: https://tracker.ceph.com/issues/48214
Signed-off-by: Xue Yantao <jhonxue@tencent.com>
4 years agoMerge pull request #38029 from kshtsk/wip-cephadm-bootstrap-remote
kyr [Thu, 12 Nov 2020 13:19:47 +0000 (14:19 +0100)]
Merge pull request #38029 from kshtsk/wip-cephadm-bootstrap-remote

qa/task/cephadm: run cephadm only on bootstrap_remote

4 years agoMerge pull request #36385 from ghyer/ghyer-dashboard
Ernesto Puerta [Thu, 12 Nov 2020 13:15:04 +0000 (14:15 +0100)]
Merge pull request #36385 from ghyer/ghyer-dashboard

mgr/dashboard: Add 'Dirs' and 'Caps' for filesystems details

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #38027 from s0nea/wip-dashboard-fix-doc-link
Ernesto Puerta [Thu, 12 Nov 2020 13:11:06 +0000 (14:11 +0100)]
Merge pull request #38027 from s0nea/wip-dashboard-fix-doc-link

mgr/dashboard: fix HACKING.rst reference

Reviewed-by: aaSharma14 <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
4 years agoMerge pull request #37993 from votdev/issue_48051_ngx_pipe_function
Ernesto Puerta [Thu, 12 Nov 2020 13:06:15 +0000 (14:06 +0100)]
Merge pull request #37993 from votdev/issue_48051_ngx_pipe_function

mgr/dashboard: Use pipe instead of calling function within template

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #37770 from pritha-srivastava/wip-sts-47871
Matt Benjamin [Thu, 12 Nov 2020 12:58:27 +0000 (07:58 -0500)]
Merge pull request #37770 from pritha-srivastava/wip-sts-47871

rgw/sts: fix for validating path in role arn in assume role api.

4 years agomgr/dashboard: Use pipe instead of calling function within template 37993/head
Volker Theile [Mon, 9 Nov 2020 13:51:53 +0000 (14:51 +0100)]
mgr/dashboard: Use pipe instead of calling function within template

This PR introduces the 'ngx-pipe-function' package to call functions in templates.

Fixes: https://tracker.ceph.com/issues/48051
Signed-off-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #37918 from dungdm93/avoiding-relative-paths
Ernesto Puerta [Thu, 12 Nov 2020 10:42:45 +0000 (11:42 +0100)]
Merge pull request #37918 from dungdm93/avoiding-relative-paths

mgr/dashboards: avoiding relative paths '../../..'

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: nizamial09 <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agomgr/dashboard: fix cephadm e2e test failure on deleting OSDs 38038/head
Kiefer Chang [Thu, 12 Nov 2020 09:20:48 +0000 (17:20 +0800)]
mgr/dashboard: fix cephadm e2e test failure on deleting OSDs

- Adapt the OSD ID column change in this PR:
  https://github.com/ceph/ceph/pull/37506
- Turn off Cypress retries because it makes the failure log misleading.

Fixes: https://tracker.ceph.com/issues/48209
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
4 years agorpm,deb: change sudoers file mode to 440 38013/head
David Turner [Tue, 10 Nov 2020 19:31:35 +0000 (14:31 -0500)]
rpm,deb: change sudoers file mode to 440

change sudoers file mode to 440 to match recommended defaults.

From the sudoers man page.

> the default file mode is 0440 (read‐able by owner and group, writable
by none).
> The default mode may be changed via the “sudoers_mode” option to the
sudoers
>  Plugin line in the sudo.conf(5) file.

Fixes: https://tracker.ceph.com/issues/48169
Signed-off-by: David Turner <drakonstein@gmail.com>
4 years agoMerge pull request #37922 from mgfritch/project-kubic
Kefu Chai [Thu, 12 Nov 2020 02:40:24 +0000 (10:40 +0800)]
Merge pull request #37922 from mgfritch/project-kubic

cephadm: install podman from the Kubic project

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38018 from tchaikov/wip-cmake-python
Kefu Chai [Thu, 12 Nov 2020 01:54:54 +0000 (09:54 +0800)]
Merge pull request #38018 from tchaikov/wip-cmake-python

COPYING: note cmake/modules/FindPython* license and copyright

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #38028 from tchaikov/wip-crimson-maybe-unused
Kefu Chai [Thu, 12 Nov 2020 01:53:47 +0000 (09:53 +0800)]
Merge pull request #38028 from tchaikov/wip-crimson-maybe-unused

crimson/os: mark unused variable [[maybe_unused]]

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #35865 from tchaikov/wip-crimson-recovery-qa
Kefu Chai [Thu, 12 Nov 2020 01:52:33 +0000 (09:52 +0800)]
Merge pull request #35865 from tchaikov/wip-crimson-recovery-qa

qa/suites: add crimson-rados suite

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agoclient: add a dedicated thread for the Client tick 37746/head
Xiubo Li [Mon, 2 Nov 2020 04:23:15 +0000 (23:23 -0500)]
client: add a dedicated thread for the Client tick

The Client::timer will remain to be use by others like the Delegation.

Fixes: https://tracker.ceph.com/issues/47842
Signed-off-by: Xiubo Li <xiubli@redhat.com>
4 years agoMerge pull request #36759 from dzafman/wip-46264
David Zafman [Thu, 12 Nov 2020 01:09:28 +0000 (17:09 -0800)]
Merge pull request #36759 from dzafman/wip-46264

mon: check for mismatched daemon versions

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoclient: try to renew caps and flush old cap releases
Xiubo Li [Wed, 28 Oct 2020 02:40:15 +0000 (22:40 -0400)]
client: try to renew caps and flush old cap releases

For multiple threads case, if there has more than one threads are
waiting the client_lock, which one to be woke up is not determined.
So in worst case the tick() may be stuck for a long time.

When the MDS daemons are out of resources it will recall them and
tell the client to release the caps, so the clients may surge in
receiving thousands of recall_state requests.

Fixes: https://tracker.ceph.com/issues/47842
Signed-off-by: Xiubo Li <xiubli@redhat.com>
4 years agoqa/tasks/vstart_runner.py: disable the ns unsharing if using localhost 34842/head
Xiubo Li [Wed, 10 Jun 2020 09:25:30 +0000 (05:25 -0400)]
qa/tasks/vstart_runner.py: disable the ns unsharing if using localhost

If the -l option is specified in :

$ MDS=3 MON=3 MGR=1 OSD=3 ../src/vstart.sh -n -l

The ceph cluster will use the localhost IP address as the mon host,
and then in the network namespace container the ceph-fuse daemon
couldn't connect to it.

Fixes: https://tracker.ceph.com/issues/45342
Signed-off-by: Xiubo Li <xiubli@redhat.com>
4 years agomon: Log "ceph health detail" periodically in cluster log 37902/head
Prashant D [Fri, 30 Oct 2020 10:40:43 +0000 (06:40 -0400)]
mon: Log "ceph health detail" periodically in cluster log

change mon_health_to_clog_interval from 1_hr -> 10_min to
log health summary or detail more frequently.

Fixes: https://tracker.ceph.com/issues/48042
Signed-off-by: Prashant Dhange <pdhange@redhat.com>
4 years agotest: Changes based on code review comments 36759/head
David Zafman [Wed, 11 Nov 2020 22:00:24 +0000 (14:00 -0800)]
test: Changes based on code review comments

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agodoc: Apply suggestions from code review
David Zafman [Tue, 10 Nov 2020 22:29:08 +0000 (14:29 -0800)]
doc: Apply suggestions from code review

Co-authored-by: Neha Ojha <nehaojha88@gmail.com>
Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoosd test: Delay reporting until mon_warn_older_version_delay has passed
David Zafman [Sun, 8 Nov 2020 17:07:04 +0000 (09:07 -0800)]
osd test: Delay reporting until mon_warn_older_version_delay has passed

Move release notes description to 16.0.0 and update
Update documentation

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoosd: Temporary fix for alienstore which doesn't support asok commands yet
David Zafman [Thu, 22 Oct 2020 16:15:40 +0000 (16:15 +0000)]
osd: Temporary fix for alienstore which doesn't support asok commands yet

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agodoc: Document health check DAEMON_OLD_VERSION
David Zafman [Mon, 28 Sep 2020 22:48:09 +0000 (22:48 +0000)]
doc: Document health check DAEMON_OLD_VERSION

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoUpdate Release notes
David Zafman [Fri, 28 Aug 2020 20:27:42 +0000 (20:27 +0000)]
Update Release notes

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agotest: Simple test case for version health warning
David Zafman [Fri, 28 Aug 2020 18:35:03 +0000 (18:35 +0000)]
test: Simple test case for version health warning

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agotest: Use a config variable debug_version_for_testing
David Zafman [Tue, 25 Aug 2020 01:20:28 +0000 (01:20 +0000)]
test: Use a config variable debug_version_for_testing

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agomon: Add mds version collector
David Zafman [Thu, 27 Aug 2020 17:54:15 +0000 (17:54 +0000)]
mon: Add mds version collector

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agomon: Add mgr version collector
David Zafman [Thu, 27 Aug 2020 05:10:06 +0000 (05:10 +0000)]
mon: Add mgr version collector

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agomon: Add osd version collector
David Zafman [Fri, 11 Sep 2020 21:46:55 +0000 (21:46 +0000)]
mon: Add osd version collector

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agomon: Verify version consistency across daemons
Tyler [Mon, 20 Jul 2020 17:18:29 +0000 (13:18 -0400)]
mon: Verify version consistency across daemons

Add a function called check_daemon_versions()
Made minor changes based on pull request comments
Changed the way versions are checked along with some other minor modifications
Made minor modification to the error message
Modifications to include the hostname in the error message

Fixes: https://tracker.ceph.com/issues/46264
Signed-off-by: Tyler <tyler_sheehan@student.uml.edu>
Remove time since health errors aren't preserved if not set every time
Rename health error to DAEMON_OLD_VERSION
Reoganize code so that we can get versions from other daemon types
Change to map of version (key), a list of daemons (value)
Get actual daemon names from get_versions() requests
Fix message output based on how many daemons and how many versions
Add a config to be able to turn off this features
Give HEALTH_ERR if more than one older version exists
Fix minor indentation problem with health detail

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoqa/task/cephadm: run cephadm only on bootstrap_remote 38029/head
Kyr Shatskyy [Wed, 11 Nov 2020 15:18:56 +0000 (16:18 +0100)]
qa/task/cephadm: run cephadm only on bootstrap_remote

Because not all the node in teuthology config might
have any cephadm related role we should not execute
cephadm on random node.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
4 years agoMerge PR #37978 into master
Patrick Donnelly [Wed, 11 Nov 2020 19:07:27 +0000 (11:07 -0800)]
Merge PR #37978 into master

* refs/pull/37978/head:
qa: fix broken links in multimds suite

Reviewed-by: Jeff Layton <jlayton@redhat.com>
4 years agocephadm: verify root privileges before log dir create 38011/head
Michael Fritch [Tue, 10 Nov 2020 01:07:15 +0000 (18:07 -0700)]
cephadm: verify root privileges before log dir create

root privileges need to be verified before creating the log dir

introduced by 81a7df0

Fixes: https://tracker.ceph.com/issues/48166
Signed-off-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #37235 from adk3798/4mon
Michael Fritch [Wed, 11 Nov 2020 16:09:30 +0000 (09:09 -0700)]
Merge pull request #37235 from adk3798/4mon

mgr/cephadm: only deploy 3 mons by default when there are 4 hosts

Reviewed-by: Joshua Schmid <jschmid@suse.de>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agocrimson/os: mark unused variable [[maybe_unused]] 38028/head
Kefu Chai [Wed, 11 Nov 2020 15:22:08 +0000 (23:22 +0800)]
crimson/os: mark unused variable [[maybe_unused]]

silences the warning when building with -DNDEBUG:

segment_cleaner.h:399:10: warning: unused variable ‘ret’ [-Wunused-variable]
  399 |     auto ret = space_tracker->allocate(
      |          ^~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomgr/dashboard: fix HACKING.rst reference 38027/head
Tatjana Dehler [Wed, 11 Nov 2020 14:52:50 +0000 (15:52 +0100)]
mgr/dashboard: fix HACKING.rst reference

Update the documentation reference as the content
of the HACKING.rst file has been moved to the Ceph
developer documentation.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #37916 from orozery/librbd-crypto-wait-for-copyup
Jason Dillaman [Wed, 11 Nov 2020 14:53:29 +0000 (09:53 -0500)]
Merge pull request #37916 from orozery/librbd-crypto-wait-for-copyup

librbd: wait for copyup in unaligned crypto write

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38017 from YanfeiXu/yann-dev
Kefu Chai [Wed, 11 Nov 2020 11:57:08 +0000 (19:57 +0800)]
Merge pull request #38017 from YanfeiXu/yann-dev

cmake: add support for python3.9

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoCOPYING: note cmake/modules/FindPython* license and copyright 38018/head
Kefu Chai [Wed, 11 Nov 2020 03:47:40 +0000 (11:47 +0800)]
COPYING: note cmake/modules/FindPython* license and copyright

these files were copied from CMake project for better python3 support

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38021 from tchaikov/wip-mgr-liburl3
Kefu Chai [Wed, 11 Nov 2020 08:05:12 +0000 (16:05 +0800)]
Merge pull request #38021 from tchaikov/wip-mgr-liburl3

pybind/mgr: add urllib3==1.25.11 to mgr/requirements.txt

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
4 years agopybind/mgr: add urllib3==1.25.11 to mgr/requirements.txt 38021/head
Kefu Chai [Wed, 11 Nov 2020 05:09:53 +0000 (13:09 +0800)]
pybind/mgr: add urllib3==1.25.11 to mgr/requirements.txt

in hope to address the failure of

ERROR: Cannot install -r requirements.txt (line 3) and kubernetes because these package versions have conflicting dependencies.

The conflict is caused by:
    kubernetes 12.0.0 depends on urllib3>=1.24.2
    requests 2.24.0 depends on urllib3!=1.25.0, !=1.25.1, <1.26 and >=1.21.1

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: add support for python3.9 38017/head
Yanfei Xu [Tue, 10 Nov 2020 09:17:30 +0000 (17:17 +0800)]
cmake: add support for python3.9

add support for python3.9.

Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>