]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Jan Fajerski [Tue, 17 Nov 2020 11:41:47 +0000 (12:41 +0100)]
github: add ceph-volume autolabel
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
Kefu Chai [Tue, 17 Nov 2020 02:52:43 +0000 (10:52 +0800)]
Merge pull request #38119 from neha-ojha/wip-core-labels
github/labeler.yml: add bluestore, cephadm labels and more core rules
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 17 Nov 2020 02:48:59 +0000 (10:48 +0800)]
Merge pull request #38096 from tchaikov/wip-cmake-boost-1.74
cmake: add 1.74 to known versions
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Tue, 17 Nov 2020 02:47:45 +0000 (10:47 +0800)]
Merge pull request #38097 from tchaikov/wip-clang-cleanup
message,log: mark final classes "final", fix clang related warnings
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Kefu Chai [Tue, 17 Nov 2020 02:47:07 +0000 (10:47 +0800)]
Merge pull request #38099 from tchaikov/wip-mgr-python3.9
mgr/PyModuleRegistry: do not call PyEval_InitThreads() on python3.9
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Michael Fritch [Tue, 17 Nov 2020 02:32:43 +0000 (19:32 -0700)]
Merge pull request #38052 from mgfritch/cephadm-validate-ssh-config
mgr/cephadm: validate user provided ssh_config
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Michael Fritch [Tue, 17 Nov 2020 02:31:22 +0000 (19:31 -0700)]
Merge pull request #38053 from mgfritch/cephadm-placement-err
mgr/cephadm: show failure cause during placement
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Michael Fritch [Tue, 17 Nov 2020 02:21:06 +0000 (19:21 -0700)]
Merge pull request #37901 from votdev/issue_48041_device_light
mgr/cephadm: Allow customizing mgr/cephadm/lsmcli_blink_lights_cmd per host
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Neha Ojha [Tue, 17 Nov 2020 01:23:19 +0000 (01:23 +0000)]
.github/labeler.yml: add cephadm
Signed-off-by: Neha Ojha <nojha@redhat.com>
Neha Ojha [Tue, 17 Nov 2020 01:19:13 +0000 (01:19 +0000)]
.github/labeler.yml: add bluestore and more core rules
more to come
Signed-off-by: Neha Ojha <nojha@redhat.com>
Jason Dillaman [Mon, 16 Nov 2020 22:10:17 +0000 (17:10 -0500)]
Merge pull request #37939 from trociny/wip-rbd-nbd-wait-for-terminate
rbd-nbd: fixes and improvements for unmap/detach wait for process terminate
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Jason Dillaman [Mon, 16 Nov 2020 22:09:25 +0000 (17:09 -0500)]
Merge pull request #38081 from wjwithagen/wjw-fix-test_mock_CryptoObjectDispatch.cc
test/librbd/crypto: Fixup include order to prevent implicit definitions
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Casey Bodley [Mon, 16 Nov 2020 14:53:08 +0000 (09:53 -0500)]
Merge pull request #38105 from ofriedma/wip-barbican-qa-issue
qa/rgw: fix "cannot create secret" on barbican test
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Mon, 16 Nov 2020 13:22:03 +0000 (21:22 +0800)]
Merge pull request #38072 from tchaikov/wip-github-labeler-crimson
github/labeler: add "crimson" to labeler.yml
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Kefu Chai [Mon, 16 Nov 2020 11:04:16 +0000 (19:04 +0800)]
Merge pull request #38041 from tchaikov/wip-mon-trim-osdmap
mon/OSDMonitor: remove osd_epochs if osd is marked in or out
Reviewed-by: Joao Eduardo Luis <joao@suse.com>
Kefu Chai [Mon, 16 Nov 2020 10:30:53 +0000 (18:30 +0800)]
Merge pull request #38103 from ybwang0211/link-to-balancer
doc: Fix the broken link to the "balancer"
Reviewed-by: Kefu Chai <kchai@redhat.com>
Or Friedmann [Sun, 15 Nov 2020 16:43:47 +0000 (18:43 +0200)]
qa/rgw: fix "cannot create secret" on barbican test
fix "cannot create secret" on barbican test
Signed-off-by: Or Friedmann <ofriedma@redhat.com>
Fixes: https://tracker.ceph.com/issues/47799
Kefu Chai [Mon, 16 Nov 2020 07:21:19 +0000 (15:21 +0800)]
log/Log: cast typed pointer to integer before printing it
libfmt does not print pointer if it's not "void*", but "thread_t" is
defined as a pointer pointing to "struct pthread" on FreeBSD, so we need
to cast it either to "void*" or an integer". let's cast it to an integer
so it's more consistent with the output on Linux where thread_t is
defined as an integer.
this change addresses the FTBFS on FreeBSD likee:
In file included from /home/jenkins/workspace/ceph-master-compile/src/log/Log.cc:27:
In file included from /usr/local/include/fmt/format.h:44:
/usr/local/include/fmt/core.h:1043:20: error: invalid application of 'sizeof' to an incomplete type 'pthread'
static_assert(!sizeof(T), "formatting of non-void pointers is disallowed");
^~~~~~~~~
/usr/local/include/fmt/core.h:1259:32: note: in instantiation of function template specialization
'fmt::v7::detail::arg_mapper<fmt::v7::basic_format_context<std::__1::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::map<pthread>' requested here
return arg_mapper<Context>().map(val);
^
/usr/local/include/fmt/core.h:1408:23: note: in instantiation of function template specialization 'fmt::v7::detail::make_arg<true,
fmt::v7::basic_format_context<std::__1::back_insert_iterator<fmt::v7::detail::buffer<char> >, char>, fmt::v7::detail::type::int_type, pthread *, 0>' requested here
data_{detail::make_arg<
^
/usr/local/include/fmt/core.h:1764:10: note: in instantiation of member function 'fmt::v7::format_arg_store<fmt::v7::basic_format_context<std::__1::back_insert_iterator<fmt::v7::detail::buffer<char>
>, char>, pthread *const, char *>::format_arg_store' requested here
return {args...};
^
/usr/local/include/fmt/core.h:1835:31: note: in instantiation of function template specialization 'fmt::v7::detail::make_args_checked<pthread *const &, char *, char [10], char>' requested here
const auto& vargs = detail::make_args_checked<Args...>(format_str, args...);
^
/home/jenkins/workspace/ceph-master-compile/src/log/Log.cc:376:23: note: in instantiation of function template specialization 'fmt::v7::format<char [10], pthread *const &, char *, char>' requested
here
_log_message(fmt::format(" {} / {}", pthread_id, (char*)pthread_name), true);
^
/usr/include/sys/_pthreadtypes.h:46:8: note: forward declaration of 'pthread'
struct pthread;
^
1 error generated.
Signed-off-by: Kefu Chai <kchai@redhat.com>
ybwang0211 [Mon, 16 Nov 2020 08:59:24 +0000 (16:59 +0800)]
doc:Fix the web link that jumps to the "balancer"
In "https://docs.ceph.com/en/latest/rados/operations/upmap/#upmap", the link to "balancer" was not set correctly, so we fixed it.
Signed-off-by: wangyingbin <wangyingbin@inspur.com>
Kefu Chai [Mon, 16 Nov 2020 07:33:42 +0000 (15:33 +0800)]
mgr/PyModuleRegistry: do not call PyEval_InitThreads() on python3.9
PyEval_InitThreads() and PyEval_ThreadsInitialized() are deprecated
since python3.9, and GIL is initialized by Py_Initialize() in python3.9.
so do not call them unless we are using python < 3.9.
see https://docs.python.org/3/c-api/init.html#c.PyEval_InitThreads
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 16 Nov 2020 07:18:33 +0000 (15:18 +0800)]
log/Log: cast parameter of syslog() from unsigned to int
silences warning like:
../src/log/Log.cc:325:34: warning: field precision should have type 'int', but argument has type 'std::basic_string_view::size_type' (aka 'unsigned long') [-Wformat]
syslog(LOG_USER|LOG_INFO, "%.*s", s.size(), s.data());
~~^~ ~~~~~~~~
1 warning generated.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 16 Nov 2020 06:58:22 +0000 (14:58 +0800)]
message: mark message classes "final"
silences warnings like:
src/messages/MOSDPGUpdateLogMissingReply.h:74:34: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
~MOSDPGUpdateLogMissingReply() final {}
^
../src/messages/MOSDPGUpdateLogMissingReply.h:21:7: note: mark 'MOSDPGUpdateLogMissingReply' as 'final' to silence this warning
class MOSDPGUpdateLogMissingReply : public MOSDFastDispatchOp {
^
1 warning generated.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 16 Nov 2020 06:06:40 +0000 (14:06 +0800)]
cmake: add 1.74 to known versions
sync with
https://github.com/Kitware/CMake/blob/
685fa8bec064e5776319c8a42c02578bd85b6a7d /Modules/FindBoost.cmake
for boost 1.74 support
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 16 Nov 2020 06:04:15 +0000 (14:04 +0800)]
cmake: enable CMP0074
to search prefixes specified by the <PackageName>_ROOT CMake
variable and the <PackageName>_ROOT environment variable. find_package()
in CMake 3.12 started to use these prefixes if it is enabled.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Sridhar Seshasayee [Mon, 16 Nov 2020 07:26:09 +0000 (12:56 +0530)]
Merge pull request #38007 from sseshasa/wip-qa-rados-perf-scheduler
qa/suite/rados: Introduce "scheduler" directory within rados perf suite.
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Patrick Donnelly [Sun, 15 Nov 2020 20:39:11 +0000 (12:39 -0800)]
Merge PR #34842 into master
* refs/pull/34842/head:
qa/tasks/vstart_runner.py: disable the ns unsharing if using localhost
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Sun, 15 Nov 2020 20:38:05 +0000 (12:38 -0800)]
Merge PR #37746 into master
* refs/pull/37746/head:
client: add a dedicated thread for the Client tick
client: try to renew caps and flush old cap releases
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Sun, 15 Nov 2020 20:37:02 +0000 (12:37 -0800)]
Merge PR #37982 into master
* refs/pull/37982/head:
qa/cephfs: add code for when config is None in __init__
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Patrick Donnelly [Sun, 15 Nov 2020 20:35:58 +0000 (12:35 -0800)]
Merge PR #38016 into master
* refs/pull/38016/head:
qa: switch to 'osdop_read' instead of 'op_r'
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Sun, 15 Nov 2020 20:34:00 +0000 (12:34 -0800)]
Merge PR #38056 into master
* refs/pull/38056/head:
pybind/mgr/volumes: use = for equality comparision
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Brad Hubbard [Sun, 15 Nov 2020 20:19:09 +0000 (06:19 +1000)]
Merge pull request #38077 from tchaikov/wip-doc-scrub-max
doc/rados/operation: add link to scrub_max_interval
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sun, 15 Nov 2020 17:29:46 +0000 (01:29 +0800)]
Merge pull request #38038 from bk201/wip-48209
mgr/dashboard: fix cephadm e2e test failure on deleting OSDs
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Kefu Chai [Sun, 15 Nov 2020 17:00:56 +0000 (01:00 +0800)]
Merge pull request #37908 from dzafman/wip-47930
test: Fix race in TEST_recovery_scrub test
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Sun, 15 Nov 2020 16:38:35 +0000 (00:38 +0800)]
Merge pull request #38043 from jhonxue/wip-fix-bluestore-bitmap-allocator
osd: fix bluestore bitmap allocator calculate wrong last_pos with hint
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Kefu Chai [Sun, 15 Nov 2020 16:37:51 +0000 (00:37 +0800)]
Merge pull request #37963 from aclamk/wip-bluestore-no-debug-misc
os/bluestore: Removed bluestore_debug_misc option
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Kefu Chai [Sun, 15 Nov 2020 16:34:12 +0000 (00:34 +0800)]
Merge pull request #37999 from trociny/wip-48153
os/bluestore: fix "end reached" check in collection_list_legacy
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Sun, 15 Nov 2020 16:32:22 +0000 (00:32 +0800)]
Merge pull request #37630 from zjcmszh/aio_rmxattr
pybind/rados: add Ioctx::aio_rmxattr() and test aio_rmxattr()
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sun, 15 Nov 2020 16:31:21 +0000 (00:31 +0800)]
Merge pull request #37976 from batrick/msg-destructor
messages: use final specifier for destructor
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sun, 15 Nov 2020 16:30:42 +0000 (00:30 +0800)]
Merge pull request #37992 from rishabh-d-dave/dashboard-qa-skipTest
qa/mgr: mgr_test_case: raise SkipTest instead of calling skipTest()
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Kefu Chai [Sun, 15 Nov 2020 16:18:17 +0000 (00:18 +0800)]
Merge pull request #37998 from tchaikov/wip-log-mon-cleanup
log,mon: use libfmt to format string and use range-based loop
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Kefu Chai [Sun, 15 Nov 2020 16:09:15 +0000 (00:09 +0800)]
Merge pull request #38026 from wjwithagen/wjw-fix-test-mon-build_initial
test/mon: FreeBSD returns ENOENT on resolv error
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Willem Jan Withagen [Wed, 11 Nov 2020 14:09:12 +0000 (15:09 +0100)]
test/mon: Accept ENOENT as returned value on FreeBSD
FreeBSD returns ENOENT on resolv error
Tracker: https://tracker.ceph.com/issues/48183
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
Kefu Chai [Sat, 14 Nov 2020 06:59:04 +0000 (14:59 +0800)]
doc/rados/operation: add link to scrub_max_interval
add the reference to the per-pool setting when explaing
PG_NOT_DEEP_SCRUBBED.
Signed-off-by: Kefu Chai <kchai@redhat.com>
J. Eric Ivancich [Sun, 15 Nov 2020 03:35:23 +0000 (22:35 -0500)]
Merge pull request #38082 from adamemerson/wip-anti-nihilism
Asyncening 0: The Yielding Anti-Nihilist
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Patrick Donnelly [Sat, 14 Nov 2020 18:04:12 +0000 (10:04 -0800)]
Merge PR #38071 into master
* refs/pull/38071/head:
.github: add labeler for cephfs
Reviewed-by: Kefu Chai <kchai@redhat.com>
Willem Jan Withagen [Sat, 14 Nov 2020 17:11:05 +0000 (18:11 +0100)]
test/librbd/crypto: Fixup include order to prevent implicit definitions
Clang complains a lot, part of it:
```
/home/jenkins/workspace/ceph-master-compile/src/test/librbd/crypto/test_mock_CryptoObjectDispatch.cc:35:8: error: explicit specialization of 'librbd::io::CopyupRequest<librbd::MockImageCtx>' after instantiation
struct CopyupRequest<librbd::MockImageCtx> {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jenkins/workspace/ceph-master-compile/src/librbd/io/ObjectRequest.cc:560:10: note: implicit instantiation first required here
if (it == image_ctx->copyup_list.end()) {
^
/home/jenkins/workspace/ceph-master-compile/src/test/librbd/crypto/test_mock_CryptoObjectDispatch.cc:54:32: error: template specialization requires 'template<>'
librbd::MockImageCtx>::s_instance = nullptr;
```
fixes: https://github.com/ceph/ceph/pull/37916
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
Kefu Chai [Sat, 14 Nov 2020 16:53:38 +0000 (00:53 +0800)]
Merge pull request #38067 from dillaman/wip-github-rbd-label
github: add 'rbd' auto-labelling
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 14 Nov 2020 11:56:40 +0000 (19:56 +0800)]
Merge pull request #38013 from drakonstein/master
rpm,deb: change sudoers file mode to 440
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Brad Hubbard [Sat, 14 Nov 2020 04:49:27 +0000 (14:49 +1000)]
Merge pull request #38073 from badone/wip-use-right-tunable-for-pg-scrub-doc
doc: Use correct tunable for PG_NOT_SCRUBBED
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 14 Nov 2020 02:43:20 +0000 (10:43 +0800)]
github/labeler: add more rules to labeler.yml
mainly for the maintainers from the RADOS team.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Michael Fritch [Sat, 14 Nov 2020 02:27:59 +0000 (19:27 -0700)]
Merge pull request #37883 from diwilli/patch-1
cephadm: Set listen-addresses on alertmanager container
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Michael Fritch [Sat, 14 Nov 2020 02:23:34 +0000 (19:23 -0700)]
Merge pull request #38011 from mgfritch/cephadm-sudo-log-dir
cephadm: verify root privileges before log dir create
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Kefu Chai [Sat, 14 Nov 2020 02:14:56 +0000 (10:14 +0800)]
github/labeler: add "crimson" to labeler.yml
so crimson related changes can be labeled by the labler action.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Fri, 13 Nov 2020 23:07:12 +0000 (15:07 -0800)]
.github: add labeler for cephfs
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Jason Dillaman [Fri, 13 Nov 2020 19:43:21 +0000 (14:43 -0500)]
github: add 'rbd' auto-labelling
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Adam C. Emerson [Wed, 11 Nov 2020 22:12:08 +0000 (17:12 -0500)]
rgw: No null_yield in rgw_rest
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Wed, 11 Nov 2020 20:55:41 +0000 (15:55 -0500)]
rgw: No null_yield in rgw_role
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Wed, 11 Nov 2020 19:06:07 +0000 (14:06 -0500)]
rgw: no null_yield in rgw_tools
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Wed, 11 Nov 2020 17:13:50 +0000 (12:13 -0500)]
rgw: No null_yield in rgw_torrent
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Wed, 11 Nov 2020 16:25:38 +0000 (11:25 -0500)]
rgw: No null_yield in rgw_user
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Wed, 11 Nov 2020 14:36:23 +0000 (09:36 -0500)]
rgw: No null_yield in rgw_zone
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Wed, 11 Nov 2020 06:03:12 +0000 (01:03 -0500)]
rgw: No null_yield in RGWOp
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam C. Emerson [Wed, 11 Nov 2020 00:33:35 +0000 (19:33 -0500)]
rgw/services: No null_yield
Null yield is fine at top levels where we know what kind of thread
we're running into, but do not belong in general use functions.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Neha Ojha [Fri, 13 Nov 2020 17:42:20 +0000 (09:42 -0800)]
Merge pull request #38057 from zdover23/wip-doc-dev-guide-essentials-source-clean-update
doc/dev: update essentials.rst
Reviewed-by: Neha Ojha <nojha@redhat.com>
Neha Ojha [Fri, 13 Nov 2020 17:38:28 +0000 (09:38 -0800)]
Merge pull request #38036 from zdover23/wip-doc-dev-guide-basic-workflow-make-check-nov-2020
doc/dev: improve make check text
Reviewed-by: Neha Ojha <nojha@redhat.com>
Mykola Golub [Fri, 13 Nov 2020 14:47:46 +0000 (16:47 +0200)]
Merge pull request #37977 from dillaman/wip-48145
librbd: update hidden global config when removing pool config override
Reviewed-by: Mykola Golub <mgolub@suse.com>
Daniel Gryniewicz [Fri, 13 Nov 2020 14:02:04 +0000 (09:02 -0500)]
Merge pull request #37975 from dang/wip-dang-webdir-empty-object
RGW - Don't create empty obj in webdir
Kefu Chai [Fri, 13 Nov 2020 12:07:42 +0000 (20:07 +0800)]
Merge pull request #38060 from rhcs-dashboard/wip-master-auto_labels
github: fix autolabel paths
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Ernesto Puerta [Fri, 13 Nov 2020 10:19:33 +0000 (11:19 +0100)]
github: fix autolabel paths
Remove starting / from paths and add missing doc path from dashboard.
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Kefu Chai [Fri, 13 Nov 2020 08:58:48 +0000 (16:58 +0800)]
Merge pull request #38055 from tchaikov/wip-doc-conf
doc/rados/configuration: document option types
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Zac Dover [Fri, 13 Nov 2020 07:37:58 +0000 (17:37 +1000)]
doc/dev: update essentials.rst
This commit changes the noun "backup" to the
intended verb "back up" (this is one of my
technical documentation pet peeves and I couldn't
resist), and it also removes the verb "to nuke"
and replaces it with something less poetic but
more likely to be discoverable in a dictionary by
someone whose English is weak. It also adds a
missing colon.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Kefu Chai [Fri, 13 Nov 2020 05:33:03 +0000 (13:33 +0800)]
pybind/mgr/volumes: use = for equality comparision
should not rely on the internal implementation of Python to check the
equality of two strings.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 13 Nov 2020 05:32:14 +0000 (13:32 +0800)]
doc/rados/configuration: document option types
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 13 Nov 2020 04:14:00 +0000 (12:14 +0800)]
doc/rados: remove superfluous "::"
this change addresses a regression introduced by
0f2489406a8d4194c159c8777517d20b54e216b5
Signed-off-by: Kefu Chai <kchai@redhat.com>
Brad Hubbard [Fri, 13 Nov 2020 04:33:24 +0000 (14:33 +1000)]
doc: Use correct tunable for PG_NOT_SCRUBBED
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
Zac Dover [Thu, 12 Nov 2020 09:33:16 +0000 (19:33 +1000)]
doc/dev: improve make check text
This commit fixes the references to the
"make check" section in the "notes on
pr make check test" section and improves
the wording of that section so that it
reads a bit more clearly.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Kefu Chai [Fri, 13 Nov 2020 03:35:37 +0000 (11:35 +0800)]
Merge pull request #38049 from rhcs-dashboard/wip-master-auto_labels
github: autolabel PRs
Reviewed-by: Kefu Chai <kchai@redhat.com>
Josh Durgin [Fri, 13 Nov 2020 01:25:43 +0000 (17:25 -0800)]
Merge pull request #38023 from zdover23/wip-doc-dev-guide-essentials-nov-2020
doc/dev: update essentials.rst nov 2020
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Michael Fritch [Thu, 12 Nov 2020 22:09:42 +0000 (15:09 -0700)]
mgr/cephadm: show failure cause during placement
the host and exception cause are not shown in the event log when a
daemon placement failure occurs
Signed-off-by: Michael Fritch <mfritch@suse.com>
Michael Fritch [Thu, 12 Nov 2020 23:21:40 +0000 (16:21 -0700)]
mgr/cephadm: validate user provided ssh_config
ensure the user provided ssh_config contains a valid
`StrictHostKeyChecking` setting
Fixes: https://tracker.ceph.com/issues/48158
Signed-off-by: Michael Fritch <mfritch@suse.com>
Zac Dover [Thu, 5 Nov 2020 23:22:03 +0000 (09:22 +1000)]
doc/dev: update essentials.rst
This commit improves the grammar and structure
of essentials.rst.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Neha Ojha [Thu, 12 Nov 2020 23:02:52 +0000 (15:02 -0800)]
Merge pull request #37902 from pdvian/wip-clog-health-detail
mon: Log "ceph health detail" periodically in cluster log
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Daniel Gryniewicz [Thu, 5 Nov 2020 19:02:04 +0000 (14:02 -0500)]
RGW - Don't create empty obj in webdir
Zipper objects shouldn't be empty, but should instead be null. Fix this
case where parsing wasn't checking for empty object name, and the
website code that uses it.
Fixes: https://tracker.ceph.com/issues/48049
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Ernesto Puerta [Thu, 12 Nov 2020 17:07:44 +0000 (18:07 +0100)]
github: autolabel PRs
... starting with dashboard ones.
Requires https://github.com/marketplace/actions/labeler
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
jhonxue [Thu, 12 Nov 2020 15:17:13 +0000 (23:17 +0800)]
osd: fix bluestore bitmap allocator calculated wrong last_pos with hint
Fixes: https://tracker.ceph.com/issues/48214
Signed-off-by: Xue Yantao <jhonxue@tencent.com>
Kefu Chai [Thu, 12 Nov 2020 13:49:06 +0000 (21:49 +0800)]
mon/OSDMonitor: remove osd_epochs if osd is marked in or out
this is a cleanup. if we don't take the osd_epochs of osd marked out,
there is no need to keep those osd_epochs around anymore. so, in this
change, once the osd is marked in or out, we just drop its osd_epochs
right away.
Signed-off-by: Kefu Chai <kchai@redhat.com>
kyr [Thu, 12 Nov 2020 13:19:47 +0000 (14:19 +0100)]
Merge pull request #38029 from kshtsk/wip-cephadm-bootstrap-remote
qa/task/cephadm: run cephadm only on bootstrap_remote
Ernesto Puerta [Thu, 12 Nov 2020 13:15:04 +0000 (14:15 +0100)]
Merge pull request #36385 from ghyer/ghyer-dashboard
mgr/dashboard: Add 'Dirs' and 'Caps' for filesystems details
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Ernesto Puerta [Thu, 12 Nov 2020 13:11:06 +0000 (14:11 +0100)]
Merge pull request #38027 from s0nea/wip-dashboard-fix-doc-link
mgr/dashboard: fix HACKING.rst reference
Reviewed-by: aaSharma14 <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Ernesto Puerta [Thu, 12 Nov 2020 13:06:15 +0000 (14:06 +0100)]
Merge pull request #37993 from votdev/issue_48051_ngx_pipe_function
mgr/dashboard: Use pipe instead of calling function within template
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Matt Benjamin [Thu, 12 Nov 2020 12:58:27 +0000 (07:58 -0500)]
Merge pull request #37770 from pritha-srivastava/wip-sts-47871
rgw/sts: fix for validating path in role arn in assume role api.
Volker Theile [Mon, 9 Nov 2020 13:51:53 +0000 (14:51 +0100)]
mgr/dashboard: Use pipe instead of calling function within template
This PR introduces the 'ngx-pipe-function' package to call functions in templates.
Fixes: https://tracker.ceph.com/issues/48051
Signed-off-by: Volker Theile <vtheile@suse.com>
Ernesto Puerta [Thu, 12 Nov 2020 10:42:45 +0000 (11:42 +0100)]
Merge pull request #37918 from dungdm93/avoiding-relative-paths
mgr/dashboards: avoiding relative paths '../../..'
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: nizamial09 <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Kiefer Chang [Thu, 12 Nov 2020 09:20:48 +0000 (17:20 +0800)]
mgr/dashboard: fix cephadm e2e test failure on deleting OSDs
- Adapt the OSD ID column change in this PR:
https://github.com/ceph/ceph/pull/37506
- Turn off Cypress retries because it makes the failure log misleading.
Fixes: https://tracker.ceph.com/issues/48209
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
David Turner [Tue, 10 Nov 2020 19:31:35 +0000 (14:31 -0500)]
rpm,deb: change sudoers file mode to 440
change sudoers file mode to 440 to match recommended defaults.
From the sudoers man page.
> the default file mode is 0440 (read‐able by owner and group, writable
by none).
> The default mode may be changed via the “sudoers_mode” option to the
sudoers
> Plugin line in the sudo.conf(5) file.
Fixes: https://tracker.ceph.com/issues/48169
Signed-off-by: David Turner <drakonstein@gmail.com>
Kefu Chai [Thu, 12 Nov 2020 02:40:24 +0000 (10:40 +0800)]
Merge pull request #37922 from mgfritch/project-kubic
cephadm: install podman from the Kubic project
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 12 Nov 2020 01:54:54 +0000 (09:54 +0800)]
Merge pull request #38018 from tchaikov/wip-cmake-python
COPYING: note cmake/modules/FindPython* license and copyright
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Thu, 12 Nov 2020 01:53:47 +0000 (09:53 +0800)]
Merge pull request #38028 from tchaikov/wip-crimson-maybe-unused
crimson/os: mark unused variable [[maybe_unused]]
Reviewed-by: Samuel Just <sjust@redhat.com>
Kefu Chai [Thu, 12 Nov 2020 01:52:33 +0000 (09:52 +0800)]
Merge pull request #35865 from tchaikov/wip-crimson-recovery-qa
qa/suites: add crimson-rados suite
Reviewed-by: Samuel Just <sjust@redhat.com>
Xiubo Li [Mon, 2 Nov 2020 04:23:15 +0000 (23:23 -0500)]
client: add a dedicated thread for the Client tick
The Client::timer will remain to be use by others like the Delegation.
Fixes: https://tracker.ceph.com/issues/47842
Signed-off-by: Xiubo Li <xiubli@redhat.com>