]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agogithub/labeler: add rbd label to pybind/mgr/rbd_support 38197/head
Jason Dillaman [Thu, 19 Nov 2020 21:13:28 +0000 (16:13 -0500)]
github/labeler: add rbd label to pybind/mgr/rbd_support

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37914 from IlsooByun/rgw_invalid_resp
Casey Bodley [Thu, 19 Nov 2020 15:23:22 +0000 (10:23 -0500)]
Merge pull request #37914 from IlsooByun/rgw_invalid_resp

rgw: fix invalid payload issue when serving s3website error page

Reviewed-by: Or Friedmann <ofriedma@redhat.com>
4 years agoMerge pull request #38182 from orozery/librbd-crypto-image-dispatch-fixes
Jason Dillaman [Thu, 19 Nov 2020 15:01:17 +0000 (10:01 -0500)]
Merge pull request #38182 from orozery/librbd-crypto-image-dispatch-fixes

librbd: fix crypto prepare_copyup to use new remap_extents api

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38158 from rhcs-dashboard/fix-labeler-master
Ernesto Puerta [Thu, 19 Nov 2020 11:33:09 +0000 (12:33 +0100)]
Merge pull request #38158 from rhcs-dashboard/fix-labeler-master

github/labeler: disable sync-labels

Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: neha-ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38146 from ljishen/peering_state_model
Kefu Chai [Thu, 19 Nov 2020 08:09:14 +0000 (16:09 +0800)]
Merge pull request #38146 from ljishen/peering_state_model

doc: increase visibility of the peering state diagram

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agolibrbd: fix crypto prepare_copyup to use new remap_extents api 38182/head
Or Ozeri [Thu, 19 Nov 2020 06:26:51 +0000 (08:26 +0200)]
librbd: fix crypto prepare_copyup to use new remap_extents api

This commit changes the crypto prepare_copyup implementation to correctly
translate object extents to image extents, via the remap_extents api.
Additionally, we fix relevant unit tests that call this api to correctly expect these calls.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
4 years agodoc: increase visibility of the peering state diagram 38146/head
Jianshen Liu [Wed, 18 Nov 2020 04:44:30 +0000 (21:44 -0700)]
doc: increase visibility of the peering state diagram

Signed-off-by: Jianshen Liu <jliu120@ucsc.edu>
4 years agoMerge pull request #38001 from badone/wip-powertools-repo-name-change
Kefu Chai [Thu, 19 Nov 2020 04:12:08 +0000 (12:12 +0800)]
Merge pull request #38001 from badone/wip-powertools-repo-name-change

install-deps.sh: Make powertools repo case insensitive

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38172 from zdover23/wip-doc-dev-unit-test-list-update 38176/head
Neha Ojha [Wed, 18 Nov 2020 23:50:01 +0000 (15:50 -0800)]
Merge pull request #38172 from zdover23/wip-doc-dev-unit-test-list-update

doc/dev: update list in unit test section

Reviewed-By: Nathan Cutler <ncutler@suse.com>
4 years agoMerge pull request #38114 from orozery/librbd-crypto-prepare-copyup
Jason Dillaman [Wed, 18 Nov 2020 22:55:16 +0000 (17:55 -0500)]
Merge pull request #38114 from orozery/librbd-crypto-prepare-copyup

librbd: add encryption support for copyup

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37935 from orozery/librbd-image-address-remap
Jason Dillaman [Wed, 18 Nov 2020 22:55:00 +0000 (17:55 -0500)]
Merge pull request #37935 from orozery/librbd-image-address-remap

librbd: add crypto image dispatch layer

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38133 from zdover23/wip-doc-dev-unit-tests-1-of-7
Neha Ojha [Wed, 18 Nov 2020 20:19:42 +0000 (12:19 -0800)]
Merge pull request #38133 from zdover23/wip-doc-dev-unit-tests-1-of-7

doc/dev: update unit test 1 of 7

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #38134 from zdover23/wip-doc-dev-unit-tests-2-of-7
Neha Ojha [Wed, 18 Nov 2020 20:18:55 +0000 (12:18 -0800)]
Merge pull request #38134 from zdover23/wip-doc-dev-unit-tests-2-of-7

doc/dev: update unit tests 2 of 7

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge PR #38126 into master
Patrick Donnelly [Wed, 18 Nov 2020 20:15:22 +0000 (12:15 -0800)]
Merge PR #38126 into master

* refs/pull/38126/head:
doc/cephfs/health-messages: add dot between mds identifier and it's name

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #38174 from neha-ojha/wip-fix-label
Neha Ojha [Wed, 18 Nov 2020 20:12:00 +0000 (12:12 -0800)]
Merge pull request #38174 from neha-ojha/wip-fix-label

.github/labeler.yml: fix bluestore rule, add label for tests and classify core tests

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #37607 from pcuzner/docs-cephadm-host-maintenance
pcuzner [Wed, 18 Nov 2020 20:03:19 +0000 (09:03 +1300)]
Merge pull request #37607 from pcuzner/docs-cephadm-host-maintenance

doc/dev/cephadm: Doc defining the design for host maintenance

4 years agolibrbd: add encryption support for copyup 38114/head
Or Ozeri [Mon, 2 Nov 2020 13:20:18 +0000 (15:20 +0200)]
librbd: add encryption support for copyup

This commit implements the prepare_copyup api by the crypto object dispatch layer.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
4 years ago.github/labeler.yml: add label for tests and classify core tests 38174/head
Neha Ojha [Wed, 18 Nov 2020 18:39:42 +0000 (18:39 +0000)]
.github/labeler.yml: add label for tests and classify core tests

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years ago.github/labeler.yml: fix bluestore rule
Neha Ojha [Wed, 18 Nov 2020 18:32:31 +0000 (18:32 +0000)]
.github/labeler.yml: fix bluestore rule

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years agodoc/dev: update list in unit test section 38172/head
Zac Dover [Wed, 18 Nov 2020 17:35:19 +0000 (03:35 +1000)]
doc/dev: update list in unit test section

This commit removes an unwanted extra
nested list layer from a list.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #38150 from zdover23/wip-doc-dev-unit-tests-3-of-7
zdover23 [Wed, 18 Nov 2020 17:16:44 +0000 (03:16 +1000)]
Merge pull request #38150 from zdover23/wip-doc-dev-unit-tests-3-of-7

doc/dev: update unit test declaration

Reviewed-by: Nathan Cutler <ncutler@suse.com>
4 years agoMerge pull request #38054 from dzafman/wip-test-fixes
David Zafman [Wed, 18 Nov 2020 16:52:28 +0000 (08:52 -0800)]
Merge pull request #38054 from dzafman/wip-test-fixes

test: Fix osd-scrub-test.sh and ver-health.sh tests

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #38132 from ceph/rhel_8_distros
rakeshgm [Wed, 18 Nov 2020 16:09:25 +0000 (21:39 +0530)]
Merge pull request #38132 from ceph/rhel_8_distros

qa/distros: add RHEL 8.3 and use RHEL 8.3 as default

4 years agoMerge PR #34552 into master
Patrick Donnelly [Wed, 18 Nov 2020 15:54:15 +0000 (07:54 -0800)]
Merge PR #34552 into master

* refs/pull/34552/head:
tests: add snap schedule tests
snap-schedule: reject invalid retention specs
mgr/snap_schedule: log snapshot name on creation
pybind / snap_schedule: sanely dump schedules and retention specs
pybind/snap_schedule: config option to allow minute granularity snaps
pybind / snap_schedule: remove 'SNAP_SCHED_TESTING' check

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #38107 from ceph/wip-mgr-progress-fix-48217
Neha Ojha [Wed, 18 Nov 2020 15:15:22 +0000 (07:15 -0800)]
Merge pull request #38107 from ceph/wip-mgr-progress-fix-48217

qa/mgr/test_progress: add _get_osd_in_out_events to account for osd marked in/out events

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agodoc/dev: update unit test declaration 38150/head
Zac Dover [Wed, 18 Nov 2020 08:56:14 +0000 (18:56 +1000)]
doc/dev: update unit test declaration

This commit updates the text in the "How
Unit Tests Are Declared" section of
tests-unit-tests.rst. This commit breaks
long sentences into shorter sentences and
breaks a sentence into a bulleted list that
might reduce the reader's cognitive load.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #38129 from jan--f/add-ceph-volume-autolabel
Kefu Chai [Wed, 18 Nov 2020 13:21:51 +0000 (21:21 +0800)]
Merge pull request #38129 from jan--f/add-ceph-volume-autolabel

github: add ceph-volume autolabel

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agogithub/labeler: disable sync-labels 38158/head
Ernesto Puerta [Wed, 18 Nov 2020 12:00:00 +0000 (13:00 +0100)]
github/labeler: disable sync-labels

Yaml syntax cleaned too.

Fixes: https://github.com/ceph/ceph/pull/38107#issuecomment-729300615
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
4 years agogithub: add ceph-volume autolabel 38129/head
Jan Fajerski [Tue, 17 Nov 2020 11:41:47 +0000 (12:41 +0100)]
github: add ceph-volume autolabel

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agoMerge pull request #37606 from ifed01/wip-ifed-fix-mempool-and-others
Kefu Chai [Wed, 18 Nov 2020 10:53:01 +0000 (18:53 +0800)]
Merge pull request #37606 from ifed01/wip-ifed-fix-mempool-and-others

os/bluestore: a bunch of minor fixes

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38152 from tchaikov/wip-crimson-clang-cleanup
Kefu Chai [Wed, 18 Nov 2020 10:48:36 +0000 (18:48 +0800)]
Merge pull request #38152 from tchaikov/wip-crimson-clang-cleanup

crimson/os: do not capture unused variables

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #38022 from tchaikov/wip-crimson-with-lock
Kefu Chai [Wed, 18 Nov 2020 10:18:35 +0000 (18:18 +0800)]
Merge pull request #38022 from tchaikov/wip-crimson-with-lock

crimson/os: use with_lock() to guard obc

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson/os: do not capture unused variables 38152/head
Kefu Chai [Wed, 18 Nov 2020 10:03:55 +0000 (18:03 +0800)]
crimson/os: do not capture unused variables

silences warnings reported by clang iike:

btree_lba_manager.cc:439:50: warning: lambda capture 't' is not used [-Wunused-lambda-capture]
        lba_node->get_node_meta().depth).safe_then([=, &t](LBANodeRef c) {
                                                     ~~~^
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd/object_context: drop unused methods 38022/head
Kefu Chai [Wed, 11 Nov 2020 13:25:55 +0000 (21:25 +0800)]
crimson/osd/object_context: drop unused methods

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: add PG::with_clone_obc()
Kefu Chai [Wed, 11 Nov 2020 10:36:22 +0000 (18:36 +0800)]
crimson/osd: add PG::with_clone_obc()

this method replaces `PG::get_or_load_clone_obc()`. so we can
with `seastar::with_lock()` to ensure that `lock.unlock()` is always
called when accessing clone obc.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: drop PG::get_or_load_head_obc()
Kefu Chai [Wed, 11 Nov 2020 11:18:54 +0000 (19:18 +0800)]
crimson/osd: drop PG::get_or_load_head_obc()

as it is not used anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: use with_head_obc() to replace get_or_load_head_obc
Kefu Chai [Wed, 11 Nov 2020 11:14:06 +0000 (19:14 +0800)]
crimson/osd: use with_head_obc() to replace get_or_load_head_obc

for better readability, and ensure that `lock.unlock()` is called when
an error is returned after the lock is acquired.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: add PG::with_head_obc()
Kefu Chai [Tue, 10 Nov 2020 13:03:02 +0000 (21:03 +0800)]
crimson/osd: add PG::with_head_obc()

this method replicates `PG::get_or_load_head_obc()`. but uses a different
way to ensure that the "lock" on obc is always released even if the
called func throws. it always guard the called func with a
`with_lock()`, so `lock.unlock()` is always called. the plan is to
replace `PG::get_or_load_head_obc()` with `PG::with_head_obc()` in
the following changes piecemeal.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: pass RWState using template parameter
Kefu Chai [Wed, 11 Nov 2020 05:38:22 +0000 (13:38 +0800)]
crimson/osd: pass RWState using template parameter

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: mark PG::get_locked_obc() private
Kefu Chai [Fri, 6 Nov 2020 03:15:15 +0000 (11:15 +0800)]
crimson/osd: mark PG::get_locked_obc() private

this methods is used by PG::with_locked_obc(). so mark it private.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: move PG::with_locked_obc() into .cc
Kefu Chai [Wed, 4 Nov 2020 03:40:18 +0000 (11:40 +0800)]
crimson/osd: move PG::with_locked_obc() into .cc

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38151 from tchaikov/wip-seastar-api-v6
Kefu Chai [Wed, 18 Nov 2020 09:35:43 +0000 (17:35 +0800)]
Merge pull request #38151 from tchaikov/wip-seastar-api-v6

crimson/common: correct template parameter of seastar::future<>

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson/common: correct template parameter of seastar::future<> 38151/head
Kefu Chai [Wed, 18 Nov 2020 09:19:48 +0000 (17:19 +0800)]
crimson/common: correct template parameter of seastar::future<>

it's a leftover of 688b95798bfd88b409abce9b70bb6d2933819bef

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37742 from rhcs-dashboard/update-QoS-fields
Ernesto Puerta [Wed, 18 Nov 2020 09:28:16 +0000 (10:28 +0100)]
Merge pull request #37742 from rhcs-dashboard/update-QoS-fields

mgr/dashboard: update QoS values when editing a Pool/RBD image

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoMerge pull request #35039 from bk201/wip-45301
Ernesto Puerta [Wed, 18 Nov 2020 09:24:09 +0000 (10:24 +0100)]
Merge pull request #35039 from bk201/wip-45301

mgr/dashboard: displaying deleting status in the OSD list

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
4 years agoos/bluestore: fix lack of blob unshare if 'root' onode is not present 37606/head
Igor Fedotov [Thu, 8 Oct 2020 18:54:21 +0000 (21:54 +0300)]
os/bluestore: fix lack of blob unshare if 'root' onode is not present
in cache.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
4 years agotest/store_test: add unshare blob tests cases
Igor Fedotov [Thu, 8 Oct 2020 18:53:18 +0000 (21:53 +0300)]
test/store_test: add unshare blob tests cases

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
4 years agoos/bluestore: Buffer's flag might be lost if it's partially discarded or
Igor Fedotov [Thu, 8 Oct 2020 12:20:49 +0000 (15:20 +0300)]
os/bluestore: Buffer's flag might be lost if it's partially discarded or
split.

Haven't seen any real issues due to this though.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
4 years agodoc/dev: update unit test 1 of 7 38133/head
Zac Dover [Tue, 17 Nov 2020 13:43:03 +0000 (23:43 +1000)]
doc/dev: update unit test 1 of 7

This commit updates the language at the beginning
of the Unit Test section of the developer guide.
The language in this edit is more grammatical than
it used to be, and should now reduce the reader's
cognitive load.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agodoc/dev: update unit tests 2 of 7 38134/head
Zac Dover [Tue, 17 Nov 2020 14:02:32 +0000 (00:02 +1000)]
doc/dev: update unit tests 2 of 7

This commit updates the "What does 'make
check' mean" section of the "Unit Tests" chapter
of the Developer Guide. It makes the wording a
bit less editorial and attempts to reduce the
reader's cognitive load.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #38102 from tchaikov/wip-mgr-boost-cleanup
Kefu Chai [Wed, 18 Nov 2020 02:02:08 +0000 (10:02 +0800)]
Merge pull request #38102 from tchaikov/wip-mgr-boost-cleanup

mgr: do not include unused headers

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #38139 from batrick/doc-label
Kefu Chai [Wed, 18 Nov 2020 02:00:28 +0000 (10:00 +0800)]
Merge pull request #38139 from batrick/doc-label

.github: add labeler for documentation

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38004 from tchaikov/wip-48058
Kefu Chai [Wed, 18 Nov 2020 01:58:47 +0000 (09:58 +0800)]
Merge pull request #38004 from tchaikov/wip-48058

qa/tasks/ceph: update_archive_setting() only if ctx.archive is valid

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agodoc/cephfs/health-messages: add dot between mds identifier and it's name 38126/head
haoyixing [Tue, 17 Nov 2020 10:38:10 +0000 (18:38 +0800)]
doc/cephfs/health-messages: add dot between mds identifier and it's name

After pr #37608, ceph health detail output message
have changed when mds has slow requests. So update
doc according to output.

Signed-off-by: haoyixing <haoyixing@kuaishou.com>
4 years agoMerge pull request #37488 from kamoltat/wip-mgr-progress-turn-off-option
Josh Durgin [Tue, 17 Nov 2020 21:37:30 +0000 (13:37 -0800)]
Merge pull request #37488 from kamoltat/wip-mgr-progress-turn-off-option

mgr/progress: progress module on/off option

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge remote-tracking branch 'wip-resurrect-authorizer-challenges'
Josh Durgin [Tue, 17 Nov 2020 20:24:07 +0000 (15:24 -0500)]
Merge remote-tracking branch 'wip-resurrect-authorizer-challenges'

Bring back CEPHX_V2 authorizer challenges

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years ago.github: add labeler for documentation 38139/head
Patrick Donnelly [Tue, 17 Nov 2020 16:24:26 +0000 (08:24 -0800)]
.github: add labeler for documentation

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #38084 from WarriorXK/disable-sso-without-python3-saml
Ernesto Puerta [Tue, 17 Nov 2020 16:05:52 +0000 (17:05 +0100)]
Merge pull request #38084 from WarriorXK/disable-sso-without-python3-saml

mgr/dashboard: Disable sso without python3-saml

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge PR #35749 into master
Patrick Donnelly [Tue, 17 Nov 2020 15:33:20 +0000 (07:33 -0800)]
Merge PR #35749 into master

* refs/pull/35749/head:
Update Release notes for multimds scrub
qa/cephfs: log-ignorelist scrub errors
qa/cephfs: Add more tests for multimds scrub
qa/cephfs: add tests for multimds scrub
qa/cephfs: update existing scrub test cases
mds: don't skip validating disk state of symlink
mds: abort/pause/resume scrubs in multiple mds
mds: track scrub status in multiple mds
mds: remove on_finish from {CInode,CDir}::scrub_info_t
Continuation: don't delete self while there are in-processing stages
mds: auth pin CInode when validating its disk state
mds: rdlock file/nest lock when accumulating stats of subtree dirfrags
mds: multiple mds scrub support
include/frag: add encode/decode functions for fragset_t
mds: remove object can't be scrubbed immediately from scrub stack
mds: prevent dirfrag scrub/fragment from running at the same time
mds: change scrub traverse from post-order to breadth-first search
mds: make both CInode and CDir as entities of scrub
mds: remove ScrubStack::scrubstack

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agotests: add snap schedule tests 34552/head
Venky Shankar [Fri, 24 Apr 2020 05:20:03 +0000 (01:20 -0400)]
tests: add snap schedule tests

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agoqa/distros: add RHEL 8.3 and use RHEL 8.3 as default 38132/head
rakeshgm [Tue, 17 Nov 2020 13:14:16 +0000 (18:44 +0530)]
qa/distros: add RHEL 8.3 and use RHEL 8.3 as default

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
4 years agomgr/dashboard: update QoS values when editing a Pool/RBD image 37742/head
Avan Thakkar [Wed, 21 Oct 2020 17:04:34 +0000 (22:34 +0530)]
mgr/dashboard: update QoS values when editing a Pool/RBD image

Fixes: https://tracker.ceph.com/issues/47900
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
4 years agoqa/mgr/test_progress: fix bug 48217 38107/head
Kamoltat [Mon, 16 Nov 2020 08:52:12 +0000 (08:52 +0000)]
qa/mgr/test_progress: fix bug 48217

Fixes a failing test case regarding osd coming back
after being marked out. The old test case wasn't accounting
for a specific event, therefore this resulted in the failure.
The fix basically accounts for a specific event of osd being
marked in/out.

Fixes: https://tracker.ceph.com/issues/48217
Signed-off-by: Kamoltat <ksirivad@redhat.com>
4 years agolibrbd: add crypto image dispatch layer 37935/head
Or Ozeri [Mon, 2 Nov 2020 14:41:53 +0000 (16:41 +0200)]
librbd: add crypto image dispatch layer

This commit adds a crypto image dispatch layer, in addition to the existing crypto object dispatch layer.
The single purpose of this layer is to translate logical image offset to "on-disk" offsets,
given a crypto header which occupies the beginning of the image data.
This calculation is done via a new remap_extents api,
which is used in to wrap existing Striper translations between object and image extents.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
4 years agosnap-schedule: reject invalid retention specs
Jan Fajerski [Thu, 29 Oct 2020 13:16:56 +0000 (14:16 +0100)]
snap-schedule: reject invalid retention specs

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agomgr/snap_schedule: log snapshot name on creation
Venky Shankar [Wed, 2 Sep 2020 04:53:14 +0000 (00:53 -0400)]
mgr/snap_schedule: log snapshot name on creation

... mostly as an aid for debugging.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agopybind / snap_schedule: sanely dump schedules and retention specs
Venky Shankar [Thu, 20 Aug 2020 09:44:17 +0000 (05:44 -0400)]
pybind / snap_schedule: sanely dump schedules and retention specs

For easiness in parsing for tests.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agopybind/snap_schedule: config option to allow minute granularity snaps
Jan Fajerski [Thu, 17 Sep 2020 06:09:03 +0000 (02:09 -0400)]
pybind/snap_schedule: config option to allow minute granularity snaps

Thsi allows setting and scheduling snapshots with minute granularity. If
the option is unset, adding these will fail and scheduling for them will
be skipped.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
4 years agopybind / snap_schedule: remove 'SNAP_SCHED_TESTING' check
Venky Shankar [Thu, 20 Aug 2020 09:42:29 +0000 (05:42 -0400)]
pybind / snap_schedule: remove 'SNAP_SCHED_TESTING' check

Next commit introduces a module option to allow minute granularity
snapshots.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agoUpdate Release notes for multimds scrub 35749/head
Yan, Zheng [Tue, 17 Nov 2020 05:10:51 +0000 (13:10 +0800)]
Update Release notes for multimds scrub

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
4 years agoMerge pull request #38119 from neha-ojha/wip-core-labels 37676/head
Kefu Chai [Tue, 17 Nov 2020 02:52:43 +0000 (10:52 +0800)]
Merge pull request #38119 from neha-ojha/wip-core-labels

github/labeler.yml: add bluestore, cephadm labels and more core rules

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38096 from tchaikov/wip-cmake-boost-1.74
Kefu Chai [Tue, 17 Nov 2020 02:48:59 +0000 (10:48 +0800)]
Merge pull request #38096 from tchaikov/wip-cmake-boost-1.74

cmake: add 1.74 to known versions

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #38097 from tchaikov/wip-clang-cleanup
Kefu Chai [Tue, 17 Nov 2020 02:47:45 +0000 (10:47 +0800)]
Merge pull request #38097 from tchaikov/wip-clang-cleanup

message,log:  mark final classes "final", fix clang related warnings

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agoMerge pull request #38099 from tchaikov/wip-mgr-python3.9
Kefu Chai [Tue, 17 Nov 2020 02:47:07 +0000 (10:47 +0800)]
Merge pull request #38099 from tchaikov/wip-mgr-python3.9

mgr/PyModuleRegistry: do not call PyEval_InitThreads() on python3.9

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #38052 from mgfritch/cephadm-validate-ssh-config
Michael Fritch [Tue, 17 Nov 2020 02:32:43 +0000 (19:32 -0700)]
Merge pull request #38052 from mgfritch/cephadm-validate-ssh-config

mgr/cephadm: validate user provided ssh_config

Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agoMerge pull request #38053 from mgfritch/cephadm-placement-err
Michael Fritch [Tue, 17 Nov 2020 02:31:22 +0000 (19:31 -0700)]
Merge pull request #38053 from mgfritch/cephadm-placement-err

mgr/cephadm: show failure cause during placement

Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agotest: Fix TEST_scrub_extended_sleep test (corrected test name) 38054/head
David Zafman [Fri, 13 Nov 2020 01:47:21 +0000 (17:47 -0800)]
test: Fix TEST_scrub_extended_sleep test (corrected test name)

Didn't really test extended sleep in original code:
Cause by: 3bfb5c2621cf9b5e602bc37724b20c18eb852aea

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agotest: Improve version checking test, to improve reliability
David Zafman [Thu, 12 Nov 2020 23:51:49 +0000 (15:51 -0800)]
test: Improve version checking test, to improve reliability

Signed-off-by: David Zafman <dzafman@redhat.com>
4 years agoMerge pull request #37901 from votdev/issue_48041_device_light
Michael Fritch [Tue, 17 Nov 2020 02:21:06 +0000 (19:21 -0700)]
Merge pull request #37901 from votdev/issue_48041_device_light

mgr/cephadm: Allow customizing mgr/cephadm/lsmcli_blink_lights_cmd per host

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years ago.github/labeler.yml: add cephadm 38119/head
Neha Ojha [Tue, 17 Nov 2020 01:23:19 +0000 (01:23 +0000)]
.github/labeler.yml: add cephadm

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years ago.github/labeler.yml: add bluestore and more core rules
Neha Ojha [Tue, 17 Nov 2020 01:19:13 +0000 (01:19 +0000)]
.github/labeler.yml: add bluestore and more core rules

more to come

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #37939 from trociny/wip-rbd-nbd-wait-for-terminate
Jason Dillaman [Mon, 16 Nov 2020 22:10:17 +0000 (17:10 -0500)]
Merge pull request #37939 from trociny/wip-rbd-nbd-wait-for-terminate

rbd-nbd: fixes and improvements for unmap/detach wait for process terminate

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38081 from wjwithagen/wjw-fix-test_mock_CryptoObjectDispatch.cc
Jason Dillaman [Mon, 16 Nov 2020 22:09:25 +0000 (17:09 -0500)]
Merge pull request #38081 from wjwithagen/wjw-fix-test_mock_CryptoObjectDispatch.cc

test/librbd/crypto: Fixup include order to prevent implicit definitions

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agorgw: fix invalid payload issue when serving s3website error page 37914/head
Ilsoo Byun [Mon, 2 Nov 2020 07:10:44 +0000 (16:10 +0900)]
rgw: fix invalid payload issue when serving s3website error page

Fixes: https://tracker.ceph.com/issues/48064
Signed-off-by: Ilsoo Byun <ilsoobyun@linecorp.com>
4 years agoMerge pull request #38105 from ofriedma/wip-barbican-qa-issue
Casey Bodley [Mon, 16 Nov 2020 14:53:08 +0000 (09:53 -0500)]
Merge pull request #38105 from ofriedma/wip-barbican-qa-issue

qa/rgw: fix "cannot create secret" on barbican test

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agomgr/dashboard: Disable sso without python3-saml 38084/head
Kevin Meijer [Sat, 14 Nov 2020 18:44:07 +0000 (19:44 +0100)]
mgr/dashboard: Disable sso without python3-saml

Removed the requirement for the python3-saml package when wanting to disable SSO for the dashboard, this is currently relevant since the official container that runs Ceph mgr does not have this package installed.
So when upgrading from an older, non-containerized version, you would be stuck using a non-functional dashboard.

This pull requests changes that and allows the ceph dashboard sso disable command without the requirement of the library so that we SSO can always be disabled again.

Fixes: https://tracker.ceph.com/issues/48237 Signed-off-by: Kevin Meijer <admin@kevinmeijer.nl>
4 years agoMerge pull request #38072 from tchaikov/wip-github-labeler-crimson
Kefu Chai [Mon, 16 Nov 2020 13:22:03 +0000 (21:22 +0800)]
Merge pull request #38072 from tchaikov/wip-github-labeler-crimson

github/labeler: add "crimson" to labeler.yml

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoMerge pull request #38041 from tchaikov/wip-mon-trim-osdmap
Kefu Chai [Mon, 16 Nov 2020 11:04:16 +0000 (19:04 +0800)]
Merge pull request #38041 from tchaikov/wip-mon-trim-osdmap

mon/OSDMonitor: remove osd_epochs if osd is marked in or out

Reviewed-by: Joao Eduardo Luis <joao@suse.com>
4 years agoMerge pull request #38103 from ybwang0211/link-to-balancer
Kefu Chai [Mon, 16 Nov 2020 10:30:53 +0000 (18:30 +0800)]
Merge pull request #38103 from ybwang0211/link-to-balancer

doc: Fix the broken link to the "balancer"

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoqa/rgw: fix "cannot create secret" on barbican test 38105/head
Or Friedmann [Sun, 15 Nov 2020 16:43:47 +0000 (18:43 +0200)]
qa/rgw: fix "cannot create secret" on barbican test

fix "cannot create secret" on barbican test

Signed-off-by: Or Friedmann <ofriedma@redhat.com>
Fixes: https://tracker.ceph.com/issues/47799
4 years agolog/Log: cast typed pointer to integer before printing it 38097/head
Kefu Chai [Mon, 16 Nov 2020 07:21:19 +0000 (15:21 +0800)]
log/Log: cast typed pointer to integer before printing it

libfmt does not print pointer if it's not "void*", but "thread_t" is
defined as a pointer pointing to "struct pthread" on FreeBSD, so we need
to cast it either to "void*" or an integer". let's cast it to an integer
so it's more consistent with the output on Linux where thread_t is
defined as an integer.

this change addresses the FTBFS on FreeBSD likee:

In file included from /home/jenkins/workspace/ceph-master-compile/src/log/Log.cc:27:
In file included from /usr/local/include/fmt/format.h:44:
/usr/local/include/fmt/core.h:1043:20: error: invalid application of 'sizeof' to an incomplete type 'pthread'
    static_assert(!sizeof(T), "formatting of non-void pointers is disallowed");
                   ^~~~~~~~~
/usr/local/include/fmt/core.h:1259:32: note: in instantiation of function template specialization
'fmt::v7::detail::arg_mapper<fmt::v7::basic_format_context<std::__1::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::map<pthread>' requested here
  return arg_mapper<Context>().map(val);
                               ^
/usr/local/include/fmt/core.h:1408:23: note: in instantiation of function template specialization 'fmt::v7::detail::make_arg<true,
fmt::v7::basic_format_context<std::__1::back_insert_iterator<fmt::v7::detail::buffer<char> >, char>, fmt::v7::detail::type::int_type, pthread *, 0>' requested here
        data_{detail::make_arg<
                      ^
/usr/local/include/fmt/core.h:1764:10: note: in instantiation of member function 'fmt::v7::format_arg_store<fmt::v7::basic_format_context<std::__1::back_insert_iterator<fmt::v7::detail::buffer<char>
>, char>, pthread *const, char *>::format_arg_store' requested here
  return {args...};
         ^
/usr/local/include/fmt/core.h:1835:31: note: in instantiation of function template specialization 'fmt::v7::detail::make_args_checked<pthread *const &, char *, char [10], char>' requested here
  const auto& vargs = detail::make_args_checked<Args...>(format_str, args...);
                              ^
/home/jenkins/workspace/ceph-master-compile/src/log/Log.cc:376:23: note: in instantiation of function template specialization 'fmt::v7::format<char [10], pthread *const &, char *, char>' requested
here
    _log_message(fmt::format("  {} / {}", pthread_id, (char*)pthread_name), true);
                      ^
/usr/include/sys/_pthreadtypes.h:46:8: note: forward declaration of 'pthread'
struct pthread;
       ^
1 error generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc:Fix the web link that jumps to the "balancer" 38103/head
ybwang0211 [Mon, 16 Nov 2020 08:59:24 +0000 (16:59 +0800)]
doc:Fix the web link that jumps to the "balancer"

In "https://docs.ceph.com/en/latest/rados/operations/upmap/#upmap", the link to "balancer" was not set correctly, so we fixed it.

Signed-off-by: wangyingbin <wangyingbin@inspur.com>
4 years agomgr: do not include unused header files 38102/head
Kefu Chai [Mon, 16 Nov 2020 08:36:35 +0000 (16:36 +0800)]
mgr: do not include unused header files

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomgr: only include necessary headers
Kefu Chai [Mon, 16 Nov 2020 08:16:38 +0000 (16:16 +0800)]
mgr: only include necessary headers

for two reasons:

* faster compilation with less source files to process
* avoid including "boost/detail/iterator.hpp", so we can
  silence the warning like:

boost/detail/iterator.hpp:13:1: note: ‘#pragma message: This header is
deprecated. Use <iterator> instead.’
   13 | BOOST_HEADER_DEPRECATED("<iterator>")
      | ^~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomgr/dashboard: display OSD operational status 35039/head
Kiefer Chang [Mon, 11 May 2020 14:04:34 +0000 (22:04 +0800)]
mgr/dashboard: display OSD operational status

Frontend: display deleting state in the OSD ID column.

Backend: add `operational_status` to OSD:
- `working`: the OSD is in normal operation.
- `deleting`: the OSD had been scheduled for deleting.
- `unmanaged`: the OSD can't be managed by the Orchestrator.

Fixes: https://tracker.ceph.com/issues/45301
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
4 years agomgr/dashboard: support custom executing template in table cells
Kiefer Chang [Wed, 28 Oct 2020 07:18:26 +0000 (15:18 +0800)]
mgr/dashboard: support custom executing template in table cells

Now we can modify the style of a table that has an executing state
by providing a custom config when declaring columns: e.g.,

```
    this.columns = [
      {
        prop: 'id',
        name: $localize`ID`,
        flexGrow: 1,
        cellTransformation: CellTemplate.executing,
        customTemplateConfig: {
          valueClass: 'a',
          executingClass: 'b'
        }
      },
```

Which makes the cell value render with class `a` and the executing state
(e.g. (updating)) render with class `b`.

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
4 years agomgr/PyModuleRegistry: do not call PyEval_InitThreads() on python3.9 38099/head
Kefu Chai [Mon, 16 Nov 2020 07:33:42 +0000 (15:33 +0800)]
mgr/PyModuleRegistry: do not call PyEval_InitThreads() on python3.9

PyEval_InitThreads() and PyEval_ThreadsInitialized() are deprecated
since python3.9, and GIL is initialized by Py_Initialize() in python3.9.
so do not call them unless we are using python < 3.9.

see https://docs.python.org/3/c-api/init.html#c.PyEval_InitThreads

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agolog/Log: cast parameter of syslog() from unsigned to int
Kefu Chai [Mon, 16 Nov 2020 07:18:33 +0000 (15:18 +0800)]
log/Log: cast parameter of syslog() from unsigned to int

silences warning like:

../src/log/Log.cc:325:34: warning: field precision should have type 'int', but argument has type 'std::basic_string_view::size_type' (aka 'unsigned long') [-Wformat]
    syslog(LOG_USER|LOG_INFO, "%.*s", s.size(), s.data());
                               ~~^~   ~~~~~~~~
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomessage: mark message classes "final"
Kefu Chai [Mon, 16 Nov 2020 06:58:22 +0000 (14:58 +0800)]
message: mark message classes "final"

silences warnings like:

src/messages/MOSDPGUpdateLogMissingReply.h:74:34: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
  ~MOSDPGUpdateLogMissingReply() final {}
                                 ^
../src/messages/MOSDPGUpdateLogMissingReply.h:21:7: note: mark 'MOSDPGUpdateLogMissingReply' as 'final' to silence this warning
class MOSDPGUpdateLogMissingReply : public MOSDFastDispatchOp {
      ^
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: add 1.74 to known versions 38096/head
Kefu Chai [Mon, 16 Nov 2020 06:06:40 +0000 (14:06 +0800)]
cmake: add 1.74 to known versions

sync with
https://github.com/Kitware/CMake/blob/685fa8bec064e5776319c8a42c02578bd85b6a7d/Modules/FindBoost.cmake

for boost 1.74 support

Signed-off-by: Kefu Chai <kchai@redhat.com>