]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agocrimson/net: make ms_dispatch() return optional<future<>> 38360/head
Yingxin Cheng [Wed, 2 Dec 2020 03:25:10 +0000 (11:25 +0800)]
crimson/net: make ms_dispatch() return optional<future<>>

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: use boost::container::small_vector in ChainedDispatchers
Yingxin Cheng [Wed, 2 Dec 2020 02:34:52 +0000 (10:34 +0800)]
crimson/net: use boost::container::small_vector in ChainedDispatchers

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: ms_dispatch() use ConnectionRef
Yingxin Cheng [Mon, 30 Nov 2020 07:53:46 +0000 (15:53 +0800)]
crimson/net: ms_dispatch() use ConnectionRef

The future returned by ms_dispatch() is only for throttling, not for
Connection lifecycle management. And Messenger may not hold the
connection reference once it is closed.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/test: implement get_server_addr()
Yingxin Cheng [Mon, 30 Nov 2020 06:17:10 +0000 (14:17 +0800)]
crimson/test: implement get_server_addr()

So we can distinguish which messenger test is still pending when we have
bind failure.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: avoid using finally
Yingxin Cheng [Mon, 30 Nov 2020 05:28:28 +0000 (13:28 +0800)]
crimson/net: avoid using finally

Messenger will only throw unexpected exceptions when there is a bug. In
that case, we should not do any further operations which may result in
segmentation fault and hide the original exception.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: make bind()/try_bind() return errorated future
Yingxin Cheng [Mon, 30 Nov 2020 03:50:36 +0000 (11:50 +0800)]
crimson/net: make bind()/try_bind() return errorated future

Also fixed callers to handle the error: abort immediately upon bind
failure and report error. Previously, these callers didn't handle bind
failures correctly and would result in misleading undefined behaviors.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/osd: fix incorrect header
Yingxin Cheng [Mon, 30 Nov 2020 03:44:42 +0000 (11:44 +0800)]
crimson/osd: fix incorrect header

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: cleanup interfaces to start and stop a messenger
Yingxin Cheng [Fri, 27 Nov 2020 06:03:43 +0000 (14:03 +0800)]
crimson/net: cleanup interfaces to start and stop a messenger

There is no on-going iterations in the new
ChainedDispatchers::ms_dispatch() implementation, so we no longer need
to worry about removing dispatchers when stopping the messenger. So the
""boost::intrusive::slist" is not needed, and we can use cleaner
interfaces to start and stop the messenger.

Also fixed an regression issue in perf_crimson_msgr caused by
ChainedDispatchers.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: make Dispatcher::ms_dispatch() a pure virtual interface
Yingxin Cheng [Fri, 27 Nov 2020 05:43:14 +0000 (13:43 +0800)]
crimson/net: make Dispatcher::ms_dispatch() a pure virtual interface

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: link the throttling future in both v1 and v2
Yingxin Cheng [Fri, 27 Nov 2020 05:38:12 +0000 (13:38 +0800)]
crimson/net: link the throttling future in both v1 and v2

The current implementations are correct and will not link the
throttleing future with unrelated futures.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: return tuple<bool, future<>> from ms_dispatch()
Yingxin Cheng [Fri, 27 Nov 2020 04:53:24 +0000 (12:53 +0800)]
crimson/net: return tuple<bool, future<>> from ms_dispatch()

Return a boolean to notify whether the Dispatcher has claimed the
message. And fix all the ms_dispatch() to return future only for
throttling purposes, which is currently always seastar::now().

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: isolate exceptions from dispatcher implementations
Yingxin Cheng [Fri, 27 Nov 2020 03:30:40 +0000 (11:30 +0800)]
crimson/net: isolate exceptions from dispatcher implementations

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson: add a missing header to admin_socket.cc
Yingxin Cheng [Fri, 27 Nov 2020 03:16:22 +0000 (11:16 +0800)]
crimson: add a missing header to admin_socket.cc

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: add comments to Messenger bind methods
Yingxin Cheng [Thu, 26 Nov 2020 08:33:47 +0000 (16:33 +0800)]
crimson/net: add comments to Messenger bind methods

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agocrimson/net: remove unused add_dispatcher()
Yingxin Cheng [Thu, 26 Nov 2020 08:30:36 +0000 (16:30 +0800)]
crimson/net: remove unused add_dispatcher()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agoMerge pull request #38213 from petrutlucian94/rbd_exit
Jason Dillaman [Wed, 25 Nov 2020 01:52:02 +0000 (20:52 -0500)]
Merge pull request #38213 from petrutlucian94/rbd_exit

rbd: minor rbd-wnbd improvements

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38254 from neha-ojha/wip-48299
Yuri Weinstein [Tue, 24 Nov 2020 18:51:40 +0000 (10:51 -0800)]
Merge pull request #38254 from neha-ojha/wip-48299

doc/releases/nautilus.rst: add release notes for 14.2.15

Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
4 years agoMerge pull request #38144 from anthonyeleven/anthonyeleven/docs-46365
zdover23 [Tue, 24 Nov 2020 18:51:13 +0000 (04:51 +1000)]
Merge pull request #38144 from anthonyeleven/anthonyeleven/docs-46365

doc/dev/developer_guide: prefer Latinate verbs to English phrasal verbs

Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #38260 from bk201/wip-48338
Ernesto Puerta [Tue, 24 Nov 2020 18:35:36 +0000 (19:35 +0100)]
Merge pull request #38260 from bk201/wip-48338

mgr/dashboard: fix tox py3 environment error

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38253 from cbodley/wip-rgw-gc-disable-defer
Casey Bodley [Tue, 24 Nov 2020 17:14:22 +0000 (12:14 -0500)]
Merge pull request #38253 from cbodley/wip-rgw-gc-disable-defer

rgw: temporarily disable calls to defer_gc() in RGWGetObj

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
4 years agodoc/releases/nautilus.rst: add release notes for 14.2.15 38254/head
Neha Ojha [Tue, 24 Nov 2020 00:13:24 +0000 (00:13 +0000)]
doc/releases/nautilus.rst: add release notes for 14.2.15

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #38142 from theanalyst/doc/releases/v14.2.14
Ilya Dryomov [Tue, 24 Nov 2020 16:23:00 +0000 (17:23 +0100)]
Merge pull request #38142 from theanalyst/doc/releases/v14.2.14

doc: release notes for octopus & nautilus backports

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
4 years agoMerge pull request #38247 from dillaman/wip-librbd-test-rename
Mykola Golub [Tue, 24 Nov 2020 15:15:29 +0000 (17:15 +0200)]
Merge pull request #38247 from dillaman/wip-librbd-test-rename

test/librbd: rename tests to match proper namespaces

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agodoc: releases: v15.2.6 Octopus release notes 38142/head
Abhishek Lekshmanan [Tue, 17 Nov 2020 19:51:40 +0000 (20:51 +0100)]
doc: releases: v15.2.6 Octopus release notes

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
4 years agodoc: releases: v14.2.14 Nautilus release notes
Abhishek Lekshmanan [Tue, 17 Nov 2020 19:51:15 +0000 (20:51 +0100)]
doc: releases: v14.2.14 Nautilus release notes

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
4 years agoMerge pull request #38261 from tchaikov/wip-45919
Kefu Chai [Tue, 24 Nov 2020 10:14:37 +0000 (18:14 +0800)]
Merge pull request #38261 from tchaikov/wip-45919

pybind/mgr/dashboard/run-backend-api-tests: print more log from mgr

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
4 years agoMerge pull request #38217 from ideepika/wip-fix-lua-failure
Kefu Chai [Tue, 24 Nov 2020 10:00:15 +0000 (18:00 +0800)]
Merge pull request #38217 from ideepika/wip-fix-lua-failure

cmake: require Lua 5.3 and up

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38204 from lnsyyj/wip-iouring
Kefu Chai [Tue, 24 Nov 2020 09:55:17 +0000 (17:55 +0800)]
Merge pull request #38204 from lnsyyj/wip-iouring

blk/kernel/io_uring: do not guard liburing backend with __x86_64__ anymore

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38256 from badone/wip-dont-build-io_uring.c-every-time
Kefu Chai [Tue, 24 Nov 2020 08:04:51 +0000 (16:04 +0800)]
Merge pull request #38256 from badone/wip-dont-build-io_uring.c-every-time

cmake: Stop 'configure' running every time

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agopybind/mgr/dashboard/run-backend-api-tests: print more log from mgr 38261/head
Kefu Chai [Tue, 24 Nov 2020 07:46:52 +0000 (15:46 +0800)]
pybind/mgr/dashboard/run-backend-api-tests: print more log from mgr

in hope to more context when debugging https://tracker.ceph.com/issues/45919

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agomgr/dashboard: fix tox py3 environment error 38260/head
Kiefer Chang [Tue, 24 Nov 2020 07:41:11 +0000 (15:41 +0800)]
mgr/dashboard: fix tox py3 environment error

Add `ceph_argparse` module to the base environment.

Fixes: https://tracker.ceph.com/issues/48338
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
4 years agocmake: Stop 'configure' running every time 38256/head
Brad Hubbard [Tue, 24 Nov 2020 03:24:35 +0000 (13:24 +1000)]
cmake: Stop 'configure' running every time

Currently the configure script is run on 'liburing_ext' not only for the
initial build but for subsequent incremental builds.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
4 years agoMerge pull request #38243 from idryomov/wip-relax-preauth-asserts-again
Ilya Dryomov [Tue, 24 Nov 2020 01:48:48 +0000 (02:48 +0100)]
Merge pull request #38243 from idryomov/wip-relax-preauth-asserts-again

msg/async/ProtocolV2: allow rxbuf/txbuf get bigger in testing, again

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #38252 from idryomov/wip-resurrect-log-compression
Kefu Chai [Tue, 24 Nov 2020 01:46:40 +0000 (09:46 +0800)]
Merge pull request #38252 from idryomov/wip-resurrect-log-compression

qa/tasks/ceph: resurrect log compression

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoqa/tasks/ceph: resurrect log compression 38252/head
Ilya Dryomov [Mon, 23 Nov 2020 22:15:09 +0000 (23:15 +0100)]
qa/tasks/ceph: resurrect log compression

Commit 953662555840 ("qa/tasks/ceph: use Cluster.sh() and Remote.sh()
when appropriate") dropped run.wait(), which waits for all given
processes to exit.  This resulted in errors like

  INFO:teuthology.orchestra.run.smithi107.stderr:tar: ./objectstore_tool..log: file changed as we read it
  INFO:teuthology.orchestra.run.smithi107.stderr:tar: ./ceph-client.admin.175125.log: File removed before we read it

as the task moved on to archiving semi-corrupted and uncompressed logs,
filling up the lab cluster.

Revert that hunk, as Cluster.sh() is useless here -- we don't need
stdout or stderr, but very much need parallel execution and wait for
the compression to finish.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 years agorgw: temporarily disable calls to defer_gc() in RGWGetObj 38253/head
Casey Bodley [Mon, 23 Nov 2020 23:06:26 +0000 (18:06 -0500)]
rgw: temporarily disable calls to defer_gc() in RGWGetObj

cls_rgw_gc_queue_update_entry() is known to cause data loss when called
on objects that have not actually been scheduled for garbage collection

RGWGetObj is the only caller, and uses defer_gc() when reads are taking
a long time compared to rgw_gc_obj_min_wait. if an object has since been
deleted and submitted for garbage collection, this allows RGWGetObj to
defer that gc until the entire read completes

by disabling these calls to defer_gc(), very long reads (longer than 1hr,
with default configuration) may fail if the object gets deleted, and a
retry will result in a 404 Not Found error as expected

Fixes: https://tracker.ceph.com/issues/47866
Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 years agodoc/dev/developer_guide: prefer Latinate verbs to English phrasal verbs 38144/head
Anthony D'Atri [Wed, 18 Nov 2020 01:04:57 +0000 (17:04 -0800)]
doc/dev/developer_guide: prefer Latinate verbs to English phrasal verbs

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
Fixes: https://tracker.ceph.com/issues/46365
4 years agotest/librbd: rename tests to match proper namespaces 38247/head
Jason Dillaman [Mon, 23 Nov 2020 17:07:23 +0000 (12:07 -0500)]
test/librbd: rename tests to match proper namespaces

Some of the new crypto tests use a generic test name that
doesn't include the full namespace of the class under test.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #37875 from orozery/librbd-luks-format
Jason Dillaman [Mon, 23 Nov 2020 17:06:32 +0000 (12:06 -0500)]
Merge pull request #37875 from orozery/librbd-luks-format

librbd: add LUKS support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38201 from lixiaoy1/minor_fix_parent_cache
Jason Dillaman [Mon, 23 Nov 2020 16:12:44 +0000 (11:12 -0500)]
Merge pull request #38201 from lixiaoy1/minor_fix_parent_cache

librbd/plugin: delete field m_image_ctx in ParentCache

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd: add LUKS support 37875/head
Or Ozeri [Wed, 28 Oct 2020 12:22:06 +0000 (14:22 +0200)]
librbd: add LUKS support

This commit introduces internal (not yet part of the api) librbd functions for:
1. formating an RBD image in LUKS format
2. parsing an RBD image in LUKS format

 The actual implementation of the LUKS format is done via libcryptsetup, which is added as a new dependency.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
4 years agoMerge pull request #38089 from anthonyeleven/anthonyeleven/docs-47976
zdover23 [Mon, 23 Nov 2020 14:32:22 +0000 (00:32 +1000)]
Merge pull request #38089 from anthonyeleven/anthonyeleven/docs-47976

doc/mgr: Fix msgr2 TCP port in a couple of examples

Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #38180 from anthonyeleven/anthonyeleven/docs-23442
zdover23 [Mon, 23 Nov 2020 14:05:00 +0000 (00:05 +1000)]
Merge pull request #38180 from anthonyeleven/anthonyeleven/docs-23442

doc/rados/operations: Add description of new auth profiles

Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #38229 from wjwithagen/wjw-fix-librbd-HttpStream.cc
Jason Dillaman [Mon, 23 Nov 2020 13:35:10 +0000 (08:35 -0500)]
Merge pull request #38229 from wjwithagen/wjw-fix-librbd-HttpStream.cc

librbd: Fix variable declaration in capture list in lambda

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agomsg/async/ProtocolV2: allow rxbuf/txbuf get bigger in testing, again 38243/head
Ilya Dryomov [Sat, 21 Nov 2020 10:01:40 +0000 (11:01 +0100)]
msg/async/ProtocolV2: allow rxbuf/txbuf get bigger in testing, again

With CEPHX_V2 authorizer challenges brought back in commit
4a82c72e3bdd, these need to be bumped again, as two authorizers
(without and then with the challenge) are transmitted and signed
instead of one (without the challenge).  See commit 94953dd9398a
("msg/async/ProtocolV2: allow rxbuf/txbuf get bigger in testing")
for details.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 years agoMerge PR #38207 into master
Jan Fajerski [Mon, 23 Nov 2020 12:59:16 +0000 (13:59 +0100)]
Merge PR #38207 into master

* refs/pull/38207/head:
ceph-volume: fix test_setup_device_device_name_is_none

Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
4 years agoMerge pull request #38092 from anthonyeleven/anthonyeleven/docs-mixed-device-trick
zdover23 [Mon, 23 Nov 2020 12:20:13 +0000 (22:20 +1000)]
Merge pull request #38092 from anthonyeleven/anthonyeleven/docs-mixed-device-trick

doc/rados/operations: enhance primary affinity section

Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agocmake: require Lua 5.3 and up 38217/head
Deepika Upadhyay [Fri, 20 Nov 2020 14:02:45 +0000 (19:32 +0530)]
cmake: require Lua 5.3 and up

fixes: https://tracker.ceph.com/issues/48312
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #38181 from anthonyeleven/anthonyeleven/docs-23443
zdover23 [Mon, 23 Nov 2020 06:13:24 +0000 (16:13 +1000)]
Merge pull request #38181 from anthonyeleven/anthonyeleven/docs-23443

doc: object -> file -> disk is wrong for bluestore

Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #34506 from ktdreyer/doc-rm-sysv-init
zdover23 [Mon, 23 Nov 2020 06:10:30 +0000 (16:10 +1000)]
Merge pull request #34506 from ktdreyer/doc-rm-sysv-init

doc: remove SysV init reference in manual deployment walkthrough

Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 years agorbd: add "help" command to rbd-wnbd 38213/head
Lucian Petrut [Fri, 20 Nov 2020 07:06:39 +0000 (07:06 +0000)]
rbd: add "help" command to rbd-wnbd

At the moment, "rbd-wnbd" says that "help" is an unsupported command,
only "rbd-wnbd -h" works. This isn't very user friendly.

Although "rbd-wnbd" isn't supposed to be used directly in most cases,
users might want to retrieve device specific arguments that can be
passed using "rbd device -o".

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
4 years agoMerge pull request #38228 from ivancich/wip-rgw-gc-defer-should-not-enqueue
J. Eric Ivancich [Sun, 22 Nov 2020 15:36:48 +0000 (10:36 -0500)]
Merge pull request #38228 from ivancich/wip-rgw-gc-defer-should-not-enqueue

rgw: during GC defer, prevent new GC enqueue

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
4 years agoMerge pull request #38231 from anthonyeleven/anthonyeleven/docs-40579
Kefu Chai [Sun, 22 Nov 2020 13:24:56 +0000 (21:24 +0800)]
Merge pull request #38231 from anthonyeleven/anthonyeleven/docs-40579

doc/rados/operations: POOL_NEAR_FULL on OSD_NEAR_FULL

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoblk/kernel/io_uring: do not guard liburing backend with __x86_64__ anymore 38204/head
JiangYu [Fri, 20 Nov 2020 06:24:54 +0000 (06:24 +0000)]
blk/kernel/io_uring: do not guard liburing backend with __x86_64__ anymore

Signed-off-by: JiangYu <lnsyyj@hotmail.com>
Let the liburing library to ensure the support of the iouring system call back-end CPU instruction set.

4 years agodoc/rados/operations: POOL_NEAR_FULL on OSD_NEAR_FULL 38231/head
Anthony D'Atri [Wed, 18 Nov 2020 05:08:29 +0000 (21:08 -0800)]
doc/rados/operations: POOL_NEAR_FULL on OSD_NEAR_FULL

Fixes: https://tracker.ceph.com/issues/40579
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
4 years agodoc/rados/operations: enhance primary affinity section 38092/head
Anthony D'Atri [Mon, 16 Nov 2020 03:52:00 +0000 (19:52 -0800)]
doc/rados/operations: enhance primary affinity section

Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
4 years agoMerge pull request #38090 from anthonyeleven/anthonyeleven/docs-47339
Kefu Chai [Sun, 22 Nov 2020 06:03:09 +0000 (14:03 +0800)]
Merge pull request #38090 from anthonyeleven/anthonyeleven/docs-47339

doc/releases: correct spelling

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37900 from jhonxue/master
Kefu Chai [Sun, 22 Nov 2020 05:42:46 +0000 (13:42 +0800)]
Merge pull request #37900 from jhonxue/master

os/bluestore/StupidAllocator: choose the right bin when bdev_block_size changed

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #38161 from petrutlucian94/msg_timeout
Kefu Chai [Sun, 22 Nov 2020 05:41:33 +0000 (13:41 +0800)]
Merge pull request #38161 from petrutlucian94/msg_timeout

msg: use timeout when initiating connection

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38070 from dvanders/dvanders_trimto
Kefu Chai [Sun, 22 Nov 2020 05:39:44 +0000 (13:39 +0800)]
Merge pull request #38070 from dvanders/dvanders_trimto

mon/OSDMonitor, mon/PaxosService: additional debug outputs when trimming

Reviewed-by: Joao Eduardo Luis <joao@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38148 from jhonxue/wip-fix-bluestore-avl-allocator
Kefu Chai [Sun, 22 Nov 2020 05:39:09 +0000 (13:39 +0800)]
Merge pull request #38148 from jhonxue/wip-fix-bluestore-avl-allocator

os/bluestore: do not call _block_picker() again if already searched from start()

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38128 from tchaikov/wip-mon-add-space-in-log
Kefu Chai [Sun, 22 Nov 2020 05:36:25 +0000 (13:36 +0800)]
Merge pull request #38128 from tchaikov/wip-mon-add-space-in-log

mon/OSDMonitor: add a space after function name in logging message

Reviewed-by: Joao Eduardo Luis <joao@suse.com>
4 years agodoc/releases: correct spelling 38090/head
Anthony D'Atri [Mon, 16 Nov 2020 00:01:36 +0000 (16:01 -0800)]
doc/releases: correct spelling

Fixes: https://tracker.ceph.com/issues/47339
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
4 years agoMerge pull request #38227 from tchaikov/wip-store-test
Kefu Chai [Sun, 22 Nov 2020 01:59:08 +0000 (09:59 +0800)]
Merge pull request #38227 from tchaikov/wip-store-test

test/store_test: pass raw Formatter pointer as expected

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agolibrbd: Fix variable declaration in capture list in lambda 38229/head
Willem Jan Withagen [Sat, 21 Nov 2020 21:58:13 +0000 (22:58 +0100)]
librbd: Fix variable declaration in capture list in lambda

Fixes: https://github.com/ceph/ceph/pull/38000
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agorgw: during GC defer, prevent new GC enqueue 38228/head
J. Eric Ivancich [Sat, 21 Nov 2020 16:10:35 +0000 (11:10 -0500)]
rgw: during GC defer, prevent new GC enqueue

With the new queue-based GC code, when a GC defer operation is
performed, it adds an "urgent" record to prevent GC from removing
objects that are still being read. It does not check whether the
objects are on the GC queue or not and that's OK for the urgent
record.

The code *also* adds a new GC entry to the queue to cause GC to occur
at a later time. This would be incorrect if there was no GC entry to
begin with, however. In such a case this would cause GC to delete tail
objects when no user-initiated remove has happend. In other words a
READ could cause a DELETE of tail objects and therefore data loss.

This fix prevents such a new GC entry from being enqueued, thus
preventing the data loss in this rare case. There is a new risk that
tail object orphans to be created, but as an immediate fix to prevent
data loss, this is appropriate and it is a rare event. A follow-on PR
that will handle these cases is likely.

This PR adds a level 0 log entry as a way to potentially confirm this
case is being triggered in real-world cases. In time, this log entry
should be deleted.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
4 years agotest/store_test: pass raw Formatter pointer as expected 38227/head
Kefu Chai [Sat, 21 Nov 2020 17:14:27 +0000 (01:14 +0800)]
test/store_test: pass raw Formatter pointer as expected

this addresses the FTBFS regression introduced by
f153a7031e56534723c0fc891869902c58acb473

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38196 from dillaman/wip-48296
Mykola Golub [Sat, 21 Nov 2020 13:41:16 +0000 (15:41 +0200)]
Merge pull request #38196 from dillaman/wip-48296

pybind/mgr/rbd_support: delay creation of progress module events

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #38223 from Rethan/fix_formatter_pointer
Kefu Chai [Sat, 21 Nov 2020 11:01:33 +0000 (19:01 +0800)]
Merge pull request #38223 from Rethan/fix_formatter_pointer

test: free Formatter pointers

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agotest/: use unique_ptr for some formatter whose pointers were not released. 38223/head
haoyixing [Sat, 21 Nov 2020 09:09:32 +0000 (17:09 +0800)]
test/: use unique_ptr for some formatter whose pointers were not released.

some code under test use formatter to output, but Formatter *f
was not freed like elsewere. So use unique_ptr to avoid this.

Signed-off-by: haoyixing <haoyixing@kuaishou.com>
4 years agoMerge pull request #38220 from neha-ojha/wip-fix-label-2
Neha Ojha [Fri, 20 Nov 2020 22:50:10 +0000 (14:50 -0800)]
Merge pull request #38220 from neha-ojha/wip-fix-label-2

.github/labeler.yml: fix pybind and common rules

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years ago.github/labeler.yml: fix pybind and common rules 38220/head
Neha Ojha [Fri, 20 Nov 2020 19:53:29 +0000 (19:53 +0000)]
.github/labeler.yml: fix pybind and common rules

Noticed it didn't work in https://github.com/ceph/ceph/pull/38206

Signed-off-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #38193 from dang/wip-dang-zipper-9
Daniel Gryniewicz [Fri, 20 Nov 2020 19:33:45 +0000 (14:33 -0500)]
Merge pull request #38193 from dang/wip-dang-zipper-9

RGW - Zipper 9: Write path

4 years agoZipper - ObjectProcessor 38193/head
Daniel Gryniewicz [Wed, 23 Sep 2020 17:19:01 +0000 (13:19 -0400)]
Zipper - ObjectProcessor

Fix the ObjectProcessor classes to use Zipper APIs

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
4 years agoMerge pull request #37734 from matthewoliver/rgw_swift_dlo_fix
Casey Bodley [Fri, 20 Nov 2020 16:55:58 +0000 (11:55 -0500)]
Merge pull request #37734 from matthewoliver/rgw_swift_dlo_fix

rgw: Check all shards for user manifest parts

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
4 years agoMerge pull request #38062 from s0nea/wip-dashboard-new-password
Ernesto Puerta [Fri, 20 Nov 2020 16:47:27 +0000 (17:47 +0100)]
Merge pull request #38062 from s0nea/wip-dashboard-new-password

mgr/dashboard: amend the look & feel of the login password form

Reviewed-by: nizamial09 <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #37740 from s0nea/wip-dashboard-ceph-input-validation
Ernesto Puerta [Fri, 20 Nov 2020 16:45:44 +0000 (17:45 +0100)]
Merge pull request #37740 from s0nea/wip-dashboard-ceph-input-validation

mgr/dashboard: validate username while creation

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #37719 from tspmelo/wip-rbd-invalid-name
Ernesto Puerta [Fri, 20 Nov 2020 16:43:55 +0000 (17:43 +0100)]
Merge pull request #37719 from tspmelo/wip-rbd-invalid-name

mgr/dashboard: RBD: Disable actions when name is not valid

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #38000 from dillaman/wip-librbd-migration-3
Mykola Golub [Fri, 20 Nov 2020 16:37:08 +0000 (18:37 +0200)]
Merge pull request #38000 from dillaman/wip-librbd-migration-3

librbd: http-based migration source

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #38214 from rzarzynski/wip-crimson-pg-drop-undefined-declarations
Kefu Chai [Fri, 20 Nov 2020 15:55:17 +0000 (23:55 +0800)]
Merge pull request #38214 from rzarzynski/wip-crimson-pg-drop-undefined-declarations

crimson: drop two undefined method declarations from PG

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38216 from rzarzynski/wip-crimson-no-pg-in-opsexecuter
Kefu Chai [Fri, 20 Nov 2020 15:52:24 +0000 (23:52 +0800)]
Merge pull request #38216 from rzarzynski/wip-crimson-no-pg-in-opsexecuter

crimson: make OpsExecuter unaware about the giant PG class

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoRemove copy from ceph::static_ptr
Daniel Gryniewicz [Thu, 24 Sep 2020 16:45:31 +0000 (12:45 -0400)]
Remove copy from ceph::static_ptr

The copy functionality of ceph::static_ptr is unused, and it means that
nothing containing a std::unique_ptr (or any other non-copyable type)
can be put into a static_ptr.

Remove the copy functionality, so that unique_ptr can be used in
static_ptr.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
4 years agoZipper - Assorted cleanups
Daniel Gryniewicz [Tue, 15 Sep 2020 11:59:39 +0000 (07:59 -0400)]
Zipper - Assorted cleanups

- Move cluste stat into public header, allowing more zipper cleanup
- Swift versioning
- Implement a MPSerializer for Zipper.
- Add Lifecycle APIs to Zipper.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
4 years agoZipper - WriteOp
Daniel Gryniewicz [Wed, 18 Nov 2020 20:51:52 +0000 (15:51 -0500)]
Zipper - WriteOp

Add WriteOp to the Zipper API, and use it.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
4 years agoMerge pull request #38122 from lxbsz/rbdmap_init
Jason Dillaman [Fri, 20 Nov 2020 15:17:20 +0000 (10:17 -0500)]
Merge pull request #38122 from lxbsz/rbdmap_init

rbd: drop initd-based systems for rbdmap

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #37576 from p-se/doc-cephadm-custom-monitoring-templates
Sebastian Wagner [Fri, 20 Nov 2020 15:15:39 +0000 (16:15 +0100)]
Merge pull request #37576 from p-se/doc-cephadm-custom-monitoring-templates

mgr/cephadm: document setting custom monitoring templates for configuration files

Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #37696 from p-se/cephadm-monitoring-grafana-tls
Sebastian Wagner [Fri, 20 Nov 2020 14:42:28 +0000 (15:42 +0100)]
Merge pull request #37696 from p-se/cephadm-monitoring-grafana-tls

doc/cepham: instructions for custom Grafana TLS certs

Reviewed-by: Alexandra Settle <asettle@suse.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #38210 from rzarzynski/wip-crimson-fix-warning-in-with_locked_obc
Kefu Chai [Fri, 20 Nov 2020 14:14:51 +0000 (22:14 +0800)]
Merge pull request #38210 from rzarzynski/wip-crimson-fix-warning-in-with_locked_obc

crimson: fix a warning in PG::with_lock_obc().

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson: OpsExecuter stores only const reference to MOSDOp. 38216/head
Radoslaw Zarzynski [Fri, 20 Nov 2020 13:42:33 +0000 (14:42 +0100)]
crimson: OpsExecuter stores only const reference to MOSDOp.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson: make OpsExecuter unaware about PG.
Radoslaw Zarzynski [Fri, 20 Nov 2020 13:31:47 +0000 (14:31 +0100)]
crimson: make OpsExecuter unaware about PG.

`PG` is heavy-weight class with many responsibilities.
Exposing it to lower-layer may suggest there is far more
coupling between them than in reality.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson: drop the declared but undefined PG::do_pgnls(). 38214/head
Radoslaw Zarzynski [Fri, 20 Nov 2020 13:44:15 +0000 (14:44 +0100)]
crimson: drop the declared but undefined PG::do_pgnls().

`PgOpsExecuter` takes care; it's not not a responsibility
of `PG` anymore.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson: drop the declared but undefined PG::do_osd_op().
Radoslaw Zarzynski [Fri, 20 Nov 2020 13:13:39 +0000 (14:13 +0100)]
crimson: drop the declared but undefined PG::do_osd_op().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson: comment on why OpsExecuter needs PG.
Radoslaw Zarzynski [Fri, 20 Nov 2020 12:42:32 +0000 (13:42 +0100)]
crimson: comment on why OpsExecuter needs PG.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agorbd: update "rbd-wnbd show" error handling
Lucian Petrut [Thu, 19 Nov 2020 14:45:52 +0000 (14:45 +0000)]
rbd: update "rbd-wnbd show" error handling

We'll update the "rbd-wnbd show" command to return -ENOENT
when the specified mapping doesn't exist, instead of returning
-EINVAL. At the moment, it's impossible to tell if the operation
failed because of an error or the mapping simply doesn't exist.

Worth mentioning that on Windows, we can use 32b for the exit code,
which is a bit more flexible.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
4 years agoMerge pull request #38061 from tchaikov/wip-48012
Kefu Chai [Fri, 20 Nov 2020 12:27:00 +0000 (20:27 +0800)]
Merge pull request #38061 from tchaikov/wip-48012

mgr/dashboard: use http://docs.ceph.com/en/${release}/ for the domain…

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
4 years agocrimson: fix a warning in PG::with_lock_obc(). 38210/head
Radoslaw Zarzynski [Fri, 20 Nov 2020 11:52:01 +0000 (12:52 +0100)]
crimson: fix a warning in PG::with_lock_obc().

Without the fix, on a build with `NDEBUG` set,
GCC complains:

```
crimson/osd/pg.cc:869:35: warning: control reaches end of non-void function [-Wreturn-type]
  869 |   const hobject_t oid = get_oid(*m);
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agolibrbd/plugin: delete field m_image_ctx 38201/head
lixiaoy1 [Fri, 20 Nov 2020 11:06:15 +0000 (06:06 -0500)]
librbd/plugin: delete field m_image_ctx

librbd::plugin::ParentCache may be shared by more than one images.

Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
4 years agoMerge pull request #38177 from jhonxue/fix-test-objectstore-allocator
Kefu Chai [Fri, 20 Nov 2020 10:52:46 +0000 (18:52 +0800)]
Merge pull request #38177 from jhonxue/fix-test-objectstore-allocator

test/objectstore: handle -ENOSPC returned by allocate()

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoceph-volume: fix test_setup_device_device_name_is_none 38207/head
Guillaume Abrioux [Fri, 20 Nov 2020 10:41:28 +0000 (11:41 +0100)]
ceph-volume: fix test_setup_device_device_name_is_none

Let's call this function by using the same syntax than other tests.
This will make it work with py2 in nautilus branch.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
4 years agotest/objectstore: handle -ENOSPC returned by allocate() 38177/head
jhonxue [Thu, 19 Nov 2020 04:38:02 +0000 (12:38 +0800)]
test/objectstore: handle -ENOSPC returned by allocate()

Fixes: https://tracker.ceph.com/issues/48288
Signed-off-by: Xue Yantao <jhonxue@tencent.com>