]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Avan Thakkar [Thu, 17 Dec 2020 09:44:46 +0000 (15:14 +0530)]
mgr/dashboard: Fix for copy2Clipboard failing to copy on the first time.
Fixes: https://tracker.ceph.com/issues/48601
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Fix for the copy2Clipboard button to work on the first click itself.
Kefu Chai [Thu, 17 Dec 2020 06:16:38 +0000 (14:16 +0800)]
Merge pull request #38617 from batrick/cmake-labeler
.github/labeler: add build/ops label
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 17 Dec 2020 05:40:50 +0000 (13:40 +0800)]
Merge pull request #38629 from changchengx/sudo_fix
install-deps.sh: install debian package with proper right
Reviewed-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Thu, 17 Dec 2020 04:13:43 +0000 (20:13 -0800)]
Merge PR #38464 into master
* refs/pull/38464/head:
mds/OpenFileTable: make the data length as long as possible for each op
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Thu, 17 Dec 2020 04:13:09 +0000 (20:13 -0800)]
Merge PR #38363 into master
* refs/pull/38363/head:
mds/OpenFileTable: enhance the log info
mds/OpenFileTable: add _read_omap_values() to simplify the code
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Thu, 17 Dec 2020 04:12:22 +0000 (20:12 -0800)]
Merge PR #38355 into master
* refs/pull/38355/head:
client: when STATX_NLINK is requested request FsLs caps
client: ensure we take Fs caps when querying dirstat vxattrs
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Patrick Donnelly [Thu, 17 Dec 2020 04:11:42 +0000 (20:11 -0800)]
Merge PR #38236 into master
* refs/pull/38236/head:
qa: forward scrubbing background task
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Thu, 17 Dec 2020 04:04:50 +0000 (20:04 -0800)]
Merge PR #38222 into master
* refs/pull/38222/head:
client: set CEPH_STAT_RSTAT mask for dir in readdir_r_cb
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Changcheng Liu [Thu, 17 Dec 2020 03:13:35 +0000 (11:13 +0800)]
install-deps.sh: install debian package with proper right
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
Patrick Donnelly [Wed, 16 Dec 2020 16:47:17 +0000 (08:47 -0800)]
.github/labeler: add build/ops label
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Thu, 17 Dec 2020 01:28:39 +0000 (09:28 +0800)]
Merge pull request #38624 from rzarzynski/wip-crimson-nopack-in-blocking_future
crimson/osd: drop arg packs from blocking_future.
Reviewed-by: Kefu Chai <kchai@redhat.com>
zdover23 [Thu, 17 Dec 2020 01:28:21 +0000 (11:28 +1000)]
Merge pull request #38450 from zdover23/wip-doc-dev-guide-basic-workflow-auto-pr-valid-dec-2020-1
doc/dev: update auto pr validation section
Reviewed-by: Josh Durgin <jdurgin@redat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Kefu Chai [Thu, 17 Dec 2020 01:02:49 +0000 (09:02 +0800)]
Merge pull request #38600 from agayev/master
os/bluestore: Fix code rot in ZonedAllocator.
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 17 Dec 2020 00:05:44 +0000 (08:05 +0800)]
Merge pull request #38609 from ideepika/fix-yaml-failure
cmake: fix build failure due to yaml-cpp not available
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 16 Dec 2020 23:54:29 +0000 (07:54 +0800)]
Merge pull request #38608 from tchaikov/wip-crimson-build
rpm,deb: conditionally package crimson-store-nbd in ceph-test
Reviewed-by: Samuel Just <sjust@redhat.com>
Kefu Chai [Wed, 16 Dec 2020 23:52:34 +0000 (07:52 +0800)]
Merge pull request #38578 from cyx1231st/wip-seastar-onode-tree-fix-stage-type
crimson/onode-staged-tree: fix match_stage_t related compile issue
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Neha Ojha [Wed, 16 Dec 2020 22:11:18 +0000 (14:11 -0800)]
Merge pull request #38625 from batrick/tox-fix
qa: fix tox failures
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Patrick Donnelly [Wed, 16 Dec 2020 20:42:25 +0000 (12:42 -0800)]
qa: fix tox failures
Fixes: c6121e48ecb7224e5addf4b5fdeb64907a8d8683
Fixes: https://tracker.ceph.com/issues/48633
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Radoslaw Zarzynski [Wed, 16 Dec 2020 18:35:48 +0000 (19:35 +0100)]
crimson/osd: drop arg packs from blocking_future.
This feature is not necessary as the `seastar::feature` lost
the support for `T...`.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ernesto Puerta [Wed, 16 Dec 2020 17:16:58 +0000 (18:16 +0100)]
Merge pull request #38548 from rhcs-dashboard/wip-48570-master
github: add action to manage needs-rebase label
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Patrick Donnelly [Wed, 16 Dec 2020 16:19:21 +0000 (08:19 -0800)]
Merge branch 'CVE-2020-27781' into master
* CVE-2020-27781:
tasks/cephfs/test_volume_client: Add tests for authorize/deauthorize
pybind/ceph_volume_client: Optionally authorize existing auth-ids
pybind/ceph_volume_client: Preserve existing caps while authorize/deauthorize auth-id
pybind/ceph_volume_client: Disallow authorize auth_id
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
zdover23 [Wed, 16 Dec 2020 15:11:53 +0000 (01:11 +1000)]
Merge pull request #38580 from anthonyeleven/anthonyeleven/48301-underscores
doc: standardize config option names with interstitial underscores
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Yingxin Cheng [Wed, 16 Dec 2020 08:09:42 +0000 (16:09 +0800)]
crimson/onode-staged-tree: comment out excessive range checks
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Zac Dover [Sat, 5 Dec 2020 02:17:24 +0000 (12:17 +1000)]
doc/dev: update auto pr validation section
This commit updates the "Automated PR Validation"
section of the "Basic Workflow" page in the
Developer Guide. This is part of a project that
aims to clean all of the sentences currently extant
in the Dev Guide, prior to a slight reorganization
of that guide for the sake of clarity and simplicity.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Abutalib Aghayev [Tue, 15 Dec 2020 17:07:29 +0000 (12:07 -0500)]
os/bluestore: Fix code rot in ZonedAllocator.
Signed-off-by: Abutalib Aghayev <agayev@psu.edu>
Deepika Upadhyay [Wed, 16 Dec 2020 12:47:01 +0000 (18:17 +0530)]
install-deps.sh: add with_jaeger options for installing it's dependencies
* if WITH_JAEGER flag is specified, install-deps should mangle and update
debian/control + ceph.spec the way we do for adding crimson dependencies
with WITH_SEASTAR flag.
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
Deepika Upadhyay [Wed, 16 Dec 2020 12:39:00 +0000 (18:09 +0530)]
debian/control: update yaml-cpp version if building with Jaeger
jaeger specifically requires yaml-dev +0.6 but since all supported
distro(bionic) still doesn't have this version, yaml-cpp will be build
from source if enabled.
This fixes the build failure:
```
Could NOT find yaml-cpp: Found unsuitable version "", but required is at
least "0.5.1" (found yaml-cpp_LIBRARY-NOTFOUND)
```
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
Ernesto Puerta [Wed, 16 Dec 2020 12:29:22 +0000 (13:29 +0100)]
Merge pull request #38316 from rhcs-dashboard/temporary-lockout
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Ernesto Puerta [Wed, 16 Dec 2020 12:27:32 +0000 (13:27 +0100)]
Merge pull request #38534 from votdev/issue_48542_rgw_status
mgr/dashboard: The /rgw/status endpoint does not check for running service
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Mykola Golub [Wed, 16 Dec 2020 11:20:38 +0000 (13:20 +0200)]
Merge pull request #38536 from dillaman/wip-48553
librbd/mirror: unlink the third snapshot when the limit is reached
Reviewed-by: Mykola Golub <mgolub@suse.com>
Nizamudeen A [Thu, 10 Dec 2020 08:05:38 +0000 (13:35 +0530)]
mgr/dashboard: Updating the docs regarding the user lockout
Fixes: https://tracker.ceph.com/issues/40914
Signed-off-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Thu, 26 Nov 2020 10:25:00 +0000 (15:55 +0530)]
mgr/dashboard: Temporary User Lockout if 10 Invalid Login attempts
Implemented a user lockout mechanism if the user enters 10 invalid attempts. The attempt count gets resetted to 0 once the user succesfully logins before getting disabled. Once the user gets disabled administrator has to manually enable the user which will also resets the number of attempts.
Fixes: https://tracker.ceph.com/issues/40914
Signed-off-by: Nizamudeen A <nia@redhat.com>
Ernesto Puerta [Wed, 16 Dec 2020 10:43:54 +0000 (11:43 +0100)]
Merge pull request #38606 from rhcs-dashboard/log-e2e-fix
mgr/dashboard: Fixing dashboard logs e2e test
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Nizamudeen A [Wed, 16 Dec 2020 08:23:14 +0000 (13:53 +0530)]
mgr/dashboard: Fixing dashboard logs e2e test
Yesterday there were some changes went in which disables the logging of config set and config-key set to to be logged in mgr audit logs. Dashboard has an e2e test which checks for this config set and broke the current e2e jenkins job. This commit removes that certain test to fix the jenkins job.
Fixes: https://tracker.ceph.com/issues/48623
Signed-off-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Wed, 16 Dec 2020 07:54:55 +0000 (15:54 +0800)]
debian: install crimson-store-nbd with pkg.ceph.crimson profile
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 16 Dec 2020 07:43:45 +0000 (15:43 +0800)]
rpm: package crimson-store-nbd in ceph-test package
when building with seastar enabled, package crimson-store-ndb in
"ceph-test" package. "crimson-store-nbd" is a new tool for testing
seastore using nbd.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 16 Dec 2020 05:58:05 +0000 (13:58 +0800)]
Merge pull request #38581 from cyx1231st/wip-seastar-msgr-fix-test-preemptive-shutdown
crimson/net: fix test_preemptive_shutdown() failure
Reviewed-by: Kefu Chai <kchai@redhat.com>
Josh Durgin [Wed, 16 Dec 2020 00:29:26 +0000 (16:29 -0800)]
Merge pull request #31358 from ideepika/wip-jaegertracing-in-ceph
jaegertracing build/ops integration
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Anthony D'Atri [Tue, 15 Dec 2020 06:02:31 +0000 (22:02 -0800)]
doc: standardize config option names to use interstitial underscores
Ceph config option names may use spaces, underscores, or by one reference hyphens
as interstitial separators. Most usage within the doc tree uses underscores,
though example conf files and especially structured lists of options mostly
use spaces. Mostly. Underscores help differentiate the config names from
surrounding text, and moreover facilitate scripting, grep, awk, etc and match
their form in src/common/options.cc.
This PR conforms these occurrences of option names to use interstitial underscores instead of spaces.
Fixes: https://tracker.ceph.com/issues/48301
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
Josh Durgin [Tue, 15 Dec 2020 20:06:39 +0000 (12:06 -0800)]
Merge pull request #38479 from neha-ojha/wip-37503-2
Do not add sensitive information in Ceph log files
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Jason Dillaman [Tue, 15 Dec 2020 19:53:48 +0000 (14:53 -0500)]
Merge pull request #38514 from lixiaoy1/rbd_types_fix
librbd/cmake: Add missed PWL related types
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Ernesto Puerta [Tue, 15 Dec 2020 19:07:23 +0000 (20:07 +0100)]
Merge pull request #38546 from rhcs-dashboard/round-button
mgr/dashboard: Making the edges of not rounded button rounded
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Ernesto Puerta [Tue, 15 Dec 2020 18:51:45 +0000 (19:51 +0100)]
Merge pull request #38269 from rhcs-dashboard/fix-44960-master
mgr/dashboard: replace cdCopy2ClipboardButton Directive with a component
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Ernesto Puerta [Tue, 15 Dec 2020 18:47:30 +0000 (19:47 +0100)]
Merge pull request #37937 from p-se/cd-alternative-grafana-fe-url
mgr/dashboard: enable different URL for users of browser to Grafana
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Ernesto Puerta [Fri, 11 Dec 2020 20:24:35 +0000 (21:24 +0100)]
github: add action to manage needs-rebase label
Fixes: https://tracker.ceph.com/issues/48570
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Ernesto Puerta [Tue, 15 Dec 2020 17:59:14 +0000 (18:59 +0100)]
Merge pull request #36715 from rhcs-dashboard/fix-39128-master
mgr/dashboard: new generic HTTP error page component
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
Ernesto Puerta [Tue, 15 Dec 2020 17:57:03 +0000 (18:57 +0100)]
Merge pull request #38456 from SMIL-Infra/fix-crush-map-viewer
mgr/dashboard: Fix CRUSH map viewer VirtualScroll
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Courtney Caldwell [Tue, 15 Dec 2020 16:41:18 +0000 (11:41 -0500)]
mgr/dashboard: replace cdCopy2ClipboardButton Directive with a component
Replaces Directive-Based copy2ClipboardButton with a Component-based version.
Further replaces all instances of Directive use with Component version.
Similar toastr logic used.
Fixes: https://tracker.ceph.com/issues/44960
Signed-off-by: Courtney Caldwell <ccaldwel@redhat.com>
Neha Ojha [Sat, 5 Dec 2020 01:22:11 +0000 (01:22 +0000)]
mon, messages: use TOPNSPC::common for crimson compatibility
Signed-off-by: Neha Ojha <nojha@redhat.com>
Neha Ojha [Thu, 3 Dec 2020 21:54:23 +0000 (21:54 +0000)]
mgr/ActivePyModules.cc: don't log config value in get_typed_config
Signed-off-by: Neha Ojha <nojha@redhat.com>
Neha Ojha [Thu, 3 Dec 2020 21:00:51 +0000 (21:00 +0000)]
mon/ConfigMonitor.cc: don't log config values in refresh_config
Signed-off-by: Neha Ojha <nojha@redhat.com>
Neha Ojha [Thu, 3 Dec 2020 20:34:53 +0000 (20:34 +0000)]
mgr: don't add config values to mgr log in config_callback and module_config
The original code has been commented out and left for future debugging
purposes.
Signed-off-by: Neha Ojha <nojha@redhat.com>
Neha Ojha [Thu, 3 Dec 2020 20:33:20 +0000 (20:33 +0000)]
mon/ConfigMonitor.cc: don't dump all keys and values in config map
Signed-off-by: Neha Ojha <nojha@redhat.com>
Neha Ojha [Thu, 3 Dec 2020 19:24:39 +0000 (19:24 +0000)]
mon: don't log "config set" and "config-key set" dispatch and finished messages
Signed-off-by: Neha Ojha <nojha@redhat.com>
Neha Ojha [Thu, 3 Dec 2020 19:18:04 +0000 (19:18 +0000)]
messages/MMonCommand, MMonCommandAck: don't log values for "config set" and "config-key set"
This acts like a big hammer to avoid adding sensitive information, like passwords
into mon/mgr/cluster logs when using "config set" and "config-key set" to set keys
whose values should be secure.
Fixes: https://tracker.ceph.com/issues/37503
Signed-off-by: Neha Ojha <nojha@redhat.com>
Casey Bodley [Tue, 15 Dec 2020 13:51:07 +0000 (08:51 -0500)]
Merge pull request #38010 from cbodley/wip-rgw-doc-reshard-syncstop
doc/rgw: update reshard design regarding 'bucket sync disable'
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 12:28:57 +0000 (20:28 +0800)]
Merge pull request #38585 from tchaikov/wip-doc-dev-errorator
doc/dev/crimson: highlight code blocks using C++ lexer
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 12:26:52 +0000 (20:26 +0800)]
Merge pull request #38582 from tchaikov/wip-crimson-cleanup
crimson/osd: cleanups
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 09:50:35 +0000 (17:50 +0800)]
doc/dev/crimson: quote inline codeblock using "``"
backquote is used for quoting italic typed text.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 09:40:59 +0000 (17:40 +0800)]
doc/dev/crimson: highlight code blocks using C++ lexer
also remove redundant ":", normally "::" would suffice to start a
codeblock.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 09:21:08 +0000 (17:21 +0800)]
crimson/osd: handle error using handle_error()
no need to use safe_then() for this purpose.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 08:56:21 +0000 (16:56 +0800)]
crimson/osd: do not use __func__ in lambda
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 08:54:30 +0000 (16:54 +0800)]
crimson/osd: drop log messages only for debugging
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 08:47:20 +0000 (16:47 +0800)]
crimson/osd: do not capture dup variable
first can be deduced by variable already captured, so store it as a
local variable. it's less expensive than storing it as a captured
variable.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 08:40:44 +0000 (16:40 +0800)]
crimson/osd: do not use do_with() unless necessary
in this change, a seastar::do_with() is removed, as the captured
variables are passed to submit_push_data() by value. so no need to keep
them alive after the call.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 08:14:21 +0000 (16:14 +0800)]
crimson/osd: let trim_pushed_data() return extents
trim_pushed_data() is responsible for building up the extents to be used
for pushing. so let it return the extents.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 07:36:50 +0000 (15:36 +0800)]
crimson/osd: use range-based for loop
also add comment explaining
ReplicatedRecoveryBackend::trim_pushed_data()
and move the definition of local variable closer to where it is used.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Mykola Golub [Tue, 15 Dec 2020 09:00:08 +0000 (11:00 +0200)]
Merge pull request #38539 from dillaman/wip-48526
librbd/object_map: don't assert if a snapshot doesn't exist
Reviewed-by: Mykola Golub <mgolub@suse.com>
Yingxin Cheng [Tue, 15 Dec 2020 07:52:08 +0000 (15:52 +0800)]
crimson/net: abort on-going v1 protocol when closed
Fixes: http://tracker.ceph.com/issues/48108
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 15 Dec 2020 07:51:01 +0000 (15:51 +0800)]
crimson/net: track closing connections for v1
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 15 Dec 2020 07:48:43 +0000 (15:48 +0800)]
crimson/net: report unexpected exceptions during closing
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 15 Dec 2020 07:45:52 +0000 (15:45 +0800)]
crimson/net: assert connection gate is not unexpectedly closed
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Tue, 15 Dec 2020 07:42:02 +0000 (15:42 +0800)]
crimson/net: fix test error report
Report unexpected exceptions before destructing the tests.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Tue, 15 Dec 2020 07:14:53 +0000 (15:14 +0800)]
Merge pull request #38570 from rzarzynski/wip-crimson-recover_missing-noopt
crimson/osd: recover_missing() doesn't return std::optional anymore.
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 06:08:04 +0000 (14:08 +0800)]
Merge pull request #38569 from tchaikov/wip-crimson-cleanups
crimson/osd: cleanups
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Tim Serong [Tue, 15 Dec 2020 05:48:57 +0000 (16:48 +1100)]
Merge pull request #38525 from varshar16/wip-ls-nfs-services
mgr/rook: Fix various 'orch ls' issues
Reviewed-by: Travis Nielsen <tnielsen@redhat.com>
Tim Serong [Tue, 15 Dec 2020 05:43:03 +0000 (16:43 +1100)]
Merge pull request #38557 from pcuzner/bootstrap-allocate-output-dir
cephadm: create default output dir during bootstrap
Reviewed-by: Tim Serong <tserong@suse.com>
Kefu Chai [Tue, 15 Dec 2020 05:28:44 +0000 (13:28 +0800)]
Merge pull request #38577 from athanatos/sjust/wip-fix-crimson-nbd
crimson/tools: fix bugs introduced in 3333ff
Reviewed-by: Kefu Chai <kchai@redhat.com>
Aashish Sharma [Tue, 15 Dec 2020 04:35:32 +0000 (10:05 +0530)]
mgr/dashboard: new generic HTTP error page component
Added a generic Error component for HTTP Errors such as 404,403,501
Fixes:https://tracker.ceph.com/issues/39128
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Yingxin Cheng [Tue, 15 Dec 2020 03:52:00 +0000 (11:52 +0800)]
crimson/onode-staged-tree: fix match_stage_t related compile issue
Change the type to int8_t for potential negative value when
substantiating the templates.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Samuel Just [Tue, 15 Dec 2020 03:04:02 +0000 (19:04 -0800)]
crimson/tools: fix bugs introduced in 3333ff
You can't actually mix buffered and direct io on a stream.
Signed-off-by: Samuel Just <sjust@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 01:09:45 +0000 (09:09 +0800)]
Merge pull request #38572 from rzarzynski/wip-crimson-obc-not-blocker
crimson/osd: ObjectContext is not a Blocker anymore.
Reviewed-by: Samuel Just <sjust@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 01:07:12 +0000 (09:07 +0800)]
Merge pull request #38563 from tchaikov/wip-admin-breathe
admin/doc-requirements.txt: require breathe >= 4.20
Reviewed-by: Neha Ojha <nojha@redhat.com>
Kefu Chai [Tue, 15 Dec 2020 01:04:20 +0000 (09:04 +0800)]
Merge pull request #38567 from rzarzynski/wip-doc-dev-errorator
doc/dev/crimson: exemplify errorator usage in error-handling.rst
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 14 Dec 2020 17:45:02 +0000 (01:45 +0800)]
messages,osd,crimson: let MOSDPGPull::take_pulls() return pulls
so the caller can grab the pulls without creating a pull vector first.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 14 Dec 2020 17:32:08 +0000 (01:32 +0800)]
crimson/osd: let build_push_op() return PushOp
for better readability
Signed-off-by: Kefu Chai <kchai@redhat.com>
Samuel Just [Mon, 14 Dec 2020 22:29:26 +0000 (14:29 -0800)]
Merge pull request #38111 from ronen-fr/wip-ronenf-scrub-v2
osd: Extracting scrub-related code from the PG & friends
Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Jason Dillaman [Fri, 11 Dec 2020 00:31:45 +0000 (19:31 -0500)]
rbd-mirror: validate that remote start snapshot still exists
Perform a basic sanity check to verify that the remote start snapshot
still exists. This was previosly being deleted as part of the unlink
process due to a race condition between the remote side completing
a sync between snapshots 1 and 2 and snapshot 2 being unlinked due
to reaching max snapshots.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Samuel Just [Mon, 14 Dec 2020 20:19:16 +0000 (12:19 -0800)]
Merge pull request #38566 from tchaikov/crimson-tools
crimson/tools: use helpers from byteorder.hh
Reviewed-by: Samuel Just <sjust@redhat.com>
Samuel Just [Mon, 14 Dec 2020 20:17:11 +0000 (12:17 -0800)]
Merge pull request #38565 from tchaikov/wip-crimson-cmake
cmake: add alien::cflags and move SubProcess.cc into crimson-alien-common
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Paul Cuzner [Mon, 14 Dec 2020 20:12:36 +0000 (09:12 +1300)]
cephadm: update permissions on newly created dirs
Use 755 instead of 700 on new directories created during
bootstrap
Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
Radoslaw Zarzynski [Mon, 14 Dec 2020 17:10:10 +0000 (18:10 +0100)]
crimson/osd: ObjectContext is not a Blocker anymore.
This is a follow-up to the
c2dc437f78cd8be393c4d2eb8d79ce9c351ec4de
which removes unused OBC mebers after the with_lock() transition.
I'm not sure there is a reason to keep the `Blocker` bits as all
`ObjectContext::dump_detail()` does is just dumping `object_state_t`
while entering the OBC stage is already denoted by `PGPipeline::get_obc`.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Mon, 14 Dec 2020 17:54:11 +0000 (18:54 +0100)]
crimson/osd: recover_missing() doesn't return std::optional anymore.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Mon, 14 Dec 2020 12:46:50 +0000 (20:46 +0800)]
cmake: add "alien::cflags" library
which exposes the definitions needed for building alienized bluestore
and the shared facilities compiled with -DWITH_ALIEN and -DWITH_SEASTAR
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 14 Dec 2020 10:30:29 +0000 (18:30 +0800)]
cmake: move SubProcess.cc from crimson-common to crimson-alien-common
SubProcess is used by blkdev.cc only
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 14 Dec 2020 16:38:05 +0000 (00:38 +0800)]
crimson/osd: let prep_push() return a map of PushOp
ReplicatedRecoveryBackend::prep_push() is responsible for building
PushOps, so it's more natural to let it return a map of PushOp.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 14 Dec 2020 15:56:11 +0000 (23:56 +0800)]
crimson/osd: move unrelated continuation out of do_with()
if the variables held by do_with() is not used by the continuation, and
the continuation does not depend on the other continuations called in
the do_with(), let's move it out for smaller lexical scope. and hence
better readability.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 14 Dec 2020 15:39:07 +0000 (23:39 +0800)]
crimson/osd: mark const method "const"
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 14 Dec 2020 15:26:45 +0000 (23:26 +0800)]
crimson/osd: pass vector<pg_shard_t> for recovery
std::list<std::map<pg_shard_t, pg_missing_t>::const_iterator> is
difficult to parse and understand. and what we need is no more than a
collection of pg_shard_t here. we do the look in
ReplicatedRecoveryBackend::prep_push() again anyway.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 14 Dec 2020 15:14:11 +0000 (23:14 +0800)]
crimson/osd: use range-based for loop
for better readability
Signed-off-by: Kefu Chai <kchai@redhat.com>