]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agodoc: Fix mds capabilities for manual deployment 38666/head
Ivan Jager [Mon, 14 Dec 2020 12:39:00 +0000 (06:39 -0600)]
doc: Fix mds capabilities for manual deployment

Now matches auth-config-ref.rst, and actually works.

Signed-off-by: Ivan Jager <aij+git@mrph.org>
4 years agoMerge pull request #37433 from aclamk/wip-rocksdb-better-options
Kefu Chai [Sat, 12 Dec 2020 04:36:54 +0000 (12:36 +0800)]
Merge pull request #37433 from aclamk/wip-rocksdb-better-options

kv/RocksDBStore: Added ability to set compound options

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #38020 from mdw-at-linuxbox/teuth-fix-x509-san
Kefu Chai [Sat, 12 Dec 2020 04:18:16 +0000 (12:18 +0800)]
Merge pull request #38020 from mdw-at-linuxbox/teuth-fix-x509-san

qa/tasks/openssl_keys.py: add subjectAltName to certificates

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38282 from vosdev/ceph-pool-alert
Kefu Chai [Sat, 12 Dec 2020 04:10:44 +0000 (12:10 +0800)]
Merge pull request #38282 from vosdev/ceph-pool-alert

mgr/prometheus: Fix 'pool filling up' with >50% usage

Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
4 years agoMerge pull request #38290 from athanatos/sjust/wip-transaction-manager-nbd
Kefu Chai [Sat, 12 Dec 2020 03:48:41 +0000 (11:48 +0800)]
Merge pull request #38290 from athanatos/sjust/wip-transaction-manager-nbd

crimson/seastore: add journaling checksumming and nbd based simple perf tester

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge PR #38322 into master
Patrick Donnelly [Sat, 12 Dec 2020 02:59:42 +0000 (18:59 -0800)]
Merge PR #38322 into master

* refs/pull/38322/head:
test_cephfs_shell: add tests for ls command

Reviewed-by: Rishabh Dave <ridave@redhat.com>
4 years agocrimson/os/seastore/journal: fix typo in comment 38290/head
Samuel Just [Fri, 11 Dec 2020 21:27:01 +0000 (13:27 -0800)]
crimson/os/seastore/journal: fix typo in comment

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/segment_manager: allocate page aligned in read helper
Samuel Just [Wed, 25 Nov 2020 05:59:39 +0000 (21:59 -0800)]
crimson/os/seastore/segment_manager: allocate page aligned in read helper

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/cached_extent: always allocate page aligned
Samuel Just [Wed, 25 Nov 2020 05:59:07 +0000 (21:59 -0800)]
crimson/os/seastore/cached_extent: always allocate page aligned

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: remove now unused scan_segment
Samuel Just [Tue, 24 Nov 2020 19:40:30 +0000 (11:40 -0800)]
crimson/os/seastore/journal: remove now unused scan_segment

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore: rework jorunal::scan_extents to use scan_valid_records
Samuel Just [Tue, 24 Nov 2020 19:39:27 +0000 (11:39 -0800)]
crimson/os/seastore: rework jorunal::scan_extents to use scan_valid_records

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: replace scan_segment with scan_valid_records in replay_s...
Samuel Just [Sat, 21 Nov 2020 03:09:54 +0000 (19:09 -0800)]
crimson/os/seastore/journal: replace scan_segment with scan_valid_records in replay_segment

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: add scan_valid_records
Samuel Just [Sat, 21 Nov 2020 03:09:25 +0000 (19:09 -0800)]
crimson/os/seastore/journal: add scan_valid_records

scan_valid_records validates record checksums and uses last_comitted
to avoid checking data crcs except on the final few records.  Will
replace scan_segment in a few patches.

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #38444 from tchaikov/wip-msgr-string-view
Kefu Chai [Sat, 12 Dec 2020 00:17:02 +0000 (08:17 +0800)]
Merge pull request #38444 from tchaikov/wip-msgr-string-view

msg/async: drop unused member variable

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #38439 from adk3798/iscsi-stuff
Sebastian Wagner [Sat, 12 Dec 2020 00:09:14 +0000 (01:09 +0100)]
Merge pull request #38439 from adk3798/iscsi-stuff

mgr/cephadm: improve iscsi dashboard config

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Kiefer Chang <kiefer.chang@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #38533 from sebastian-philipp/cephadm-mypy-no-untyped
Sebastian Wagner [Sat, 12 Dec 2020 00:07:12 +0000 (01:07 +0100)]
Merge pull request #38533 from sebastian-philipp/cephadm-mypy-no-untyped

mgr/cephadm: disallow_untyped_defs=True

Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #38544 from tchaikov/wip-build-doc-auto-build
Kefu Chai [Sat, 12 Dec 2020 00:05:24 +0000 (08:05 +0800)]
Merge pull request #38544 from tchaikov/wip-build-doc-auto-build

admin/build-doc: add livehtml target

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson/os/seastore/journal: try_decode* pass bl as const &
Samuel Just [Sat, 21 Nov 2020 03:08:05 +0000 (19:08 -0800)]
crimson/os/seastore/journal: try_decode* pass bl as const &

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: validate header crc on read
Samuel Just [Sat, 21 Nov 2020 03:07:36 +0000 (19:07 -0800)]
crimson/os/seastore/journal: validate header crc on read

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/lba_manager/btree/btree_range_pin: remove obsolete assert
Samuel Just [Sat, 21 Nov 2020 02:23:26 +0000 (02:23 +0000)]
crimson/os/seastore/lba_manager/btree/btree_range_pin: remove obsolete assert

In the event that the only two children of the root are merged, they
as well as the old root will be retired meaning that check_parent
will find no parent.

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: maintain committed_to on each record
Samuel Just [Thu, 19 Nov 2020 21:08:17 +0000 (13:08 -0800)]
crimson/os/seastore/journal: maintain committed_to on each record

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: use specified size types for header
Samuel Just [Thu, 19 Nov 2020 21:07:59 +0000 (13:07 -0800)]
crimson/os/seastore/journal: use specified size types for header

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: fix debugging lines
Samuel Just [Thu, 19 Nov 2020 21:07:27 +0000 (13:07 -0800)]
crimson/os/seastore/journal: fix debugging lines

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: add data and metadata checksums
Samuel Just [Thu, 19 Nov 2020 21:06:10 +0000 (13:06 -0800)]
crimson/os/seastore/journal: add data and metadata checksums

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/.../lba_btree_node: collapse root on merge if down to one element
Samuel Just [Fri, 6 Nov 2020 23:00:20 +0000 (15:00 -0800)]
crimson/os/seastore/.../lba_btree_node: collapse root on merge if down to one element

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/.../lba_btree_node_impl: fix merge_entry return values
Samuel Just [Fri, 6 Nov 2020 04:17:09 +0000 (20:17 -0800)]
crimson/os/seastore/.../lba_btree_node_impl: fix merge_entry return values

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: check segment nonce in scan_segment
Samuel Just [Fri, 6 Nov 2020 00:10:10 +0000 (00:10 +0000)]
crimson/os/seastore/journal: check segment nonce in scan_segment

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: factor out read_segment_header
Samuel Just [Fri, 6 Nov 2020 00:04:49 +0000 (16:04 -0800)]
crimson/os/seastore/journal: factor out read_segment_header

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: propogate segment headers with replay segments
Samuel Just [Thu, 5 Nov 2020 23:29:15 +0000 (15:29 -0800)]
crimson/os/seastore/journal: propogate segment headers with replay segments

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: record segment/record nonces based on seastore_id
Samuel Just [Thu, 5 Nov 2020 23:11:35 +0000 (15:11 -0800)]
crimson/os/seastore/journal: record segment/record nonces based on seastore_id

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agoinclude/uuid: make bytes() return const *
Samuel Just [Thu, 5 Nov 2020 23:11:17 +0000 (15:11 -0800)]
include/uuid: make bytes() return const *

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/segment_manager: add seastore_meta_t with uuid
Samuel Just [Wed, 4 Nov 2020 03:37:10 +0000 (19:37 -0800)]
crimson/os/seastore/segment_manager: add seastore_meta_t with uuid

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agoinclude/uuid: convert to denc
Samuel Just [Thu, 5 Nov 2020 22:14:04 +0000 (14:14 -0800)]
include/uuid: convert to denc

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/segment_manger/ephemeral: add final annotations
Samuel Just [Wed, 4 Nov 2020 21:31:59 +0000 (13:31 -0800)]
crimson/os/seastore/segment_manger/ephemeral: add final annotations

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore: use unqualified en/decode for denc types
Samuel Just [Wed, 4 Nov 2020 03:36:57 +0000 (19:36 -0800)]
crimson/os/seastore: use unqualified en/decode for denc types

Otherwise, if definitions from encoding.h are in scope the templated
denc one won't be considered.

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: fix error returns in replay
Samuel Just [Sat, 31 Oct 2020 00:04:32 +0000 (17:04 -0700)]
crimson/os/seastore/journal: fix error returns in replay

SegmentManager is allowed to return an enoent if the segment isn't
readable.

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/.../ephemeral: introduce pauses for testing
Samuel Just [Sat, 31 Oct 2020 00:03:33 +0000 (17:03 -0700)]
crimson/os/seastore/.../ephemeral: introduce pauses for testing

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/os/seastore/journal: send aligned buffer in initialize_segment
Samuel Just [Sat, 31 Oct 2020 00:03:04 +0000 (17:03 -0700)]
crimson/os/seastore/journal: send aligned buffer in initialize_segment

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agocrimson/tools/: add really simple nbd driver for TransactionManager
Samuel Just [Sat, 31 Oct 2020 00:00:01 +0000 (17:00 -0700)]
crimson/tools/: add really simple nbd driver for TransactionManager

Signed-off-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #38413 from pcuzner/fix-yaml-error
pcuzner [Fri, 11 Dec 2020 20:00:12 +0000 (09:00 +1300)]
Merge pull request #38413 from pcuzner/fix-yaml-error

orchestrator: validate osd yaml

4 years agoMerge PR #38511 into master
Patrick Donnelly [Fri, 11 Dec 2020 17:47:35 +0000 (09:47 -0800)]
Merge PR #38511 into master

* refs/pull/38511/head:
qa/tasks/cephfs/nfs: Check if host ip is in cluster info output

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoadmin/build-doc: upgrade pip setuptools first 38544/head
Kefu Chai [Fri, 11 Dec 2020 16:22:37 +0000 (00:22 +0800)]
admin/build-doc: upgrade pip setuptools first

on certain distros, buggy pip and setuptools are used, so we need to
upgrade them first.

see also: googleapis/google-cloud-python#2990 and pypa/setuptools#885

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38519 from rhcs-dashboard/fix-47727-master
Ernesto Puerta [Fri, 11 Dec 2020 16:14:50 +0000 (17:14 +0100)]
Merge pull request #38519 from rhcs-dashboard/fix-47727-master

mgr/dashboard: RGW User Form is validating disabled fields

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #38125 from rhcs-dashboard/improve-CRUSH-info-columns
Ernesto Puerta [Fri, 11 Dec 2020 16:08:35 +0000 (17:08 +0100)]
Merge pull request #38125 from rhcs-dashboard/improve-CRUSH-info-columns

mgr/dashboard: Replace Replica size and Erasure code profile with a single column

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #38494 from dillaman/wip-45694
Mykola Golub [Fri, 11 Dec 2020 15:40:12 +0000 (17:40 +0200)]
Merge pull request #38494 from dillaman/wip-45694

librbd: fix sporadic failures in TestMigration.StressLive

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #38515 from tchaikov/wip-script-run-cbt
Kefu Chai [Fri, 11 Dec 2020 14:34:53 +0000 (22:34 +0800)]
Merge pull request #38515 from tchaikov/wip-script-run-cbt

script/run-cbt.sh: drop bashism

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoadmin/build-doc: add livehtml target
Kefu Chai [Fri, 11 Dec 2020 13:33:41 +0000 (21:33 +0800)]
admin/build-doc: add livehtml target

it is time-consuming to rebuild the python bindings every time we
rebuild the document, it'd be ideal if we could just build document.

in this change, in addition to "html" and "doc", "livehtml" argument is
now supported by build-doc script, so one can just use

./build-doc livehtml

to build and start a web server. whenever a change in doc/ is detected,
the document is rebuilt. for more details, see
https://pypi.org/project/sphinx-autobuild/

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agolibrbd/deep_copy: added new migrating flag to object copy 38494/head
Jason Dillaman [Tue, 8 Dec 2020 19:16:49 +0000 (14:16 -0500)]
librbd/deep_copy: added new migrating flag to object copy

The migration operation and the copyup state machine will set
this flag when attempting to perform a deep-copy due to a
live-migration.

This flag will prevent a possible race condition between the
start of the object deep-copy when migration was enabled and
the writing portion of the deep-copy when migration might
have completed via external means.

Fixes: https://tracker.ceph.com/issues/45694
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd/deep_copy: added bitwise flag parameter to object copy
Jason Dillaman [Tue, 8 Dec 2020 18:11:20 +0000 (13:11 -0500)]
librbd/deep_copy: added bitwise flag parameter to object copy

This initial version subsumes the original "flatten" boolean flag.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38486 from Rjerk/fix-mds-conf-typo
Kefu Chai [Fri, 11 Dec 2020 12:46:24 +0000 (20:46 +0800)]
Merge pull request #38486 from Rjerk/fix-mds-conf-typo

doc: fix a couple of typos

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #38542 from SMIL-Infra/wip-doc-conf-typo
Kefu Chai [Fri, 11 Dec 2020 12:41:54 +0000 (20:41 +0800)]
Merge pull request #38542 from SMIL-Infra/wip-doc-conf-typo

doc: Fixes a typo in mon_dns_srv_name.

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38517 from dillaman/wip-48525
Mykola Golub [Fri, 11 Dec 2020 10:13:41 +0000 (12:13 +0200)]
Merge pull request #38517 from dillaman/wip-48525

rbd-mirror: bad state and crashes in snapshot-based mirroring

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agoMerge pull request #38492 from dillaman/wip-librbd-io-tweaks
Mykola Golub [Fri, 11 Dec 2020 10:12:04 +0000 (12:12 +0200)]
Merge pull request #38492 from dillaman/wip-librbd-io-tweaks

librbd: minor fix to IO shut-down and increased IO logging

Reviewed-by: Mykola Golub <mgolub@suse.com>
4 years agodoc: Fixes a typo in mon_dns_srv_name. 38542/head
胡玮文 [Fri, 11 Dec 2020 09:16:14 +0000 (17:16 +0800)]
doc: Fixes a typo in mon_dns_srv_name.

Signed-off-by: 胡玮文 <huww98@outlook.com>
4 years agoMerge pull request #38480 from yician1000/fix_48488
Kefu Chai [Fri, 11 Dec 2020 08:08:31 +0000 (16:08 +0800)]
Merge pull request #38480 from yician1000/fix_48488

mgr/restful: fix TypeError occurring in _gather_osds()

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38384 from bk201/wip-48406
Kefu Chai [Fri, 11 Dec 2020 08:07:03 +0000 (16:07 +0800)]
Merge pull request #38384 from bk201/wip-48406

mgr/dashboard: fix test_dashboard_e2e.sh errors

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #37785 from lxbsz/conf1
Kefu Chai [Fri, 11 Dec 2020 08:04:51 +0000 (16:04 +0800)]
Merge pull request #37785 from lxbsz/conf1

common/config: do not expand the pid for socket admin

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38417 from changchengx/osdmap
Kefu Chai [Fri, 11 Dec 2020 08:04:00 +0000 (16:04 +0800)]
Merge pull request #38417 from changchengx/osdmap

osd/OSDMonitor: correct duplicated output info

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Joao Eduardo Luis <joao@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #38453 from b-ranto/wip-crash-serial
Kefu Chai [Fri, 11 Dec 2020 08:00:35 +0000 (16:00 +0800)]
Merge pull request #38453 from b-ranto/wip-crash-serial

mgr/crash: Serialize command handling

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 years agoMerge pull request #38501 from tchaikov/wip-cmake-crimson-test
Kefu Chai [Fri, 11 Dec 2020 07:52:22 +0000 (15:52 +0800)]
Merge pull request #38501 from tchaikov/wip-cmake-crimson-test

test/crimson: do not link against crimson-{os,common}

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #38516 from tchaikov/wip-cmake-rocksdb
Kefu Chai [Fri, 11 Dec 2020 04:47:51 +0000 (12:47 +0800)]
Merge pull request #38516 from tchaikov/wip-cmake-rocksdb

cmake: stop rebuilding rocksdb everytime

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoorchestrator: drop redundant try/except 38413/head
Paul Cuzner [Fri, 11 Dec 2020 04:25:08 +0000 (17:25 +1300)]
orchestrator: drop redundant try/except

YAML is validated up front, so the additional try/except
clause is not needed.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
4 years agoMerge pull request #35314 from zdover23/wip-doc-elasticsearch-7-warning
Josh Durgin [Fri, 11 Dec 2020 02:54:51 +0000 (18:54 -0800)]
Merge pull request #35314 from zdover23/wip-doc-elasticsearch-7-warning

doc/radosgw: Note that ElasticSearch 7 doesn't work. Just 6 and lower.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #38523 from tchaikov/wip-gcc-toolset-9
Kefu Chai [Fri, 11 Dec 2020 02:41:53 +0000 (10:41 +0800)]
Merge pull request #38523 from tchaikov/wip-gcc-toolset-9

install-deps.sh: do not use gcc-toolset-9 from copr

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 years agoMerge pull request #38157 from sebastian-philipp/labeler-orchestrator
Kefu Chai [Fri, 11 Dec 2020 00:59:09 +0000 (08:59 +0800)]
Merge pull request #38157 from sebastian-philipp/labeler-orchestrator

github/labeler: Add some more to cephadm, add orchestrator

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38408 from trociny/wip-rbd-group-snap-create2
Jason Dillaman [Thu, 10 Dec 2020 23:06:50 +0000 (18:06 -0500)]
Merge pull request #38408 from trociny/wip-rbd-group-snap-create2

librbd: extend group snap create API to support flags

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38518 from trociny/wip-rbd-test-memleak
Jason Dillaman [Thu, 10 Dec 2020 23:06:24 +0000 (18:06 -0500)]
Merge pull request #38518 from trociny/wip-rbd-test-memleak

test/librbd: fix memory leak in TestLibRBD.ConcurentOperations

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #38490 from sebastian-philipp/mypy-0.790
Sebastian Wagner [Thu, 10 Dec 2020 21:41:47 +0000 (22:41 +0100)]
Merge pull request #38490 from sebastian-philipp/mypy-0.790

src,qa,dashboard: Upgrade to mypy 0.790

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #38075 from joke-lee/s3-auth-date-fix
Harish Munjulur [Thu, 10 Dec 2020 19:49:37 +0000 (11:49 -0800)]
Merge pull request #38075 from joke-lee/s3-auth-date-fix

rgw: fix RequestTimeTooSkewed when Date contain RFC-822/ISO 8601 standard timezone

4 years agoMerge pull request #37926 from BryceCao/wip-catch-non-int-exception
Harish Munjulur [Thu, 10 Dec 2020 19:48:47 +0000 (11:48 -0800)]
Merge pull request #37926 from BryceCao/wip-catch-non-int-exception

rgw : catch non int exception

4 years agoMerge pull request #37909 from alexandrsushko/prometheus-pg-laggy-46142
Kefu Chai [Thu, 10 Dec 2020 15:53:48 +0000 (23:53 +0800)]
Merge pull request #37909 from alexandrsushko/prometheus-pg-laggy-46142

mgr: Fix for dashboard/prometheus failure due to laggy pg state

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
4 years agoMerge pull request #38131 from linuxbox2/wip-lc-ix
J. Eric Ivancich [Thu, 10 Dec 2020 15:06:40 +0000 (10:06 -0500)]
Merge pull request #38131 from linuxbox2/wip-lc-ix

rgwlc: correctly dimension lc shard index vector

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
4 years agomgr/cephadm: disallow_untyped_defs=True 38533/head
Sebastian Wagner [Thu, 10 Dec 2020 14:53:00 +0000 (15:53 +0100)]
mgr/cephadm: disallow_untyped_defs=True

simplifies mypy.ini

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agogithub/labeler: Add some more to cephadm, add orchestrator 38157/head
Sebastian Wagner [Wed, 18 Nov 2020 11:29:50 +0000 (12:29 +0100)]
github/labeler: Add some more to cephadm, add orchestrator

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #38524 from tchaikov/wip-crimson-qa-rbd
Kefu Chai [Thu, 10 Dec 2020 14:18:39 +0000 (22:18 +0800)]
Merge pull request #38524 from tchaikov/wip-crimson-qa-rbd

qa/suites: add crimson-rados/rbd test suites

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoMerge pull request #38470 from sebastian-philipp/cephadm-command-unit-verbose
Sebastian Wagner [Thu, 10 Dec 2020 14:14:19 +0000 (15:14 +0100)]
Merge pull request #38470 from sebastian-philipp/cephadm-command-unit-verbose

cephadm: command_unit: call systemctl with verbose=True

Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoMerge pull request #38009 from ideepika/wip-48058-cephadm
Sebastian Wagner [Thu, 10 Dec 2020 14:13:42 +0000 (15:13 +0100)]
Merge pull request #38009 from ideepika/wip-48058-cephadm

qa/tasks/cephadm: update_info_yam() only if ctx.archive is valid

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #36551 from CongMinYin/immutable_object_cache_throttle
Jason Dillaman [Thu, 10 Dec 2020 14:07:16 +0000 (09:07 -0500)]
Merge pull request #36551 from CongMinYin/immutable_object_cache_throttle

tools: add throttle mechanism to immutable object cache

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agorbd-mirror: do not attempt to unlink from more recent snapshots 38517/head
Jason Dillaman [Thu, 10 Dec 2020 04:17:24 +0000 (23:17 -0500)]
rbd-mirror: do not attempt to unlink from more recent snapshots

The snapshot-based mirroring replayer should only attempt to unlink
from any snapshots that are older than the end remote snapshot id to
prevent the remote side from incorrectly deleted the snapshot.

Fixes: https://tracker.ceph.com/issues/48527
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agolibrbd/mirror: unlink peer might recursively loop
Jason Dillaman [Thu, 10 Dec 2020 03:30:17 +0000 (22:30 -0500)]
librbd/mirror: unlink peer might recursively loop

If the mirror peer set is (incorrectly) empty, it's not currently
possible for the unlink peer state machine to properly delete the
snapshot. This can result in a recursive loop between the create
primary snapshot state machine and the unlink peer state machine
until the stack depth grows too large.

Fixes: https://tracker.ceph.com/issues/48525
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
4 years agoqa/suites: add crimson-rados/rbd test suites 38524/head
Kefu Chai [Thu, 10 Dec 2020 11:36:15 +0000 (19:36 +0800)]
qa/suites: add crimson-rados/rbd test suites

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38435 from votdev/issue_48449_test_standby
Ernesto Puerta [Thu, 10 Dec 2020 12:25:03 +0000 (13:25 +0100)]
Merge pull request #38435 from votdev/issue_48449_test_standby

mgr/dashboard: test_standby* (tasks.mgr.test_dashboard.TestDashboard) failed locally

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #38441 from bk201/wip-48455
Ernesto Puerta [Thu, 10 Dec 2020 12:23:46 +0000 (13:23 +0100)]
Merge pull request #38441 from bk201/wip-48455

mgr/dashboard: adjust refresh intervals of Services and Daemons

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #38212 from sebastian-philipp/mgr-cephadm-type-annotations-mandato...
Sebastian Wagner [Thu, 10 Dec 2020 12:15:57 +0000 (13:15 +0100)]
Merge pull request #38212 from sebastian-philipp/mgr-cephadm-type-annotations-mandatory-module

mgr/cephadm: make type annotations for module.py mandatory

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
4 years agoinstall-deps.sh: do not use gcc-toolset-9 from copr 38523/head
Kefu Chai [Thu, 10 Dec 2020 10:48:24 +0000 (18:48 +0800)]
install-deps.sh: do not use gcc-toolset-9 from copr

since both CentOS and RHEL now include the updated
gcc-toolset-9-gcc-9.2.1-2.3.el8.

see also https://bugzilla.redhat.com/show_bug.cgi?id=1853900

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: use correct fmt string in logger().debug(...) 38501/head
Kefu Chai [Thu, 10 Dec 2020 07:17:56 +0000 (15:17 +0800)]
crimson/osd: use correct fmt string in logger().debug(...)

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: exclude unit tests from the "all" target
Kefu Chai [Thu, 10 Dec 2020 06:54:10 +0000 (14:54 +0800)]
cmake: exclude unit tests from the "all" target

no need to build unit tests when "make all", unless required explicitly,
like "make tests".

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agosrc/*: do not pass cct to ceph_version_to_str()
Kefu Chai [Thu, 10 Dec 2020 06:17:07 +0000 (14:17 +0800)]
src/*: do not pass cct to ceph_version_to_str()

in e5b1ae5554c4d8a20f9f0ff562b231ad0b0ba0ab, a new option named
"debug_version_for_testing" is introduced to override the version so
we can test version check.

in crimson, we have two families of shared functions.

- one of them is used by alien store. they are compiled with
  -DWITH_SEASTAR and -DWITH_ALIEN, to enable the shim code between
  seastar and POSIX thread.
- another is used by crimson in general. where no lock is allowed.

currently, we use the "crimson" and "ceph" namespace to differentiate
these two families of functions, so they can colocate in the same
executable without violating the ODR. see src/include/common_fwd.h for
more details.

the functions defined in src/common/version.cc are also shared by
alien store and crimson code. and because we have different
implementations of `CephContext` in crimson and in classic OSD (i.e.
alienstore), we have to have different implementations of this function
as well, if we follow the same approach. but since these functions are
very simple and are non-blocking, there is not much value in
differentiating them, it is better to inject the test settings using
environment variable instead of using ceph option subsystem.

in this change, "ceph_debug_version_for_testing" environment variable is
checked instead, so that crimson and alienstore can share the same
compilation unit of version.cc. and "debug_version_for_testing" option
is removed.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: reorder linked libraries of crimson-alienstore
Kefu Chai [Wed, 9 Dec 2020 16:13:15 +0000 (00:13 +0800)]
cmake: reorder linked libraries of crimson-alienstore

so the libraries like libkv can access the symbols exposed by
crimson-alien-common.

this change should address the link failures like:

/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.0.0-8049-g1ab93e4d/rpm/el8/BUILD/ceph-16.0.0-8049-g1ab93e4d/src/common/PriorityCache.cc:175:
undefined reference to `ceph::common::PerfCountersBuilder::~PerfCountersBuilder()'

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: do not link crimson-alienstore against crimson-os
Kefu Chai [Wed, 9 Dec 2020 11:39:19 +0000 (19:39 +0800)]
cmake: do not link crimson-alienstore against crimson-os

crimson-os contains crimson-alienstore, we should not link the latter
against the former. this change partially reverts
490b6322fbbece053f1d92b29ae101bfb0976007

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: link unittest-seastar-alienstore-thread-pool against crimson-alienstore
Kefu Chai [Wed, 9 Dec 2020 11:30:20 +0000 (19:30 +0800)]
cmake: link unittest-seastar-alienstore-thread-pool against crimson-alienstore

no need to link it against crimson-os in a wholesale, crimson-alienstore
would be enough.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agotest/crimson: do not link against crimson-{os,common}
Kefu Chai [Wed, 9 Dec 2020 09:42:43 +0000 (17:42 +0800)]
test/crimson: do not link against crimson-{os,common}

this change partially reverts 652dbacc7424efbd3c3175de8ba79ed29edd55c8
quite a few test does not use crimson-os at all, so no need to link
against this library.

even worse is that crimson-os contains crimson-seastore *and*
crimson-alienstore. this introduces cyclic references.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agorbd: make "group snap create" support quiesce options 38408/head
Mykola Golub [Wed, 9 Dec 2020 05:07:42 +0000 (05:07 +0000)]
rbd: make "group snap create" support quiesce options

Signed-off-by: Mykola Golub <mgolub@suse.com>
4 years agolibrbd: extend group snap create API to support flags
Mykola Golub [Wed, 2 Dec 2020 17:43:16 +0000 (17:43 +0000)]
librbd: extend group snap create API to support flags

Signed-off-by: Mykola Golub <mgolub@suse.com>
4 years agomgr/dashboard: RGW User Form is validating disabled fields 38519/head
Aashish Sharma [Thu, 10 Dec 2020 06:00:36 +0000 (11:30 +0530)]
mgr/dashboard: RGW User Form is validating disabled fields

When you try to submit a non valid form, angular is checking all the fields of the form, resulting in some wrong validations.

Fixes:https://tracker.ceph.com/issues/47727
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
4 years agotest/librbd: fix memory leak in TestLibRBD.ConcurentOperations 38518/head
Mykola Golub [Thu, 10 Dec 2020 06:00:34 +0000 (06:00 +0000)]
test/librbd: fix memory leak in TestLibRBD.ConcurentOperations

Signed-off-by: Mykola Golub <mgolub@suse.com>
4 years agopybind/mgr/prometheus/module.py: defaultdict for num_by_state 37909/head
Alexander Sushko [Fri, 27 Nov 2020 11:04:13 +0000 (14:04 +0300)]
pybind/mgr/prometheus/module.py: defaultdict for num_by_state

num_by_state[state] += count in get_pg_status method raises KeyError
if pg state is not in PG_STATES list. PG_STATES should be synced with
osd_types.cc:pg_state_string(). But sometimes it is not. After the
KeyError raise mgr metrics are not available at all.

Fixes: https://tracker.ceph.com/issues/46142
Signed-off-by: Alexander Sushko <alexandrsushko@gmail.com>
4 years agocmake: stop rebuilding rocksdb everytime 38516/head
Kefu Chai [Thu, 10 Dec 2020 04:22:48 +0000 (12:22 +0800)]
cmake: stop rebuilding rocksdb everytime

this change was originally introduced as a part of
418bfd7bb5ec1dcec2b011e9df118c33ce38d398, and latter migrated / changed
in the current form. but the idea is the same: to rebuild rocksdb even
if the stamp file shows that it has been built. there is no need to do
so, as we don't hack RocksDB as we used to. also,it is distracting to
check this log message when rebuilding the tree. so drop it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38431 from tchaikov/wip-rtd-doc
Kefu Chai [Thu, 10 Dec 2020 04:03:21 +0000 (12:03 +0800)]
Merge pull request #38431 from tchaikov/wip-rtd-doc

pybind,doc: build stub using cython and build API doc with RTD

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@hotmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoscript/run-cbt.sh: drop bashism 38515/head
Kefu Chai [Thu, 10 Dec 2020 03:13:55 +0000 (11:13 +0800)]
script/run-cbt.sh: drop bashism

* "local" is not supported by POSIX shell, so drop it
* assign "$*" to a non-array variable, see
  https://github.com/koalaman/shellcheck/wiki/SC2124
* fail early if "cd" fails, see
  https://github.com/koalaman/shellcheck/wiki/SC2164
* quote "$(...)" with quotes to avoid string split

Signed-off-by: Kefu Chai <kchai@redhat.com>