auth/CephxClientHandler: explain why skipping extra_tickets is needed

Since nautilus, CEPHX_GET_AUTH_SESSION_KEY shares both the auth ticket
and the service tickets, sparing an extra round-trip to get the service
tickets via CEPHX_GET_PRINCIPAL_SESSION_KEY.  This applies to msgr1 as
well, but we don't take advantage of it on the client side.

However, fixing CephxClientHandler to do the right thing breaks msgr1.
Since msgr1 is on its way out, rather than also fixing MonClient just
document the bug and the current behaviour.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #40466 from inspur-wyq/patch-2

blk/spdk/NVMEDevice.cc:  remove unused variables

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40188 from rhcs-dashboard/fix-49869-master

mgr/dashboard: fix broken feature toggles

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38679 from ceph/dependabot/npm_and_yarn/src/pybind/mgr/dashboard/frontend/node-notifier-8.0.1

build(deps): bump node-notifier from 8.0.0 to 8.0.1 in /src/pybind/mgr/dashboard/frontend

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #39908 from rhcs-dashboard/fix-49645-master

mgr/dashboard: Remove username, password fields from Manager Modules/dashboard,influx

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #40023 from rhcs-dashboard/fix-49354-master

mgr/dashboard: Device health status is not getting listed under hosts section

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #40332 from rhcs-dashboard/prometheus-alert-notification-fix

mgr/dashboard: Fix for alert notification message being undefined

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #39917 from rhcs-dashboard/fix-43058-master

mgr/dashboard: warn password expiration in User Management

blk/spdk/NVMEDevice.cc:  remove unused variables

Signed-off-by: wangyunqing <wangyunqing@inspur.com>

Merge pull request #40240 from rhcs-dashboard/clear-cookies-on-logout

mgr/dashboard: Unable to login to ceph dashboard until clearing cookies manually

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #40458 from lxbsz/typo

client: fix typo in the comments

client: fix typo in the comments

Signed-off-by: Xiubo Li <xiubli@redhat.com>

Merge pull request #40445 from liewegas/cephadm-upgrade-progress-version

mgr/cephadm: make upgrade progress bar mention target version, not repo digest

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #40447 from Daniel-Pivonka/cephadmdocapplyrgwflags

mgr/orchestrator: fix rgw realm and zone flags

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #40379 from adk3798/no-overwrite

mgr/cephadm: --no-overwite flag for apply command

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #39969 from batrick/i49684

qa: wait for daemons to come up via cephadm

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #40396 from maydaycc/wip-49968

mgr: attr_list reassigned before use in diskprediction_local module

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40421 from badone/wip-fix-typo-get_device_id

common/blkdev: Remove trailing single quote

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40450 from smithfarm/wip-50007-alt

rpm: drop extraneous explicit sqlite-libs runtime dependency

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

rpm: drop extraneous explicit sqlite-libs runtime dependency

Commit 75980798f19b8c11efd75ba4aae3e491d4c99f98 introduced a new package,
libcephsqlite, with a hard RPM dependency on a package "sqlite-libs" which
does not exist in openSUSE.

Since the runtime library dependencies of libcephsqlite are handled by RPM
transparently, this line is not needed.

Fixes: https://tracker.ceph.com/issues/50007
Signed-off-by: Nathan Cutler <ncutler@suse.com>

Merge pull request #40442 from Thingee/update-foundation-page

doc: Update Foundation page

Reviewed-by: Sage Weil <sage@redhat.com>

doc: Updating Foundation membership page

Signed-off-by: Mike Perez <thingee@gmail.com>

Merge pull request #40408 from varshar16/wip-doc-update-ninja

doc/install: update about ninja

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40345 from rzarzynski/wip-crimson-doc-waitstates-follow-up

doc/crimson: improve wording about the pipeline / wait states.

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge PR #38732 into master

* refs/pull/38732/head:
client: fire the finish_cap_snap() after buffer being flushed
client: simplify the iterating code
client: remove unused _flushed_cap_snap
client: clean up the code

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #40326 into master

* refs/pull/40326/head:
client: rebuild bl to avoid too many vector(> IOV_MAX)

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>

Merge PR #40394 into master

* refs/pull/40394/head:
osd: handle MOSDPGInfo
osd/PeeringState: init last_require_osd_release in ctor

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

doc/cephadm: fix rgw realm and zone flags

Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>

Merge pull request #40415 from sseshasa/wip-qa-wait-for-clean-check

qa/tasks: Add wait_for_clean() check prior to initiating scrubbing.

Reviewed-by: Neha Ojha <nojha@redhat.com>

mgr/cephadm: make upgrade progress bar mention target version, not repo digest

The repo digest is super long and meaningless for a human user.  Instead,
use the target version (as soon as we know what it is--until then, use
the target image name).

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #40438 from idryomov/wip-crimson-reopen-session

crimson/monc: discard active/pending connections when reopening

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/monc: discard active/pending connections when reopening

Otherwise pending_conns vector just keeps growing with redundant
connections all trying to reach the same set of monitors.  When one
of the attempts finally succeeds, _finish_auth() will pick the first
connection with a matching entity_addr_t, designate it as active and
close all others.  The match is very likely to be wrong and hence the
actual authenticated connection gets closed, leaving the OSD with
a bogus active_con and no monitor session.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge PR #40404 into master

* refs/pull/40404/head:
auth: require CEPHX_V2 by default

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #40321 into master

* refs/pull/40321/head:
cephadm: fix parsing of keepalived version (drop leading 'v')
cephadm: keepalived needs --cap-add=NET_RAW
cephadm: fix --cap-add=NET_ADMIN
cephadm: fix quoting for keepalived env var
mgr/cephadm: ha-rgw: use correct port

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge PR #40015 into master

* refs/pull/40015/head:
cephadm: validate fsid during cephadm shell command

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>

Merge PR #40341 into master

* refs/pull/40341/head:
os/bluestore: separate omap per-pool vs per-pg alerts

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #40429 from varshar16/wip-fix-fs-top-error

src/tools/cephfs-top: fix flake8 line too long error

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #40401 from lnussel/master

ceph.spec: prepare openSUSE usrmerge (boo#1029961)

src/tools/cephfs-top: fix flake8 line too long error

Fixes: https://tracker.ceph.com/issues/50005
Signed-off-by: Varsha Rao <varao@redhat.com>

mgr/dashboard: Unable to login to ceph dashboard until clearing cookies

Fixes: https://tracker.ceph.com/issues/49897
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Clears the cookie for token after logout.

Merge pull request #40170 from Rethan/fix-sync-pause-max-lat

os/FileStore: fix sync_pause_max_lat which should not be inced

Reviewed-by: Kefu Chai <kchai@redhat.com>

README.md: remove extra 'the' and format para related to ninja

Signed-off-by: Varsha Rao <varao@redhat.com>

doc/install: replace do_cmake note with link to ceph README

Ceph README.md doc already has the do_cmake note and other build related info.

Signed-off-by: Varsha Rao <varao@redhat.com>

doc/install: Update about ninja

'ninja' replaced 'make' in this PR[1]. This patch updates the doc about it.

[1] https://github.com/ceph/ceph/pull/39826

Signed-off-by: Varsha Rao <varao@redhat.com>

Merge pull request #40334 from dvanders/pick

common/ipaddr: skip loopback interfaces named 'lo' and test it

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #40292 from tchaikov/wip-39191

debian,cmake,cephsqlite: hide non-public symbols

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #40171 from swegener/bluefs-assert-always-true

bluefs: fix assert always being true

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40304 from tchaikov/wip-telegraph-ann

pybind/mgr/telegraf: add type annotations

Reviewed-by: Wido den Hollander <wido@widodh.nl>

Merge pull request #40403 from vshankar/wip-cephfs-top-add-metrics

cephfs-top: include additional metrics reported by `fs perf stats`

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #40167 from singuliere/wip-49781

common/mempool: only fail tests if sharding is very bad

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

common/blkdev: Remove trailing single quote

Example output:

e1 collect_metadata :  no unique device id for : fallback method has no
model nor serial'

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #40331 from athanatos/sjust/wip-seatore-gc-refactor

crimson/seastore: refactor gc into concurrent task

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #40336 from tchaikov/wip-cmake-fio

cmake: pass compile options by fio interface library

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #40323 from aclamk/wip-onode-resiliant-to-split-cache

os/bluestore: Make Onode::put/get resiliant to split_cache

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>

mgr/volumes: do not overwrite existant mds specs

Signed-off-by: Adam King <adking@redhat.com>

crimson/os/seastore/segment_cleaner: bump reclaim_ratio limits

GC behavior still needs a ton of work, but this adjustment should
reduce gc activity for now until we have time to refine the params
and introduce the ability to write cold extents to a segment other
than the current journal segment.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/.../btree_range_pin: use ceph_assert

There's a performance overhead, but seastore is quite immature and
detecting these logic errors saves a ton of debugging time.

Signed-off-by: Samuel Just <sjust@redhat.com>

crimson/os/seastore/.../block.cc: add error message on alloc error to segment_write

Signed-off-by: Samuel Just <sjust@redhat.com>

mgr/cephadm: no-overwite flag for apply command

no-overwrite flag makes it so cephadm will only apply the spec
if the spec does not already exist.

Signed-off-by: Adam King <adking@redhat.com>

mgr/dashboard: warn user's password expiration in user management
Warn about user's incoming password expiration on the User Management with an icon.
Fixes: https://tracker.ceph.com/issues/43058
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>

qa/tasks: Add wait_for_clean() check prior to initiating scrubbing.

Fixes: https://tracker.ceph.com/issues/49983
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>

Merge pull request #39776 from alimaredia/wip-rgw-log-req-latency

rgw: add latency to the request summary of an op

cephadm: validate fsid during cephadm shell command

Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>

Merge PR #40366 into master

* refs/pull/40366/head:
mgr/cephadm: Fix dashboard gateway configuration when using IPV6

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #40395 from rhcs-dashboard/fix-49952-master

mgr/dashboard:Simplify some complex calculations in test_alerts.yml

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>

auth: require CEPHX_V2 by default

It's been almost three years and support is present in all relevant
clients.

From the security perspective, roughly the same could be achieved
with "ceph osd set-require-min-compat-client nautilus", but this is
more user friendly as the client gets ENOTSUP instead of spinning on
"feature set mismatch" faults.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

cephfs-top: include additional metrics reported by `fs perf stats`.

Without this, `cephfs-top` hits an exception since the additional
metrics keys were not configured.

Also, include a validation suring selftest that checks if `ceph
fs perf stats` metrics match what cephfs-top is configured to
report.

Fixes: http://tracker.ceph.com/issues/49974
Signed-off-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #40400 from tchaikov/wip-ctest-jenkins

run-make-check.sh: let ctest generate XML output

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #40327 from racpatel/wip-cephfs-top-refresh-interval

cephfs-top: allow configurable stats refresh interval

Merge pull request #40210 from joscollin/wip-B49736-missing-client-metadata

cephfs-top: be resilient to missing client metadata keys

ceph.spec: prepare openSUSE usrmerge (boo#1029961)

The compat symlink in /sbin is no longer required and actually in
the way in the usrmerge case.

Signed-off-by: Ludwig Nussel <ludwig.nussel@suse.de>

run-make-check.sh: let ctest generate XML output

to enable XUnit plugin of jenkins to consume the ctest output and
publish it in the dashboard, we need to

* let ctest generate XML output instead of plain text output
* do not fail the test if any test case fails. this allows the publisher
  to do its job by checking the XML output.
* prevent ctest from compressing the output. see
  https://issues.jenkins.io/browse/JENKINS-21737

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard:Simplify some complex calculations in test_alerts.yml

run-promtool-unittests is failing with difference in floating point values in some complex calculations. This PR intends to simplify those calculations and fix this issue.

Fixes: https://tracker.ceph.com/issues/49952
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

osd: handle MOSDPGInfo

this change partially reverts b37e959238e75690d38873744515fa54413f4393,
which introduced a regression where we fail to handle MOSDPGInfo
messages sent by osd before aba13c7661bf8a62f2879513512053dc9857c003
and/or f7130db7a9fa85e475f14e4feed0097bf2d0b964.

Fixes: https://tracker.ceph.com/issues/49963
Signed-off-by: Kefu Chai <kchai@redhat.com>

osd/PeeringState: init last_require_osd_release in ctor

so we can use the latest osdmap to tell what is the required osd release in
*current* cluster before consuming a new osdmap which is fed to
PeeringState only if we advance to a new map.

a osd shares its pg_info using MOSDPGInfo2 or MOSDPGInfo according to
PeeringState::last_require_osd_release, this happens before a new osdmap
is fully consumed.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr: attr_list reassigned before use in diskprediction_local module

According to the document description, attr_list should be intersection
set of all disk days.

Fixes: https://tracker.ceph.com/issues/49968
Signed-off-by: wencong wan <wanwc@chinatelecom.cn>

Merge pull request #40377 from tchaikov/wip-doc-fixes

doc/man: fix formatting

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #38044 from dvanders/dvanders_buffered

common/options: bluefs_buffered_io=true by default

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #40380 from adamemerson/wip-num-rados-handles-die-die-die

Die, `num_rados_handles`, die.

Reviewed-by: Ali Maredia <amaredia@redhat.com>

cephadm: fix parsing of keepalived version (drop leading 'v')

Signed-off-by: Sage Weil <sage@newdream.net>

cephadm: keepalived needs --cap-add=NET_RAW

This makes

Mar 24 12:00:32 dael conmon[3969650]: Wed Mar 24 16:00:32 2021: cant open raw socket. errno=1

go away and allows it to enter the MASTER state.

Signed-off-by: Sage Weil <sage@newdream.net>

cephadm: fix --cap-add=NET_ADMIN

Podman wants the = sign.  This aligns us with the other --cap-add user
(SYS_PTRACE), which uses =.

Signed-off-by: Sage Weil <sage@newdream.net>

cephadm: fix quoting for keepalived env var

This was broken by 3ea514c5525cd21722ef3fe9b90363c21e483596

Signed-off-by: Sage Weil <sage@newdream.net>

rgw: Remove spurious `num_rados_handles` option

While any code that used the option is gone, it appears the option
itself was accidentally resurrected in various options.cc refactors
and transitions.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

crimson/os/seastore/segment_cleaner: introduce byte limit on rewrite_dirty

Signed-off-by: Samuel Just <sjust@redhat.com>

doc/install/windows-troubleshooting: fix typo

and tweak the format a little bit

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/man/8/ceph-volume: fix formatting

Signed-off-by: Kefu Chai <kchai@redhat.com>

admin/build-doc: build man page in proper directory

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #40350 into master

* refs/pull/40350/head:
doc/cephadm: explicitly show host requirments in adding host section

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #40235 from tchaikov/wip-cmake-test-fixture

cmake: use fixture for preparing venv

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

mgr/cephadm: Fix dashboard gateway configuration when using IPV6

Fixes: https://tracker.ceph.com/issues/49957
Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>

cmake: use fixture for preparing venv

this change should allow us to decouple "ninja tests" from "ctest".
in other words, we can just run

ctest -R run-tox-python-common -V

without running "ninja tests" first. before this change

${name}-venv is added as a dependency of "tests" target.

after this change,

setup-venv-for-${name} is added as a test, which is in turn a test of
run-tox-${name}, so we can just

ctest -R run-tox-${name}

now for preparing the venv and then testing the tox test of ${name}.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40344 from zdover23/wip-doc-cephadm-index-rewrite-2021-Mar-23

doc/cephadm: rewrite "index.rst"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge PR #40353 into master

* refs/pull/40353/head:
cephsqlite: add julian day offset in milliseconds

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #40291 from tchaikov/wip-debian-cleanups

debian: cleanups and exclude ceph_crypto from dh_shlibdep

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

mgr/dashboard: mute i18n progress

i18n progress build generates a lot of traces that make harder to find
the root cause for an error in frontend-unittests.

Fixes: https://tracker.ceph.com/issues/49943
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

build(deps): bump node-notifier in /src/pybind/mgr/dashboard/frontend

Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

os/bluestore: separate omap per-pool vs per-pg alerts

Currently the health alert raised does not match the docs, and the docs
do not describe what the health alert indicates.

Octopus added per-pool omap storage.  This improves space accounting
and reporting.

Pacific added per-pg omap storage (object hash in key).  This speeds up
PG removal.

Separate everthing out into two distinct alerts raised from bluestore
and surfaced as health alerts, with corresponding config options to
disable, and update the docs accordingly.

Also update the fsck options for warn vs error, and raise separate
errors for the per-pg and per-pool cases.

Signed-off-by: Sage Weil <sage@newdream.net>

tools/cephfs: fix missing keys in cephfs-top client_metadata

Fixes: https://tracker.ceph.com/issues/49736
Signed-off-by: Jos Collin <jcollin@redhat.com>

Merge pull request #39683 from maydaycc/wip-49487

osd: fix scrub reschedule bug

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: David Zafman <dzafman@redhat.com>