]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agopybind/mgr/dashboard: bump up requests to 2.25.1 40492/head
Kefu Chai [Thu, 25 Feb 2021 09:56:02 +0000 (17:56 +0800)]
pybind/mgr/dashboard: bump up requests to 2.25.1

request 2.20 is not compatible with urllib3 v1.25.2 and up. this causes
trouble of incompatibility with other python modules. for instance, we
now have following error:

ERROR: pip's dependency resolver does not currently take into account
all the packages that are installed. This behaviour is the source of the
following dependency conflicts.
botocore 1.20.14 requires urllib3<1.27,>=1.25.4, but you have urllib3
1.24.3 which is incompatible.

see also https://github.com/psf/requests/pull/5092

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8bf07cd1408d0f407ef5e32717bfea159188670d)

4 years agomgr/dashboard: update pylint to 2.6.0
Volker Theile [Fri, 25 Sep 2020 11:17:19 +0000 (13:17 +0200)]
mgr/dashboard: update pylint to 2.6.0

* Update pylint to 2.6.0.
* Fix pylint issues.

Fixes: https://tracker.ceph.com/issues/47647
Signed-off-by: Volker Theile <vtheile@suse.com>
s

(cherry picked from commit 298c91958a41674a928d53f010b20f174f16d68f)

Conflicts:
src/pybind/mgr/dashboard/requirements-lint.txt
src/pybind/mgr/dashboard/services/ceph_service.py
src/pybind/mgr/dashboard/services/ganesha.py
src/pybind/mgr/dashboard/services/rgw_client.py
src/pybind/mgr/dashboard/tests/test_access_control.py
src/pybind/mgr/dashboard/tests/test_ganesha.py
src/pybind/mgr/dashboard/tests/test_iscsi.py
src/pybind/mgr/dashboard/tests/test_rgw.py
src/pybind/mgr/dashboard/tests/test_settings.py

4 years agoadmin/build-doc: stop passing --use-feature=2020-resolver to pip
Kefu Chai [Sat, 12 Dec 2020 07:19:40 +0000 (15:19 +0800)]
admin/build-doc: stop passing --use-feature=2020-resolver to pip

to silence the warning of

WARNING: --use-feature=2020-resolver no longer has any effect, since it is now the default dependency resolver in pip. This will become an error in pip 21.0.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 5cb9d5458745046aaea58cf4af50579925fbb1d0)

Conflicts:
admin/build-doc: trivial resolution

4 years agopybind/mgr/dashboard: bump flake8 to 3.9.0
Kefu Chai [Fri, 19 Mar 2021 04:05:45 +0000 (12:05 +0800)]
pybind/mgr/dashboard: bump flake8 to 3.9.0

to address the failure of

ERROR: Cannot install -r requirements-lint.txt (line 2) and -r requirements-lint.txt (line 8) because these package versions have conflicting dependencies.

The conflict is caused by:
    flake8 3.8.4 depends on pycodestyle<2.7.0 and >=2.6.0a1
    autopep8 1.5.6 depends on pycodestyle>=2.7.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

also, loosen the version of pytest:

The conflict is caused by:
    The user requested pytest<4
    The user requested pytest<4
    pytest-cov 2.11.1 depends on pytest>=4.6

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency
   conflict

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 152964ca360293d9accd18f435efcd66d145063e)

4 years agoMerge pull request #39914 from mgfritch/octopus-backport-37764-39739
Yuri Weinstein [Fri, 26 Mar 2021 18:03:23 +0000 (11:03 -0700)]
Merge pull request #39914 from mgfritch/octopus-backport-37764-39739

octopus: cephadm: run containers using `--init`

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #40138 from neha-ojha/wip-49402-octopus
Yuri Weinstein [Fri, 26 Mar 2021 17:53:46 +0000 (10:53 -0700)]
Merge pull request #40138 from neha-ojha/wip-49402-octopus

octopus: qa/suites/rados/singletone: whitelist MON_DOWN when injecting msgr errors

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
4 years agoMerge pull request #40009 from mgfritch/octopus-backport-39825
Yuri Weinstein [Fri, 26 Mar 2021 17:53:18 +0000 (10:53 -0700)]
Merge pull request #40009 from mgfritch/octopus-backport-39825

octopus: mgr/cephadm: alias rgw-nfs -> nfs

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoMerge pull request #39940 from smithfarm/wip-49663-octopus
Yuri Weinstein [Fri, 26 Mar 2021 17:52:48 +0000 (10:52 -0700)]
Merge pull request #39940 from smithfarm/wip-49663-octopus

octopus: src/global/signal_handler.h: fix preprocessor logic for alpine

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #39922 from smithfarm/wip-49636-octopus
Yuri Weinstein [Fri, 26 Mar 2021 17:51:54 +0000 (10:51 -0700)]
Merge pull request #39922 from smithfarm/wip-49636-octopus

octopus: mgr/telemetry: check if 'ident' channel is active

Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
4 years agoMerge pull request #39919 from smithfarm/wip-49530-octopus
Yuri Weinstein [Fri, 26 Mar 2021 17:51:14 +0000 (10:51 -0700)]
Merge pull request #39919 from smithfarm/wip-49530-octopus

octopus: crush/CrushWrapper: update shadow trees on update_item()

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #39884 from singuliere/wip-49386-octopus
Yuri Weinstein [Fri, 26 Mar 2021 17:50:20 +0000 (10:50 -0700)]
Merge pull request #39884 from singuliere/wip-49386-octopus

octopus: os/bluestore/BlueFS: use iterator_impl::copy instead of bufferlist::c_str() to avoid bufferlist rebuild

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #37972 from callithea/wip-48131-octopus
Yuri Weinstein [Fri, 26 Mar 2021 17:49:37 +0000 (10:49 -0700)]
Merge pull request #37972 from callithea/wip-48131-octopus

octopus: mgr/dashboard: additional logging to SMART data retrieval

Reviewed-by: Patrick Seidensal <pnawracay@suse.com>
4 years agoMerge pull request #40406 from tchaikov/octopus-pr-40400
Kefu Chai [Fri, 26 Mar 2021 01:27:04 +0000 (09:27 +0800)]
Merge pull request #40406 from tchaikov/octopus-pr-40400

octopus: run-make-check.sh: let ctest generate XML output

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agorun-make-check.sh: let ctest generate XML output 40406/head
Kefu Chai [Thu, 25 Mar 2021 09:08:48 +0000 (17:08 +0800)]
run-make-check.sh: let ctest generate XML output

to enable XUnit plugin of jenkins to consume the ctest output and
publish it in the dashboard, we need to

* let ctest generate XML output instead of plain text output
* do not fail the test if any test case fails. this allows the publisher
  to do its job by checking the XML output.
* prevent ctest from compressing the output. see
  https://issues.jenkins.io/browse/JENKINS-21737

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 48ba39987d3958531589d7969750ea749e6a6d30)

4 years agoMerge pull request #39360 from kamoltat/wip-octupus-del-period-arg
Josh Durgin [Wed, 24 Mar 2021 00:08:14 +0000 (17:08 -0700)]
Merge pull request #39360 from kamoltat/wip-octupus-del-period-arg

octopus:qa/tasks/mgr/test_progress: fix wait_until_equal

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #40225 from kamoltat/wip-fix-39289-incomplete-backport
Josh Durgin [Wed, 24 Mar 2021 00:07:34 +0000 (17:07 -0700)]
Merge pull request #40225 from kamoltat/wip-fix-39289-incomplete-backport

octopus: qa/tasks/mgr/test_progress.py:  remove calling of _osd_in_out_completed_events_count()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #40001 from rhcs-dashboard/wip-49703-octopus
Ernesto Puerta [Tue, 23 Mar 2021 17:24:30 +0000 (18:24 +0100)]
Merge pull request #40001 from rhcs-dashboard/wip-49703-octopus

octopus: mgr/dashboard: fix dashboard instance ssl certificate functionality

Reviewed-by: Nizamudeen A <nia@redhat.com>
4 years agoqa/tasks/mgr/test_progress: fix wait_until_equal 39360/head
Kamoltat [Mon, 8 Feb 2021 15:45:06 +0000 (15:45 +0000)]
qa/tasks/mgr/test_progress: fix wait_until_equal

Octopus ceph_test_case doesn't have period arg
so remove that in wait_until_equal. Also increase
time to wait for complete events by using RECOVERY_PERIOD
instead of EVENT_CREATION_PERIOD

Not needed in masters because only octopus and nautilus
doesn't have a period argument in qa/tasks/mgr/test_progress.py
wait_until_equals() function

Fixes: https://tracker.ceph.com/issues/48824
Signed-off-by: Kamoltat <ksirivad@redhat.com>
4 years agoMerge pull request #40286 from tchaikov/octopus-pr-40272
Kefu Chai [Sun, 21 Mar 2021 17:19:11 +0000 (01:19 +0800)]
Merge pull request #40286 from tchaikov/octopus-pr-40272

octopus: install-deps.sh: remove existing ceph-libboost of different version

Reviewed-by: David Galloway <dgallowa@redhat.com>
4 years agoinstall-deps.sh: remove existing ceph-libboost of different version 40286/head
Kefu Chai [Sat, 20 Mar 2021 05:00:01 +0000 (13:00 +0800)]
install-deps.sh: remove existing ceph-libboost of different version

we install different versions of precompiled ceph-libboost packages
for different branches when building and testing them on ubuntu test
nodes. for instance,

- nautilus, octopus: v1.72
- pacific: v1.73

they share the same set of test nodes. and these ceph-libboost packages
conflict with each other, because they install files to the same places.

in order to avoid the confliction, we should uninstall existing packages
before installing a different version of ceph-libboost packages.

ceph-libboost${version}-dev is a package providing the shared headers of
boost library, so, in this change we check if it is installed before
returning or removing the existing packages.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 939b147a55192c21e98d21cb380d0ec0b2ca84d5)

Conflicts:
install-deps.sh: use 1.72

4 years agoMerge pull request #40211 from idryomov/wip-krbd-blkroset-5.12-octopus
Ilya Dryomov [Fri, 19 Mar 2021 16:22:29 +0000 (17:22 +0100)]
Merge pull request #40211 from idryomov/wip-krbd-blkroset-5.12-octopus

octopus: qa: krbd_blkroset.t: update for separate hw and user read-only flags

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoqa/tasks/mgr/test_progress.py: remove _osd_in_out_completed_events_count() 40225/head
Kamoltat [Thu, 18 Mar 2021 19:51:34 +0000 (19:51 +0000)]
qa/tasks/mgr/test_progress.py: remove _osd_in_out_completed_events_count()

delete the part where  _osd_in_out_completed_events_count()
was called in test_osd_cannot_recover() and revert to initial
state of the function since we don't need to use this function
in octopus. Also delete a duplicate of _osd_in_out_events_count().
This must be added by mistake in #39289 as well.

No need to fix for the backport in Nautilus: #38173
since the bugs are occured by adding additional code to
the cherry-pick specifically for Octopus.

fixes: https://tracker.ceph.com/issues/49891

Signed-off-by: Kamoltat <ksirivad@redhat.com>
4 years agoMerge pull request #40065 from idryomov/wip-krbd-xfstests-fixes-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:49:51 +0000 (09:49 -0700)]
Merge pull request #40065 from idryomov/wip-krbd-xfstests-fixes-octopus

octopus: qa/suites/krbd: address recent issues caused by newer kernels

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #40029 from yuvalif/wip-yuval-fix-48461
Yuri Weinstein [Thu, 18 Mar 2021 16:49:16 +0000 (09:49 -0700)]
Merge pull request #40029 from yuvalif/wip-yuval-fix-48461

octopus: rgw/notification: trigger notifications on changes from any user

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #39968 from dillaman/wip-49438-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:48:43 +0000 (09:48 -0700)]
Merge pull request #39968 from dillaman/wip-49438-octopus

octopus: krbd: make sure the device node is accessible after the mapping

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
4 years agoMerge pull request #39967 from dillaman/wip-49417-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:47:56 +0000 (09:47 -0700)]
Merge pull request #39967 from dillaman/wip-49417-octopus

octopus: rbd-mirror: delay update snapshot mirror image state

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
4 years agoMerge pull request #39966 from dillaman/wip-49257-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:47:28 +0000 (09:47 -0700)]
Merge pull request #39966 from dillaman/wip-49257-octopus

octopus: librbd: refuse to release exclusive lock when removing

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
4 years agoMerge pull request #39965 from dillaman/wip-49181-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:47:06 +0000 (09:47 -0700)]
Merge pull request #39965 from dillaman/wip-49181-octopus

octopus: test/rbd-mirror: fix broken ceph_test_rbd_mirror_random_write

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
4 years agoMerge pull request #39964 from dillaman/wip-48677-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:46:44 +0000 (09:46 -0700)]
Merge pull request #39964 from dillaman/wip-48677-octopus

octopus: librbd/api: avoid retrieving more than max mirror image info records

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
4 years agoMerge pull request #39962 from dillaman/wip-48674-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:46:21 +0000 (09:46 -0700)]
Merge pull request #39962 from dillaman/wip-48674-octopus

octopus: librbd: explicitly disable readahead for writearound cache

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
4 years agoMerge pull request #39961 from dillaman/wip-48561-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:45:46 +0000 (09:45 -0700)]
Merge pull request #39961 from dillaman/wip-48561-octopus

octopus: rbd-mirror: bad state and crashes in snapshot-based mirroring

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
4 years agoMerge pull request #39958 from smithfarm/wip-49199-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:45:07 +0000 (09:45 -0700)]
Merge pull request #39958 from smithfarm/wip-49199-octopus

octopus: librbd/io: conditionally disable move optimization

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #39954 from smithfarm/wip-49361-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:44:23 +0000 (09:44 -0700)]
Merge pull request #39954 from smithfarm/wip-49361-octopus

octopus: rgw: fix sts get_session_token duration check failed

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
4 years agoMerge pull request #39766 from ivancich/wip-49193-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:43:32 +0000 (09:43 -0700)]
Merge pull request #39766 from ivancich/wip-49193-octopus

octopus: rgw: allow rgw-orphan-list to handle intermediate files w/ binary data

Reviewed-by: Ali Maredia <amaredia@redhat.com>
4 years agoMerge pull request #39785 from ivancich/wip-49186-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:37:37 +0000 (09:37 -0700)]
Merge pull request #39785 from ivancich/wip-49186-octopus

octopus: rgw: tooling to locate rgw objects with missing rados components

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #39758 from href/wip-49070-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:32:53 +0000 (09:32 -0700)]
Merge pull request #39758 from href/wip-49070-octopus

octopus: rgw: add MD5 in forward_request

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #39746 from pponnuvel/wip-49538-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:32:25 +0000 (09:32 -0700)]
Merge pull request #39746 from pponnuvel/wip-49538-octopus

octopus: rgw: catch non int exception

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
4 years agoMerge pull request #39611 from smithfarm/wip-49380-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:31:27 +0000 (09:31 -0700)]
Merge pull request #39611 from smithfarm/wip-49380-octopus

octopus: rgw: multisite: fix single-part-MPU object etag misidentify problem

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #39935 from gerald-yang/octopus-49641
Yuri Weinstein [Thu, 18 Mar 2021 16:29:53 +0000 (09:29 -0700)]
Merge pull request #39935 from gerald-yang/octopus-49641

octopus: common: Fix assertion when disabling and re-enabling clog_to_monitors

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #39899 from singuliere/wip-49039-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:29:11 +0000 (09:29 -0700)]
Merge pull request #39899 from singuliere/wip-49039-octopus

octopus: blk/kernel: fix io_uring got (4) Interrupted system call

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #39717 from sebastian-philipp/octopus-backport-39385
Yuri Weinstein [Thu, 18 Mar 2021 16:28:48 +0000 (09:28 -0700)]
Merge pull request #39717 from sebastian-philipp/octopus-backport-39385

octopus: cephadm: allow redeploy of daemons in error state if container running

Reviewed-by: Adam King adking@redhat.com
4 years agoMerge pull request #39887 from tchaikov/octopus-49533
Yuri Weinstein [Thu, 18 Mar 2021 16:26:56 +0000 (09:26 -0700)]
Merge pull request #39887 from tchaikov/octopus-49533

octopus: mgr: relax osd ok-to-stop condition on degraded pgs

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: David Zafman <dzafman@redhat.com>
4 years agoMerge pull request #39804 from sebastian-philipp/octopus-backport-39770
Yuri Weinstein [Thu, 18 Mar 2021 16:26:09 +0000 (09:26 -0700)]
Merge pull request #39804 from sebastian-philipp/octopus-backport-39770

octopus: cephadm: add docker.service dependency in systemd units

Reviewed-by: Sage Weil <sage@redhat.com>
4 years agoMerge pull request #39578 from neha-ojha/wip-49320-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:23:59 +0000 (09:23 -0700)]
Merge pull request #39578 from neha-ojha/wip-49320-octopus

octopus: qa/*/thrash_cache_writeback_proxy_none.yaml: disable writeback overlay tests

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #39343 from smithfarm/wip-48904-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:18:19 +0000 (09:18 -0700)]
Merge pull request #39343 from smithfarm/wip-48904-octopus

octopus: common/ipaddr: Allow binding on lo

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #39341 from smithfarm/wip-48898-octopus
Yuri Weinstein [Thu, 18 Mar 2021 16:16:07 +0000 (09:16 -0700)]
Merge pull request #39341 from smithfarm/wip-48898-octopus

octopus: mgr: fix deadlock in ActivePyModules::get_osdmap()

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoqa: krbd_blkroset.t: update for separate hw and user read-only flags 40211/head
Ilya Dryomov [Wed, 17 Mar 2021 10:00:33 +0000 (11:00 +0100)]
qa: krbd_blkroset.t: update for separate hw and user read-only flags

Since kernel 5.12, hardware read-only state and user read-only
policy (BLKROGET/SET ioctls) are tracked separately in the block
layer.  As the purpose of our ->set_read_only() method was exactly
that, it was removed.

As a side effect, BLKROSET no longer returns EROFS on an attempt
to make a read-only mapping read-write with "blockdev --setrw".
The policy gets updated, but the device remains read-only as before
because the hardware (== mapping) state is controlled by the driver.

Fixes: https://tracker.ceph.com/issues/49858
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit d72fca26edcff49d203ed6fb940e0cf331e943dd)

4 years agokrbd: check device node accessibility only if we actually mapped 39968/head
Ilya Dryomov [Mon, 15 Mar 2021 19:30:07 +0000 (20:30 +0100)]
krbd: check device node accessibility only if we actually mapped

Fix a braino that came with commit f6854ac65d2a ("krbd: make sure the
device node is accessible after the mapping").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 8330c9fa4e27204c768777afe45af0eeb273c835)

4 years ago15.2.10 v15.2.10
Jenkins Build Slave User [Wed, 17 Mar 2021 17:02:39 +0000 (17:02 +0000)]
15.2.10

4 years agoMerge pull request #40155 from rhcs-dashboard/wip-49272-octopus
Yuri Weinstein [Tue, 16 Mar 2021 17:26:40 +0000 (10:26 -0700)]
Merge pull request #40155 from rhcs-dashboard/wip-49272-octopus

octopus: mgr/dashboard: delete EOF when reading passwords from file

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
4 years agomgr/dashboard: delete EOF when reading passwords from file 40155/head
Alfonso Martínez [Tue, 9 Feb 2021 10:17:52 +0000 (11:17 +0100)]
mgr/dashboard: delete EOF when reading passwords from file

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
(cherry picked from commit caeadf1397db00c6b7ba218b1910508099802e39)

4 years agoqa/suites/rados/singletone: whitelist MON_DOWN when injecting msgr errors 40138/head
Sage Weil [Fri, 19 Feb 2021 22:46:28 +0000 (16:46 -0600)]
qa/suites/rados/singletone: whitelist MON_DOWN when injecting msgr errors

add a 'none.yaml' facet which doesn't whitelist so we hopefully capture
other causes of MON_DOWN.

This fixes at least one source of https://tracker.ceph.com/issues/45441

Fixes: https://tracker.ceph.com/issues/45441
Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 3d2eb0d76ae396bec5f527e99bfecd9fa5223bbd)

4 years agoMerge pull request #39701 from ifed01/wip-ifed-fix-huge-bluefs-oct
Yuri Weinstein [Mon, 15 Mar 2021 16:36:57 +0000 (09:36 -0700)]
Merge pull request #39701 from ifed01/wip-ifed-fix-huge-bluefs-oct

octopus: os/bluestore: fix huge reads/writes at BlueFS

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
4 years agorgw/notification: trigger notifications on changes from any user 40029/head
Yuval Lifshitz [Tue, 17 Nov 2020 11:31:59 +0000 (13:31 +0200)]
rgw/notification: trigger notifications on changes from any user

any user authorized to make changes to a bucket may trigger
notifications defined on that bucket.
manual test procedure of the fix is described here:
https://gist.github.com/yuvalif/39c183aa0f74d286ecef7844268817df

Fixes: https://tracker.ceph.com/issues/48461
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
(cherry picked from commit 658993efc16498c2106108fe407f6d44040f349d)

Conflics:
src/test/rgw/rgw_multi/tests_ps.py
manual changes were made to the tests so they can pass. this does not affect teuthology runs

4 years agoMerge pull request #40074 from ideepika/wip-fix-ignorelist
Yuri Weinstein [Fri, 12 Mar 2021 23:24:32 +0000 (15:24 -0800)]
Merge pull request #40074 from ideepika/wip-fix-ignorelist

octopus: qa/suites/upgrade: s/whitelist/ignorelist for octopus specific tests

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
4 years agoMerge pull request #39754 from ifed01/wip-ifed-bluefs-zero-read-retry-octa
Yuri Weinstein [Fri, 12 Mar 2021 23:12:55 +0000 (15:12 -0800)]
Merge pull request #39754 from ifed01/wip-ifed-bluefs-zero-read-retry-octa

octopus: os/bluestore: Add option to check BlueFS reads

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
4 years agomgr/cephadm: add CEPHADM_STRAY_DAEMON unittest 40009/head
Michael Fritch [Fri, 12 Mar 2021 17:23:12 +0000 (10:23 -0700)]
mgr/cephadm: add CEPHADM_STRAY_DAEMON unittest

Fixes: https://tracker.ceph.com/issues/49573
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 88dc55266958d77ffa1da34a3d20c039cb249ac5)

4 years agomgr/cephadm: alias rgw-nfs -> nfs
Michael Fritch [Fri, 12 Mar 2021 17:23:01 +0000 (10:23 -0700)]
mgr/cephadm: alias rgw-nfs -> nfs

RGW will register a daemon_type `rgw-nfs` which needs to map to
the corresponding cephadm nfs daemon to avoid stray daemon warnings

Fixes: https://tracker.ceph.com/issues/49573
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 0f237223accbea49cf9792400a657cbf696a5d67)

4 years agoMerge pull request #39872 from rhcs-dashboard/wip-48190-octopus
Yuri Weinstein [Fri, 12 Mar 2021 17:09:55 +0000 (09:09 -0800)]
Merge pull request #39872 from rhcs-dashboard/wip-48190-octopus

octopus: mgr/dashboard: add ssl verify option for prometheus and alert manager

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 years agoMerge pull request #39868 from rhcs-dashboard/wip-49083-octopus
Yuri Weinstein [Fri, 12 Mar 2021 17:09:14 +0000 (09:09 -0800)]
Merge pull request #39868 from rhcs-dashboard/wip-49083-octopus

octopus: mgr/dashboard: Fix missing root path of each session for CephFS

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
4 years agoMerge pull request #39854 from rhcs-dashboard/wip-49324-octopus
Yuri Weinstein [Fri, 12 Mar 2021 17:07:27 +0000 (09:07 -0800)]
Merge pull request #39854 from rhcs-dashboard/wip-49324-octopus

octopus: mgr/dashboard: fix MTU Mismatch alert

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 years agoMerge pull request #39852 from rhcs-dashboard/wip-49599-octopus
Yuri Weinstein [Fri, 12 Mar 2021 17:05:59 +0000 (09:05 -0800)]
Merge pull request #39852 from rhcs-dashboard/wip-49599-octopus

octopus: mgr/dashboard: report mgr fsid

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 years agoMerge pull request #39436 from rhcs-dashboard/wip-48654-octopus
Yuri Weinstein [Fri, 12 Mar 2021 17:05:07 +0000 (09:05 -0800)]
Merge pull request #39436 from rhcs-dashboard/wip-48654-octopus

octopus: mgr/dashboard: CLI commands: read passwords from file

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
4 years agoqa/suites/upgrade: s/whitelist/ignorelist for octopus only 40074/head
Deepika Upadhyay [Fri, 12 Mar 2021 16:21:32 +0000 (21:51 +0530)]
qa/suites/upgrade: s/whitelist/ignorelist for octopus only

some upgrade tests are only present for octopus and not for master and
hence we missed updating the ignorelist terminology for those cases.

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #39885 from smithfarm/wip-49031-octopus
Yuri Weinstein [Thu, 11 Mar 2021 16:48:54 +0000 (08:48 -0800)]
Merge pull request #39885 from smithfarm/wip-49031-octopus

octopus: cmake: boost>=1.74 adds BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT to radosgw

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #39867 from trociny/wip-49452-octopus
Yuri Weinstein [Thu, 11 Mar 2021 16:48:24 +0000 (08:48 -0800)]
Merge pull request #39867 from trociny/wip-49452-octopus

octopus: rbd-mirror: reset update_status_task pointer in timer thread

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #39866 from trociny/wip-49454-octopus
Yuri Weinstein [Thu, 11 Mar 2021 16:47:18 +0000 (08:47 -0800)]
Merge pull request #39866 from trociny/wip-49454-octopus

octopus: librbd: use on-disk image name when storing mirror snapshot state

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #39864 from trociny/wip-49399-octopus
Yuri Weinstein [Thu, 11 Mar 2021 16:46:52 +0000 (08:46 -0800)]
Merge pull request #39864 from trociny/wip-49399-octopus

octopus: librbd: allow disabling journaling for snapshot based mirroring image

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #39863 from trociny/wip-49335-octopus
Yuri Weinstein [Thu, 11 Mar 2021 16:46:24 +0000 (08:46 -0800)]
Merge pull request #39863 from trociny/wip-49335-octopus

octopus: mgr/rbd_support: mirror snapshot schedule should skip non-primary images

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #39862 from trociny/wip-49263-octopus
Yuri Weinstein [Thu, 11 Mar 2021 16:45:55 +0000 (08:45 -0800)]
Merge pull request #39862 from trociny/wip-49263-octopus

octopus: librbd: don't log error if get mirror status fails due to mirroring disabled

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
4 years agoMerge pull request #39704 from smithfarm/wip-49397-octopus
Yuri Weinstein [Thu, 11 Mar 2021 15:59:45 +0000 (07:59 -0800)]
Merge pull request #39704 from smithfarm/wip-49397-octopus

octopus: qa/suites/rados/dashboard: whitelist TELEMETRY_CHANGED

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 years agomgr: relax osd ok-to-stop condition on degraded pgs 39887/head
Xuehan Xu [Sun, 7 Feb 2021 04:40:36 +0000 (12:40 +0800)]
mgr: relax osd ok-to-stop condition on degraded pgs

Right now, the "ok-to-stop" condition is relatively rigorous, it allows
stopping an osd only if no PG on it is non-active or degraded. But there
are situations in which an OSD is part of a degraded pg and the pg still
still have > min_size complete replicas after the OSD is stopped.

In 9750061d5d4236aaba156d60790e0b8bcd7cfb64, we changed from considering
just acting to using avail_no_missing (OSDs that have no missing objects).
When the projected pg_acting is constructed this way, we can safely compare
to min_size... even for a PG marked degraded.

Fixes: https://tracker.ceph.com/issues/49392
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
(cherry picked from commit 2f28fc58eb63e20c2a869f5407516cf8044dbc41)

4 years agoqa/suites/krbd: bump scratch image size to 15G 40065/head
Ilya Dryomov [Wed, 24 Feb 2021 10:41:24 +0000 (11:41 +0100)]
qa/suites/krbd: bump scratch image size to 15G

Allow generic/038 and generic/048 to run.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 37d56e13544fa06b88196b1a4d6edd1b3425325e)

4 years agoqa/suites/krbd: exclude ext4/002
Ilya Dryomov [Fri, 26 Feb 2021 12:54:49 +0000 (13:54 +0100)]
qa/suites/krbd: exclude ext4/002

ext4/002 exercises obsolete EXT4_EOFBLOCKS_FL feature that was removed
in kernel 5.7 and therefore always fails.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit d2bdf0ac43a35f755ea70103f497625d882a4592)

4 years agoqa/tasks/rbd: fix xfstests_branch/url example
Ilya Dryomov [Sat, 27 Feb 2021 13:58:45 +0000 (14:58 +0100)]
qa/tasks/rbd: fix xfstests_branch/url example

- don't mention xfstests_branch together with xfstests_url as
  xfstests_branch gets superseded by xfstests_url
- make xfstests_url example more clear

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit ec36d501ed5f875d26d1362ec097187697170a4d)

4 years agomgr/dashboard: fix dashboard instance ssl certificate functionality 40001/head
Avan Thakkar [Tue, 16 Feb 2021 22:25:29 +0000 (03:55 +0530)]
mgr/dashboard: fix dashboard instance ssl certificate functionality

Fixes: https://tracker.ceph.com/issues/46542
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 0a88c62e76f80a4ad9c01a91161b77ac6f073ed4)

 Conflicts:
src/pybind/mgr/mgr_module.py
      - Adopting the master branch changes.

4 years agokrbd: make sure the device node is accessible after the mapping
Ilya Dryomov [Fri, 19 Feb 2021 15:47:17 +0000 (16:47 +0100)]
krbd: make sure the device node is accessible after the mapping

We have always assumed this to be the case and users' scripts and
orchestration tools have grown to depend on this.  Let's add some
enforcement, prompted by [1]:

  "I am running my Kubernetes worker node inside of an LXC container
   which doesn't benefit from the device node created by the kernel, so
   I'm using udev to create the /dev/rbd* device nodes inside of the LXC
   container."

which, through the unfortunate interaction with ceph-csi rbd plugin,
results in data loss for "volumeMode: Filesystem" PVs because it ends
up recreating the filesystem every time the PV is attached to the pod:

  "When deleting the pod and re-creating it, I can see that the RBD
   image is indeed being reformatted. This seems to be because when
   blkid is being run to check if the image is formatted, the /dev/rbd*
   device has not yet been created by udev. By the time the code gets
   down to running mkfs, the device is there and the damage is done."

[1] https://github.com/ceph/ceph-csi/issues/1820

Fixes: https://tracker.ceph.com/issues/49410
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit f6854ac65d2a838e2f523979e341136e5f201b5c)

4 years agolibrbd/mirror: leave non-primary snapshot images in creating state 39967/head
Jason Dillaman [Thu, 11 Feb 2021 20:54:01 +0000 (15:54 -0500)]
librbd/mirror: leave non-primary snapshot images in creating state

The creating state is a special case in rbd-mirror where it will
automatically delete the image since it assumes it's malformed.
A non-primary, snapshot-based mirror image needs to have at least
one non-primary snapshot and the first one is not created until
after replay has started. Now rbd-mirror will update the mirror
image state to the enabled state after creating the first
non-primary snapshot but before attempting the sync.

Fixes: https://tracker.ceph.com/issues/49238
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 43f2c208fa3042d93e4810d804ffe28e9ca7af77)

4 years agorbd-mirror: ensure that the last non-primary snapshot cannot be pruned
Jason Dillaman [Thu, 11 Feb 2021 20:45:01 +0000 (15:45 -0500)]
rbd-mirror: ensure that the last non-primary snapshot cannot be pruned

Tweak the normal pruning behavior to ensure that an incomplete initial
non-primary snapshot is not included in the prune set since we know
it will be complete since otherwise the image would have been deleted
due to not updating the mirror-image-state to enabled. Also ensure
we cannot prune a non-primary mirror snapshot if we don't have a
predecessor.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit ecd3778a6f9a6ca33aebbf47cef79db5f04157a9)

4 years agorbd-mirror: update snapshot mirror image state after snapshot creation
Jason Dillaman [Thu, 11 Feb 2021 20:23:56 +0000 (15:23 -0500)]
rbd-mirror: update snapshot mirror image state after snapshot creation

The non-primary mirror snapshot is what is used to link the non-primary
to the primary image. If there is an interruption between creating the
non-primary image and the creation of the first non-primary snapshot,
the images will be considerered unlinked.

A future commit will modify librbd to avoid setting the mirror image
state to enabled for non-primary snapshot-based mirroring images.
rbd-mirror will already automatically delete images in the CREATING
state during the bootstrap phase.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit c9378ab8293e531a49970a01becd9762cf1f8f80)

4 years agolibrbd: journal::StandardPolicy template defaults to ImageCtx 39966/head
Ilya Dryomov [Tue, 9 Feb 2021 13:04:39 +0000 (14:04 +0100)]
librbd: journal::StandardPolicy template defaults to ImageCtx

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit b90ee634fa2aca4d1223ee19f43d026917aa969d)

4 years agolibrbd: don't hold owner_lock for validate_image_removal()
Ilya Dryomov [Mon, 8 Feb 2021 16:01:47 +0000 (17:01 +0100)]
librbd: don't hold owner_lock for validate_image_removal()

handle_exclusive_lock() and handle_shut_down_exclusive_lock() call
validate_image_removal() without owner_lock held, so holding it in
shut_down_exclusive_lock() appears to be redundant.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit b1bf3eaef200fb5d1aa847cad14936f2bbbf7b64)

4 years agolibrbd: treat EROFS as expected in handle_acquire_lock()
Ilya Dryomov [Sun, 7 Feb 2021 14:09:24 +0000 (15:09 +0100)]
librbd: treat EROFS as expected in handle_acquire_lock()

If the peer refuses to release exclusive lock (e.g. in case automatic
exclusive lock transitions are disabled), EROFS is retured.  Suppress
a rather confusing "Read-only file system" error message -- this case
is no different from EBUSY or EAGAIN.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 2f82c98f5a542a69057f3e78d232380eee14eff7)

4 years agolibrbd: refuse to release exclusive lock when removing
Ilya Dryomov [Sun, 7 Feb 2021 12:46:15 +0000 (13:46 +0100)]
librbd: refuse to release exclusive lock when removing

Commit 25c2ffe145be ("librbd: acquire exclusive lock from peer when
removing") changed PreRemoveRequest to request exclusive lock from the
peer instead of giving up and proceeding without exclusive lock.  This
caused one of the test cases that sometimes runs concurrent "rbd rm"
against the same image to fail intermittently, most often on assert

  ceph_assert(image_ctx.exclusive_lock == nullptr ||
              image_ctx.exclusive_lock->is_lock_owner());

because exclusive lock is now automatically transitioned to another
"rbd rm" on its request.

The root cause is older and probably goes back to when synchronous
librbd::remove() which held owner_lock across all operations including
trim_image() was converted to a set of state machines.  Since then, any
peer that requests exclusive lock (instead of trying once and backing
off) is able to mess with image removal.

Install StandardPolicy to disable automatic exclusive lock transitions
during image removal.

Fixes: https://tracker.ceph.com/issues/49226
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 707907ea3f6ff39968666af4ba718ceef8cd8953)

4 years agolibrbd: templatize exclusive_lock::StandardPolicy
Ilya Dryomov [Mon, 8 Feb 2021 15:49:35 +0000 (16:49 +0100)]
librbd: templatize exclusive_lock::StandardPolicy

This will be used by expect_set_exclusive_lock_policy() in
test_mock_PreRemoveRequest.cc.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 948f3c761dce4678b38d22e240da06434dbe10e4)

4 years agotest/rbd-mirror: fix broken ceph_test_rbd_mirror_random_write 39965/head
Jason Dillaman [Wed, 3 Feb 2021 04:34:18 +0000 (23:34 -0500)]
test/rbd-mirror: fix broken ceph_test_rbd_mirror_random_write

It appears that commit 6eb8f30a238 broke the test utility and
its failure was masked by the test case that expected a failure
due to a timeout force-killing the app.

Fixes: https://tracker.ceph.com/issues/49117
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 8643b046fb4d5b05b4c75b83f16cd8ccc6a8b0a0)

4 years agolibrbd/api: avoid retrieving more than max mirror image info records 39964/head
Jason Dillaman [Wed, 16 Dec 2020 15:15:28 +0000 (10:15 -0500)]
librbd/api: avoid retrieving more than max mirror image info records

This could otherwise result in an assertion failure in the API if
it failed to retrieve the status on an image and therefore required
a second iteration through the loop.

Fixes: https://tracker.ceph.com/issues/48522
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 77bc48bbadd8e8423e9342102475994632441eaa)

Conflicts:
src/librbd/api/Mirror.cc: conflict with new AsioEngine

4 years agolibrbd: explicitly disable readahead for writearound cache 39962/head
Jason Dillaman [Tue, 15 Dec 2020 19:56:02 +0000 (14:56 -0500)]
librbd: explicitly disable readahead for writearound cache

The readahead IOs would be wasted effort since the writearound
cache does not service reads.

Fixes: https://tracker.ceph.com/issues/48486
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit b65f6b865044bffc4db07551caff9e81d6fa8f28)

4 years agorbd-mirror: validate that remote start snapshot still exists 39961/head
Jason Dillaman [Fri, 11 Dec 2020 00:31:45 +0000 (19:31 -0500)]
rbd-mirror: validate that remote start snapshot still exists

Perform a basic sanity check to verify that the remote start snapshot
still exists. This was previosly being deleted as part of the unlink
process due to a race condition between the remote side completing
a sync between snapshots 1 and 2 and snapshot 2 being unlinked due
to reaching max snapshots.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit fb69efc6c19e6ee2bd8947129fb7f35442acb907)

4 years agolibrbd/mirror: tweak which snapshot is unlinked when at capacity
Jason Dillaman [Thu, 10 Dec 2020 22:32:16 +0000 (17:32 -0500)]
librbd/mirror: tweak which snapshot is unlinked when at capacity

The rbd-mirror daemon will attempt to sync from the last synced
snapshot to the next mirror snapshot. When the limit is at 3, this
currently can result in a situation where an in-use sync snapshot is
deleted. Instead of unlinking the second oldest snapshot, always
unlink the third oldest.

Fixes: https://tracker.ceph.com/issues/48553
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit a888bff8d00e3e496ec80e4273e01a47b67da5dc)

4 years agolibrbd/mirror: ignore non-fatal errors when unlinking the snapshot
Jason Dillaman [Thu, 10 Dec 2020 20:05:04 +0000 (15:05 -0500)]
librbd/mirror: ignore non-fatal errors when unlinking the snapshot

Notifications can fail if a client crashes or if we race with the
removal of the image. Either case should be ignored.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 529d3c9a073b6ab11f469fd54c72de2d3650cf18)

4 years agolibrbd/mirror: increase debug logging of snapshot state machines
Jason Dillaman [Thu, 10 Dec 2020 21:13:23 +0000 (16:13 -0500)]
librbd/mirror: increase debug logging of snapshot state machines

Try to keep debug level 20 for IO state machines so that setting the
debug level to something lower should show the manipulation of
the mirror snapshots.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 11165b1de3b355cb9d4ec077a00bc97844f8fe7e)

4 years agorbd-mirror: do not attempt to unlink from more recent snapshots
Jason Dillaman [Thu, 10 Dec 2020 04:17:24 +0000 (23:17 -0500)]
rbd-mirror: do not attempt to unlink from more recent snapshots

The snapshot-based mirroring replayer should only attempt to unlink
from any snapshots that are older than the end remote snapshot id to
prevent the remote side from incorrectly deleted the snapshot.

Fixes: https://tracker.ceph.com/issues/48527
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 78f8abce2d90d7c9bcf7b4bd4d805c3fe0b39b03)

4 years agolibrbd/mirror: unlink peer might recursively loop
Jason Dillaman [Thu, 10 Dec 2020 03:30:17 +0000 (22:30 -0500)]
librbd/mirror: unlink peer might recursively loop

If the mirror peer set is (incorrectly) empty, it's not currently
possible for the unlink peer state machine to properly delete the
snapshot. This can result in a recursive loop between the create
primary snapshot state machine and the unlink peer state machine
until the stack depth grows too large.

Fixes: https://tracker.ceph.com/issues/48525
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 18a45503011a572325e09b56d5ab799a15ee83d4)

4 years agolibrbd/io: conditionally disable move optimization 39958/head
Jason Dillaman [Thu, 4 Feb 2021 16:17:48 +0000 (11:17 -0500)]
librbd/io: conditionally disable move optimization

If the requested write length does not match the provided bufferlist
length, disable the move optimization and instead fallback to creating
a new sub-bufferlist for the object request.

Fixes: https://tracker.ceph.com/issues/49173
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 8dbb4a3d971d9a48c171f161f531956dd0030403)

4 years agorgw: fix download object when use v2 presigned url generate by 39954/head
yuliyang_yewu [Fri, 15 Jan 2021 01:45:55 +0000 (09:45 +0800)]
rgw: fix download object when use v2 presigned url generate by
sts

fix https://tracker.ceph.com/issues/48885

Signed-off-by: yuliyang_yewu <yuliyang_yewu@cmss.chinamobile.com>
(cherry picked from commit 51af56cee4ba4fc1a2f937c5c195d05cddfb40b7)

4 years agorgw: fix sts get_session_token always failed because of wrong
yuliyang_yewu [Fri, 15 Jan 2021 00:44:03 +0000 (08:44 +0800)]
rgw: fix sts get_session_token always failed because of wrong
check

fix https://tracker.ceph.com/issues/48883

Signed-off-by: yuliyang_yewu <yuliyang_yewu@cmss.chinamobile.com>
(cherry picked from commit bf9c66e16dfc704c3471f42d9f6b9b1682f9969e)

Conflicts:
src/rgw/rgw_rest_sts.cc
d6af250bff08d54cd37121666c26b475d5d2cf52 was not backported

4 years agoMerge pull request #39890 from tchaikov/octopus-github-milestone
Kefu Chai [Tue, 9 Mar 2021 09:20:10 +0000 (17:20 +0800)]
Merge pull request #39890 from tchaikov/octopus-github-milestone

octopus: .github: add workflow for adding label and milestone

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agosrc/global/signal_handler.h: fix preprocessor logic for alpine 39940/head
Duncan Bellamy [Thu, 25 Feb 2021 12:05:56 +0000 (12:05 +0000)]
src/global/signal_handler.h: fix preprocessor logic for alpine
Fixes: https://tracker.ceph.com/issues/49494
Co-authored-by: Kefu Chai <tchaikov@gmail.com>
Signed-off-by: Duncan Bellamy <dunk@denkimushi.com>
(cherry picked from commit 387f33e7265825ae4cdd3580289f5154e250b05b)

4 years ago.github/workflows: use a released sha1 39890/head
Kefu Chai [Tue, 9 Mar 2021 04:16:26 +0000 (12:16 +0800)]
.github/workflows: use a released sha1

otherwise the action cannot be found

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit ae8ea10f415ec170be4a7be48567dbac83221dc0)