crimson/osd: include headers at where they are used

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40564 from tchaikov/wip-crimson-internal_client_request-lite

crimson/osd: cleanups preparing for InternalClientRequest infrastructure.

Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/osd: pg_backend.h doesn't depend on pg.h anymore.

It's not only unnecessary but it also causes a depedency hell.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: use obc->get_oid() instead of passing hobject_t around.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/common: let error handlers to return errorated futures.

Before the change an error handler (a callable passed as second
or further parameters to `safe_then()`) was supposed to return
`seastar::future<..>` if it handled the errors or one of allowed
error types otherwise (like `crimson::ct_error::enoent`). Now
they may return also an erroratored future (`errator<ErrorT>::future<...>`)
and its error-set will fused with other sources of errors to be
included in errorator `safe_then()` returns.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: OpsExecuter::get_target() returns const reference now.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/common: replace UTF-8 with ASCII in errorator's stateful_error_t.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/common: stateful_error_t allows for void-taking handlers.

Before this commit there was an inconsistencty between
`unthrowable_wrapper::handle()` and `stateful_error_t::handle()`
in the regard of parameters the provided handler had to accept.
The former was fine with void-taking handlers while the latter
was not.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: drop the never used ctors of osd_op_params_t.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: std::move func in pg::with_*_obc().

Well, likely all the commit does is just appending a couple
of extra bytes. Though, strictly juding, a func should be
`std::move()`d before calling in those cases. Otherwise we
can miss e.g. the `operator() &&` overload.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: use the alias for OpsExecuter in PG::do_osd_ops().

It's already defined there. We've just missed this fact in
one place.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: fix a thinko in the comment about OpsExecuter.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: drop ObjectContext::loaded as it's never read.

The `PG::with_obc*` machinery uses the `existed` marker
provided by the LRU cache subsystem.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #40533 from Seong-yeop/master

src/rgw/rgw_client_io.h: fix a typo

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40540 from tchaikov/wip-stop.sh

stop.sh: restructure stop logic

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #40454 from zdover23/wip-doc-cephadm-osd-remove-main-text-rewrite-2021-Mar-26

doc/cephadm: rewrite osd.rst "Remove an OSD"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #39092 from adamemerson/wip-datalog-genbacking

rgw: Fixes and Improvements for Datalog

Reviewed-By: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-By: Casey Bodley <cbodley@redhat.com>

Merge pull request #40548 from tchaikov/wip-doc-tweaks

doc: tweak .admonition.important and command line block formatting tweaks

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

doc/rbd: tweak the format of command line blocks

to use the "prompt" directive for better rendering.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/_themes: tweak .admonition.important

do not render the links in "important" block in gray, it's not
readable in light red background. so use the blue and purple colors
specified by sphinx_rtd_theme.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #40524 into master

* refs/pull/40524/head:
doc: document CephFS Snapshot Mirroring

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #40535 from tchaikov/wip-dashboard-pytest

pybind/mgr/dashboard: move pytest into requirements.txt

Reviewed-by: Sebastian Wagner <swagner@suse.com>

Merge PR #40504 into master

* refs/pull/40504/head:
doc/security: no gpg keys yet
doc/security: restructure a bit
doc/security: add security section

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #40542 from tchaikov/wip-radosgw-admin-realm-rm

rgw/rgw_admin: s/realm delete/realm rm/

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #40541 from tchaikov/wip-executable-without-shebang

os/bluestore: remove executable bit of source file

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #40173 from rhcs-dashboard/fix-40676-master

mgr/dashboard: Warn the user when creating/editing pools without application tags

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/security: no gpg keys yet

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #40397 from rhcs-dashboard/update-texts

mgr/dashboard: Improve descriptions in some parts of the dashboard

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

doc/security: restructure a bit

Signed-off-by: Sage Weil <sage@newdream.net>

doc/security: add security section

- how to report an issue
- describe process for handling vulnerability
- list past issues

Signed-off-by: Sage Weil <sage@newdream.net>

Merge PR #40477 into master

* refs/pull/40477/head:
cephadm: fix failure when using --apply-spec and --shh-user

Reviewed-by: Adam King <adking@redhat.com>

Merge PR #40463 into master

* refs/pull/40463/head:
cephadm: specify addr on bootstrap's host add

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge PR #40478 into master

* refs/pull/40478/head:
mgr/cephadm: don't have upgrade fail if "." in patch section of version

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>

doc: document CephFS Snapshot Mirroring

Signed-off-by: Venky Shankar <vshankar@redhat.com>

Merge PR #40530 into master

* refs/pull/40530/head:
doc/releases: reorg
doc/releases/releases.yaml: add missing releases
admin/build-doc: do not rebuild venv every time
doc/releases/releases.yaml: add 16.2.0
doc/releases: move 'active-releases' tag
doc/releases: add major headings for releases

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>

rgw/rgw_admin: s/realm delete/realm rm/

it was an oversight of fa5398d31f9467b58a8b4eda55d1b5e2bbdb6500

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40451 from tchaikov/wip-dencoder-plugins

tools/ceph-dencoder: build dencoders as plugins

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

os/bluestore: remove executable bit of source file

Signed-off-by: Kefu Chai <kchai@redhat.com>

stop.sh: extract maybe_kill() into a function

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

stop.sh: restructure stop logic

avoid using multiple loops for stopping daemons, and to move the
related logic to a single place for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

stop.sh: add editor variables

to ensure that the editors understanding them can follow our coding
convention.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Warn the user when creating/editing pools without application tags

Added warning icon when no application tag is selected

Fixes: https://tracker.ceph.com/issues/40676
Signed-off-by: Waad Alkhoury <walkhour@redhat.com>

mgr/dashboard: Improve descriptions in some parts of the dashboard

Improves the description in some parts of the dashboard code.

Fixes: https://tracker.ceph.com/issues/49829
Fixes: https://tracker.ceph.com/issues/49969
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #39761 from aclamk/wip-stop-sh-less-kill

stop.sh: prevent forced kill

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40348 from rhcs-dashboard/fix-49606-master

mgr/dashboard: improve telemetry opt-in reminder notification message

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>

tools/ceph-dencoder: build dencoders as plugins

to reduce the memory footprint when linking ceph-dencoder.

* src/tools/ceph-dencoder:
  * build dencoders as shared libraries named with the prefix of
    "den-mod-". so ceph-dencoder can find them
  * install dencoders into $prefix/lib/ceph/denc, so ceph-dencoder
    can find them
  * only expose "register_dencoders()" function from plugins.
  * load plugins in specified directory
* ceph.spec.in: package plugins
* debian: package plugins

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40519 from rhcs-dashboard/50077-vstart-runner-max-required-mgrs

qa/tasks/vstart_runner.py: start max required mgrs

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: rishabh-d-dave <NOT@FOUND>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40055 from yuvalif/wip-yuval-fix-49738

librgw/notifications: initialize kafka and amqp

pybind/mgr/dashboard: move pytest into requirements.txt

before this change, pytest is included by both requirements-lint.txt
and requirements-test.txt. this fails the install-deps.sh script when
collecting the python package wheels:

ERROR: Double requirement given: pytest<4 (from -r requirements-test.txt (line 2)) (already in pytest (from -r requirements-lint.txt (line 12)), name='pytest')

also, since pytest is unconditionally imported in the source, for instance,
in pybind/mgr/dashboard/tests/test_ceph_service.py

it would be more straightforward just to include it in requirements.txt.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40532 from liu-chunmei/seastore_journal_fix

crimson/seastore:fix scan_extents in journal.cc

Reviewed-by: Samuel Just <sjust@redhat.com>

src/rgw/rgw_client_io.h: fix a typo

Patch to correct type.

Signed-off-by: Seongyeop Jeong <seongyeop.jeong@snu.ac.kr>

crimson/seastore:fix scan_extents in journal.cc

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

doc/releases: reorg

- move current release table to index
- add table for past releases and actual EOL
- move past release timeline too
- make timeline less wide (avoid wrapping)
- use full dates, not just month + year
- clean up left-side toctree
- capitalize release names

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases/releases.yaml: add missing releases

pacific initial release
recent octopus and nautilus point releases

Signed-off-by: Sage Weil <sage@newdream.net>

admin/build-doc: do not rebuild venv every time

Downside is you have to delete and re-run if the deps change.  The venv
install is suuuuper slow for me, though, so this is a win.

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases/releases.yaml: add 16.2.0

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases: move 'active-releases' tag

This table shows release dates, EOL, etc.

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases: add major headings for releases

This cleans up the index on the left so that the release name/series
is listed instead of a zillion point releases.

Also, drop the separate page for archived releases, so that the
left-hand index behaves well.

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #40265 from ceph/wip-1610

doc: Add Pacific release notes

Merge pull request #40483 from gregsfortytwo/wip-stretch-mon-location

Improve mon location handling for stretch clusters

Reviewed-by: Sam Just <sjust@redhat.com>

doc/releases/pacific.rst: Spacing

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #40521 from tchaikov/wip-mon-log

mon/Monitor: add a space before "*m" in logging message

Reviewed-by: Sage Weil <sage@redhat.com>

doc: rgw release notes for pacific

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc/releases/pacific.rst: add rbd highlights

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc: add links for pacific cephfs features

Note: cephfs-mirror does not yet have user-facing documentation to link
to.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

doc/releases/pacific.rst: add CEPHX_V2 release note

Landed in pacific in commit a6651bad8f1f ("auth: require CEPHX_V2 by
default").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc/releases/pacific.rst: add RADOS highlights

Signed-off-by: Neha Ojha <nojha@redhat.com>

doc/releases/pacific.rst: add more release notes

Some of these were under >=15.0.0 in master PendingReleaseNotes.

Signed-off-by: Neha Ojha <nojha@redhat.com>

doc: include more CephFS updates

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

doc/releases/pacific: add Dashboard notes

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

doc: add more CephFS release notes for Pacific

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

doc/releases/pacific: a few adjustments

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases/index: add pacific to index

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases/pacific: draft outline, and upgrade instructions

Signed-off-by: Sage Weil <sage@newdream.net>

doc: Add release note for mclock scheduler refinements and profiles

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>

doc: add release note for libcephsqlite

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

doc: remove aggressive scrubbing from pacific release notes

This was reverted in pacific by 673b5ea4ae988096d7165f7ff166f6c556345386

Signed-off-by: Josh Durgin <jdurgin@redhat.com>

doc: Add Pacific release notes

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge PR #40509 into master

* refs/pull/40509/head:
qa/tasks/cephfs: create enough subvolumes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #40515 from tchaikov/wip-system-zstd

cmake, script/run-make: enable WITH_SYSTEM_ZSTD on focal

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #40527 from ceph/wip-14219

doc/release/nautilus.rst: Correct regressed version

doc/cephadm: rewrite osd.rst "Remove an OSD"

This commit rewrites the entire "Remove an OSD"
section of the "OSD Service" chapter of the
cephadm book.

I got carried away and didn't break this one into
four smaller PRs, and I'm sorry in advance to
whomever ends up reviewing this. I'll break "Advanced
OSD Service Specifications", the next section in the
queue, into multiple sections.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #40368 from zdover23/wip-doc-cephadm-osd-deploy-osd-rewrite-2021-Mar-25

doc/cephadm: rewrite part of "deploy osds"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #40374 from zdover23/wip-doc-cephadm-osd-dry-run-rewrite-2021-Mar-25

doc/cephadm: rewrite "dry run" section in osd.rst

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

doc/release/nautilus.rst: Correct regressed version

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #40370 from MrFreezeex/fix-perfdump-rbd-mirror

rbd-mirror: fix UB while registering perf counters

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #40525 from tchaikov/wip-50079

cmake: do not pass extra param to crimson tests

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

cmake: do not pass extra param to crimson tests

Fixes: https://tracker.ceph.com/issues/50079
Signed-off-by: Kefu Chai <kchai@redhat.com>

mon/Monitor: add a space before "*m" in logging message

for better readability, otherwise the log reads like:

handle_probe_probe mon.5 v2:192.168.1.234:3300/0mon_probe(probe 77f26cbf-918c-44c5-b2ff-63a1ae713839 ...

Signed-off-by: Kefu Chai <kchai@redhat.com>

qa/tasks/vstart_runner.py: start max required mgrs

Pass environment copy with max required mgrs when shell kwarg is True.

Fixes: https://tracker.ceph.com/issues/50077
Signed-off-by: Alfonso Martínez <almartin@redhat.com>

osd: osdmap: do not assert target_v when encoding under stretch mode

As in dd63a3e21fb6d63b8951a6542fb09f98b79b8cd6 for the OSDMap, this
caused crashes when encoding for kernel clients, and is unnecessary
for servers because they are separately gated.

I did a full audit of every instance of "assert" I added to the codebase
to make sure this is the very last one of these issues.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>

mon: let users specify a crush location on boot, and send it in MMonJoin

Go to some effort to look at our location in the monmap and update it the
same way we update names or IP addresses when necessary. Let users
pass in the location on the CLI via "--set-crush-location".

Signed-off-by: Greg Farnum <gfarnum@redhat.com>

mon: messages: Extend MMonJoin so it can provide a crush_location on join

This will let newly-created monitors auto-join on startup in stretch mode, by
providing the needed location.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>

script/run-make: enable WITH_SYSTEM_ZSTD on focal

to speed up the build for "make check"

Signed-off-by: Kefu Chai <kchai@redhat.com>

cmake: allow use libzstd in system

since we are moving the test nodes from bionic to focal, we are able to
use the prebuilt libzstd libraries when running "make check". to speed
up the build and test, in this change:

* add FindZstd.cmake which allows us to use the libzstd in system
* extract BuildZstd.cmake for better readability
* add an option named "WITH_SYSTEM_ZSTD", which defaults to "OFF",
  so user can enable it on demand.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40449 from tchaikov/wip-mds-autoscaler-ann

pybind/mgr/mds_autoscaler: add type annotation

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #40505 from tchaikov/wip-progress

mgr/PyModule: put mgr_module_path before Py_GetPath()

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge PR #40471 into master

* refs/pull/40471/head:
qa/suites/rados/cephadm: stop testing on broken focal kubic podman

Reviewed-by: Kefu Chai <kchai@redhat.com>

qa/tasks/cephfs: create enough subvolumes

... in a subvolume group so that the desired number of ephmerally pinned
subtrees are created for the subvolume group, which has the distributed
ephemeral pin policy set on it.

Fixes: https://tracker.ceph.com/issues/48411
Signed-off-by: Ramana Raja <rraja@redhat.com>

Merge pull request #40503 from ceph/wip-14219

doc: 14.2.19 Release Note