src: use entity_addr_t::parse(string_view) when possible

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

msg/msg_types: pass TYPE_DEFAULT as default_type to entity_addr_t::parse()

TYPE_NONE equals to 0, and we use it for the default value of entity's
messenger protocol version, if it is not specified. but we always use
TYPE_DEFAULT for the protocol version if it's not specified in the
parsed string or the parameter.

so we can just simplify the logic by assigning it to `newtype`, and
assign the parse value to `new_type` for better readability.

Signed-off-by: Kefu Chai <kchai@redhat.com>

msg/msg_types: add a default_type param to entity_addr_t::parse()

so it can be used in more places.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40124 from adk3798/format-help

pybind/ceph_argparse: print --format flag name in help descs

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #40316 from batrick/i49605

pybind/mgr/volumes: avoid deadlock in ceph-mgr Finisher thread

Reviewed-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #40555 from jecluis/wip-cephadm-fix-apparmor.master

cephadm: ignore apparmor if profiles file is empty

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #38500 from pdvian/wip-print-weight

crush/CrushCompiler: print weight with uniform precision

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #38258 from badone/wip-tracker-48336-monmaptool-enforce-ip-better

monmaptool: Don't call set_port on an invalid address

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40518 from Rethan/fix-client-message-throttle-max

osd: allow osd_client_message_size throttle set to zero

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40444 from TheJJ/ensure-fsck-transactions

os/bluestore: ensure fsck repair transactions succeed

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #40457 from lihuibng/crush-bug

crush/CrushLocation: do not print logging message in constructor

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40488 from lxbsz/typo

mgr: fix the desc typo for mds PyCFunction methods

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40168 from amathuria/wip-amathuria-fix-mon-trimming

mon: Modifying trim logic to change paxos_service_trim_max dynamically

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40498 from guits/guits-quick_fix

cephadm: fix a typo

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #40538 from tchaikov/wip-msg-type-cleanup

msg/msg_types: let ceph_entity_name::parse() accept string_view

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>

Merge pull request #40556 from liewegas/mon-no-config-indent

mon/ConfigMonitor: do not indent 'config dump' output

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40574 from badone/wip-submanager-contatiner-failure-tracker-50118

install-deps: Use dnf config-manager

Reviewed-by: Kefu Chai <kchai@redhat.com>

install-deps: Use dnf config-manager

Using subscription-manager will fail in a container so use dnf
config-manager which should work on bare metal as well as in a
container.

Fixes: https://tracker.ceph.com/issues/50118
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

msg/msg_types: remove entity_name_t::parse(const char*...)

it can be replaced with entity_name_t::parse(string_view)

also refactor entity_name_t::parse(string_view) a little bit, to
embed the logic of `entity_name_t::parse(const char*...)` in it.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40435 from tchaikov/wip-48893

common/pick_address: Allow binding on loopback iface

Reviewed-by: Sage Weil <sage@redhat.com>

common/pick_address: Allow binding on loopback iface

in 6147c0917157efd2d35610e759685656a4989abb, "lo" is also skipped when
daemon is trying to find an address to bind. but that change reverts the
fix of 201b59204374ebdab91bb554b986577a97b19c36, to address the problem.

an option named "ms_bind_exclude_lo_iface" is added, it defaults to
"true". but it can be changed to false to allow daemon to bind on "lo".

Fixes: https://tracker.ceph.com/issues/50012
Signed-off-by: Kefu Chai <kchai@redhat.com>

common/pick_address: pass string by reference

to silence warnings from clang-tidy.

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/pick_address: use scope_guard for freeifaddrs()

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/pick_addr: refactor pick_address.cc and ipaddr.cc

* do not replicate the same logic in IPv4 and IPv6 paths
* use helpers returning bool for filtering the candidate addresses
  for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

common/pick_address: document find_ip_in_subnet_list()

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40531 from sseshasa/wip-mclock-config-ref-doc

doc: Add mclock configuration reference documentation

Reviewed-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #40456 from wjwithagen/wjw-fix-boost-version

cmake: bump the required boost version to 1.73

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40565 from tchaikov/wip-crimson-header-cleanup

crimson/osd: include headers at where they are used

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>

crimson/osd: include headers at where they are used

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40564 from tchaikov/wip-crimson-internal_client_request-lite

crimson/osd: cleanups preparing for InternalClientRequest infrastructure.

Reviewed-by: Kefu Chai <kchai@redhat.com>

crimson/osd: pg_backend.h doesn't depend on pg.h anymore.

It's not only unnecessary but it also causes a depedency hell.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: use obc->get_oid() instead of passing hobject_t around.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/common: let error handlers to return errorated futures.

Before the change an error handler (a callable passed as second
or further parameters to `safe_then()`) was supposed to return
`seastar::future<..>` if it handled the errors or one of allowed
error types otherwise (like `crimson::ct_error::enoent`). Now
they may return also an erroratored future (`errator<ErrorT>::future<...>`)
and its error-set will fused with other sources of errors to be
included in errorator `safe_then()` returns.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: OpsExecuter::get_target() returns const reference now.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/common: replace UTF-8 with ASCII in errorator's stateful_error_t.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/common: stateful_error_t allows for void-taking handlers.

Before this commit there was an inconsistencty between
`unthrowable_wrapper::handle()` and `stateful_error_t::handle()`
in the regard of parameters the provided handler had to accept.
The former was fine with void-taking handlers while the latter
was not.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: drop the never used ctors of osd_op_params_t.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: std::move func in pg::with_*_obc().

Well, likely all the commit does is just appending a couple
of extra bytes. Though, strictly juding, a func should be
`std::move()`d before calling in those cases. Otherwise we
can miss e.g. the `operator() &&` overload.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: use the alias for OpsExecuter in PG::do_osd_ops().

It's already defined there. We've just missed this fact in
one place.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: fix a thinko in the comment about OpsExecuter.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

crimson/osd: drop ObjectContext::loaded as it's never read.

The `PG::with_obc*` machinery uses the `existed` marker
provided by the LRU cache subsystem.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #40533 from Seong-yeop/master

src/rgw/rgw_client_io.h: fix a typo

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40540 from tchaikov/wip-stop.sh

stop.sh: restructure stop logic

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #40454 from zdover23/wip-doc-cephadm-osd-remove-main-text-rewrite-2021-Mar-26

doc/cephadm: rewrite osd.rst "Remove an OSD"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

mon/ConfigMonitor: do not indent 'config dump' output

The indentation is misleading.  For example,

  mgr                                  advanced  mgr/telemetry/last_opt_revision       3                                                                                  *
  osd                                  advanced  osd_max_backfills                     10
  osd                                  basic     osd_memory_target                     6442450944
  osd                                  advanced  osd_scrub_auto_repair                 true
    mds.ar                             basic     mds_join_fs                           ar
    client.rgw.foo                     basic     rgw_frontends                         beast port=8080                                                                    *

The indentation kind of implies that mds.ar (or client.whatever) is
beneath 'osd', which it is not, and there rarely a 'client' scoped
option to make it look right.  Same problem for osd.foo etc.

Also, it is IMO easier to see the nesting structure when things align
naturally. e.g.

global
osd
osd.1
osd.2
mds
mds.foo
mds.foo.bar
client.foo.bar
...

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #39092 from adamemerson/wip-datalog-genbacking

rgw: Fixes and Improvements for Datalog

Reviewed-By: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-By: Casey Bodley <cbodley@redhat.com>

cephadm: ignore apparmor if profiles file is empty

Signed-off-by: Joao Eduardo Luis <joao@suse.com>

Merge pull request #40548 from tchaikov/wip-doc-tweaks

doc: tweak .admonition.important and command line block formatting tweaks

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

doc/rbd: tweak the format of command line blocks

to use the "prompt" directive for better rendering.

Signed-off-by: Kefu Chai <kchai@redhat.com>

doc/_themes: tweak .admonition.important

do not render the links in "important" block in gray, it's not
readable in light red background. so use the blue and purple colors
specified by sphinx_rtd_theme.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge PR #40524 into master

* refs/pull/40524/head:
doc: document CephFS Snapshot Mirroring

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #40535 from tchaikov/wip-dashboard-pytest

pybind/mgr/dashboard: move pytest into requirements.txt

Reviewed-by: Sebastian Wagner <swagner@suse.com>

Merge PR #40504 into master

* refs/pull/40504/head:
doc/security: no gpg keys yet
doc/security: restructure a bit
doc/security: add security section

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #40542 from tchaikov/wip-radosgw-admin-realm-rm

rgw/rgw_admin: s/realm delete/realm rm/

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #40541 from tchaikov/wip-executable-without-shebang

os/bluestore: remove executable bit of source file

Reviewed-by: Sage Weil <sage@redhat.com>

msg/msg_types: move ceph_entity_name::parse() into .cc

for faster compilation.

Signed-off-by: Kefu Chai <kchai@redhat.com>

msg/msg_types: let ceph_entity_name::parse() accept string_view

instead of accepting string, use string_view for the parsed string.

so the caller does not have to construct a temporary std::string object
for passing the string to be parsed.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40173 from rhcs-dashboard/fix-40676-master

mgr/dashboard: Warn the user when creating/editing pools without application tags

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/security: no gpg keys yet

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #40397 from rhcs-dashboard/update-texts

mgr/dashboard: Improve descriptions in some parts of the dashboard

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>

doc/security: restructure a bit

Signed-off-by: Sage Weil <sage@newdream.net>

doc/security: add security section

- how to report an issue
- describe process for handling vulnerability
- list past issues

Signed-off-by: Sage Weil <sage@newdream.net>

Merge PR #40477 into master

* refs/pull/40477/head:
cephadm: fix failure when using --apply-spec and --shh-user

Reviewed-by: Adam King <adking@redhat.com>

Merge PR #40463 into master

* refs/pull/40463/head:
cephadm: specify addr on bootstrap's host add

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge PR #40478 into master

* refs/pull/40478/head:
mgr/cephadm: don't have upgrade fail if "." in patch section of version

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>

doc: document CephFS Snapshot Mirroring

Signed-off-by: Venky Shankar <vshankar@redhat.com>

doc: Add mclock configuration reference documentation

Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>

Merge PR #40530 into master

* refs/pull/40530/head:
doc/releases: reorg
doc/releases/releases.yaml: add missing releases
admin/build-doc: do not rebuild venv every time
doc/releases/releases.yaml: add 16.2.0
doc/releases: move 'active-releases' tag
doc/releases: add major headings for releases

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>

rgw/rgw_admin: s/realm delete/realm rm/

it was an oversight of fa5398d31f9467b58a8b4eda55d1b5e2bbdb6500

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40451 from tchaikov/wip-dencoder-plugins

tools/ceph-dencoder: build dencoders as plugins

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

os/bluestore: remove executable bit of source file

Signed-off-by: Kefu Chai <kchai@redhat.com>

stop.sh: extract maybe_kill() into a function

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

stop.sh: restructure stop logic

avoid using multiple loops for stopping daemons, and to move the
related logic to a single place for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

stop.sh: add editor variables

to ensure that the editors understanding them can follow our coding
convention.

Signed-off-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: Warn the user when creating/editing pools without application tags

Added warning icon when no application tag is selected

Fixes: https://tracker.ceph.com/issues/40676
Signed-off-by: Waad Alkhoury <walkhour@redhat.com>

mgr/dashboard: Improve descriptions in some parts of the dashboard

Improves the description in some parts of the dashboard code.

Fixes: https://tracker.ceph.com/issues/49829
Fixes: https://tracker.ceph.com/issues/49969
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #39761 from aclamk/wip-stop-sh-less-kill

stop.sh: prevent forced kill

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40348 from rhcs-dashboard/fix-49606-master

mgr/dashboard: improve telemetry opt-in reminder notification message

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>

tools/ceph-dencoder: build dencoders as plugins

to reduce the memory footprint when linking ceph-dencoder.

* src/tools/ceph-dencoder:
  * build dencoders as shared libraries named with the prefix of
    "den-mod-". so ceph-dencoder can find them
  * install dencoders into $prefix/lib/ceph/denc, so ceph-dencoder
    can find them
  * only expose "register_dencoders()" function from plugins.
  * load plugins in specified directory
* ceph.spec.in: package plugins
* debian: package plugins

Signed-off-by: Kefu Chai <kchai@redhat.com>

monmaptool: Don't call set_port on an invalid address

Verify we parse the entire address argument.

Fixes: https://tracker.ceph.com/issues/48336
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40519 from rhcs-dashboard/50077-vstart-runner-max-required-mgrs

qa/tasks/vstart_runner.py: start max required mgrs

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: rishabh-d-dave <NOT@FOUND>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40055 from yuvalif/wip-yuval-fix-49738

librgw/notifications: initialize kafka and amqp

pybind/mgr/dashboard: move pytest into requirements.txt

before this change, pytest is included by both requirements-lint.txt
and requirements-test.txt. this fails the install-deps.sh script when
collecting the python package wheels:

ERROR: Double requirement given: pytest<4 (from -r requirements-test.txt (line 2)) (already in pytest (from -r requirements-lint.txt (line 12)), name='pytest')

also, since pytest is unconditionally imported in the source, for instance,
in pybind/mgr/dashboard/tests/test_ceph_service.py

it would be more straightforward just to include it in requirements.txt.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #40532 from liu-chunmei/seastore_journal_fix

crimson/seastore:fix scan_extents in journal.cc

Reviewed-by: Samuel Just <sjust@redhat.com>

src/rgw/rgw_client_io.h: fix a typo

Patch to correct type.

Signed-off-by: Seongyeop Jeong <seongyeop.jeong@snu.ac.kr>

crimson/seastore:fix scan_extents in journal.cc

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>

doc/releases: reorg

- move current release table to index
- add table for past releases and actual EOL
- move past release timeline too
- make timeline less wide (avoid wrapping)
- use full dates, not just month + year
- clean up left-side toctree
- capitalize release names

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases/releases.yaml: add missing releases

pacific initial release
recent octopus and nautilus point releases

Signed-off-by: Sage Weil <sage@newdream.net>

admin/build-doc: do not rebuild venv every time

Downside is you have to delete and re-run if the deps change.  The venv
install is suuuuper slow for me, though, so this is a win.

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases/releases.yaml: add 16.2.0

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases: move 'active-releases' tag

This table shows release dates, EOL, etc.

Signed-off-by: Sage Weil <sage@newdream.net>

doc/releases: add major headings for releases

This cleans up the index on the left so that the release name/series
is listed instead of a zillion point releases.

Also, drop the separate page for archived releases, so that the
left-hand index behaves well.

Signed-off-by: Sage Weil <sage@newdream.net>

Merge pull request #40265 from ceph/wip-1610

doc: Add Pacific release notes

Merge pull request #40483 from gregsfortytwo/wip-stretch-mon-location

Improve mon location handling for stretch clusters

Reviewed-by: Sam Just <sjust@redhat.com>

doc/releases/pacific.rst: Spacing

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #40521 from tchaikov/wip-mon-log

mon/Monitor: add a space before "*m" in logging message

Reviewed-by: Sage Weil <sage@redhat.com>

doc: rgw release notes for pacific

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc/releases/pacific.rst: add rbd highlights

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

doc: add links for pacific cephfs features

Note: cephfs-mirror does not yet have user-facing documentation to link
to.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

doc/releases/pacific.rst: add CEPHX_V2 release note

Landed in pacific in commit a6651bad8f1f ("auth: require CEPHX_V2 by
default").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>