]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agodoc/rados: rewrite mclock docs (2 of 2) 40723/head
Zac Dover [Fri, 9 Apr 2021 10:49:15 +0000 (20:49 +1000)]
doc/rados: rewrite mclock docs (2 of 2)

This is my second attempt to rewrite the
second half of the mclock docs. The first attempt
is enshrined in https://github.com/ceph/ceph/pull/40571,
in which I got cute with git and got burned.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #40510 from aclamk/wip-bluestore-sharding-rst
Josh Durgin [Thu, 8 Apr 2021 22:36:27 +0000 (15:36 -0700)]
Merge pull request #40510 from aclamk/wip-bluestore-sharding-rst

doc: Add BlueStore sharding documentation

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge PR #40486 into master
Patrick Donnelly [Thu, 8 Apr 2021 18:35:05 +0000 (11:35 -0700)]
Merge PR #40486 into master

* refs/pull/40486/head:
mds: trim cache regularly for standby-replay
mds: remove extra heap release

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
4 years agoMerge PR #40520 into master
Patrick Donnelly [Thu, 8 Apr 2021 18:34:21 +0000 (11:34 -0700)]
Merge PR #40520 into master

* refs/pull/40520/head:
mds/scrub: background scrub error fixes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40633 into master
Patrick Donnelly [Thu, 8 Apr 2021 18:33:41 +0000 (11:33 -0700)]
Merge PR #40633 into master

* refs/pull/40633/head:
mds: ensure export_pin rank < max_mds

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40638 into master
Patrick Donnelly [Thu, 8 Apr 2021 18:33:08 +0000 (11:33 -0700)]
Merge PR #40638 into master

* refs/pull/40638/head:
mds: do not show the default auth if it's unambiguous
mds: switch to rank number instead

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #40617 from tchaikov/wip-system-pmem
Kefu Chai [Thu, 8 Apr 2021 14:57:23 +0000 (22:57 +0800)]
Merge pull request #40617 from tchaikov/wip-system-pmem

install-deps.sh: install libpmem libraries if WITH_PMEM is set

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40467 into master
Patrick Donnelly [Thu, 8 Apr 2021 14:28:10 +0000 (07:28 -0700)]
Merge PR #40467 into master

* refs/pull/40467/head:
doc: detail `fs snapshot mirror daemon status` mgr command
doc: s/<fs>/<fs_name>/g

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
4 years agoMerge pull request #40654 from rzarzynski/wip-crimson-notify-lifetime
Kefu Chai [Thu, 8 Apr 2021 12:37:41 +0000 (20:37 +0800)]
Merge pull request #40654 from rzarzynski/wip-crimson-notify-lifetime

crimson/osd: fix the lifetime of Notify during timeouts

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40641 from idryomov/wip-require-ceph-common-for-ioc
Ilya Dryomov [Thu, 8 Apr 2021 11:07:44 +0000 (13:07 +0200)]
Merge pull request #40641 from idryomov/wip-require-ceph-common-for-ioc

packaging: require ceph-common for immutable object cache daemon

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: improve debugs around Watch / Notify. 40654/head
Radoslaw Zarzynski [Wed, 7 Apr 2021 19:49:17 +0000 (19:49 +0000)]
crimson/osd: improve debugs around Watch / Notify.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson/osd: fix the lifetime of Notify during timeouts.
Radoslaw Zarzynski [Wed, 7 Apr 2021 19:48:49 +0000 (19:48 +0000)]
crimson/osd: fix the lifetime of Notify during timeouts.

This fixes a segfault during `LibRadosWatchNotify.WatchNotify2Timeout`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agodoc: detail `fs snapshot mirror daemon status` mgr command 40467/head
Venky Shankar [Mon, 29 Mar 2021 08:59:58 +0000 (04:59 -0400)]
doc: detail `fs snapshot mirror daemon status` mgr command

@leseb noticed that this interface did not have any documentation. Thanks!

Fixes: http://tracker.ceph.com/issues/50229
Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agodoc: s/<fs>/<fs_name>/g
Venky Shankar [Mon, 29 Mar 2021 09:29:54 +0000 (05:29 -0400)]
doc: s/<fs>/<fs_name>/g

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agorun-make-check: enable WITH_RBD_RWL when WITH_PMEM is true 40617/head
Kefu Chai [Thu, 8 Apr 2021 09:12:38 +0000 (17:12 +0800)]
run-make-check: enable WITH_RBD_RWL when WITH_PMEM is true

so we can at least build-test the rwl cache plugin in "make check" run.

this is an opt-in option which is only enabled if WITH_PMEM is "true",
we will set it in the corresponding ceph-build job.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoinstall-deps.sh: install libpmem libraries if WITH_PMEM is set
Kefu Chai [Tue, 6 Apr 2021 12:17:12 +0000 (20:17 +0800)]
install-deps.sh: install libpmem libraries if WITH_PMEM is set

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodoc: Add BlueStore sharding documentation 40510/head
Adam Kupczyk [Tue, 30 Mar 2021 20:56:58 +0000 (22:56 +0200)]
doc: Add BlueStore sharding documentation

Provide sharding explanation, configuration parameters explanation.
Provide resharding tool example into Pacific format.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Co-authored-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #40596 from tchaikov/wip-cmake-clean
Kefu Chai [Thu, 8 Apr 2021 07:26:07 +0000 (15:26 +0800)]
Merge pull request #40596 from tchaikov/wip-cmake-clean

cmake: remove created directory when "clean" target is run

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoMerge pull request #40342 from batrick/snap_schedule-qa-fixes
Venky Shankar [Thu, 8 Apr 2021 06:21:05 +0000 (11:51 +0530)]
Merge pull request #40342 from batrick/snap_schedule-qa-fixes

qa: snap_schedule test debugging

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 years agoMerge pull request #40625 from TRYTOBE8TME/wip-rgw-notifications
Yuval Lifshitz [Thu, 8 Apr 2021 05:32:45 +0000 (08:32 +0300)]
Merge pull request #40625 from TRYTOBE8TME/wip-rgw-notifications

rgw/test: Changing force-branch to master

4 years agoMerge pull request #40622 from batrick/dev-make
Kefu Chai [Thu, 8 Apr 2021 04:55:37 +0000 (12:55 +0800)]
Merge pull request #40622 from batrick/dev-make

doc: update some docs still referring to make

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40647 from rzarzynski/wip-crimson-notify-send_comp-broken-debug
Kefu Chai [Thu, 8 Apr 2021 03:58:56 +0000 (11:58 +0800)]
Merge pull request #40647 from rzarzynski/wip-crimson-notify-send_comp-broken-debug

crimson/osd: fix broken debug in Notify::send_completion().

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
4 years agoMerge PR #40204 into master
Patrick Donnelly [Thu, 8 Apr 2021 02:37:40 +0000 (19:37 -0700)]
Merge PR #40204 into master

* refs/pull/40204/head:
client: cleanup _preadv_pwritev_locked()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
4 years agoMerge PR #40427 into master
Patrick Donnelly [Thu, 8 Apr 2021 02:37:00 +0000 (19:37 -0700)]
Merge PR #40427 into master

* refs/pull/40427/head:
mds: skip the buffer in UnknownPayload::decode()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40611 into master
Patrick Donnelly [Thu, 8 Apr 2021 02:35:58 +0000 (19:35 -0700)]
Merge PR #40611 into master

* refs/pull/40611/head:
qa: retry cloning the ceph.git

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #40636 from tchaikov/wip-50196
Kefu Chai [Thu, 8 Apr 2021 02:15:33 +0000 (10:15 +0800)]
Merge pull request #40636 from tchaikov/wip-50196

qa/tasks/mgr: skip test_diskprediction_local on python>=3.8

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 years agomds: ensure export_pin rank < max_mds 40633/head
Yanhu Cao [Wed, 7 Apr 2021 02:13:07 +0000 (10:13 +0800)]
mds: ensure export_pin rank < max_mds

Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
4 years agoMerge pull request #40632 from adamemerson/wip-warnless-4now
Adam C. Emerson [Wed, 7 Apr 2021 20:38:22 +0000 (16:38 -0400)]
Merge pull request #40632 from adamemerson/wip-warnless-4now

Warning Cleanup and Clang Compile Fix

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
4 years agorgw/test: Changing force-branch to master 40625/head
Kalpesh [Tue, 6 Apr 2021 15:59:43 +0000 (21:29 +0530)]
rgw/test: Changing force-branch to master

This PR includes 2 things:
1. Changing force-branch to master and removing the git-remote. This change was forgetten for PR #39139.
2. Proper cleanup/removal after completion of commands more precisely removing the kafka logs directory.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
4 years agotest/osd: Change const copy in loop to const reference 40632/head
Adam C. Emerson [Tue, 6 Apr 2021 19:23:58 +0000 (15:23 -0400)]
test/osd: Change const copy in loop to const reference

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Fix brace-enclosed-scalar warning
Adam C. Emerson [Tue, 6 Apr 2021 19:21:30 +0000 (15:21 -0400)]
rgw: Fix brace-enclosed-scalar warning

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Fix warnings from s3select
Adam C. Emerson [Tue, 6 Apr 2021 19:20:55 +0000 (15:20 -0400)]
rgw: Fix warnings from s3select

Since this is a submodule, just wrap the include in a pragma.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Remove unused variables
Adam C. Emerson [Tue, 6 Apr 2021 19:19:06 +0000 (15:19 -0400)]
rgw: Remove unused variables

(Also mark the file as C++ rather than C)

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agotest/librados: Remove unused capture
Adam C. Emerson [Tue, 6 Apr 2021 19:18:34 +0000 (15:18 -0400)]
test/librados: Remove unused capture

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorbd: Fix ambiguous call to addr.parse
Adam C. Emerson [Tue, 6 Apr 2021 18:00:48 +0000 (14:00 -0400)]
rbd: Fix ambiguous call to addr.parse

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Fix signed comparison warning
Adam C. Emerson [Tue, 6 Apr 2021 17:59:14 +0000 (13:59 -0400)]
rgw: Fix signed comparison warning

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agotest/librados: Disambiguate function call
Adam C. Emerson [Tue, 6 Apr 2021 17:28:45 +0000 (13:28 -0400)]
test/librados: Disambiguate function call

Cleaning up a warning.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Add missing extension to file in sources list
Adam C. Emerson [Tue, 6 Apr 2021 17:27:45 +0000 (13:27 -0400)]
rgw: Add missing extension to file in sources list

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agoMerge pull request #38737 from IlsooByun/objmeta-key-underscore
J. Eric Ivancich [Wed, 7 Apr 2021 16:31:37 +0000 (12:31 -0400)]
Merge pull request #38737 from IlsooByun/objmeta-key-underscore

rgw: keep underscore in metatdata key

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
4 years agoMerge pull request #39749 from linuxbox2/wip-olock-fixes
J. Eric Ivancich [Wed, 7 Apr 2021 16:31:10 +0000 (12:31 -0400)]
Merge pull request #39749 from linuxbox2/wip-olock-fixes

rgw: objectlock: improve client error messages

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #40263 from ivancich/wip-update-listing-comments
J. Eric Ivancich [Wed, 7 Apr 2021 16:30:47 +0000 (12:30 -0400)]
Merge pull request #40263 from ivancich/wip-update-listing-comments

rgw: update bucket listing log output

Reviewed-by: Ali Maredia <amaredia@redhat.com>
4 years agoMerge pull request #40570 from zdover23/wip-doc-mclock-rewrite-first-half-2021-Apr-2
Neha Ojha [Wed, 7 Apr 2021 15:53:35 +0000 (08:53 -0700)]
Merge pull request #40570 from zdover23/wip-doc-mclock-rewrite-first-half-2021-Apr-2

doc/rados: rewrite mclock-config-ref

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
4 years agoMerge pull request #40639 from yuvalif/wip-yuval-fix-50201
Casey Bodley [Wed, 7 Apr 2021 15:03:34 +0000 (11:03 -0400)]
Merge pull request #40639 from yuvalif/wip-yuval-fix-50201

rgw/multisite: return correct error code when op fails

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agocrimson/osd: fix broken debug in Notify::send_completion(). 40647/head
Radoslaw Zarzynski [Wed, 7 Apr 2021 14:35:06 +0000 (14:35 +0000)]
crimson/osd: fix broken debug in Notify::send_completion().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoqa/tasks/mgr: skip test_diskprediction_local on python>=3.8 40636/head
Kefu Chai [Wed, 7 Apr 2021 05:38:27 +0000 (13:38 +0800)]
qa/tasks/mgr: skip test_diskprediction_local on python>=3.8

query the python version before trying to test diskprediction_local

Fixes: https://tracker.ceph.com/issues/50196
Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40581 from weixinwei/master
Kefu Chai [Wed, 7 Apr 2021 13:18:01 +0000 (21:18 +0800)]
Merge pull request #40581 from weixinwei/master

os/bluestore/BlueFS: do not _flush_range deleted files

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
4 years agoMerge pull request #40601 from cbodley/wip-50147
Casey Bodley [Wed, 7 Apr 2021 12:49:49 +0000 (08:49 -0400)]
Merge pull request #40601 from cbodley/wip-50147

qa/rgw: move ignore-pg-availability.yaml out of suites/rgw

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
4 years agoMerge pull request #39907 from guits/fix_get_first_lv
Rishabh Dave [Wed, 7 Apr 2021 11:32:05 +0000 (17:02 +0530)]
Merge pull request #39907 from guits/fix_get_first_lv

ceph-volume: `get_first_lv()` refactor

4 years agopackaging: require ceph-common for immutable object cache daemon 40641/head
Ilya Dryomov [Wed, 7 Apr 2021 09:36:53 +0000 (11:36 +0200)]
packaging: require ceph-common for immutable object cache daemon

This daemon has a systemd service which starts it with --setuser ceph
--setgroup ceph.  "ceph" user and group are created by ceph-common and
won't be there unless ceph-common is installed.

Fixes: https://tracker.ceph.com/issues/50207
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 years agoMerge pull request #40624 from rhcs-dashboard/read-only-config-access-disable
Ernesto Puerta [Wed, 7 Apr 2021 11:04:28 +0000 (13:04 +0200)]
Merge pull request #40624 from rhcs-dashboard/read-only-config-access-disable

mgr/dashboard: Revoke read-only user's access to Manager modules

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agomgr/selftest: add a command for querying python version
Kefu Chai [Wed, 7 Apr 2021 06:40:05 +0000 (14:40 +0800)]
mgr/selftest: add a command for querying python version

so the test driver can skip certain tests based on the version of python
runtime on the test node

Fixes: https://tracker.ceph.com/issues/50196
Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agorgw/multisite: return correct error code when op fails 40639/head
Yuval Lifshitz [Wed, 7 Apr 2021 09:49:50 +0000 (12:49 +0300)]
rgw/multisite: return correct error code when op fails

when trying to disable/enbale sync on non-master zone

Fixes: https://tracker.ceph.com/issues/50201
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agoceph-volume: `get_first_*()` refactor 39907/head
Guillaume Abrioux [Mon, 8 Mar 2021 08:59:26 +0000 (09:59 +0100)]
ceph-volume: `get_first_*()` refactor

As indicated by commit 17957d9beb42a04b8f180ccb7ba07d43179a41d3 those
fuctions were meant to avoid writing something like following:

```
lvs = get_lvs()
if len(lvs) >= 1:
lvs = lv[0]
```

Those functions should return `None` if 0 or more than 1 item is returned.
The current name of these functions are confusing and can lead to thinking that
we just want the first item returned, even though it returns more than 1
item, let's rename them to `get_single_pv()`, `get_single_vg()` and
`get_single_lv()`

Closes: https://tracker.ceph.com/issues/49643
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
4 years agoMerge pull request #40637 from ronen-fr/wip-ronenf-rgw-logbacking
Ronen Friedman [Wed, 7 Apr 2021 07:13:01 +0000 (10:13 +0300)]
Merge pull request #40637 from ronen-fr/wip-ronenf-rgw-logbacking

rgw: fix lambda capture of a non-variable
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
4 years agoMerge pull request #40604 from liewegas/podman-registries-conf
Kefu Chai [Wed, 7 Apr 2021 07:12:24 +0000 (15:12 +0800)]
Merge pull request #40604 from liewegas/podman-registries-conf

qa/distros/podman: preserve registries.conf

Reviewed-by: David Galloway <dgallowa@redhat.com>
4 years agoMerge pull request #40487 from tchaikov/wip-boost-1.75
Kefu Chai [Wed, 7 Apr 2021 07:10:34 +0000 (15:10 +0800)]
Merge pull request #40487 from tchaikov/wip-boost-1.75

install-deps.sh: install boost 1.75

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #40583 from a16bitsysop/include
Kefu Chai [Wed, 7 Apr 2021 07:07:34 +0000 (15:07 +0800)]
Merge pull request #40583 from a16bitsysop/include

tools/cephfs_mirror/PeerReplayer.cc: add missing include

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40607 from tchaikov/wip-journald-if-msghdr
Kefu Chai [Wed, 7 Apr 2021 07:06:25 +0000 (15:06 +0800)]
Merge pull request #40607 from tchaikov/wip-journald-if-msghdr

common: disable journald logging backend if struct msghdr is not found

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
4 years agoMerge pull request #40609 from tchaikov/wip-common-buffer-cleanup
Kefu Chai [Wed, 7 Apr 2021 07:05:23 +0000 (15:05 +0800)]
Merge pull request #40609 from tchaikov/wip-common-buffer-cleanup

common/buffer.cc: use shift_round_up() when appropriate

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agomds: do not show the default auth if it's unambiguous 40638/head
Xiubo Li [Wed, 7 Apr 2021 03:08:03 +0000 (11:08 +0800)]
mds: do not show the default auth if it's unambiguous

Signed-off-by: Xiubo Li <xiubli@redhat.com>
4 years agomds: switch to rank number instead
Xiubo Li [Tue, 6 Apr 2021 08:05:28 +0000 (16:05 +0800)]
mds: switch to rank number instead

Signed-off-by: Xiubo Li <xiubli@redhat.com>
4 years agorgw: fix lambda capture of a non-variable 40637/head
Ronen Friedman [Wed, 7 Apr 2021 05:42:02 +0000 (08:42 +0300)]
rgw: fix lambda capture of a non-variable

One cannot just capture a structured binding "non-variable".

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 years agoos/bluestore/BlueFS: do not _flush_range deleted files 40581/head
weixinwei [Sun, 4 Apr 2021 05:30:10 +0000 (13:30 +0800)]
os/bluestore/BlueFS: do not _flush_range deleted files

Fixes: https://tracker.ceph.com/issues/49861
Signed-off-by: weixinwei <weixw3@lenovo.com>
4 years agoMerge PR #40603 into master
Sage Weil [Tue, 6 Apr 2021 21:28:08 +0000 (17:28 -0400)]
Merge PR #40603 into master

* refs/pull/40603/head:
qa/tasks/ceph.conf: shorten cephx TTL for testing

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
4 years agoMerge pull request #40190 from cbodley/wip-qa-rgw-sigv4-warnings
Casey Bodley [Tue, 6 Apr 2021 20:08:28 +0000 (16:08 -0400)]
Merge pull request #40190 from cbodley/wip-qa-rgw-sigv4-warnings

rgw: silence some unused variable warnings

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
4 years agoMerge PR #40602 into master
Sage Weil [Tue, 6 Apr 2021 20:04:27 +0000 (16:04 -0400)]
Merge PR #40602 into master

* refs/pull/40602/head:
qa/tasks/cephadm: add apply() method/task

Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agoMerge PR #40597 into master
Sage Weil [Tue, 6 Apr 2021 20:04:17 +0000 (16:04 -0400)]
Merge PR #40597 into master

* refs/pull/40597/head:
cephadm: pass '-i' to docker|podman run for shell|enter

Reviewed-by: Adam King <adking@redhat.com>
4 years agoMerge pull request #40553 from dang/wip-dang-zipper-list
J. Eric Ivancich [Tue, 6 Apr 2021 17:49:35 +0000 (13:49 -0400)]
Merge pull request #40553 from dang/wip-dang-zipper-list

RGW Zipper - Make sure bucket list progresses

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
4 years agoMerge PR #39939 into master
Patrick Donnelly [Tue, 6 Apr 2021 17:46:23 +0000 (10:46 -0700)]
Merge PR #39939 into master

* refs/pull/39939/head:
cephfs: ceph-dokan - properly log the mounted root
cephfs: Update ceph-dokan "--removable" flag
cephfs: document using multiple fs on Windows
cephfs: provide additional volume details on Windows
cephfs: add ceph-dokan unmap command

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40418 into master
Patrick Donnelly [Tue, 6 Apr 2021 17:45:00 +0000 (10:45 -0700)]
Merge PR #40418 into master

* refs/pull/40418/head:
test: unmount when finished ino_release_cb
test: wait a time for inode release
qa: move ino_release_cb to libcephfs sub-suite
qa: simplify recall triggers for bug
qa: fix name for qa task referencing tracker issue

Reviewed-by: Jeff Layton <jlayton@redhat.com>
4 years agoMerge PR #40460 into master
Patrick Donnelly [Tue, 6 Apr 2021 17:43:54 +0000 (10:43 -0700)]
Merge PR #40460 into master

* refs/pull/40460/head:
client: only check pool permissions for regular files

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40465 into master
Patrick Donnelly [Tue, 6 Apr 2021 17:43:12 +0000 (10:43 -0700)]
Merge PR #40465 into master

* refs/pull/40465/head:
test: bump up retries for `test_mirroring_init_failure_with_recovery` test
test: fix typo
test: disable mgr/mirroring for `test_mirroring_init_failure_with_recovery` test

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40468 into master
Patrick Donnelly [Tue, 6 Apr 2021 17:42:42 +0000 (10:42 -0700)]
Merge PR #40468 into master

* refs/pull/40468/head:
mds/metrics: add one whitespace between metric type the metainfo

Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
4 years agoMerge PR #40469 into master
Patrick Donnelly [Tue, 6 Apr 2021 17:41:55 +0000 (10:41 -0700)]
Merge PR #40469 into master

* refs/pull/40469/head:
qa: check mounts attribute in ctx

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40501 into master
Patrick Donnelly [Tue, 6 Apr 2021 17:41:07 +0000 (10:41 -0700)]
Merge PR #40501 into master

* refs/pull/40501/head:
client: fix the opened inodes counter increasing

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agodoc/rados: rewrite mclock-config-ref 40570/head
Zac Dover [Fri, 2 Apr 2021 20:57:51 +0000 (06:57 +1000)]
doc/rados: rewrite mclock-config-ref

This PR rewrites the material provided in
PR#40531, improving its elegance and
readability.

This PR rewrites the first 48 percent of the
material provided in PR#40531.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #40113 from yuvalif/wip-yuval-fix-49799
Yuval Lifshitz [Tue, 6 Apr 2021 16:45:57 +0000 (19:45 +0300)]
Merge pull request #40113 from yuvalif/wip-yuval-fix-49799

rgw/notification: set correct type to "post" and "copy" notifications

4 years agomgr/dashboard: Revoke read-only user's access to Manager modules 40624/head
Nizamudeen A [Tue, 6 Apr 2021 15:54:51 +0000 (21:24 +0530)]
mgr/dashboard: Revoke read-only user's access to Manager modules

This will disable read only user to read/open Manager Modules page in
Ceph Dashboard where some of the security related informations are
shown.

Fixes: https://tracker.ceph.com/issues/50174
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 years agoMerge PR #40620 into master
Patrick Donnelly [Tue, 6 Apr 2021 15:25:49 +0000 (08:25 -0700)]
Merge PR #40620 into master

* refs/pull/40620/head:
cephfs-top: fix typo in help

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40613 into master
Patrick Donnelly [Tue, 6 Apr 2021 15:24:59 +0000 (08:24 -0700)]
Merge PR #40613 into master

* refs/pull/40613/head:
doc/cephfs/nfs: add user id, fs name and key to FSAL block

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agodoc: update some docs still referring to make 40622/head
Patrick Donnelly [Tue, 6 Apr 2021 13:58:13 +0000 (06:58 -0700)]
doc: update some docs still referring to make

We use ninja now.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #40616 from rhcs-dashboard/fix-50044-master
Ernesto Puerta [Tue, 6 Apr 2021 14:33:24 +0000 (16:33 +0200)]
Merge pull request #40616 from rhcs-dashboard/fix-50044-master

mgr/dashboard: debug nodeenv hangs

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agomds: trim cache regularly for standby-replay 40486/head
Patrick Donnelly [Tue, 30 Mar 2021 03:09:30 +0000 (20:09 -0700)]
mds: trim cache regularly for standby-replay

This change is slightly awkward because standby-replay MDS do not do all
the kinds of upkeep a normal active MDS does. In particular, it is not
going to recall client state from clients.

This diff also merges the extra recall_client_state in
MDCache::check_memory_usage into its only caller (the upkeep thread)
where it was also doing a recall. That's just a matter of merging the
recall flags. This has the added benefit of making
MDCache::check_memory_usage callable for all MDS daemons regardless of
state.

Fixes: https://tracker.ceph.com/issues/50048
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agomds: remove extra heap release
Patrick Donnelly [Tue, 30 Mar 2021 03:07:25 +0000 (20:07 -0700)]
mds: remove extra heap release

We now regularly do this unconditionally in the MDS, see the upkeep
thread.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #40615 from tchaikov/wip-doc-header-css
Kefu Chai [Tue, 6 Apr 2021 14:04:54 +0000 (22:04 +0800)]
Merge pull request #40615 from tchaikov/wip-doc-header-css

doc/_themes: fix the styling of section header

Reviewed-by: Sebastian Wagner <swagner@suse.com>
4 years agodoc/_themes: fix the styling of section header and list items 40615/head
Kefu Chai [Tue, 6 Apr 2021 11:30:28 +0000 (19:30 +0800)]
doc/_themes: fix the styling of section header and list items

in the latest document generated from RtD, the section headers are now
in <section> tags instead of <div class="section">, so update the css
accordingly.

also tweak the style of the list items in unordered list to be the same
as it was.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40587 from tchaikov/wip-addr-parse-cleanup
Kefu Chai [Tue, 6 Apr 2021 12:47:17 +0000 (20:47 +0800)]
Merge pull request #40587 from tchaikov/wip-addr-parse-cleanup

src: use entity_addr_t::parse(string_view) when possible

Reviewed-by: Sage Weil <sage@redhat.com>
4 years agomgr/dashboard: debug nodeenv hangs 40616/head
Ernesto Puerta [Tue, 6 Apr 2021 11:45:15 +0000 (13:45 +0200)]
mgr/dashboard: debug nodeenv hangs

Increase verbosity in nodeenv command for debugging purposes.

Fixes: https://tracker.ceph.com/issues/50044
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
4 years agodoc/cephfs/nfs: add user id, fs name and key to FSAL block 40613/head
Varsha Rao [Tue, 6 Apr 2021 10:06:45 +0000 (15:36 +0530)]
doc/cephfs/nfs: add user id, fs name and key to FSAL block

Fixes: https://tracker.ceph.com/issues/50161
Signed-off-by: Varsha Rao <varao@redhat.com>
4 years agocommon/buffer.cc: use shift_round_up() when appropriate 40609/head
Kefu Chai [Tue, 6 Apr 2021 07:18:42 +0000 (15:18 +0800)]
common/buffer.cc: use shift_round_up() when appropriate

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoqa: retry cloning the ceph.git 40611/head
Xiubo Li [Tue, 6 Apr 2021 07:24:56 +0000 (15:24 +0800)]
qa: retry cloning the ceph.git

The cloning may take a very long time, 2.5 hours for example, usally
it should be done in server minutes. If it really very slow, there
maybe something wrong with the current socket connections, retry it
maybe fixed.

This fixing will timeout the clone command after 30m, and retry it
by doubling the timeout value.

Fixes: https://tracker.ceph.com/issues/50021
Signed-off-by: Xiubo Li <xiubli@redhat.com>
4 years agorgw/notification: set correct type to "post" and "copy" notifications 40113/head
Yuval Lifshitz [Mon, 15 Mar 2021 11:07:39 +0000 (13:07 +0200)]
rgw/notification: set correct type to "post" and "copy" notifications

Fixes: https://tracker.ceph.com/issues/49799
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agocommon: disable journald logging backend if struct msghdr is not found 40607/head
Kefu Chai [Tue, 6 Apr 2021 05:09:13 +0000 (13:09 +0800)]
common: disable journald logging backend if struct msghdr is not found

* cmake/modules/CephChecks.cmake: detect the existence of struct msghdr,
  define HAVE_MSGHDR if it is found
* src/common/CMakeLists.txt: do not compile journald.cc if HAVE_MSGHDR
  is FALSE. as in that case, we cannot use sendmsg() to write to
  journald unix domain socket
* src/test/CMakeLists.txt, src/test/common/CMakeLists.txt: disable test
  exercising journald logging backend if HAVE_MSGHDR is not defined
* src/common/Journald.h: define a dummy JournaldLogger and a dummy
  JournaldClusterLogger when HAVE_MSGHDR is not defined, in order to
  minimize the change in Log.h and Log.cc, otherwise the source code of
  Log.h and Log.cc would be segmented into smaller chunks by
  `ifdef HAVE_MSGHDR` macros.
* src/include/config-h.in.cmake: define a new macro named
  HAVE_MSGHDR.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocephfs-top: fix typo in help 40620/head
Jos Collin [Tue, 6 Apr 2021 06:20:21 +0000 (11:50 +0530)]
cephfs-top: fix typo in help

Signed-off-by: Jos Collin <jcollin@redhat.com>
4 years agoMerge pull request #40582 from a16bitsysop/32bit
Kefu Chai [Tue, 6 Apr 2021 06:35:18 +0000 (14:35 +0800)]
Merge pull request #40582 from a16bitsysop/32bit

src/common/buffer.cc: change cast to static_cast

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40578 from tchaikov/wip-cmake-pmem
Kefu Chai [Tue, 6 Apr 2021 06:31:51 +0000 (14:31 +0800)]
Merge pull request #40578 from tchaikov/wip-cmake-pmem

cmake: require libpmem 1.7 and cleanups

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 years agoMerge pull request #40572 from athanatos/sjust/wip-48613
Kefu Chai [Tue, 6 Apr 2021 06:30:20 +0000 (14:30 +0800)]
Merge pull request #40572 from athanatos/sjust/wip-48613

osd/PeeringState: fix acting_set_writeable min_size check

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #40475 from tchaikov/wip-qa-focal
Kefu Chai [Tue, 6 Apr 2021 06:28:42 +0000 (14:28 +0800)]
Merge pull request #40475 from tchaikov/wip-qa-focal

qa/tests: replaced ubuntu_latest.yaml with ubuntu 20.04

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
4 years agoMerge pull request #40591 from tchaikov/wip-dencoder
Kefu Chai [Tue, 6 Apr 2021 02:31:07 +0000 (10:31 +0800)]
Merge pull request #40591 from tchaikov/wip-dencoder

tools/ceph-dencoder: link against libtcmalloc

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Sage Weil <sage@redhat.com>
4 years agoosd/PeeringState: fix acting_set_writeable min_size check 40572/head
Samuel Just [Fri, 2 Apr 2021 22:30:54 +0000 (22:30 +0000)]
osd/PeeringState: fix acting_set_writeable min_size check

acting.size() >= pool.info.min_size is meant to check min_size against
acting set participants, but acting is a vector with placeholders.
actingset is the representation with placeholders removed.

The upshot of this bug is that the activation process will basically
ignore min_size for an ec pool allowing writes in cases where it
shouldn't.  PastIntervals::check_new_interval, however, performs
the check correctly, and will therefore discount intervals in which
we really did serve writes as not writeable.  This can trigger many
different problem conditions including but not limited to:
  - Unfound objects due to accepting a last_update with insufficient
    osds
  - Lost writes
  - Crashes due to peering rules being violated

This bug was originally introduced with recovery below min_size in
e5a96fd, and then preserved through refactors in 749a13d and 95bec9.

7cb818a exposed it with with expansion of recovery below min_size
to include ec pools (acting.size() is sufficient for replicated
pools).

Fixes: https://tracker.ceph.com/issues/48613
Fixes: https://tracker.ceph.com/issues/48417
Signed-off-by: Samuel Just <sjust@redhat.com>