]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agodoc: Add GPG Keys 40726/head
Hardik Vyas [Fri, 9 Apr 2021 11:41:26 +0000 (17:11 +0530)]
doc: Add GPG Keys

Replaced my GPG key with ceph.com and David's GPG keys

Signed-off-by: Hardik Vyas <hvyas@redhat.com>
4 years agoMerge pull request #40795 from wjwithagen/wjw-fix-ceph-dencoder
Kefu Chai [Mon, 12 Apr 2021 11:47:02 +0000 (19:47 +0800)]
Merge pull request #40795 from wjwithagen/wjw-fix-ceph-dencoder

tools: do not unload plugins during destruction.

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40797 from wjwithagen/wjw-fix-monmap-retval
Kefu Chai [Mon, 12 Apr 2021 10:35:47 +0000 (18:35 +0800)]
Merge pull request #40797 from wjwithagen/wjw-fix-monmap-retval

test: Undo the FreeBSD specific retval test

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40794 from wjwithagen/wjw-fix-promtool
Kefu Chai [Mon, 12 Apr 2021 09:06:47 +0000 (17:06 +0800)]
Merge pull request #40794 from wjwithagen/wjw-fix-promtool

test: Run Dockers only on Linux platforms

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #38120 from kiizawa/wip-cls-remote-read
Kefu Chai [Mon, 12 Apr 2021 08:42:52 +0000 (16:42 +0800)]
Merge pull request #38120 from kiizawa/wip-cls-remote-read

osd: allow remote read by calling cls method from within cls context

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agotest: Undo the FreeBSD specific retval test 40797/head
Willem Jan Withagen [Sun, 11 Apr 2021 14:27:35 +0000 (16:27 +0200)]
test: Undo the FreeBSD specific retval test

Changes to the socket code now result in returning EINVAL
In the past ENOENT was returned which is the FreeBSD error code
if DNS lookup does not work.

And that change is probably because somewhere in the code that
errorcode is not passed verbatim from the systemcall, but is
rewritten in extra evaluation.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agotools: do not unload plugins during destruction. 40795/head
Willem Jan Withagen [Sun, 11 Apr 2021 13:01:22 +0000 (15:01 +0200)]
tools: do not unload plugins during destruction.

FreeBSD ceph-dencoder crashes in the exit() calls, due to
invalid pointer references during the release process of
the loaded libraries.

Often this is signaled by libc reporting:
  __cxa_thread_call_dtors: dtr 0x47efc0 from unloaded dso, skipping

The cause for this is different behaviour between FreeBSD and Linux:
https://groups.google.com/g/bsdmailinglist/c/22ncTZAbDp4/m/Dii_pII5AwAJ
_The FreeBSD implementation here looks racy. If one thread dlcloses an
object while another thread is exiting, we can end up calling a
function at an invalid memory address. It also looks as if it may
be possible to unload one library, load another at the same address,
and end up executing entirely the wrong code, which would have some
serious security implications.

The GNU/Linux equivalent of this function locks the DSO in memory
until all references to it have gone away. A call to dlclose() on
GNU/Linux will not actually unload the library until all threads
with destructors in that library have been unloaded. I believe
that this reuses the same reference counting mechanism that
allows the same library to be dlopened and dlclosed multiple times.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agoMerge pull request #37016 from zhangdaolong/subcommon-bulefs-import
Kefu Chai [Mon, 12 Apr 2021 08:26:34 +0000 (16:26 +0800)]
Merge pull request #37016 from zhangdaolong/subcommon-bulefs-import

os/bluestore:Add subcommand bluefs-import in ceph-bluestore-tool.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40644 from SMIL-Infra/cleanup-slash
Kefu Chai [Mon, 12 Apr 2021 08:23:48 +0000 (16:23 +0800)]
Merge pull request #40644 from SMIL-Infra/cleanup-slash

cephadm: cleanup extra slash in runtime dir

Reviewed-by: Adam King <adking@redhat.com>
4 years agoMerge pull request #40658 from tchaikov/wip-systemd
Kefu Chai [Mon, 12 Apr 2021 08:09:33 +0000 (16:09 +0800)]
Merge pull request #40658 from tchaikov/wip-systemd

cmake: s/HAVE_MSGHDR/WITH_SYSTEMD/

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agoMerge pull request #40635 from pcuzner/prometheus_add_pool_metadata
pcuzner [Mon, 12 Apr 2021 00:02:03 +0000 (12:02 +1200)]
Merge pull request #40635 from pcuzner/prometheus_add_pool_metadata

mgr/prometheus:Improve the pool metadata

4 years agoMerge pull request #39944 from yuvalif/wip-yuval-fix-49650
Yuval Lifshitz [Sun, 11 Apr 2021 18:52:06 +0000 (21:52 +0300)]
Merge pull request #39944 from yuvalif/wip-yuval-fix-49650

rgw/notifications: delete bucket notification object when empty

4 years agotest: Run Dockers only on Linux platforms 40794/head
Willem Jan Withagen [Sun, 11 Apr 2021 12:46:17 +0000 (14:46 +0200)]
test: Run Dockers only on Linux platforms

Running a docker alternative only works if the platform
   is Linux

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
4 years agoMerge pull request #40786 from tchaikov/wip-script-bit
Kefu Chai [Sun, 11 Apr 2021 16:43:46 +0000 (00:43 +0800)]
Merge pull request #40786 from tchaikov/wip-script-bit

build-integration-branch: retry when running into network failures

Reviewed-by: Sage Weil <sage@redhat.com>
4 years agobuild-integration-branch: retry when running into network failures 40786/head
Kefu Chai [Sun, 11 Apr 2021 03:59:41 +0000 (11:59 +0800)]
build-integration-branch: retry when running into network failures

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoos/bluestore/bluestore_tool: Add subcommand blufs-import 37016/head
zhangdaolong [Mon, 7 Sep 2020 01:00:10 +0000 (09:00 +0800)]
os/bluestore/bluestore_tool: Add subcommand blufs-import

Examples
 ceph-bluestore-tool bluefs-import --path /var/lib/ceph/osd/ceph-1 --input-file ./db/CURRENT --dest-file db/CURRENT

Signed-off-by: zhang daolong <zhangdaolong@fiberhome.com>
4 years agobuild-integration-branch: define variables for pr_number and friends
Kefu Chai [Sun, 11 Apr 2021 03:52:16 +0000 (11:52 +0800)]
build-integration-branch: define variables for pr_number and friends

so they can be reused later.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge PR #40577 into master
Sage Weil [Sat, 10 Apr 2021 13:01:58 +0000 (09:01 -0400)]
Merge PR #40577 into master

* refs/pull/40577/head:
cephadm: normalize unqualified repo digests to docker.io
mgr/cephadm/upgrade: normalize unqualified target image

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
4 years agoMerge PR #40537 into master
Sage Weil [Sat, 10 Apr 2021 13:01:27 +0000 (09:01 -0400)]
Merge PR #40537 into master

* refs/pull/40537/head:
cephadm:persist the grafana.db file

Reviewed-by: Sage Weil <sage@redhat.com>
4 years agoMerge PR #40653 into master
Patrick Donnelly [Sat, 10 Apr 2021 03:08:51 +0000 (20:08 -0700)]
Merge PR #40653 into master

* refs/pull/40653/head:
mon: check mdsmap is resizeable before promoting standby-replay

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40642 into master
Patrick Donnelly [Sat, 10 Apr 2021 03:06:21 +0000 (20:06 -0700)]
Merge PR #40642 into master

* refs/pull/40642/head:
client: don't allow access to MDS-private inodes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
4 years agoMerge PR #40481 into master
Patrick Donnelly [Sat, 10 Apr 2021 03:04:32 +0000 (20:04 -0700)]
Merge PR #40481 into master

* refs/pull/40481/head:
qa: test standby-replay with fs:workloads

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40431 into master
Patrick Donnelly [Sat, 10 Apr 2021 03:02:27 +0000 (20:02 -0700)]
Merge PR #40431 into master

* refs/pull/40431/head:
qa/cephfs: remove create_keyring_file from cephfs_test_case.py
qa/cephfs: don't use sudo to write files in /tmp

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
4 years agoMerge PR #40389 into master
Patrick Donnelly [Sat, 10 Apr 2021 02:58:40 +0000 (19:58 -0700)]
Merge PR #40389 into master

* refs/pull/40389/head:
mds: reject lookup ino requests for mds dirs
test: add test for invalid lookup of mdsdir

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
4 years agoMerge pull request #40723 from zdover23/wip-doc-second-attempt-mclock-rewrite-second...
Neha Ojha [Sat, 10 Apr 2021 00:24:41 +0000 (17:24 -0700)]
Merge pull request #40723 from zdover23/wip-doc-second-attempt-mclock-rewrite-second-half-2021-Apr-09

doc/rados: rewrite mclock docs (2 of 2)

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #40738 from jdurgin/wip-librados-docs
Josh Durgin [Fri, 9 Apr 2021 23:48:13 +0000 (16:48 -0700)]
Merge pull request #40738 from jdurgin/wip-librados-docs

include/librados: fix doxygen syntax for docs build

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoinclude/librados: fix doxygen syntax for docs build 40738/head
Josh Durgin [Fri, 9 Apr 2021 22:01:32 +0000 (18:01 -0400)]
include/librados: fix doxygen syntax for docs build

The docs build is now warning about these like:

WARNING: Unparseable C cross-reference: '[in]'
Invalid C declaration: Expected identifier in nested name.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
4 years agocephadm: normalize unqualified repo digests to docker.io 40577/head
Sage Weil [Sat, 3 Apr 2021 13:14:00 +0000 (09:14 -0400)]
cephadm: normalize unqualified repo digests to docker.io

A RepoDigests returned by docker|podman image inspect can either include
the docker.io/ prefix or not.  For reasons that aren't entirely clear,
this may vary between hosts in a cluster.  However, ceph/ceph@sha256:abc...
is the same thing as docker.io/ceph/ceph@sha256:abc..., and should be
treated as such.  Otherwise, upgrade can get into a loop where it pulls
the image on a new host, finds the other variant of the repodigests,
sees no overlap, updates target_digests, and restarts.  (It will then
find the first variant again on the first host and loop.)

Avoid this by normalizing any docker.io digests by always including the
docker.io/ prefix.

Note that it is technically possible that this assumption is wrong: it
may be that the image that already exists on the local host is from a
different registry in registries.conf's unqualified-search-registries.
However, we don't know which, since this is a search list.  In practice,
it should be exceeding rare that an image that *we* are installing using
a fully-qualified image name will end up having an unqualified repodigest
in the local registry.  Hopefully!

Fixes: https://tracker.ceph.com/issues/50114
Signed-off-by: Sage Weil <sage@newdream.net>
4 years agomgr/cephadm/upgrade: normalize unqualified target image
Sage Weil [Tue, 6 Apr 2021 13:36:31 +0000 (09:36 -0400)]
mgr/cephadm/upgrade: normalize unqualified target image

If we get an unqualified target image, assume it's docker.io.  This
ensures that we're passing a fully-qualified target to docker|podman on
the various hosts and don't end up with something different based on the
per-host search path for unqualified image names.

Signed-off-by: Sage Weil <sage@newdream.net>
4 years agodoc/rados: rewrite mclock docs (2 of 2) 40723/head
Zac Dover [Fri, 9 Apr 2021 10:49:15 +0000 (20:49 +1000)]
doc/rados: rewrite mclock docs (2 of 2)

This is my second attempt to rewrite the
second half of the mclock docs. The first attempt
is enshrined in https://github.com/ceph/ceph/pull/40571,
in which I got cute with git and got burned.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 years agoMerge pull request #39216 from myoungwon/wip-manifest-dedup-test
Samuel Just [Fri, 9 Apr 2021 19:42:18 +0000 (12:42 -0700)]
Merge pull request #39216 from myoungwon/wip-manifest-dedup-test

osd, test: reworks for manifest dedup test cases

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #40623 from ronen-fr/wip-ronenf-revert-40077
Yuri Weinstein [Fri, 9 Apr 2021 14:45:55 +0000 (07:45 -0700)]
Merge pull request #40623 from ronen-fr/wip-ronenf-revert-40077

osd: Revert "osd: Try other PGs when reservation failures occur"

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #40606 from myoungwon/wip-49427-2
Yuri Weinstein [Fri, 9 Apr 2021 14:44:42 +0000 (07:44 -0700)]
Merge pull request #40606 from myoungwon/wip-49427-2

osd: recover unreadable snapshot before reading refcount info

Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #40510 from aclamk/wip-bluestore-sharding-rst
Josh Durgin [Thu, 8 Apr 2021 22:36:27 +0000 (15:36 -0700)]
Merge pull request #40510 from aclamk/wip-bluestore-sharding-rst

doc: Add BlueStore sharding documentation

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
4 years agomds: reject lookup ino requests for mds dirs 40389/head
Patrick Donnelly [Wed, 24 Mar 2021 20:54:17 +0000 (13:54 -0700)]
mds: reject lookup ino requests for mds dirs

Fixes: https://tracker.ceph.com/issues/49922
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoqa: test standby-replay with fs:workloads 40481/head
Patrick Donnelly [Mon, 29 Mar 2021 22:08:28 +0000 (15:08 -0700)]
qa: test standby-replay with fs:workloads

Fixes: https://tracker.ceph.com/issues/50045
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40486 into master
Patrick Donnelly [Thu, 8 Apr 2021 18:35:05 +0000 (11:35 -0700)]
Merge PR #40486 into master

* refs/pull/40486/head:
mds: trim cache regularly for standby-replay
mds: remove extra heap release

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
4 years agoMerge PR #40520 into master
Patrick Donnelly [Thu, 8 Apr 2021 18:34:21 +0000 (11:34 -0700)]
Merge PR #40520 into master

* refs/pull/40520/head:
mds/scrub: background scrub error fixes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40633 into master
Patrick Donnelly [Thu, 8 Apr 2021 18:33:41 +0000 (11:33 -0700)]
Merge PR #40633 into master

* refs/pull/40633/head:
mds: ensure export_pin rank < max_mds

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40638 into master
Patrick Donnelly [Thu, 8 Apr 2021 18:33:08 +0000 (11:33 -0700)]
Merge PR #40638 into master

* refs/pull/40638/head:
mds: do not show the default auth if it's unambiguous
mds: switch to rank number instead

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agomon: check mdsmap is resizeable before promoting standby-replay 40653/head
Patrick Donnelly [Wed, 7 Apr 2021 19:27:05 +0000 (12:27 -0700)]
mon: check mdsmap is resizeable before promoting standby-replay

If any MDS is up:creating, some rank data structures may not exist yet.

Fixes: https://tracker.ceph.com/issues/50215
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #40617 from tchaikov/wip-system-pmem
Kefu Chai [Thu, 8 Apr 2021 14:57:23 +0000 (22:57 +0800)]
Merge pull request #40617 from tchaikov/wip-system-pmem

install-deps.sh: install libpmem libraries if WITH_PMEM is set

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40467 into master
Patrick Donnelly [Thu, 8 Apr 2021 14:28:10 +0000 (07:28 -0700)]
Merge PR #40467 into master

* refs/pull/40467/head:
doc: detail `fs snapshot mirror daemon status` mgr command
doc: s/<fs>/<fs_name>/g

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
4 years agoMerge pull request #40654 from rzarzynski/wip-crimson-notify-lifetime
Kefu Chai [Thu, 8 Apr 2021 12:37:41 +0000 (20:37 +0800)]
Merge pull request #40654 from rzarzynski/wip-crimson-notify-lifetime

crimson/osd: fix the lifetime of Notify during timeouts

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40641 from idryomov/wip-require-ceph-common-for-ioc
Ilya Dryomov [Thu, 8 Apr 2021 11:07:44 +0000 (13:07 +0200)]
Merge pull request #40641 from idryomov/wip-require-ceph-common-for-ioc

packaging: require ceph-common for immutable object cache daemon

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agocrimson/osd: improve debugs around Watch / Notify. 40654/head
Radoslaw Zarzynski [Wed, 7 Apr 2021 19:49:17 +0000 (19:49 +0000)]
crimson/osd: improve debugs around Watch / Notify.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agocrimson/osd: fix the lifetime of Notify during timeouts.
Radoslaw Zarzynski [Wed, 7 Apr 2021 19:48:49 +0000 (19:48 +0000)]
crimson/osd: fix the lifetime of Notify during timeouts.

This fixes a segfault during `LibRadosWatchNotify.WatchNotify2Timeout`.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agodoc: detail `fs snapshot mirror daemon status` mgr command 40467/head
Venky Shankar [Mon, 29 Mar 2021 08:59:58 +0000 (04:59 -0400)]
doc: detail `fs snapshot mirror daemon status` mgr command

@leseb noticed that this interface did not have any documentation. Thanks!

Fixes: http://tracker.ceph.com/issues/50229
Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agodoc: s/<fs>/<fs_name>/g
Venky Shankar [Mon, 29 Mar 2021 09:29:54 +0000 (05:29 -0400)]
doc: s/<fs>/<fs_name>/g

Signed-off-by: Venky Shankar <vshankar@redhat.com>
4 years agorun-make-check: enable WITH_RBD_RWL when WITH_PMEM is true 40617/head
Kefu Chai [Thu, 8 Apr 2021 09:12:38 +0000 (17:12 +0800)]
run-make-check: enable WITH_RBD_RWL when WITH_PMEM is true

so we can at least build-test the rwl cache plugin in "make check" run.

this is an opt-in option which is only enabled if WITH_PMEM is "true",
we will set it in the corresponding ceph-build job.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoinstall-deps.sh: install libpmem libraries if WITH_PMEM is set
Kefu Chai [Tue, 6 Apr 2021 12:17:12 +0000 (20:17 +0800)]
install-deps.sh: install libpmem libraries if WITH_PMEM is set

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agodo_freebsd.sh: disable WITH_SYSTEMD 40658/head
Kefu Chai [Thu, 8 Apr 2021 08:46:09 +0000 (16:46 +0800)]
do_freebsd.sh: disable WITH_SYSTEMD

as FreeBSD does not has systemd at the time of writing, so it does not
make sense to build or install systemd support.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocmake: s/HAVE_MSGHDR/WITH_SYSTEMD/
Kefu Chai [Thu, 8 Apr 2021 08:43:33 +0000 (16:43 +0800)]
cmake: s/HAVE_MSGHDR/WITH_SYSTEMD/

as FreeBSD also has msghdr but it does not have systemd, or
flags like MFD_ALLOW_SEALING, O_TMPFILE or F_SEAL_GROW. so
use WITH_SYSTEMD for enabling journald backend of logging system.

also move the option of "WITH_SYSTEMD" up so that the src/CMakeLists.txt
is able to see the variable of WITH_SYSTEMD defined by it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agoosd: do not assert() in the case of no obc 39216/head
myoungwon oh [Thu, 1 Apr 2021 00:59:22 +0000 (09:59 +0900)]
osd: do not assert() in the case of no obc

Upon rollback, we should handle ENOENT case,
so what we should do here is to return NOOP.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
4 years agoosd: remove unnecessary ref handling in _delete_oid
myoungwon oh [Wed, 31 Mar 2021 06:22:01 +0000 (15:22 +0900)]
osd: remove unnecessary ref handling in _delete_oid

Let's consider the following case when handling a delete op.
1. Delete --> whiteouted
2. Make clone

In this case, current code clears chunk_map and calls dec_all_manifest_refcount()
in _delete_oid() even if the clone still has the references.

To fix this, This commit remove unnecessary ref handling in _delete_oid, and
makes finish_ctx() to handle ref handling, which can aware of whether the
clone is created or not.

Also, remove oi.size == 0 condition in finish_ctx() to handle ref. counting
upon a delete op with whitedouted clone.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
4 years agodoc: Add BlueStore sharding documentation 40510/head
Adam Kupczyk [Tue, 30 Mar 2021 20:56:58 +0000 (22:56 +0200)]
doc: Add BlueStore sharding documentation

Provide sharding explanation, configuration parameters explanation.
Provide resharding tool example into Pacific format.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Co-authored-by: Josh Durgin <jdurgin@redhat.com>
4 years agoMerge pull request #40596 from tchaikov/wip-cmake-clean
Kefu Chai [Thu, 8 Apr 2021 07:26:07 +0000 (15:26 +0800)]
Merge pull request #40596 from tchaikov/wip-cmake-clean

cmake: remove created directory when "clean" target is run

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agoqa/cephfs: remove create_keyring_file from cephfs_test_case.py 40431/head
Rishabh Dave [Thu, 8 Apr 2021 06:30:18 +0000 (12:00 +0530)]
qa/cephfs: remove create_keyring_file from cephfs_test_case.py

Since teuthology.orchestra.remote.mktemp() can write a temporary file
and not just create it, create_keyring_file() is now redundant.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 years agoqa/cephfs: don't use sudo to write files in /tmp
Rishabh Dave [Fri, 26 Mar 2021 09:20:20 +0000 (14:50 +0530)]
qa/cephfs: don't use sudo to write files in /tmp

Files in /tmp cannot be written by any user( including the root user)
other than the file owner even if the permission mode on the file is
777.

Fixes: https://tracker.ceph.com/issues/49466
Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 years agoMerge pull request #40342 from batrick/snap_schedule-qa-fixes
Venky Shankar [Thu, 8 Apr 2021 06:21:05 +0000 (11:51 +0530)]
Merge pull request #40342 from batrick/snap_schedule-qa-fixes

qa: snap_schedule test debugging

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 years agoMerge pull request #40625 from TRYTOBE8TME/wip-rgw-notifications
Yuval Lifshitz [Thu, 8 Apr 2021 05:32:45 +0000 (08:32 +0300)]
Merge pull request #40625 from TRYTOBE8TME/wip-rgw-notifications

rgw/test: Changing force-branch to master

4 years agoMerge pull request #40622 from batrick/dev-make
Kefu Chai [Thu, 8 Apr 2021 04:55:37 +0000 (12:55 +0800)]
Merge pull request #40622 from batrick/dev-make

doc: update some docs still referring to make

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #40647 from rzarzynski/wip-crimson-notify-send_comp-broken-debug
Kefu Chai [Thu, 8 Apr 2021 03:58:56 +0000 (11:58 +0800)]
Merge pull request #40647 from rzarzynski/wip-crimson-notify-send_comp-broken-debug

crimson/osd: fix broken debug in Notify::send_completion().

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
4 years agoMerge PR #40204 into master
Patrick Donnelly [Thu, 8 Apr 2021 02:37:40 +0000 (19:37 -0700)]
Merge PR #40204 into master

* refs/pull/40204/head:
client: cleanup _preadv_pwritev_locked()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
4 years agoMerge PR #40427 into master
Patrick Donnelly [Thu, 8 Apr 2021 02:37:00 +0000 (19:37 -0700)]
Merge PR #40427 into master

* refs/pull/40427/head:
mds: skip the buffer in UnknownPayload::decode()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge PR #40611 into master
Patrick Donnelly [Thu, 8 Apr 2021 02:35:58 +0000 (19:35 -0700)]
Merge PR #40611 into master

* refs/pull/40611/head:
qa: retry cloning the ceph.git

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #40636 from tchaikov/wip-50196
Kefu Chai [Thu, 8 Apr 2021 02:15:33 +0000 (10:15 +0800)]
Merge pull request #40636 from tchaikov/wip-50196

qa/tasks/mgr: skip test_diskprediction_local on python>=3.8

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 years agomds: ensure export_pin rank < max_mds 40633/head
Yanhu Cao [Wed, 7 Apr 2021 02:13:07 +0000 (10:13 +0800)]
mds: ensure export_pin rank < max_mds

Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
4 years agoosd: recover unreadable snapshot before reading ref. count info 40606/head
myoungwon oh [Tue, 6 Apr 2021 01:29:56 +0000 (10:29 +0900)]
osd: recover unreadable snapshot before reading ref. count info

Manifest objects needs adjacent clones when incrementing/decrementing
refcount. This commit makes the current code to call get_manifest_ref_count
before reading ref. count info.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
4 years agomgr/prometheus:Improve the pool metadata 40635/head
Paul Cuzner [Tue, 2 Feb 2021 01:20:30 +0000 (14:20 +1300)]
mgr/prometheus:Improve the pool metadata

Adds percent_used and used_bytes to the per pool
metrics group, and add additional labels to the ceph_pool_metadata
metric
- compression_mode - so consumers can tell whether compression
  is active
- description - provide a text string showing the protection
  scheme of the pool (e.g. replica2, or ec:4+2
- type - text string showing replicated or erasure enabling
  easy filtering across the pools

These additional fields allow compression savings to be more
easily shown. The inclusion of percent_used ensures that any
prometheus based view of pool usage will ALWAYS match the CLI.

Fixes: https://tracker.ceph.com/issues/49049
Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
4 years agoMerge pull request #40632 from adamemerson/wip-warnless-4now
Adam C. Emerson [Wed, 7 Apr 2021 20:38:22 +0000 (16:38 -0400)]
Merge pull request #40632 from adamemerson/wip-warnless-4now

Warning Cleanup and Clang Compile Fix

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
4 years agorgw/test: Changing force-branch to master 40625/head
Kalpesh [Tue, 6 Apr 2021 15:59:43 +0000 (21:29 +0530)]
rgw/test: Changing force-branch to master

This PR includes 2 things:
1. Changing force-branch to master and removing the git-remote. This change was forgetten for PR #39139.
2. Proper cleanup/removal after completion of commands more precisely removing the kafka logs directory.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
4 years agotest/osd: Change const copy in loop to const reference 40632/head
Adam C. Emerson [Tue, 6 Apr 2021 19:23:58 +0000 (15:23 -0400)]
test/osd: Change const copy in loop to const reference

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Fix brace-enclosed-scalar warning
Adam C. Emerson [Tue, 6 Apr 2021 19:21:30 +0000 (15:21 -0400)]
rgw: Fix brace-enclosed-scalar warning

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Fix warnings from s3select
Adam C. Emerson [Tue, 6 Apr 2021 19:20:55 +0000 (15:20 -0400)]
rgw: Fix warnings from s3select

Since this is a submodule, just wrap the include in a pragma.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Remove unused variables
Adam C. Emerson [Tue, 6 Apr 2021 19:19:06 +0000 (15:19 -0400)]
rgw: Remove unused variables

(Also mark the file as C++ rather than C)

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agotest/librados: Remove unused capture
Adam C. Emerson [Tue, 6 Apr 2021 19:18:34 +0000 (15:18 -0400)]
test/librados: Remove unused capture

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorbd: Fix ambiguous call to addr.parse
Adam C. Emerson [Tue, 6 Apr 2021 18:00:48 +0000 (14:00 -0400)]
rbd: Fix ambiguous call to addr.parse

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Fix signed comparison warning
Adam C. Emerson [Tue, 6 Apr 2021 17:59:14 +0000 (13:59 -0400)]
rgw: Fix signed comparison warning

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agotest/librados: Disambiguate function call
Adam C. Emerson [Tue, 6 Apr 2021 17:28:45 +0000 (13:28 -0400)]
test/librados: Disambiguate function call

Cleaning up a warning.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agorgw: Add missing extension to file in sources list
Adam C. Emerson [Tue, 6 Apr 2021 17:27:45 +0000 (13:27 -0400)]
rgw: Add missing extension to file in sources list

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
4 years agoMerge pull request #38737 from IlsooByun/objmeta-key-underscore
J. Eric Ivancich [Wed, 7 Apr 2021 16:31:37 +0000 (12:31 -0400)]
Merge pull request #38737 from IlsooByun/objmeta-key-underscore

rgw: keep underscore in metatdata key

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
4 years agoMerge pull request #39749 from linuxbox2/wip-olock-fixes
J. Eric Ivancich [Wed, 7 Apr 2021 16:31:10 +0000 (12:31 -0400)]
Merge pull request #39749 from linuxbox2/wip-olock-fixes

rgw: objectlock: improve client error messages

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #40263 from ivancich/wip-update-listing-comments
J. Eric Ivancich [Wed, 7 Apr 2021 16:30:47 +0000 (12:30 -0400)]
Merge pull request #40263 from ivancich/wip-update-listing-comments

rgw: update bucket listing log output

Reviewed-by: Ali Maredia <amaredia@redhat.com>
4 years agoMerge pull request #40570 from zdover23/wip-doc-mclock-rewrite-first-half-2021-Apr-2
Neha Ojha [Wed, 7 Apr 2021 15:53:35 +0000 (08:53 -0700)]
Merge pull request #40570 from zdover23/wip-doc-mclock-rewrite-first-half-2021-Apr-2

doc/rados: rewrite mclock-config-ref

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
4 years agoMerge pull request #40639 from yuvalif/wip-yuval-fix-50201
Casey Bodley [Wed, 7 Apr 2021 15:03:34 +0000 (11:03 -0400)]
Merge pull request #40639 from yuvalif/wip-yuval-fix-50201

rgw/multisite: return correct error code when op fails

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agocrimson/osd: fix broken debug in Notify::send_completion(). 40647/head
Radoslaw Zarzynski [Wed, 7 Apr 2021 14:35:06 +0000 (14:35 +0000)]
crimson/osd: fix broken debug in Notify::send_completion().

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 years agoqa/tasks/mgr: skip test_diskprediction_local on python>=3.8 40636/head
Kefu Chai [Wed, 7 Apr 2021 05:38:27 +0000 (13:38 +0800)]
qa/tasks/mgr: skip test_diskprediction_local on python>=3.8

query the python version before trying to test diskprediction_local

Fixes: https://tracker.ceph.com/issues/50196
Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agocephadm: cleanup extra slash in runtime dir 40644/head
胡玮文 [Wed, 7 Apr 2021 13:18:52 +0000 (21:18 +0800)]
cephadm: cleanup extra slash in runtime dir

%t already contains a slash, no need to add an extra one

Signed-off-by: 胡玮文 <huww98@outlook.com>
4 years agoMerge pull request #40581 from weixinwei/master
Kefu Chai [Wed, 7 Apr 2021 13:18:01 +0000 (21:18 +0800)]
Merge pull request #40581 from weixinwei/master

os/bluestore/BlueFS: do not _flush_range deleted files

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
4 years agoMerge pull request #40601 from cbodley/wip-50147
Casey Bodley [Wed, 7 Apr 2021 12:49:49 +0000 (08:49 -0400)]
Merge pull request #40601 from cbodley/wip-50147

qa/rgw: move ignore-pg-availability.yaml out of suites/rgw

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
4 years agoclient: don't allow access to MDS-private inodes 40642/head
Xiubo Li [Wed, 7 Apr 2021 11:37:26 +0000 (19:37 +0800)]
client: don't allow access to MDS-private inodes

Fixes: https://tracker.ceph.com/issues/50112
Signed-off-by: Xiubo Li <xiubli@redhat.com>
4 years agoMerge pull request #39907 from guits/fix_get_first_lv
Rishabh Dave [Wed, 7 Apr 2021 11:32:05 +0000 (17:02 +0530)]
Merge pull request #39907 from guits/fix_get_first_lv

ceph-volume: `get_first_lv()` refactor

4 years agopackaging: require ceph-common for immutable object cache daemon 40641/head
Ilya Dryomov [Wed, 7 Apr 2021 09:36:53 +0000 (11:36 +0200)]
packaging: require ceph-common for immutable object cache daemon

This daemon has a systemd service which starts it with --setuser ceph
--setgroup ceph.  "ceph" user and group are created by ceph-common and
won't be there unless ceph-common is installed.

Fixes: https://tracker.ceph.com/issues/50207
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 years agoMerge pull request #40624 from rhcs-dashboard/read-only-config-access-disable
Ernesto Puerta [Wed, 7 Apr 2021 11:04:28 +0000 (13:04 +0200)]
Merge pull request #40624 from rhcs-dashboard/read-only-config-access-disable

mgr/dashboard: Revoke read-only user's access to Manager modules

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
4 years agomgr/selftest: add a command for querying python version
Kefu Chai [Wed, 7 Apr 2021 06:40:05 +0000 (14:40 +0800)]
mgr/selftest: add a command for querying python version

so the test driver can skip certain tests based on the version of python
runtime on the test node

Fixes: https://tracker.ceph.com/issues/50196
Signed-off-by: Kefu Chai <kchai@redhat.com>
4 years agorgw/multisite: return correct error code when op fails 40639/head
Yuval Lifshitz [Wed, 7 Apr 2021 09:49:50 +0000 (12:49 +0300)]
rgw/multisite: return correct error code when op fails

when trying to disable/enbale sync on non-master zone

Fixes: https://tracker.ceph.com/issues/50201
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
4 years agoceph-volume: `get_first_*()` refactor 39907/head
Guillaume Abrioux [Mon, 8 Mar 2021 08:59:26 +0000 (09:59 +0100)]
ceph-volume: `get_first_*()` refactor

As indicated by commit 17957d9beb42a04b8f180ccb7ba07d43179a41d3 those
fuctions were meant to avoid writing something like following:

```
lvs = get_lvs()
if len(lvs) >= 1:
lvs = lv[0]
```

Those functions should return `None` if 0 or more than 1 item is returned.
The current name of these functions are confusing and can lead to thinking that
we just want the first item returned, even though it returns more than 1
item, let's rename them to `get_single_pv()`, `get_single_vg()` and
`get_single_lv()`

Closes: https://tracker.ceph.com/issues/49643
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
4 years agoMerge pull request #40637 from ronen-fr/wip-ronenf-rgw-logbacking
Ronen Friedman [Wed, 7 Apr 2021 07:13:01 +0000 (10:13 +0300)]
Merge pull request #40637 from ronen-fr/wip-ronenf-rgw-logbacking

rgw: fix lambda capture of a non-variable
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
4 years agoMerge pull request #40604 from liewegas/podman-registries-conf
Kefu Chai [Wed, 7 Apr 2021 07:12:24 +0000 (15:12 +0800)]
Merge pull request #40604 from liewegas/podman-registries-conf

qa/distros/podman: preserve registries.conf

Reviewed-by: David Galloway <dgallowa@redhat.com>