]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Kefu Chai [Thu, 20 May 2021 09:19:44 +0000 (17:19 +0800)]
crimson/os/seastore/logging: remove comma
to address the FTBFS of the release builds.
fix a regression introduced by
c39d64d7bbd7d7cf1d476a44f60c70edce55f3d1
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 20 May 2021 01:04:33 +0000 (09:04 +0800)]
Merge pull request #41392 from tchaikov/wip-librados
include/rados/librados.h: use UINT64_C to define constants
Reviewed-by: Neha Ojha <nojha@redhat.com>
Josh Durgin [Thu, 20 May 2021 00:42:21 +0000 (17:42 -0700)]
Merge pull request #41409 from zdover23/wip-doc-security-2021-05-19-fifth-item
doc/security: updating fifth listitem
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Josh Durgin [Thu, 20 May 2021 00:41:38 +0000 (17:41 -0700)]
Merge pull request #41410 from zdover23/wip-doc-security-2021-05-19-seventh-item
doc/security: enrich seventh listitem
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Samuel Just [Thu, 20 May 2021 00:11:02 +0000 (17:11 -0700)]
Merge pull request #41424 from athanatos/sjust/wip-interruptor-unittest-name
test/crimson/CMakeLists.txt: fix name of unittest-interruptible-future
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@360.cn>
Kefu Chai [Thu, 20 May 2021 00:10:11 +0000 (08:10 +0800)]
Merge pull request #41425 from athanatos/sjust/wip-seastore-build
crimson: fix misc build issues
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Samuel Just [Wed, 19 May 2021 21:41:06 +0000 (14:41 -0700)]
crimson/tools/store_nbd/tm_driver: remove perfcounter argument
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Wed, 19 May 2021 21:40:42 +0000 (14:40 -0700)]
crimson/os/seastore/logging: fix log() argument
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Wed, 19 May 2021 21:07:46 +0000 (14:07 -0700)]
test/crimson/CMakeLists.txt: fix name of unittest-interruptible-future
unittest-interruptible-future matches the other unit tests here.
Signed-off-by: Samuel Just <sjust@redhat.com>
Josh Durgin [Wed, 19 May 2021 20:15:37 +0000 (13:15 -0700)]
Merge pull request #40836 from kamoltat/wip-autoscaler-new-alg-turn-on-off
pybind/mgr/pg_autoscaler: Added autoscale-profile feature
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Kamoltat [Tue, 13 Apr 2021 21:12:40 +0000 (21:12 +0000)]
pybind/mgr/pg_autoscaler: Added autoscale-profile feature
The autoscaler by default will start out each pool with minimal
pgs and `scale-up` the pgs when there is more usage in each pool.
Users can now use the commands:
`osd pool set autoscale-profile scale-down` to make the pools
start out with a full complement of pgs and only `scale-down`
when usage ratio across the pools are not even.
`osd pool set autoscale-profile scale-up` (by default) to make the pools
start out with minimal pgs and `scale-up` the pgs when there
is more usage in each pool.
Edited KVMonitor.cc file to make the `autoscale_profile` variable
persistent.
Edited tests/test_cal_final_pg_target.py so that it takes into account
the new `profile` argument when calling cal_final_pg_target(). Also,
added some new test cases for when profile is `scale-up`
Renamed tests/test_autoscaler.py to a more appropriate name:
tests/test_cal_ratio.py
Signed-off-by: Kamoltat <ksirivad@redhat.com>
Zac Dover [Wed, 19 May 2021 14:44:00 +0000 (00:44 +1000)]
doc/security: enrich seventh listitem
This PR improves the language of the seventh listitem
in the Vulnerability Management Process in the security
documentation.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Josh Durgin [Wed, 19 May 2021 14:40:59 +0000 (07:40 -0700)]
Merge pull request #41406 from zdover23/wip-doc-security-2021-05-19-first-item
doc/security: removing pleonasm
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Zac Dover [Wed, 19 May 2021 14:37:52 +0000 (00:37 +1000)]
doc/security: updating fifth listitem
This PR enriches the text in the fifth listitem
of the Vulnerability Management Process.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Kefu Chai [Wed, 19 May 2021 14:13:15 +0000 (22:13 +0800)]
Merge pull request #41391 from tchaikov/wip-libcephfs
libcephfs: include <sys/time.h>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Wed, 19 May 2021 14:12:24 +0000 (22:12 +0800)]
Merge pull request #41359 from tchaikov/wip-cmake-cleanup
cmake: cleanups related to file(GLOB_RECURSE..) call
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Zac Dover [Wed, 19 May 2021 14:07:45 +0000 (00:07 +1000)]
doc/security: removing pleonasm
s/three business days or less/three business days/
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Kefu Chai [Wed, 19 May 2021 13:19:11 +0000 (21:19 +0800)]
Merge pull request #41355 from tchaikov/wip-doc-rgw-conf
doc/radosgw: use confval directive to define options
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Wed, 19 May 2021 12:38:07 +0000 (20:38 +0800)]
Merge pull request #41399 from idryomov/wip-mrun-if-posix
mrun: avoid == in [ command
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 19 May 2021 12:37:44 +0000 (20:37 +0800)]
Merge pull request #41393 from rosinL/fix-50835
common/crc32c_aarch64: fix crc32c unittest failed on aarch64
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sun, 16 May 2021 03:54:19 +0000 (11:54 +0800)]
doc/radosgw: use confval directive to define options
less repeating this way
Signed-off-by: Kefu Chai <kchai@redhat.com>
Sage Weil [Wed, 19 May 2021 11:57:20 +0000 (07:57 -0400)]
Merge PR #41388 into master
* refs/pull/41388/head:
cephadm: write config files as utf-8
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Sage Weil [Wed, 19 May 2021 11:55:30 +0000 (07:55 -0400)]
Merge PR #41286 into master
* refs/pull/41286/head:
qa/suites/orch/rook: disable centos for now
qa/suites/orch/rook/smoke: initial smoke suite
qa/tasks/rook: ROOK_HOSTPATH_REQUIRES_PRIVILEGED=true on centos
qa/tasks/rook: simplify shutdown
qa/tasks/rook: archive logs
qa/tasks/rook: more orderly cluster teardown
qa/tasks/rook: deploy ceph via rook on top of kubernetes
qa/tasks/kubeadm: install kubernetes with kubeadm
qa/suites: move rados/cephadm -> orch/cephadm; symlink
qa/tasks/cephadm: add whitespace between functions
qa/tasks/cephadm: clean up ctx.manager setup
Reviewed-by: Sébastien Han <seb@redhat.com>
Sage Weil [Wed, 19 May 2021 11:52:17 +0000 (07:52 -0400)]
Merge PR #41370 into master
* refs/pull/41370/head:
mgr/cephadm: pin haproxy image to 2.3.z
Reviewed-by: Daniel Pivonka <dpivonka@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Ernesto Puerta [Wed, 19 May 2021 11:43:42 +0000 (13:43 +0200)]
Merge pull request #41345 from rhcs-dashboard/fix-CVE-2021-3509-master
mgr/dashboard: fix cookie injection issue (CVE-2021-3509)
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Ilya Dryomov [Wed, 19 May 2021 11:00:16 +0000 (13:00 +0200)]
mrun: avoid == in [ command
== operator is not supported in POSIX sh (e.g. dash):
./mrun: 24: [: unexpected operator
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ernesto Puerta [Wed, 19 May 2021 10:41:33 +0000 (12:41 +0200)]
Merge pull request #41104 from rhcs-dashboard/fix-ESOCKETTIMEDOUT-e2e-failure
mgr/dashboard: fix ESOCKETTIMEDOUT E2E failure
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Ernesto Puerta [Wed, 19 May 2021 10:40:02 +0000 (12:40 +0200)]
Merge pull request #41273 from rhcs-dashboard/update-frontend-deps
mgr/dashboard: update frontend deps due to security vulnerabilities
Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
luo rixin [Wed, 19 May 2021 02:27:18 +0000 (10:27 +0800)]
common/crc32c_aarch64: fix crc32c unittest failed on aarch64
On centos 8.2 for aarch64 with gcc 8.3, the complier will use
register v0 conflicting with the register v0 be usded in inline
asm code. Adding the related registers into clobber list to inform
complier avoiding the confict.
Fixes: https://tracker.ceph.com/issues/50835
Signed-off-by: luo rixin <luorixin@huawei.com>
Sage Weil [Tue, 18 May 2021 12:23:36 +0000 (08:23 -0400)]
cephadm: write config files as utf-8
If we don't specify the encoding, python may use something like 'latin-1',
which cannot handle unicode characters.
Signed-off-by: Sage Weil <sage@newdream.net>
Kefu Chai [Wed, 19 May 2021 01:30:08 +0000 (09:30 +0800)]
include/rados/librados.h: use UINT64_C to define constants
UINT64_C add the appropriate suffix to literals, this is more readable
than casting the literal to the expected type.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 19 May 2021 01:18:33 +0000 (09:18 +0800)]
libcephfs: include <sys/time.h>
header files should be self-contained. we are using `timeval` in the header,
but failed to include the header defining it.
this change addresses the build failures on Darwin like:
int ceph_lutimes(struct ceph_mount_info *cmount, const char *path, struct timeval times[2]);
^
src/include/cephfs/libcephfs.h:1080:78: error: array has incomplete element type 'struct timeval'
int ceph_futimes(struct ceph_mount_info *cmount, int fd, struct timeval times[2]);
^
src/include/cephfs/libcephfs.h:1080:65: note: forward declaration of 'struct timeval'
int ceph_futimes(struct ceph_mount_info *cmount, int fd, struct timeval times[2]);
^
3 errors generated.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 19 May 2021 00:47:34 +0000 (08:47 +0800)]
Merge pull request #41390 from batrick/i50865
doc: use sphinx .dot include
Reviewed-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 20:43:28 +0000 (13:43 -0700)]
Merge PR #41357 into master
* refs/pull/41357/head:
mds: do not assert when receiving a unknow metric type
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 20:42:47 +0000 (13:42 -0700)]
Merge PR #41347 into master
* refs/pull/41347/head:
mon,doc: deprecate CephFS min_compat_client
doc: add alternate_name cephfs feature to table
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 20:42:09 +0000 (13:42 -0700)]
Merge PR #41332 into master
* refs/pull/41332/head:
mds: place the journaler pointer under the mds_lock
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 20:41:28 +0000 (13:41 -0700)]
Merge PR #41171 into master
* refs/pull/41171/head:
test: disable mirroring module for certain tests
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 20:40:45 +0000 (13:40 -0700)]
Merge PR #41097 into master
* refs/pull/41097/head:
cephfs-mirror: allow connecting to local cluster using mon address
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sébastien Han <seb@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 20:36:05 +0000 (13:36 -0700)]
Merge PR #40885 into master
* refs/pull/40885/head:
doc: document cephfs-mirror configuration options
cephfs-mirror: use sensible mount timeout when mounting local/remote fs
test: add tests for settting mount timeout
pybind/cephfs: add interface to set mount timeout
libcephfs: add interface to set mount timeout
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 20:20:20 +0000 (13:20 -0700)]
Merge PR #41371 into master
* refs/pull/41371/head:
mds/Mutation: initialize MutationImpl object's initiated_at
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sage Weil [Tue, 18 May 2021 18:37:32 +0000 (13:37 -0500)]
qa/suites/orch/rook: disable centos for now
We are hitting an selinux denial:
type=AVC msg=audit(
1621353663 .595:6016): avc: denied { write } for pid=28812 comm="cephcsi" name="pids.max" dev="cgroup" ino=2933 scontext=system_u:system_r:container_t:s0:c43,c177 tcontext=system_u:object_r:cgroup_t:s0 tclass=file permissive=1
Signed-off-by: Sage Weil <sage@newdream.net>
Sage Weil [Fri, 14 May 2021 15:45:00 +0000 (10:45 -0500)]
qa/suites/orch/rook/smoke: initial smoke suite
- os: 18.04, 20.04, centos, centos+kubic
- nodes: 1 or 3
- rook: 1.6.2 or master
- k8s: 1.21 always (for now)
- net: calico always (flannel + centos is wonky)
- workload: none, rados bench
Signed-off-by: Sage Weil <sage@newdream.net>
Sage Weil [Tue, 18 May 2021 14:54:42 +0000 (09:54 -0500)]
qa/tasks/rook: ROOK_HOSTPATH_REQUIRES_PRIVILEGED=true on centos
This fixes OSD creation on centos.
Signed-off-by: Sage Weil <sage@newdream.net>
Sage Weil [Tue, 18 May 2021 14:54:15 +0000 (09:54 -0500)]
qa/tasks/rook: simplify shutdown
For some reason deleting common.yaml sometimes fails. Not really
sure why, but since we will tear down kubernetes anyway this
cleanup isn't really needed.
Signed-off-by: Sage Weil <sage@newdream.net>
Sage Weil [Tue, 18 May 2021 14:53:39 +0000 (09:53 -0500)]
qa/tasks/rook: archive logs
Signed-off-by: Sage Weil <sage@newdream.net>
Sage Weil [Tue, 18 May 2021 13:57:12 +0000 (08:57 -0500)]
qa/tasks/rook: more orderly cluster teardown
Signed-off-by: Sage Weil <sage@newdream.net>
Sage Weil [Thu, 13 May 2021 14:26:35 +0000 (09:26 -0500)]
qa/tasks/rook: deploy ceph via rook on top of kubernetes
This assumes that k8s is installed and kubectl works.
The ceph container to use is selected the same way the cephadm
task does it.
All scratch devices are consumed as OSDs.
A ceph.conf and client.admin keyring are deployed on all test
nodes, so normal tasks should work (if/when packages are installed).
Fixes: https://tracker.ceph.com/issues/47507
Signed-off-by: Sage Weil <sage@newdream.net>
Patrick Donnelly [Tue, 18 May 2021 18:13:00 +0000 (11:13 -0700)]
doc: use sphinx .dot include
To compile svg automatically into docs.
Fixed: https://tracker.ceph.com/issues/50865
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Josh Durgin [Tue, 18 May 2021 17:56:05 +0000 (10:56 -0700)]
Merge pull request #40921 from kamoltat/wip-pool-start-out-with-1-pg
mon/OSDMonitor: prepare_new_pool() starts out with 1 pg
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sage Weil [Tue, 18 May 2021 16:23:48 +0000 (12:23 -0400)]
Merge PR #41383 into master
* refs/pull/41383/head:
doc/security: Add single GPG key in lieu of existing three GPG keys
Reviewed-by: Sage Weil <sage@redhat.com>
Sage Weil [Fri, 7 May 2021 18:24:31 +0000 (13:24 -0500)]
qa/tasks/kubeadm: install kubernetes with kubeadm
- install k8s with kubeadm
- initial support for flannel only
- remove taint from bootstrap/master node
- create PVs for all scratch_devs + a 'scratch' SC
- kubeadm.kubectl task
Signed-off-by: Sage Weil <sage@newdream.net>
Sage Weil [Fri, 14 May 2021 15:40:02 +0000 (10:40 -0500)]
qa/suites: move rados/cephadm -> orch/cephadm; symlink
Move cephadm under orch/ top-level suite. Symlink so that we
still include it in a rados run.
Signed-off-by: Sage Weil <sage@newdream.net>
Kefu Chai [Tue, 18 May 2021 15:37:22 +0000 (23:37 +0800)]
Merge pull request #41352 from tchaikov/wip-crimson-metrics
crimson/os/seastore: use seastar::metrics for metrics reporting
Reviewed-by: Amnon Hanuhov <ahanukov@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Ernesto Puerta [Tue, 18 May 2021 15:22:02 +0000 (17:22 +0200)]
Merge pull request #41377 from rhcs-dashboard/change-password-preserve-url-fix
mgr/dashboard: Fix for query params resetting on change-password
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Sage Weil [Mon, 17 May 2021 21:23:48 +0000 (16:23 -0500)]
qa/tasks/cephadm: add whitespace between functions
Signed-off-by: Sage Weil <sage@newdream.net>
Hardik Vyas [Tue, 18 May 2021 12:13:53 +0000 (17:43 +0530)]
doc/security: Add single GPG key in lieu of existing three GPG keys
Replace existing three GPG keys with new Ceph Security Team GPG key
Signed-off-by: Hardik Vyas <hvyas@redhat.com>
Sage Weil [Tue, 18 May 2021 13:32:52 +0000 (09:32 -0400)]
Merge PR #40640 into master
* refs/pull/40640/head:
common: send SYSLOG_IDENTIFIER to journald
cephadm: enable log to journald by default
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Rishabh Dave [Tue, 18 May 2021 12:50:43 +0000 (18:20 +0530)]
Merge pull request #39580 from ifed01/wip-ifed-migrate
ceph-volume: implement bluefs volume migration.
Sage Weil [Mon, 17 May 2021 19:40:10 +0000 (15:40 -0400)]
mgr/cephadm: pin haproxy image to 2.3.z
The 2.4 version fails for reasons that aren't immediate clear:
May 17 15:28:42 dael conmon[
3007013 ]: [NOTICE] (8) : haproxy version is 2.4.0-
6cbbecf
May 17 15:28:42 dael conmon[
3007013 ]: [NOTICE] (8) : path to executable is /usr/local/sbin/haproxy
May 17 15:28:42 dael conmon[
3007013 ]: [ALERT] (8) : Cannot open configuration file/directory /var/lib/haproxy/haproxy.cfg : Permission denied
Even with mode 777 on those files, there is an error about the chroot to
/var/lib/haproxy.
For now, just stick with a working version.
Fixes: https://tracker.ceph.com/issues/50830
Signed-off-by: Sage Weil <sage@newdream.net>
Matt Benjamin [Tue, 18 May 2021 12:19:09 +0000 (08:19 -0400)]
Merge pull request #41282 from cbodley/wip-rgw-rm-civetweb
rgw: remove the civetweb and fcgi frontends
Kefu Chai [Sat, 15 May 2021 08:55:49 +0000 (16:55 +0800)]
crimson/admin: reindent SeastarMetricsHook
we don't use 1-space indent.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 15 May 2021 06:35:31 +0000 (14:35 +0800)]
crimson/admin: add optional prefix arg to "perf dump_seastar"
so we can filter the dumped metrics by their prefix
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 15 May 2021 06:00:33 +0000 (14:00 +0800)]
crimson/admin: do not construct AdminSocketHook with osd
osd is not used at all.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 15 May 2021 05:58:33 +0000 (13:58 +0800)]
crimson/admin: add desc for DumpPerfCountersHook
logger and counter are used when executing the hook
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 15 May 2021 05:44:49 +0000 (13:44 +0800)]
crimson/os/seastore: use seastar::metrics for metrics reporting
to be better prepeare for the m:n mapping and to attach more labels
to a metric for better off-line data analysis using ETL tools in future.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 15 May 2021 05:43:33 +0000 (13:43 +0800)]
crimson/admin: print different metric type in different way
and use registered_metric::operator() for better readability
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 15 May 2021 05:21:48 +0000 (13:21 +0800)]
crimson/admin: use better variable names
for better readability.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sat, 15 May 2021 04:18:07 +0000 (12:18 +0800)]
crimson/os: define SeastoreCollection as a class
to be consistent with the forward declaration. C++ standard does not
differentiate class from struct in this perspective. but Clang warngs at
seeing it. so silence the warning.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 18 May 2021 09:45:28 +0000 (17:45 +0800)]
Merge pull request #41364 from rzarzynski/wip-crimson-monc-pending_messages-assert
crimson/monc: fix send_message() racing with reopen_session().
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Tue, 18 May 2021 09:05:15 +0000 (17:05 +0800)]
Merge pull request #41366 from tchaikov/wip-crimson-os-debug
crimson/os: use compile-time validation
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Nizamudeen A [Tue, 18 May 2021 08:48:38 +0000 (14:18 +0530)]
mgr/dashboard: Fix for query params resetting on change-password
Fixes: https://tracker.ceph.com/issues/50857
Signed-off-by: Nizamudeen A <nia@redhat.com>
Ilya Dryomov [Tue, 18 May 2021 08:25:42 +0000 (10:25 +0200)]
Merge pull request #41354 from idryomov/wip-rbd-pwl-ssd-recovery
librbd/cache/pwl/ssd: fix some crash recovery issues
Reviewed-by: Yin Congmin <congmin.yin@intel.com>
Reviewed-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
Kefu Chai [Tue, 18 May 2021 05:44:53 +0000 (13:44 +0800)]
Merge pull request #39772 from xxhdx1985126/wip-crimson-client-req-pipeline-parallelism
crimson/osd: optimize crimson-osd's client requests process parallelism
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Tue, 18 May 2021 05:29:13 +0000 (13:29 +0800)]
Merge pull request #41362 from Aran85/crimson-diagrams
crimson/seastore: add string_kv_node_layout diagrams
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Patrick Donnelly [Tue, 18 May 2021 02:50:45 +0000 (19:50 -0700)]
Merge PR #40234 into master
* refs/pull/40234/head:
client: always register callbacks before mount()
client: move SnapRealm methods to ClientSnapRealm.cc
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 02:49:40 +0000 (19:49 -0700)]
Merge PR #40842 into master
* refs/pull/40842/head:
qa: update the ffsb.sh to clone it from git://git.ceph.com/ffsb.git
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 02:47:57 +0000 (19:47 -0700)]
Merge PR #41235 into master
* refs/pull/41235/head:
mds: PurgeQueue.cc fix for 32bit compilation
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 02:46:56 +0000 (19:46 -0700)]
Merge PR #41239 into master
* refs/pull/41239/head:
librbd: use uint64_t instead of size_t for SparseExtent::length
mgr/PyModule: use Py_ssize_t for the PyList index
os/bluestore: print size_t using %xz
client: print int64_t using PRId64
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 02:42:54 +0000 (19:42 -0700)]
Merge PR #41254 into master
* refs/pull/41254/head:
mds: save the metadata pool id MDSRank class's private member
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 02:40:16 +0000 (19:40 -0700)]
Merge PR #41267 into master
* refs/pull/41267/head:
mds: defer the journal recovered success log
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Tue, 18 May 2021 02:39:11 +0000 (19:39 -0700)]
Merge PR #41268 into master
* refs/pull/41268/head:
mds: fix possible mds_lock not locked assert
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Tue, 18 May 2021 01:20:53 +0000 (09:20 +0800)]
Merge pull request #41341 from tchaikov/wip-dmclock
dmclock: pick up change to fix run_sched_ahead() scheduling issue
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Ramana Raja [Mon, 17 May 2021 22:54:40 +0000 (18:54 -0400)]
mds/Mutation: initialize MutationImpl object's initiated_at
... to current time, ceph_clock_now(). This is a more useful
initialized value than utime_t().
Fixes: https://tracker.ceph.com/issues/42516
Signed-off-by: Ramana Raja <rraja@redhat.com>
Co-Authored-By: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Fri, 14 May 2021 19:19:37 +0000 (12:19 -0700)]
mon,doc: deprecate CephFS min_compat_client
Instead admins should specify specific features to require.
Fixes: https://tracker.ceph.com/issues/50819
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Casey Bodley [Tue, 11 May 2021 14:01:20 +0000 (10:01 -0400)]
rgw: building the beast frontend is no longer optional
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 11 May 2021 13:56:01 +0000 (09:56 -0400)]
rgw: remove the fcgi frontend
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Tue, 11 May 2021 13:42:53 +0000 (09:42 -0400)]
rgw: remove the civetweb frontend from src and qa
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 17 May 2021 18:46:50 +0000 (14:46 -0400)]
Merge pull request #41262 from cbodley/wip-rgw-civetweb-deprecate
rgw: deprecate the civetweb frontend
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Kefu Chai [Mon, 17 May 2021 17:26:11 +0000 (01:26 +0800)]
crimson/os: pass log level to LOG()
instead of passing function name to the underlying macro, pass log
level for better readability.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 17 May 2021 17:13:03 +0000 (01:13 +0800)]
crimson/os: use compile-time validation
libfmt does compile-time format argument validation of the format string
and the argument when the the user-defined literal is used. but the
downside is that the formatter materialize the whole formatted string
into a std::string, before printing them argument into seastar's log buffer
inserter. presumably, the inserter would be more efficient in
comparision to the pre-format approach. so this validation is only
enabled for non NDEBUG build. so it is able to help us to identify
errors like
DEBUG("{} {}", 1, 2, 3)
Signed-off-by: Kefu Chai <kchai@redhat.com>
David Galloway [Mon, 17 May 2021 16:03:15 +0000 (12:03 -0400)]
Merge pull request #41348 from jdurgin/wip-release-notes-fixes
script/ceph-release-notes: work with py3 and remove backport release names from PRs
Patrick Donnelly [Mon, 17 May 2021 15:38:41 +0000 (08:38 -0700)]
Merge PR #41314 into master
* refs/pull/41314/head:
qa/tasks/nfs: add test to check if cmds fail on not passing required arguments
mgr/nfs: fix flake8 missing whitespace around parameter equals error
mgr/nfs: annotate _cmd_nfs_* methods return value
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Igor Fedotov [Wed, 28 Apr 2021 19:17:24 +0000 (22:17 +0300)]
tests/ceph_volume: add UT for bluefs migration stuff
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
Radoslaw Zarzynski [Mon, 17 May 2021 13:50:55 +0000 (13:50 +0000)]
crimson/monc: fix send_message() racing with reopen_session().
The `send_message()` method is a high-level facility for
communicating with a monitor. If there is an active conn
available, it sends the message immediately; otherwise
the message is queued. This method assumes the queue is
already drained if the connection is available.
`active_con` is managed by `reopen_session()` where it's
first cleared and then reset after finding new alive mon.
This is followed by draining the `pending_messages` queue
which happens in `on_session_opened()` after the `MAuth`
exchange is finished.
Unfortunately, the path from the `active_con` clearing
to draining the queue is long and divided into multiple
continuations which results in lack of atomicity. When
e.g. `run_command()` interleaves the stages, following
crash happens:
```
INFO 2021-05-07 08:13:43,914 [shard 0] monc - do_auth_single: mon v2:172.21.15.82:6805/34166 => v2:172.21.15.82:3300/0 returns auth_reply(proto 2 0 (0) Success) v1: 0
ceph-osd: /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/
17.0.0-3910-g1b18e076 /rpm/el8/BUILD/
ceph-17.0.0-3910-g1b18e076 /src/crimson/mon/MonClient.cc:1034: seastar::future<> crimson::mon::Client::send_message(MessageRef): Assertion `pending_messages.empty()' failed.
Aborting on shard 0.
Backtrace:
0# 0x000055CDE6DB532F in ceph-osd
1# FatalSignal::signaled(int, siginfo_t const*) in ceph-osd
2# FatalSignal::install_oneshot_signal_handler<6>()::{lambda(int, siginfo_t*, void*)#1}::_FUN(int, siginfo_t*, void*) in ceph-osd
3# 0x00007FC1BF20BB20 in /lib64/libpthread.so.0
4# gsignal in /lib64/libc.so.6
5# abort in /lib64/libc.so.6
6# 0x00007FC1BD806B09 in /lib64/libc.so.6
7# 0x00007FC1BD814DE6 in /lib64/libc.so.6
8# crimson::mon::Client::send_message(boost::intrusive_ptr<Message>) in ceph-osd
9# crimson::mon::Client::renew_subs() in ceph-osd
10# 0x000055CDE764FB0B in ceph-osd
11# 0x000055CDE10457F0 in ceph-osd
12# 0x000055CDEA0AB88F in ceph-osd
13# 0x000055CDEA0B0DD0 in ceph-osd
14# 0x000055CDEA2689FB in ceph-osd
15# 0x000055CDE9DC0EDA in ceph-osd
16# main in ceph-osd
17# __libc_start_main in /lib64/libc.so.6
18# _start in ceph-osd
```
The problem caused following failure at Sepia:
http://pulpito.front.sepia.ceph.com/rzarzynski-2021-05-07_07:41:02-rados-master-distro-basic-smithi/
6104549
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Xuehan Xu [Sun, 16 May 2021 15:23:19 +0000 (23:23 +0800)]
crimson/osd: make do_osd_ops receive lvalue reference to osd ops vector
otherwise any async execution of lambdas in PG::do_osd_ops_execute() may
reference a outdated osd_op
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Sebastian Wagner [Mon, 17 May 2021 12:23:05 +0000 (14:23 +0200)]
Merge pull request #40172 from p-se/pse-fix-cephadm-prom-alerts-missing
mgr/cephadm: fix missing prometheus alerts
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
zdover23 [Mon, 17 May 2021 11:40:42 +0000 (21:40 +1000)]
Merge pull request #41361 from zdover23/wip-doc-rados-gateway-spelling-embeddding-2021-05-17
doc/radosgw: s/embeddding/embedding/
Reviewed-by: Kefu Chai <kchai@redhat.com>
Aran85 [Mon, 17 May 2021 10:32:11 +0000 (18:32 +0800)]
crimson/seastore: add string_kv_node_layout diagrams
Signed-off-by: Zengran Zhang <zhangzengran@sangfor.com.cn>
Zac Dover [Mon, 17 May 2021 11:01:37 +0000 (21:01 +1000)]
doc/radosgw: s/embeddding/embedding/
res ipsa loquitur
Signed-off-by: Zac Dover <zac.dover@gmail.com>
Kefu Chai [Mon, 17 May 2021 07:10:35 +0000 (15:10 +0800)]
Merge pull request #41360 from mflehmig/patch-1
doc/rados: Fix typo
Reviewed-by: Kefu Chai <kchai@redhat.com>