]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Sage Weil [Sun, 11 Jul 2021 17:24:00 +0000 (13:24 -0400)]
common/blkdev: remove stray debug output
Signed-off-by: Sage Weil <sage@newdream.net>
Sébastien Han [Thu, 8 Jul 2021 10:26:48 +0000 (12:26 +0200)]
Merge pull request #42055 from leseb/crash-various-fixes
src/ceph-crash.in: various enhancements and fixes
Kefu Chai [Thu, 8 Jul 2021 06:42:27 +0000 (14:42 +0800)]
Merge pull request #42236 from tchaikov/wip-crimson-no-protobuf
ceph.spec,debian: drop protobuf dependencies
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Thu, 8 Jul 2021 01:17:50 +0000 (09:17 +0800)]
Merge pull request #42185 from qiuxinyidian/dev2
cmake: set denc_plugin_dir with the full path
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 8 Jul 2021 00:49:02 +0000 (08:49 +0800)]
ceph.spec,debian: drop protobuf dependencies
since Seastar has dropped the protobuf dependencies, there is no
need to prepare them for building crimson anymore.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 8 Jul 2021 00:48:13 +0000 (08:48 +0800)]
seastar: bump seastar to latest upstream master
to pick up the change to drop protobuf dependency
Signed-off-by: Kefu Chai <kchai@redhat.com>
Xie Xingguo [Thu, 8 Jul 2021 00:33:58 +0000 (08:33 +0800)]
Merge pull request #42141 from trociny/wip-38931
osd: move down peers out from peer_purged
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Ilya Dryomov [Wed, 7 Jul 2021 22:57:55 +0000 (00:57 +0200)]
Merge pull request #42164 from yuriw/wip-yuriw-crontab-master
qa/tests: removed nautilus suites as EOL
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Yuri Weinstein [Fri, 2 Jul 2021 17:54:39 +0000 (10:54 -0700)]
qa/tests: removed nautilus suites as EOL, kept kcephfs and krbd suites
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Kefu Chai [Wed, 7 Jul 2021 13:58:30 +0000 (21:58 +0800)]
Merge pull request #42176 from tchaikov/wip-doc-option
doc/rados/troubleshooting/log-and-debug: document option using :confval:
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Kefu Chai [Wed, 7 Jul 2021 13:22:53 +0000 (21:22 +0800)]
Merge pull request #42136 from dvanders/dvanders_lec_merging
mon/OSDMonitor: resize oversized Lec::epoch_by_pg, after PG merging, preventing osdmap trimming
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
J. Eric Ivancich [Wed, 7 Jul 2021 12:30:09 +0000 (08:30 -0400)]
Merge pull request #42190 from ivancich/wip-unused-store-warning
rgw: remove unused store variable
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Kalpesh Pandya <kapandya@redhat.com>
Dan van der Ster [Thu, 1 Jul 2021 14:12:26 +0000 (16:12 +0200)]
mon/OSDMonitor: account for PG merging in epoch_by_pg accounting
After a pool has merged PGs, the epoch_by_pg accounting will refer
to osdmap epochs of PGs that no longer exist. We'll never again get
OSD beacons for these PGs, so the min epoch in epoch_by_pg will not
advance until the mon leader has restarted. The effect of this is
that osdmaps are not trimmed after a pool has undergone PG merging,
until the mon leader restarts. To fix, we unconditionally resize
epoch_by_pg to the pg_num of the pool during each beacon report.
Fixes: https://tracker.ceph.com/issues/48212
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
Kefu Chai [Wed, 7 Jul 2021 11:23:48 +0000 (19:23 +0800)]
Merge pull request #42040 from wjwithagen/wjw-wip-bluestore-choose_fdv3
blk: use choose_fd for all filehandle references
Reviewed-by: Kefu Chai <kchai@redhat.com>
Willem Jan Withagen [Wed, 7 Jul 2021 09:50:50 +0000 (11:50 +0200)]
blk/kernel: Only use file hint capabilities if available.
Without WRITE_LIFE capabilities, only one file is used.
And rocksdb sets this value also to > 0, so we need to catch this here
instead of trusting rocksdb to set write_hint.
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
Willem Jan Withagen [Thu, 1 Jul 2021 16:08:20 +0000 (18:08 +0200)]
blk/kernel: reorganise and use fd in debug
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
Willem Jan Withagen [Sat, 26 Jun 2021 13:47:24 +0000 (15:47 +0200)]
blk: use choose_fd for all filehandle references
This is a leading part of the changes to implement bluestore on
FreeBSD. Without this invalid indexing in the descriptor arrays
will occur.
Creates a new enum: `blk_access_mode_t`
to describe `BUFFERED` and `DIRECT `mode access
with `choose_fd()` to get the correct file for the typed access
and adds
a pretty-printer
boolean convertor `blk_access_mode_t::buffermode(bool)`
This PR is a redo for PR #37258, since that one was lost
in rebasing errors. But the review notes are still there.
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
Alfonso Martínez [Wed, 7 Jul 2021 09:15:58 +0000 (11:15 +0200)]
Merge pull request #42183 from SMIL-Infra/fix-ac-lang
mgr/dashboard: fix Accept-Language header parsing
Mark Kogan [Wed, 7 Jul 2021 09:11:47 +0000 (12:11 +0300)]
Merge pull request #36266 from amathuria/wip-rgw-d3n-cache-upstreaming
rgw: D3N Cache changes for Upstream
Kefu Chai [Wed, 7 Jul 2021 08:37:08 +0000 (16:37 +0800)]
Merge pull request #42158 from tchaikov/wip-e2e-centos
qa: run e2e test on centos only
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Kefu Chai [Wed, 7 Jul 2021 08:19:41 +0000 (16:19 +0800)]
Merge pull request #42175 from tchaikov/wip-45457
log: set hostname and fsid for graylog
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Wed, 7 Jul 2021 08:11:23 +0000 (16:11 +0800)]
Merge pull request #42205 from tchaikov/wip-doc-crimson-metrics
doc/dev/crimson: add a section for metrics
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Wed, 7 Jul 2021 08:04:41 +0000 (16:04 +0800)]
Merge pull request #42179 from brucen1030/wip-fix-mon-crash-when-osd-pool-get
mon: return -EINVAL when handling unknown option in 'ceph osd pool get'
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 7 Jul 2021 07:47:34 +0000 (15:47 +0800)]
Merge pull request #42177 from sebastian-philipp/cephadm-ls-garbage
mgr/cephadm: avoid saving daemons of unknown type
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 7 Jul 2021 06:26:26 +0000 (14:26 +0800)]
doc/dev/crimson: add a section for metrics
Signed-off-by: Kefu Chai <kchai@redhat.com>
zhipeng li [Mon, 5 Jul 2021 14:15:02 +0000 (22:15 +0800)]
cmake: set denc_plugin_dir with the full path
This commit changes denc_plugin_dir from relative to absolute path, so
that CEPH_DENC_MOD_DIR points to the absolute path and ceph-dencoder
is able to load the shared libraries from the specified path.
Fixes:https://tracker.ceph.com/issues/51519
Signed-off-by: zhipeng li <qiuxinyidian@gmail.com>
Kefu Chai [Wed, 7 Jul 2021 07:16:45 +0000 (15:16 +0800)]
Merge pull request #42168 from tchaikov/wip-mgr-unsigned-pgp
mgr/DaemonServer: use "unsigned" to represent the pgp num
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Kefu Chai [Wed, 7 Jul 2021 02:51:42 +0000 (10:51 +0800)]
Merge pull request #42203 from tchaikov/wip-crimson-metrics
crimson/admin: dump DERIVE metrics as signed integer
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Wed, 7 Jul 2021 02:29:59 +0000 (10:29 +0800)]
crimson/admin: dump DERIVE metrics as signed integer
per include/seastar/core/metrics.hh,
// The value binding data types
enum class data_type : uint8_t {
COUNTER, // unsigned int 64
GAUGE, // double
DERIVE, // signed int 64
ABSOLUTE, // unsigned int 64
HISTOGRAM,
};
the DERIVE values are signed.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Patrick Donnelly [Tue, 6 Jul 2021 20:08:32 +0000 (13:08 -0700)]
Merge PR #42139 into master
* refs/pull/42139/head:
src/pybind/mgr/mirroring/fs/snapshot_mirror.py: do not assume a cephfs-mirror daemon is always running
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Patrick Donnelly [Tue, 6 Jul 2021 20:07:53 +0000 (13:07 -0700)]
Merge PR #42137 into master
* refs/pull/42137/head:
msg/async/net_handler: do not define variable unless it is used
mds/cephfs_features: print size_t using "%zu"
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Yuval Lifshitz [Tue, 6 Jul 2021 19:02:02 +0000 (22:02 +0300)]
Merge pull request #42155 from yuvalif/wip-yuval-fix-51347
rgw/notifications: cache object size to avoid accessing invalid memoery
Patrick Donnelly [Tue, 6 Jul 2021 18:54:18 +0000 (11:54 -0700)]
Merge PR #41966 into master
* refs/pull/41966/head:
mgr/volumes: use dedicated libcephfs handles for subvolume calls and async jobs
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Mark Kogan [Sun, 27 Sep 2020 17:25:11 +0000 (20:25 +0300)]
rgw: D3N Cache changes for Upstream
Upstreaming / rebase of #24500
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
rgw: change io_ctx pool per storage class
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: Changing free() to delete()
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
rgw: Addressing review comments
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
rgw: Fixing seg fault
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
Moving CacheRequest out of librados
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
rgw: cache initialization fix
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
rgw: fix missing spawn.hpp compile errors
resolves compilation errors similar to:
```
[ 15%] Building CXX object src/tools/immutable_object_cache/CMakeFiles/ceph_immutable_object_cache_lib.dir/CacheController.cc.o
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_common.h:31,
from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_rados.h:17,
from /home/jenkins-build/build/workspace/ceph-pull-requests/src/librados/IoCtxImpl.h:30,
from /home/jenkins-build/build/workspace/ceph-pull-requests/src/librados/RadosClient.h:35,
from /home/jenkins-build/build/workspace/ceph-pull-requests/src/neorados/RADOSImpl.h:27,
from /home/jenkins-build/build/workspace/ceph-pull-requests/src/neorados/RADOS.cc:37:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/async/yield_context.h:31:10: fatal error: spawn/spawn.hpp: No such file or directory
31 | #include <spawn/spawn.hpp>
| ^~~~~~~~~~~~~~~~~
compilation terminated.
src/neorados/CMakeFiles/neorados_api_obj.dir/build.make:62: recipe for target 'src/neorados/CMakeFiles/neorados_api_obj.dir/RADOS.cc.o' failed
make[3]: *** [src/neorados/CMakeFiles/neorados_api_obj.dir/RADOS.cc.o] Error 1
```
Signed-off-by: Mark Kogan <mkogan@redhat.com>
Resolving merge conflict
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
Removing all logs and unnecessary comments
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
Cache Read and Write working
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
Initial Commit L1 Cache
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
post re-rebase merge, update fixes
Signed-off-by: Mark Kogan <mkogan@redhat.com>
fixup! post re-rebase merge, update fixes
rgw: continuation of rgwcache branch rebase
Signed-off-by: Mark Kogan <mkogan@redhat.com>
RGW: DataCache: post merge fixes
Signed-off-by: Mark Kogan <mkogan@redhat.com>
fixes of segmentation fault caused by oid
Signed-off-by: E. Ugur Kaynar <ukaynar@bu.edu>
rgw: fixes for segmentation faults and configuration processing
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: data cache first commit
Signed-off-by: Mania Abdi <mania.abdi287@gmail.com>
rgw: cleanup addressing PR comments
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: cleanup addressing PR comments, continuation.
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: pr cleanup addressing second review round
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: Addressing review comments, removing all D3N code from librados
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
rgw: for compilation err from removal of mydout() helper
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rge: addressing review comments
rgw: move d3n datacache into separate files
rgw: 1st part of datacache rebranding to d3n
fix forward declaration compile err (only with clang):
../src/rgw/rgw_cache.h:396:4: error: member access into incomplete type 'struct get_obj_data'
d->data_lock.lock();
^
../src/rgw/rgw_cache.h:365:8: note: forward declaration of 'get_obj_data'
struct get_obj_data;
^
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: addressing review comments, datacache rebranding to d3n cache
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: Cleaning up unused D3N cache code
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
rgw: cont. cleaning up of rgw_obj_data()
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: Removing redundant code, fix for multipart S3 objects
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
rgw: fix: incorrect content len on multipart get
in s3tests_boto3.functional.test_s3:test_multipart_copy_versioned
when d3n cache is disabled
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: fix segfault reading from cache
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: fix segfault in multisite
sync on secondary site
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: fix segfault in multisite teuthology tests, cont.
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: Adding drain to wait for all AIO reads to complete
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
rgw: fix for using read() by liabio or posix io per config
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: improve persistent data cache directory handling
on start create the persistent datacache directory if necessary
and add an option to evict it's content if already exists
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: fix possible segfault during eviction
Signed-off-by: Mark Kogan <mkogan@redhat.com>
Co-authored-by: Mania Abdi <mania.abdi287@gmail.com>
Co-authored-by: E. Ugur Kaynar <ukaynar@bu.edu>
Co-authored-by: Aishwarya Mathuria <amathuri@redhat.com>
Co-authored-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: addressing latest review comments
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: add debug logs for cache in/out flow
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: move the L2 cache functionality to separate PR
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: addressing review comments
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: address java_s3tests teuthology issues
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: do not handle compressed objects fro now
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: l2 cleanup and log fixups + post dpp
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: thread dpp thru get_obj_iterate_cb() and related
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: bypass reading versioned objects from cache
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: cleanup and fix s3tests
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: allow to enable cache only on beast
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: delete the content of the cache directory on rgw start
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: re-enable d3n cache with civetweb frontend
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: rebase post zipper 10
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: address teuthoogy valgrind leaks detected
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: mitigating valgrind leaks
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: remove rgw_d3n_l1_libaio_read option
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: wip segfault fix
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: mitigate libaio SIGEV_THREAD cb race
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: change libaio signaling mechanism
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: wip cont. libaio cb thread race
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: wip libaio cb thread race
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: libaio cleanups and edge case handling fixes
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: narrow the libaio locking scope
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: add libaio req ordering mechanism
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: fix lock regression
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: addressing reviwe comments and cleasnup
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: libaio locks cleanup
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: refactor libaio abstraction to share the ioc implementation
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: addressing latest review comments and cleanup
Signed-off-by: Mark Kogan <mkogan@redhat.com>
rgw: d3n: address review comments, cont.
Signed-off-by: Mark Kogan <mkogan@redhat.com>
Co-authored-by: Mania Abdi <mania.abdi287@gmail.com>
Co-authored-by: E. Ugur Kaynar <ukaynar@bu.edu>
Co-authored-by: Aishwarya Mathuria <amathuri@redhat.com>
Co-authored-by: Ali Maredia <amaredia@redhat.com>
Co-authored-by: Feng Hualong <hualong.feng@intel.com>
Kefu Chai [Tue, 6 Jul 2021 04:53:52 +0000 (12:53 +0800)]
Merge pull request #42174 from cyx1231st/wip-seastore-fix-transactional-retire
crimson/os/seastore: leverage RetiredExtentPlaceholder to detect transaction conflicts
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Yingxin Cheng [Mon, 5 Jul 2021 13:59:10 +0000 (21:59 +0800)]
crimson/os/seastore/cache: cleanup query_cache_with_placeholders()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 5 Jul 2021 03:29:57 +0000 (11:29 +0800)]
crimson/os/seastore/transaction: remove unused retired_uncached
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 5 Jul 2021 03:28:35 +0000 (11:28 +0800)]
crimson/os/seastore: leverage RetiredExtentPlaceholder to detect transaction conflicts
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Mon, 5 Jul 2021 03:24:57 +0000 (11:24 +0800)]
crimson/os/seastore: remove unused template in RetiredExtentPlaceholder
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin Cheng [Thu, 1 Jul 2021 06:03:02 +0000 (14:03 +0800)]
crimson/os/seastore/cache: cleanup, consolidate extent lookup through query_cache_for_extent()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Tue, 6 Jul 2021 01:05:29 +0000 (09:05 +0800)]
Merge pull request #42187 from tchaikov/wip-crimson-cleanup
crimson/os/seastore: use discard_result() to discard futurized value
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
J. Eric Ivancich [Mon, 5 Jul 2021 23:27:00 +0000 (19:27 -0400)]
rgw: remove unused store variable
A recent change made the store variable unnecessary and now compiling
generates a warning. Clean up.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 15:50:17 +0000 (23:50 +0800)]
doc/rados/troubleshooting/log-and-debug: use ini to highlight code block
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 04:47:59 +0000 (12:47 +0800)]
doc/rados/troubleshooting/log-and-debug: document option using :confval:
* simpler this way.
* and drop non-existent options.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 15:32:11 +0000 (23:32 +0800)]
Merge pull request #42186 from lorenzbausch/fix_typo
doc/dev/crimson/osd: fix typo
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 15:27:27 +0000 (23:27 +0800)]
crimson/common/errorator: forward declare futurize as a struct
as it is defined as struct, otherwise clang complains on this
inconsistency.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 14:54:51 +0000 (22:54 +0800)]
crimson/os/seastore: use discard_result() to discard futurized value
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 14:53:53 +0000 (22:53 +0800)]
crimson/os/seastore: capture variables explicitly
less error prune this way.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 14:53:21 +0000 (22:53 +0800)]
crimson/common: add discard_result() to errorator
so we can discard result explicitly.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Lorenz Bausch [Mon, 5 Jul 2021 14:50:42 +0000 (16:50 +0200)]
doc/dev/crimson/osd: fix typo
Signed-off-by: Lorenz Bausch <info@lorenzbausch.de>
Kefu Chai [Mon, 5 Jul 2021 14:17:46 +0000 (22:17 +0800)]
Merge pull request #42184 from xxhdx1985126/wip-seastore-lambda
crimson/os/seastore: fix lambda capture issue in Journal::scan_extents()
Reviewed-by: Kefu Chai <kchai@redhat.com>
Xuehan Xu [Mon, 5 Jul 2021 13:41:03 +0000 (21:41 +0800)]
crimson/os/seastore: fix lambda capture issue in Journal::scan_extents()
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
胡玮文 [Mon, 5 Jul 2021 13:27:57 +0000 (21:27 +0800)]
mgr/dashboard: fix Accept-Language header parsing
Fix 400 error caused by multi-subtag language in Accept-Language header.
Reproduced by Firefox for Android in Chinese.
The regex expression is fixed according to https://datatracker.ietf.org/doc/html/rfc4647#section-2.1
Fixes: https://tracker.ceph.com/issues/51528
Signed-off-by: 胡玮文 <huww98@outlook.com>
Zhao Cuicui [Mon, 5 Jul 2021 08:53:17 +0000 (16:53 +0800)]
mon: return -EINVAL when handling unknown option in 'ceph osd pool get'
Signed-off-by: Zhao Cuicui <brucen1030@163.com>
Kefu Chai [Mon, 5 Jul 2021 10:25:24 +0000 (18:25 +0800)]
Merge pull request #42178 from xxhdx1985126/wip-collection-manager-test-case
test/crimson/seastore: fix a bug in the collection manager test case
Reviewed-by: Kefu Chai <kchai@redhat.com>
Sébastien Han [Mon, 28 Jun 2021 16:49:15 +0000 (18:49 +0200)]
src/ceph-crash.in: print stderr if available
This is not perfect, but we have seen cases where the CLI returns 0 even
on failure.
For instance:
```sh
[root@rook-ceph-crashcollector-compute-1-
66bdfbd886 -d2zcd /]# ceph -n client.crash crash post -i /var/lib/ceph/crash/2021-06-28T07\:47\:37.859766Z_6ffb119c-930e-4047-9cfa-
a92af783cdd0 /meta
malformed crash metadata: time data '2021-06-28T07:47:37.859766' does not match format '%Y-%m-%d %H:%M:%S.%f'
[root@rook-ceph-crashcollector-compute-1-
66bdfbd886 -d2zcd /]# echo $?
0
```
So until we find the root cause, let's mitigate and perhaps accomodate
for futur similar issues.
Signed-off-by: Sébastien Han <seb@redhat.com>
Sébastien Han [Mon, 28 Jun 2021 16:40:22 +0000 (18:40 +0200)]
src/ceph-crash.in: adad log-level support
Now, the script can run with --log-level DEBUG to enable DEBUG level
logging.
Signed-off-by: Sébastien Han <seb@redhat.com>
Sébastien Han [Mon, 28 Jun 2021 16:36:51 +0000 (18:36 +0200)]
src/ceph-crash.in: fix --name usage
Previously when the --name was used, the code will still go through the
initial list. Now if --name is passed, only this user will be used to
upload crashes.
Signed-off-by: Sébastien Han <seb@redhat.com>
Sébastien Han [Mon, 28 Jun 2021 16:36:08 +0000 (18:36 +0200)]
src/ceph-crash.in: remove unused frame in handler()
frame was unused so let's remove it.
Signed-off-by: Sébastien Han <seb@redhat.com>
Xuehan Xu [Mon, 5 Jul 2021 08:56:53 +0000 (16:56 +0800)]
test/crimson/seastore: fix bug in the collection manager test case
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Sebastian Wagner [Mon, 5 Jul 2021 08:34:56 +0000 (10:34 +0200)]
mgr/cephadm: avoid saving daemons of unknown type
Fixes: https://tracker.ceph.com/issues/51176
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 05:17:47 +0000 (13:17 +0800)]
Merge pull request #42171 from sharuzzaman/patch-1
doc/rados/configuration: fixing small typo for word "implemebnt"
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 04:14:21 +0000 (12:14 +0800)]
common/Graylog: consolidate ctors
* initialize member variables in-class
* use delegate ctor to dedup the logic in two ctors.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 02:09:05 +0000 (10:09 +0800)]
common/Graylog: assert(!m_hostname.empty()) in Graylog
to verify that we always have a non-empty host field in log entry sent
to graylog per the spec of GrayLog. see https://docs.graylog.org/en/4.0/pages/gelf.html#gelf-payload-specification
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 01:38:57 +0000 (09:38 +0800)]
log: set hostname and fsid for graylog
in which, hostname is mandatory per
https://docs.graylog.org/en/4.0/pages/gelf.html#gelf-payload-specification,
so without this change, if user enables `log_to_graylog` and/or `err_to_graylog`,
failures like
java.lang.IllegalArgumentException: GELF message <
ed6876e1 -9265-11ea-bc94-
1ad2db8b5489 > (received from <10.10.10.12:36509>) has empty mandatory "host" field.
is expected.
after this change, this field is set.
Fixes: https://tracker.ceph.com/issues/45457
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 5 Jul 2021 04:00:24 +0000 (12:00 +0800)]
common/common_init: set conf->host in common_preinit()
conf.host is used by graylog for setting the "host" property.
and it is used when serving the "get config" command when the command
queries the "host", so better off setting it early before
flushing the log entries with graylog.
Fixes: https://tracker.ceph.com/issues/45457
Signed-off-by: Kefu Chai <kchai@redhat.com>
Sharuzzaman Ahmat Raslan [Sun, 4 Jul 2021 18:06:21 +0000 (02:06 +0800)]
doc/rados/configuration: fixing small typo for word "implemebnt"
Signed-off-by: Sharuzzaman Ahmat Raslan <sharuzzaman@gmail.com>
Ali Maredia [Tue, 1 Dec 2020 04:25:01 +0000 (04:25 +0000)]
qa: add workunit for testing rgw datacache
Add a workunit for testing the rgw object cache
by using s3cmd to write objects and then
verify the objects in the cache.
Also move the 0-install.yaml file out of tasks and
into the main dir for the rgw/verify subsuite.
Signed-off-by: Ali Maredia <amaredia@redhat.com>
qa: d3n: add debug logs
Signed-off-by: Ali Maredia <amaredia@redhat.com>
rgw: s3n: qa: fix netstat search for rgw process
Signed-off-by: Mark Kogan <mkogan@redhat.com>
Kefu Chai [Sun, 4 Jul 2021 05:48:26 +0000 (13:48 +0800)]
mgr/DaemonServer: use "unsigned" to represent the pgp num
as pgp num should alwayes be unsigned, and this change silences the
GCC warning like:
../src/mgr/DaemonServer.cc: In lambda function:
../src/mgr/DaemonServer.cc:2862:15: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
2862 | if (next != p.get_pgp_num()) {
| ~~~~~^~~~~~~~~~~~~~~~~~
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Sun, 4 Jul 2021 05:02:17 +0000 (13:02 +0800)]
Merge pull request #42147 from xxhdx1985126/wip-interruptible-errorator
crimson/common: allow interruptible parallel_for_each to handle error…
Reviewed-by: Kefu Chai <kchai@redhat.com>
Xuehan Xu [Fri, 2 Jul 2021 04:05:02 +0000 (12:05 +0800)]
crimson/common: allow interruptible parallel_for_each to handle errorated future
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Sage Weil [Sat, 3 Jul 2021 18:19:03 +0000 (14:19 -0400)]
Merge PR #41938 into master
* refs/pull/41938/head:
mgr/cephadm: include addr in HOST_CHECK_FAILED alert detail
Reviewed-by: Adam King <adking@redhat.com>
Yuval Lifshitz [Fri, 2 Jul 2021 13:12:33 +0000 (16:12 +0300)]
rgw/notifications: cache object size to avoid accessing invalid memoery
Fixes: https://tracker.ceph.com/issues/51347
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Patrick Donnelly [Fri, 2 Jul 2021 20:17:05 +0000 (13:17 -0700)]
Merge PR #42081 into master
* refs/pull/42081/head:
qa: use kclient xattr to lookup client id
qa: refactor reading debug file code
qa: get mount id before failing fs
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Patrick Donnelly [Fri, 2 Jul 2021 20:14:42 +0000 (13:14 -0700)]
Merge PR #42075 into master
* refs/pull/42075/head:
qa: avoid using sudo for regular test artifacts
qa: convert mount calls to mount_wait
qa: use run_shell_payload to avoid sudo
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Patrick Donnelly [Tue, 29 Jun 2021 00:15:19 +0000 (17:15 -0700)]
qa: use kclient xattr to lookup client id
Added relatively recently but in RHEL 8.4.
Fixes: https://tracker.ceph.com/issues/51183
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Ali Maredia [Fri, 2 Jul 2021 18:02:54 +0000 (14:02 -0400)]
Merge pull request #41926 from TRYTOBE8TME/wip-rgw-dpp-2
src/rgw: DPP addition 3
Reviewed-by: Ali Maredia <amaredia@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 16:58:56 +0000 (00:58 +0800)]
Merge pull request #42105 from dvanders/dvanders_pgp_num_actual
mgr/DaemonServer: skip redundant update of pgp_num_actual
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 15:15:38 +0000 (23:15 +0800)]
Merge pull request #41829 from SMIL-Infra/clean-cg
cephadm: workaround unit replace failure
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 15:14:56 +0000 (23:14 +0800)]
Merge pull request #41928 from sebastian-philipp/rm-qa-qa
qa: remove `qa/.qa` symlink
Reviewed-by: Yuri Weinstein <yweins@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 15:14:27 +0000 (23:14 +0800)]
Merge pull request #41943 from liewegas/qa-8-stream
qa/distro/supported: add centos 8.stream
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 15:05:37 +0000 (23:05 +0800)]
qa: run e2e test on centos only
this change is a follow up of
02b8b0f49059b58db8b2d16fcc647a17d5ecdf43 ,
which failed to remove the random facet for distro.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 14:59:24 +0000 (22:59 +0800)]
Merge pull request #42146 from tchaikov/wip-crimson-cleanup
crimson/os/seastore: do not capture unused variable
Reviewed-by: Samuel Just <sjust@redhat.com>
Sebastian Wagner [Fri, 2 Jul 2021 13:17:06 +0000 (15:17 +0200)]
Merge pull request #42032 from sebastian-philipp/cephadm_shared_folder_bin_cephadm
cephadm: shared folder: Mount the cephadm
Reviewed-by: Adam King <adking@redhat.com>
Sebastian Wagner [Fri, 2 Jul 2021 13:16:42 +0000 (15:16 +0200)]
Merge pull request #41906 from mgfritch/cephadm-test-monaddrv
cephadm: add `bootstrap --mon-addrv` test
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Sebastian Wagner [Fri, 2 Jul 2021 13:16:11 +0000 (15:16 +0200)]
Merge pull request #42017 from Daniel-Pivonka/cephadm-orch-host-drain
mgr/cephadm: add ceph orch host drain and limit host removal to empty hosts
Reviewed-by: Adam King <adking@redhat.com>
Ernesto Puerta [Fri, 2 Jul 2021 10:51:19 +0000 (12:51 +0200)]
Merge pull request #41883 from rhcs-dashboard/run-dashboard-cephadm-e2e-tests
mgr/dashboard: run cephadm-backend e2e tests with KCLI
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 08:56:24 +0000 (16:56 +0800)]
Merge pull request #42144 from cyx1231st/wip-fix-seastore-cache2
crimson/os/seastore/cache: fix retiring mutation-pending extents
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@360.cn>
Alfonso Martínez [Fri, 2 Jul 2021 08:08:49 +0000 (10:08 +0200)]
mgr/dashboard: run cephadm-backend e2e tests with KCLI
Fixes: https://tracker.ceph.com/issues/51300
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
Yingxin Cheng [Fri, 2 Jul 2021 01:28:39 +0000 (09:28 +0800)]
crimson/os/seastore/cache: fix retiring mutation-pending extents
Mark the retiring mutation-pending extent as INVALID, and add it's
prior-instance to retired-set in order to populate transaction
invalidation correctly.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Kefu Chai [Fri, 2 Jul 2021 03:56:42 +0000 (11:56 +0800)]
crimson/os/seastore: use map::emplace(key, val) instead of map::emplace(pair<>)
simpler this way.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 03:33:43 +0000 (11:33 +0800)]
crimson/os/seastore: do not capture unused variable
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 03:32:15 +0000 (11:32 +0800)]
crimson/os/seastore: read_set_t<> should be an alias of set<>
we don't extend it by inheriting from this class. what we need is to
have a convenient template alias here.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Samuel Just [Fri, 2 Jul 2021 03:34:04 +0000 (20:34 -0700)]
Merge pull request #42143 from athanatos/sjust/wip-cm-omap-int-future
crimson/os/seastore: convert omap and collection_manager to interruptible future
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kalpesh Pandya [Wed, 16 Jun 2021 08:33:52 +0000 (14:03 +0530)]
rgw: DPP addition 3
Following files have been covered in this PR:
1. rgw_period_puller.cc
2. rgw_reshard.cc
3. rgw_sal_rados.cc
4. services/svc_sync_modules.cc
5. services/svc_bucket_sobj.cc
6. services/svc_notify.cc
7. rgw_acl_swift.cc
8. rgw_acl.cc
9. rgw_sync_module_aws.cc
10. rgw_tools.cc
11. services/svc_sys_obj_cache.cc
12. rgw_bucket_sync.cc
Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 00:16:23 +0000 (08:16 +0800)]
Merge pull request #42138 from rzarzynski/wip-crimson-alienstore-indent
crimson/os: fix indentation in alien_store.cc.
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 2 Jul 2021 00:11:12 +0000 (08:11 +0800)]
Merge pull request #42128 from tchaikov/wip-crimson-asock-cleanup
crimson/asock: cleanups
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Samuel Just [Wed, 30 Jun 2021 21:29:15 +0000 (14:29 -0700)]
crimson/os/seastore/omap_manager: convert to use interruptible future
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Wed, 30 Jun 2021 00:20:13 +0000 (17:20 -0700)]
crimson/os/seastore/collection_manager: convert to use interruptible_future
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Wed, 30 Jun 2021 00:19:23 +0000 (17:19 -0700)]
test/crimson/seastore: clean up transaction_manager based tests
Permits using either vanilla TransactionManager and
InterruptedTransactionManager, updates users to use submit_transaction
helpers.
Signed-off-by: Samuel Just <sjust@redhat.com>