]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 years agoos/bluestore: fix erroneous SharedBlob record removal during repair. 42373/head
Igor Fedotov [Fri, 9 Jul 2021 18:13:48 +0000 (21:13 +0300)]
os/bluestore: fix erroneous SharedBlob record removal during repair.

Fixes: https://tracker.ceph.com/issues/51619
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit 7090930d4a2e6f2efdecaff23f9a2f795e7819fb)

4 years agoMerge pull request #42025 from idryomov/wip-rbd-qemu-iotests-focal-octopus
Yuri Weinstein [Tue, 13 Jul 2021 00:16:31 +0000 (17:16 -0700)]
Merge pull request #42025 from idryomov/wip-rbd-qemu-iotests-focal-octopus

octopus: qa/workunits/rbd: use bionic version of qemu-iotests for focal

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #41775 from trociny/wip-51142-octopus
Yuri Weinstein [Mon, 12 Jul 2021 16:05:39 +0000 (09:05 -0700)]
Merge pull request #41775 from trociny/wip-51142-octopus

octopus: cls/rgw: look for plain entries in non-ascii plain namespace too

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #42161 from batrick/i51494
Yuri Weinstein [Mon, 12 Jul 2021 15:42:30 +0000 (08:42 -0700)]
Merge pull request #42161 from batrick/i51494

octopus: pacific: pybind/ceph_volume_client: stat on empty string

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #41996 from batrick/i51336
Yuri Weinstein [Mon, 12 Jul 2021 15:41:54 +0000 (08:41 -0700)]
Merge pull request #41996 from batrick/i51336

octopus: mds: avoid journaling overhead for setxattr("ceph.dir.subvolume") for no-op case

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #41767 from cfsnyder/wip-50916-octopus
Yuri Weinstein [Mon, 12 Jul 2021 15:41:12 +0000 (08:41 -0700)]
Merge pull request #41767 from cfsnyder/wip-50916-octopus

octopus: mds: fix cpu_profiler asok crash

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #41626 from cfsnyder/wip-50874-octopus
Yuri Weinstein [Mon, 12 Jul 2021 15:40:43 +0000 (08:40 -0700)]
Merge pull request #41626 from cfsnyder/wip-50874-octopus

octopus: mds: place the journaler pointer under the mds_lock

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #41625 from cfsnyder/wip-50635-octopus
Yuri Weinstein [Mon, 12 Jul 2021 15:40:09 +0000 (08:40 -0700)]
Merge pull request #41625 from cfsnyder/wip-50635-octopus

octopus: mds: completed_requests -> num_completed_requests and dump num_completed_flushes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #40782 from smithfarm/wip-50283-octopus
Yuri Weinstein [Mon, 12 Jul 2021 15:36:32 +0000 (08:36 -0700)]
Merge pull request #40782 from smithfarm/wip-50283-octopus

octopus: mds: reject lookup ino requests for mds dirs

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 years agoMerge pull request #41757 from ifed01/wip-ifed-tchaikov-rocksdb-oct
Yuri Weinstein [Mon, 12 Jul 2021 14:51:59 +0000 (07:51 -0700)]
Merge pull request #41757 from ifed01/wip-ifed-tchaikov-rocksdb-oct

octopus: bluestore: use string_view and strip trailing slash for dir listing

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #41887 from s0nea/wip-51052-octopus
Alfonso Martínez [Wed, 7 Jul 2021 10:47:02 +0000 (12:47 +0200)]
Merge pull request #41887 from s0nea/wip-51052-octopus

octopus: mgr/dashboard: show partially deleted RBDs

4 years agoMerge pull request #42154 from rhcs-dashboard/wip-51477-octopus
Ernesto Puerta [Tue, 6 Jul 2021 16:14:36 +0000 (18:14 +0200)]
Merge pull request #42154 from rhcs-dashboard/wip-51477-octopus

octopus: mgr/dashboard: fix OSD out count

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: huww98 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
4 years agoMerge pull request #42123 from rhcs-dashboard/bucket-async-validator-octopus
Ernesto Puerta [Fri, 2 Jul 2021 17:32:03 +0000 (19:32 +0200)]
Merge pull request #42123 from rhcs-dashboard/bucket-async-validator-octopus

octopus: mgr/dashboard: RGW buckets async validator performance enhancement and name constraints

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 years agoMerge pull request #41649 from rhcs-dashboard/wip-50425-octopus
Ernesto Puerta [Fri, 2 Jul 2021 17:31:28 +0000 (19:31 +0200)]
Merge pull request #41649 from rhcs-dashboard/wip-50425-octopus

octopus: mgr/Dashboard: Remove erroneous elements in hosts-overview Grafana dashboard

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: malcolmholmes <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
4 years agoMerge pull request #42015 from rhcs-dashboard/wip-51179-octopus
Ernesto Puerta [Fri, 2 Jul 2021 17:29:24 +0000 (19:29 +0200)]
Merge pull request #42015 from rhcs-dashboard/wip-51179-octopus

octopus: mgr/dashboard: fix for right sidebar nav icon not clickable

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: aaryanporwal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 years agopybind/ceph_volume_client: use cephfs mkdirs api 42161/head
Patrick Donnelly [Fri, 2 Jul 2021 16:07:34 +0000 (09:07 -0700)]
pybind/ceph_volume_client: use cephfs mkdirs api

This _mkdir_p should never have worked as the first directory it tries
to stat/mkdir is "", the empty string. This causes an assertion in the
client. I'm not sure how this code ever functioned without causing
faults. They look like:

    2021-07-01 02:15:04.449 7f7612b5ab80  3 client.178735 statx enter (relpath  want 2047)

The assertion is caused by a C++ exception:

/usr/include/c++/8/string_view:172: constexpr const _CharT& std::basic_string_view<_CharT, _Traits>::operator[](std::basic_string_view<_CharT, _Traits>::size_type) const [with _CharT = char$_Traits = std::char_traits<char>; std::basic_string_view<_CharT, _Traits>::size_type = long unsigned int]: Assertion '__pos < this->_M_len' failed.
        Aborted (core dumped)

Where relpath is just the path passed to Client::stat.

This commit only applies to Pacific and older because master no longer
has this library.

Fixes: https://tracker.ceph.com/issues/51492
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 0fb05aea8a6e12c37a9b54641715a9a94ae1366f)

4 years agomgr/dashboard: fix OSD out count 42154/head
胡玮文 [Mon, 21 Jun 2021 13:31:49 +0000 (21:31 +0800)]
mgr/dashboard: fix OSD out count

Think we have 3 OSDs out but up (prepare for re-formatting to change min_alloc_size), and another OSD down but in
(during reboot). The dashboard will display "1 down, 2 out", which is obviously incorrect. It should be "1 down, 3 out"

Fixes: https://tracker.ceph.com/issues/51376
Signed-off-by: 胡玮文 <huww98@outlook.com>
(cherry picked from commit 921b48234777eba1a15c126f964cc47c0932879a)

4 years agoMerge pull request #42142 from rhcs-dashboard/wip-51474-octopus
Ernesto Puerta [Fri, 2 Jul 2021 09:15:22 +0000 (11:15 +0200)]
Merge pull request #42142 from rhcs-dashboard/wip-51474-octopus

octopus: mgr/dashboard: User database migration has been cut out

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #41584 from cfsnyder/wip-50895-octopus
Guillaume Abrioux [Fri, 2 Jul 2021 07:18:38 +0000 (09:18 +0200)]
Merge pull request #41584 from cfsnyder/wip-50895-octopus

octopus: ceph-volume: Consider /dev/root as mounted

4 years agoMerge pull request #41870 from cfsnyder/wip-51190-octopus
Yuri Weinstein [Thu, 1 Jul 2021 17:49:50 +0000 (10:49 -0700)]
Merge pull request #41870 from cfsnyder/wip-51190-octopus

octopus: mgr/telemetry: pass leaderboard flag even w/o ident

Reviewed-by: Sage Weil <sage@redhat.com>
4 years agoMerge pull request #41617 from cfsnyder/wip-50167-octopus
Yuri Weinstein [Thu, 1 Jul 2021 17:47:30 +0000 (10:47 -0700)]
Merge pull request #41617 from cfsnyder/wip-50167-octopus

octopus: mgr: do not load disabled modules

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #40948 from mgfritch/octopus-backport-39730-39822
Yuri Weinstein [Thu, 1 Jul 2021 17:46:42 +0000 (10:46 -0700)]
Merge pull request #40948 from mgfritch/octopus-backport-39730-39822

octopus: cephadm: fix escaping/quoting of stderr-prefix arg for ceph daemons

Reviewed-by: Adam King adking@redhat.com
4 years agomgr/dashboard: User database migration has been cut out 42142/head
Volker Theile [Wed, 30 Jun 2021 12:00:28 +0000 (14:00 +0200)]
mgr/dashboard: User database migration has been cut out

This PR will revert changes done by https://tracker.ceph.com/issues/49645 to auto-migrate user database v1 to v2.

Fixes: https://tracker.ceph.com/issues/51443
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 82922811612813840a684af993ca7c95a0b48d53)

4 years agomgr/dashboard: Detailed error messages in rgw bucket name validation 42123/head
Nizamudeen A [Sun, 25 Apr 2021 12:41:03 +0000 (18:11 +0530)]
mgr/dashboard: Detailed error messages in rgw bucket name validation

Explain the rgw bucket name constrains for each bucket name validation
errors.

Fixes: https://tracker.ceph.com/issues/50516
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit ab04e536684024c8d3613907d4bcd72fddf2ef20)

4 years agomgr/dashboard: RGW buckets async validator performance enhancement
Nizamudeen A [Sun, 25 Apr 2021 08:47:07 +0000 (14:17 +0530)]
mgr/dashboard: RGW buckets async validator performance enhancement

The rgw bucket creation form has the Name field which have an async
validator. The validator calls all the bucket name and check if the
entered name is unique or not. This happens on every keystroke. So if
100 or more buckets are there, then the async validation can be real
    slow and causes misvalidations in different fields.

I changed the validation logic and did some cleanups to improve the
performance of the async validation.

Fixes: https://tracker.ceph.com/issues/50514
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 005327c4e12fef8d7054894d9df021c0b3c53e19)

Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-form/rgw-bucket-form.component.ts
  -  Solved some import conflicts. Used the I18N import and removed the
     forkJoin import
src/pybind/mgr/dashboard/frontend/src/app/shared/api/rgw-bucket.service.spec.ts
  -  Dont need ${RgwHelper.DAEMON_QUERY_PARAM}
src/pybind/mgr/dashboard/frontend/src/app/shared/api/rgw-bucket.service.ts
  -  Removed enumerate function

4 years agoMerge pull request #41620 from cfsnyder/wip-50790-octopus
Yuri Weinstein [Wed, 30 Jun 2021 18:53:28 +0000 (11:53 -0700)]
Merge pull request #41620 from cfsnyder/wip-50790-octopus

octopus: osd: clear data digest when write_trunc

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #41568 from ideepika/wip-tracker-48142-octopus
Yuri Weinstein [Tue, 29 Jun 2021 15:09:17 +0000 (08:09 -0700)]
Merge pull request #41568 from ideepika/wip-tracker-48142-octopus

octopus: qa/cephadm/upgrade: use v15.2.9 for cephadm tests

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
4 years agoMerge pull request #41622 from cfsnyder/wip-50987-octopus
Yuri Weinstein [Mon, 28 Jun 2021 19:29:44 +0000 (12:29 -0700)]
Merge pull request #41622 from cfsnyder/wip-50987-octopus

octopus: crush/crush: ensure alignof(crush_work_bucket) is 1

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #41621 from cfsnyder/wip-50796-octopus
Yuri Weinstein [Mon, 28 Jun 2021 19:28:56 +0000 (12:28 -0700)]
Merge pull request #41621 from cfsnyder/wip-50796-octopus

octopus: mon: load stashed map before mkfs monmap

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #41613 from cfsnyder/wip-50940-octopus
Yuri Weinstein [Mon, 28 Jun 2021 19:27:24 +0000 (12:27 -0700)]
Merge pull request #41613 from cfsnyder/wip-50940-octopus

octopus: os/bluestore: introduce multithireading sync for bluestore's repairer

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #41612 from cfsnyder/wip-50781-octopus
Yuri Weinstein [Mon, 28 Jun 2021 19:26:19 +0000 (12:26 -0700)]
Merge pull request #41612 from cfsnyder/wip-50781-octopus

octopus: os/bluestore: tolerate zero length for allocators' init_[add/rm]_free()

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #40820 from ivancich/wip-50302-octopus
Yuri Weinstein [Mon, 28 Jun 2021 19:19:51 +0000 (12:19 -0700)]
Merge pull request #40820 from ivancich/wip-50302-octopus

octopus: rgw: radoslist incomplete multipart parts marker

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
4 years agoMerge pull request #41878 from ideepika/wip-51242-octopus
Deepika Upadhyay [Mon, 28 Jun 2021 18:10:35 +0000 (23:40 +0530)]
Merge pull request #41878 from ideepika/wip-51242-octopus

octopus: debian/control: ceph-mgr-modules-core does not Recommend ceph-mgr-rook

Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #41922 from ideepika/wip-51269-octopus
Deepika Upadhyay [Mon, 28 Jun 2021 17:49:55 +0000 (23:19 +0530)]
Merge pull request #41922 from ideepika/wip-51269-octopus

octopus: qa/suites/rados/perf: pin to 18.04

4 years agoMerge pull request #41478 from ideepika/wip-remove-bionic
Yuri Weinstein [Mon, 28 Jun 2021 17:40:30 +0000 (10:40 -0700)]
Merge pull request #41478 from ideepika/wip-remove-bionic

octopus: qa/distros: move to latest version on supported distro's

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
4 years agoqa/tasks/cephadm: include first mgr host when applying mgrs 41478/head
Josh Durgin [Wed, 23 Dec 2020 00:25:48 +0000 (19:25 -0500)]
qa/tasks/cephadm: include first mgr host when applying mgrs

This prevents the first mgr from being shut down due to lack of
appropriate placements.

trivial fix: removed octopus upgrade configs.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
(cherry picked from commit c79fa6d780580f99b62117e54326a4ef4b7adfef)

4 years agoqa/upgrade: replace ubuntu_latest to ubuntu_18.04
Deepika Upadhyay [Wed, 16 Jun 2021 20:42:12 +0000 (02:12 +0530)]
qa/upgrade: replace ubuntu_latest to ubuntu_18.04

since mimic and nautilus does not support focal builds, keep using
ubuntu_18.

octopus only, since master and pacific support focal

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoqa/distros/supported-random-distro$: keep support for bionic
Deepika Upadhyay [Wed, 26 May 2021 14:29:58 +0000 (19:59 +0530)]
qa/distros/supported-random-distro$: keep support for bionic

we still want to keep supporting 18.04 LTS for octopus, don't want to
use it for cephadm, since podman dropped support for bionic.

this is octopus only commit, since it's octopus specific support and we
dropped bionic in master.

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoqa/workunits/rbd: disable qemu-iotest test 055 globally 42025/head
Ilya Dryomov [Sun, 2 May 2021 21:13:29 +0000 (23:13 +0200)]
qa/workunits/rbd: disable qemu-iotest test 055 globally

It doesn't work on Focal and already disabled on CentOS 7 and 8.  More
importantly, it doesn't actually test rbd -- it always tests "file", no
matter which protocol is specified in IMGPROTO.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 602db5e386b4acb4f827866bf3789629aacf8307)

4 years agoqa/workunits/rbd: use bionic version of qemu-iotests for focal
Ilya Dryomov [Sun, 2 May 2021 21:13:29 +0000 (23:13 +0200)]
qa/workunits/rbd: use bionic version of qemu-iotests for focal

Currently Focal ends up with v2.2.0-rc3, which results in "WARNING:
Image format was not specified for ..." for all tests and all tests
fail.

Fixes: https://tracker.ceph.com/issues/50605
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 2de2146c300c9f1b49944ffe13cc249a95bca19a)

4 years agoMerge pull request #41618 from cfsnyder/wip-50990-octopus
Kefu Chai [Fri, 25 Jun 2021 06:47:59 +0000 (14:47 +0800)]
Merge pull request #41618 from cfsnyder/wip-50990-octopus

octopus: mon/OSDMonitor: drop stale failure_info even if can_mark_down()

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agoMerge pull request #41619 from cfsnyder/wip-50383-octopus
Kefu Chai [Fri, 25 Jun 2021 06:46:52 +0000 (14:46 +0800)]
Merge pull request #41619 from cfsnyder/wip-50383-octopus

octopus: test: bump DecayCounter.steady acceptable error

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
4 years agomgr/dashboard: fix for right sidebar nav icon not clickable 42015/head
Aaryan Porwal [Wed, 26 May 2021 08:58:15 +0000 (14:28 +0530)]
mgr/dashboard: fix for right sidebar nav icon not clickable

fixed the responsive sidebar not opening on click event, and close sidebar on clicking tasks and notification list item because it'll be over shadowed by the sidebar
Signed-off-by: Aaryan Porwal <aaryanporwal2233@gmail.com>
(cherry picked from commit 4e53a139d96215477d00eb709c1662d8277cba1d)

 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
      - Adopt the master branch changes.

4 years agomds: avoid journaling overhead for ceph.dir.subvolume for no-op case 41996/head
Patrick Donnelly [Fri, 18 Jun 2021 16:27:54 +0000 (09:27 -0700)]
mds: avoid journaling overhead for ceph.dir.subvolume for no-op case

In preparation for acquiring the xlock on the directory inode, the MDS
must journal a few events before continuing on with the setvxattr. This
can cause significant delays in the volumes ceph-mgr module which needs
to regularly enable this vxattr from multiple code paths. We could cache
in that module whether the vxattr is set but it's also pretty easy to
adjust the MDS to acquire a rdlock on the directory to check if the
subvolume flag is already set. That is much lighter weight and the lock
is generally readily available.

Fixes: https://tracker.ceph.com/issues/51276
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit b5f736eee408c220ffdfb67b10667a7b553dac25)

4 years agoMerge pull request #41764 from cfsnyder/wip-51093-octopus
Yuri Weinstein [Wed, 23 Jun 2021 18:17:30 +0000 (11:17 -0700)]
Merge pull request #41764 from cfsnyder/wip-51093-octopus

octopus: mgr/DaemonServer.cc: prevent mgr crashes caused by integer underflow that is triggered by large increases to pg_num/pgp_num

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #41586 from cfsnyder/wip-50661-octopus
Yuri Weinstein [Wed, 23 Jun 2021 18:10:56 +0000 (11:10 -0700)]
Merge pull request #41586 from cfsnyder/wip-50661-octopus

octopus: ceph: ignore BrokenPipeError when printing help

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #41658 from neha-ojha/wip-51041-octopus
Yuri Weinstein [Tue, 22 Jun 2021 17:22:34 +0000 (10:22 -0700)]
Merge pull request #41658 from neha-ojha/wip-51041-octopus

octopus:  os/bluestore: fix unexpected ENOSPC in Avl/Hybrid allocators.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
4 years agoMerge pull request #41623 from cfsnyder/wip-50705-octopus
Yuri Weinstein [Tue, 22 Jun 2021 17:21:45 +0000 (10:21 -0700)]
Merge pull request #41623 from cfsnyder/wip-50705-octopus

octopus: osd/PG.cc: handle removal of pgmeta object

Reviewed-by: Neha Ojha <nojha@redhat.com>
4 years agoMerge pull request #41609 from dvanders/dvanders_40572_octopus
Yuri Weinstein [Tue, 22 Jun 2021 17:20:47 +0000 (10:20 -0700)]
Merge pull request #41609 from dvanders/dvanders_40572_octopus

octopus: osd/PeeringState: fix acting_set_writeable min_size check

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
4 years agoMerge pull request #41602 from p-se/backport-octopus-port-in-use
Yuri Weinstein [Tue, 22 Jun 2021 17:19:24 +0000 (10:19 -0700)]
Merge pull request #41602 from p-se/backport-octopus-port-in-use

octopus: cephadm: fix port_in_use when IPv6 is disabled

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
4 years agoqa/workunits/cephadm/test_repos: adjust target version
Sage Weil [Sun, 24 Jan 2021 00:56:42 +0000 (18:56 -0600)]
qa/workunits/cephadm/test_repos: adjust target version

15.2.7 is available for 20.04; 15.1.1 is not

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 7fe3853af97120fc97406f5b8123bbaa4adc9c6e)

4 years agorados/cephadm/qa/distros: update to latest distros
Deepika Upadhyay [Wed, 26 May 2021 09:11:55 +0000 (14:41 +0530)]
rados/cephadm/qa/distros: update to latest distros

- removes ubuntu_18.04 support for podman, instead we move to focal.
- use rhel_8.3 for all rhel_8 references
- use {centos/rhel}_8 instead of {rhel/centos}_latest: to keep things
  same in master and octopus since we use: rhel_8 and centos_8 as latest
  version symlinks, which differentiated after an octopus only commit.

this was not cherry picked from master as octopus had some of the
symlinks, not in sync with master, this commit does cleanup for them,
and tries to make them similar to master.

(updates introduced change by: 126217febf023a6f561fe88dbdb87b5b2f379798)
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoqa/distros/podman: preserve registries.conf
Sage Weil [Mon, 5 Apr 2021 18:49:18 +0000 (13:49 -0500)]
qa/distros/podman: preserve registries.conf

Otherwise we'll lose the mirror configuration.

trivial-fix:

specify location for container registry since we use sepia labs as our
container registery, which otherwise can't find registries.conf

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 917a9c49e55ab107c1e5b1d035398344bcd33858)

4 years agoqa: new kubic distro files; use kubic podman for centos/rhel
Sage Weil [Wed, 3 Mar 2021 14:14:29 +0000 (08:14 -0600)]
qa: new kubic distro files; use kubic podman for centos/rhel

The current centos/rhel version of podman (2.2.1) is broken.

- create new qa/distros/podman/* files that install kubic podman
- include centos/rhel variants
- adjust cephadm jobs to use new yaml files
- remove old qa/distros/all/*_podman.yaml files

trivial fix: we do not have cephadm/thrash suite in octopus(removed)
- distro(from octopus) renamed to 0-distro(from pacific)

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 11beb7287084b56ac7cbd45ac3d28b3d9fa4cc5b)

4 years agoqa/suites/rados/cephadm: add back centos+rhel with kubic podman
Sage Weil [Thu, 11 Mar 2021 19:46:23 +0000 (13:46 -0600)]
qa/suites/rados/cephadm: add back centos+rhel with kubic podman

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit dbdd4d46e35d2fcf80a1b2cd9da77b6832c45aa3)

4 years agoqa/suites/rados/cephadm: add 20.04 target
Sage Weil [Sat, 23 Jan 2021 17:23:13 +0000 (11:23 -0600)]
qa/suites/rados/cephadm: add 20.04 target

Link directly to the distro version... no need to use _latest here since
it obscures the podman vs docker difference.

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 170dd14af4f72bdac2a43742d11fa194c84819f5)

4 years agoqa/tests: replaced ubuntu_latest.yaml with ubuntu 20.04
Kefu Chai [Mon, 29 Mar 2021 16:06:16 +0000 (00:06 +0800)]
qa/tests: replaced ubuntu_latest.yaml with ubuntu 20.04

resurrect 835f2f5f511e7363f4056e5137382982aac1bfbf, which was reverted by
1f885b6c2fdde1f3ab249a56f7b4b763556f4373

so all tests for `pacific` will be tested on the latest ubuntu version

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 55564dbd01e6020a40d9a18d080aa7b1b9f86d5e)

4 years agoqa/distros: add centos 8.3
Patrick Donnelly [Fri, 5 Mar 2021 21:11:30 +0000 (13:11 -0800)]
qa/distros: add centos 8.3

trivial fix: adding centos_8 symlink

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 74f04aa9e12bbe195506fe28d2a0d4e3d4ff200d)

4 years agoqa/distros: add ubuntu 20.04 targets
Sage Weil [Sat, 23 Jan 2021 17:20:52 +0000 (11:20 -0600)]
qa/distros: add ubuntu 20.04 targets

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 24c2d2b1244d95c232f927dad1417717a2768ece)

4 years agoqa/distros: add RHEL 8.3 and use RHEL 8.3 as default
rakeshgm [Tue, 17 Nov 2020 13:14:16 +0000 (18:44 +0530)]
qa/distros: add RHEL 8.3 and use RHEL 8.3 as default

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
(cherry picked from commit 5eabe906e6d15dec48224fd29b45e1155e751314)

4 years agoqa/distros: centos7 -> centos8, rhel7 -> rhel8
Sage Weil [Tue, 10 Dec 2019 13:45:06 +0000 (07:45 -0600)]
qa/distros: centos7 -> centos8, rhel7 -> rhel8

trivial fix: removing skipping log warning needed for previous versions

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 1eb8198d0b25be38eae707fc79e8d13d2a3a9788)

4 years agomgr/dashboard: show partially deleted RBDs 41887/head
Tatjana Dehler [Thu, 27 May 2021 09:46:50 +0000 (11:46 +0200)]
mgr/dashboard: show partially deleted RBDs

An RBD might be partially deleted if the deletion
process has been started but was interrupted. In
this case return the RBD as part of the RBD list
and mark it as partially deleted.

Fixes: https://tracker.ceph.com/issues/48603
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit d83c277ac1861df31d2a39d16e20c7bebbea676e)

Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-details/rbd-details.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-list/rbd-list.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-list/rbd-list.component.ts
src/pybind/mgr/dashboard/services/rbd.py
src/pybind/mgr/dashboard/tests/test_rbd_service.py
Resolved various conflicts because octopus and
master diverged a lot.

4 years agoqa/suites/perf-basic: pin to 18.04 41922/head
Neha Ojha [Wed, 3 Feb 2021 18:57:50 +0000 (18:57 +0000)]
qa/suites/perf-basic: pin to 18.04

This will have same problems as https://tracker.ceph.com/issues/49139

trivial fix: removed ubuntu_latest having bionic as entry.

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit e5895dd8012f646ae9d67b9d1b331e7c06fe89d3)

4 years agoqa/suites/rados/perf: pin to 18.04
Neha Ojha [Wed, 3 Feb 2021 17:29:59 +0000 (17:29 +0000)]
qa/suites/rados/perf: pin to 18.04

Caused by a07ca4c5c0f04c43c71231a898c2a89e99a80606

Fixes: https://tracker.ceph.com/issues/49139
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 6a03b4cec9be39b2c3217e5f28372e1db3999781)

4 years agoMerge pull request #41087 from smithfarm/wip-50357-octopus
Nathan Cutler [Wed, 16 Jun 2021 20:20:01 +0000 (22:20 +0200)]
Merge pull request #41087 from smithfarm/wip-50357-octopus

octopus: make-dist: refuse to run if script path contains a colon

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agomds: make the lost+found dir accessible from clients 40782/head
Xiubo Li [Mon, 19 Apr 2021 02:34:02 +0000 (10:34 +0800)]
mds: make the lost+found dir accessible from clients

Inode number 0x4 is reserved for the lost+found dir, and the apps
or recovery apps need to access it.

At the same time the 0x3 is reserved for the global snaprealm, which
will also be lookup by the clients when looking up the snaprealm inodes.

Here will make all the inode less than 100 accessible by clients.

Fixes: https://tracker.ceph.com/issues/50216
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 841071b3602aa2b8bcca57b95cdf671d48036a34)

Conflicts:
src/mds/Server.cc
- most of the master commit was already backported via
  c5362b8464bdafbea7556acdee9e877b71ed4f8d
  This backports just one small part that was missed in that commit.

4 years agomds: reject lookup ino requests for mds dirs
Patrick Donnelly [Wed, 24 Mar 2021 20:54:17 +0000 (13:54 -0700)]
mds: reject lookup ino requests for mds dirs

Fixes: https://tracker.ceph.com/issues/49922
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 682a55e8a22a137f80855f2cdd98f6f230d67fce)

Conflicts:
        src/mds/Server.cc
- octopus wants ESTALE instead of CEPHFS_ESTALE
- octopus wants CEPH_INO_ROOT instead of MDS_INO_ROOT

4 years agotest: add test for invalid lookup of mdsdir
Patrick Donnelly [Wed, 24 Mar 2021 21:09:57 +0000 (14:09 -0700)]
test: add test for invalid lookup of mdsdir

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 4778308eb9149594cb31519a5ff77413d6ec1fab)

Conflicts:
src/test/libcephfs/test.cc
- some adjoining code that doesn't exist in octopus

4 years agodebian/control: ceph-mgr-modules-core does not Recommend ceph-mgr-rook anymore 41878/head
Kefu Chai [Fri, 4 Jun 2021 03:25:12 +0000 (11:25 +0800)]
debian/control: ceph-mgr-modules-core does not Recommend ceph-mgr-rook anymore

per https://www.debian.org/doc/debian-policy/ch-relationships.html

> Recommends
>   This declares a strong, but not absolute, dependency.
>
> The Recommends field should list packages that would be found together
> with this one in all but unusual installations.

ceph-mgr-modules-core provides a set of ceph-mgr modules which are
always enabeld. but the rook module enables ceph-mgr to install and
configure a Ceph cluster using Rook. this module is very useful but
it does not have such a strong connection with ceph-mgr-modules-core.
we can always install it separately for using better intergration with
Rook.

See-also: https://tracker.ceph.com/issues/45574
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 814fb28892370bef3337f90edccfd6f9c00bf350)

4 years agomgr/telemetry: pass leaderboard flag even w/o ident 41870/head
Sage Weil [Fri, 4 Jun 2021 17:49:40 +0000 (12:49 -0500)]
mgr/telemetry: pass leaderboard flag even w/o ident

Allow non-identified clusters to appear in the leaderboard.
The leaderboard option still defaults to false, so the change here
is that if they opt in to leaderboard but not ident we'll see
that on the backend.

Note that a leaderboard still does not exist (yet), so this doesn't
have any immediate impact.  But if/when we do create one, it will
allow us to show big clusters (that opt in) on the leaderboard
as 'unidentified' or similar.

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit d4a6c3d0099a1f005f41a2cbcfbdbfeddd468db6)

4 years agoqa/tasks/mgr: skip test_diskprediction_local on python>=3.8 41617/head
Kefu Chai [Wed, 7 Apr 2021 05:38:27 +0000 (13:38 +0800)]
qa/tasks/mgr: skip test_diskprediction_local on python>=3.8

query the python version before trying to test diskprediction_local

Fixes: https://tracker.ceph.com/issues/50196
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 39b2b5edc008900d531be95ece1ce75a1e036914)

Conflicts:
qa/tasks/mgr/test_module_selftest.py

4 years agomgr/selftest: add a command for querying python version
Kefu Chai [Wed, 7 Apr 2021 06:40:05 +0000 (14:40 +0800)]
mgr/selftest: add a command for querying python version

so the test driver can skip certain tests based on the version of python
runtime on the test node

Fixes: https://tracker.ceph.com/issues/50196
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 91bc0e54ab816fca12a08817c261bbbf65606726)

Conflicts:
src/pybind/mgr/selftest/module.py

4 years agoMerge pull request #41624 from cfsnyder/wip-50750-octopus
Yuri Weinstein [Tue, 15 Jun 2021 16:12:12 +0000 (09:12 -0700)]
Merge pull request #41624 from cfsnyder/wip-50750-octopus

octopus: doc/rados/operations: s/max_misplaced/target_max_misplaced_ratio/

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
4 years agoMerge pull request #41766 from cfsnyder/wip-50727-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:57:57 +0000 (07:57 -0700)]
Merge pull request #41766 from cfsnyder/wip-50727-octopus

octopus: rgw : add check empty for sync url

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #41765 from cfsnyder/wip-51079-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:57:31 +0000 (07:57 -0700)]
Merge pull request #41765 from cfsnyder/wip-51079-octopus

octopus: rgw: require bucket name in bucket chown

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #41420 from cfsnyder/wip-50677-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:57:05 +0000 (07:57 -0700)]
Merge pull request #41420 from cfsnyder/wip-50677-octopus

octopus: rgw: fix segfault related to explicit object manifest handling

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #41419 from cfsnyder/wip-50423-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:56:15 +0000 (07:56 -0700)]
Merge pull request #41419 from cfsnyder/wip-50423-octopus

octopus: rgw: send headers of quota settings

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #41418 from cfsnyder/wip-50380-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:55:38 +0000 (07:55 -0700)]
Merge pull request #41418 from cfsnyder/wip-50380-octopus

octopus: rgw/amqp/test: fix mock prototype for librabbitmq-0.11.0

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #41417 from cfsnyder/wip-50643-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:55:06 +0000 (07:55 -0700)]
Merge pull request #41417 from cfsnyder/wip-50643-octopus

octopus: rgw: allow rgw-orphan-list to process multiple data pools

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #41416 from cfsnyder/wip-50730-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:54:37 +0000 (07:54 -0700)]
Merge pull request #41416 from cfsnyder/wip-50730-octopus

octopus: rgw/rgw_file: Fix the return value of read() and readlink()

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #41415 from cfsnyder/wip-50640-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:54:08 +0000 (07:54 -0700)]
Merge pull request #41415 from cfsnyder/wip-50640-octopus

octopus: rgw/sts: read_obj_policy() consults iam_user_policies on ENOENT

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #41413 from cfsnyder/wip-50709-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:53:39 +0000 (07:53 -0700)]
Merge pull request #41413 from cfsnyder/wip-50709-octopus

octopus: rgw: fix bucket object listing when marker matches prefix

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #41412 from cfsnyder/wip-50464-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:52:56 +0000 (07:52 -0700)]
Merge pull request #41412 from cfsnyder/wip-50464-octopus

octopus: rgw/notifications: delete bucket notification object when empty

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 years agoMerge pull request #40768 from smithfarm/wip-49513-octopus
Yuri Weinstein [Tue, 15 Jun 2021 14:46:06 +0000 (07:46 -0700)]
Merge pull request #40768 from smithfarm/wip-49513-octopus

octopus: cephfs: client: add ability to lookup snapped inodes by inode number

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
4 years agoMerge pull request #41647 from rhcs-dashboard/wip-51065-octopus
Ernesto Puerta [Mon, 14 Jun 2021 08:29:50 +0000 (10:29 +0200)]
Merge pull request #41647 from rhcs-dashboard/wip-51065-octopus

octopus: mgr/dashboard: fix bucket objects and size calculations

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
4 years agoMerge pull request #41530 from rhcs-dashboard/wip-50884-octopus
Ernesto Puerta [Fri, 11 Jun 2021 18:01:02 +0000 (20:01 +0200)]
Merge pull request #41530 from rhcs-dashboard/wip-50884-octopus

octopus: mgr/dashboard: fix OSDs Host details/overview grafana graphs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: wornet-mwo <NOT@FOUND>
4 years agoMerge pull request #41508 from rhcs-dashboard/wip-50960-octopus
Ernesto Puerta [Fri, 11 Jun 2021 17:59:41 +0000 (19:59 +0200)]
Merge pull request #41508 from rhcs-dashboard/wip-50960-octopus

octopus: mgr/dashboard: fix API docs link

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
4 years agoMerge pull request #41199 from votdev/wip-50663-octopus
Ernesto Puerta [Fri, 11 Jun 2021 08:40:56 +0000 (10:40 +0200)]
Merge pull request #41199 from votdev/wip-50663-octopus

octopus: mgr/dashboard: disable NFSv3 support in dashboard

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: sebastian-philipp <NOT@FOUND>
Reviewed-by: Volker Theile <vtheile@suse.com>
4 years agoMerge pull request #41642 from idryomov/wip-rbd-qemu-precise-repos-octopus
Yuri Weinstein [Wed, 9 Jun 2021 18:45:55 +0000 (11:45 -0700)]
Merge pull request #41642 from idryomov/wip-rbd-qemu-precise-repos-octopus

octopus: qa/tasks/qemu: precise repos have been archived

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
4 years agoMerge pull request #41031 from trociny/wip-48424-octopus
Yuri Weinstein [Wed, 9 Jun 2021 16:24:25 +0000 (09:24 -0700)]
Merge pull request #41031 from trociny/wip-48424-octopus

octopus: rgw: check object locks in multi-object delete

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
4 years agotest/cls_rgw: make bi_list test not rely on osd_max_omap_entries_per_request 41775/head
Mykola Golub [Thu, 6 May 2021 16:45:52 +0000 (17:45 +0100)]
test/cls_rgw: make bi_list test not rely on osd_max_omap_entries_per_request

Signed-off-by: Mykola Golub <mgolub@suse.com>
(cherry picked from commit d02d91f6f20a3431fd758a67a0bf77ea4bd4d883)

4 years agotest/cls_rgw: test bi_list for objects with non-ascii names
Mykola Golub [Wed, 28 Apr 2021 06:17:09 +0000 (07:17 +0100)]
test/cls_rgw: test bi_list for objects with non-ascii names

Signed-off-by: Mykola Golub <mgolub@suse.com>
(cherry picked from commit 878d9510b4c9c0cc944740642e3342fdcb341936)

4 years agocls/rgw: look for plane entries in non-ascii plain namespace too
Mykola Golub [Thu, 22 Apr 2021 06:14:25 +0000 (07:14 +0100)]
cls/rgw: look for plane entries in non-ascii plain namespace too

Fixes: https://tracker.ceph.com/issues/50415
Signed-off-by: Mykola Golub <mgolub@suse.com>
(cherry picked from commit 7cf30e943276ff66f0eff9f0c088c597b1f9e066)

Conflicts:
src/cls/rgw/cls_rgw.cc (trivial)

4 years agomds: reset code after cpu_profiler 41767/head
liu shi [Fri, 14 May 2021 07:52:27 +0000 (03:52 -0400)]
mds: reset code after cpu_profiler

Signed-off-by: liu shi <liu.shi@navercorp.com>
(cherry picked from commit f1afb7b1b8d1b4873730e1b88a552213e4c51977)

4 years agocpu_profiler: fix asok command crash
liu shi [Fri, 14 May 2021 07:51:01 +0000 (03:51 -0400)]
cpu_profiler: fix asok command crash

fixes: https://tracker.ceph.com/issues/50814
Signed-off-by: liu shi <liu.shi@navercorp.com>
(cherry picked from commit be7303aafe34ae470d2fd74440c3a8d51fcfa3ff)

4 years agorgw : add check empty for sync url 41766/head
cao.leilc [Fri, 2 Apr 2021 03:55:54 +0000 (11:55 +0800)]
rgw : add check empty for sync url

Fixes: https://tracker.ceph.com/issues/50103
Signed-off-by: caolei <halei15848934852@163.com>
(cherry picked from commit 3a4e0b79310b21eeee37043d5419887bb41c0cf6)

4 years agorgw: require bucket name in bucket chown 41765/head
Zulai Wang [Thu, 3 Jun 2021 05:13:15 +0000 (13:13 +0800)]
rgw: require bucket name in bucket chown

Checking and reporting missing the mandatory parameter avoid clueless error
message for bucket chown.

Signed-off-by: Zulai Wang <zl31wang@gmail.com>
(cherry picked from commit 158a1f4313c0fa206031ede6f48a26c0c7467d57)

4 years agomgr/DaemonServer.cc: prevent integer underflow that is triggered by large increases... 41764/head
Cory Snyder [Fri, 28 May 2021 19:08:49 +0000 (15:08 -0400)]
mgr/DaemonServer.cc: prevent integer underflow that is triggered by large increases to pg_num/pgp_num

This fixes a scenario where mgrs continually crash while attempting to apply large increases to pg_num/pgp_num. The max step size (estmax) for each incremental update to the pgp_num is calculated as a percentage of the pg_num, which permits the possibility for the max step size (estmax) to be greater than the current pgp_num when the increase is large; this causes an integer underflow when the max step size is subtracted from the pgp_num in order to calculate the next step size with std::clamp. The integer underflow causes hi < lo in args passed to std::clamp, which causes a failed assertion, SIGABRT, and ultimately crashing mgr.

Fixes: https://tracker.ceph.com/issues/47738
Signed-off-by: Cory Snyder <csnyder@iland.com>
(cherry picked from commit b4316d257e928b3789b818054927c2e98bb3c0d6)

4 years agoos/bluestore: strip trailing slash for directory listings 41757/head
Jonas Jelten [Mon, 15 Mar 2021 22:21:07 +0000 (23:21 +0100)]
os/bluestore: strip trailing slash for directory listings

Calls to BlueRocksEnv::GetChildren may contain a trailing / in the
queried directory, which is stripped away with this patch.

If it's not stripped, the directory entry is not found in BlueFS:
```
10 bluefs readdir db/
20 bluefs readdir dir db/ not found
 3 rocksdb: [db/db_impl/db_impl_open.cc:1785] Persisting Option File error: OK
```

Fixes: https://tracker.ceph.com/issues/49815
Signed-off-by: Jonas Jelten <jj@sft.lol>
(cherry picked from commit 3aa31813980d22719277a04797df48310acdff66)

4 years agoos/bluestore: let split() return string_view
Kefu Chai [Tue, 16 Mar 2021 02:42:43 +0000 (10:42 +0800)]
os/bluestore: let split() return string_view

instead of creating two strings, just return string_views, for better
performance. and for better readability.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit afc2c61a3ac6904f3c5ca0cede053cb4920baf90)