script/run-make.sh: retry if dpkg was interrupted

there is chance that apt-get is interrupted in the middle when a new PR
cancels the running jenkins job, the next job running apt-get or dpkg
would run into issues like:

E: dpkg was interrupted, you must manually run 'sudo dpkg --configure -a' to correct the problem.
Build step 'Execute shell' marked build as failure

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42715 from tchaikov/wip-crimson-tls-int-cond

crimson/common: instantiate interrupt_cond in .cc

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #42662 from trociny/wip-52063

rbd-mirror: fix potential async op tracker leak in start_image_replayers

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #42708 from cbodley/wip-rgw-meta-sync-behind-after-trim

radosgw-admin: 'sync status' is not behind if there are no mdlog entries

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

crimson: build without "using namespace std"

* add "std::" prefix in headers
* add "using" declarations in .cc files.

so we don't reply on "using namespace std" in one or more included
headers.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42611 from s0nea/wip-doc-transifex-resource

doc/dev: Dashboard translations release update

Reviewed-by: aaryanporwal <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

crimson/common: instantiate interrupt_cond in .cc

so we can explicitly instantiate it.

this should address the segfault when accessing interrupt_cond when
it is defined as a plain thread local storage template variable in the
header file.

it seems Clang is not able to identify the access to TLS variable and
the value of %fs segment register of the main thread is always zero if
interrupt_cond is defined as a plain global variable stored in
thread local storage.

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/crimson: drop copy assignment operator

because of the const reference member variable of `parent`:

const delta_overlay_t &parent;

we are not allowed to mutate it. so the explicitly defaulted copy assignment
operator is implicitly deleted

this change silences the warnings from Clang like:

 ../src/test/crimson/seastore/test_transaction_manager.cc:159:12: warning: explicitly defaulted copy assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
         iterator &operator=(const iterator &) = default;
                   ^
 ../src/test/crimson/seastore/test_transaction_manager.cc:98:25: note: copy assignment operator of 'iterator' is implicitly deleted because field 'parent' is of reference type 'const transaction_manager_$
         const delta_overlay_t &parent;
                                ^

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42711 from tchaikov/wip-seastar

seastar: pick up change adding ioctl and fcntl support

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

seastar: pick up change adding ioctl and fcntl support

prepare for the better support of ZNS.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42668 from tchaikov/wip-doc-ci

doc/dev/continuous-integration: document chacra

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

doc/dev/continuous-integration: document chacra

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42149 from hualongfeng/fix_sync_point

librbd/cache/pwl: avoid stack overflow caused by nested shared_ptr destruction

Reviewed-by: Jianpeng Ma <jianpeng.ma@intel.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

radosgw-admin: 'sync status' is not behind if there are no mdlog entries

if remote mdlogs are trimmed prematurely, sync status will report
that it's behind the remote's max-marker even if there are no mdlog
entries to sync

for each behind shard, we fetch the next mdlog entry from the remote. if
we get an empty listing, remove that shard from behind_shards. this
logic now has to run before we print "behind shards:" so that empty
shards aren't listed

Fixes: https://tracker.ceph.com/issues/52091
Signed-off-by: Casey Bodley <cbodley@redhat.com>

librbd/cache/pwl: avoid stack overflow caused by nested shared_ptr destruction

Destruction of nested shared_ptr will cause stack overflow.
With the explicit assignment of nullptr, the deleted node
is completely disconnected from the current linked list

-------              *******               -------
|sync | <--earlier-- |sync | <--earlier-x- |sync |
|point| --later----> |point| --later----x> |point|
-------              *******               -------
   |                    |                     |
   V                    V                     V
-------              -------               -------
|log_ | ---next----> |log_ | ---next----x> |log_ |
|entry|              |entry|               |entry|
-------              -------               -------

earlier: earlier_sync_point
later:   later_sync_point
next:    next_sync_point_entry

Fixes: https://tracker.ceph.com/issues/51418
Signed-off-by: Feng Hualong <hualong.feng@intel.com>

Merge pull request #42705 from tchaikov/wip-clang-fixes

crimson, test/crimson, msg: clang fixes

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #42660 from zdover23/wip-doc-2021-08-04rados-config-storage-devices-filestore

doc/rados: rewrite "FileStore" section

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

crimson/os/seastore: do not capture unused variable

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/crimson/seastore: drop duplicated i++

for two reasons:

* to silence Clang warning
* it's very unusual to do this. and this is a bad smell.

Signed-off-by: Kefu Chai <kchai@redhat.com>

test/crimson/seastore: capture labels by defining new variables

structured binding does not define variables, so we have to define
variables in capture list for capturing them.

Signed-off-by: Kefu Chai <kchai@redhat.com>

msg/async/compression_onwire: include used header

this fixes the FTBFS with Clang + libc++.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42700 from tchaikov/wip-crimson-cleanup

crimson/os/seastore: do not capture unused variable

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #36517 from giladmaya/on_wire_compression

msgr: added support in on-wire compression for osd-osd communication

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #42686 from dsavineau/cephadm_almalinux_distro

cephadm: add AlmaLinux to supported distro

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #42608 from joscollin/wip-B51975-keyerror-null-foo

pybind/mgr/stats: validate cmdtag

Reviewed-by: Venky Shankar <vshankar@redhat.com>

test/crimson: mark final class "final"

silences warning from Clang like:

../src/test/crimson/seastore/test_object_data_handler.cc:33:16: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
  ~TestOnode() final = default;
               ^
../src/test/crimson/seastore/test_object_data_handler.cc:20:7: note: mark 'TestOnode' as 'final' to silence this warning
class TestOnode : public Onode {
      ^
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>

crimson/os/seastore: do not capture unused variable

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42698 from tchaikov/wip-cmake-attr

cmake: fail on unknown attribute

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>

Merge pull request #42607 from tchaikov/wip-ceph-dencoder

tools/ceph-dencoder: refactor to address segfault when compiled w/ clang

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

cmake: fail on unknown attribute

on Clang, the option for detecting unknown attribute is
-Wunknown-attributes, so "-Wattributes -Werror" does not fail the test
when the C compiler is Clang.

in this change, we just turn all warnings into errors.
this should fail the test if the compiler does not understand
`__attribute__((__symver__ ...))`

Fixes: https://tracker.ceph.com/issues/40060
Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42602 from b-ranto/wip-lto

rados+rpm: Update symver defs and re-enable LTO

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42564 from myoungwon/wip-fix-45423

test: fix wrong alarm (HitSetWrite)

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #42277 from tchaikov/wip-vstart-runner-cleanups

qa/tasks/vstart_runner: do not send SIGTERM if no matched pid

Reviewed-by: Rishabh Dave <ridave@redhat.com>

Merge pull request #42663 from cyx1231st/wip-fix-lba-empty-delta

crimson/os/seastore/lba_manager: remove assert non-empty delta

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>

Merge pull request #42669 from tchaikov/wip-doc-ext-confval

doc/_ext: print out the module which fails the build

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #42681 from tchaikov/wip-fmt-a

cmake: link bundled fmt statically

Reviewed-by: Boris Ranto <branto@redhat.com>

Merge pull request #42593 from ceph/wip-yuriw-release-15.2.14-master

doc: 15.2.14 Release Notes

doc/releases/octopus.rst: add notable changes for mgr and core

Signed-off-by: Neha Ojha <nojha@redhat.com>

doc: add note about mon trimming of old MDSMaps

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

doc: 15.2.14 Release Notes

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #42505 from wzbxqt327/put_obj_rentention

rgw: add the condition of lock mode conversion to PutObjRentention

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #42531 from ivancich/wip-user-utilized-stats

rgw: user stats showing 0 value for "size_utilized" and "size_kb_utilized" fields

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #42597 from ivancich/wip-rename-f

rgw: clean up some code

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #42125 from ivancich/wip-cls-empty-listing

rgw: resolve empty ordered bucket listing results w/ CLS filtering

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #42182 from tengfWang/rgw-swift-check-container-name

rgw: remove the three-character limit when creating a container with swift interface

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #42397 from mkogan1/rgw-d3n-rem-ops-log

rgw: d3n: remove legacy requirement to enable rgw_enable_ops_log

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

cephadm: add AlmaLinux to supported distro

AlmaLinux [1] is an open-source 1:1 binary compatible fork of RHEL.

[1] https://almalinux.org/

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>

Merge pull request #42673 from guits/update_cephadm_doc

doc/cephadm: update documentation

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42664 from sebastian-philipp/cephadm-FakePipeWrapper

cephadm: fix unit tests

Reviewed-by: Sage Weil <sage@newdream.net>

Merge pull request #42665 from sebastian-philipp/cephadm-doc-upgrade-offline

doc/cephadm: Offline hosts will pause upgrades

Reviewed-by: Sage Weil <sage@newdream.net>

cmake: link bundled fmt statically

instead of building the bundled fmt library as shared library, built
static library. otherwise we'd have to link against libfmt.so.

Signed-off-by: Kefu Chai <kchai@redhat.com>

librados/librados_c: check for both symvers

We should check if either asm symver or attribute symver is defined and
not assume that attribute symver implies asm symver.

Fixes: https://tracker.ceph.com/issues/40060
Signed-off-by: Boris Ranto <branto@redhat.com>

cmake: Check -flto flags

We should check if -flto-partition=none is defined when the compiler
does not support symver attribute and fail the build if it is not.

Fixes: https://tracker.ceph.com/issues/40060
Co-authored-by: Kefu Chai <tchaikov@gmail.com>
Signed-off-by: Boris Ranto <branto@redhat.com>

librados/librados_c: Use symver attribute if available

Fixes: https://tracker.ceph.com/issues/40060
Signed-off-by: Boris Ranto <branto@redhat.com>

rpm: Re-enable LTO on supported systems

We can now use LTO when building ceph. The symver issue was fixed by
using the gcc __symver__ attribute. The systems that support it can now
re-enable LTO.

Fixes: https://tracker.ceph.com/issues/40060
Signed-off-by: Boris Ranto <branto@redhat.com>

pybind/mgr/stats: check if cmdtag is a valid key in client_metadata

Invalid cmdtag values ('', foo) are found in random testing and in the
qa runs. So check if cmdtag is a valid key in client_metadata.

Fixes: https://tracker.ceph.com/issues/51975
Signed-off-by: Jos Collin <jcollin@redhat.com>

doc/cephadm: update documentation

This commit fixes a couple of typos in the cephadm documentation.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

doc/_ext: print out the module which fails the build

Signed-off-by: Kefu Chai <kchai@redhat.com>

rados: Update symver defs

The gcc compiler now supports symver attribute. We should update the
symvers to be able to support LTO.

Fixes: https://tracker.ceph.com/issues/40060
Signed-off-by: Boris Ranto <branto@redhat.com>

rados: Fix function ordering

The build fails because the function definitions are out of order. This
also reuses the LIBRADOS_C_API_DEFAULT_F macro for function definitions.

Fixes: https://tracker.ceph.com/issues/40060
Signed-off-by: Boris Ranto <branto@redhat.com>

doc/cephadm: Offline hosts will pause upgrades

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

cephadm: fix unit tests.

Fixes AttributeError: 'FakePipeWrapper' object has no attribute 'readable'

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #42242 from sebastian-philipp/cephadm-container-name-dashes

cephadm: use dashes for container names

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>

crimson/os/seastore/lba_manager: remove assert non-empty delta

Delta can be empty when measure the effort of invalidated transactions.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #42462 from sebastian-philipp/mon-ip-change

doc/cephadm: Move MONs to a different network

Reviewed-by: Michael Fritch <mfritch@suse.com>

rbd-mirror: fix potential async op tracker leak in start_image_replayers

Fixes: https://tracker.ceph.com/issues/52063
Signed-off-by: Mykola Golub <mgolub@suse.com>

doc/rados: rewrite "FileStore" section

This PR makes minor improvements to the
syntax of the sentences in the "FileStore"
material in the Configuration chapter of
the RADOS manual.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

Merge pull request #42619 from jdurgin/wip-release-notes-script

script/ceph-release-notes: improve output for markdown and limit verbosity

Reviewed-by: David Galloway <dgallowa@redhat.com>

script/ceph-release-notes: don't include PR body by default, just the title

This avoids overly long output for merges involving lots of PRs,
e.g. cephadm batch backports.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>

script/ceph-release-notes: infer actual title from ptl-tool merges

This helps the notes stay accurate when the commit title has changed,
but the PR title is out of date.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #42636 from zdover23/wip-doc-rados-config-storage-devices-bluestore-2021-08-03

doc/rados: rewrite BlueStore material

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #41897 from ivancich/wip-versioned-deletes

rgw: when deleted obj removed in versioned bucket, extra del-marker added

Reviewed-by: Casey Bodley <cbodley@redhat.com>

cephadm: Introduce unit.stop

Reason is we now have to stop two containers named differently. This is possible
with `bash -c ... echo %i | tr . -`. But we're not gainig anything readability
compared to putting it into a unit.stop script.

As not all daemons have this stop script, we still have to call podman for old daemons.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

cephadm: don't log on exit.

At this point, the garbage collector already colleceted the `open` function

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

cephadm: `stats` might return `--` for containers

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

cephadm: exec: also search for old cname

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

cephadm: dashes: use both cnames for `inspect`

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

cephadm: Add CephContainer.for_daemon()

To avoid calling get_container()

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

cephadm: use dashes for container names

podman adds the current container name to the /etc/hosts
file. Turns out, python's `socket.getfqdn()` differs from
`hostname -f`, when we have the container names containing
dots in it.:

[root@sebastians-laptop /]# cat /etc/hosts
127.0.0.1   localhost
::1         localhost
127.0.1.1   sebastians-laptop foo.bar.baz.com
[root@sebastians-laptop /]# hostname -f
sebastians-laptop
[root@sebastians-laptop /]# python3 -c 'import socket; print(socket.getfqdn())'
foo.bar.baz.com

Fascinatingly, this doesn't happen when using dashes.

Fixes: https://tracker.ceph.com/issues/51590
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #42395 from sebastian-philipp/cephadm-improve-no-enigne-msg

cephadm: Clarify no container engine message

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/cephadm: MON IP change

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #42587 from liewegas/rgw-mon-secure

rgw: default ms_mon_client_mode = secure

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #42610 from rhcs-dashboard/52022-fix-rgw-perf-counters

mgr/dashboard: show perf. counters for rgw svc. on Cluster > Hosts

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #42554 from rhcs-dashboard/fix-rgw-ssl-cert-validation

mgr/dashboard: fix ssl cert validation for rgw service creation

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #42575 from tchaikov/wip-venv

*: s/virtualenv/python -m venv/

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #42594 from sebastian-philipp/mypy-ini-disallow-untyped-root

mypy.ini: Globally enable `disallow_untyped_defs = True`

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42571 from tchaikov/wip-disable-kvs

cmake: disable kvs rados cls by default

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #42614 from soumyakoduri/wip-skoduri-sqlite3

cmake: Remove duplicate SQLITE module

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

mgr/dashboard: show perf. counters for rgw svc. on Cluster > Hosts

- Use service_map_id to retrieve perf. counters for rgw services.
- Move logic from controller to CephService.

Fixes: https://tracker.ceph.com/issues/52022
Signed-off-by: Alfonso Martínez <almartin@redhat.com>

rgw: allow ordered bucket listing to work when many filtered out entries

A previous PR moved the much of the filtering that's part of bucket
listing to the CLS layer. One unanticipated result was that it is now
possible for a call to return 0 entries. In such a case we want to
retry the call with the marker moved forward (i.e., advanced),
repeatedly if necessary, in order to either retrieve some entries or
to hit the end of the entries. This PR adds that functionality.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

rgw: allow CLSRGWConcurrentIO to handle "advancing" retries

When doing an asynchronous/concurrent bucket index operation against
multiple bucket index shards, a special error code is set aside to
indicate that an "advancing" retry of a/some shard(s) is necessary. In
that case another asynchronous call is made on the indicated shard(s)
from the client (i.e., CLSRGWConcurrentIO).  It is up to the subclass
of CLSRGWConcurrentIO to handle the retry such that it "advances" and
simply doesn't get stuck, looping forever.

The retry functionality only works when the "need_multiple_rounds"
functionality is not in use.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

rgw: de-conflate shard_id and request_id in CLSRGWConcurrentIO

When using asynchronous (concurrent) IO for bucket index requests,
there are two int ids that are used that need to be kept separate --
shard id and request id. In many cases they're the same -- shard 0
gets request 0, and so forth.

But in preparation for re-requests, those ids can diverge, where
request 13 maps to shard 2. The existing code maintained the OIDs that
went with each request. This PR also maintains the shard id as
well. Documentation has been beefed up to help future developers
navigate this.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

cmake: disable kvs rados cls by default

libcls_kvs was introduced back in
73d016fdb304ad19bba8aed3f2877b4bdb6ed32e, but we don't have an internal
user so far. to reduce the build time. let's disable the build of it by
default.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #42567 from dsavineau/issue_51973

cephadm: set global default container for ingress

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #42559 from tchaikov/wip-rpm-dwz

rpm: enable dwz

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

script/ceph-release-notes: sort PRs case-insensitively

Signed-off-by: Josh Durgin <jdurgin@redhat.com>

mgr/dashboard: fix ssl cert validation for rgw service creation

Fixes: https://tracker.ceph.com/issues/51965
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

script/ceph-release-notes: adapt markdown output for new website

* escape underscores
* avoid automatic links from PR titles containing .

Signed-off-by: Josh Durgin <jdurgin@redhat.com>

rgw: clean up some code

In rgw_admin.cc a variable `f` is used frequently. However due to the
sheer size of the file and variable scopes involved, finding the
declaration of `f`, which is a common character, can be
challenging. So it has been renamed `stream_flusher`, which better
indicates its purpose and makes it easier to find the corresponding
declaration.

Additionally some unneeded variables in RGWBucket::check_object_index
were removed. rgw::sal::Bucket::ListParams initializes parameters as
one would hope/expect.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

cmake: Remove duplicate SQLite module

Signed-off-by: Soumya Koduri <skoduri@redhat.com>