]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoRGW - Zipper remove unused files 42851/head
Daniel Gryniewicz [Thu, 19 Aug 2021 14:27:50 +0000 (10:27 -0400)]
RGW - Zipper remove unused files

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #42796 from dang/wip-dang-zipper-raw_obj
Daniel Gryniewicz [Thu, 19 Aug 2021 14:19:27 +0000 (10:19 -0400)]
Merge pull request #42796 from dang/wip-dang-zipper-raw_obj

RGW - Remove last rgw_raw_obj from zipper

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #42793 from sebastian-philipp/dashboard-fix-standby-redirect
Alfonso Martínez [Thu, 19 Aug 2021 11:12:17 +0000 (13:12 +0200)]
Merge pull request #42793 from sebastian-philipp/dashboard-fix-standby-redirect

pybind/mgr: Fix IPv6 url generation

3 years agoMerge pull request #42302 from myoungwon/wip-51000
Kefu Chai [Thu, 19 Aug 2021 07:42:04 +0000 (15:42 +0800)]
Merge pull request #42302 from myoungwon/wip-51000

osd: fix to allow inc manifest leaked

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #42820 from ronen-fr/wip-ronenf-mgr-argvvec
Kefu Chai [Thu, 19 Aug 2021 07:40:54 +0000 (15:40 +0800)]
Merge pull request #42820 from ronen-fr/wip-ronenf-mgr-argvvec

common: create a faster & cleaner alternative to argv_to_vec()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42823 from mgfritch/ceph-volume-py3-exec
Kefu Chai [Thu, 19 Aug 2021 06:49:55 +0000 (14:49 +0800)]
Merge pull request #42823 from mgfritch/ceph-volume-py3-exec

cmake: s/Python_EXECUTABLE/Python3_EXECUTABLE/

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42799 from varshar16/wip-update-email-id
Kefu Chai [Thu, 19 Aug 2021 06:42:38 +0000 (14:42 +0800)]
Merge pull request #42799 from varshar16/wip-update-email-id

.githubmap: update mail address

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #42835 from ceph/wip-ctest-fail
Kefu Chai [Thu, 19 Aug 2021 05:49:37 +0000 (13:49 +0800)]
Merge pull request #42835 from ceph/wip-ctest-fail

run-make-check.sh: Increase failure output log size

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42828 from tchaikov/wip-doc-dev-config
Kefu Chai [Thu, 19 Aug 2021 02:15:43 +0000 (10:15 +0800)]
Merge pull request #42828 from tchaikov/wip-doc-dev-config

doc/dev/config: update to in sync with latest .yaml.in changes

Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agorun-make-check.sh: Increase failure output log size 42835/head
David Galloway [Wed, 18 Aug 2021 17:30:22 +0000 (13:30 -0400)]
run-make-check.sh: Increase failure output log size

Fixes: https://tracker.ceph.com/issues/43566
Signed-off-by: David Galloway <dgallowa@redhat.com>
3 years agoRGW - Zipper - remove last rgw_raw_obj from API 42796/head
Daniel Gryniewicz [Tue, 10 Aug 2021 13:40:54 +0000 (09:40 -0400)]
RGW - Zipper - remove last rgw_raw_obj from API

Remove the remaining rgw_raw_obj from the API.  This consists of:

- move get/delete raw_obj from Store to RadosStore; it's only needed by
  RadosStore code
- Add a layout formatter to the API
- remove head_obj and get_manifest() from ReadOp
- Remove GCChain (no longer needed)

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoFix uninitialized warnings
Daniel Gryniewicz [Tue, 10 Aug 2021 16:22:58 +0000 (12:22 -0400)]
Fix uninitialized warnings

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
3 years agoMerge pull request #42827 from ronen-fr/wip-ronenf-std-fix2
Ronen Friedman [Wed, 18 Aug 2021 11:40:30 +0000 (14:40 +0300)]
Merge pull request #42827 from ronen-fr/wip-ronenf-std-fix2

key_value_store: fix missing std

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42825 from hualongfeng/fix_blk_pmem
Kefu Chai [Wed, 18 Aug 2021 11:39:26 +0000 (19:39 +0800)]
Merge pull request #42825 from hualongfeng/fix_blk_pmem

blk/pmem: Add namespace std for map,string

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agomgr/cephadm: fix generation of wrong IPv6 urls 42793/head
Sebastian Wagner [Tue, 17 Aug 2021 10:41:31 +0000 (12:41 +0200)]
mgr/cephadm: fix generation of wrong IPv6 urls

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/restful: Fix url generation for IPv6 hosts
Sebastian Wagner [Tue, 17 Aug 2021 10:30:36 +0000 (12:30 +0200)]
mgr/restful: Fix url generation for IPv6 hosts

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/prometheus: Fix url generation for IPv6 hosts
Sebastian Wagner [Tue, 17 Aug 2021 10:29:58 +0000 (12:29 +0200)]
mgr/prometheus: Fix url generation for IPv6 hosts

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agomgr/dashboard: Fix redirect to active MGR
Sebastian Wagner [Mon, 16 Aug 2021 12:15:23 +0000 (14:15 +0200)]
mgr/dashboard: Fix redirect to active MGR

Fixes: https://tracker.ceph.com/issues/52117
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agopybind/mgr: move build_url from dashboard to mgr_util
Sebastian Wagner [Tue, 17 Aug 2021 10:06:12 +0000 (12:06 +0200)]
pybind/mgr: move build_url from dashboard to mgr_util

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #42690 from adk3798/offline2
Sebastian Wagner [Wed, 18 Aug 2021 10:00:33 +0000 (12:00 +0200)]
Merge pull request #42690 from adk3798/offline2

mgr/cephadm: make scheduler able to accomodate offline/maintenance hosts

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
Reviewed-by: Cory Snyder <csnyder@iland.com>
3 years agodoc/dev/config: update to in sync with latest .yaml.in changes 42828/head
Kefu Chai [Wed, 18 Aug 2021 09:33:26 +0000 (17:33 +0800)]
doc/dev/config: update to in sync with latest .yaml.in changes

we migrated to a build process which translate the options from .yaml.in
files. so update the document to reflect this change.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42592 from vfreex/cephadm-better-port-stripping
Sebastian Wagner [Wed, 18 Aug 2021 09:52:09 +0000 (11:52 +0200)]
Merge pull request #42592 from vfreex/cephadm-better-port-stripping

cephadm: better port stripping

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #42590 from vfreex/cephadm-propagate-env-vars
Sebastian Wagner [Wed, 18 Aug 2021 09:51:17 +0000 (11:51 +0200)]
Merge pull request #42590 from vfreex/cephadm-propagate-env-vars

cephadm: propagate environment variables to subprocesses

3 years agoMerge pull request #42589 from vfreex/fix-cephadm-ipv6
Sebastian Wagner [Wed, 18 Aug 2021 09:48:18 +0000 (11:48 +0200)]
Merge pull request #42589 from vfreex/fix-cephadm-ipv6

cephadm: Fix bootstrap error with IPv6 mon-ip

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #42816 from sebastian-philipp/cephadm-upgrade-status-message
Sebastian Wagner [Wed, 18 Aug 2021 09:41:22 +0000 (11:41 +0200)]
Merge pull request #42816 from sebastian-philipp/cephadm-upgrade-status-message

mgr/cephadm/upgrade: Upgrade status: We also upgrade non-ceph daemons

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
3 years agokey_value_store: fix missing std 42827/head
Ronen Friedman [Wed, 18 Aug 2021 08:25:49 +0000 (08:25 +0000)]
key_value_store: fix missing std

following the removal of 'using std' in PR #42742, and missed
in PR #42790.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #41968 from CongMinYin/fix-ssd-bug
Ilya Dryomov [Wed, 18 Aug 2021 08:08:50 +0000 (10:08 +0200)]
Merge pull request #41968 from CongMinYin/fix-ssd-bug

librbd/cache/pwl/ssd: fix m_bytes_allocated exceeding m_bytes_allocated_cap

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #42768 from s0nea/wip-dashboard-suppressed-alerts
Alfonso Martínez [Wed, 18 Aug 2021 06:32:49 +0000 (08:32 +0200)]
Merge pull request #42768 from s0nea/wip-dashboard-suppressed-alerts

mgr/dashboard: don't notify for suppressed alerts

3 years agoblk/pmem: Add namespace std for map,string 42825/head
Feng Hualong [Wed, 18 Aug 2021 05:52:50 +0000 (13:52 +0800)]
blk/pmem: Add namespace std for map,string

Due to not use namespace std for map,string, it leads to
`map,string` not be declared.

Signed-off-by: Feng Hualong <hualong.feng@intel.com>
3 years agoMerge pull request #42758 from liewegas/gh-template
Kefu Chai [Wed, 18 Aug 2021 05:44:50 +0000 (13:44 +0800)]
Merge pull request #42758 from liewegas/gh-template

.github/pull_request_template: fix dashboard e2e test command

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42801 from ivancich/wip-update-rados-rm-help
Kefu Chai [Wed, 18 Aug 2021 03:46:45 +0000 (11:46 +0800)]
Merge pull request #42801 from ivancich/wip-update-rados-rm-help

doc: clarify use of `rados rm` command

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #42822 from tchaikov/wip-drop-gdbm
Kefu Chai [Wed, 18 Aug 2021 03:36:02 +0000 (11:36 +0800)]
Merge pull request #42822 from tchaikov/wip-drop-gdbm

ceph.spec.in: drop gdbm from build deps

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agotools/setup-virtualenv: verify the `--python` param 42823/head
Michael Fritch [Tue, 17 Aug 2021 21:37:13 +0000 (15:37 -0600)]
tools/setup-virtualenv: verify the `--python` param

when given an invalid or empty (PYTHON_BINARY)
fixup for 494fea50ced7

Fixes: https://tracker.ceph.com/issues/52304
Signed-off-by: Michael Fritch <mfritch@suse.com>
3 years agocmake: s/Python_EXECUTABLE/Python3_EXECUTABLE/
Michael Fritch [Tue, 17 Aug 2021 21:36:50 +0000 (15:36 -0600)]
cmake: s/Python_EXECUTABLE/Python3_EXECUTABLE/

pass the python3 exec when creating the ceph-volume build venv
fixup for 5fc657b40dc7

Fixes: https://tracker.ceph.com/issues/52304
Signed-off-by: Michael Fritch <mfritch@suse.com>
3 years agocommon: create a faster & cleaner alternative to argv_to_vec() 42820/head
Ronen Friedman [Tue, 17 Aug 2021 05:11:15 +0000 (05:11 +0000)]
common: create a faster & cleaner alternative to argv_to_vec()

New function signature follows current C++ guidance regarding
returning values from functions. It is also faster
- 1.3X for a sample test of 10 arguments.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Co-authored-by: Kefu Chai <tchaikov@gmail.com>
3 years agoceph.spec.in: drop gdbm from build deps 42822/head
Kefu Chai [Tue, 17 Aug 2021 17:04:39 +0000 (01:04 +0800)]
ceph.spec.in: drop gdbm from build deps

neither gdbm nor libgdbm is used when building ceph, so let's drop it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42738 from sebastian-philipp/mypy-3.7
Sebastian Wagner [Tue, 17 Aug 2021 14:37:15 +0000 (16:37 +0200)]
Merge pull request #42738 from sebastian-philipp/mypy-3.7

pybind/mgr: tox: also test mypy with python 3.7

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agotest: allowing >= the real refcount to avoid false alarm 42302/head
myoungwon oh [Tue, 17 Aug 2021 12:51:29 +0000 (21:51 +0900)]
test: allowing >= the real refcount to avoid false alarm

Current dedup allow to contain multiple same sources using
multiset, which results in inconsistent situation as follow
(during set_chunk, but not confined in set_chunk).

1. User issues set_chunk
2. OSD receives the set_chunk, and sends increment message
to an object in the low tier (INPROGRESS).
3. OSD map is changed (841 → 843)
3.5. on_change() is called
4. the set_chunk op is reenqueued by requeue_op()
5. OSD handles the duplicated set_chunk, but it is not able to
 know the set_chunk is duplicated because it does not log on the disk yet.
6. OSD issues increment message again to the object
in the low tier. (increment operation is executed twice)

To fix this, this commit allows >= the real refcount in test cases

fixes: https://tracker.ceph.com/issues/51000

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
3 years agoMerge pull request #42811 from tchaikov/wip-dashboard-test
Kefu Chai [Tue, 17 Aug 2021 12:40:47 +0000 (20:40 +0800)]
Merge pull request #42811 from tchaikov/wip-dashboard-test

mgr/dashboard/api: set a UTF-8 locale when running pip

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
3 years agoMerge pull request #42732 from rhcs-dashboard/bug-1950644
Alfonso Martínez [Tue, 17 Aug 2021 12:35:24 +0000 (14:35 +0200)]
Merge pull request #42732 from rhcs-dashboard/bug-1950644

mgr/dashboard: disable create snapshot with subvolumes

3 years agoMerge pull request #42717 from rhcs-dashboard/iscsi-target-refresh-btn
Alfonso Martínez [Tue, 17 Aug 2021 12:32:49 +0000 (14:32 +0200)]
Merge pull request #42717 from rhcs-dashboard/iscsi-target-refresh-btn

mgr/dashboard: Refresh button on the iscsi targets page

3 years agomgr/cephadm/upgrade: Upgrade status: We also upgrade non-ceph daemons 42816/head
Sebastian Wagner [Tue, 17 Aug 2021 12:27:40 +0000 (14:27 +0200)]
mgr/cephadm/upgrade: Upgrade status: We also upgrade non-ceph daemons

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agolibrbd/cache/pwl/ssd: ensure bdev and pool sizes match 41968/head
Ilya Dryomov [Sat, 14 Aug 2021 17:15:47 +0000 (19:15 +0200)]
librbd/cache/pwl/ssd: ensure bdev and pool sizes match

m_log_pool_size should be multiple of 1M but, just in case, prevent
is_valid_io() assert in KernelDevice::aio_write().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agoMerge pull request #42786 from aaryanporwal/visual-tests
Alfonso Martínez [Tue, 17 Aug 2021 09:57:41 +0000 (11:57 +0200)]
Merge pull request #42786 from aaryanporwal/visual-tests

mgr/dashboard: visual tests: Add more ignore regions for dashboard component

3 years agomgr/dashboard: disable create snapshot with subvolumes 42732/head
Pere Diaz Bou [Tue, 17 Aug 2021 07:41:58 +0000 (09:41 +0200)]
mgr/dashboard: disable create snapshot with subvolumes

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #42808 from tchaikov/wip-crimson-test-cleanup
Kefu Chai [Tue, 17 Aug 2021 08:03:06 +0000 (16:03 +0800)]
Merge pull request #42808 from tchaikov/wip-crimson-test-cleanup

test/crimson: do not discard returned future<>

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agomgr/dashboard/api: set a UTF-8 locale when running pip 42811/head
Kefu Chai [Tue, 17 Aug 2021 07:53:51 +0000 (15:53 +0800)]
mgr/dashboard/api: set a UTF-8 locale when running pip

ansible-core started to include files whose filenames are encoded in
non-ascii characters, so we have to use a more capable encoding for the
locale in order to install this package. otherwise we'd have following
error:

Collecting ansible-core<2.12,>=2.11.3
  Using cached ansible-core-2.11.4.tar.gz (6.8 MB)
ERROR: Exception:

Traceback (most recent call last):
  File "/tmp/tmp.fX76ASIrch/venv/lib/python3.8/site-packages/pip/_internal/cli/base_command.py", line 173, in _main
    status = self.run(options, args)
...
  File "/tmp/tmp.fX76ASIrch/venv/lib/python3.8/site-packages/pip/_internal/utils/unpacking.py", line 226, in untar_file
    with open(path, "wb") as destfp:
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 137-140: ordinal not in range(256)

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42807 from tchaikov/wip-crimson-test-more-chatty
Kefu Chai [Tue, 17 Aug 2021 07:01:45 +0000 (15:01 +0800)]
Merge pull request #42807 from tchaikov/wip-crimson-test-more-chatty

test/crimson: re-enable logging output

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Xuehan Xu <xuxuehan@360.cn>
3 years agoMerge pull request #42791 from ideepika/wip-50947-blk-cmake
Kefu Chai [Tue, 17 Aug 2021 06:32:32 +0000 (14:32 +0800)]
Merge pull request #42791 from ideepika/wip-50947-blk-cmake

src/blk: fix block_device_t return if no aio libs present

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42800 from tchaikov/wip-cmake-debug-build
Kefu Chai [Tue, 17 Aug 2021 06:28:07 +0000 (14:28 +0800)]
Merge pull request #42800 from tchaikov/wip-cmake-debug-build

cmake: set CMAKE_BUILD_TYPE to Debug when .git exists

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
3 years agotest/crimson: do not discard returned future<> 42808/head
Kefu Chai [Tue, 17 Aug 2021 06:11:20 +0000 (14:11 +0800)]
test/crimson: do not discard returned future<>

to silence following warning:

../src/test/crimson/seastore/test_randomblock_manager.cc:122:7: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
      rbm_manager->add_free_extent(t.allocated_blocks, r.first * DEFAULT_BLOCK_SIZE,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agotest/crimson: use structured binding
Kefu Chai [Tue, 17 Aug 2021 06:09:48 +0000 (14:09 +0800)]
test/crimson: use structured binding

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42798 from xxhdx1985126/wip-52275
Kefu Chai [Tue, 17 Aug 2021 05:43:39 +0000 (13:43 +0800)]
Merge pull request #42798 from xxhdx1985126/wip-52275

crimson/common: allow the tls interrupt_cond to exist when a continuation starts to run

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agotest/crimson: re-enable logging output 42807/head
Kefu Chai [Tue, 17 Aug 2021 05:39:39 +0000 (13:39 +0800)]
test/crimson: re-enable logging output

this change reverts 57877075c0b6885c7e35dc4c4a881b140c30cfb0

per Yingxin's request, we should enable it for better debugging
experience when the test fails.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42787 from rzarzynski/wip-crimson-fix-warn-storenbd
Kefu Chai [Tue, 17 Aug 2021 05:07:25 +0000 (13:07 +0800)]
Merge pull request #42787 from rzarzynski/wip-crimson-fix-warn-storenbd

crimson/tools: silence [[maybe_unused]] warning in store-nbd.cc.

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years ago.githubmap: update mail address 42799/head
Varsha Rao [Mon, 16 Aug 2021 16:54:46 +0000 (22:24 +0530)]
.githubmap: update mail address

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
3 years agoRevert "crimson/onode-staged-tree: force test work with invalidated transactions" 42798/head
Yingxin Cheng [Mon, 16 Aug 2021 08:09:59 +0000 (16:09 +0800)]
Revert "crimson/onode-staged-tree: force test work with invalidated transactions"

This reverts commit 8b6428c4ac08a7d3beabf64f549bfe11e5245978.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agotest/crimson: avoid creating interrupt condition within an already interruptible...
Xuehan Xu [Tue, 17 Aug 2021 04:17:27 +0000 (12:17 +0800)]
test/crimson: avoid creating interrupt condition within an already interruptible continuation chain

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/common: assert the existence of interrupt_cond even in release builds
Xuehan Xu [Mon, 16 Aug 2021 16:20:02 +0000 (00:20 +0800)]
crimson/common: assert the existence of interrupt_cond even in release builds

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agocrimson/common: allow the tls interrupt_cond to exist when a continuation starts...
Xuehan Xu [Mon, 16 Aug 2021 16:16:10 +0000 (00:16 +0800)]
crimson/common: allow the tls interrupt_cond to exist when a continuation starts to run

Release build of seastar invokes continuations synchronously if their predecessor futures
are resolved at the time when those continuations are constructed, so we have to allow
these circumstances to happen

Fixes: https://tracker.ceph.com/issues/52275
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agoMerge pull request #42658 from tchaikov/wip-doc-build
Kefu Chai [Tue, 17 Aug 2021 03:26:07 +0000 (11:26 +0800)]
Merge pull request #42658 from tchaikov/wip-doc-build

admin/build-doc: rebuild venv if md5 does not match

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agoMerge PR #42749 into master
Patrick Donnelly [Tue, 17 Aug 2021 02:15:37 +0000 (19:15 -0700)]
Merge PR #42749 into master

* refs/pull/42749/head:
doc: document that NEARFULL conditions can result in slow writes

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
3 years agoMerge pull request #42797 from rzarzynski/wip-crimson-no-prometheus-by-default
Kefu Chai [Tue, 17 Aug 2021 01:09:52 +0000 (09:09 +0800)]
Merge pull request #42797 from rzarzynski/wip-crimson-no-prometheus-by-default

crimson/osd: disable Premetheous by default.

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agocmake: set CMAKE_BUILD_TYPE to Debug when .git exists 42800/head
Kefu Chai [Mon, 16 Aug 2021 17:07:45 +0000 (01:07 +0800)]
cmake: set CMAKE_BUILD_TYPE to Debug when .git exists

if CMAKE_BUILD_TYPE is an empty string, we should also set it to Debug.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoerasure-code/clay: do not set unreferenced variable
Kefu Chai [Tue, 17 Aug 2021 00:46:08 +0000 (08:46 +0800)]
erasure-code/clay: do not set unreferenced variable

plane_count was introduced by 2a3e56b22c5b52e4834a9fd5047b3cdff7e8859f,
and presumably it is only used for debugging. let's drop it as it is not
referenced in production.

this change silences following warning:

../src/erasure-code/clay/ErasureCodeClay.cc:502:7: error: variable 'plane_count' set but not used [-Werror,-Wunused-but-set-variable]
  int plane_count = 0;
      ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoerasure-code/lrc: early return if to_string() fails
Kefu Chai [Tue, 17 Aug 2021 00:43:46 +0000 (08:43 +0800)]
erasure-code/lrc: early return if to_string() fails

so far to_string() always return 0, but it is designed to return
an error code if it fails to parse a string.

this change silences following warning:

../src/erasure-code/lrc/ErasureCodeLrc.cc:399:7: error: variable 'err' set but not used [-Werror,-Wunused-but-set-variable]
  int err = 0;
      ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agomds/CDir: do not set referenced variable
Kefu Chai [Tue, 17 Aug 2021 00:38:30 +0000 (08:38 +0800)]
mds/CDir: do not set referenced variable

off is set by never get referenced, let's just drop it.

this variable was introduced by
0ec5f3a84aa29ec422e920fb5dc989ed90897e6b.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42731 from liu-chunmei/seastore-alloc-extent-hint
Liu-Chunmei [Tue, 17 Aug 2021 00:15:22 +0000 (17:15 -0700)]
Merge pull request #42731 from liu-chunmei/seastore-alloc-extent-hint

crimson/seastore alloc extent hint

Replace L_ADDR_MIN by obj hash in onode, omap, object_data when alloc_extent.

Reviewed-by: Sam Just <sjust@redhat.com> and Cheng, Yingxin <yingxin.cheng@intel.com>
3 years agorgw: disable -Wimplicit-const-int-float-conversion conditionally
Kefu Chai [Tue, 17 Aug 2021 00:04:28 +0000 (08:04 +0800)]
rgw: disable -Wimplicit-const-int-float-conversion conditionally

to silence warning like:

 unknown warning group '-Wimplicit-const-int-float-conversion', ignored [-Werror,-Wunknown-warning-option]
 #pragma clang diagnostic ignored "-Wimplicit-const-int-float-conversion"

clang-10 does not support this option yet.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agodoc: clarify use of `rados rm` command 42801/head
J. Eric Ivancich [Mon, 16 Aug 2021 22:28:07 +0000 (18:28 -0400)]
doc: clarify use of `rados rm` command

The man page did not make it clear that multiple objects could be
specified, nor did it describe use of "--force-full".

Info displayed about "rm" with `rados --help` was poorly formatted and
the wording was adjusted.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
3 years agolibrbd/cache/pwl: make pool size a multiple of 1M
Ilya Dryomov [Sat, 14 Aug 2021 17:06:28 +0000 (19:06 +0200)]
librbd/cache/pwl: make pool size a multiple of 1M

In ssd mode, we need it to be a multiple of bdev block size.
Instead of munging it after opening the bdev in ssd/WriteLog.cc, let's
impose a common restriction and round rbd_persistent_cache_size down to
a 1M boundary.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
3 years agocrimson/seastore: change unit test using hint 42731/head
Chunmei Liu [Wed, 11 Aug 2021 03:22:17 +0000 (20:22 -0700)]
crimson/seastore: change unit test using hint

Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agocrimson/seastore: replace L_ADDR_MIN by hint in omap
chunmei-liu [Sat, 7 Aug 2021 20:39:45 +0000 (13:39 -0700)]
crimson/seastore: replace L_ADDR_MIN by hint in omap

Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
3 years agocrimson/seastore: use get_hint in object_data_handler
Chunmei Liu [Thu, 12 Aug 2021 00:45:55 +0000 (17:45 -0700)]
crimson/seastore: use get_hint in object_data_handler

Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agocrimson/seastore: replace L_ADDR_MIN by obj hash in Onode
Chunmei Liu [Mon, 16 Aug 2021 20:54:07 +0000 (13:54 -0700)]
crimson/seastore: replace L_ADDR_MIN by obj hash in Onode

Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
3 years agoMerge pull request #42340 from mkogan1/wip-d3n-docs
Casey Bodley [Mon, 16 Aug 2021 20:11:33 +0000 (16:11 -0400)]
Merge pull request #42340 from mkogan1/wip-d3n-docs

doc/radosgw/d3n: add user docs

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
3 years agocrimson/osd: disable Prometheous by default. 42797/head
Radoslaw Zarzynski [Mon, 16 Aug 2021 16:00:54 +0000 (16:00 +0000)]
crimson/osd: disable Prometheous by default.

As we lack the machinery for distributed port allocation, spawning
multiple instances of crimson on the same node is impossible. This
makes almost all Teuthology jobs red very early.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agodoc/radosgw/d3n: add user docs 42340/head
Mark Kogan [Wed, 14 Jul 2021 16:37:16 +0000 (19:37 +0300)]
doc/radosgw/d3n: add user docs

(high-level feature description, setup instructions, config options)
Fixes: https://tracker.ceph.com/issues/51409
Signed-off-by: Mark Kogan <mkogan@redhat.com>
3 years agoMerge pull request #42790 from ronen-fr/wip-ronenf-std-fix
Kefu Chai [Mon, 16 Aug 2021 15:05:41 +0000 (23:05 +0800)]
Merge pull request #42790 from ronen-fr/wip-ronenf-std-fix

key_value_store: fix missing std

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42795 from tchaikov/wip-cmake-quiet
Kefu Chai [Mon, 16 Aug 2021 14:38:58 +0000 (22:38 +0800)]
Merge pull request #42795 from tchaikov/wip-cmake-quiet

cmake: silence build output when building external deps

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agosrc/blk: fix block_device_t return if no aio libs present 42791/head
Deepika Upadhyay [Mon, 16 Aug 2021 14:04:33 +0000 (19:34 +0530)]
src/blk: fix block_device_t return if no aio libs present

In cases, when no libaio are present in the system, compilation fails,
return block_device_t as unknown

fixes: https://tracker.ceph.com/issues/50947#note-1

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agocmake: do not quote string 42795/head
Kefu Chai [Mon, 16 Aug 2021 13:02:06 +0000 (21:02 +0800)]
cmake: do not quote string

otherwise we have

CMake Error at /home/jenkins-build/build/workspace/ceph-pull-requests/build/spdk-ext-prefix/src/spdk-ext-stamp/spdk-ext-build-.cmake:37 (message):
  Command failed: 2

   'env' '-i' 'PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin' 'CC=/usr/bin/clang-10' '/usr/bin/make' 'EXTRA_CFLAGS=' '-fPIC' '-Wno-address-of-packed-member""'

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocmake: silence build output when building external deps
Kefu Chai [Mon, 16 Aug 2021 10:42:18 +0000 (18:42 +0800)]
cmake: silence build output when building external deps

when download/building grafonnet-lib, dpdk, spdk, liburing and fio,
they dump lots of output during configuration and building phrases,
all of which is irrelevant to us. so let's just silence it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42784 from tchaikov/wip-rgw_dencoder
Kefu Chai [Mon, 16 Aug 2021 13:12:05 +0000 (21:12 +0800)]
Merge pull request #42784 from tchaikov/wip-rgw_dencoder

rgw/rgw_dencoder: set identity_type when creating samples

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agokey_value_store: fix missing std 42790/head
Ronen Friedman [Mon, 16 Aug 2021 11:28:28 +0000 (11:28 +0000)]
key_value_store: fix missing std

following PR #42742

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #42785 from tchaikov/wip-no-warnings
Kefu Chai [Mon, 16 Aug 2021 13:08:33 +0000 (21:08 +0800)]
Merge pull request #42785 from tchaikov/wip-no-warnings

run-make-check: pass -Werror when compiling C++ code and a couple cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 years agoMerge pull request #42714 from ronen-fr/wip-ronenf-last-update
Kefu Chai [Mon, 16 Aug 2021 12:20:12 +0000 (20:20 +0800)]
Merge pull request #42714 from ronen-fr/wip-ronenf-last-update

osd/scrub: only telling the scrubber of 'updates' events if these eve…

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #42754 from aclamk/wip-aclamk-bluefs-improve-allocation-check
Kefu Chai [Mon, 16 Aug 2021 12:18:02 +0000 (20:18 +0800)]
Merge pull request #42754 from aclamk/wip-aclamk-bluefs-improve-allocation-check

os/bluestore/bluefs: Cleanup allocation consistency check code

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
3 years agomgr/dashboard: visual tests: Add more ignore regions for dashboard component 42786/head
Aaryan Porwal [Sun, 15 Aug 2021 23:04:40 +0000 (04:34 +0530)]
mgr/dashboard: visual tests: Add more ignore regions for dashboard component

Fixes: https://tracker.ceph.com/issues/52282
Signed-off-by: Aaryan Porwal <aaryanporwal2233@gmail.com>
3 years agocrimson/tools: silence [[maybe_unused]] warning in store-nbd.cc. 42787/head
Radoslaw Zarzynski [Mon, 16 Aug 2021 09:49:28 +0000 (09:49 +0000)]
crimson/tools: silence [[maybe_unused]] warning in store-nbd.cc.

```
[595/2463] Building CXX object src/crimson/tools/CMakeFiles/crimson-store-nbd.dir/store_nbd/store-nbd.cc.o
../src/crimson/tools/store_nbd/store-nbd.cc:324:43: warning: maybe_unused attribute ignored [-Wattributes]
  324 |   [[maybe_unused]] char reserved[124] = {0};
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agorun-make-check: pass -Werror when compiling C++ code 42785/head
Kefu Chai [Mon, 16 Aug 2021 09:36:30 +0000 (17:36 +0800)]
run-make-check: pass -Werror when compiling C++ code

to raise the bar so we can identify potential issues earlier.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agocmake: use -Wno-unused-but-set-variable when compiling SPDK if supported
Kefu Chai [Mon, 16 Aug 2021 09:32:33 +0000 (17:32 +0800)]
cmake: use -Wno-unused-but-set-variable when compiling SPDK if supported

to silence warnings like:

In file included from nvme_tcp.c:52:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/spdk/include/spdk_internal/nvme_tcp.h:369:17: warning: variable 'plen' set but not used [-Wunused-but-set-variable]
        uint32_t hlen, plen;
                       ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42580 from hualongfeng/solve_competition_between_read_and_retire
Ilya Dryomov [Mon, 16 Aug 2021 09:30:01 +0000 (11:30 +0200)]
Merge pull request #42580 from hualongfeng/solve_competition_between_read_and_retire

librbd/cache/pwl/ssd: solve competition between read and retire

Reviewed-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 years agocmake: use string(APPEND ..) to append to string
Kefu Chai [Mon, 16 Aug 2021 09:29:35 +0000 (17:29 +0800)]
cmake: use string(APPEND ..) to append to string

more readable and less repeating this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agorgw/rgw_rest: do not set unused variable
Kefu Chai [Mon, 16 Aug 2021 09:26:09 +0000 (17:26 +0800)]
rgw/rgw_rest: do not set unused variable

`len` is used to track the total length of received data, but we already
collect the data in `bl`, so we can always check `bl` for the total
length. this change also silences following warning from Clang:

../src/rgw/rgw_rest.cc:1477:21: warning: variable 'len' set but not used [-Wunused-but-set-variable]
  int read_len = 0, len = 0;
                    ^
1 warning generated.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agomgr/dashboard: Refresh button on the iscsi targets page 42717/head
Nizamudeen A [Mon, 9 Aug 2021 07:52:51 +0000 (13:22 +0530)]
mgr/dashboard: Refresh button on the iscsi targets page

Added a refresh button on the iscsi targets page. I've noticed that the
auto reload causes some load on the backend. So I disabled the auto
reload and went for the same approach as we have on rgw. A yellow
warning color on refresh btn to let the user know to manually refresh
that whenever needed.

Fixes: https://tracker.ceph.com/issues/52102
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoos/bluestore/BlueStore: make maybe unused variable [[maybe_unused]]
Kefu Chai [Mon, 16 Aug 2021 09:17:48 +0000 (17:17 +0800)]
os/bluestore/BlueStore: make maybe unused variable [[maybe_unused]]

cct is defined so it can be used by dout(), but when the source code is
compiled for crimson, dout() does not use cct at all, so in that case,
compiler complains like:

../src/os/bluestore/BlueStore.cc:17413:8: warning: unused variable 'cct' [-Wunused-variable]
  auto cct  = onode->c->store->cct;
       ^
1 warning generated.

in this change, cct is marked with [[maybe_unused]] to silence this
warning.

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #42777 from tchaikov/wip-clang-build
Kefu Chai [Mon, 16 Aug 2021 08:59:09 +0000 (16:59 +0800)]
Merge pull request #42777 from tchaikov/wip-clang-build

run-make-check,cmake: use clang in run-make-check.sh

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agorgw/rgw_json_enc: dump rgw_log_entry::identity_type 42784/head
Kefu Chai [Mon, 16 Aug 2021 08:23:26 +0000 (16:23 +0800)]
rgw/rgw_json_enc: dump rgw_log_entry::identity_type

should dump it for better debugging experience

Signed-off-by: Kefu Chai <kchai@redhat.com>
3 years agorgw/rgw_json_enc: dump obj using dump_stream()
Kefu Chai [Mon, 16 Aug 2021 08:21:42 +0000 (16:21 +0800)]
rgw/rgw_json_enc: dump obj using dump_stream()

use dump_stream() instead of dump_string() for dumping stringify object.

more readably this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>