client: fix uninline data funtion

For CEPH_OSD_CMPXATTR_MODE_U64, OSD expects the u64 to be encoded
as string in object's xattr

Fixes: #11356
Signed-off-by: Yan, Zheng <zyan@redhat.com>

Merge pull request #4239 from yuyuyu101/wip-librbd-conf

Wip librbd conf

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #4323 from ceph/wip-11363

librbd: ImageWatcher should cancel in-flight ops on watch error

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #4140 from ceph/wip-rbd-rebuild-object-map

rbd: add ability to rebuild corrupt/missing object maps

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #4325 from wonzhq/async-resize-2

librbd/AsyncResize: avoid dup incrementing refresh seq

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #4336 from ceph/wip-11369

librbd: failure to update the object map should always return success

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #4319 from ceph/wip-11348

librbd: update default image format to version 2

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

librbd: notify of header update after rebuilding object map

This will allow clients to detect that the object map is no longer
invalid and to reload the object map from disk.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: rebuilding object map shouldn't update piecemeal

The object map is now rebuilt in-memory and written back to the
OSDs as a single operation.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: add test case for cls_rbd object_map_save

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

cls_rbd_client: add object_map_save helper method

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

cls_rbd: add object_map_save method

Allow the object map rebuild process to build the full object map
in memory and save it to disk with one operation.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: add ImageWatcher test for new rebuild object map request

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: added rebuild_object_map test to test_librbd

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: librados_test_stub reads should deep-copy

If a client of librados_test_stub modified a bufferlist
retrieved via a read call, the client will actually be
changing the contents of the file.  Therefore, read calls
should deep-copy the contents of the buffer::ptrs.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: allow snapshot object maps to be updated

Rebuild will need to be able to update/resize the object maps
for image snapshots.  This was previously not permitted.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: update in-memory object map before on-disk update completes

When multiple IO updates are occurring within the same object, this
will allow only a single object map update request to be sent to the
OSD.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

cls_rbd: treat zero-byte object maps as missing

Acquiring the lock on a missing object map will create an
empty object. Treat the empty object as a non-existant
object map to support rebuilding corrupt object maps while
holding the exclusive lock.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

rbd: add object map rebuild command

An invalid object map can now be rebuilt via the rbd CLI.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: add rebuild_object_map to public API

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librados_test_stub: add another overload of aio_operate

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: connect async rebuild object map to state machine

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: require callers to ObjectMap::aio_update to acquire lock

This is needed to allow an atomic compare and update operation
from the rebuild object map utility.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: added RebuildObjectMapRequest state machine

It will verify the object map is properly sized, verify
the existence of each object within the image (snapshot),
and clear the invalid object map flag once complete.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: correct basic object map errors during refresh

If the object map is corrupt on-disk or too small for the image,
correct these basic issues as soon as possible.  The object map
is still flagged as invalid, but there will be less required repair
work if future IO is able to properly update the object map.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: use generic helper for issuing async requests

resize, flatten, and rebuild object map now use the same
bootstrap code for sending the request to the remote lock owner
or executing the request locally.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: connect ImageWatch rebuild request to async rebuild method

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: add preliminary methods for rebuilding object map

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: add hooks for rebuild object map to ImageWatcher

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: add new notify payload for rebuild object map

The request will be sent to the client which owns the exclusive
lock to rebuild the object map for the current image HEAD.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librbd: failure to update the object map should always return success

If an object map update fails, the object map will be flagged as
invalid.  However, if a subsequent update failure occurs, the error
code will propagate back to the caller.

Fixes: #11369
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: librados_test_stub reads should deep-copy

If a client of librados_test_stub modified a bufferlist
retrieved via a read call, the client will actually be
changing the contents of the file.  Therefore, read calls
should deep-copy the contents of the buffer::ptrs.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #4330 from dachary/wip-hammer-release-notes

release-notes: draft v0.94.1 release notes

librbd: ImageWatcher should cancel in-flight ops on watch error

Upon an watch error notification from librados, pending requests
should be canceled and in-flight IO should be flushed prior to
unlocking the image.

Fixes: #11363
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #4333 from dachary/wip-fedora

tests: add Dockerfile for fedora 21

Reviewed-by: Kefu Chai <kchai@redhat.com>

tests: add Dockerfile for fedora 21

Signed-off-by: Loic Dachary <ldachary@redhat.com>

release-notes: draft v0.94.1 release notes

Signed-off-by: Loic Dachary <ldachary@redhat.com>

librbd: Fix image_watcher test

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

Librbd: Don't affect global md_config_t

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

Librbd: Don't apply to global configserver

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

librbd/AsyncResize: avoid dup incrementing refresh seq

The refresh_seq is incremented in notify_change when calling
notify_async_complete after the locker owner completes the resize
request.

Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com>

Merge pull request #4306 from dachary/wip-ec-troubleshooting

doc: an erasure code crush ruleset can be dynamically modified

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

Merge pull request #4320 from liewegas/wip-crush-straw2-div0

crush/mapper: fix divide-by-0 in straw2

Reviewed-by: Yann Dupont <yann@objoo.org>
Reviewed-by: Loic Dachary <ldachary@redhat.com>

crush/mapper: fix divide-by-0 in straw2

If the item weight is 0 we don't want to divide; instead draw a minimal
value.

Fixes: #11357
Reported-by: Yann Dupont <yd@objoo.org>
Tested-by: Yann Dupont <yd@objoo.org>
Signed-off-by: Sage Weil <sage@redhat.com>

qa/workunits/rbd/copy.sh: removed deprecated --new-format option

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: ensure old-format RBD tests still work

Override the RBD default image format back to version 1
to ensure tests properly cover the old format.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

rbd: deprecate --new-format command-line option

Image formats can be explicitly chosen via the --image-format X
command-line option.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

common/config_opts: updated rbd_default_format

New images will now default to format 2 RBD images.

Fixes: #11348
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

librados_test_stub: added rados_ioctx_cct implementation

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Merge pull request #4174 from trociny/wip-10976.master

osd: fix PG::all_unfound_are_queried_or_lost for non-existent osds

Reviewed-by: Kefu Chai <tchaikov@gmail.com
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #4111 from wonzhq/hitsets-check

osd/ReplicatedPG: correct the checking if the promoting object is in other hit sets

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #4136 from XinzeChi/wip-pg-delete-sleep

osd: return fast if PG::deleting is true in snap_trimmer and PG::scrub

Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #4178 from XinzeChi/wip-tracker-message

osd: more useful message to find out potential unhealth osd

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #4155 from wonzhq/prdop

osd/ReplicatedPG: don't check order in finish_proxy_read

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Sage Weil <sage@redhat.com>

Merge pull request #4139 from Ved-vampir/oscnt

Perf counters descriptions

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #3928 from dmitryya/rados_bench_with_iops_metric

rados bench: Add IOPS metric to `rados bench'

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #4253 from majianpeng/scrub-fix2

Scrub bug fix

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #4224 from rzarzynski/wip-10682_bucketlisting

rgw: add support for end_marker parameter for GET on Swift container.

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #4305 from Ved-vampir/rgw

rgw: add perf counters descriptions

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #4240 from 9seconds/post_check_quotas

rgw: Quota not respected in POST object

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #4268 from guangyy/wip-11322

rgw : Issue AIO for next chunk first before flush the (cached) data.

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

Merge pull request #4315 from dachary/wip-workflow

doc: development workflows

Reviewed-by: Alistair Israel <aisrael@gmail.com>

doc: when and why publish a point release

Explain who decides when to cut a point release and the tradeoffs
involved.

Signed-off-by: Loic Dachary <ldachary@redhat.com>

doc: add Hammer to the release timeline

Signed-off-by: Loic Dachary <ldachary@redhat.com>

Librbd: aware_metadata_confs->apply_metadata_confs

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

Librbd: Use boost:assign to init aware_confs

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>

Merge pull request #4233 from ceph/wip-librbd-aio-request

librbd: simplify AioRequest constructor parameters

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge remote-tracking branch 'origin/wip-2862'

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Conflicts:
src/common/ceph_argparse.cc
src/rbd.cc

Merge pull request #4307 from dzafman/wip-dz-cmd-fix

osd: Fix wrong usage for "ceph tell osd.* debug dump_missing"

Reviewed-by: Dan Mick <dmick@redhat.com>

osd: Fix wrong usage for "ceph tell osd.* debug dump_missing"

Signed-off-by: David Zafman <dzafman@redhat.com>

Merge pull request #4304 from Ved-vampir/mds

mds: add perf counters descriptions

Reviewed-by: John Spray <john.spray@redhat.com>

rgw: add perf counters descriptions

Sign-off-by: Alyona Kiseleva <akiselyova@mirantis.com>

doc: an erasure code crush ruleset can be dynamically modified

Signed-off-by: Loic Dachary <ldachary@redhat.com>

mds: add perf counters descriptions

Sign-off-by: Alyona Kiseleva <akiselyova@mirantis.com>

doc/release-notes: note about SHEC

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #4274 from liewegas/wip-osd-cleanup

osd: remove some dead(ish) code

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #4301 from nilamdyuti/wip-doc-ceph-object-gateway

doc: Corrects rgw.conf file path for Debian-based and RPM-based distros
in radosgw man page.

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

doc: Corrects rgw.conf file path for Debian-based and RPM-based distros
in radosgw man page.

Signed-off-by: Nilamdyuti Goswami <ngoswami@redhat.com>

Merge pull request #4294 from ktdreyer/wip-readme-rm-old-ubuntu

README: rm references to old Ubuntu distros

Reviewed-by: Loic Dachary <ldachary@redhat.com>

Merge pull request #4289 from dachary/wip-docker-user

tests: allow multiple users of docker-tests.sh

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #4210 from trociny/fix-11261

ceph_argparse: return false instead exiting when argument is missed

Reviewed-by: Kefu Chai <kchai@redhat.com>

TestCase: Change in testcase output

For the local sanity test to pass this change is needed as the output message changes.

Signed-off-by: Rajesh Nambiar <rajesh.n@msystechnologies.com>

 Fix to some of the command line parsing (including rbd)

Fix#: 2862

Changes to some of the common files for command line parsing

Change to ceph_argparse.cc
-------------------------

Added function ceph_arg_value_type()
  Given an input it will determine
   i) If that input is an option or not
   ii) If input is numeric in nature or not.

  It will set the flag bool_option and bool_numeric appropriately.
  This function is called by ceph_argparse_witharg() to figure out if
  the input parameter to those functions are numeric in nature and not
  an option.  If the input parameter to ceph_argparse_witharg()
  happens to be an option then it implies that user didn't supply
  value to the option.

Changes to strol.cc
-------------------
Changes to strict_strtoll() and strict_strtol()

  Both these functions reponsibility is to convert the string to long or to int.
  I felt it may be not be good for it to display error message within this function,
  rather caller of this function who has better understanding of the function's purpose
  can display the error message.

  Made change in this function to just create a generic error message,Its the
  caller of this function decides what to do with this message.

Signed-off-by: Rajesh Nambiar <rajesh.n@msystechnologies.com>

rbd: create command throws inappropriate error messages

Fixes: #2862
Changes related to rbd file

Changes to rbd.cc
-----------------

Change 1: line# 2744 to 2747

 If the option is --order then do the check of its value if its less
 than 12 or greaterthan 25 then throw error. Correct value of --order
 is 12 to 25.

Change 2: Removal of validation from line# 3205 to 3209

  Since the check for correct value of --order is done before hence the
  check here is not needed.

Signed-off-by: Rajesh Nambiar <rajesh.n@msystechnologies.com>

Merge pull request #4288 from fullerdj/wip-rbd-xfstests-201504

RBD: build xfsdump and xfsprogs from source; set new expunge set for xfstests

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

RBD: update expunge set for latest test, parameterize test script

Update expunge set for xfstests to known-good set for RHEL7 and Ubuntu 14.04.
Expunged tests without justifying comments are long-running and have not yet
been thoroughly investigated.

Add an environment variable (optionally passed from xfstests_url variable in
test YAML) to override the default xfstests repo.

Signed-off-by: Douglas Fuller <dfuller@redhat.com>

RBD: build prerequisites for latest xfstests and update test configuration

To standardize results from xfstests, install specific versions of xfstests,
xfsprogs, and xfsdump in /tmp. Move test mountpoints to /tmp/cephtest to allow
access for fsgqa user expected by xfstests.

XXX: xfsdump required significant hacks to build and install on Ubuntu 14.04.
A developer removed the definitions of the min and max macros; this commit is
reverted by this script. The installation paths are difficult to override and
the installer breaks (trying to ln one of the binaries to itself) when an
alternate installation location is specified. This script ignores this error
(make -k install || true).

Signed-off-by: Douglas Fuller <dfuller@redhat.com>

README: rm references to old Ubuntu distros

Support for Ubuntu 11.04 officially ended on 28 October 2012.

Support for Ubuntu Oneiric Ocelot was officially ended on 9 May 2013.

Remove the references to these EOL distro versions.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>

Merge pull request #4292 from ceph/wip-11342

librbd: moved snap_create header update notification to initiator

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #4281 from wonzhq/readahead

librbd: readahead fixes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

doc/release-notes: spelling

Signed-off-by: Sage Weil <sage@redhat.com>

doc/release-notes: correction

There isn't an upgrade f-g-x suite

Signed-off-by: Sage Weil <sage@redhat.com>

librbd: moved snap_create header update notification to initiator

When handling a proxied snap_create operation, the client which
invoked the snap_create should send the header update notification
to avoid a possible race condition where snap_create completes but
the client doesn't see the new snapshot (since it didn't yet receive
the notification).

Fixes: #11342
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

doc/release-notes: final hammer notes

Signed-off-by: Sage Weil <sage@redhat.com>

Merge remote-tracking branch 'gh/hammer'

Conflicts:
src/gmock

Merge pull request #4291 from ceph/wip-doc-fixes

Wip doc fixes

Reviewed-by: Loic Dachary <ldachary@redhat.com>

doc/release-notes: make a note about rgw deployment; tweak dedication

Signed-off-by: Sage Weil <sage@redhat.com>

Merge pull request #4283 from oritwas/multizone

rgw: remove meta file after deleting bucket

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

0.94

librbd: simplify AioRequest constructor parameters

Moved all parent overlap computation to within AioRequest so that
callers don't need to independently compute the overlap.  Also
removed the need to pass the snap_id for write operations since
it can only be CEPH_NOSNAP.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>