]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 years agoqa/tasks/nvme_loop: loop until 'nvme list' shows new devs 43455/head
Sage Weil [Fri, 8 Oct 2021 18:43:56 +0000 (13:43 -0500)]
qa/tasks/nvme_loop: loop until 'nvme list' shows new devs

Sometimes this doesn't happen immediately.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/suites/roch/cephadm/smoke: use nvme_loop
Sage Weil [Thu, 7 Oct 2021 15:12:43 +0000 (10:12 -0500)]
qa/suites/roch/cephadm/smoke: use nvme_loop

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/suites/orch/cephadm/smoke-roleless: no osd roles, use nvme loop
Sage Weil [Thu, 7 Oct 2021 15:11:57 +0000 (10:11 -0500)]
qa/suites/orch/cephadm/smoke-roleless: no osd roles, use nvme loop

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/overrides/nvme_loop: reusable fragment to use nvme_loop devs
Sage Weil [Thu, 7 Oct 2021 15:11:03 +0000 (10:11 -0500)]
qa/overrides/nvme_loop: reusable fragment to use nvme_loop devs

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/cephadm: wait for osds to start explicitly
Sage Weil [Tue, 5 Oct 2021 21:36:05 +0000 (16:36 -0500)]
qa/tasks/cephadm: wait for osds to start explicitly

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/cephadm: if no osd roles, --all-available-devices
Sage Weil [Tue, 5 Oct 2021 16:37:58 +0000 (11:37 -0500)]
qa/tasks/cephadm: if no osd roles, --all-available-devices

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoqa/tasks/nvme_loop: set up nvme_loop on scratch_devs
Sage Weil [Tue, 5 Oct 2021 16:06:09 +0000 (11:06 -0500)]
qa/tasks/nvme_loop: set up nvme_loop on scratch_devs

Using an nvme loop device makes the LVs look like "real" disks,
which means we can exercise all of the normal code paths for
provisioning, deprovisioning, and zapping.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoMerge pull request #36733 from majianpeng/rocksdb-remove-redundant-perfcount
Yuri Weinstein [Thu, 30 Sep 2021 14:52:30 +0000 (07:52 -0700)]
Merge pull request #36733 from majianpeng/rocksdb-remove-redundant-perfcount

kv/RocksdbStore: remove perfcounter l_rocksdb_gets.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge pull request #34624 from zhouyh-orcadt/fix_optracker_coredump
Yuri Weinstein [Thu, 30 Sep 2021 14:51:32 +0000 (07:51 -0700)]
Merge pull request #34624 from zhouyh-orcadt/fix_optracker_coredump

common/TrackedOp: fix osd reboot optracker coredump

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 years agoMerge pull request #43355 from rzarzynski/wip-crimson-write_meta
Kefu Chai [Thu, 30 Sep 2021 14:16:51 +0000 (22:16 +0800)]
Merge pull request #43355 from rzarzynski/wip-crimson-write_meta

crimson/osd: write the 'osd_key' meta on OSD::mkfs().

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43364 from rzarzynski/wip-crimson-canceliores-on-stop
Kefu Chai [Thu, 30 Sep 2021 14:14:11 +0000 (22:14 +0800)]
Merge pull request #43364 from rzarzynski/wip-crimson-canceliores-on-stop

crimson/osd: cancel IO reservations on PG::stop().

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agocrimson/osd: cancel IO reservations on PG::stop(). 43364/head
Radoslaw Zarzynski [Thu, 30 Sep 2021 09:53:50 +0000 (09:53 +0000)]
crimson/osd: cancel IO reservations on PG::stop().

`PG::request_{local,remote}_recovery_reservation()` dynamically allocates
up to 2 instances of `LambdaContext<T>` and transfers their ownership to
the `AsyncReserver<T, F>`. This is expressed in raw pointers (`new` and
`delete`) notion. Further analysis shows the only place where `delete`
for these objects is called is the `AsyncReserver::cancel_reservation()`.
In contrast to the classical OSD, crimson doesn't invoke the method when
stopping a PG during the shutdown sequence. This would explain the
following ASan issue observed at Sepia:

```
Direct leak of 576 byte(s) in 24 object(s) allocated from:
    #0 0x7fa108fc57b0 in operator new(unsigned long) (/lib64/libasan.so.5+0xf17b0)
    #1 0x55723d8b0b56 in non-virtual thunk to crimson::osd::PG::request_local_background_io_reservation(unsigned int, std::unique_ptr<PGPeeringEvent, std::default_delete<PGPeeringEvent> >, std::unique_ptr<PGPeeringEvent, std::default_delete<PGPeeringEvent> >) (/usr/bin/ceph-osd+0x24d95b56)
    #2 0x55723f1f66ef in PeeringState::WaitDeleteReserved::WaitDeleteReserved(boost::statechart::state<PeeringState::WaitDeleteReserved, PeeringState::ToDelete, boost::mpl::list<mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, (boost::statechart::history_mode)0>::my_context) (/usr/bin/ceph-osd+0x266db6ef)
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43202 from karmab/kcli_doc
Sebastian Wagner [Thu, 30 Sep 2021 10:01:54 +0000 (12:01 +0200)]
Merge pull request #43202 from karmab/kcli_doc

doc: update kcli information

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43356 from tchaikov/wip-doc-cephadm
Sebastian Wagner [Thu, 30 Sep 2021 08:29:00 +0000 (10:29 +0200)]
Merge pull request #43356 from tchaikov/wip-doc-cephadm

doc/cephadm/services: unindent note section

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agodoc/cephadm/services: unindent note section 43356/head
Kefu Chai [Wed, 29 Sep 2021 23:22:09 +0000 (07:22 +0800)]
doc/cephadm/services: unindent note section

before this change the note on "apply" command is embedded in the note
on "_no_schedule". and they are not related. so let's move the former
out. also, highlight the yaml file sample in YAML.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agocrimson/osd: write the 'ready' meta on OSD::mkfs(). 43355/head
Radoslaw Zarzynski [Wed, 29 Sep 2021 20:12:18 +0000 (20:12 +0000)]
crimson/osd: write the 'ready' meta on OSD::mkfs().

This is for the compliance with the classical OSD. No problem
with lack of this file has been identified yet.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agocrimson/osd: write the 'osd_key' meta on OSD::mkfs().
Radoslaw Zarzynski [Wed, 29 Sep 2021 20:00:20 +0000 (20:00 +0000)]
crimson/osd: write the 'osd_key' meta on OSD::mkfs().

This commit fixes an issue identified during the Rook-crimson effort.

Missing the `write_meta()` on `osd_key` made the CephX inoperational
because of imposibility to load the keyring. Disabling CephX in turn
caused the auth method negotation to fail when reaching out to a monitor.

```
ERROR 2021-09-28 21:19:46,598 [shard 0] none - auth: unable to find a keyring on /var/lib/ceph/osd/ceph-0/keyring: (2) No such file or directory
ERROR 2021-09-28 21:19:46,598 [shard 0] none - AuthRegistry(0x7fa38c322b68) no keyring found at /var/lib/ceph/osd/ceph-0/keyring, disabling cephx
...
INFO  2021-09-28 21:19:46,601 [shard 0] monc - get_auth_request(con=[client.?(temp_mon_client) 172.17.0.1:0/2910147961@63138 >> mon.? v2:10.108.187.31:3300/0], auth_method=0)
INFO  2021-09-28 21:19:46,601 [shard 0] monc - get_auth_request no methods is supported
...
WARN  2021-09-28 21:20:06,612 [shard 0] monc - cannot establish the active_con with any mon
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
3 years agoMerge pull request #43340 from athanatos/sjust/wip-seastore-throttle
Samuel Just [Wed, 29 Sep 2021 19:29:23 +0000 (12:29 -0700)]
Merge pull request #43340 from athanatos/sjust/wip-seastore-throttle

crimson/seastore: fix segment_cleaner blocked_io_wake crash

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
3 years agoMerge PR #43287 into master
Sage Weil [Wed, 29 Sep 2021 18:38:47 +0000 (14:38 -0400)]
Merge PR #43287 into master

* refs/pull/43287/head:
mgr/rook, qa/tasks/rook: change rgw daemon service name
mgr/rook: fix placement_spec_to_node_selector
mgr/rook: orch rm no longer uses rook api delete
qa/tasks/rook: fix cluster deletion hanging due to CephObjectStore CR
mgr/rook: use default replication size in orch apply rgw
mgr/rook: add placement specs to apply rgw

Reviewed-by: Sage Weil <sage@redhat.com>
3 years agoMerge pull request #43255 from rhcs-dashboard/fix-49344-master
Ernesto Puerta [Wed, 29 Sep 2021 18:23:23 +0000 (20:23 +0200)]
Merge pull request #43255 from rhcs-dashboard/fix-49344-master

qa/mgr/dashboard: add extra wait to test

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43341 from pdvian/wip-doc-mon-bootstrap
Kefu Chai [Wed, 29 Sep 2021 15:22:24 +0000 (23:22 +0800)]
Merge pull request #43341 from pdvian/wip-doc-mon-bootstrap

doc/dev/mon-bootstrap: fix typo

Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agodoc: update kcli information 43202/head
karmab [Fri, 17 Sep 2021 06:18:16 +0000 (08:18 +0200)]
doc: update kcli information

3 years agoMerge pull request #42353 from ifed01/wip-ifed-fix-invalid-offset-repair
Kefu Chai [Wed, 29 Sep 2021 14:54:15 +0000 (22:54 +0800)]
Merge pull request #42353 from ifed01/wip-ifed-fix-invalid-offset-repair

os/bluestore: fix writing to invalid offset when repairing

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
3 years agoMerge pull request #39062 from fyzard1991/master
Kefu Chai [Wed, 29 Sep 2021 14:52:11 +0000 (22:52 +0800)]
Merge pull request #39062 from fyzard1991/master

mon/OSDMonitor:Make the pg_num check more accurate

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43289 from tchaikov/wip-52705
Kefu Chai [Wed, 29 Sep 2021 14:50:02 +0000 (22:50 +0800)]
Merge pull request #43289 from tchaikov/wip-52705

os/bluestore: list obj which equals to pend

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Xinze Chi <xinze@xsky.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
3 years agoMerge pull request #42821 from rhcs-dashboard/force-maintenance-workflow
Ernesto Puerta [Wed, 29 Sep 2021 11:36:45 +0000 (13:36 +0200)]
Merge pull request #42821 from rhcs-dashboard/force-maintenance-workflow

mgr/dashboard: Move force maintenance test to the workflow test suite

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
3 years agoMerge pull request #43246 from Daniel-Pivonka/cephadm-iscsi-trust-mgr-ips
Sebastian Wagner [Wed, 29 Sep 2021 10:37:44 +0000 (12:37 +0200)]
Merge pull request #43246 from Daniel-Pivonka/cephadm-iscsi-trust-mgr-ips

mgr/cephadm: populate trusted_ip_list in iscsi-gateway.cfg with mgr ips

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agoMerge pull request #43309 from guits/iscsi_fixes
Sebastian Wagner [Wed, 29 Sep 2021 10:37:02 +0000 (12:37 +0200)]
Merge pull request #43309 from guits/iscsi_fixes

cephadm/iscsi: fix a typo

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43319 from guits/workaround_tcmurunner_log
Sebastian Wagner [Wed, 29 Sep 2021 10:36:42 +0000 (12:36 +0200)]
Merge pull request #43319 from guits/workaround_tcmurunner_log

cephadm: modify iscsi containers bindmount

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43321 from adk3798/remove-exporter
Sebastian Wagner [Wed, 29 Sep 2021 10:36:06 +0000 (12:36 +0200)]
Merge pull request #43321 from adk3798/remove-exporter

mgr/cephadm: remove cephadm exporter code

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43226 from TRYTOBE8TME/wip-rgw-amqp-minor-nit
Yuval Lifshitz [Wed, 29 Sep 2021 09:32:55 +0000 (12:32 +0300)]
Merge pull request #43226 from TRYTOBE8TME/wip-rgw-amqp-minor-nit

src/test: Minor nit from PR #43025

3 years agocrimson/os/seastore/transaction_manager: limit callers to reserve_projected_usage 43340/head
Samuel Just [Wed, 29 Sep 2021 01:46:25 +0000 (18:46 -0700)]
crimson/os/seastore/transaction_manager: limit callers to reserve_projected_usage

Adds an exclusive stage for obtaining projected usage as well as an
unordered one for submitting ool writes.  This should allow for a
straightforward wait-list when io is blocked while still allowing
concurrent submission of ool writes otherwise.

Fixes: https://tracker.ceph.com/issues/52698
Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/segment_cleaner: track projected usage for in progress operations
Samuel Just [Wed, 29 Sep 2021 01:43:02 +0000 (18:43 -0700)]
crimson/os/seastore/segment_cleaner: track projected usage for in progress operations

We're going to want to permit multiple transactions to be writing
concurrently.  Replace await_hard_limits() with a mechanism that
remembers bytes that will be used by in-progress operations.

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agodoc/dev/mon-bootstrap: fix typo 43341/head
Prashant D [Wed, 29 Sep 2021 06:13:56 +0000 (07:13 +0100)]
doc/dev/mon-bootstrap: fix typo

Signed-off-by: Prashant D <pdhange@redhat.com>
3 years agocrimson/os/seastore/segment_manager/block: add debugging to remaining invarg case
Samuel Just [Wed, 29 Sep 2021 03:26:21 +0000 (20:26 -0700)]
crimson/os/seastore/segment_manager/block: add debugging to remaining invarg case

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/segment_manager/block: add method name debug prefix
Samuel Just [Wed, 29 Sep 2021 03:25:55 +0000 (20:25 -0700)]
crimson/os/seastore/segment_manager/block: add method name debug prefix

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43327 from cyx1231st/wip-seastore-ool-metrics
Samuel Just [Wed, 29 Sep 2021 00:38:13 +0000 (17:38 -0700)]
Merge pull request #43327 from cyx1231st/wip-seastore-ool-metrics

crimson/os/seastore: introduce ool related metrics with misc improvements

Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/common/operation: add UnorderedStage
Samuel Just [Wed, 29 Sep 2021 00:12:18 +0000 (17:12 -0700)]
crimson/common/operation: add UnorderedStage

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/transaction: make for_each_fresh_block const
Samuel Just [Wed, 29 Sep 2021 00:11:49 +0000 (17:11 -0700)]
crimson/os/seastore/transaction: make for_each_fresh_block const

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/segment_cleaner: make used_bytes unsigned
Samuel Just [Tue, 28 Sep 2021 22:01:00 +0000 (22:01 +0000)]
crimson/os/seastore/segment_cleaner: make used_bytes unsigned

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43302 from ronen-fr/wip-rf-osd-psik
Neha Ojha [Tue, 28 Sep 2021 17:01:28 +0000 (10:01 -0700)]
Merge pull request #43302 from ronen-fr/wip-rf-osd-psik

osd: add a missing comma in a list of strings

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
3 years agoMerge pull request #43303 from ronen-fr/wip-rf-osd-modulu
Neha Ojha [Tue, 28 Sep 2021 17:00:02 +0000 (10:00 -0700)]
Merge pull request #43303 from ronen-fr/wip-rf-osd-modulu

osd: fix the truncation of an int by int division

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43132 from p-se/monitoring-grafana-piechart-update
Ernesto Puerta [Tue, 28 Sep 2021 16:37:45 +0000 (18:37 +0200)]
Merge pull request #43132 from p-se/monitoring-grafana-piechart-update

monitoring: update grafana-piechart-panel plugin

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: p-se <NOT@FOUND>
3 years agoMerge PR #43177 into master
Sage Weil [Tue, 28 Sep 2021 14:58:24 +0000 (10:58 -0400)]
Merge PR #43177 into master

* refs/pull/43177/head:
osd/PrimaryLogPG: drop ops when pool has EIO flag
osdc/Objecter: set SUPPORTSPOOLEIO flag on all ops
ceph_test_rados_api_aio: test pool EIO flag
osdc/Objecter: return EIO for new linger ops
osdc/Objecter: return EIO for existing ops and linger ops
osdc/Objecter: return EIO for new ops
osd,mon: add EIO pool flag

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43320 from pdvian/wip-doc-cephx-fixtypo
Kefu Chai [Tue, 28 Sep 2021 14:56:57 +0000 (22:56 +0800)]
Merge pull request #43320 from pdvian/wip-doc-cephx-fixtypo

doc/dev/cephx: fix typo

Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43316 from smithfarm/wip-spdk-tw
Kefu Chai [Tue, 28 Sep 2021 14:49:58 +0000 (22:49 +0800)]
Merge pull request #43316 from smithfarm/wip-spdk-tw

rpm: enable system_pmdk bcond for SUSE builds

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
3 years agoos/bluestore: list obj which equals to pend 43289/head
Kefu Chai [Fri, 24 Sep 2021 15:33:03 +0000 (23:33 +0800)]
os/bluestore: list obj which equals to pend

otherwise we could have failures like

scrub : stat mismatch, got 3/4 objects, 1/2 clones, 3/4 dirty, 3/4 omap, 0/0 pinned, 0/0 hit_set_archive, 0/0 whiteouts, 49/56 bytes, 0/0 manifest objects, 0/0 hit_set_archive bytes."

where the numbers of scrubbed object, clones, dirty and omap are always
less than the total number of corresponding numbers, if the PG contains
object(s) whose hash happens to be 0xffffffff.

in this change, if the calculated hash of the upper bound is greater
than the maximum possible number represented by uint32_t, in addition to
setting the hash of the upper bound hobj to 0xffffffff, we also set the
nspace of hobj of the upper bound to "\xff", so that the upper bound
is greater than an hobj whose hash happens to be 0xfffffff. please note,
the nspace of "\xff" is not an ascii string, so it's not likely to be
less than a real-world nspace of an hobj.

with this new *greater* upper bound, we are able to include the previous
missing hobj when listing the objects in a PG. so the scrub won't be
annoyed when the number of objects does not match.

Fixes: https://tracker.ceph.com/issues/52705
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoos/bluestore: use scope_guard to log latency
Kefu Chai [Wed, 22 Sep 2021 16:42:33 +0000 (00:42 +0800)]
os/bluestore: use scope_guard to log latency

simpler this way, and avoid using `goto`.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
3 years agoMerge pull request #43150 from sebastian-philipp/doc-cephadm-serves-sub-tree
Sebastian Wagner [Tue, 28 Sep 2021 09:20:47 +0000 (11:20 +0200)]
Merge pull request #43150 from sebastian-philipp/doc-cephadm-serves-sub-tree

doc/cephadm: move services under doc/cephadm/services ?

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agomgr/dashboard: Move force maintenance test to the workflow test suite 42821/head
Nizamudeen A [Tue, 17 Aug 2021 16:56:52 +0000 (22:26 +0530)]
mgr/dashboard: Move force maintenance test to the workflow test suite

Fixes: https://tracker.ceph.com/issues/52276
Signed-off-by: Nizamudeen A <nia@redhat.com>
3 years agoMerge pull request #43221 from badone/wip-install-deps-new-pip-resolver
Deepika Upadhyay [Tue, 28 Sep 2021 08:45:41 +0000 (14:15 +0530)]
Merge pull request #43221 from badone/wip-install-deps-new-pip-resolver

install-deps.sh: Use legacy pip resolver

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
3 years agocrimson/os/seastore: introduce ool related metrics with misc improvements 43327/head
Yingxin Cheng [Tue, 28 Sep 2021 07:38:52 +0000 (15:38 +0800)]
crimson/os/seastore: introduce ool related metrics with misc improvements

* The number of ool records written;
* Write overhead from journal/ool records;
* Wasted writes from invalided ool records;
* Wasted writes from erased inline extents;
* Distinguish ool and inline extents from metrics;

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/transaction: count fresh blocks separately
Yingxin Cheng [Tue, 28 Sep 2021 07:10:23 +0000 (15:10 +0800)]
crimson/os/seastore/transaction: count fresh blocks separately

Correct get_num_fresh_blocks() to be accurate under the effect of
delayed allocations.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/transaction: cleanup comments
Yingxin Cheng [Tue, 28 Sep 2021 07:02:54 +0000 (15:02 +0800)]
crimson/os/seastore/transaction: cleanup comments

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore/cache: misc cleanup
Yingxin Cheng [Tue, 28 Sep 2021 06:54:22 +0000 (14:54 +0800)]
crimson/os/seastore/cache: misc cleanup

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: cleanup, consolidate metrics about transactional efforts
Yingxin Cheng [Tue, 28 Sep 2021 06:48:09 +0000 (14:48 +0800)]
crimson/os/seastore: cleanup, consolidate metrics about transactional efforts

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agocrimson/os/seastore: cleanup, reset cache metrics as a whole
Yingxin Cheng [Tue, 28 Sep 2021 06:31:17 +0000 (14:31 +0800)]
crimson/os/seastore: cleanup, reset cache metrics as a whole

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agomgr/cephadm: populate trusted_ip_list in iscsi-gateway.cfg with mgr ips 43246/head
Daniel Pivonka [Tue, 21 Sep 2021 20:04:51 +0000 (16:04 -0400)]
mgr/cephadm: populate trusted_ip_list in iscsi-gateway.cfg with mgr ips

Iscsi gateways do not show "UP" in dashboard without this

fixes: https://tracker.ceph.com/issues/52692
Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>
3 years agomgr/rook, qa/tasks/rook: change rgw daemon service name 43287/head
Joseph Sawaya [Thu, 23 Sep 2021 15:07:23 +0000 (11:07 -0400)]
mgr/rook, qa/tasks/rook: change rgw daemon service name

This commit changes the rgw daemon service name format from
rgw.<realm name>.<zone name> to rgw.<resource_name> and changes the daemon
removal in the QA accordingly. This also gets rid of the Rook API when
describing services.

Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
3 years agomgr/rook: fix placement_spec_to_node_selector
Joseph Sawaya [Wed, 22 Sep 2021 20:49:56 +0000 (16:49 -0400)]
mgr/rook: fix placement_spec_to_node_selector

This commit takes care of the edge case where a completely empty
placement spec is passed to the function.

Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
3 years agomgr/rook: orch rm no longer uses rook api delete
Joseph Sawaya [Wed, 22 Sep 2021 20:46:14 +0000 (16:46 -0400)]
mgr/rook: orch rm no longer uses rook api delete

This commit changes orch rm to no longer use the rook api to delete the daemon
but instead directly delete the corresponding CR using the kubernetes api.

Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
3 years agoqa/tasks/rook: fix cluster deletion hanging due to CephObjectStore CR
Joseph Sawaya [Tue, 21 Sep 2021 13:41:28 +0000 (09:41 -0400)]
qa/tasks/rook: fix cluster deletion hanging due to CephObjectStore CR

This commit fixes the issue where the cluster deletion hangs in the QA
while a CephObjectStore CR is still up by removing all rgw/nfs/mds/rbd-mirror
daemons before tearing down the rest of the cluster.

Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
3 years agomgr/rook: use default replication size in orch apply rgw
Joseph Sawaya [Tue, 7 Sep 2021 13:06:08 +0000 (09:06 -0400)]
mgr/rook: use default replication size in orch apply rgw

This commit changes `orch apply rgw` to use the osd_pool_default_size
when setting the replication size for the data pool and metadata pool
of the rgw daemon. This commit also adds `orch apply rgw` to the Rook
QA.

Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
3 years agomgr/rook: add placement specs to apply rgw
Joseph Sawaya [Fri, 3 Sep 2021 19:47:54 +0000 (15:47 -0400)]
mgr/rook: add placement specs to apply rgw

This commit adds the placement spec option when creating
a CephObjectStore using `orch apply rgw`.

Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
3 years agoosd/PrimaryLogPG: drop ops when pool has EIO flag 43177/head
Sage Weil [Wed, 15 Sep 2021 23:12:38 +0000 (19:12 -0400)]
osd/PrimaryLogPG: drop ops when pool has EIO flag

If the op doesn't have the SUPPORTSPOOLEIO flag (i.e., it is an old client),
return with an explicit EIO.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoosdc/Objecter: set SUPPORTSPOOLEIO flag on all ops
Sage Weil [Wed, 15 Sep 2021 23:12:04 +0000 (19:12 -0400)]
osdc/Objecter: set SUPPORTSPOOLEIO flag on all ops

This tells us the client understands the pool EIO flag, without having to
burn a feature bit.

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoceph_test_rados_api_aio: test pool EIO flag
Sage Weil [Wed, 15 Sep 2021 23:06:27 +0000 (19:06 -0400)]
ceph_test_rados_api_aio: test pool EIO flag

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agomgr/cephadm: remove cephadm exporter code 43321/head
Adam King [Mon, 27 Sep 2021 16:05:14 +0000 (12:05 -0400)]
mgr/cephadm: remove cephadm exporter code

It's functionality has been effectively replaced by the cephadm agent

Signed-off-by: Adam King <adking@redhat.com>
3 years agocephadm: fix iscsi test 43319/head
Guillaume Abrioux [Mon, 27 Sep 2021 15:22:48 +0000 (17:22 +0200)]
cephadm: fix iscsi test

the current test is wrong because it generates the tcmu-runner part two
times.
given the function `deploy_daemon_units()` in cephadm already writes a
first time the tcmu-runner command, calling a second time
`get_tcmu_runner_container()` from the test makes `deploy_daemon_units()`
write the same command again.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agomon/OSDMonitor: Make the pg_num check more accurate 39062/head
jerryluo [Mon, 25 Jan 2021 16:10:57 +0000 (00:10 +0800)]
mon/OSDMonitor: Make the pg_num check more accurate

In check_pg_num function, finding the corresponding osd according to the
current pool's crush rule, and calculating whether the average value of
pg_num on these osd will exceed the value of 'mon_max_pg_per_osd'. Make
the pg_num check more accurate by counting all the pgs on the osd used
by the new pool.

Fixes: https://tracker.ceph.com/issues/47062
Signed-off-by: Jerry Luo <luojierui@chinatelecom.cn>
3 years agodoc/dev/cephx: fix typo 43320/head
Prashant D [Mon, 27 Sep 2021 12:37:31 +0000 (13:37 +0100)]
doc/dev/cephx: fix typo

Signed-off-by: Prashant D <pdhange@redhat.com>
3 years agoMerge pull request #43285 from rhcs-dashboard/api-endpoint-version-compatibility
Ernesto Puerta [Mon, 27 Sep 2021 12:13:07 +0000 (14:13 +0200)]
Merge pull request #43285 from rhcs-dashboard/api-endpoint-version-compatibility

mgr/dashboard: make modified API endpoints backward compatible

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
3 years agocephadm: modify iscsi containers bindmount
Guillaume Abrioux [Mon, 27 Sep 2021 11:46:01 +0000 (13:46 +0200)]
cephadm: modify iscsi containers bindmount

tcmu-runner logs in `/var/log/tcmu-runner.log`, there's no option to
make it log to stdout/stderr so the log is only available from the
container.
Modifying the bindmount from `-v /var/log/ceph/<fsid>/:/var/log/rbd-target-api:z`
to `-v /var/log/ceph/<fsid>/:/var/log:z` makes it at least available
from the host.

Fixes: https://tracker.ceph.com/issues/47480
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agodoc/cephadm: move services into services/ 43150/head
Sebastian Wagner [Mon, 13 Sep 2021 15:15:33 +0000 (17:15 +0200)]
doc/cephadm: move services into services/

This is going to clean up the toctree a bit.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agodoc/cephadm: move service-management to services/index.rst
Sebastian Wagner [Mon, 13 Sep 2021 15:12:01 +0000 (17:12 +0200)]
doc/cephadm: move service-management to services/index.rst

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3 years agoMerge pull request #43160 from sebastian-philipp/doc-spec-networks
Sebastian Wagner [Mon, 27 Sep 2021 10:19:17 +0000 (12:19 +0200)]
Merge pull request #43160 from sebastian-philipp/doc-spec-networks

doc/cephadm: Add networks to spec documentation

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
3 years agorpm: enable system_pmdk bcond for SUSE builds 43316/head
Nathan Cutler [Mon, 27 Sep 2021 10:05:45 +0000 (12:05 +0200)]
rpm: enable system_pmdk bcond for SUSE builds

ecb8d2cae2c063acf4e7e1bffed887d52117762f disabled the system_pmdk bcond for all
build targets based on the fact that pmdk 1.10 was not available on any of them.

Now that openSUSE Tumbleweed ships pmdk 1.11, we re-enable the system_pmdk bcond
to fix the master build for openSUSE Tumbleweed.

Since openSUSE Tumbleweed is the *only* SUSE build target master supports, there
is no need for greater granularity in the distro conditional here.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
3 years agocephadm/iscsi: fix a typo 43309/head
Guillaume Abrioux [Mon, 27 Sep 2021 06:57:35 +0000 (08:57 +0200)]
cephadm/iscsi: fix a typo

This commit fixes a typo in the comment of unit.run of iscsi service.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
3 years agoMerge pull request #43276 from lxbsz/fix_typo
Venky Shankar [Mon, 27 Sep 2021 06:30:11 +0000 (12:00 +0530)]
Merge pull request #43276 from lxbsz/fix_typo

mds: fix typo in the comments and log when setting new loner

Reviewed-by: Venky Shankar <vshankar@redhat.com>
3 years agoMerge pull request #43301 from athanatos/sjust/wip-seastore-fixes-2021-09-24
Samuel Just [Mon, 27 Sep 2021 05:04:18 +0000 (22:04 -0700)]
Merge pull request #43301 from athanatos/sjust/wip-seastore-fixes-2021-09-24

crimson/os/seastore/.../btree_range_pin: fix is_parent_of

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
3 years agoMerge pull request #43291 from badone/wip-missing-hostname-dependency
Brad Hubbard [Mon, 27 Sep 2021 04:21:14 +0000 (14:21 +1000)]
Merge pull request #43291 from badone/wip-missing-hostname-dependency

rpm, debian: We depend on 'hostname'

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agorpm, debian: Add hostname as a "make check" dependency 43291/head
Brad Hubbard [Fri, 24 Sep 2021 02:15:53 +0000 (12:15 +1000)]
rpm, debian: Add hostname as a "make check" dependency

test_hostname.cc depends on the hostname binary.

Fixes: https://tracker.ceph.com/issues/52695
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
3 years agoMerge pull request #43191 from ronen-fr/wip-rf-scrub-locations
Ronen Friedman [Sun, 26 Sep 2021 17:33:49 +0000 (20:33 +0300)]
Merge pull request #43191 from ronen-fr/wip-rf-scrub-locations

osd/scrub: collecting scrub-related files into a separate directory

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
3 years agoMerge pull request #43304 from inspur-wyq/wip-doc-3
Kefu Chai [Sun, 26 Sep 2021 13:55:57 +0000 (21:55 +0800)]
Merge pull request #43304 from inspur-wyq/wip-doc-3

doc/rbd/rbd-windows.rst: fix typos

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoosd/scrub: collecting scrub-related files into a separate directory 43191/head
Ronen Friedman [Sun, 11 Apr 2021 18:17:41 +0000 (21:17 +0300)]
osd/scrub: collecting scrub-related files into a separate directory

Cleaning src/osd from scrub implementation files. Triggered by:
- the matching Crimson scrub structure;
- the proliferation of scrub related code files (inc. in coming PRs);

scrubber_common.h, which defines the scrubber's interface, remains
in src/osd.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #40984 from ronen-fr/wip-ronenf-scrub-sched
Ronen Friedman [Sun, 26 Sep 2021 11:59:49 +0000 (14:59 +0300)]
Merge pull request #40984 from ronen-fr/wip-ronenf-scrub-sched

osd/scrub: extracting scrub scheduling code from OSD.cc

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
3 years agoMerge pull request #43220 from idryomov/wip-keyring-resolve-error
Ilya Dryomov [Sun, 26 Sep 2021 10:09:43 +0000 (12:09 +0200)]
Merge pull request #43220 from idryomov/wip-keyring-resolve-error

auth,mon: don't log "unable to find a keyring" error when key is given

Reviewed-by: Kefu Chai <kchai@redhat.com>
3 years agoMerge pull request #43207 from idryomov/wip-full-try-regressions
Ilya Dryomov [Sun, 26 Sep 2021 10:07:06 +0000 (12:07 +0200)]
Merge pull request #43207 from idryomov/wip-full-try-regressions

librados,neorados,librbd: fix FULL_TRY handling regressions

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
3 years agomgr/dashboard: replace string version with class 43285/head
Ernesto Puerta [Fri, 24 Sep 2021 15:46:42 +0000 (17:46 +0200)]
mgr/dashboard: replace string version with class

* APIVersion:
  * Moved to a separate file
  * Added doctests
  * Added sentinel values:
    * DEFAULT = 1.0
    * EXPERIMENTAL = 0.1
    * NONE = 0.0
  * Added to_mime_type() helper method
* Controllers.__init__:
  * Added type hints
  * Replaced string versions with APIVersions
* Feedback controller:
  * Replaced with EXPERIMENTAL (probably it should be NONE)

Fixes: https://tracker.ceph.com/issues/52480
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 years agoosd: fix the truncation of an int by int division 43303/head
Ronen Friedman [Sat, 25 Sep 2021 11:42:56 +0000 (11:42 +0000)]
osd: fix the truncation of an int by int division

The 'r' coeff calculated in OSD::tick() was always 0.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoosd: add a missing comma in a list of strings 43302/head
Ronen Friedman [Sat, 25 Sep 2021 09:13:09 +0000 (09:13 +0000)]
osd: add a missing comma in a list of strings

One of OSD::get_tracked_conf_keys() keys was missing
a terminating ','

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
3 years agoMerge pull request #43228 from idryomov/wip-rbd-mirror-snapshot-rx-only
Ilya Dryomov [Sat, 25 Sep 2021 08:58:17 +0000 (10:58 +0200)]
Merge pull request #43228 from idryomov/wip-rbd-mirror-snapshot-rx-only

rbd-mirror: unbreak one-way snapshot-based mirroring

Reviewed-by: Mykola Golub <mgolub@suse.com>
3 years agomds: fix the set loner log 43276/head
Xiubo Li [Sat, 25 Sep 2021 08:56:39 +0000 (16:56 +0800)]
mds: fix the set loner log

Once here the current loner has already been dropped if there has,
and the get_wanted_loner() is the new loner it trying to set to.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
3 years agomds: fix typo in the comments
Xiubo Li [Tue, 10 Aug 2021 07:06:54 +0000 (15:06 +0800)]
mds: fix typo in the comments

Signed-off-by: Xiubo Li <xiubli@redhat.com>
3 years agocrimson/os/seastore/.../btree_range_pin: fix is_parent_of 43301/head
Samuel Just [Sat, 25 Sep 2021 00:10:43 +0000 (17:10 -0700)]
crimson/os/seastore/.../btree_range_pin: fix is_parent_of

The LBA tree implementation only requires that the start addr of
a logical extent be contained within the leaf range.  It's entirely
possible for the end of a logical extent to extend past the end addr
of the containing leaf node.

Fixes: https://tracker.ceph.com/issues/52709
Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agocrimson/os/seastore/transaction_manager: whitespace cleanup submit_transaction_direct
Samuel Just [Thu, 23 Sep 2021 09:07:35 +0000 (02:07 -0700)]
crimson/os/seastore/transaction_manager: whitespace cleanup submit_transaction_direct

Signed-off-by: Samuel Just <sjust@redhat.com>
3 years agoosdc/Objecter: return EIO for new linger ops
Sage Weil [Wed, 15 Sep 2021 23:06:11 +0000 (19:06 -0400)]
osdc/Objecter: return EIO for new linger ops

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoosdc/Objecter: return EIO for existing ops and linger ops
Sage Weil [Wed, 15 Sep 2021 23:06:02 +0000 (19:06 -0400)]
osdc/Objecter: return EIO for existing ops and linger ops

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoosdc/Objecter: return EIO for new ops
Sage Weil [Wed, 15 Sep 2021 23:05:35 +0000 (19:05 -0400)]
osdc/Objecter: return EIO for new ops

Signed-off-by: Sage Weil <sage@newdream.net>
3 years agoosd,mon: add EIO pool flag
Sage Weil [Tue, 14 Sep 2021 19:08:24 +0000 (15:08 -0400)]
osd,mon: add EIO pool flag

Signed-off-by: Sage Weil <sage@newdream.net>